1 2007-08-13 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.c:
4 (create_page_incoming), (create_page_outgoing): Use a define
5 for the min and max port numbers.
7 (check_hildon_number_editor_and_warn_value_not_in_range),
8 (check_data): Do an extra check for an invalid port number, as needed
9 in projects.maemo.org bug #64275, when the number is cleared, but this
10 does not work due to bugs.maemo.org bug #1806.
12 2007-08-13 Murray Cumming <murrayc@murrayc.com>
14 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
15 Comment out the debug warning about the unexpected D-Bus methods.
16 They are just annoying now.
17 * src/maemo/modest-platform.c:
18 (modest_platform_set_update_interval): Correct the D-Bus path, instead
19 of using a file path, though it did not seem to break things before.
20 It might be needed now:
21 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
22 modest is not already running. This is the behaviour of the old client, and
23 Mox says it is what we should do for modest.
24 This closes projects.maemo.org bug NB#64327.
26 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
28 * src/modest-text-utils.c:
29 Fixed invalid jump due to incorrect string/pointer
31 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
34 2007-08-01 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-account-mgr-helpers.h:
37 * src/modest-account-mgr-helpers.c:
38 Added modest_account_mgr_get_first_account_name(),
39 using code from modest_account_mgr_set_first_account_as_default().
41 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
42 (account_number_changed): Call set_at_least_one_account_visible() so that
43 the first account is visible when first added, without the user having to
45 I do wonder how this worked before.
47 2007-08-01 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-tny-account-store.c: (show_password_warning_only),
50 (show_wrong_password), (request_password_and_wait), (get_password),
51 (modest_tny_account_store_alert): Remove the (incomplete anyway)
52 attempts to show UI only in the main context, which used g_idle_add()
53 and mainloops, because tinymail now guarantees that it only calls these
54 callbacks in the mainloop with the gdk lock. This makes everything much
57 2007-08-01 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
60 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
61 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
62 error dialog, instead of ignoring it.
64 2007-08-01 Murray Cumming <murrayc@murrayc.com>
66 * src/maemo/modest-msg-view-window.c:
67 (modest_msg_view_window_get_header),
68 (modest_msg_view_window_last_message_selected):
69 Added comments to explain the use of priv->header_model.
70 * src/modest-ui-dimming-rules.c:
71 (modest_ui_dimming_rules_on_open_msg),
72 (modest_ui_dimming_rules_on_mark_as_read_msg),
73 (modest_ui_dimming_rules_on_mark_as_unread_msg),
74 (modest_ui_dimming_rules_on_remove_attachments),
75 (_invalid_attach_selected), (_selected_msg_marked_as):
76 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
77 and changed the parameter to a ModestMainWindow to make it clearer that
78 it never uses any other kind of window.
79 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
80 instead of the selected message.
81 I notice that much of the dimming code and the ModestMsgViewWindow code
82 hard-codes the assumption that the viewed message is always selected in
83 the header view. This does not seem wise or simple.
85 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
86 examine the actual message instead of whatever might be selected
87 in the header view. This stops the delete toolbar button and menu item
88 from being dimmed when opening a message view the search UI,
89 partially fixing projects.maemo.org bug NB#63811.
91 However, when actually deleting, I now get this warning:
92 "tny_header_set_flags: This is a header instance for a new message.
93 Only priority and attachment flags are supported"
95 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
97 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
99 Show account wizard if no accounts are defined while sending
100 (automatic sending after the account wizard finished does not
101 work because it takes some time until the account manager
102 synchronizes everything. (projects.maemo.org NB#62792)
104 2007-07-30 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-tny-account-store.c: (on_account_removed),
107 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
108 account is removed from the View menu. We have TnyAccountStore
109 and ModestTnyAccountStore signals that seem very similar, but this
110 seems to work for now.
112 * src/maemo/modest-main-window.c:
113 (on_show_account_action_activated): Prevent dereference
114 of a NULL if the accoutn does not really exist, though that
115 should not happen anymore.
117 This fixes projects.maemo.org bug NB#64606.
119 2007-07-30 Murray Cumming <murrayc@murrayc.com>
121 * src/modest-ui-actions.c: (run_account_setup_wizard),
122 (modest_ui_actions_on_accounts): Revert a change that set these
123 to modal dialogs, freezing the UI when they show secondary dialogs.
124 This fixed projects.maemo.org bug NB#64519.
126 2007-07-27 Murray Cumming <murrayc@murrayc.com>
128 * src/widgets/modest-header-view-render.c:
129 (_modest_header_view_compact_header_cell_data):
130 Some checks and initialization to try to deal with a crash,
131 probably ineffective.
133 2007-07-27 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/modest-maemo-utils.c:
136 (modest_maemo_utils_get_supported_secure_authentication_methods):
137 Make sure that we have a connection, asking the user for one
139 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
140 Check for a connection before showing the wizard, because
141 the wizard needs a connection to check for server capabilities.
143 2007-07-27 Murray Cumming <murrayc@murrayc.com>
145 * src/maemo/modest-account-view-window.c:
146 (on_new_button_clicked): Remember the wizard dialog instance,
147 so we can just present it again if necessary. This prevents
148 multiple windows from appearing if you click again quickly on the
149 New button before the dialog appears, fixing projects.maemo.org
152 2007-07-27 Murray Cumming <murrayc@murrayc.com>
154 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
155 Offer a connection dialog if there is no connection when
156 starting modest. This should fix projects.maemo.org bug NB#61134.
158 2007-07-27 Murray Cumming <murrayc@murrayc.com>
160 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
161 Reverted my last commit. I was able to fix the build by doing
162 apt-get install wpeditor0 (replacing other wpeditor packages) and
163 an explicit apt-get install wpeditor-dev to upgrade the -dev
166 2007-07-27 Murray Cumming <murrayc@murrayc.com>
168 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
169 Commented out the use of wp_text_buffer_replace_image()
170 because it does not exist, to break the build. Added a TODO for it.
172 2007-07-26 Murray Cumming <murrayc@murrayc.com>
174 * src/modest-tny-account-store.c: (recreate_all_accounts):
175 Recreate them even if they were NULL before. I guess something
176 else was already creating them before, or this would never
178 (modest_tny_account_store_get_server_account): Make sure that
179 the tny accounts have been created before trying to find one.
180 This allows libmodest_dbus_client_compose_mail() to work
181 when the UI is not yet visible.
182 This is probably useful in other cases too.
184 (get_password): When the password is wrong after it is entered
185 in the protected password dialog, show an info banner (in an
186 idle handler) before showing the protected password dialog
189 2007-07-26 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-ui-actions.h:
192 * src/modest-ui-actions.c: Added
193 modest_do_refresh_current_folder() containing some code from
194 modest_ui_actions_on_send_receive().
195 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
196 Call modest_do_refresh_current_folder() before refreshing the
197 requested account, as in modest_ui_actions_on_send_receive().
198 This is strange, but seems to be necessary to show new mails.
199 Now new emails are finally visible in the UI when downloaded
200 via the automatic update interval, fixing bug NB#57458.
201 This also works because bug NB#57458 has been fixed somehow.
203 2007-07-26 Murray Cumming <murrayc@murrayc.com>
205 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
206 printf more details when we get unhandled D-Bus methods, because
209 * src/modest-mail-operation.c: (update_account_thread):
210 Comment out the tny_camel_pop_store_account_reconnect(), because this
211 is apparently no longer needed, and it did not work before anyway.
212 See the comment in the code.
214 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
215 by checking the header flags. This fixes projects.maemo.org bug
218 2007-07-25 Murray Cumming <murrayc@murrayc.com>
220 * src/maemo/modest-maemo-utils.h:
221 * src/maemo/modest-maemo-utils.c: Added
222 modest_maemo_show_information_note_in_main_context_and_forget().
223 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
224 Use the new function to show simple error dialogs in the main
225 context, though question dialogs are still in the current context,
226 which is unfortunately usually not the main context. This should
229 2007-07-25 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-tny-account-store.c: (get_password):
232 Never save the entered username and password in gconf,
233 because the UI spec says we should not. This helps
234 slightly with projects.maemo.org bug NB#63671.
236 2007-07-25 Murray Cumming <murrayc@murrayc.com>
238 * src/widgets/modest-msg-edit-window.h:
239 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
240 Moved some code here to make it simpler.
241 (modest_msg_edit_window_attach_file_one): Renamed from
242 modest_msg_edit_window_attach_file_interactive().
243 (modest_msg_edit_window_offer_attach_file): Renamed from
244 modest_msg_edit_window_attach_file() and used
245 modest_msg_edit_window_attach_file_one() instead of
246 copy/pasting the code. The old code for one was not using
247 GnomeVFS. This allows use of smb:// URLs when using send-as
248 from external applications, fixing bug NB#63741.
250 (modest_msg_edit_window_insert_image),
251 (modest_msg_edit_window_add_attachment_clicked):
252 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
253 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
254 Adapted to the new function names.
256 2007-07-25 Murray Cumming <murrayc@murrayc.com>
258 (modest_platform_set_update_interval): Set the alarm recurrence
259 fields so that auto-update does not just happen the first time.
260 This should have fixed projects.maemo.org bug NB#63938.
262 When this happens you can see a printf when the D-Bus method is
264 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
266 However, I do not actually seem to get new POP messages even when
267 clicking the refresh button manually. A restart gets them.
268 This might be a problem in today's tinymail only.
270 2007-07-24 Murray Cumming <murrayc@murrayc.com>
272 * src/maemo/modest-maemo-global-settings-dialog.c:
273 (current_connection):
274 Avoid a crash (probably only in scratchbox) when strcmp()ing a
275 NULL when closing the dialog.
277 2007-07-24 Murray Cumming <murrayc@murrayc.com>
279 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
280 Remove the hacky send/receive that didn't work, and instead
281 refilter the treemodel to make the deleted email really vanish from
282 the UI (though the delete-from-menu code does has commented out
283 the code that does that). This fixes projects.maemo.org bug
286 2007-07-24 Murray Cumming <murrayc@murrayc.com>
288 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
289 Try a couple of tricks to force the treeview to update (
290 poke the folder, and do a send/receive refresh), but the deleted
291 email still appears with a strike-through instead of really being
294 2007-07-23 Murray Cumming <murrayc@murrayc.com>
296 * src/dbus_api/modest-dbus-callbacks.c:
297 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
298 because their ID is not human-readable (see the comment about
299 improvements needed to the osso-email-interface API) and
300 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
302 2007-07-23 Murray Cumming <murrayc@murrayc.com>
304 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
305 (add_folders_to_list), (on_dbus_method_get_folders),
306 (modest_dbus_req_filter):
307 * src/maemo/modest-maemo-utils.c:
308 (on_camel_account_get_supported_secure_authentication):
309 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
310 (on_header_view_focus_in):
311 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
312 * src/modest-formatter.c: (modest_formatter_create_body_part):
313 * src/modest-mail-operation.c: (recurse_folders),
314 (update_account_thread), (get_msgs_full_thread),
315 (modest_mail_operation_get_msgs_full),
316 (modest_mail_operation_xfer_msgs):
317 * src/modest-search.c: (search_mime_part_and_child_parts),
318 (modest_search_account), (modest_search_all_accounts):
319 * src/modest-tny-account.c:
320 (modest_tny_account_get_special_folder), (recurse_folders):
321 * src/modest-tny-local-folders-account.c:
322 (modest_tny_local_folders_account_query_passes):
323 * src/modest-tny-msg.c: (copy_mime_part),
324 (modest_tny_msg_find_body_part_from_mime_part):
325 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
326 (modest_tny_send_queue_try_to_send):
327 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
328 (_modest_ui_actions_open), (download_uncached_messages),
329 (reply_forward), (modest_ui_actions_on_copy),
330 (modest_ui_actions_on_details), (has_retrieved_msgs),
331 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
333 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
334 (_selected_msg_marked_as), (_msg_download_completed),
335 (_selected_msg_sent_in_progress):
336 * src/widgets/modest-attachments-view.c:
337 (modest_attachments_view_set_message):
338 * src/widgets/modest-msg-view.c: (find_cid_image):
339 * tests/check_folder-transfer.c: (find_folders):
340 * tests/check_update-account.c: (func):
341 * tests/dbus_api/test_get_folders.c: (main):
342 Checked all uses of tny_iterator_get_current(), making sure
343 that the object is unreferenced (3 or 4 places did not),
344 and adding checks for NULL.
346 2007-07-23 Murray Cumming <murrayc@murrayc.com>
348 * src/dbus_api/modest-dbus-callbacks.c:
349 (on_idle_open_default_inbox): Make sure that the application UI is
351 * src/maemo/easysetup/modest-easysetup-wizard.c:
352 (on_entry_invalid_character): Show the word whitespace instead
353 of (null) in the banner when whitespace was entered.
354 (show_error): Add a comment that this does not work in
355 Maemo Bora, though we do not know why.
357 2007-07-23 Murray Cumming <murrayc@murrayc.com>
359 * src/modest-tny-account.c:
360 (modest_tny_account_get_special_folder): Use an if instead of
361 an assert for when the parent account name is NULL, because this
362 might be causing a crash in projects.maemo.org bug 63192.
363 * src/modest-mail-operation.c:
364 (modest_mail_operation_send_new_mail_cb),
365 (modest_mail_operation_remove_folder): unref the folder that is
366 returned from modest_tny_account_get_special_folder().
368 2007-07-23 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-ui-actions.c:
371 (modest_ui_actions_on_password_requested):
372 Show mail_ib_login_cancelled info banner when the user cancels
373 the protected password dialog, to fix projects.maemo.org
376 2007-07-23 Murray Cumming <murrayc@murrayc.com>
378 * src/maemo/modest-account-settings-dialog.c:
379 (create_page_outgoing): Put this page in a GtkScrolledWindow,
380 matching the UI mock-up in the UI spec, and allowing access
381 to all widgets even when the on-screen keyboard is active.
383 2007-07-23 Murray Cumming <murrayc@murrayc.com>
385 Reverted this previous commit from Johannes,
386 because the scrollbars are always visible and because
387 I think we only need it on onepage of the account
388 settings, not the account wizard.
389 (I wrote the wrong instructions in the bug.)
391 * src/maemo/easysetup/modest-easysetup-wizard.c:
392 Added scrollbars to account wizard dialog.
393 Fixed projects.maemo.org NB #62744
395 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
397 * src/maemo/easysetup/modest-easysetup-wizard.c:
398 (create_page_user_details):
399 Use auto-cap for name (projects.maemo.org NB#63716)
400 * src/widgets/modest-account-view.c: (on_account_busy_changed):
402 2007-07-22 Armin Burgmeier <armin@openismus.com>
404 * src/maemo/modest-ui-actions.c: Use current account instead of
405 default account for creating viewer windows, so that the viewer
406 window knows to which account the viewed message belongs.
408 * src/maemo/modest-msg-view-window.c: Destroy the window when the
409 corresponding account is deleted. This fixes projects.maemo.org bug
412 2007-07-18 Armin Burgmeier <armin@openismus.com>
414 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
415 the dialog close after entering an invalid port number and clicking
416 OK. This fixes projects.maemo.org bug NB#63602.
418 2007-07-18 Armin Burgmeier <armin@openismus.com>
420 * src/modest-tny-account-store.c:
421 (get_server_accounts): Set parent modest account name for each
422 connection-specific transport account so that special folders of such
423 an account can be looked up. This fixes a crash when changing account
424 settings. This might also be related to projects.maemo.org bug
427 2007-07-16 Armin Burgmeier <armin@openismus.com>
429 * src/modest-ui-actions.c: Added a button to create a folder to the
430 move-to dialog. This fixes projects.maemo.org bug NB#.
432 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
434 * src/maemo/easysetup/modest-easysetup-wizard.c:
435 Added scrollbars to account wizard dialog.
436 Fixed projects.maemo.org NB #62744
438 2007-07-16 Murray Cumming <murrayc@murrayc.com>
440 * src/widgets/modest-msg-view.h:
441 * src/widgets/modest-msg-view.c:
442 Added modest_msg_view_get_message_is_empty() but this needs
444 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
445 Check if there is any text in the message yet.
446 But this needs to be implemented properly.
447 (modest_msg_edit_window_toggle_find_toolbar):
448 * src/maemo/modest-msg-view-window.c:
449 (modest_msg_view_window_toggle_find_toolbar):
450 Show a banner warning if there is no text to search, when
451 trying to start a search. This partially fixes
452 projects.maemo.org bug NB#62350.
454 2007-07-13 Murray Cumming <murrayc@murrayc.com>
456 * src/modest-mail-operation.c: (update_account_thread):
457 Initialized num_new_headers to fix the build.
459 2007-07-13 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
462 Ignore modest accounts whose server accounts don't exist in gconf.
463 This prevents us trying to create TnyAccount instances for those
464 server accounts when the server account has been removed from gconf,
465 but the parent modest account has not yet been removed from modest.
466 I don't know why this is only noticeable now. It was probably just
467 a harmeless g_warning() anyway.
469 2007-07-13 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
472 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
474 2007-07-12 Armin Burgmeier <armin@openismus.com>
476 * src/maemo/modest-main-window.c: Make default account appear bold
477 in view, tools/send & receive and toolbar/send & receive SCM menus.
478 This fixes projects.maemo.org bug NB#59010.
480 2007-07-12 Murray Cumming <murrayc@murrayc.com>
482 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
483 Add a short-cut, by checking if the folder store is an account.
484 This ensures that the Sort menu item and toolbar is dimmed for
485 the local-folders account root item, fixing
486 projects.maemo.org bug NB#62545.
488 2007-07-12 Murray Cumming <murrayc@murrayc.com>
490 * src/modest-tny-account-store.c: (get_password):
491 Show the password dialog (via the signal) only in the mainloop, via
492 an idle handler that we wait for. This could theoretically prevent
493 hangs, though I worry that it could introduce some too.
495 2007-07-12 Murray Cumming <murrayc@murrayc.com>
497 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
498 * src/maemo/modest-platform.c:
499 (modest_platform_connect_and_wait):
500 Take a TnyAccount* parameter and try to set it to online
501 (a TnyCamel-only API), because tinymail sets accounts to offline
502 when the user cancels a password dialog, and doesn't ask again until
503 it has been set to online.
504 However, this is commented out because it causes a hang now.
506 (modest_platform_connect_and_wait_if_network_account):
507 * src/modest-mail-operation.c:
508 (modest_mail_operation_update_account):
509 * src/modest-platform.h:
510 * src/modest-ui-actions.c: (_modest_ui_actions_open),
511 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
513 2007-07-12 Armin Burgmeier <armin@openismus.com>
515 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
517 * src/modest-mail-operation.c:
518 * src/modest-ui-actions.c: Check for already existing folder before
519 querying the server, show error message from camel if the request
520 still fails. This fixes projects.maemo.org bug NB#58701.
522 2007-07-12 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-tny-account-store.h:
525 * src/modest-tny-account-store.c:
526 Added modest_tny_account_store_forget_password_in_memory(),
527 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
528 when creating a new account, so that new passwords will be used, instead of
529 us thinking that it's a second request as a result of a failed password again.
531 2007-07-12 Murray Cumming <murrayc@murrayc.com>
533 * src/dbus_api/modest-dbus-callbacks.c:
534 (on_idle_open_message): If the message is in drafts then open it
535 in an edit window instead of a view window. This fixes
536 projects.maemo.org bug NB#63005.
538 2007-07-12 Murray Cumming <murrayc@murrayc.com>
540 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
541 Avoided a harmless g_warning().
543 2007-07-12 Murray Cumming <murrayc@murrayc.com>
545 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
546 Pass the modest account name, not the TnyAccount display name to
547 modest_msg_view_window_new() so that the reply feature works,
548 fixing projects.maemo.org bug NB#62892.
550 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
551 (modest_msg_view_window_new_with_header_model):
552 * src/maemo/modest-msg-view-window.c:
553 (modest_msg_view_window_new_with_header_model),
554 (modest_msg_view_window_new):
555 * src/modest-ui-actions.c: (reply_forward):
556 * src/widgets/modest-msg-view-window.h:
557 * src/widgets/modest-window.c: (modest_window_set_active_account):
558 Rename an account parameter to modest_account_name to make this clearer.
560 2007-07-11 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-ui-actions.h:
563 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
564 modest_do_message_delete().
565 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
566 Call modest_do_message_delete(), hoping that this would cause messages
567 to be really deleted from search instead of just marked with strike through.
568 Does not seem to help.
570 2007-07-11 Armin Burgmeier <armin@openismus.com>
572 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
573 priv->reselect to FALSE prior to calling
574 modest_folder_view_select_first_inbox_or_local() to prevent endless
575 recursion and thus a crash on startup.
577 2007-07-11 Armin Burgmeier <armin@openismus.com>
579 * src/maemo/modest-account-settings-dialog.h: Include
580 <gtk/gtknotebook.h> to fix the build (at least for me).
582 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
583 Use "New FolderN" as default suggested name if "New folder" already
584 exists, with N being the first free number, though never exceed "New
585 folder99" in which case we just fall back to "New Folder" even though
586 it already exists. This fixes projects.maemo.org bug NB#58663.
588 2007-07-11 Murray Cumming <murrayc@murrayc.com>
590 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
591 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
592 projects.maemo.org bug NB#62778.
594 2007-07-11 Murray Cumming <murrayc@murrayc.com>
596 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
597 Ignore the wrong (for now) secure-smtp setting in the presets -
598 just default to requiring secure authentication for SMTP, because
601 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
603 * src/widgets/modest-folder-view.c: (filter_row)
604 Do not show drafts folder (see UI specs)
606 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
608 * src/modest-ui-actions.c:
609 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
610 place and also not necessary.
612 * src/widgets/modest-folder-view.c: (filter_row)
613 Guess folder type and hide Sent & Outbox if necessary.
614 Fixed project.maemo.org NB#57328
616 2007-07-11 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-ui-actions.h:
619 * src/modest-ui-actions.c:
620 (modest_ui_actions_on_delete_message):
621 Move some code into a new
622 modest_ui_actions_refresh_message_window_after_delete()
623 function so we can use it from elsewhere.
625 * src/dbus_api/modest-dbus-callbacks.c:
626 (on_idle_delete_message), (on_delete_message): Used an idle
627 handler, as we do for the other D-Bus method handlers.
628 Call modest_ui_actions_refresh_message_window_after_delete()
629 if the deleted message was open in a window. This fixed
630 projects.maemo.org bug NB#62862.
632 2007-07-11 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-main.c: (main): Only show the UI at the start if
635 the showui command line option was given. For instance,
636 run-standalone src/modest showui
637 Otherwise, we wait for the top_application D-Bus method to
638 be sent by hildon-desktop when the application is selected
640 This allows us to run without a UI when osso-global-search
641 uses our D-Bus methods.
643 2007-07-11 Murray Cumming <murrayc@murrayc.com>
645 * src/dbus_api/modest-dbus-api.h: Added a define for a
646 top-application D-Bus method.
647 * src/dbus_api/modest-dbus-callbacks.c:
648 (on_top_application),
649 (modest_dbus_req_handler): Handle the top-application D-Bus
650 method, which might be an undocumented D-Bus signal sent by
651 hildon-desktop when it starts the application from the menu.
652 But I am not sure and I need to test it on the device, because
653 my scratchbox does not have the application in the menu now.
654 This method shows the main window, so that it can be invisible
655 when started, for instance, just for email searching from
658 * src/maemo/modest-main-window.c: (restore_settings),
659 (modest_main_window_new): Do not show the window immediately
660 upon creation. We show it later.
661 * src/modest-widget-memory.c: (save_settings_paned):
662 Try (unsuccessfully) to avoid saving the paned position when
663 it is not even visible.
664 (restore_settings_paned): Do not allow a silly paned position.
665 This seems necessary when not showing the window at first.
667 * tests/dbus_api/Makefile.am:
668 * tests/dbus_api/test_top_application.c: (main): Test for the
671 2007-07-10 Murray Cumming <murrayc@murrayc.com>
673 * src/modest-ui-dimming-rules.c:
674 (modest_ui_dimming_rules_on_new_msg),
675 (modest_ui_dimming_rules_on_reply_msg),
676 (modest_ui_dimming_rules_on_delete_msg),
677 (modest_ui_dimming_rules_on_details),
678 (modest_ui_dimming_rules_on_view_window_move_to),
679 (modest_ui_dimming_rules_on_view_previous),
680 (modest_ui_dimming_rules_on_view_next),
681 (_invalid_folder_for_purge): Added checks before
682 casting the window. This looks like an actual
683 logic error in _invalid_folder_for_purge(), because it
684 tries to use a ModestMainWindow as a message window.
686 2007-07-10 Murray Cumming <murrayc@murrayc.com>
688 * src/maemo/modest-account-settings-dialog.c:
689 (show_error): Use the same implementation as in
690 modest-easysetup-wizard.c:
691 (on_entry_invalid_character): The logical ID contains a %s.
692 Guessed what it should be.
693 (on_entry_max), (check_data), (on_response): Adapt to
694 changed show_error().
695 (create_page_account_details): Really call
696 modest_validating_entry_set_func() on the correct widgets.
697 * src/maemo/easysetup/modest-easysetup-wizard.c:
698 (on_entry_invalid_character): Fix the logical ID here too.
699 (create_page_account_details),
700 (create_page_user_details):
702 modest_validating_entry_set_func() on the correct widgets.
704 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
705 Do not try to use the account if it is NULL.
707 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
709 * src/modest-ui-actions.c: (create_move_to_dialog),
710 (modest_ui_actions_on_main_window_move_to),
711 (modest_ui_actions_on_msg_view_window_move_to):
712 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
713 (filter_row), (modest_folder_view_show_non_move_folders):
714 * src/widgets/modest-folder-view.h:
716 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
717 the Sent folder yet as it does not report the correct folder type.
719 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
721 * src/maemo/modest-msg-edit-window.c: (init_window):
724 2007-07-10 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
727 Take a parent widget instead of a parent window, and
728 implement this with hildon_banner_show_information() instead.
729 Non-Maemo builds can just ifdef that there.
730 This fixed projects.maemo.org bug NB#62766.
732 (on_entry_invalid_character): Use show_error() again instead
733 of using hildon directly, and use the _CS() macro to use the correct
735 (create_account), (check_for_supported_auth_methods), (on_entry_max):
736 Pass a widget instead od a window to show_error().
738 2007-07-10 Murray Cumming <murrayc@murrayc.com>
740 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
741 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
742 This allows us to show the server name in the error message, fixing
743 projects.maemo.org bug NB#62904.
744 Also, use the appropriate logical ID message for the account protocol.
746 2007-07-10 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-account-store.c: (on_idle_wrong_password):
749 A compilation fix, though the build wasn't broken for me.
751 2007-07-09 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
754 Do not try to unref a NULL folder store, to avoid a runtime warning.
755 This seems to happen sometimes when changing accounts settings.
757 2007-07-09 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-tny-account-store.c:
760 (modest_tny_account_store_instance_init),
761 (modest_tny_account_store_finalize),
762 (on_account_settings_hide), (on_idle_wrong_password):
763 Use a GHashTable to ensure that we only show one account settings
764 dialog per modest account. This avoids us having a dialog open for
765 both the store and transport accounts, or due to repeated get_password()
766 calls that shouldn't happen anyway.
768 2007-07-09 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/modest-maemo-utils.c: (on_hide),
771 (modest_maemo_show_dialog_and_forget): Handle the response, because
772 the window is not even hidden by default.
774 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
775 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
776 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
777 which seems to prevent some modality problems.
779 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
780 Ignore user cancellation errors.
782 * src/modest-account-mgr-helpers.h:
783 * src/modest-account-mgr-helpers.c:
784 Added modest_server_account_get_password() and
785 modest_server_account_get_has_password() to avoid direct use of
788 * src/maemo/modest-account-settings-dialog.h:
789 * src/maemo/modest-account-settings-dialog.c:
790 (modest_account_settings_dialog_init): Store the notebook so we can
792 Added modest_account_settings_dialog_switch_to_user_info().
794 * src/modest-tny-account-store.c:
795 (get_password): When the password in the account settings is wrong (we think),
796 show the relevant page of the account settings dialog, in the mainloop.
797 However, we currently get many of these at once because cancel does not
799 (forget_password): Do not forget the password
800 from the account settings, because this causes side-effects when
801 tinymail seems to call it at strange time, maybe because of how we
802 are cancelling get_password().
803 (modest_tny_account_store_alert): Ignore user cancellations.
805 2007-07-09 Murray Cumming <murrayc@murrayc.com>
807 * src/maemo/modest-maemo-utils.h:
808 * src/maemo/modest-maemo-utils.c:
809 Added modest_maemo_show_information_note_and_forget() for use instead of
810 gtk_dialog_run() when the response is not needed, to avoid an extra
811 mainloop which could cause a hang.
813 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
814 Use the logical IDs for the error message, though they are not
815 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
816 because gtk_dialog_run() caused a hang here (the window did not close).
817 This fixes projects.maemo.org bug NB#62646.
819 2007-07-09 Murray Cumming <murrayc@murrayc.com>
821 * src/modest-account-mgr-helpers.h:
822 * src/modest-account-mgr-helpers.c:
823 Added modest_account_mgr_get_store_protocol().
825 * src/maemo/modest-account-view-window.c:
826 (on_delete_button_clicked): Show different warning text depending on
827 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
828 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
831 2007-07-09 Murray Cumming <murrayc@murrayc.com>
833 * src/maemo/modest-msg-edit-window.c:
834 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
835 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
837 2007-07-07 Armin Burgmeier <armin@openismus.com>
839 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
840 ckdg_ib_maximum_characters_reached from correct package.
842 * src/modest-ui-actions.c: Show an error message when a folder could
843 not be created. Tinymail does not give us specific error codes about
844 what has gone wrong, so we assume that a folder with that name
845 already exists, though there might be other reasons.
847 2007-07-06 Murray Cumming <murrayc@murrayc.com>
849 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
850 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
851 give a more exact error message that can be partly translated.
853 2007-07-05 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/modest-address-book.c:
856 (select_email_addrs_for_contact): Specify a default window size for the
857 select-email-address dialog, so that it is probably big enough for the
858 title. This should fix projects.maemo.org bug NB#62277.
860 2007-07-05 Murray Cumming <murrayc@murrayc.com>
862 * src/maemo/easysetup/modest-easysetup-wizard.c:
863 (create_page_complete_easysetup): Use
864 gtk_widget_set_size() request to ensure that the text wraps
867 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
869 * src/maemo/easysetup/modest-easysetup-wizard.c:
870 (on_entry_invalid_character), (create_page_account_details),
871 (create_page_user_details):
872 Use new API of ModestValidatingEntry. But for some reason the banner is
873 not shown. I will have to investigate that further.
875 * src/widgets/modest-validating-entry.c: (on_insert_text),
876 (modest_validating_entry_set_func):
877 * src/widgets/modest-validating-entry.h:
878 Added a new callback function to be able to react to prevented
879 characters whitespaces to e.g show a banner.
881 2007-07-05 Armin Burgmeier <armin@openismus.com>
883 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
884 notification of HildonNumberEditor instead of remembering the port
885 number. Thanks to Johannes for pointing this out.
887 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
889 * src/maemo/easysetup/modest-easysetup-wizard.c:
890 Check if there are any user changes before showing a confirmation
891 dialog (projects.maemo.org NB#60946)
893 2007-07-05 Armin Burgmeier <armin@openismus.com>
895 * src/maemo/modest-account-settings-dialog.c: Remember custom port
896 number at the beginning of the dialog and set the modified flag at the
897 end if the port number has changed. This is necessary because
898 HildonNumberEditor does not support notification when the value has
901 2007-07-05 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-ui-actions.c:
904 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
905 a connection before asking anything else. Correct the check for the destination
906 folder so that it succeeds when online.
907 This fixed projects.maemo.org bug NB#61645.
909 2007-07-05 Murray Cumming <murrayc@murrayc.com>
911 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
912 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
913 to fix projects.maemo.org bug NB#62439.
915 2007-07-05 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-tny-account.c: (on_connection_status_changed):
918 Really do not use tny_device_force_offline() here. See the previous comment.
920 2007-07-04 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-tny-account.c: (on_connection_status_changed):
923 Do not use tny_device_force_offline() when tinymail says that something
924 went wrong with the connection. It seems to report this unnecessarily.
926 2007-07-04 Murray Cumming <murrayc@murrayc.com>
928 * src/maemo/modest-connection-specific-smtp-window.c:
929 (modest_connection_specific_smtp_window_init):
930 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
931 does not seem to have any effect in osso 1.1 (though it works in
932 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
934 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
936 * src/maemo/modest-connection-specific-smtp-window.c:
937 Fix UI specification problems with projects.meamo.org NB#60479
939 2007-07-04 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
942 clue when this has failed, because the error dialog is not always shown
943 (at least in earlier version).
945 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
946 GError message, because the generic error dialog is not helpful.
948 'This message is not currently available (can't let a new connection go online)'
949 when trying to open an IMAP message.
951 (_modest_ui_actions_open): Offer a connection when some messages would
952 have to be downloaded and we are offline.
954 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
956 * src/widgets/modest-folder-view.c:
957 Don't check for MERGE type anymore as we use the correct type
959 NOTE: For the last two changes you need to update your tinymail copy
960 because of API changes!
962 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
964 * src/modest-tny-local-folders-account.c:
965 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
966 (see projects.maemo.org NB#61580)
968 2007-07-04 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-tny-account.c: (on_connection_status_changed):
971 Commented out the call to modest_platform_connect_and_wait() because this
972 seems to always hang, and I would like to know if this is the only thing
973 that causes a hang when showing the connection dialog.
974 It is not very useful anyway.
976 2007-07-04 Murray Cumming <murrayc@murrayc.com>
978 * src/maemo/modest-msg-view-window.c:
979 (modest_msg_view_window_select_next_message):
981 * src/modest-platform.h:
982 * src/maemo/modest-platform.c:
983 Added modest_platform_connect_and_wait(), which calls
984 tny_maemo_conic_device_connect() always in the main thread, by calling it
985 in an idle handler and waiting for the idle handler to run. It should be
986 in the main thread because it uses GTK+ UI code. It just returns TRUE
987 if the device is already online.
989 There is some nasty code to ensure that subsequent calls to
990 modest_platform_connect_and_wait() just wait for the first one to finish,
991 by checking repeatedly in another idle handler. This is necessary,
992 because other threads (or even the main thread, via another idle handler)
993 can call modest_platform_connect_and_wait() while
994 modest_platform_connect_and_wait() is running.
996 (modest_platform_connect_and_wait_if_network_account),
997 (modest_platform_connect_and_wait_if_network_folderstore):
998 Convenience functions that calls modest_platform_connect_and_wait() if
999 the account or folder might want network access.
1001 * src/modest-mail-operation.c:
1002 (modest_mail_operation_update_account):
1003 * src/modest-ui-actions.c: (download_uncached_messages),
1004 (modest_ui_actions_on_rename_folder), (delete_folder),
1005 (modest_ui_actions_on_main_window_move_to),
1006 (modest_ui_actions_on_msg_view_window_move_to):
1007 * src/widgets/modest-folder-view.c:
1008 (drag_and_drop_from_folder_view):
1009 Offer a connection if we are offline.
1011 * src/modest-tny-account.c: (on_connection_status_changed):
1012 Document this as only handling errors during network operations in progress,
1013 and replace the idle code with a simple call to
1014 modest_platform_connect_and_wait(), which does this instead.
1016 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-tny-account.c:
1019 (modest_tny_account_get_special_folder): (util_on_idle),
1020 Handle the GError so we can see when tny_folder_store_get_folders()
1021 fails, as it currently does while something else is connecting.
1023 Added util_run_in_main_thread_and_wait()
1024 which uses an idlen handler and mainloop to ensure that the function
1025 is called in the main thread.
1026 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1027 to make sure that we call attempt the connection in the mainloop only,
1028 which might solve some hangs.
1030 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1032 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1033 be found by their display name. This is never useful.
1034 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1035 by its ID, instead of trying to use its ID as its display name.
1037 * src/modest-tny-account-store.h:
1038 * src/modest-tny-account.c:
1039 (modest_tny_account_get_special_folder): Add a g_warning() when
1040 tny_folder_store_get_folders() returns an empty list for the maildir.
1042 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1043 Add a g_warning() when this returns NULL, because that it not allowed
1046 2007-07-02 Armin Burgmeier <armin@openismus.com>
1048 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1049 note when trying to cancel the wizard. This fixes projects.maemo.org
1052 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-tny-account.h:
1055 * src/modest-tny-account.c:
1056 (modest_tny_account_new_from_server_account),
1057 (modest_tny_account_new_from_server_account_name),
1058 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1059 because this must now be set before setting the proto. This is usd in
1060 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1061 warning in camel_session_get_service() caused by
1062 tny_camel_transport_account_prepare().
1064 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1067 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1069 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1071 (modest_connection_specific_smtp_edit_window_init):
1073 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1074 of "changed" for now
1076 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-tny-account.c:
1079 (modest_tny_account_new_from_server_account):
1080 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1081 now uses to request a connection when it needs one, and which it uses
1082 to tell us that something is wrong with the connection, so we can force
1083 the accounts offline to prevent further problems.
1085 * src/modest-defs.h:
1086 * src/modest-init.c: (init_default_settings):
1087 * src/modest-mail-operation.c:
1088 (modest_mail_operation_update_account):
1089 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1090 This should not be necessary anymore. Do not set the conf key that
1091 determined this (it was always TRUE and not set anywhere else).
1093 * src/modest-ui-actions.h: Remove unused and unimplemented
1094 modest_ui_actions_on_online_toggle_toggled().
1096 2007-06-29 Murray Cumming <murrayc@murrayc.com
1098 * src/maemo/modest-main-window.c: (connect_signals):
1099 Don't connect to delete_event twice. Maybe this was harmless.
1101 2007-06-29 Murray Cumming <murrayc@murrayc.com
1103 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1104 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1105 Debug output to give some more clue when a folder move is not allowed.
1107 2007-06-28 Murray Cumming <murrayc@murrayc.com
1109 * src/modest-tny-account.c: (on_modest_file_system_info),
1110 (modest_tny_account_get_mmc_account_name):
1111 Always call the callback, without checking whether the name has changed.
1112 * src/widgets/modest-folder-view.c: (strings_are_equal),
1113 (on_model_foreach_set_name), (on_get_mmc_account_name),
1114 (text_cell_data): Compare the name here, and use the name from
1115 the account rather than from the
1116 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1117 if the name was changed after the account was added to the model.
1118 That's a tinymail bug but not one that I want to fix now.
1120 This finally fixes projects.maemo.org bug NB#59301.
1122 2007-06-27 Armin Burgmeier <armin@openismus.com>
1124 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1127 2007-06-27 Murray Cumming <murrayc@murrayc.com
1129 * src/modest-tny-account.h:
1130 * src/modest-tny-account.c:
1131 Added modest_tny_account_get_mmc_account_name(), to set the memory
1132 card name asynchronously for the given account and then notify.
1133 (modest_tny_account_new_for_local_folders): Use this new function instead
1134 of using hildon_file_system_info_async_new() directly.
1136 * src/widgets/modest-folder-view.c: (text_cell_data):
1137 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1138 gtk_tree_model_row_changed() when it is available.
1140 This should fix projects.maemo.org bug NB#59301.
1142 2007-06-27 Murray Cumming <murrayc@murrayc.com
1144 * src/modest-mail-operation.c: (update_account_thread),
1145 (get_msgs_full_thread): Fix typo failures in the revert
1148 2007-06-27 Murray Cumming <murrayc@murrayc.com
1150 * src/maemo/modest-maemo-global-settings-dialog.c:
1151 (idle_select_default_focus):
1152 * src/modest-mail-operation.c: (idle_notify_progress),
1153 (idle_notify_progress_once), (set_last_updated_idle),
1154 (update_account_thread), (get_msgs_full_thread):
1155 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1156 * src/widgets/modest-header-view.c:
1157 (idle_notify_headers_count_changed_destroy),
1158 (idle_notify_headers_count_changed):
1159 Reverted the additions of gdk_threads_enter/leave(), in case this
1160 helps with a startup hang on the device.
1162 2007-06-26 Armin Burgmeier <armin@openismus.com>
1164 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1165 for supported secure authentication methods from server by
1166 gtk_dialog_run(), saving CPU time and a potential race condition.
1168 2007-06-26 Armin Burgmeier <armin@openismus.com>
1170 * src/maemo/modest-maemo-utils.h:
1171 * src/maemo/modest-maemo-utils.c: Added a
1172 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1173 only error code to tell the calling code when the user canceled the
1176 * src/maemo/modest-account-settings-dialog.h:
1177 * src/maemo/modest-account-settings-dialog.c:
1178 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1179 message if the retrieval of secure authentication methods was canceled
1180 by the user. Perform the check before saving anything to configuration
1181 to not end up with half-committed configuration changes, do not show
1182 a "Saving to configuration failed" note when authentication methods
1183 could not be retrieved.
1185 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1188 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1190 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1191 Only return the first level of folders under accounts, because the
1192 osso-global-search UI spec doesn't want the rest.
1193 This fixed projects.maemo.org bug NB#61811.
1195 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-tny-account-store.c:
1198 * src/modest-tny-account-store.h:
1199 Added modest_tny_account_is_memory_card_account().
1200 * src/maemo/modest-main-window.c: (create_details_widget):
1201 Show the same information items for the memory card as we show for the
1202 local-folders, to fix projects.maemo.org bug NB#59307.
1204 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1206 * src/modest-tny-account-store.c: (get_password):
1207 Added some checks for NULL to maybe prevent crashes, though I think
1208 it was Philip's last commit that actually prevented the crash here
1209 when creating a first new account.
1210 But the new account is still not usable (no messages are shown)
1211 until a restart of the application.
1213 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1215 * src/maemo/modest-maemo-global-settings-dialog.c:
1216 (idle_select_default_focus):
1217 * src/modest-mail-operation.c: (idle_notify_progress),
1218 (idle_notify_progress_once), (idle_notify_update_account_queue),
1219 (set_last_updated_idle), (update_account_thread),
1220 (notify_get_msgs_full), (get_msgs_full_destroyer),
1221 (get_msgs_full_thread):
1222 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1223 * src/widgets/modest-header-view.c:
1224 (idle_notify_headers_count_changed_destroy),
1225 (idle_notify_headers_count_changed):
1226 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1227 all idle handlers, because some other thread could be blocking
1228 the GDK lock, so that it can do GUI stuff.
1230 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1232 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1233 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1234 (on_idle_send_receive), (on_idle_open_default_inbox):
1235 * src/maemo/modest-msg-edit-window.c:
1236 (modest_msg_edit_window_attach_file_noninteractive):
1237 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1238 to prevent a hang. I don't quite understand why these are necessary,
1239 beause we should already be in the main loop. I guess something outside
1240 of the main loop is taking the lock.
1242 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1243 we are really using URIs, and use files that are more likely to exist.
1245 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1247 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1248 necessary because configure.ac now defines different variables.
1250 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1252 * libmodest-dbus-client/libmodest-dbus-client.c:
1253 * libmodest-dbus-client/libmodest-dbus-client.h:
1254 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1255 libmodest_dbus_client_compose_mail() is what things actually use.
1257 * src/dbus_api/modest-dbus-api.h:
1258 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1259 * tests/dbus_api/Makefile.am:
1260 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1263 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-init.c: (modest_init_local_folders):
1266 For memory-card (or other non local-folders) maildir accounts,
1267 always create an Archive folder, so that there is somewhere to put
1268 messages. This should be less confusing, because the user does not need
1269 to guess that the need to create a folder.
1271 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1273 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1274 Fixed icon size by using (50, 50) which is the same as defined by
1277 2007-06-25 Armin Burgmeier <armin@openismus.com>
1279 * src/widgets/modest-window-mgr.c:
1280 * src/modest-init.c:
1281 * configure.ac: Correctly recognize hildon-notify presence and fixed
1282 the build without it being installed.
1284 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1286 * libmodest-dbus-client/libmodest-dbus-client.c:
1287 (libmodest_dbus_client_search): Fix the build. Sorry.
1288 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1289 (reply_forward_cb): Initialize variables to fix the build.
1291 * src/modest-tny-account-store.c:
1292 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1293 comparison (a silly typo) so that email search results can be opened
1294 when there are more than one account.
1296 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1298 * libmodest-dbus-client/libmodest-dbus-client.c:
1299 (libmodest_dbus_client_search),
1300 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1301 instead of 1 second, because the search gets folders and messages from
1302 the server, which can take a long time. When it times out,
1303 osso-global-search will report no results.
1305 We need to specify whether we should search only cached information
1306 (maybe with a user preference), and the osso-email-search-plugin
1307 API should really be improved to allow that option, and to allow results
1308 to be delivered asynchronously in batches.
1310 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1312 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1313 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1314 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1316 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1319 that is an empty string. D-Bus seems to give us these instead of NULL.
1321 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1323 * src/dbus_api/modest-dbus-callbacks.c:
1324 * src/maemo/easysetup/modest-easysetup-wizard.h:
1325 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1326 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1327 (modest_connection_specific_smtp_edit_window_init):
1328 * src/maemo/modest-maemo-global-settings-dialog.c:
1330 * src/maemo/modest-maemo-utils.c:
1331 (modest_maemo_utils_setup_images_filechooser):
1332 * src/maemo/modest-main-window.c: (create_details_widget):
1333 * src/maemo/modest-msg-edit-window.c:
1334 (modest_msg_edit_window_attach_file_noninteractive),
1335 (modest_msg_edit_window_color_button_change),
1336 (modest_msg_edit_window_set_zoom):
1337 * src/modest-mail-operation.c: (update_account_thread):
1338 * src/modest-tny-account-store.c:
1339 * src/modest-tny-account.c:
1340 * src/widgets/modest-global-settings-dialog.c:
1341 * src/widgets/modest-window.h:
1343 Fixed build on bora!
1345 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1347 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1348 * src/modest-search.c: (modest_search_folder),
1349 (modest_search_all_accounts): Actually search only in the specified folder,
1350 doing a simple match on the folder ID.
1351 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1352 and added some documentation.
1354 2007-06-22 Armin Burgmeier <armin@openismus.com>
1356 * src/maemo/modest-maemo-utils.h:
1357 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1358 modest_maemo_utils_get_supported_secure_authentication_methods.
1360 * src/maemo/easysetup/modest-easysetup-wizard.c:
1361 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1362 one occured, not just "Server does not support secure authentication".
1364 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1366 * src/modest-tny-account-store.c: (get_password):
1367 Restored the call to tny_account_set_user() because Philip seems to have
1368 stopped this from crashing (by not using the freed string). It still does
1369 not work, but now we can test it.
1371 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/modest-msg-edit-window.c: (init_window):
1374 Comment out use of an uninitialzed GtkScrolledWindow variable,
1375 to fix the build and stop a crash. Yet again.
1377 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1379 * src/modest-tny-account-store.c: (get_password):
1380 Remove the call to tny_account_set_user() because this actually crashes.
1381 As mentioned in the last commit, it is known to not work anyway.
1383 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1385 * src/modest-tny-account-store.c: (get_password):
1386 Use tny_account_set_username() to tell tinymail that the username might
1387 have changed too. But tinymail ignores this: see projects.maemo.org
1389 * src/modest-ui-actions.c:
1390 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1391 reset the connection when changing the username, and improve the comments.
1392 Save the changed username to gconf at least, so it is used when Modest is
1395 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1397 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1398 Do not use a query, so that we get all folders, including for POP and
1399 local-folders. They work as search criteria too.
1400 This fixes projects.maemo.org bug NB#57740.
1402 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1404 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1405 Comment out the use of hildon_notification_set_sound() because it is
1406 not declared, to fix the build. Warnings are serious, people.
1408 2007-06-21 Armin Burgmeier <armin@openismus.com>
1410 * src/maemo/modest-maemo-utils.h:
1411 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1412 modest_maemo_utils_get_supported_secure_authentication_methods()
1413 to query authentication methods for a specific user. This should fix
1414 projects.maemo.org bug NB#61369.
1416 * src/maemo/easysetup/modest-easysetup-wizard.c:
1417 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1420 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1422 * libmodest-dbus-client/libmodest-dbus-client.h:
1423 * libmodest-dbus-client/libmodest-dbus-client.c:
1424 (modest_dbus_message_iter_get_search_hit),
1425 (libmodest_dbus_client_search):
1426 Reorganised and commented this.
1427 Removed modest_search_hit_free() from the public API because it
1430 Added libmodest_dbus_client_get_folders() and
1431 modest_folder_result_list_free().
1433 * src/dbus_api/modest-dbus-api.h:
1434 * src/dbus_api/modest-dbus-callbacks.c:
1435 (modest_dbus_req_filter): Commented. Moved most code to
1436 on_dbus_method_search() and added on_dbus_method_get_folders().
1438 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1439 of the extra D-Bus handler.
1441 * tests/dbus_api/Makefile.am:
1442 * tests/dbus_api/test_get_folders.c: New test for
1443 libmodest_dbus_client_get_folders(). This seems to return an empty list
1444 at the moment. That could be the same error that causes the message list
1445 to be empty sometimes.
1446 This should help with projects.maemo.org bug NB#57740.
1448 2007-06-21 Armin Burgmeier <armin@openismus.com>
1450 * src/modest-mail-operation.c: Do not call
1451 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1452 notify the operation's end after having set the status to CANCELED for
1453 the operation queue to listen on. This fixes a deadlock when there
1454 were mail operations in the queue during its finalization.
1456 * src/modest-singletons.c: Reordered uninitialization of the account
1457 manager to happen after the mail operation queue was uninitialized
1458 because the mail operation's in the queue might still try to access
1459 the account manager (see modest_mail_operation_notify_end()). This
1460 fixes a potential crash when terminating the application.
1462 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-search.c:
1465 (search_mime_part_and_child_parts): Moved some code here so we
1466 can search recursively in child folders.
1467 (modest_search_folder): Search in the message as a mime part, instead
1468 of just its child mime parts.
1469 (read_chunk), (search_mime_part_ogs):
1470 Check how many bytes were read, to prevent an endless loop.
1471 Searching in message bodies now works. This finishes the fix for
1472 projects.maemo.org bug NB#61007.
1474 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1476 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1477 Add a g_warning when the item is not a folder.
1479 * src/modest-ui-dimming-rules.c:
1480 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1481 when selected item is not a folder (for instance, an account), because
1482 the UI spec only talks about folders.
1483 I am not sure what the UI spec wants, so this might not totally fix
1484 projects.maemo.org bug NB#60794.
1486 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1488 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1489 (load_from_file): Sort the list. The unsorted list would be more noticeable
1490 in non-English locales.
1492 * src/maemo/modest-msg-edit-window.c:
1493 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1494 warning and fix the build.
1496 * src/maemo/modest-progress-bar-widget.c:
1497 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1498 avoid a g_warning, and probably to avoid a crash.
1500 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-search.c: (modest_search_folder): Check for a GError
1503 when calling tny_folder_get_headers(), to show that this is not the cause
1506 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1508 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1509 Actually set the body query instead of the subject query.
1511 * src/modest-search.c: (search_mime_part_ogs),
1512 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1513 which would probably cause it to fail if we got this far.
1515 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1516 to simplify the code.
1517 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1518 be causing search-in-body to fail.
1520 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1522 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1524 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1525 Better debug message when the folder cannot be found.
1526 This should help with fixing projects.maemo.org bug #61287.
1527 * src/modest-search.c: (add_hit): Do not leak the furl string.
1529 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-ui-actions.c:
1532 (modest_ui_actions_on_folder_selection_changed):
1533 Do not special-case TNY_MERGE_FOLDER here, because
1534 modest_tny_folder_get_account() already does that. This fixes
1535 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1536 shown when the Outbox was selected).
1538 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1540 * libmodest-dbus-client/libmodest-dbus-client.c:
1541 (_dbus_iter_get_string_or_null): Initialize the string variable in
1542 case this helps with Dirk's crash.
1544 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1546 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1547 though it is not implemented yet (this function is maybe not even used),
1548 to avoid breaking ABI in future.
1549 * libmodest-dbus-client/libmodest-dbus-client.c:
1550 (get_attachments_string): Moved some code into this generic function.
1551 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1552 sends email. It is maybe not used.
1553 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1554 (on_send_mail): Use attachments.
1556 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1557 * src/maemo/modest-msg-edit-window.c:
1558 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1559 a filename before using it, to fix projects.maemo.org bug NB#58233.
1561 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1563 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1564 Initialize the continue_download variable to fix the build, and probably
1565 to fix randome behaviour.
1567 2007-06-18 Armin Burgmeier <armin@openismus.com>
1569 * src/modest-tny-send-queue.h:
1570 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1571 the queue so we can later show it in the UI. Replaced
1572 modest_tny_send_queue_msg_is_being_sent() by
1573 modest_tny_send_queue_get_msg_status().
1575 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1577 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1578 gpointer. This probably was not harmful, but just to be sure.
1580 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1583 Fix the build, but leave the function broken on Bora, because
1584 hildon_uri_action_get_service() does not exist.
1585 osso_uri_action_get_service() does not exist either, it seems.
1587 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1589 * src/modest-tny-account.c:
1590 (modest_tny_account_new_from_server_account):
1591 Uncommented the url debug output again, because it is useful for
1592 debugging, as I said in the comment.
1594 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1596 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1598 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1599 for Mameo Bora, to fix the build.
1601 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1604 Fixed build with hildon < 0.99
1606 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1607 Check if the selected account is busy instead of checking all accounts
1609 * src/modest-account-mgr-priv.h:
1610 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1611 (modest_account_mgr_init), (compare_account_name),
1612 (modest_account_mgr_set_account_busy),
1613 (modest_account_mgr_account_is_busy):
1614 * src/modest-account-mgr.h:
1615 Added busy information to the account manager. It possible to
1616 set an account to busy or not busy now.
1618 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1619 (modest_mail_operation_update_account),
1620 (modest_mail_operation_notify_end):
1621 Set the account to busy/not busy depending on the operation state.
1623 * src/widgets/modest-account-view.c:
1624 (modest_account_view_finalize), (get_last_updated_string),
1625 (update_account_view), (on_account_busy_changed), (init_view):
1626 Show string "Refreshing..." if the account is currently busy.
1628 All this fixes projects.maemo.org bug NB#59711
1630 2007-06-14 Armin Burgmeier <armin@openismus.com>
1632 * src/widgets/modest-attachments-view.h:
1633 * src/widgets/modest-attachments-view.c: Added
1634 modest_attachments_view_has_attachments() and fixed coordinate
1635 transformation in get_att_view_at_coords(). This fixes attachment
1638 * src/widgets/modest-msg-view.c: Make use of
1639 modest_attachments_view_has_attachments() to decide whether to show
1640 attachments in the header.
1642 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1645 (on_change), (on_combo_security_changed),
1646 (modest_connection_specific_smtp_edit_window_init),
1647 (modest_connection_specific_smtp_edit_window_set_connection),
1648 (modest_connection_specific_smtp_edit_window_is_dirty):
1649 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1650 * src/maemo/modest-connection-specific-smtp-window.c:
1653 Show an comfirmation dialog for the smpt-edit-window if there are
1654 unsaved changes and the user hits cancel.
1655 (projects.maemo.org bug NB#60479)
1657 2007-06-14 Armin Burgmeier <armin@openismus.com>
1659 * src/maemo/easysetup/modest-easysetup-wizard.c:
1660 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1661 address" info in banner instead of node, and select all the text as
1662 per UI spec. This fixes projects.maemo.org bug NB#60550.
1664 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1666 reviewed by: <delete if not using a buddy>
1668 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1669 * src/modest-ui-actions.c: (folder_refreshed_cb):
1671 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1673 * src/widgets/modest-folder-view.c: (filter_row):
1674 Explictly filter out the per-account outbox accounts. I don't know why
1675 these only sometimes show up, but now they should never show up in the UI.
1676 This should fix projects.maemo.org bug NB#60160.
1678 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1681 when the toolbar does not exist yet.
1682 * src/modest-widget-memory.c: (save_settings_header_view):
1683 Added g_warnings() to help us to discover when we are trying to set
1684 an empty columns list in gconf.
1686 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1688 * src/modest-init.h:
1689 * src/modest-init.c:
1690 Added modest_init_get_default_header_view_column_ids().
1692 * src/modest-widget-memory.c: (restore_settings_header_view):
1693 Use the new function to get defaults, if the gconf key is empty,
1694 instead of not creating any columns. This seems to fix the
1695 empty right-hand pane problems.
1697 * src/widgets/modest-header-view.h: Improved documentation.
1699 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1701 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1702 Revert the use of the display name as the account name, because this
1703 is generally wrong and would break the code that follows.
1705 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1707 * src/maemo/easysetup/modest-easysetup-wizard.c:
1708 (check_for_supported_auth_methods), (on_before_next),
1711 More correct fix for projects.maemo.org bug NB# 58991
1712 Do not longer accept AUTH_PASSWORD as secure method and choose
1713 correct method when creating the account.
1715 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1717 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1718 Fixed projects.maemo.org bug NB# 58991
1720 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1722 * src/modest-init.c: (modest_init_init_core),
1723 (modest_init_local_folders): Fixed compilation errors.
1725 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1727 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1728 Remove unnecessary lib/include, though it is good in principle when needed.
1730 * src/modest-init.c: (modest_init_one_local_folder),
1731 (modest_init_local_folders):
1732 * src/modest-init.h: Initialize the .modest library for memory cards,
1733 instead of just doing nothing for them. This should allow us to create
1734 folders there, fixing projects.maemo.org bug NB#59297.
1736 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1738 * libmodest-dbus-client/libmodest-dbus-client.c:
1739 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1740 (libmodest_dbus_client_compose_mail),
1741 (libmodest_dbus_client_open_message),
1742 (libmodest_dbus_client_send_and_receive),
1743 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1745 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1746 (on_idle_open_message), (modest_dbus_req_handler),
1747 (search_result_to_message), (modest_dbus_req_filter):
1748 * src/modest-search.c: (add_hit), (modest_search_folder),
1749 (modest_search_all_accounts): Improved debug messages.
1751 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1753 * src/modest-tny-account-store.c:
1754 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1757 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1760 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1762 * src/modest-tny-account-store.c: (get_server_accounts):
1763 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1764 even when there are no accounts, so that the Outbox folder is always
1765 visible. This fixes projects.maemo.org bug NB#60158.
1767 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1769 * src/maemo/modest-main-window.c: (create_details_widget):
1770 Use the mcen_va_never logical ID.
1772 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1774 * src/dbus_api/modest-dbus-api.h:
1775 * src/dbus_api/modest-dbus-callbacks.c:
1776 (on_idle_open_default_inbox), (on_open_default_inbox),
1777 (modest_dbus_req_handler):
1778 Added a new OpenDefaultInbox method.
1780 * libmodest-dbus-client/libmodest-dbus-client.h:
1781 * libmodest-dbus-client/libmodest-dbus-client.c:
1782 Added libmodest_dbus_client_open_default_inbox() to call the new
1783 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1784 though it should maybe be used by a new osso-email-interface function.
1786 * tests/dbus_api/Makefile.am:
1787 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1790 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1792 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1793 NULL, so that the signals get all the keys. This should not actually
1794 change any behaviour because we currently update everything when anything
1797 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1799 * src/widgets/modest-folder-view.c: (text_cell_data),
1800 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1801 (find_inbox_iter): If tinymail tells us that the folder is
1802 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1803 This causes the inbox to be selected at startup, fixing part of
1804 projects.maemo.org bug NB#56305.
1806 * src/modest-ui-dimming-rules.c:
1807 (modest_ui_dimming_rules_on_tools_smtp_servers):
1808 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1809 the SMTP servers menu item.
1810 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1811 that the SMTP Servers menu item is dimmed when there are no accounts,
1812 as a future version of the UI spec will require. This fixes
1813 projects.maemo.org bug NB#56305.
1815 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1817 * src/maemo/modest-maemo-utils.c:
1818 (modest_maemo_utils_get_supported_secure_authentication_methods):
1819 Added label to dialog instead of unreadable title
1821 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1822 (modest_main_window_new):
1823 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1826 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1827 * src/modest-account-mgr.h:
1828 Added method to avoid code duplication
1830 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1831 (modest_ui_actions_on_send_receive):
1832 Use modest_account_mgr_has_accounts
1834 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/easysetup/modest-presets.c:
1837 (modest_presets_get_info_server_security): Do not report secure auth
1839 * src/modest-protocol-info.c: Use the defines for the gconf key names
1840 for secure authentication. This was not working because we were writing
1841 Password and reading password, and the check was case sensitive.
1842 With this, gmail now works for receiving and sending when created via
1845 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1847 * src/maemo/easysetup/modest-presets.c:
1848 (modest_presets_get_info_server_security): Correct the key name for
1849 SecureSmtp, because it seems to be case-sensitive.
1850 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1851 Do not try to get the 0th notebook page if there are 0 pages, to
1852 avoid a g_warning().
1854 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1857 Prevent use of the new notification feature for now, because it currently
1858 shows one dialog for each new email, which is annoying.
1860 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1862 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1863 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1864 when no country was selected, so that we show the global ones.
1865 * src/maemo/easysetup/modest-presets.c:
1866 (modest_presets_get_providers): Return only the global providers, not
1867 all providers when mmc=0 was requested.
1869 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1871 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1872 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1873 provider ID in the combo.
1875 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1876 Do not show the page numbers, because it would be confusing when we add
1877 the 2 extra pages for the custom setup, when the user chooses the "Other"
1878 provider. This fixes projects.maemo.org bug NB#59028
1880 * src/modest-init.c: (modest_init_init_core),
1881 (modest_init_local_folders):
1882 * src/modest-init.h:
1883 * src/modest-tny-account.c:
1884 (modest_tny_account_new_for_local_folders): Do not create default folders
1885 for the memory card. This should fix projects.maemo.org bug NB#59328.
1887 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1890 Free the changed_conf_keys string items. They are already freed in the
1891 idle handler if that runs first.
1893 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1895 * src/modest-ui-actions.c:
1896 (modest_ui_actions_on_password_requested): Check that the server name
1897 is not NULL, because I just saw a password dialog with (null) as the
1900 * src/modest-tny-folder.[h|c]: Added
1901 modest_tny_folder_is_memory_card_folder().
1902 * src/modest-ui-dimming-rules.c:
1903 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1904 menu item for memory cards, as per the UI spec (section 7.4). This should
1905 fix projects.maemo.org bug NB#59297.
1907 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1909 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1910 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1911 is another problem with the code, see Murray's comment at line 772)
1913 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1916 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1917 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1918 (load_from_file), (easysetup_country_combo_box_init),
1919 (easysetup_country_combo_box_get_active_country_ids),
1920 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1921 instead of just one ID, to avoid duplicate country names in the UI.
1923 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1924 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1925 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1926 a single ID, avoiding duplicate providers.
1927 * src/maemo/easysetup/modest-easysetup-wizard.c:
1928 (on_combo_account_country): Adapt to use a list.
1930 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1932 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1933 keys changed in the last X seconds.
1935 * src/modest-account-mgr.h:
1936 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1937 (on_key_change), (modest_account_mgr_class_init),
1938 (modest_account_mgr_init), (modest_account_mgr_finalize):
1939 As the keys are changed, save them in a GSList* and signal that GSList*
1940 further every X seconds, to batch changes, to allow us to do just one
1941 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1942 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1944 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1945 changed signal signature.
1947 * src/modest-conf.c: (modest_conf_set_list),
1948 (modest_conf_on_change): Reenable notification.
1950 (modest_conf_maemo_fake_on_change): Comment out the hack that
1951 notified immediately instead of asynchronously.
1953 * src/widgets/modest-account-view.h:
1954 * src/widgets/modest-account-view.c:
1955 (update_account_view): Select the previously-selected account ID,
1956 if possible. This fixes projects.maemo.org bug NB#56933.
1958 (on_account_changed), (on_account_removed),
1959 (modest_account_view_select_account):
1961 Remove the block/unblock functions
1962 because they were not useful.
1964 * src/maemo/modest-account-view-window.c:
1965 (on_delete_button_clicked), (on_edit_button_clicked),
1966 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1968 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1971 Improve the error dialog to show Incorrect Account Settings, which seems
1972 clearer, and say that the internal error message (to be removed from the
1973 dialog later) is often misleading.
1974 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1976 * src/modest-tny-account.c:
1977 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1978 URL because this is so useful for debugging on the device.
1980 * src/widgets/modest-serversecurity-combo-box.c:
1981 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1983 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1985 * src/modest-mail-operation.c:
1986 (modest_mail_operation_send_new_mail):
1987 Added a comment about a nasty but apparently harmless message. Details
1988 added to the wiki g_warnings() page.
1990 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1992 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1993 (modest_tny_send_queue_class_init):
1994 Do not use the priv struct because it is empty, to avoid g_warnings
1995 about a non-existant priv struct.
1997 * src/modest-tny-account-store.c:
1998 (modest_tny_account_store_get_server_account),
1999 (modest_tny_account_store_get_transport_account_for_open_connection
2000 ): Do not try to get transport server accounts for local folders,
2001 because they don't have any. This avoids a g_warning().
2003 * src/maemo/modest-main-window.c:
2004 (modest_main_window_notify_send_receive_initied),
2005 (on_configuration_key_changed):
2006 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2007 * src/modest-defs.h:
2008 * src/modest-mail-operation.c:
2009 (modest_mail_operation_update_account):
2010 * src/modest-tny-account-store.h:
2011 * src/modest-tny-account.c:
2012 (modest_tny_account_get_special_folder),
2013 (modest_tny_account_new_for_local_folders),
2014 (modest_tny_account_new_for_per_account_local_outbox_folder):
2015 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2016 * src/modest-tny-local-folders-account.c:
2017 (add_account_folders_to_merged_folder):
2018 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2019 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2020 (modest_ui_actions_on_send):
2021 * src/widgets/modest-folder-view.c: (update_model):
2022 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2023 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2024 modest_tny_account_store_get_tny_account_by_account() to
2025 modest_tny_account_store_get_server_account() to make the code clearer.
2027 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2029 * src/dbus_api/modest-dbus-api.h:
2030 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2031 * src/maemo/modest-msg-edit-window.c:
2032 (modest_msg_edit_window_attach_file_noninteractive):
2033 added g_warning in case the file to be attached does not exist
2034 * tests/dbus_api/test_compose_mail.c: (main):
2035 removed obsolete comment, added generic files as test case
2037 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2039 * src/modest-tny-account-store.c: (get_server_accounts):
2040 Create the local folders account only once, not once for each outbox, and
2041 not only when there are some outboxes.
2043 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2045 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2046 code that is causing a crash at startup. Sergio says that he is fixing this.
2048 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2050 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2051 * src/maemo/modest-account-settings-dialog.c:
2052 (create_page_outgoing),
2053 (modest_account_settings_dialog_set_account_name),
2054 (save_configuration):
2055 - Fixed handling of the "Use secure authentication" toggle to comply with
2056 the ui specification. See also projects.maemo.org bug NB#58400
2058 - Restore the Secure connection setting combo correctly when loading
2061 * src/maemo/modest-maemo-utils.c:
2062 (on_camel_account_get_supported_secure_authentication),
2063 (modest_maemo_utils_get_supported_secure_authentication_methods):
2064 Fixed a crasher if operation is canceled
2066 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2067 (modest_protocol_info_auth_is_secure):
2068 * src/modest-protocol-info.h:
2070 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2071 the sense of the "Use secure authentication" toggle.
2073 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2075 * src/modest-tny-account-store.h:
2076 * src/modest-tny-account-store.c:
2077 Added modest_tny_account_store_get_local_folders_account().
2079 * src/modest-tny-folder.h:
2080 * src/modest-tny-folder.c:
2081 (modest_tny_folder_get_account):
2082 Added this replacement for tny_folder_get_account() which returns
2083 the local-folders account for TnyMergeFolders, to avoid the
2084 warning about the unimplemented get_account_func() vfunc().
2086 (modest_tny_folder_get_rules),
2087 * src/modest-ui-actions.c:
2088 (modest_ui_actions_on_folder_selection_changed):
2089 * src/modest-mail-operation.c:
2090 (modest_mail_operation_remove_folder),
2091 (modest_mail_operation_xfer_folder),
2092 (modest_mail_operation_rename_folder),
2093 (modest_mail_operation_get_msg),
2094 (modest_mail_operation_get_msgs_full),
2095 (modest_mail_operation_remove_msg),
2096 (modest_mail_operation_xfer_msgs),
2097 (modest_mail_operation_refresh_folder):
2098 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2100 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2102 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2103 (modest_server_account_set_security):
2104 * src/modest-defs.h: Add comments explaining that our
2105 UI spec means TLS when it says Normal, so these do not look like errors.
2107 * src/modest-tny-account.c:
2108 (modest_tny_account_new_from_server_account): Use the new tinymail
2109 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2110 for TLS. This should fix projects.maemo.org bug NB#58460.
2112 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/easysetup/modest-easysetup-wizard.c:
2115 (create_account): Correct the position of the gconf sanity check warning.
2116 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2117 of using the g_idle_add() hack, because this does not seem to be necessary
2118 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2119 caused by something other than maemo's gconf.
2120 This fixes projects.maemo.org bug #59022.
2122 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2124 * src/modest-account-mgr-helpers.c:
2125 (modest_account_mgr_get_default_account): Do not check that the account
2126 exists if there is no default account (NULL), to fix a runtime warning.
2128 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2130 * src/widgets/modest-folder-view.c: (update_model):
2131 Do not unref the treemodel before we have finished with it.
2132 This prevents a valgrind warning and an occasional crash at startup.
2134 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2136 * libmodest-dbus-client/libmodest-dbus-client.h:
2137 added libmodest_dbus_client_compose_mail()
2138 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2140 added functions needed for SendAsMail() functionality
2141 * src/maemo/modest-msg-edit-window.c:
2142 (modest_msg_edit_window_attach_file_noninteractive):
2143 non interactively attaching files to message edit window
2144 * src/widgets/modest-msg-edit-window.h:
2145 * tests/dbus_api/Makefile.am:
2146 added test_compose_mail.c
2147 * tests/dbus_api/test_compose_mail.c: (main):
2149 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2151 * src/modest-account-view.c:
2152 Fixed bug projects.maemo.org bug NB#59307
2154 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2156 * src/maemo/easysetup/modest-easysetup-wizard.c:
2157 (get_serverport_incoming), (on_before_next), (create_account):
2158 * src/maemo/modest-account-settings-dialog.c:
2159 (modest_account_settings_dialog_set_account_name):
2160 * src/maemo/modest-maemo-utils.c:
2161 (on_camel_account_get_supported_secure_authentication_status),
2162 (on_camel_account_get_supported_secure_authentication),
2163 (on_secure_auth_cancel),
2164 (modest_maemo_utils_get_supported_secure_authentication_methods):
2166 Implemented security authentication for settings and easysetup.
2168 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2170 * src/maemo/modest-main-window.c: (create_details_widget):
2171 Show the total size for memory card accounts too, instead of showing
2172 the name again. Fixes bug projects.maemo.org bug NB#59307.
2174 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-tny-simple-folder-store.c:
2178 * src/modest-tny-simple-folder-store.h: Removed.
2180 * src/modest-tny-local-folders-account.h
2181 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2182 for the local-folders maildir, with an extra TnyMergedFolder containing
2183 the folders of the per-account outbox store accounts.
2184 * src/modest-tny-account-store.c: (get_server_accounts):
2185 Add the outboxes to the special local folders account after creating it.
2187 * src/modest-tny-account.c:
2188 (modest_tny_account_new_for_local_folders): Create the derived
2189 account when creating the main local-folders account.
2191 * src/maemo/modest-main-window.c: (create_details_widget),
2192 (modest_main_window_set_contents_style):
2193 Adapted to the use of the derived account instead of the folder store.
2195 * src/modest-ui-actions.c:
2196 (modest_ui_actions_on_folder_selection_changed):
2197 * src/modest-ui-dimming-rules.c:
2198 (modest_ui_dimming_rules_on_new_folder):
2199 * src/widgets/modest-folder-view.c: (text_cell_data),
2200 (icon_cell_data), (filter_row), (update_model),
2201 (get_cmp_rows_type_pos):
2204 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2205 Do not get the priv struct, because no priv struct has been set,
2206 to avoid a runtime warning.
2208 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2209 #ifelse with #else, to fix a warning, to fix the build.
2212 2007-06-05 Christian Kellner <ckellner@openismus.com>
2214 * libmodest-dbus-client/libmodest-dbus-client.c:
2215 Fix small typo in doc (why do you always see them
2216 AFTER committing stuff?)
2219 2007-06-05 Christian Kellner <ckellner@openismus.com>
2221 * libmodest-dbus-client/libmodest-dbus-client.c:
2222 (libmodest_dbus_client_search):
2223 Initialize hit list with NULL. Also set folder list
2224 to "" if NULL was supplied.
2227 2007-06-03 Christian Kellner <ckellner@openismus.com>
2229 * libmodest-dbus-client/libmodest-dbus-client.c:
2230 (modest_search_hit_list_free):
2231 Make it save to call it with NULL.
2233 * src/dbus_api/modest-dbus-callbacks.c:
2234 * src/modest-search.c:
2235 Return full ModestSearchHits as the search result list not TnyHeader
2236 since can't be around withouth the correspoding TnyFolder.
2238 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2240 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2241 Added currently commented code to check for secure auth
2243 * src/maemo/modest-account-settings-dialog.c: (on_response),
2244 (save_configuration), (show_ok):
2245 Fixed projects.maemo.org bugs NB #59248 and #59251
2247 * src/maemo/modest-maemo-utils.c:
2248 (on_camel_account_get_supported_secure_authentication_status),
2249 (on_camel_account_get_supported_secure_authentication),
2250 (modest_maemo_utils_get_supported_secure_authentication_methods):
2251 * src/maemo/modest-maemo-utils.h:
2252 Moved get_supported_secure_authentication() method here to be able
2253 to use it from easysetup wizard.
2255 * src/modest-pair.c: (on_pair_compare_as_string):
2256 Should compare string with first part of pair and not
2257 strcmp pairs which will crash.
2259 * src/modest-protocol-info.c:
2260 (modest_protocol_info_protocol_is_store):
2261 * src/modest-protocol-info.h:
2262 Added modest_protocol_info_get_auth_protocol_name()
2264 2007-06-03 Armin Burgmeier <armin@openismus.com>
2266 * src/modest-mail-operation.c:
2267 (modest_mail_operation_get_msgs_full): Set priv->account also when
2268 only retrieving a single message. This avoids a crash when canceling
2271 (modest_mail_operation_notify_end): Do not explicitely remove the
2272 operation from the queue but only emit the progress_changed signal.
2273 The queue itself listens to that signal to remove the operation when
2274 it is finished. This reduces coupling and removes a potential deadlock
2275 when modest_mail_operation_notify_end() is called from the queue
2276 itself. If that is a problem performance-wise, I would suggest to
2277 implement a status-changed signal or something.
2279 * src/modest-mail-operation-queue.c: Make sure to never call a
2280 function from another file while the queue is locked. This (hopefully)
2281 fixes another deadlock when exiting the application while retrieving
2284 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2286 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2287 Fixed build if libogs is not available
2289 2007-06-03 Christian Kellner <ckellner@openismus.com>
2291 * libmodest-dbus-client/libmodest-dbus-client.h:
2292 * libmodest-dbus-client/libmodest-dbus-client.c:
2293 (libmodest_dbus_client_delete_message):
2294 Implement deletion of messages (Client side).
2296 (modest_search_hit_free),
2297 (modest_search_hit_list_free):
2298 Utility functions to free the result hits.
2300 * src/dbus_api/modest-dbus-api.h:
2301 * src/dbus_api/modest-dbus-callbacks.c:
2302 (on_delete_message),
2303 (modest_dbus_req_handler):
2304 Implement deletion of messages (Server side).
2306 * tests/dbus_api/test_search.c: (main):
2309 * tests/dbus_api/Makefile.am:
2310 * tests/dbus_api/test_delete_message:
2311 Add little test for the message deletion logic
2313 2007-06-03 Armin Burgmeier <armin@openismus.com>
2315 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2316 when the operation queue was not empty. projects.maemo.org bug
2319 2007-06-03 Armin Burgmeier <armin@openismus.com>
2321 * src/widgets/modest-account-view.c
2322 (on_account_default_toggled): Toggle default account column
2323 explicitely instead of waiting for gconf notification (which is
2324 currently ignored). This should fix projects.maemo.org bug NB#56910
2325 for now. It should probably be removed when gconf notifications are
2328 2007-06-03 Christian Kellner <ckellner@openismus.com>
2330 * libmodest-dbus-client/libmodest-dbus-client.c:
2331 Removed debugging spew.
2333 * src/dbus_api/modest-dbus-callbacks.c:
2334 Added debugging info.
2336 * src/modest-search.c:
2337 (modest_search_all_accounts):
2338 Use tny_account_store_get_accounts () on the account store
2339 to get all accounts which is the way to get all accounts.
2341 * tests/dbus_api/test_search.c: (main):
2342 Make it possible to supply the search term on the command line.
2344 2007-06-03 Christian Kellner <ckellner@openismus.com>
2346 * libmodest-dbus-client/libmodest-dbus-client.c:
2347 * libmodest-dbus-client/libmodest-dbus-client.h:
2348 Implement searching for mesages over raw dbus. (Client side)
2350 * src/dbus_api/Makefile.am:
2351 * src/dbus_api/modest-dbus-api.h:
2352 * src/dbus_api/modest-dbus-callbacks.c:
2353 * src/dbus_api/modest-dbus-callbacks.h:
2354 Search framework (Server side). Also implement on_idle_open_message().
2356 * src/maemo/modest-platform.c: (modest_platform_init):
2357 Prepare for raw dbus/osso rpc interaction.
2359 * src/modest-search.h:
2360 Changed minsize from unspecific guint to guint32.
2362 * src/modest-search.c:
2364 Added strange hack which magically made tnymail work.
2366 (modest_search_folder),
2367 (modest_search_account),
2368 (modest_search_all_accounts):
2369 Implement helper functions to search all accounts, specific account
2372 * tests/dbus_api/Makefile.am:
2373 * tests/dbus_api/test_open_message.c:
2374 Read url to open from commandline.
2376 * tests/dbus_api/test_search.c:
2377 Implement small test for dbus search stuff
2379 2007-06-02 Armin Burgmeier <armin@openismus.com>
2381 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2382 include account type and account title. This fixes projects.maemo.org
2385 * src/maemo/modest-account-view-window.c: Set a title for the window.
2387 2007-06-02 Armin Burgmeier <armin@openismus.com>
2389 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2390 incoming and outgoing server name based on email address and server
2391 types as long as the names have not been edited manually. This fixes
2392 projects.maemo.org bug NB#58671.
2394 2007-06-02 Armin Burgmeier <armin@openismus.com>
2396 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2397 server type cannot be changed in future to the incoming details page
2398 when creating an account. This fixes projects.maemo.org bug NB#59029.
2400 2007-06-02 Armin Burgmeier <armin@openismus.com>
2402 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2403 and assigned max width chars so that they wrap instead of being
2404 truncated. Fixes projects.maemo.org bug NB#56126.
2406 2007-06-02 Armin Burgmeier <armin@openismus.com>
2408 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2409 introductory note to the connection specific smtp servers dialog, as
2410 section 8.12 of the email UI specification requires. This fixes
2411 projects.maemo.org bug NB#59212.
2413 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2416 Check for running mail operations, and offer to cancel them, as per the UI
2417 spec. This fixes projects.maemo.org bug NB#59041 .
2418 However, I suspect that tinymail may still use the network connection
2419 in ways that we cannot detect or cancel. But it should at least adapt to
2420 changes fairly well.
2422 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2424 * src/modest-tny-account-store.c: (recreate_all_accounts),
2425 (get_cached_accounts), (get_server_accounts): Do more sensible
2426 ref-counting of the temporarily-cached outbox accounts list. This seems
2427 to fix a crash when entering the password when the password was wrong.
2429 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2431 * src/gnome/modest-main-window.c: (connect_signals):
2432 * src/modest-tny-account-store.c: (get_password),
2433 (modest_tny_account_store_alert): Added comments and clues and
2434 commented-out code about how we currently fail to deal with connection
2435 errors and wrong passwords, and how we should.
2437 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2439 * src/widgets/modest-retrieve-combo-box.c:
2440 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2441 This fixes projects.maemo.org bug NB#58472 .
2443 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2445 * src/maemo/easysetup/modest-easysetup-wizard.c:
2446 (create_page_complete_easysetup):
2447 (create_page_complete_custom): Correct the last commit,
2448 putting the correct sentences in the correct pages.
2450 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2452 * src/maemo/easysetup/modest-easysetup-wizard.c:
2453 (create_page_complete_custom): Show the second sentence of text
2454 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2457 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2460 Set the leave-on-server conf key by default. This fixes
2461 projects.maemo.org bug NB#59258 .
2463 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-account-view-window.c:
2466 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2467 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2470 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2472 * src/maemo/easysetup/modest-easysetup-wizard.c:
2473 (create_caption_new_with_asterisk):
2474 * src/maemo/modest-account-settings-dialog.c:
2475 (create_caption_new_with_asterisk):
2476 Uncomment the code to add the asterisk, because they are no longer in the
2477 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2478 (update_incoming_server_title): Add an asterisk here too.
2480 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2482 * src/maemo/modest-maemo-global-settings-dialog.c:
2483 (current_connection): Check that we are even connected before trying to
2484 get the current connection name, to prevent a warning.
2486 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2487 Change the comments because tny_maemo_conic_device_connect() is now meant to
2489 * src/modest-mail-operation.c:
2490 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2491 make sure we have a connection and fail if we can't connect.
2493 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/modest-main-window.c:
2496 (on_account_store_connecting_finished): Do not try to get the
2497 connection ID if we are not really connected. I am surprised that
2498 this signal handler is called when we are not connected.
2500 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2502 * src/modest-error.h:
2503 * src/modest-ui-actions.c:
2504 (modest_ui_actions_get_msgs_full_error_handler):
2505 Renamed an enum, added comments, added an enum
2506 for retrieve-limit errors.
2508 * src/modest-mail-operation.c: (foreach_add_item),
2509 (internal_folder_observer_update), (update_account_thread),
2510 (modest_mail_operation_get_msgs_full):
2511 (modest_mail_operation_update_account),
2512 Added comments about how this works, and some code that should
2513 (but does not) check the retrieve-limit. See the TODO comment.
2515 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2517 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2518 Initialize help_id to fix the build. Warnings are good.
2520 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2522 * src/widgets/modest-hbox-cell-renderer.c:
2523 (modest_hbox_cell_renderer_append):
2524 * src/widgets/modest-vbox-cell-renderer.c:
2525 (modest_vbox_cell_renderer_append):
2526 Fix the last commit by doing an extra ref.
2528 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2530 * src/widgets/modest-hbox-cell-renderer.c:
2531 (modest_hbox_cell_renderer_append):
2532 * src/widgets/modest-vbox-cell-renderer.c:
2533 (modest_vbox_cell_renderer_append):
2534 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2535 to fix the build with Maemo Bora.
2536 However, there seems to be a remaining crash, probably due to reference
2539 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2541 * src/modest-tny-account.c:
2542 (modest_tny_account_new_for_local_folders):
2543 Use hildon_file_system_info_async_new() to get a better name for
2544 the memory card account, setting it as the account name.
2545 The timing seems to work, but this is probably
2546 not the best place to do this. See the TODO comment.
2547 * src/maemo/modest-main-window.c: (create_details_widget):
2548 * src/widgets/modest-folder-view.c: (text_cell_data):
2549 Use the tny account name instead of hardcoding a name.
2551 2007-05-30 Christian Kellner <ckellner@openismus.com>
2553 * src/modest-search.c: (modest_search):
2554 Correctly set part_search_func even if we have already parsed
2555 the query and thus a valid OgsTextSearcher object.
2557 2007-05-30 Christian Kellner <ckellner@openismus.com>
2560 Search and check for libogs.
2563 Incooparte the ogs build env.
2565 * src/modest-mime-part-search-stream.c:
2566 * src/modest-mime-part-search-stream.h:
2567 Removed since we do the real searching now in modest-search.c.
2569 * src/modest-search.c:
2570 * src/modest-search.h:
2571 Implement support for ogs. We use that if available and requested
2572 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2573 should now handle the corner case when the search term is spread
2574 across multiple reads.
2575 Also the logic in modest_search () was corrected to search all
2576 requested fields until one is found.
2578 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2580 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2582 * src/modest-init.h:
2583 * src/modest-init.c: Made modest_init_local_folders() take a
2584 path and be public so we can iniitialize maildir folders on
2587 * src/modest-local-folder-info.h:
2588 * src/modest-local-folder-info.c:
2589 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2591 * src/modest-tny-account.c:
2592 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2593 still means the standard local-folders path on the local volume.
2595 * src/modest-tny-account-store.c:
2596 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2597 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2598 all accounts when that happens.
2599 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2600 this too, so it shows up in the treeview.
2602 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2604 * src/maemo/modest-maemo-global-settings-dialog.c:
2605 (current_connection):
2606 * src/widgets/modest-global-settings-dialog.c:
2607 (current_connection_default):
2608 Use the enum values instead of 0, 1 and -1,
2609 to make the code clearer.
2611 * src/modest-account-mgr-helpers.c:
2612 (modest_account_mgr_get_connection_specific_smtp): Make this code
2615 * src/modest-runtime.h:
2616 * src/modest-runtime.c:
2617 Added modest_runtime_remove_all_send_queues().
2618 * src/maemo/modest-main-window.c:
2619 (on_account_store_connecting_finished): Recreate the send queues,
2620 using the appropriate transport accounts for this new connection.
2621 Some futher adapting might be needed if the old send queues are not
2622 automatically stopped at this point.
2624 * src/modest-tny-account-store.c: (get_server_accounts):
2625 Create the connection-specific transport accounts, so that they can
2626 be found later by their ID.
2628 * src/modest-tny-account.h:
2629 * src/modest-tny-account.c:
2630 Added modest_tny_account_new_from_server_account_name().
2631 modest_tny_account_new_from_server_account(): Do not create the
2632 send queues here, because they will be
2633 recreated anyway when the connection changes for the first time.
2635 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2637 * src/modest-local-folder-info.h:
2638 * src/modest-local-folder-info.c:
2639 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2640 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2641 tbox_folder): Take a modest account name instead of a server TnyAccount,
2642 so we can have per-modest-account rather than per-transport-account
2644 We must make sure that we change or recreate the exisitng send queues
2645 when the connection changes for connection-specific transport accounts.
2647 * src/modest-tny-account-store.c:
2648 (create_per_account_local_outbox_folders): Create outboxed per modest
2649 account, not per transport account.
2651 * src/modest-tny-account.h:
2652 * src/modest-tny-account.c:
2653 (modest_tny_account_get_special_folder): For outboxes, get the
2654 parent modest account name. The account is ignored for other folders.
2655 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2656 modest account name rather than a server TnyAccount.
2658 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2660 * src/modest-tny-account.c:
2661 (modest_tny_account_new_from_server_account):
2662 Call modest_runtime_get_send_queue() immediately after creating transport
2663 accounts, so that they start trying to send email from the outbox as soon
2664 as possible at startup. This is probably what we want.
2666 * src/modest-mail-operation.c: (update_account_thread):
2667 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2668 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2669 * src/modest-tny-send-queue.h:
2670 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2671 (modest_ui_actions_on_send):
2672 Added comments about how sending works, though it needs some more work.
2674 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2676 * src/modest-tny-account.c:
2677 (modest_tny_account_get_special_folder): Add TODO because this fails when
2678 the network is busy.
2679 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2680 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2681 Do not try to show this window when there is no active account. The UI
2682 specs does not tell us what to do in this case.
2684 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2688 * src/maemo/Makefile.am:
2689 * src/widgets/Makefile.am: Some dist fixes.
2691 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2693 * src/maemo/modest-connection-specific-smtp-window.c:
2694 (on_button_edit): Make the code clearer, to prevent a double free.
2696 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/modest-account-settings-dialog.c:
2699 (modest_account_settings_dialog_set_account_name),
2700 Check the connection-specific smtp servers checkbox if there are any.
2702 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2703 (modest_connection_specific_smtp_edit_window_init):
2704 Start with a suitable port number.
2706 * src/modest-account-mgr-helpers.h:
2707 * src/modest-account-mgr-helpers.c: Added
2708 modest_account_mgr_get_has_connection_specific_smtp().
2710 (modest_account_mgr_set_connection_specific_smtp),
2711 (modest_account_mgr_remove_connection_specific_smtp),
2712 (modest_account_mgr_get_has_connection_specific_smtp),
2713 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2714 connection-specific smtp server accounts in the account, rather than
2715 the server account conf dir.
2717 This fixes bug projects.maemo.org bug NB#58263 .
2719 * src/modest-tny-account-store.c:
2720 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2721 if there are no server accounts yet, to prevent an infinite loop when there
2722 are no accounts. Document that one must be called before the other.
2724 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2726 * src/modest-account-mgr-helpers.c:
2727 (modest_account_mgr_get_default_account): Make sure that at least
2728 one account is always the default, if there are any enabled accounts.
2729 This is just a sanity check that shouldn't be necessary.
2731 * src/modest-account-mgr-priv.c:
2732 (_modest_account_mgr_account_from_key): Unescape the conf key to
2733 get the real account name. For instance, this is an issue if a space
2734 was in the account name, which can happen because the account name
2735 is generated from the display name.
2736 (_modest_account_mgr_get_account_keyname): Always escape the
2738 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2739 Unescape the conf keys to get the real account names.
2741 For instance, previously the is-default radio button in the accounts
2742 list was not checked for any accounts at first. This fixes that,
2743 and might fix several similar bugs.
2745 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2747 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2748 Removed some debug printfs.
2750 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2752 Modest on-disk outbox directories are now here, for instance:
2753 $HOME/.modest/outboxes/<account-id-1>/outbox
2754 $HOME/.modest/outboxes/<account-id-2>/outbox
2756 $HOME/.modest/local-folders/outbox
2757 so we can have a separate outbox for each account.
2758 But they are shown as one outbox in the GtkTreeView, by using a
2759 TnyMergeFolder in a ModestTnySimpleFolderStore.
2762 * src/modest-tny-simple-folder-store.c:
2763 * src/modest-tny-simple-folder-store.h:
2764 Added ModestTnySimpleFolderStore, used to contain folders from
2765 other folder stores, such as other accounts.
2767 * src/modest-tny-outbox-account.h:
2768 * src/modest-tny-outbox-account.c:
2769 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2770 used for the per-account local outbox folders.
2772 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2773 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2774 only use this (internally) now for the non-outbox local folders.
2776 * src/modest-init.h:
2777 * src/modest-init.c: Added modest_init_one_local_folder(), for
2778 setting up the directory structure for each local folder.
2780 * src/modest-local-folder-info.c:
2781 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2782 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2784 * src/modest-local-folder-info.h:
2785 * src/modest-tny-account-store.c: (on_account_removed),
2786 (on_account_changed), (create_per_account_local_outbox_folders),
2787 (get_server_accounts), (modest_tny_account_store_get_accounts),
2788 (modest_tny_account_store_get_tny_account_by_account),
2789 (modest_tny_folder_store_is_virtual_local_folders):
2791 * src/modest-tny-account.h:
2792 * src/modest-tny-account.c:
2793 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2794 to create an on-disk per-account local outbox folder for each
2796 (create_per_account_local_outbox_folders): Create a local outbox folder
2797 for each transport account.
2798 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2799 for all local folders.
2801 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2802 instead of using g_object_get/set() directly. It is clearer.
2804 (modest_tny_folder_store_get_message_count),
2805 (modest_tny_folder_store_get_local_size
2806 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2807 because we now use these with non-acount folder stores.
2809 (modest_tny_account_get_special_folder),
2810 (modest_tny_account_new_from_server_account),
2811 (modest_tny_account_new_from_account):
2812 (recurse_folders): Adjust to the new outbox system.
2814 * src/modest-tny-folder.h:
2815 * src/modest-tny-folder.c:
2816 (modest_tny_folder_is_local_folder),
2817 (modest_tny_folder_get_local_folder_type),
2818 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2820 * src/widgets/modest-main-window.h:
2821 * src/maemo/modest-main-window.c: (create_details_widget),
2822 (modest_main_window_set_contents_style): Show details for any folder store,
2825 (modest_tny_folder_get_rules):
2826 Remove the const. C does not support constness enough for this.
2828 * src/modest-ui-actions.c:
2829 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2830 make all outboxes appear as one, in the usual local-folders tree node.
2832 (set_active_account_from_tny_account),
2833 (modest_ui_actions_on_folder_selection_changed):
2834 * src/widgets/modest-folder-view.c: (text_cell_data),
2835 (icon_cell_data), (filter_row),
2836 (add_account_folders_to_merged_folder),
2837 (add_account_folders_to_simple_folder_store), (),
2838 (get_cmp_rows_type_pos), (cmp_rows),
2839 (modest_folder_view_set_account_id_of_visible_server_account):
2840 Adjust to the new outbox system, using generic folder stores and folders
2841 in the GtkTreeModel.
2843 2007-05-23 Christian Kellner <ckellner@openismus.com>
2845 * src/modest-mail-operation.c:
2846 (modest_mail_operation_update_account):
2847 Use info->max_size instead of unintialized local var [small
2848 build fix]. (Added TODO to review that change since I don't
2851 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2853 * libmodest-dbus-client/libmodest-dbus-client.c:
2854 (libmodest_dbus_client_compose_mail): function added
2855 * src/dbus_api/modest-dbus-api.h:
2856 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2857 (on_compose_mail): Implementation of the SendAsMail functionality
2859 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2861 * src/modest-account-mgr.c:
2862 (modest_account_mgr_add_server_account): Set the secure-connection
2863 conf key for transport accounts as well as store accounts. I don't know
2864 why the if was there. For instance, this makes sure that we use SSL
2865 for the gmail preset from the easysetup wizard.
2867 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2869 * src/gnome/modest-main-window.c:
2870 (on_account_store_connecting_finished), (connect_signals):
2871 * src/maemo/modest-main-window.c:
2872 (on_account_store_connecting_finished), (connect_signals),
2873 (modest_main_window_new):
2874 Handle TnyAccountStore::connecting-finished instead of
2875 TnyDevice::connection-changed, because we cannot actually perform
2876 operations on accounts until TnyAccountStore has itself responded to
2877 the TnyDevice::connection-changed signal. This prevents a GError from
2879 Do not try to update at startup, because we (at least on scratchbox)
2880 already do an update at startup when the device goes online.
2881 This prevents a GError from tinymail.
2882 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2883 Added TODO about stopping simultaneous operations.
2885 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2887 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2888 * src/modest-mail-operation-queue.c:
2889 (modest_mail_operation_queue_remove):
2890 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2891 about where they happened.
2893 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2895 * src/modest-ui-actions.c:
2896 (modest_ui_actions_on_password_requested): Make sure that the remember
2897 output parameter is always TRUE.
2899 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2901 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2902 Show a OK/Cancel dialog if the error is a question, though we still do not
2903 know anything more about what we are asking the user.
2904 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2905 Fix an uninitialized variable (helper). This is a logic error, however.
2907 2007-05-21 Christian Kellner <ckellner@openismus.com>
2909 * src/modest-search.h:
2910 Correct bit shifting in the ModestSearchFlags enum.
2912 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2914 * src/modest-tny-account.c:
2915 (modest_tny_account_new_from_server_account): Do not use the lsub and
2916 check-all hard-coded IMAP options when using POP.
2918 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2920 * src/modest-tny-account.c:
2921 (modest_tny_account_new_from_server_account):
2922 Use NULL for the secure-auth method for POP when Password auth has been
2923 specified by the user, as we already do for IMAP. "auth=Login" causes
2924 an error from camel or the server.
2926 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2928 * src/maemo/modest-account-settings-dialog.c:
2929 (create_page_account_details),
2930 (modest_account_settings_dialog_set_account_name):
2931 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2932 for the leave-on-server checkbox, rathr than just the checkbox, when
2933 the protocol is not POP.
2935 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2937 * src/widgets/modest-account-view.c:
2938 * src/widgets/modest-account-view.h:
2939 Added modest_account_view_select_account() which will be useful later
2940 to asynchronously re-select the edited account.
2942 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2944 * src/maemo/modest-account-settings-dialog.c:
2945 (modest_account_settings_dialog_set_account_name):
2946 Automatically choose the port numbers based on the secure authentication
2947 methods, if they have not been chosen before.
2948 This fixes projects.maemo.org bug NB#56273 .
2950 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/modest-main-window-ui.h:
2953 * src/modest-ui-actions.c:
2954 * src/modest-ui-actions.h:
2955 Connect the Tools/SMTP Servers menu item to
2956 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2957 SMTP servers dialog, as in the UI specification and saves changes when it
2958 is closed. This fixed projects.maemo.org bug NB#56305 .
2960 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2962 * src/maemo/modest-connection-specific-smtp-window.c:
2963 (modest_connection_specific_smtp_window_init):
2964 Use gtk_window_set_default_size() to make this window big enough, so
2965 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2967 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2969 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2971 (modest_connection_specific_smtp_edit_window_init),
2972 Do not try to connect to a combobox signal before the combobox exists.
2973 This fixes the cras in projects.maemo.org bug NB#56288 .
2974 (modest_connection_specific_smtp_edit_window_get_settings):
2975 Remove the server_account_name parameter which was being checked for NULL
2976 though it was not used.
2978 * src/maemo/modest-connection-specific-smtp-window.c:
2979 (modest_connection_specific_smtp_window_fill_with_connections),
2980 (on_button_edit), (modest_connection_specific_smtp_window_init):
2981 Correct the number of treemodel columns to prevent a warning.
2982 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2983 libconic does not work.
2985 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2987 * src/modest-tny-account.c:
2988 (modest_tny_account_new_from_server_account):
2989 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2990 SMTP when "None" was chosen by the user. However, with my SMTP server that
2991 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2994 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2996 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2997 to explain the memory management issue with the ID in the ModestPair.
2999 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3000 (add_sending_page), (modest_account_assistant_finalize):
3001 * src/gnome/modest-gnome-global-settings-dialog.c:
3002 (create_updating_page), (create_composing_page):
3003 * src/gnome/modest-msg-edit-window.c: (get_transports),
3004 (init_window), (modest_msg_edit_window_finalize),
3005 (modest_msg_edit_window_get_msg_data):
3006 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3007 * src/gnome/modest-transport-widget.c:
3008 (modest_transport_widget_finalize), (smtp_configuration):
3009 * src/maemo/modest-maemo-global-settings-dialog.c:
3010 (create_updating_page), (create_composing_page):
3011 * src/maemo/modest-msg-edit-window.c: (get_transports),
3012 (init_window), (modest_msg_edit_window_finalize),
3013 (modest_msg_edit_window_get_msg_data),
3014 (modest_msg_edit_window_free_msg_data):
3015 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3016 (modest_store_widget_finalize):
3017 * src/maemo/modest-transport-widget.c:
3018 (modest_transport_widget_finalize), (smtp_configuration):
3019 * src/modest-main.c: (send_mail):
3020 * src/widgets/modest-combo-box.h:
3021 * src/widgets/modest-global-settings-dialog-priv.h:
3022 * src/widgets/modest-global-settings-dialog.c:
3023 (modest_global_settings_dialog_finalize):
3024 * src/widgets/modest-msg-edit-window.h:
3025 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3026 as long as the combo box, to prevent use of freed memory for the ID.
3028 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3030 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3031 get_accounts(), to make this clearer. Do not check for the enabled gconf
3032 key, because we do not use this for server accounts (at least, not yet).
3033 This allows us to send email again.
3035 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3037 * src/maemo/modest-platform.c:
3038 (on_modest_conf_update_interval_changed), (modest_platform_init):
3039 Only respond to this particular key change. All these strcmp()s cannot be
3042 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3044 * src/maemo/modest-maemo-global-settings-dialog.c:
3045 (current_connection): Prevent a crash in scratchbox when
3046 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3047 * src/maemo/modest-platform.c:
3048 (on_modest_conf_update_interval_changed), (modest_platform_init):
3049 Get the update interval from gconf and reset it when the gconf key changes.
3051 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-protocol-info.c:
3054 * src/modest-protocol-info.h: Adde enum-specific get functions,
3055 instead of using a ModestProtocolType enum parameter.
3057 * src/gnome/modest-account-assistant.c:
3058 * src/gnome/modest-store-widget.c:
3059 * src/gnome/modest-store-widget.h:
3060 * src/gnome/modest-transport-widget.c:
3061 * src/gnome/modest-transport-widget.h:
3062 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3063 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3064 * src/maemo/easysetup/modest-easysetup-wizard.c:
3065 * src/maemo/modest-account-settings-dialog.c:
3066 * src/maemo/modest-account-settings-dialog.h:
3067 * src/maemo/modest-store-widget.c:
3068 * src/maemo/modest-store-widget.h:
3069 * src/maemo/modest-transport-widget.c:
3070 * src/maemo/modest-transport-widget.h:
3071 * src/modest-account-mgr-helpers.c:
3072 * src/modest-account-mgr-helpers.h:
3073 * src/modest-account-mgr.c:
3074 * src/modest-account-mgr.h:
3075 * src/modest-tny-account.c:
3076 * src/modest-tny-folder.c:
3077 * src/widgets/modest-account-view.c:
3078 * src/widgets/modest-retrieve-combo-box.c:
3079 * src/widgets/modest-retrieve-combo-box.h:
3080 * src/widgets/modest-secureauth-combo-box.c:
3081 * src/widgets/modest-serversecurity-combo-box.c:
3082 * src/widgets/modest-serversecurity-combo-box.h:
3083 * tests/check_account-mgr.c:
3084 Use the specific functions, and use the re-renamed enum values for GNOME too.
3086 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3088 * src/modest-pair.h:
3089 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3090 so we can get the second based on the first.
3092 * src/maemo/modest-account-settings-dialog.h:
3093 * src/maemo/modest-account-settings-dialog.c:
3094 Added get_supported_secure_authentication_methods(), though it is mostly
3095 commented-out for now until the necessary API is committed to tinymail.
3096 (modest_account_settings_dialog_set_account_name),
3097 (save_configuration): Request the supported authentication methods from the
3098 server, so we can choose a working method.
3100 * src/modest-tny-account-store.h:
3101 * src/modest-tny-account-store.c:
3102 (modest_tny_account_store_get_session): Rename from
3103 tny_account_store_get_session().
3105 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3107 * src/modest-protocol-info.h: Split the ModestProtocol enum
3108 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3109 There was no need to have these unrelated values in one enum.
3111 * src/: many files: Adapted to changed enum. This makes the code a bit
3112 clearer, and the compiler could catch some errors.
3114 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3116 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3117 Show the detailed internal camel error message when an error happens
3118 during the configuration, so that our testers can give us more clues.
3119 For instance, in projects.maemo.org bug NB#56910 .
3121 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3123 * src/modest-tny-account.c:
3124 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3125 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3127 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3129 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3130 * src/maemo/modest-account-settings-dialog.c:
3131 (modest_account_settings_dialog_set_account_name),
3132 (save_configuration): For the incoming secure authentication checkbox,
3133 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3134 the UI specification. PLAIN does not seem to be supported for most IMAP
3135 servers anyway, and I am not sure what it would mean.
3136 However, we probably need to discover which of the secure-authentication
3137 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3138 * src/modest-account-mgr-helpers.c:
3139 (modest_account_mgr_get_server_account_data):
3141 * src/modest-tny-account.c:
3142 (modest_tny_account_new_from_server_account):
3143 Use tny_account_set_mech() to set secure-authentication methods,
3144 with some special-casing for IMAP, based on my observations of how
3147 * src/modest-account-mgr-helpers.h:
3148 * src/modest-account-mgr.c:
3149 * src/modest-defs.h: Comment that the URI is only used for local folders.
3151 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3154 parameter const, just to be neat.
3155 * src/modest-text-utils.c: (modest_text_utils_inline):
3156 End g_strconcat() with NULL, as its documentation says. This is almost
3157 certainly the cause of my crash at startup on the device. Interestingly,
3158 valgrind doesn't tell us about these errors.
3160 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3162 * scripts/build-packages: Added more precise comments about how to use
3163 this script, though I still get this error:
3164 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3165 error building tinymail
3167 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3169 * src/maemo/modest-main-window.c: (on_account_update):
3170 Very slight cleanup, hoping to make it simpler to discover what causes
3171 a crash here sometimes.
3173 * src/modest-tny-account.c:
3174 (modest_tny_account_new_from_server_account): Set the port. Added
3175 comments about the options and a TODO comment because I need to find out
3176 how to specify the secure authentication method.
3178 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3180 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3181 changed CFlags paths form modest to libmodest
3183 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3185 * src/modest-account-mgr-helpers.c:
3186 (modest_account_mgr_get_server_account_data),
3187 (modest_account_mgr_free_server_account_data):
3188 * src/modest-account-mgr-helpers.h:
3189 * src/modest-account-mgr.c:
3190 (modest_account_mgr_add_server_account):
3191 * src/modest-defs.h:
3192 * src/modest-tny-account.c:
3193 (modest_tny_account_new_from_server_account):
3194 Determine the options for tny_camel_account_add_option() here,
3195 based on the settings, rather than storing them directly in gconf.
3197 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3199 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3200 Show a more friendly error dialog now that we expect (from the tinymail
3201 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3203 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3205 * src/maemo/modest-main-window.c: (on_account_update): Check that
3206 account_name is not NULL, to prevent a crash at startup that I am
3207 seeing on the N800. I do wonder why it is NULL.
3209 * src/maemo/easysetup/modest-easysetup-wizard.c:
3210 (create_page_user_details):
3211 * src/maemo/modest-account-settings-dialog.c:
3212 (create_page_user_details), (create_page_outgoing):
3213 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3214 (modest_connection_specific_smtp_edit_window_init):
3215 * src/modest-ui-actions.c:
3216 (modest_ui_actions_on_password_requested):
3217 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3218 might do something useful with the on-screen keyboard.
3220 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3222 * src/maemo/modest-main-window.c: (on_account_update):
3223 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3224 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3226 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3228 * src/modest-tny-account-store.c: (on_account_changed):
3229 Correct the signature of this signal handler.
3231 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3233 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3234 Show a HildonNote instead of a GtkDialog for Maemo.
3236 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3238 * src/widgets/modest-account-view.h:
3239 * src/widgets/modest-account-view.c: (on_account_changed),
3240 (on_account_removed). Added a boolean flag, set/unset by
3241 modest_account_view_block_conf_updates(),
3242 modest_account_view_unblock_conf_updates() to prevent unnecessary
3243 updates, but this is not very useful because the gconf notifications are
3244 so delays (maybe only on Maemo Bora).
3245 So auto-updating is turned off, and these functions do an explicit
3246 update when necessary.
3247 However, something else is still doing too much work when adding/removing
3248 accounts, probably in another part of the application.
3250 * src/maemo/modest-account-view-window.c:
3251 (on_delete_button_clicked), (on_edit_button_clicked),
3252 (on_new_button_clicked): Use the new functions.
3254 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3256 * src/modest-account-mgr-helpers.c:
3257 (modest_account_mgr_set_first_account_as_default):
3258 Sort the list of names alphabetically-by-title, so we choose the first one
3260 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3261 alphabetically by the title.
3263 This fixes projects.maemo.org bug NB#56418 .
3265 * src/modest-account-mgr-priv.c:
3266 (_modest_account_mgr_account_from_key):
3267 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3268 avoid a valgrind error, and possible random behaviour.
3270 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3272 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3273 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3274 tinymail documentation to say that this can be expected.
3275 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3276 pretty, and should not happen, but I would prefer to know when it does.
3278 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3280 * configure.ac: When using the older hildon version, probably on Bora,
3281 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3283 * src/widgets/modest-attachment-view.c:
3284 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3287 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3289 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3290 Implemented the prototype. Can be tested with
3291 tests/dbus_api/test_open_message:
3293 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3295 * src/modest-tny-account-store.c:
3296 (modest_tny_account_store_instance_init), (get_password):
3297 * src/modest-ui-actions.c:
3298 (modest_ui_actions_on_password_requested):
3299 Do not store the password in gconf, because this function is called
3300 for non-remembered passwords. Actually use the cached (in the hash map)
3301 password instead of releasing it.
3302 The password will now not be remembered if it is asked via the protected
3303 password dialog, as per the UI spec.
3305 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3307 * src/modest-defs.h:
3308 * src/modest-account-mgr-helpers.h:
3309 * src/modest-account-mgr-helpers.c:
3310 Added modest_server_account_get_username_has_succeeded(),
3311 modest_server_account_set_username_has_succeeded().
3312 (modest_server_account_set_username),
3313 Reset the has-succeeded flag if the username changes.
3315 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3316 * src/maemo/modest-connection-specific-smtp-window.c:
3317 (modest_connection_specific_smtp_window_save_server_accounts):
3318 Use modest_server_account_set_username() instead of using
3319 modest_conf_set_string() directly, so that the has-succeeded flag is always
3322 * src/modest-ui-actions.c:
3323 (modest_ui_actions_on_password_requested): Dim the username entry if
3324 the username has ever worked, as per the UI spec.
3326 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3328 * src/modest-tny-account-store.c: (get_password):
3329 * src/modest-ui-actions.c:
3330 (modest_ui_actions_on_password_requested):
3331 Allow the username to be changed too, though there is more work to
3332 be done on exactly how this behaves.
3334 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-account-mgr-helpers.h:
3337 * src/modest-account-mgr-helpers.c:
3338 Added modest_account_mgr_get_display_name(),
3339 modest_server_account_get_username(),
3340 modest_server_account_set_username(),
3341 modest_server_account_set_password(),
3342 modest_server_account_get_hostname() functions so we do not need to
3343 use the conf API directly.
3345 * src/maemo/modest-main-window.c: (connect_signals):
3346 Actually connect ot the ModestAccountStore::request-password signal,
3347 so that we show the dialog when the password is requested by Tinymail,
3348 for isntance if it is empty.
3350 * src/modest-marshal.list:
3351 * src/modest-tny-account-store.c:
3352 (modest_tny_account_store_class_init), (get_password),
3353 (modest_tny_account_store_alert):
3354 * src/modest-tny-account-store.h:
3355 * src/modest-ui-actions.h:
3356 * src/modest-ui-actions.c:
3357 (modest_ui_actions_on_password_requested):
3358 Change the signal parameters, so it is obvious that we are providing
3359 the non human-readable server name, and receiving both the username
3360 and password, though changing of the username is not yet implemented.
3361 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3362 for the GNOME version.
3364 This should fix the projects.maemo.org bug NB#56209, though it does not
3365 work on Bora, because the gconf_client_get() for the password fails
3366 immediately after we save it with gconf_client_set().
3368 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3371 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3372 caused an undefined symbol error:
3373 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3375 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3377 * src/modest-tny-account-store.c:
3378 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3379 using a GError instead of a string message, so we can translate it in
3382 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3384 * src/maemo/modest-address-book.c:
3385 (modest_address_book_check_names):
3386 * src/maemo/modest-msg-view-window.c:
3387 (modest_msg_view_window_clipboard_owner_change):
3388 * src/modest-init.c: (modest_init_init_ui):
3389 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3390 (update_folders_cb), (modest_mail_operation_update_account):
3391 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3392 (modest_ui_actions_on_msg_attachment_clicked),
3393 (modest_ui_actions_on_msg_recpt_activated):
3394 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3395 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3396 (modest_msg_view_search_next):
3397 * src/widgets/modest-recpt-editor.c:
3398 (modest_recpt_editor_on_button_release_event),
3399 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3400 g_message(). At this point we should only be seeing interesting errors on
3401 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3403 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3405 (modest_wizard_dialog_force_title_update):
3406 * src/maemo/easysetup/modest-wizard-dialog.h:
3407 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3408 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3409 can update the title when appropriate. Otherwise the title is wrong if the
3410 pages are added after adding the notebook to the dialog.
3411 This must be a problem in HildonWizardDialog too.
3412 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3414 * src/maemo/easysetup/modest-easysetup-wizard.c:
3415 (create_subsequent_customsetup_pages),
3416 (create_subsequent_easysetup_pages):
3417 Call modest_wizard_dialog_force_title_update() so that the title is
3418 correct even with GTK+ < 2.10.
3419 This fixes projects.maemo.org bug NB#56145 .
3421 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3423 * src/maemo/modest-platform.c:
3424 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3425 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3428 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3430 * src/widgets/modest-window.h:
3431 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3432 and modest_window_save_state(), which invokes it.
3434 * src/widgets/modest-window-mgr.h:
3435 * src/widgets/modest-window-mgr.c:
3436 Added modest_window_mgr_save_state_for_all_windows(), which calls
3437 the save_state vfunc on all registered windows, if implemented.
3439 * src/gnome/modest-msg-edit-window.c:
3440 * src/gnome/modest-msg-view-window.c:
3441 * src/maemo/modest-msg-edit-window.c:
3442 * src/maemo/modest-msg-view-window.c:
3443 * src/maemo/modest-main-window.c:
3444 Specify the existing save_settings functions as implementations of
3445 ModestWindow::save_state_func().
3447 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3448 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3449 enabling hibernation, for instance.
3451 We may need to do the same thing for restoring settings.
3454 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3456 * src/widgets/modest-window-mgr.c:
3457 * src/widgets/modest-window-mgr.h:
3458 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3459 modest_window_mgr_get_hibernation_is_prevented().
3461 * src/maemo/modest-main-window.c:
3462 (on_hildon_program_is_topmost_notify): Prevent hibernation
3463 (possible when the application goes to the background in the WM),
3464 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3466 * src/maemo/easysetup/modest-easysetup-wizard.c:
3467 (modest_easysetup_wizard_dialog_init):
3468 * src/maemo/modest-account-settings-dialog.c:
3469 (modest_account_settings_dialog_init):
3470 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3471 (modest_connection_specific_smtp_edit_window_init):
3472 * src/maemo/modest-connection-specific-smtp-window.c:
3473 (modest_connection_specific_smtp_window_init):
3474 * src/maemo/modest-signature-editor-dialog.c:
3475 (modest_signature_editor_dialog_init):
3476 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3477 prevent hibernation while any of these account settings dialogs are open.
3479 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3481 * src/maemo/Makefile.am:
3482 * src/maemo/modest-osso-state-saving.c:
3483 * src/maemo/modest-osso-state-saving.h: Added
3484 modest_osso_load_state() and modest_osso_save_state() though they do
3485 nothing now. They should iterate through all the open windows and load/save
3487 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3488 save state when closing.
3490 * src/maemo/modest-main-window.c:
3491 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3492 Add a notification handler for the HildonProgram::is-topmost property,
3493 so we can allow hibernation when the application goes into the background.
3494 But we still need to detect when the accounts setup windows are open so
3495 we can stop hibernation when they are open.
3496 To do this, I also added the main window the HildonProgram. This might have
3497 other side-effects/benefits, and should maybe be done for other windows.
3499 * src/maemo/modest-osso-autosave-callbacks.h:
3500 * src/maemo/modest-osso-autosave-callbacks.c:
3501 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3502 though it does not do anything yet, and we might never need this to do
3503 anything. For instance, we already save drafts.
3505 * src/maemo/modest-platform.c: (modest_platform_init):
3506 Specify the libosso auto-save callback.
3508 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/modest-platform.c:
3511 (modest_platform_set_update_interval):
3512 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3513 aparently stays valid between application instances, so we can use this
3514 to remove and reset it later. According to a maemo-developers email from
3517 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3519 * configure.ac: Depend on libalarm for Maemo.
3521 * src/dbus_api/modest-dbus-api.h:
3522 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3523 (on_send_receive), (modest_dbus_req_handler):
3524 Handle a SEND_RECEIVE D-Bus method.
3526 * libmodest-dbus-client/libmodest-dbus-client.c:
3527 (libmodest_dbus_client_send_and_receive):
3528 * libmodest-dbus-client/libmodest-dbus-client.h:
3529 Add C convenience functions for calling the new D-Bus method.
3531 * src/modest-platform.h:
3532 * src/gnome/modest-platform.c:
3533 * src/maemo/modest-platform.c:
3534 Added modest_platform_set_update_interval(), which uses the
3535 alarmd API on Maemo.
3536 (modest_platform_init),
3537 Call modest_platform_set_update_interval(), using a hard-coded
3538 interval for now (until the global settings dialog is implemented),
3539 though I am not sure that this makes sense yet.
3541 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3543 * src/dbus_api/modest-dbus-callbacks.c:
3544 (modest_osso_cb_hw_state_handler):
3545 * src/dbus_api/modest-dbus-callbacks.h:
3546 * src/maemo/modest-platform.c: (modest_platform_init):
3547 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3548 in case this has some effect on the ability for Maemo to ping the
3551 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3553 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3554 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3555 warning. It is probably a logic error, but I need to fix the build.
3557 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3559 * src/modest-account-mgr.h:
3560 * src/modest-account-mgr.c:
3561 (modest_account_mgr_account_names): Add a gboolean enabled_only
3562 parameter, so we can get lists of onlt the enabled accounts.
3564 (modest_account_mgr_add_account),,
3565 (modest_account_mgr_account_with_display_name_exists):
3566 * src/maemo/modest-msg-edit-window.c: (get_transports):
3567 * src/modest-account-mgr-helpers.c:
3568 (modest_account_mgr_set_first_account_as_default):
3569 * src/modest-init.c: (init_default_account_maybe):
3570 * src/modest-tny-account-store.c: (get_accounts):
3571 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3572 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3573 * tests/check_account-mgr.c: (START_TEST):
3574 Provide the extra parameter, as appropriate.
3576 * src/widgets/modest-account-view.c: (update_account_view):
3577 Do not show disabled accounts (meaning that there is no way to
3578 enable/disable accounts in the UI (the feature is not in our UI
3579 specification), so we can use this internally only to mark unfinished
3580 or temporary account data.
3582 * src/maemo/easysetup/modest-easysetup-wizard.c:
3583 (create_account): Add boolean enable parameter, so we can specify FALSE
3584 to create the temporary account.
3585 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3586 (on_before_next): When finishing, when there is a temporary account, just
3588 Also, use a timeout to delay the showing of the dialog until gconf is likely
3589 to return correct information, due to a maemo gconf bug that is fixed in
3590 osso 1.1, but not yet in Bora.
3591 However, the dialog stays on screen after it is destroyed.
3593 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3594 for invalid data when cancelling. Use a hildon note instead of a dialog
3595 to complain about invalid data. Do not show the account-saved note if the
3596 account is disabled (a temporary account that will not really be saved for use
3599 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3601 * src/modest-account-mgr-helpers.h:
3602 * src/modest-account-mgr-helpers.c:
3603 Added modest_account_mgr_unset_default_account(),
3604 Added modest_account_mgr_set_first_account_as_default().
3606 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3607 If it was the default account, unset the default account name.
3609 * src/maemo/modest-account-view-window.c:
3610 (on_delete_button_clicked): If it was the default account,
3611 set the first remaining account as the default instead.
3613 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3614 a NULL account or a NULL default account, to prevent a crash. This should
3615 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3618 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3620 * src/widgets/modest-recpt-editor.c:
3621 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3622 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3623 TODO comment for this. This fixes the build.
3625 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3626 be the best place for it. This will in future update all auto-update accounts,
3627 rather than just the current/default account, when that gconf key exists.
3628 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3629 if there are no accounts, before calling do_send_receive().
3630 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3632 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3633 * src/maemo/modest-main-window-ui.h:
3634 * src/maemo/modest-main-window.c: (on_connection_changed),
3635 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3636 directly, becaue the signal handler does more.
3638 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3640 * src/modest-account-mgr-helpers.c:
3641 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3642 for the case that the account does not exist.
3644 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3645 (equivalent to the modest account name) rather than the tinymail account name
3646 (equivalent to the modest account title - human readable) to get the account data.
3647 Check for null account data to prevent the crash, and add a TODO comment saying that
3648 this needs fixing because it is using the server account name instead of the account name.
3650 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3653 * src/maemo/modest-account-settings-dialog.c: (show_error),
3655 Use hildon_note_new_information() for informative and error messages,
3656 which seems to be expected for Maemo applications (no documentation that I know of
3657 says this). I am surprised that there is no distinction between info and error
3660 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3662 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3663 it is easy to find where this is used.
3665 * src/maemo/easysetup/modest-easysetup-wizard.c:
3666 (create_page_welcome), (create_page_account_details),
3667 (create_page_user_details), (create_page_complete_easysetup),
3668 (create_page_custom_incoming), (create_page_custom_outgoing),
3669 (create_page_complete_custom):
3670 * src/maemo/modest-account-settings-dialog.c:
3671 (create_page_account_details), (create_page_user_details),
3672 (create_page_incoming), (create_page_outgoing):
3673 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3674 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3675 (modest_connection_specific_smtp_edit_window_init):
3676 * src/maemo/modest-connection-specific-smtp-window.c:
3677 (modest_connection_specific_smtp_window_init):
3678 * src/maemo/modest-signature-editor-dialog.c:
3679 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3680 and scrolling policy as per the Email Application Layout Guide, if I have
3683 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3685 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3686 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3687 which were empty, because these vfuncs have been removed from TnyAccountStore.
3688 This fixes the build.
3690 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3692 * src/maemo/modest-main-window.c:
3693 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3694 showing/hiding it. Added TODO because it probably should not be NULL.
3695 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3696 because unnecessary g_warnings() make degugging difficult.
3698 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3700 * src/maemo/modest-msg-edit-window.c:
3701 (modest_msg_edit_window_select_color),
3702 (modest_msg_edit_window_select_background_color): 2 const corrections and
3703 moving 2 #endifs before closing brackets, to fix the build.
3705 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3707 * src/maemo/easysetup/modest-easysetup-wizard.h:
3708 * src/maemo/easysetup/modest-easysetup-wizard.c:
3709 (modest_easysetup_wizard_dialog_finalize),
3710 (on_button_edit_advanced_settings), (create_page_complete_custom),
3711 (on_response), (create_account):
3712 Implement the Advanced Settings edit button, by saving the account information,
3713 for the Advanded Settings dialog to use directly from gconf, and removing it
3714 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3715 Bug #5533 in the projects.maemo.org bugzilla.
3717 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3719 * src/maemo/modest-msg-view-window.c:
3720 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3721 when opening a message window.
3723 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3725 * src/maemo/easysetup/modest-easysetup-wizard.c:
3726 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3729 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3730 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3731 gconf settings. I probably added more checks than necessary, but that is safer.
3733 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3734 variable to fix the build, but this seems to be used when it is still NULL.
3736 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3738 * src/modest-platform.h:
3739 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3740 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3741 * src/modest-main.c: Implement this function so we can avoid using
3742 maemo-specific API from cross-platform code.
3744 * src/modest-tny-account-store.c:
3745 (get_smtp_specific_transport_account_for_open_connection):
3746 * src/modest-ui-actions.c: (check_for_connection),
3747 (modest_ui_actions_on_item_not_found):
3748 Use modest_platform_connect_and_wait() and put #idefs around other
3749 maemo-specific code, because only maemo currently has a way to
3750 identify connection names.
3752 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3754 * src/modest-tny-account-store.h:
3755 * src/modest-tny-account-store.c:
3756 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3757 the connection-specific SMTP server settings in the configuration.
3759 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3761 * src/maemo/modest-main-window.c: (on_connection_changed),
3763 * src/modest-main.c: (main), (start_ui), (send_mail):
3764 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3765 that is what is intended.
3767 * src/modest-ui-actions.c: (action_send), (action_receive),
3768 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3769 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3770 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3771 SMTP server is used when it is specified.
3773 (modest_ui_actions_on_send_receive):
3774 Check that a connection is open before proceeding.
3775 Receive and then send, instead of vice-versa, as per the specification.
3777 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3779 * src/modest-mail-operation.c:
3780 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3781 though I guess it should be something other than NULL.
3783 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3785 * src/maemo/easysetup/modest-easysetup-wizard.c:
3786 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3787 combo twice, to avoid an g_warning and to make it visible again.
3788 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3789 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3790 (already intended) dereference when detaching, because we then recreate the menu.
3791 But I am not sure why the warning was happening, and it is possible that this is a memory
3794 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3796 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3797 and uri_parse_mailto() utility functions.
3798 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3800 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3802 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3804 * src/dbus_api/modest-dbus-api.h:
3805 * src/dbus_api/modest-dbus-callbacks.c:
3806 Use an idle callback to execute the modest code in the application's own thread.
3807 Remove the helloworld example method.
3808 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3809 parsed, and the open-message method is not implemented because this is not yet implemented in
3811 * libmodest-dbus-client/libmodest-dbus-client.c:
3812 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3813 (libmodest_dbus_client_open_message):
3814 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3816 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3817 body without crashing.
3819 * tests/dbus_api/Makefile.am:
3820 * tests/dbus_api/test_mail_to.c:
3821 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3823 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3825 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3826 Added file to fix the build. Sorry.
3828 * src/dbus_api/Makefile.am:
3829 * src/dbus_api/modest-dbus-api.h:
3830 * src/dbus_api/modest-dbus-callbacks.h:
3831 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3832 (modest_dbus_req_handler):
3833 Put constants in a separate header so it can be reused by the
3834 client library, without duplication
3836 * libmodest-dbus-client/Makefile.am:
3837 * libmodest-dbus-client/libmodest-dbus-client.c:
3838 (libmodest_dbus_client_call_helloworld),
3839 (libmodfest_dbus_client_send_mail),
3840 (libmodfest_dbus_client_mailto),
3841 (libmodfest_dbus_client_open_message):
3842 * libmodest-dbus-client/libmodest-dbus-client.h:
3843 (Partly) Implement a send_mail D-Bus method.
3845 * tests/dbus_api/Makefile.am:
3846 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3847 the send_email D-Bus method.
3849 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3853 * libmodest-dbus-client/Makefile.am:
3854 * libmodest-dbus-client/libmodest-dbus-client.c:
3855 * libmodest-dbus-client/libmodest-dbus-client.h:
3856 * tests/dbus_api/Makefile.am:
3857 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3858 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3860 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3862 * src/maemo/easysetup/modest-easysetup-wizard.c:
3863 (create_page_account_details):
3864 * src/maemo/modest-account-settings-dialog.c:
3865 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3866 widgets, because this might not be the default in future versions of the Maemo GTK+.
3867 However, I can not not get capitalization to work even in a simple test case.
3869 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3871 * src/maemo/easysetup/modest-easysetup-wizard.c:
3872 (create_page_custom_incoming), (create_page_custom_outgoing):
3873 * src/maemo/modest-account-settings-dialog.c:
3874 (create_page_account_details), (create_page_incoming),
3875 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3876 instead of using gtk_check_button_with_label(), so they are aligned like the other
3877 widgets, as per the UI spec.
3879 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3881 * src/maemo/easysetup/modest-easysetup-wizard.c:
3882 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3883 * src/widgets/modest-validating-entry.c:
3884 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3885 Modest prefix instead of an EasySetup prefix.
3887 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3889 * src/widgets/modest-validating-entry.h:
3890 * src/widgets/modest-validating-entry.c: (on_insert_text),
3891 Added easysetup_validating_entry_set_max_func(), used to set a callback
3892 to call when the max number of characters is reached. GtkEntry has a max-length
3893 already but is silent about it.
3895 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3896 (create_page_account_details), (create_page_user_details),
3898 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3899 (create_page_account_details), (create_page_user_details),
3900 (create_page_outgoing):
3901 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3902 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3903 the UI spec, when the user tries to enter more than the max number of characters.
3905 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3907 * src/maemo/easysetup/modest-easysetup-wizard.c:
3908 (create_page_user_details), (create_page_custom_incoming),
3909 (create_page_custom_outgoing):
3910 * src/maemo/modest-account-settings-dialog.c:
3911 (create_page_user_details), (create_page_incoming),
3912 (create_page_outgoing):
3913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3914 (modest_connection_specific_smtp_edit_window_init):
3915 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3916 not appropriate. Bad Maemo-specific defaults!.
3918 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3920 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3921 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3922 (modest_signature_editor_dialog_set_settings):
3923 Disable the label and textview when the checkbox is disabled, and use the
3924 specified (UI spec) default signature text.
3926 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3928 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3929 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3931 * src/modest-defs.h:
3932 * src/modest-account-mgr-helpers.h:
3933 * src/modest-account-mgr-helpers.c:
3934 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3936 * src/maemo/Makefile.am:
3937 * src/maemo/modest-signature-editor-dialog.c:
3938 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3941 * src/maemo/modest-account-settings-dialog.h:
3942 * src/maemo/modest-account-settings-dialog.c:
3943 (modest_account_settings_dialog_finalize), (on_button_signature),
3944 (save_configuration): Use the new dialog when the Edit button is pressed, and
3945 save the changes if necessary, as per the UI spec.
3947 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3949 * src/maemo/Makefile.am:
3950 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3951 based on maemo-develoers email from Dirk.
3953 * src/maemo/easysetup/modest-easysetup-wizard.c:
3954 (create_page_welcome), (create_page_account_details),
3955 (create_page_user_details), (create_page_complete_easysetup),
3956 (create_page_custom_incoming), (create_page_custom_outgoing),
3957 (create_page_complete_custom),
3958 (modest_easysetup_wizard_dialog_init):
3959 * src/maemo/modest-account-settings-dialog.c:
3960 (create_page_account_details), (create_page_user_details),
3961 (create_page_incoming), (create_page_outgoing),
3962 (modest_account_settings_dialog_init):
3963 * src/maemo/modest-connection-specific-smtp-window.c:
3964 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3966 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3968 * src/maemo/easysetup/modest-easysetup-wizard.c:
3969 (create_page_account_details), (create_page_custom_outgoing),
3970 (create_page_complete_custom):
3971 * src/maemo/modest-account-settings-dialog.c:
3972 (create_page_user_details), (create_page_incoming),
3973 (create_page_outgoing):
3974 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3975 (modest_connection_specific_smtp_edit_window_init):
3976 Use the correct (UI spec) port min/max, and use horizontal separators,
3979 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3981 * src/maemo/easysetup/modest-easysetup-wizard.c:
3982 (set_default_custom_servernames):
3983 * src/maemo/modest-account-settings-dialog.c:
3984 (create_page_incoming), (on_combo_outgoing_security_changed),
3985 (on_combo_incoming_security_changed), (create_page_outgoing),
3986 (modest_account_settings_dialog_set_account_name),
3987 (save_configuration):
3988 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3989 (on_combo_security_changed),
3990 (modest_connection_specific_smtp_edit_window_init),
3991 (modest_connection_specific_smtp_edit_window_set_connection),
3992 (modest_connection_specific_smtp_edit_window_get_settings):
3993 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3996 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3999 * src/maemo/easysetup/modest-easysetup-wizard.c:
4000 (create_page_custom_outgoing), (create_page_complete_custom):
4001 * src/maemo/modest-account-settings-dialog.c:
4002 (create_page_user_details), (create_page_outgoing):
4003 * src/maemo/modest-account-view-window.c: (button_box_new):
4004 Use changed logical IDs as per the most recent UI spec:
4005 mcen_bd_emailsetup_edit -> mcen_bd_edit
4006 mcen_bd_emailsetup_delete -> mcen_bd_delete
4007 mcen_bd_emailsetup_close -> mcen_bd_close
4009 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4013 * src/dbus_api/Makefile.am:
4014 * src/dbus_api/modest-dbus-callbacks.c:
4015 * src/dbus_api/modest-dbus-callbacks.h:
4016 * src/maemo/modest-platform.c: (modest_platform_init):
4017 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4019 * tests/Makefile.am:
4020 * tests/dbus_api/Makefile.am:
4021 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4023 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4025 * src/maemo/modest-account-settings-dialog.c:
4026 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4027 Removed unnecessary includes.
4029 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4031 * src/maemo/easysetup/modest-easysetup-wizard.c:
4032 * src/maemo/modest-account-settings-dialog.c:
4033 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4034 * src/widgets/Makefile.am:
4035 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4036 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4037 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4038 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4039 * src/widgets/modest-secureauth-combo-box.c:
4040 * src/widgets/modest-secureauth-combo-box.h:
4041 * src/widgets/modest-serversecurity-combo-box.c:
4042 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4043 made the GObject names more consistent with the rest of the Modest code.
4045 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4047 * src/maemo/easysetup/Makefile.am:
4048 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4049 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4050 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4051 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4052 * src/maemo/easysetup/modest-easysetup-wizard.c:
4053 * src/maemo/easysetup/modest-validating-entry.c:
4054 * src/maemo/easysetup/modest-validating-entry.h:
4055 * src/maemo/modest-account-settings-dialog.c:
4056 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4057 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4058 widgets/ because they are used outside of easysetup too. After checking in,
4059 svn will allow me to rename them too.
4061 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4063 * src/gnome/modest-msg-edit-window.c:
4064 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4065 linker error, to fix the build on the GNOME platform.
4066 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4067 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4068 ifdefed out to avoid a warning.
4070 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4072 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4073 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4074 some alternative for GTK+ 2.6.
4076 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4078 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4080 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4081 specified for EmailAccountsDialog in UI spec.
4083 * src/maemo/easysetup/modest-easysetup-wizard.c:
4084 * src/maemo/easysetup/modest-easysetup-wizard.h:
4085 * src/maemo/modest-account-settings-dialog.c:
4086 * src/maemo/modest-account-settings-dialog.h:
4087 Reuse a member window widget for the connection-specific SMTP server accounts,
4088 so we can tell it to create/save the accounts only if we actually save changes.
4090 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4091 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4092 (modest_connection_specific_smtp_edit_window_get_settings):
4093 Return a struct instance for temporarily remembering the entered data.
4095 * src/maemo/modest-connection-specific-smtp-window.h:
4096 * src/maemo/modest-connection-specific-smtp-window.c:
4097 (modest_connection_specific_smtp_window_finalize),
4098 (modest_connection_specific_smtp_window_fill_with_connections),
4100 (modest_connection_specific_smtp_window_save_server_accounts),
4101 (update_model_server_names): Do not actually save data until asked,
4102 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4104 (on_selection_changed),
4105 (modest_connection_specific_smtp_window_init): Disable the edit
4106 button when nothing is selected.
4108 * src/modest-account-mgr-helpers.c:
4109 * src/modest-account-mgr-helpers.h:
4110 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4113 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4115 * src/modest-account-mgr-helpers.h:
4116 * src/modest-account-mgr-helpers.c:
4117 (modest_account_mgr_get_unused_account_name),
4118 (modest_account_mgr_get_unused_account_display_name): Added these
4119 utility functions, to avoid code duplication.
4121 * src/maemo/easysetup/modest-easysetup-wizard.c:
4122 (create_page_account_details), (create_account):
4123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4124 (on_combo_security_changed),
4125 (modest_connection_specific_smtp_edit_window_init),
4126 (modest_connection_specific_smtp_edit_window_save_settings):
4127 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4128 * src/maemo/modest-connection-specific-smtp-window.c:
4129 (modest_connection_specific_smtp_window_finalize),
4130 (modest_connection_specific_smtp_window_fill_with_connections),
4131 (on_button_edit), (modest_connection_specific_smtp_window_init):
4132 * src/maemo/modest-connection-specific-smtp-window.h:
4133 Implementing saving of connection-specific server accounts.
4135 But I need to refactor this so we can save the data for each
4136 possible connection-specific account and only actually create the server accounts
4137 when the easysetup finished, or the OK button is pressed on the account settings
4140 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4143 (on_combo_security_changed):
4144 (modest_connection_specific_smtp_edit_window_init):
4145 Auto-fill the port number as in the account settings.
4147 (modest_connection_specific_smtp_edit_window_set_connection):
4148 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4149 * src/maemo/modest-connection-specific-smtp-window.c:
4150 (fill_with_connections), (on_button_edit),
4151 (modest_connection_specific_smtp_window_init):
4152 Turn the edit window into a dialog to simplify the code, and
4153 set a WM hint as in a GtkDialog, because only a popup can be on top of
4154 another window in Maemo, and popups usually have no WM decoration.
4156 * src/modest-defs.h:
4157 * src/modest-account-mgr-helpers.c:
4158 (modest_account_mgr_set_connection_specific_smtp),
4159 (modest_account_mgr_remove_connection_specific_smtp),
4160 (modest_account_mgr_get_connection_specific_smtp):
4161 * src/modest-account-mgr-helpers.h: Some functions to write the
4162 connection-specific SMTP server information. Not yet used.
4165 * src/widgets/modest-folder-view.c: (text_cell_data):
4166 Fix a warning about an uninitialized variable.
4167 (on_configuration_key_changed): Put an #ifdef around the use
4168 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4170 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4172 * src/maemo/modest-account-settings-dialog.h:
4173 * src/maemo/modest-account-settings-dialog.c:
4174 Added connect_for_modified() utility function to mark the new modified boolean.
4176 (create_page_account_details), (create_page_user_details),
4177 (create_page_incoming), (create_page_outgoing), (on_response),
4178 (modest_account_settings_dialog_init),
4179 (modest_account_settings_dialog_set_account_name):
4180 Only warn about unsaved changes when there are actually unsaved changes.
4182 * src/modest-account-mgr-helpers.c:
4183 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4184 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4185 to get the data from there in future.
4187 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4189 * src/modest-defs.h:
4191 * src/modest-account-mgr-helpers.h:
4192 * src/modest-account-mgr-helpers.c:
4193 Store the security account setting in a single conf key instead of using
4194 the options list, so that the list is left for just the to-be-removed camel hack,
4195 and because gconf_client_set_list() is failing for some reason.
4197 * src/modest-account-mgr.c:
4198 (modest_account_mgr_add_server_account):
4199 * src/maemo/modest-account-settings-dialog.c:
4200 (modest_account_settings_dialog_set_account_name),
4201 (save_configuration): Use the renamed functions.
4204 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4206 * src/widgets/Makefile.am:
4207 * src/widgets/modest-limit-retrieve-combo-box.c:
4208 * src/widgets/modest-limit-retrieve-combo-box.h:
4209 * src/widgets/modest-retrieve-combo-box.c:
4210 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4211 the account settings dialog.
4213 * src/modest-defs.h:
4214 * src/modest-account-mgr-helpers.h:
4215 * src/modest-account-mgr-helpers.c:
4216 (modest_server_account_get_option_secure_auth),
4217 (modest_server_account_set_option_secure_auth):
4218 * src/modest-account-mgr.c:
4219 (modest_account_mgr_add_server_account):
4220 Use the existing AUTH_MECH conf key for the secure-auth setting,
4221 instead of putting it in the list options, because this was actually used already.
4223 * src/maemo/modest-account-settings-dialog.c:
4224 (create_page_account_details),
4225 (modest_account_settings_dialog_set_account_name),
4226 (save_configuration):
4227 * src/maemo/modest-account-settings-dialog.h:
4228 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4229 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4231 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4233 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4234 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4235 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4237 * src/modest-defs.h:
4238 * src/maemo/modest-account-settings-dialog.c:
4239 (create_page_incoming), (on_combo_outgoing_security_changed),
4240 (on_combo_incoming_security_changed), (create_page_outgoing),
4241 (modest_account_settings_dialog_set_account_name),
4242 (save_configuration): Load/Save the port number, and change it when the
4243 security combo changes, to suitable defaults.
4245 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4247 * src/modest-account-mgr.c:
4248 (modest_account_mgr_add_server_account): Set the security and secure-auth
4249 options, and add a comment saying that the other camel-specific options should be
4252 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4256 * src/modest-tny-account-store.c: (account_list_free),
4257 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4258 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4261 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4263 * src/modest-protocol-info.c:
4264 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4265 is required by our UI spec. Maybe something in our implementation will use this eventually.
4266 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4267 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4268 instead of the previous 0 placeholder.
4270 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4271 secure-auth settings.
4272 * src/modest-account-mgr-helpers.h:
4273 * src/modest-account-mgr-helpers.c:
4274 (modest_server_account_data_get_option_secure_auth),
4275 (modest_server_account_set_option_secure_auth),
4276 (modest_server_account_data_get_option_security),
4277 (modest_server_account_set_option_security): Added this API for getting and setting the security
4278 and secure-auth settings.
4280 * src/maemo/modest-account-settings-dialog.h:
4281 * src/maemo/modest-account-settings-dialog.c:
4282 (modest_account_settings_dialog_finalize), (check_data),
4283 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4284 about changing titles.
4285 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4286 (save_configuration): Save the security and secure-auth settings.
4288 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4289 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4291 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4293 * src/modest-defs.h:
4294 * src/modest-account-mgr.c:
4295 (modest_account_mgr_add_server_account):
4296 Added and used defines for the options key and value pair strings,
4297 that are used so far, though they do not seem to correspond to anything in our
4298 UI specs or ModestProtocol enum.
4300 * src/modest-account-mgr-helpers.h:
4301 * src/modest-account-mgr-helpers.c:
4302 (compare_option_strings_for_name),
4303 (modest_server_account_data_get_option_value),
4304 (modest_server_account_data_get_option_bool),
4305 (modest_account_mgr_get_server_account_option):
4306 Added helper functions for parsing the options GSList.
4308 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4310 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4311 display name is based on the supplied account name.
4312 * src/modest-account-mgr.c:
4313 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4314 with an inefficient, but good-enough, implementation.
4316 * src/maemo/easysetup/modest-easysetup-wizard.c:
4317 (create_page_account_details), (on_before_next), (create_account):
4318 Check for existing display names rather than (non-user-visible) account names, and just
4319 create and set a unique account name at the end.
4321 * src/maemo/modest-account-settings-dialog.c:
4322 (modest_account_settings_dialog_init),
4323 (modest_account_settings_dialog_set_account_name),
4324 (create_page_incoming): Show the display name, instead of the account name.
4325 (on_response): Do some (not all) extra checks, as in the UI spec.
4326 (save_configuration): Save the display name if it was changed.
4328 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4330 * po/en_GB.po: Added needed logical ID and translation.
4331 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4332 (init_view): Made the is-default column clicking work.
4334 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4337 * src/maemo/easysetup/Makefile.am:
4338 * src/maemo/easysetup/modest-easysetup-wizard.c:
4339 (modest_easysetup_wizard_dialog_init):
4340 * src/maemo/easysetup/provider-data-test.keyfile:
4341 * src/maemo/easysetup/provider-data.keyfile:
4342 Moved the provider data file to the new modest-providers-data package and used it from there.
4344 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4346 * src/modest-local-folder-info.c:
4347 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4348 N_() was already used on the static strings, but this just marks it for translation without
4349 using the translation.
4351 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4353 * src/maemo/modest-account-settings-dialog.c:
4354 (create_page_incoming),
4355 (modest_account_settings_dialog_set_account_name):
4356 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4357 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4358 I will do this if nobody else gets there first.
4360 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4362 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4363 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4364 save the security stuff.
4366 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4368 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4369 Set the email address and user fullname, which I now see must be
4372 * src/maemo/modest-account-settings-dialog.h:
4373 * src/maemo/modest-account-settings-dialog.c:
4375 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4376 leave-on-server and authentication.
4377 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4380 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4383 * src/maemo/modest-account-settings-dialog.c:
4384 * src/maemo/modest-account-settings-dialog.h:
4385 Most (but not all) of the widgets are now present as specified by the UI spec.
4386 No changes are yet saved, and some details are not properly shown yet.
4388 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4390 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4392 * src/maemo/Makefile.am:
4393 * src/maemo/modest-account-settings-dialog.c:
4394 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4395 an existing account. Doesn't do much yet.
4397 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4398 Open the accounts settings dialog when Edit is clicked.
4400 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4402 * src/maemo/easysetup/Makefile.am:
4403 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4405 * src/maemo/easysetup/modest-easysetup-wizard.c:
4406 (modest_easysetup_wizard_dialog_init):
4407 Try to get the source directory from the build system,
4408 instead of hard-coding "./" into the source code, when opening our local
4409 copies of the configuration files.
4410 But this still fails when opening the wizard from the Accounts window,
4411 maybe because the working directory seems to change at runtime.
4412 So the wizard will fail the second time unless you copy the files into their
4413 proper locations - see the stdout warnings for the paths.
4415 (create_page_account_details),(on_before_next):
4416 Check for existing non-server accounts instead of server accounts,
4417 so the default account name is useful again, and to prevent trying to
4420 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4421 Show the wizard when New is clicked.
4423 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4424 (init_view): Show the column headers, and show the columns that are
4425 specified in the UI specs. However, something in Maemo's GTK+ prevents
4426 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4427 change the default account. This is despite unsetting the special properties.
4429 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4431 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4432 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4433 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4434 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4435 to make that clearer.
4436 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4438 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4440 * src/maemo/modest-account-view-window.c:
4441 (modest_account_view_window_init),
4442 (modest_account_view_window_new):
4443 Use the same buttons as specified in the
4444 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4445 the existing widgets, which never had a chance of working.
4446 Put the ModestAccountView treeview in a scrolled window.
4447 Do not repeat the initialization in both _init() and _new().
4449 * src/widgets/modest-account-view.c: (update_account_view):
4450 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4451 this widget and window shows no accounts.
4453 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4455 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4457 * src/maemo/easysetup/modest-easysetup-wizard.c:
4458 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4459 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4460 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4463 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4464 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4465 accounts exist yet, as in the UI spec.
4467 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4469 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4471 * src/maemo/Makefile.am:
4472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4473 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4474 New window for editing connection-specific smtp details.
4475 Not fully implemented.
4477 * src/maemo/modest-connection-specific-smtp-window.c:
4478 (modest_connection_specific_smtp_window_finalize) :
4479 unref the tree model.
4480 (on_button_edit): Show the edit window.
4482 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4484 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4487 * src/maemo/Makefile.am:
4488 * src/maemo/modest-connection-specific-smtp-window.c:
4489 * src/maemo/modest-connection-specific-smtp-window.h:
4490 New window for showing the list of connections, for connection-specific
4491 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4492 * src/maemo/easysetup/modest-easysetup-wizard.c:
4493 (create_page_custom_outgoing): Show the new window when the button is clicked.
4495 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4497 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4498 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4499 * src/maemo/modest-msg-edit-window.c:
4500 (modest_msg_edit_window_insert_image):
4501 * src/modest-conf.c: (modest_conf_key_escape):
4502 * src/modest-mail-operation.c:
4503 (modest_mail_operation_send_new_mail):
4504 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4505 (modest_ui_actions_on_new_account):
4506 * src/widgets/modest-attachment-view.c: (update_filename_request):
4507 * src/widgets/modest-mail-header-view.c:
4508 Corrected warnings that were breaking the build, by commenting out unused variables,
4509 and a function, and by including a header.
4511 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4513 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4514 so we can #ifdef around platform-specific code when necessary.
4515 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4516 to allow this to build for the GNOME platform too.
4518 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4520 * src/maemo/easysetup/modest-easysetup-wizard.c:
4521 Added util_increment_name() and used it in create_page_account_details()
4522 to make sure that the default account name is always a new name.
4524 (modest_easysetup_wizard_dialog_init),
4525 (set_default_custom_servernames): Some minor memory management fixes.
4527 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4531 * src/modest-runtime.c: (init_i18n): Restored the translation
4532 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4533 are defined in config.h, and the translations are installed.
4535 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4536 is defined for translation.
4538 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4540 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4542 * src/maemo/easysetup/modest-easysetup-wizard.c:
4543 (modest_easysetup_wizard_dialog_init):
4544 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4545 Use realistic paths (though they should use $prefix generically) to the
4546 mcc_mapping and provider-data.keyfile files which might work when they
4547 are installed by the future version of the operator-wizard package,
4548 and then fallback to paths in our source code, with an explanatory
4551 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4555 * src/maemo/Makefile.am:
4556 * src/maemo/easysetup/: Added files from the previously-exernal
4557 osso-modest-easysetup.
4558 * src/maemo/modest-main-window-ui.h:
4559 * src/modest-ui-actions.c:
4560 * src/modest-ui-actions.h:
4561 Added modest_ui_actions_on_new_account() as a signal handler for the
4562 New Account menu item. It shows the easysetup wizard.
4563 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob