1 2007-07-27 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
4 Commented out the use of wp_text_buffer_replace_image()
5 because it does not exist, to break the build. Added a TODO for it.
7 2007-07-26 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account-store.c: (recreate_all_accounts):
10 Recreate them even if they were NULL before. I guess something
11 else was already creating them before, or this would never
13 (modest_tny_account_store_get_server_account): Make sure that
14 the tny accounts have been created before trying to find one.
15 This allows libmodest_dbus_client_compose_mail() to work
16 when the UI is not yet visible.
17 This is probably useful in other cases too.
19 (get_password): When the password is wrong after it is entered
20 in the protected password dialog, show an info banner (in an
21 idle handler) before showing the protected password dialog
24 2007-07-26 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-ui-actions.h:
27 * src/modest-ui-actions.c: Added
28 modest_do_refresh_current_folder() containing some code from
29 modest_ui_actions_on_send_receive().
30 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
31 Call modest_do_refresh_current_folder() before refreshing the
32 requested account, as in modest_ui_actions_on_send_receive().
33 This is strange, but seems to be necessary to show new mails.
34 Now new emails are finally visible in the UI when downloaded
35 via the automatic update interval, fixing bug NB#57458.
36 This also works because bug NB#57458 has been fixed somehow.
38 2007-07-26 Murray Cumming <murrayc@murrayc.com>
40 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
41 printf more details when we get unhandled D-Bus methods, because
44 * src/modest-mail-operation.c: (update_account_thread):
45 Comment out the tny_camel_pop_store_account_reconnect(), because this
46 is apparently no longer needed, and it did not work before anyway.
47 See the comment in the code.
49 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
50 by checking the header flags. This fixes projects.maemo.org bug
53 2007-07-25 Murray Cumming <murrayc@murrayc.com>
55 * src/maemo/modest-maemo-utils.h:
56 * src/maemo/modest-maemo-utils.c: Added
57 modest_maemo_show_information_note_in_main_context_and_forget().
58 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
59 Use the new function to show simple error dialogs in the main
60 context, though question dialogs are still in the current context,
61 which is unfortunately usually not the main context. This should
64 2007-07-25 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-tny-account-store.c: (get_password):
67 Never save the entered username and password in gconf,
68 because the UI spec says we should not. This helps
69 slightly with projects.maemo.org bug NB#63671.
71 2007-07-25 Murray Cumming <murrayc@murrayc.com>
73 * src/widgets/modest-msg-edit-window.h:
74 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
75 Moved some code here to make it simpler.
76 (modest_msg_edit_window_attach_file_one): Renamed from
77 modest_msg_edit_window_attach_file_interactive().
78 (modest_msg_edit_window_offer_attach_file): Renamed from
79 modest_msg_edit_window_attach_file() and used
80 modest_msg_edit_window_attach_file_one() instead of
81 copy/pasting the code. The old code for one was not using
82 GnomeVFS. This allows use of smb:// URLs when using send-as
83 from external applications, fixing bug NB#63741.
85 (modest_msg_edit_window_insert_image),
86 (modest_msg_edit_window_add_attachment_clicked):
87 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
88 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
89 Adapted to the new function names.
91 2007-07-25 Murray Cumming <murrayc@murrayc.com>
93 (modest_platform_set_update_interval): Set the alarm recurrence
94 fields so that auto-update does not just happen the first time.
95 This should have fixed projects.maemo.org bug NB#63938.
97 When this happens you can see a printf when the D-Bus method is
99 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
101 However, I do not actually seem to get new POP messages even when
102 clicking the refresh button manually. A restart gets them.
103 This might be a problem in today's tinymail only.
105 2007-07-24 Murray Cumming <murrayc@murrayc.com>
107 * src/maemo/modest-maemo-global-settings-dialog.c:
108 (current_connection):
109 Avoid a crash (probably only in scratchbox) when strcmp()ing a
110 NULL when closing the dialog.
112 2007-07-24 Murray Cumming <murrayc@murrayc.com>
114 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
115 Remove the hacky send/receive that didn't work, and instead
116 refilter the treemodel to make the deleted email really vanish from
117 the UI (though the delete-from-menu code does has commented out
118 the code that does that). This fixes projects.maemo.org bug
121 2007-07-24 Murray Cumming <murrayc@murrayc.com>
123 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
124 Try a couple of tricks to force the treeview to update (
125 poke the folder, and do a send/receive refresh), but the deleted
126 email still appears with a strike-through instead of really being
129 2007-07-23 Murray Cumming <murrayc@murrayc.com>
131 * src/dbus_api/modest-dbus-callbacks.c:
132 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
133 because their ID is not human-readable (see the comment about
134 improvements needed to the osso-email-interface API) and
135 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
137 2007-07-23 Murray Cumming <murrayc@murrayc.com>
139 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
140 (add_folders_to_list), (on_dbus_method_get_folders),
141 (modest_dbus_req_filter):
142 * src/maemo/modest-maemo-utils.c:
143 (on_camel_account_get_supported_secure_authentication):
144 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
145 (on_header_view_focus_in):
146 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
147 * src/modest-formatter.c: (modest_formatter_create_body_part):
148 * src/modest-mail-operation.c: (recurse_folders),
149 (update_account_thread), (get_msgs_full_thread),
150 (modest_mail_operation_get_msgs_full),
151 (modest_mail_operation_xfer_msgs):
152 * src/modest-search.c: (search_mime_part_and_child_parts),
153 (modest_search_account), (modest_search_all_accounts):
154 * src/modest-tny-account.c:
155 (modest_tny_account_get_special_folder), (recurse_folders):
156 * src/modest-tny-local-folders-account.c:
157 (modest_tny_local_folders_account_query_passes):
158 * src/modest-tny-msg.c: (copy_mime_part),
159 (modest_tny_msg_find_body_part_from_mime_part):
160 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
161 (modest_tny_send_queue_try_to_send):
162 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
163 (_modest_ui_actions_open), (download_uncached_messages),
164 (reply_forward), (modest_ui_actions_on_copy),
165 (modest_ui_actions_on_details), (has_retrieved_msgs),
166 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
168 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
169 (_selected_msg_marked_as), (_msg_download_completed),
170 (_selected_msg_sent_in_progress):
171 * src/widgets/modest-attachments-view.c:
172 (modest_attachments_view_set_message):
173 * src/widgets/modest-msg-view.c: (find_cid_image):
174 * tests/check_folder-transfer.c: (find_folders):
175 * tests/check_update-account.c: (func):
176 * tests/dbus_api/test_get_folders.c: (main):
177 Checked all uses of tny_iterator_get_current(), making sure
178 that the object is unreferenced (3 or 4 places did not),
179 and adding checks for NULL.
181 2007-07-23 Murray Cumming <murrayc@murrayc.com>
183 * src/dbus_api/modest-dbus-callbacks.c:
184 (on_idle_open_default_inbox): Make sure that the application UI is
186 * src/maemo/easysetup/modest-easysetup-wizard.c:
187 (on_entry_invalid_character): Show the word whitespace instead
188 of (null) in the banner when whitespace was entered.
189 (show_error): Add a comment that this does not work in
190 Maemo Bora, though we do not know why.
192 2007-07-23 Murray Cumming <murrayc@murrayc.com>
194 * src/modest-tny-account.c:
195 (modest_tny_account_get_special_folder): Use an if instead of
196 an assert for when the parent account name is NULL, because this
197 might be causing a crash in projects.maemo.org bug 63192.
198 * src/modest-mail-operation.c:
199 (modest_mail_operation_send_new_mail_cb),
200 (modest_mail_operation_remove_folder): unref the folder that is
201 returned from modest_tny_account_get_special_folder().
203 2007-07-23 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-ui-actions.c:
206 (modest_ui_actions_on_password_requested):
207 Show mail_ib_login_cancelled info banner when the user cancels
208 the protected password dialog, to fix projects.maemo.org
211 2007-07-23 Murray Cumming <murrayc@murrayc.com>
213 * src/maemo/modest-account-settings-dialog.c:
214 (create_page_outgoing): Put this page in a GtkScrolledWindow,
215 matching the UI mock-up in the UI spec, and allowing access
216 to all widgets even when the on-screen keyboard is active.
218 2007-07-23 Murray Cumming <murrayc@murrayc.com>
220 Reverted this previous commit from Johannes,
221 because the scrollbars are always visible and because
222 I think we only need it on onepage of the account
223 settings, not the account wizard.
224 (I wrote the wrong instructions in the bug.)
226 * src/maemo/easysetup/modest-easysetup-wizard.c:
227 Added scrollbars to account wizard dialog.
228 Fixed projects.maemo.org NB #62744
230 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
232 * src/maemo/easysetup/modest-easysetup-wizard.c:
233 (create_page_user_details):
234 Use auto-cap for name (projects.maemo.org NB#63716)
235 * src/widgets/modest-account-view.c: (on_account_busy_changed):
237 2007-07-22 Armin Burgmeier <armin@openismus.com>
239 * src/maemo/modest-ui-actions.c: Use current account instead of
240 default account for creating viewer windows, so that the viewer
241 window knows to which account the viewed message belongs.
243 * src/maemo/modest-msg-view-window.c: Destroy the window when the
244 corresponding account is deleted. This fixes projects.maemo.org bug
247 2007-07-18 Armin Burgmeier <armin@openismus.com>
249 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
250 the dialog close after entering an invalid port number and clicking
251 OK. This fixes projects.maemo.org bug NB#63602.
253 2007-07-18 Armin Burgmeier <armin@openismus.com>
255 * src/modest-tny-account-store.c:
256 (get_server_accounts): Set parent modest account name for each
257 connection-specific transport account so that special folders of such
258 an account can be looked up. This fixes a crash when changing account
259 settings. This might also be related to projects.maemo.org bug
262 2007-07-16 Armin Burgmeier <armin@openismus.com>
264 * src/modest-ui-actions.c: Added a button to create a folder to the
265 move-to dialog. This fixes projects.maemo.org bug NB#.
267 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
269 * src/maemo/easysetup/modest-easysetup-wizard.c:
270 Added scrollbars to account wizard dialog.
271 Fixed projects.maemo.org NB #62744
273 2007-07-16 Murray Cumming <murrayc@murrayc.com>
275 * src/widgets/modest-msg-view.h:
276 * src/widgets/modest-msg-view.c:
277 Added modest_msg_view_get_message_is_empty() but this needs
279 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
280 Check if there is any text in the message yet.
281 But this needs to be implemented properly.
282 (modest_msg_edit_window_toggle_find_toolbar):
283 * src/maemo/modest-msg-view-window.c:
284 (modest_msg_view_window_toggle_find_toolbar):
285 Show a banner warning if there is no text to search, when
286 trying to start a search. This partially fixes
287 projects.maemo.org bug NB#62350.
289 2007-07-13 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-mail-operation.c: (update_account_thread):
292 Initialized num_new_headers to fix the build.
294 2007-07-13 Murray Cumming <murrayc@murrayc.com>
296 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
297 Ignore modest accounts whose server accounts don't exist in gconf.
298 This prevents us trying to create TnyAccount instances for those
299 server accounts when the server account has been removed from gconf,
300 but the parent modest account has not yet been removed from modest.
301 I don't know why this is only noticeable now. It was probably just
302 a harmeless g_warning() anyway.
304 2007-07-13 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
307 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
309 2007-07-12 Armin Burgmeier <armin@openismus.com>
311 * src/maemo/modest-main-window.c: Make default account appear bold
312 in view, tools/send & receive and toolbar/send & receive SCM menus.
313 This fixes projects.maemo.org bug NB#59010.
315 2007-07-12 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
318 Add a short-cut, by checking if the folder store is an account.
319 This ensures that the Sort menu item and toolbar is dimmed for
320 the local-folders account root item, fixing
321 projects.maemo.org bug NB#62545.
323 2007-07-12 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-tny-account-store.c: (get_password):
326 Show the password dialog (via the signal) only in the mainloop, via
327 an idle handler that we wait for. This could theoretically prevent
328 hangs, though I worry that it could introduce some too.
330 2007-07-12 Murray Cumming <murrayc@murrayc.com>
332 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
333 * src/maemo/modest-platform.c:
334 (modest_platform_connect_and_wait):
335 Take a TnyAccount* parameter and try to set it to online
336 (a TnyCamel-only API), because tinymail sets accounts to offline
337 when the user cancels a password dialog, and doesn't ask again until
338 it has been set to online.
339 However, this is commented out because it causes a hang now.
341 (modest_platform_connect_and_wait_if_network_account):
342 * src/modest-mail-operation.c:
343 (modest_mail_operation_update_account):
344 * src/modest-platform.h:
345 * src/modest-ui-actions.c: (_modest_ui_actions_open),
346 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
348 2007-07-12 Armin Burgmeier <armin@openismus.com>
350 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
352 * src/modest-mail-operation.c:
353 * src/modest-ui-actions.c: Check for already existing folder before
354 querying the server, show error message from camel if the request
355 still fails. This fixes projects.maemo.org bug NB#58701.
357 2007-07-12 Murray Cumming <murrayc@murrayc.com>
359 * src/modest-tny-account-store.h:
360 * src/modest-tny-account-store.c:
361 Added modest_tny_account_store_forget_password_in_memory(),
362 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
363 when creating a new account, so that new passwords will be used, instead of
364 us thinking that it's a second request as a result of a failed password again.
366 2007-07-12 Murray Cumming <murrayc@murrayc.com>
368 * src/dbus_api/modest-dbus-callbacks.c:
369 (on_idle_open_message): If the message is in drafts then open it
370 in an edit window instead of a view window. This fixes
371 projects.maemo.org bug NB#63005.
373 2007-07-12 Murray Cumming <murrayc@murrayc.com>
375 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
376 Avoided a harmless g_warning().
378 2007-07-12 Murray Cumming <murrayc@murrayc.com>
380 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
381 Pass the modest account name, not the TnyAccount display name to
382 modest_msg_view_window_new() so that the reply feature works,
383 fixing projects.maemo.org bug NB#62892.
385 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
386 (modest_msg_view_window_new_with_header_model):
387 * src/maemo/modest-msg-view-window.c:
388 (modest_msg_view_window_new_with_header_model),
389 (modest_msg_view_window_new):
390 * src/modest-ui-actions.c: (reply_forward):
391 * src/widgets/modest-msg-view-window.h:
392 * src/widgets/modest-window.c: (modest_window_set_active_account):
393 Rename an account parameter to modest_account_name to make this clearer.
395 2007-07-11 Murray Cumming <murrayc@murrayc.com>
397 * src/modest-ui-actions.h:
398 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
399 modest_do_message_delete().
400 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
401 Call modest_do_message_delete(), hoping that this would cause messages
402 to be really deleted from search instead of just marked with strike through.
403 Does not seem to help.
405 2007-07-11 Armin Burgmeier <armin@openismus.com>
407 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
408 priv->reselect to FALSE prior to calling
409 modest_folder_view_select_first_inbox_or_local() to prevent endless
410 recursion and thus a crash on startup.
412 2007-07-11 Armin Burgmeier <armin@openismus.com>
414 * src/maemo/modest-account-settings-dialog.h: Include
415 <gtk/gtknotebook.h> to fix the build (at least for me).
417 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
418 Use "New FolderN" as default suggested name if "New folder" already
419 exists, with N being the first free number, though never exceed "New
420 folder99" in which case we just fall back to "New Folder" even though
421 it already exists. This fixes projects.maemo.org bug NB#58663.
423 2007-07-11 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
426 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
427 projects.maemo.org bug NB#62778.
429 2007-07-11 Murray Cumming <murrayc@murrayc.com>
431 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
432 Ignore the wrong (for now) secure-smtp setting in the presets -
433 just default to requiring secure authentication for SMTP, because
436 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
438 * src/widgets/modest-folder-view.c: (filter_row)
439 Do not show drafts folder (see UI specs)
441 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
443 * src/modest-ui-actions.c:
444 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
445 place and also not necessary.
447 * src/widgets/modest-folder-view.c: (filter_row)
448 Guess folder type and hide Sent & Outbox if necessary.
449 Fixed project.maemo.org NB#57328
451 2007-07-11 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-ui-actions.h:
454 * src/modest-ui-actions.c:
455 (modest_ui_actions_on_delete_message):
456 Move some code into a new
457 modest_ui_actions_refresh_message_window_after_delete()
458 function so we can use it from elsewhere.
460 * src/dbus_api/modest-dbus-callbacks.c:
461 (on_idle_delete_message), (on_delete_message): Used an idle
462 handler, as we do for the other D-Bus method handlers.
463 Call modest_ui_actions_refresh_message_window_after_delete()
464 if the deleted message was open in a window. This fixed
465 projects.maemo.org bug NB#62862.
467 2007-07-11 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-main.c: (main): Only show the UI at the start if
470 the showui command line option was given. For instance,
471 run-standalone src/modest showui
472 Otherwise, we wait for the top_application D-Bus method to
473 be sent by hildon-desktop when the application is selected
475 This allows us to run without a UI when osso-global-search
476 uses our D-Bus methods.
478 2007-07-11 Murray Cumming <murrayc@murrayc.com>
480 * src/dbus_api/modest-dbus-api.h: Added a define for a
481 top-application D-Bus method.
482 * src/dbus_api/modest-dbus-callbacks.c:
483 (on_top_application),
484 (modest_dbus_req_handler): Handle the top-application D-Bus
485 method, which might be an undocumented D-Bus signal sent by
486 hildon-desktop when it starts the application from the menu.
487 But I am not sure and I need to test it on the device, because
488 my scratchbox does not have the application in the menu now.
489 This method shows the main window, so that it can be invisible
490 when started, for instance, just for email searching from
493 * src/maemo/modest-main-window.c: (restore_settings),
494 (modest_main_window_new): Do not show the window immediately
495 upon creation. We show it later.
496 * src/modest-widget-memory.c: (save_settings_paned):
497 Try (unsuccessfully) to avoid saving the paned position when
498 it is not even visible.
499 (restore_settings_paned): Do not allow a silly paned position.
500 This seems necessary when not showing the window at first.
502 * tests/dbus_api/Makefile.am:
503 * tests/dbus_api/test_top_application.c: (main): Test for the
506 2007-07-10 Murray Cumming <murrayc@murrayc.com>
508 * src/modest-ui-dimming-rules.c:
509 (modest_ui_dimming_rules_on_new_msg),
510 (modest_ui_dimming_rules_on_reply_msg),
511 (modest_ui_dimming_rules_on_delete_msg),
512 (modest_ui_dimming_rules_on_details),
513 (modest_ui_dimming_rules_on_view_window_move_to),
514 (modest_ui_dimming_rules_on_view_previous),
515 (modest_ui_dimming_rules_on_view_next),
516 (_invalid_folder_for_purge): Added checks before
517 casting the window. This looks like an actual
518 logic error in _invalid_folder_for_purge(), because it
519 tries to use a ModestMainWindow as a message window.
521 2007-07-10 Murray Cumming <murrayc@murrayc.com>
523 * src/maemo/modest-account-settings-dialog.c:
524 (show_error): Use the same implementation as in
525 modest-easysetup-wizard.c:
526 (on_entry_invalid_character): The logical ID contains a %s.
527 Guessed what it should be.
528 (on_entry_max), (check_data), (on_response): Adapt to
529 changed show_error().
530 (create_page_account_details): Really call
531 modest_validating_entry_set_func() on the correct widgets.
532 * src/maemo/easysetup/modest-easysetup-wizard.c:
533 (on_entry_invalid_character): Fix the logical ID here too.
534 (create_page_account_details),
535 (create_page_user_details):
537 modest_validating_entry_set_func() on the correct widgets.
539 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
540 Do not try to use the account if it is NULL.
542 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
544 * src/modest-ui-actions.c: (create_move_to_dialog),
545 (modest_ui_actions_on_main_window_move_to),
546 (modest_ui_actions_on_msg_view_window_move_to):
547 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
548 (filter_row), (modest_folder_view_show_non_move_folders):
549 * src/widgets/modest-folder-view.h:
551 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
552 the Sent folder yet as it does not report the correct folder type.
554 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
556 * src/maemo/modest-msg-edit-window.c: (init_window):
559 2007-07-10 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
562 Take a parent widget instead of a parent window, and
563 implement this with hildon_banner_show_information() instead.
564 Non-Maemo builds can just ifdef that there.
565 This fixed projects.maemo.org bug NB#62766.
567 (on_entry_invalid_character): Use show_error() again instead
568 of using hildon directly, and use the _CS() macro to use the correct
570 (create_account), (check_for_supported_auth_methods), (on_entry_max):
571 Pass a widget instead od a window to show_error().
573 2007-07-10 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
576 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
577 This allows us to show the server name in the error message, fixing
578 projects.maemo.org bug NB#62904.
579 Also, use the appropriate logical ID message for the account protocol.
581 2007-07-10 Murray Cumming <murrayc@murrayc.com>
583 * src/modest-tny-account-store.c: (on_idle_wrong_password):
584 A compilation fix, though the build wasn't broken for me.
586 2007-07-09 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
589 Do not try to unref a NULL folder store, to avoid a runtime warning.
590 This seems to happen sometimes when changing accounts settings.
592 2007-07-09 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-tny-account-store.c:
595 (modest_tny_account_store_instance_init),
596 (modest_tny_account_store_finalize),
597 (on_account_settings_hide), (on_idle_wrong_password):
598 Use a GHashTable to ensure that we only show one account settings
599 dialog per modest account. This avoids us having a dialog open for
600 both the store and transport accounts, or due to repeated get_password()
601 calls that shouldn't happen anyway.
603 2007-07-09 Murray Cumming <murrayc@murrayc.com>
605 * src/maemo/modest-maemo-utils.c: (on_hide),
606 (modest_maemo_show_dialog_and_forget): Handle the response, because
607 the window is not even hidden by default.
609 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
610 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
611 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
612 which seems to prevent some modality problems.
614 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
615 Ignore user cancellation errors.
617 * src/modest-account-mgr-helpers.h:
618 * src/modest-account-mgr-helpers.c:
619 Added modest_server_account_get_password() and
620 modest_server_account_get_has_password() to avoid direct use of
623 * src/maemo/modest-account-settings-dialog.h:
624 * src/maemo/modest-account-settings-dialog.c:
625 (modest_account_settings_dialog_init): Store the notebook so we can
627 Added modest_account_settings_dialog_switch_to_user_info().
629 * src/modest-tny-account-store.c:
630 (get_password): When the password in the account settings is wrong (we think),
631 show the relevant page of the account settings dialog, in the mainloop.
632 However, we currently get many of these at once because cancel does not
634 (forget_password): Do not forget the password
635 from the account settings, because this causes side-effects when
636 tinymail seems to call it at strange time, maybe because of how we
637 are cancelling get_password().
638 (modest_tny_account_store_alert): Ignore user cancellations.
640 2007-07-09 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/modest-maemo-utils.h:
643 * src/maemo/modest-maemo-utils.c:
644 Added modest_maemo_show_information_note_and_forget() for use instead of
645 gtk_dialog_run() when the response is not needed, to avoid an extra
646 mainloop which could cause a hang.
648 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
649 Use the logical IDs for the error message, though they are not
650 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
651 because gtk_dialog_run() caused a hang here (the window did not close).
652 This fixes projects.maemo.org bug NB#62646.
654 2007-07-09 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-account-mgr-helpers.h:
657 * src/modest-account-mgr-helpers.c:
658 Added modest_account_mgr_get_store_protocol().
660 * src/maemo/modest-account-view-window.c:
661 (on_delete_button_clicked): Show different warning text depending on
662 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
663 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
666 2007-07-09 Murray Cumming <murrayc@murrayc.com>
668 * src/maemo/modest-msg-edit-window.c:
669 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
670 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
672 2007-07-07 Armin Burgmeier <armin@openismus.com>
674 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
675 ckdg_ib_maximum_characters_reached from correct package.
677 * src/modest-ui-actions.c: Show an error message when a folder could
678 not be created. Tinymail does not give us specific error codes about
679 what has gone wrong, so we assume that a folder with that name
680 already exists, though there might be other reasons.
682 2007-07-06 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
685 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
686 give a more exact error message that can be partly translated.
688 2007-07-05 Murray Cumming <murrayc@murrayc.com>
690 * src/maemo/modest-address-book.c:
691 (select_email_addrs_for_contact): Specify a default window size for the
692 select-email-address dialog, so that it is probably big enough for the
693 title. This should fix projects.maemo.org bug NB#62277.
695 2007-07-05 Murray Cumming <murrayc@murrayc.com>
697 * src/maemo/easysetup/modest-easysetup-wizard.c:
698 (create_page_complete_easysetup): Use
699 gtk_widget_set_size() request to ensure that the text wraps
702 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
704 * src/maemo/easysetup/modest-easysetup-wizard.c:
705 (on_entry_invalid_character), (create_page_account_details),
706 (create_page_user_details):
707 Use new API of ModestValidatingEntry. But for some reason the banner is
708 not shown. I will have to investigate that further.
710 * src/widgets/modest-validating-entry.c: (on_insert_text),
711 (modest_validating_entry_set_func):
712 * src/widgets/modest-validating-entry.h:
713 Added a new callback function to be able to react to prevented
714 characters whitespaces to e.g show a banner.
716 2007-07-05 Armin Burgmeier <armin@openismus.com>
718 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
719 notification of HildonNumberEditor instead of remembering the port
720 number. Thanks to Johannes for pointing this out.
722 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
724 * src/maemo/easysetup/modest-easysetup-wizard.c:
725 Check if there are any user changes before showing a confirmation
726 dialog (projects.maemo.org NB#60946)
728 2007-07-05 Armin Burgmeier <armin@openismus.com>
730 * src/maemo/modest-account-settings-dialog.c: Remember custom port
731 number at the beginning of the dialog and set the modified flag at the
732 end if the port number has changed. This is necessary because
733 HildonNumberEditor does not support notification when the value has
736 2007-07-05 Murray Cumming <murrayc@murrayc.com>
738 * src/modest-ui-actions.c:
739 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
740 a connection before asking anything else. Correct the check for the destination
741 folder so that it succeeds when online.
742 This fixed projects.maemo.org bug NB#61645.
744 2007-07-05 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
747 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
748 to fix projects.maemo.org bug NB#62439.
750 2007-07-05 Murray Cumming <murrayc@murrayc.com>
752 * src/modest-tny-account.c: (on_connection_status_changed):
753 Really do not use tny_device_force_offline() here. See the previous comment.
755 2007-07-04 Murray Cumming <murrayc@murrayc.com>
757 * src/modest-tny-account.c: (on_connection_status_changed):
758 Do not use tny_device_force_offline() when tinymail says that something
759 went wrong with the connection. It seems to report this unnecessarily.
761 2007-07-04 Murray Cumming <murrayc@murrayc.com>
763 * src/maemo/modest-connection-specific-smtp-window.c:
764 (modest_connection_specific_smtp_window_init):
765 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
766 does not seem to have any effect in osso 1.1 (though it works in
767 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
769 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
771 * src/maemo/modest-connection-specific-smtp-window.c:
772 Fix UI specification problems with projects.meamo.org NB#60479
774 2007-07-04 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
777 clue when this has failed, because the error dialog is not always shown
778 (at least in earlier version).
780 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
781 GError message, because the generic error dialog is not helpful.
783 'This message is not currently available (can't let a new connection go online)'
784 when trying to open an IMAP message.
786 (_modest_ui_actions_open): Offer a connection when some messages would
787 have to be downloaded and we are offline.
789 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
791 * src/widgets/modest-folder-view.c:
792 Don't check for MERGE type anymore as we use the correct type
794 NOTE: For the last two changes you need to update your tinymail copy
795 because of API changes!
797 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
799 * src/modest-tny-local-folders-account.c:
800 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
801 (see projects.maemo.org NB#61580)
803 2007-07-04 Murray Cumming <murrayc@murrayc.com>
805 * src/modest-tny-account.c: (on_connection_status_changed):
806 Commented out the call to modest_platform_connect_and_wait() because this
807 seems to always hang, and I would like to know if this is the only thing
808 that causes a hang when showing the connection dialog.
809 It is not very useful anyway.
811 2007-07-04 Murray Cumming <murrayc@murrayc.com>
813 * src/maemo/modest-msg-view-window.c:
814 (modest_msg_view_window_select_next_message):
816 * src/modest-platform.h:
817 * src/maemo/modest-platform.c:
818 Added modest_platform_connect_and_wait(), which calls
819 tny_maemo_conic_device_connect() always in the main thread, by calling it
820 in an idle handler and waiting for the idle handler to run. It should be
821 in the main thread because it uses GTK+ UI code. It just returns TRUE
822 if the device is already online.
824 There is some nasty code to ensure that subsequent calls to
825 modest_platform_connect_and_wait() just wait for the first one to finish,
826 by checking repeatedly in another idle handler. This is necessary,
827 because other threads (or even the main thread, via another idle handler)
828 can call modest_platform_connect_and_wait() while
829 modest_platform_connect_and_wait() is running.
831 (modest_platform_connect_and_wait_if_network_account),
832 (modest_platform_connect_and_wait_if_network_folderstore):
833 Convenience functions that calls modest_platform_connect_and_wait() if
834 the account or folder might want network access.
836 * src/modest-mail-operation.c:
837 (modest_mail_operation_update_account):
838 * src/modest-ui-actions.c: (download_uncached_messages),
839 (modest_ui_actions_on_rename_folder), (delete_folder),
840 (modest_ui_actions_on_main_window_move_to),
841 (modest_ui_actions_on_msg_view_window_move_to):
842 * src/widgets/modest-folder-view.c:
843 (drag_and_drop_from_folder_view):
844 Offer a connection if we are offline.
846 * src/modest-tny-account.c: (on_connection_status_changed):
847 Document this as only handling errors during network operations in progress,
848 and replace the idle code with a simple call to
849 modest_platform_connect_and_wait(), which does this instead.
851 2007-07-03 Murray Cumming <murrayc@murrayc.com>
853 * src/modest-tny-account.c:
854 (modest_tny_account_get_special_folder): (util_on_idle),
855 Handle the GError so we can see when tny_folder_store_get_folders()
856 fails, as it currently does while something else is connecting.
858 Added util_run_in_main_thread_and_wait()
859 which uses an idlen handler and mainloop to ensure that the function
860 is called in the main thread.
861 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
862 to make sure that we call attempt the connection in the mainloop only,
863 which might solve some hangs.
865 2007-07-03 Murray Cumming <murrayc@murrayc.com>
867 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
868 be found by their display name. This is never useful.
869 * src/modest-tny-account-store.c: (on_account_removed): Find the account
870 by its ID, instead of trying to use its ID as its display name.
872 * src/modest-tny-account-store.h:
873 * src/modest-tny-account.c:
874 (modest_tny_account_get_special_folder): Add a g_warning() when
875 tny_folder_store_get_folders() returns an empty list for the maildir.
877 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
878 Add a g_warning() when this returns NULL, because that it not allowed
881 2007-07-02 Armin Burgmeier <armin@openismus.com>
883 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
884 note when trying to cancel the wizard. This fixes projects.maemo.org
887 2007-07-02 Murray Cumming <murrayc@murrayc.com>
889 * src/modest-tny-account.h:
890 * src/modest-tny-account.c:
891 (modest_tny_account_new_from_server_account),
892 (modest_tny_account_new_from_server_account_name),
893 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
894 because this must now be set before setting the proto. This is usd in
895 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
896 warning in camel_session_get_service() caused by
897 tny_camel_transport_account_prepare().
899 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
902 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
904 * src/maemo/modest-connection-specific-smtp-edit-window.c:
906 (modest_connection_specific_smtp_edit_window_init):
908 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
911 2007-06-29 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-tny-account.c:
914 (modest_tny_account_new_from_server_account):
915 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
916 now uses to request a connection when it needs one, and which it uses
917 to tell us that something is wrong with the connection, so we can force
918 the accounts offline to prevent further problems.
921 * src/modest-init.c: (init_default_settings):
922 * src/modest-mail-operation.c:
923 (modest_mail_operation_update_account):
924 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
925 This should not be necessary anymore. Do not set the conf key that
926 determined this (it was always TRUE and not set anywhere else).
928 * src/modest-ui-actions.h: Remove unused and unimplemented
929 modest_ui_actions_on_online_toggle_toggled().
931 2007-06-29 Murray Cumming <murrayc@murrayc.com
933 * src/maemo/modest-main-window.c: (connect_signals):
934 Don't connect to delete_event twice. Maybe this was harmless.
936 2007-06-29 Murray Cumming <murrayc@murrayc.com
938 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
939 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
940 Debug output to give some more clue when a folder move is not allowed.
942 2007-06-28 Murray Cumming <murrayc@murrayc.com
944 * src/modest-tny-account.c: (on_modest_file_system_info),
945 (modest_tny_account_get_mmc_account_name):
946 Always call the callback, without checking whether the name has changed.
947 * src/widgets/modest-folder-view.c: (strings_are_equal),
948 (on_model_foreach_set_name), (on_get_mmc_account_name),
949 (text_cell_data): Compare the name here, and use the name from
950 the account rather than from the
951 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
952 if the name was changed after the account was added to the model.
953 That's a tinymail bug but not one that I want to fix now.
955 This finally fixes projects.maemo.org bug NB#59301.
957 2007-06-27 Armin Burgmeier <armin@openismus.com>
959 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
962 2007-06-27 Murray Cumming <murrayc@murrayc.com
964 * src/modest-tny-account.h:
965 * src/modest-tny-account.c:
966 Added modest_tny_account_get_mmc_account_name(), to set the memory
967 card name asynchronously for the given account and then notify.
968 (modest_tny_account_new_for_local_folders): Use this new function instead
969 of using hildon_file_system_info_async_new() directly.
971 * src/widgets/modest-folder-view.c: (text_cell_data):
972 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
973 gtk_tree_model_row_changed() when it is available.
975 This should fix projects.maemo.org bug NB#59301.
977 2007-06-27 Murray Cumming <murrayc@murrayc.com
979 * src/modest-mail-operation.c: (update_account_thread),
980 (get_msgs_full_thread): Fix typo failures in the revert
983 2007-06-27 Murray Cumming <murrayc@murrayc.com
985 * src/maemo/modest-maemo-global-settings-dialog.c:
986 (idle_select_default_focus):
987 * src/modest-mail-operation.c: (idle_notify_progress),
988 (idle_notify_progress_once), (set_last_updated_idle),
989 (update_account_thread), (get_msgs_full_thread):
990 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
991 * src/widgets/modest-header-view.c:
992 (idle_notify_headers_count_changed_destroy),
993 (idle_notify_headers_count_changed):
994 Reverted the additions of gdk_threads_enter/leave(), in case this
995 helps with a startup hang on the device.
997 2007-06-26 Armin Burgmeier <armin@openismus.com>
999 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1000 for supported secure authentication methods from server by
1001 gtk_dialog_run(), saving CPU time and a potential race condition.
1003 2007-06-26 Armin Burgmeier <armin@openismus.com>
1005 * src/maemo/modest-maemo-utils.h:
1006 * src/maemo/modest-maemo-utils.c: Added a
1007 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1008 only error code to tell the calling code when the user canceled the
1011 * src/maemo/modest-account-settings-dialog.h:
1012 * src/maemo/modest-account-settings-dialog.c:
1013 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1014 message if the retrieval of secure authentication methods was canceled
1015 by the user. Perform the check before saving anything to configuration
1016 to not end up with half-committed configuration changes, do not show
1017 a "Saving to configuration failed" note when authentication methods
1018 could not be retrieved.
1020 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1023 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1025 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1026 Only return the first level of folders under accounts, because the
1027 osso-global-search UI spec doesn't want the rest.
1028 This fixed projects.maemo.org bug NB#61811.
1030 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-tny-account-store.c:
1033 * src/modest-tny-account-store.h:
1034 Added modest_tny_account_is_memory_card_account().
1035 * src/maemo/modest-main-window.c: (create_details_widget):
1036 Show the same information items for the memory card as we show for the
1037 local-folders, to fix projects.maemo.org bug NB#59307.
1039 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1041 * src/modest-tny-account-store.c: (get_password):
1042 Added some checks for NULL to maybe prevent crashes, though I think
1043 it was Philip's last commit that actually prevented the crash here
1044 when creating a first new account.
1045 But the new account is still not usable (no messages are shown)
1046 until a restart of the application.
1048 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1050 * src/maemo/modest-maemo-global-settings-dialog.c:
1051 (idle_select_default_focus):
1052 * src/modest-mail-operation.c: (idle_notify_progress),
1053 (idle_notify_progress_once), (idle_notify_update_account_queue),
1054 (set_last_updated_idle), (update_account_thread),
1055 (notify_get_msgs_full), (get_msgs_full_destroyer),
1056 (get_msgs_full_thread):
1057 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1058 * src/widgets/modest-header-view.c:
1059 (idle_notify_headers_count_changed_destroy),
1060 (idle_notify_headers_count_changed):
1061 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1062 all idle handlers, because some other thread could be blocking
1063 the GDK lock, so that it can do GUI stuff.
1065 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1067 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1068 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1069 (on_idle_send_receive), (on_idle_open_default_inbox):
1070 * src/maemo/modest-msg-edit-window.c:
1071 (modest_msg_edit_window_attach_file_noninteractive):
1072 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1073 to prevent a hang. I don't quite understand why these are necessary,
1074 beause we should already be in the main loop. I guess something outside
1075 of the main loop is taking the lock.
1077 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1078 we are really using URIs, and use files that are more likely to exist.
1080 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1082 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1083 necessary because configure.ac now defines different variables.
1085 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1087 * libmodest-dbus-client/libmodest-dbus-client.c:
1088 * libmodest-dbus-client/libmodest-dbus-client.h:
1089 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1090 libmodest_dbus_client_compose_mail() is what things actually use.
1092 * src/dbus_api/modest-dbus-api.h:
1093 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1094 * tests/dbus_api/Makefile.am:
1095 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1098 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-init.c: (modest_init_local_folders):
1101 For memory-card (or other non local-folders) maildir accounts,
1102 always create an Archive folder, so that there is somewhere to put
1103 messages. This should be less confusing, because the user does not need
1104 to guess that the need to create a folder.
1106 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1108 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1109 Fixed icon size by using (50, 50) which is the same as defined by
1112 2007-06-25 Armin Burgmeier <armin@openismus.com>
1114 * src/widgets/modest-window-mgr.c:
1115 * src/modest-init.c:
1116 * configure.ac: Correctly recognize hildon-notify presence and fixed
1117 the build without it being installed.
1119 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1121 * libmodest-dbus-client/libmodest-dbus-client.c:
1122 (libmodest_dbus_client_search): Fix the build. Sorry.
1123 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1124 (reply_forward_cb): Initialize variables to fix the build.
1126 * src/modest-tny-account-store.c:
1127 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1128 comparison (a silly typo) so that email search results can be opened
1129 when there are more than one account.
1131 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1133 * libmodest-dbus-client/libmodest-dbus-client.c:
1134 (libmodest_dbus_client_search),
1135 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1136 instead of 1 second, because the search gets folders and messages from
1137 the server, which can take a long time. When it times out,
1138 osso-global-search will report no results.
1140 We need to specify whether we should search only cached information
1141 (maybe with a user preference), and the osso-email-search-plugin
1142 API should really be improved to allow that option, and to allow results
1143 to be delivered asynchronously in batches.
1145 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1147 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1148 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1149 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1151 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1153 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1154 that is an empty string. D-Bus seems to give us these instead of NULL.
1156 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1158 * src/dbus_api/modest-dbus-callbacks.c:
1159 * src/maemo/easysetup/modest-easysetup-wizard.h:
1160 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1161 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1162 (modest_connection_specific_smtp_edit_window_init):
1163 * src/maemo/modest-maemo-global-settings-dialog.c:
1165 * src/maemo/modest-maemo-utils.c:
1166 (modest_maemo_utils_setup_images_filechooser):
1167 * src/maemo/modest-main-window.c: (create_details_widget):
1168 * src/maemo/modest-msg-edit-window.c:
1169 (modest_msg_edit_window_attach_file_noninteractive),
1170 (modest_msg_edit_window_color_button_change),
1171 (modest_msg_edit_window_set_zoom):
1172 * src/modest-mail-operation.c: (update_account_thread):
1173 * src/modest-tny-account-store.c:
1174 * src/modest-tny-account.c:
1175 * src/widgets/modest-global-settings-dialog.c:
1176 * src/widgets/modest-window.h:
1178 Fixed build on bora!
1180 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1182 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1183 * src/modest-search.c: (modest_search_folder),
1184 (modest_search_all_accounts): Actually search only in the specified folder,
1185 doing a simple match on the folder ID.
1186 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1187 and added some documentation.
1189 2007-06-22 Armin Burgmeier <armin@openismus.com>
1191 * src/maemo/modest-maemo-utils.h:
1192 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1193 modest_maemo_utils_get_supported_secure_authentication_methods.
1195 * src/maemo/easysetup/modest-easysetup-wizard.c:
1196 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1197 one occured, not just "Server does not support secure authentication".
1199 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-tny-account-store.c: (get_password):
1202 Restored the call to tny_account_set_user() because Philip seems to have
1203 stopped this from crashing (by not using the freed string). It still does
1204 not work, but now we can test it.
1206 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1208 * src/maemo/modest-msg-edit-window.c: (init_window):
1209 Comment out use of an uninitialzed GtkScrolledWindow variable,
1210 to fix the build and stop a crash. Yet again.
1212 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1214 * src/modest-tny-account-store.c: (get_password):
1215 Remove the call to tny_account_set_user() because this actually crashes.
1216 As mentioned in the last commit, it is known to not work anyway.
1218 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-tny-account-store.c: (get_password):
1221 Use tny_account_set_username() to tell tinymail that the username might
1222 have changed too. But tinymail ignores this: see projects.maemo.org
1224 * src/modest-ui-actions.c:
1225 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1226 reset the connection when changing the username, and improve the comments.
1227 Save the changed username to gconf at least, so it is used when Modest is
1230 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1232 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1233 Do not use a query, so that we get all folders, including for POP and
1234 local-folders. They work as search criteria too.
1235 This fixes projects.maemo.org bug NB#57740.
1237 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1239 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1240 Comment out the use of hildon_notification_set_sound() because it is
1241 not declared, to fix the build. Warnings are serious, people.
1243 2007-06-21 Armin Burgmeier <armin@openismus.com>
1245 * src/maemo/modest-maemo-utils.h:
1246 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1247 modest_maemo_utils_get_supported_secure_authentication_methods()
1248 to query authentication methods for a specific user. This should fix
1249 projects.maemo.org bug NB#61369.
1251 * src/maemo/easysetup/modest-easysetup-wizard.c:
1252 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1255 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1257 * libmodest-dbus-client/libmodest-dbus-client.h:
1258 * libmodest-dbus-client/libmodest-dbus-client.c:
1259 (modest_dbus_message_iter_get_search_hit),
1260 (libmodest_dbus_client_search):
1261 Reorganised and commented this.
1262 Removed modest_search_hit_free() from the public API because it
1265 Added libmodest_dbus_client_get_folders() and
1266 modest_folder_result_list_free().
1268 * src/dbus_api/modest-dbus-api.h:
1269 * src/dbus_api/modest-dbus-callbacks.c:
1270 (modest_dbus_req_filter): Commented. Moved most code to
1271 on_dbus_method_search() and added on_dbus_method_get_folders().
1273 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1274 of the extra D-Bus handler.
1276 * tests/dbus_api/Makefile.am:
1277 * tests/dbus_api/test_get_folders.c: New test for
1278 libmodest_dbus_client_get_folders(). This seems to return an empty list
1279 at the moment. That could be the same error that causes the message list
1280 to be empty sometimes.
1281 This should help with projects.maemo.org bug NB#57740.
1283 2007-06-21 Armin Burgmeier <armin@openismus.com>
1285 * src/modest-mail-operation.c: Do not call
1286 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1287 notify the operation's end after having set the status to CANCELED for
1288 the operation queue to listen on. This fixes a deadlock when there
1289 were mail operations in the queue during its finalization.
1291 * src/modest-singletons.c: Reordered uninitialization of the account
1292 manager to happen after the mail operation queue was uninitialized
1293 because the mail operation's in the queue might still try to access
1294 the account manager (see modest_mail_operation_notify_end()). This
1295 fixes a potential crash when terminating the application.
1297 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1299 * src/modest-search.c:
1300 (search_mime_part_and_child_parts): Moved some code here so we
1301 can search recursively in child folders.
1302 (modest_search_folder): Search in the message as a mime part, instead
1303 of just its child mime parts.
1304 (read_chunk), (search_mime_part_ogs):
1305 Check how many bytes were read, to prevent an endless loop.
1306 Searching in message bodies now works. This finishes the fix for
1307 projects.maemo.org bug NB#61007.
1309 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1311 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1312 Add a g_warning when the item is not a folder.
1314 * src/modest-ui-dimming-rules.c:
1315 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1316 when selected item is not a folder (for instance, an account), because
1317 the UI spec only talks about folders.
1318 I am not sure what the UI spec wants, so this might not totally fix
1319 projects.maemo.org bug NB#60794.
1321 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1323 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1324 (load_from_file): Sort the list. The unsorted list would be more noticeable
1325 in non-English locales.
1327 * src/maemo/modest-msg-edit-window.c:
1328 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1329 warning and fix the build.
1331 * src/maemo/modest-progress-bar-widget.c:
1332 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1333 avoid a g_warning, and probably to avoid a crash.
1335 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1337 * src/modest-search.c: (modest_search_folder): Check for a GError
1338 when calling tny_folder_get_headers(), to show that this is not the cause
1341 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1343 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1344 Actually set the body query instead of the subject query.
1346 * src/modest-search.c: (search_mime_part_ogs),
1347 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1348 which would probably cause it to fail if we got this far.
1350 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1351 to simplify the code.
1352 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1353 be causing search-in-body to fail.
1355 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1357 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1359 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1360 Better debug message when the folder cannot be found.
1361 This should help with fixing projects.maemo.org bug #61287.
1362 * src/modest-search.c: (add_hit): Do not leak the furl string.
1364 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1366 * src/modest-ui-actions.c:
1367 (modest_ui_actions_on_folder_selection_changed):
1368 Do not special-case TNY_MERGE_FOLDER here, because
1369 modest_tny_folder_get_account() already does that. This fixes
1370 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1371 shown when the Outbox was selected).
1373 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1375 * libmodest-dbus-client/libmodest-dbus-client.c:
1376 (_dbus_iter_get_string_or_null): Initialize the string variable in
1377 case this helps with Dirk's crash.
1379 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1381 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1382 though it is not implemented yet (this function is maybe not even used),
1383 to avoid breaking ABI in future.
1384 * libmodest-dbus-client/libmodest-dbus-client.c:
1385 (get_attachments_string): Moved some code into this generic function.
1386 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1387 sends email. It is maybe not used.
1388 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1389 (on_send_mail): Use attachments.
1391 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1392 * src/maemo/modest-msg-edit-window.c:
1393 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1394 a filename before using it, to fix projects.maemo.org bug NB#58233.
1396 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1398 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1399 Initialize the continue_download variable to fix the build, and probably
1400 to fix randome behaviour.
1402 2007-06-18 Armin Burgmeier <armin@openismus.com>
1404 * src/modest-tny-send-queue.h:
1405 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1406 the queue so we can later show it in the UI. Replaced
1407 modest_tny_send_queue_msg_is_being_sent() by
1408 modest_tny_send_queue_get_msg_status().
1410 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1412 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1413 gpointer. This probably was not harmful, but just to be sure.
1415 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1417 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1418 Fix the build, but leave the function broken on Bora, because
1419 hildon_uri_action_get_service() does not exist.
1420 osso_uri_action_get_service() does not exist either, it seems.
1422 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1424 * src/modest-tny-account.c:
1425 (modest_tny_account_new_from_server_account):
1426 Uncommented the url debug output again, because it is useful for
1427 debugging, as I said in the comment.
1429 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1431 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1433 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1434 for Mameo Bora, to fix the build.
1436 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1439 Fixed build with hildon < 0.99
1441 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1442 Check if the selected account is busy instead of checking all accounts
1444 * src/modest-account-mgr-priv.h:
1445 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1446 (modest_account_mgr_init), (compare_account_name),
1447 (modest_account_mgr_set_account_busy),
1448 (modest_account_mgr_account_is_busy):
1449 * src/modest-account-mgr.h:
1450 Added busy information to the account manager. It possible to
1451 set an account to busy or not busy now.
1453 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1454 (modest_mail_operation_update_account),
1455 (modest_mail_operation_notify_end):
1456 Set the account to busy/not busy depending on the operation state.
1458 * src/widgets/modest-account-view.c:
1459 (modest_account_view_finalize), (get_last_updated_string),
1460 (update_account_view), (on_account_busy_changed), (init_view):
1461 Show string "Refreshing..." if the account is currently busy.
1463 All this fixes projects.maemo.org bug NB#59711
1465 2007-06-14 Armin Burgmeier <armin@openismus.com>
1467 * src/widgets/modest-attachments-view.h:
1468 * src/widgets/modest-attachments-view.c: Added
1469 modest_attachments_view_has_attachments() and fixed coordinate
1470 transformation in get_att_view_at_coords(). This fixes attachment
1473 * src/widgets/modest-msg-view.c: Make use of
1474 modest_attachments_view_has_attachments() to decide whether to show
1475 attachments in the header.
1477 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1479 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1480 (on_change), (on_combo_security_changed),
1481 (modest_connection_specific_smtp_edit_window_init),
1482 (modest_connection_specific_smtp_edit_window_set_connection),
1483 (modest_connection_specific_smtp_edit_window_is_dirty):
1484 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1485 * src/maemo/modest-connection-specific-smtp-window.c:
1488 Show an comfirmation dialog for the smpt-edit-window if there are
1489 unsaved changes and the user hits cancel.
1490 (projects.maemo.org bug NB#60479)
1492 2007-06-14 Armin Burgmeier <armin@openismus.com>
1494 * src/maemo/easysetup/modest-easysetup-wizard.c:
1495 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1496 address" info in banner instead of node, and select all the text as
1497 per UI spec. This fixes projects.maemo.org bug NB#60550.
1499 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1501 reviewed by: <delete if not using a buddy>
1503 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1504 * src/modest-ui-actions.c: (folder_refreshed_cb):
1506 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1508 * src/widgets/modest-folder-view.c: (filter_row):
1509 Explictly filter out the per-account outbox accounts. I don't know why
1510 these only sometimes show up, but now they should never show up in the UI.
1511 This should fix projects.maemo.org bug NB#60160.
1513 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1515 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1516 when the toolbar does not exist yet.
1517 * src/modest-widget-memory.c: (save_settings_header_view):
1518 Added g_warnings() to help us to discover when we are trying to set
1519 an empty columns list in gconf.
1521 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-init.h:
1524 * src/modest-init.c:
1525 Added modest_init_get_default_header_view_column_ids().
1527 * src/modest-widget-memory.c: (restore_settings_header_view):
1528 Use the new function to get defaults, if the gconf key is empty,
1529 instead of not creating any columns. This seems to fix the
1530 empty right-hand pane problems.
1532 * src/widgets/modest-header-view.h: Improved documentation.
1534 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1536 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1537 Revert the use of the display name as the account name, because this
1538 is generally wrong and would break the code that follows.
1540 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1542 * src/maemo/easysetup/modest-easysetup-wizard.c:
1543 (check_for_supported_auth_methods), (on_before_next),
1546 More correct fix for projects.maemo.org bug NB# 58991
1547 Do not longer accept AUTH_PASSWORD as secure method and choose
1548 correct method when creating the account.
1550 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1552 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1553 Fixed projects.maemo.org bug NB# 58991
1555 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-init.c: (modest_init_init_core),
1558 (modest_init_local_folders): Fixed compilation errors.
1560 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1562 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1563 Remove unnecessary lib/include, though it is good in principle when needed.
1565 * src/modest-init.c: (modest_init_one_local_folder),
1566 (modest_init_local_folders):
1567 * src/modest-init.h: Initialize the .modest library for memory cards,
1568 instead of just doing nothing for them. This should allow us to create
1569 folders there, fixing projects.maemo.org bug NB#59297.
1571 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1573 * libmodest-dbus-client/libmodest-dbus-client.c:
1574 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1575 (libmodest_dbus_client_compose_mail),
1576 (libmodest_dbus_client_open_message),
1577 (libmodest_dbus_client_send_and_receive),
1578 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1580 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1581 (on_idle_open_message), (modest_dbus_req_handler),
1582 (search_result_to_message), (modest_dbus_req_filter):
1583 * src/modest-search.c: (add_hit), (modest_search_folder),
1584 (modest_search_all_accounts): Improved debug messages.
1586 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1588 * src/modest-tny-account-store.c:
1589 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1592 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1595 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1597 * src/modest-tny-account-store.c: (get_server_accounts):
1598 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1599 even when there are no accounts, so that the Outbox folder is always
1600 visible. This fixes projects.maemo.org bug NB#60158.
1602 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1604 * src/maemo/modest-main-window.c: (create_details_widget):
1605 Use the mcen_va_never logical ID.
1607 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1609 * src/dbus_api/modest-dbus-api.h:
1610 * src/dbus_api/modest-dbus-callbacks.c:
1611 (on_idle_open_default_inbox), (on_open_default_inbox),
1612 (modest_dbus_req_handler):
1613 Added a new OpenDefaultInbox method.
1615 * libmodest-dbus-client/libmodest-dbus-client.h:
1616 * libmodest-dbus-client/libmodest-dbus-client.c:
1617 Added libmodest_dbus_client_open_default_inbox() to call the new
1618 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1619 though it should maybe be used by a new osso-email-interface function.
1621 * tests/dbus_api/Makefile.am:
1622 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1625 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1628 NULL, so that the signals get all the keys. This should not actually
1629 change any behaviour because we currently update everything when anything
1632 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1634 * src/widgets/modest-folder-view.c: (text_cell_data),
1635 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1636 (find_inbox_iter): If tinymail tells us that the folder is
1637 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1638 This causes the inbox to be selected at startup, fixing part of
1639 projects.maemo.org bug NB#56305.
1641 * src/modest-ui-dimming-rules.c:
1642 (modest_ui_dimming_rules_on_tools_smtp_servers):
1643 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1644 the SMTP servers menu item.
1645 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1646 that the SMTP Servers menu item is dimmed when there are no accounts,
1647 as a future version of the UI spec will require. This fixes
1648 projects.maemo.org bug NB#56305.
1650 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1652 * src/maemo/modest-maemo-utils.c:
1653 (modest_maemo_utils_get_supported_secure_authentication_methods):
1654 Added label to dialog instead of unreadable title
1656 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1657 (modest_main_window_new):
1658 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1661 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1662 * src/modest-account-mgr.h:
1663 Added method to avoid code duplication
1665 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1666 (modest_ui_actions_on_send_receive):
1667 Use modest_account_mgr_has_accounts
1669 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1671 * src/maemo/easysetup/modest-presets.c:
1672 (modest_presets_get_info_server_security): Do not report secure auth
1674 * src/modest-protocol-info.c: Use the defines for the gconf key names
1675 for secure authentication. This was not working because we were writing
1676 Password and reading password, and the check was case sensitive.
1677 With this, gmail now works for receiving and sending when created via
1680 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1682 * src/maemo/easysetup/modest-presets.c:
1683 (modest_presets_get_info_server_security): Correct the key name for
1684 SecureSmtp, because it seems to be case-sensitive.
1685 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1686 Do not try to get the 0th notebook page if there are 0 pages, to
1687 avoid a g_warning().
1689 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1691 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1692 Prevent use of the new notification feature for now, because it currently
1693 shows one dialog for each new email, which is annoying.
1695 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1697 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1698 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1699 when no country was selected, so that we show the global ones.
1700 * src/maemo/easysetup/modest-presets.c:
1701 (modest_presets_get_providers): Return only the global providers, not
1702 all providers when mmc=0 was requested.
1704 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1706 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1707 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1708 provider ID in the combo.
1710 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1711 Do not show the page numbers, because it would be confusing when we add
1712 the 2 extra pages for the custom setup, when the user chooses the "Other"
1713 provider. This fixes projects.maemo.org bug NB#59028
1715 * src/modest-init.c: (modest_init_init_core),
1716 (modest_init_local_folders):
1717 * src/modest-init.h:
1718 * src/modest-tny-account.c:
1719 (modest_tny_account_new_for_local_folders): Do not create default folders
1720 for the memory card. This should fix projects.maemo.org bug NB#59328.
1722 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1724 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1725 Free the changed_conf_keys string items. They are already freed in the
1726 idle handler if that runs first.
1728 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1730 * src/modest-ui-actions.c:
1731 (modest_ui_actions_on_password_requested): Check that the server name
1732 is not NULL, because I just saw a password dialog with (null) as the
1735 * src/modest-tny-folder.[h|c]: Added
1736 modest_tny_folder_is_memory_card_folder().
1737 * src/modest-ui-dimming-rules.c:
1738 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1739 menu item for memory cards, as per the UI spec (section 7.4). This should
1740 fix projects.maemo.org bug NB#59297.
1742 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1744 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1745 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1746 is another problem with the code, see Murray's comment at line 772)
1748 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1751 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1752 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1753 (load_from_file), (easysetup_country_combo_box_init),
1754 (easysetup_country_combo_box_get_active_country_ids),
1755 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1756 instead of just one ID, to avoid duplicate country names in the UI.
1758 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1759 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1760 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1761 a single ID, avoiding duplicate providers.
1762 * src/maemo/easysetup/modest-easysetup-wizard.c:
1763 (on_combo_account_country): Adapt to use a list.
1765 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1767 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1768 keys changed in the last X seconds.
1770 * src/modest-account-mgr.h:
1771 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1772 (on_key_change), (modest_account_mgr_class_init),
1773 (modest_account_mgr_init), (modest_account_mgr_finalize):
1774 As the keys are changed, save them in a GSList* and signal that GSList*
1775 further every X seconds, to batch changes, to allow us to do just one
1776 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1777 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1779 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1780 changed signal signature.
1782 * src/modest-conf.c: (modest_conf_set_list),
1783 (modest_conf_on_change): Reenable notification.
1785 (modest_conf_maemo_fake_on_change): Comment out the hack that
1786 notified immediately instead of asynchronously.
1788 * src/widgets/modest-account-view.h:
1789 * src/widgets/modest-account-view.c:
1790 (update_account_view): Select the previously-selected account ID,
1791 if possible. This fixes projects.maemo.org bug NB#56933.
1793 (on_account_changed), (on_account_removed),
1794 (modest_account_view_select_account):
1796 Remove the block/unblock functions
1797 because they were not useful.
1799 * src/maemo/modest-account-view-window.c:
1800 (on_delete_button_clicked), (on_edit_button_clicked),
1801 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1803 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1805 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1806 Improve the error dialog to show Incorrect Account Settings, which seems
1807 clearer, and say that the internal error message (to be removed from the
1808 dialog later) is often misleading.
1809 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1811 * src/modest-tny-account.c:
1812 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1813 URL because this is so useful for debugging on the device.
1815 * src/widgets/modest-serversecurity-combo-box.c:
1816 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1818 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1820 * src/modest-mail-operation.c:
1821 (modest_mail_operation_send_new_mail):
1822 Added a comment about a nasty but apparently harmless message. Details
1823 added to the wiki g_warnings() page.
1825 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1827 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1828 (modest_tny_send_queue_class_init):
1829 Do not use the priv struct because it is empty, to avoid g_warnings
1830 about a non-existant priv struct.
1832 * src/modest-tny-account-store.c:
1833 (modest_tny_account_store_get_server_account),
1834 (modest_tny_account_store_get_transport_account_for_open_connection
1835 ): Do not try to get transport server accounts for local folders,
1836 because they don't have any. This avoids a g_warning().
1838 * src/maemo/modest-main-window.c:
1839 (modest_main_window_notify_send_receive_initied),
1840 (on_configuration_key_changed):
1841 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1842 * src/modest-defs.h:
1843 * src/modest-mail-operation.c:
1844 (modest_mail_operation_update_account):
1845 * src/modest-tny-account-store.h:
1846 * src/modest-tny-account.c:
1847 (modest_tny_account_get_special_folder),
1848 (modest_tny_account_new_for_local_folders),
1849 (modest_tny_account_new_for_per_account_local_outbox_folder):
1850 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1851 * src/modest-tny-local-folders-account.c:
1852 (add_account_folders_to_merged_folder):
1853 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1854 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1855 (modest_ui_actions_on_send):
1856 * src/widgets/modest-folder-view.c: (update_model):
1857 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1858 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1859 modest_tny_account_store_get_tny_account_by_account() to
1860 modest_tny_account_store_get_server_account() to make the code clearer.
1862 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1864 * src/dbus_api/modest-dbus-api.h:
1865 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1866 * src/maemo/modest-msg-edit-window.c:
1867 (modest_msg_edit_window_attach_file_noninteractive):
1868 added g_warning in case the file to be attached does not exist
1869 * tests/dbus_api/test_compose_mail.c: (main):
1870 removed obsolete comment, added generic files as test case
1872 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-tny-account-store.c: (get_server_accounts):
1875 Create the local folders account only once, not once for each outbox, and
1876 not only when there are some outboxes.
1878 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1880 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1881 code that is causing a crash at startup. Sergio says that he is fixing this.
1883 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1885 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1886 * src/maemo/modest-account-settings-dialog.c:
1887 (create_page_outgoing),
1888 (modest_account_settings_dialog_set_account_name),
1889 (save_configuration):
1890 - Fixed handling of the "Use secure authentication" toggle to comply with
1891 the ui specification. See also projects.maemo.org bug NB#58400
1893 - Restore the Secure connection setting combo correctly when loading
1896 * src/maemo/modest-maemo-utils.c:
1897 (on_camel_account_get_supported_secure_authentication),
1898 (modest_maemo_utils_get_supported_secure_authentication_methods):
1899 Fixed a crasher if operation is canceled
1901 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1902 (modest_protocol_info_auth_is_secure):
1903 * src/modest-protocol-info.h:
1905 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1906 the sense of the "Use secure authentication" toggle.
1908 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1910 * src/modest-tny-account-store.h:
1911 * src/modest-tny-account-store.c:
1912 Added modest_tny_account_store_get_local_folders_account().
1914 * src/modest-tny-folder.h:
1915 * src/modest-tny-folder.c:
1916 (modest_tny_folder_get_account):
1917 Added this replacement for tny_folder_get_account() which returns
1918 the local-folders account for TnyMergeFolders, to avoid the
1919 warning about the unimplemented get_account_func() vfunc().
1921 (modest_tny_folder_get_rules),
1922 * src/modest-ui-actions.c:
1923 (modest_ui_actions_on_folder_selection_changed):
1924 * src/modest-mail-operation.c:
1925 (modest_mail_operation_remove_folder),
1926 (modest_mail_operation_xfer_folder),
1927 (modest_mail_operation_rename_folder),
1928 (modest_mail_operation_get_msg),
1929 (modest_mail_operation_get_msgs_full),
1930 (modest_mail_operation_remove_msg),
1931 (modest_mail_operation_xfer_msgs),
1932 (modest_mail_operation_refresh_folder):
1933 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1935 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1937 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1938 (modest_server_account_set_security):
1939 * src/modest-defs.h: Add comments explaining that our
1940 UI spec means TLS when it says Normal, so these do not look like errors.
1942 * src/modest-tny-account.c:
1943 (modest_tny_account_new_from_server_account): Use the new tinymail
1944 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1945 for TLS. This should fix projects.maemo.org bug NB#58460.
1947 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1949 * src/maemo/easysetup/modest-easysetup-wizard.c:
1950 (create_account): Correct the position of the gconf sanity check warning.
1951 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1952 of using the g_idle_add() hack, because this does not seem to be necessary
1953 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1954 caused by something other than maemo's gconf.
1955 This fixes projects.maemo.org bug #59022.
1957 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-account-mgr-helpers.c:
1960 (modest_account_mgr_get_default_account): Do not check that the account
1961 exists if there is no default account (NULL), to fix a runtime warning.
1963 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1965 * src/widgets/modest-folder-view.c: (update_model):
1966 Do not unref the treemodel before we have finished with it.
1967 This prevents a valgrind warning and an occasional crash at startup.
1969 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1971 * libmodest-dbus-client/libmodest-dbus-client.h:
1972 added libmodest_dbus_client_compose_mail()
1973 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1975 added functions needed for SendAsMail() functionality
1976 * src/maemo/modest-msg-edit-window.c:
1977 (modest_msg_edit_window_attach_file_noninteractive):
1978 non interactively attaching files to message edit window
1979 * src/widgets/modest-msg-edit-window.h:
1980 * tests/dbus_api/Makefile.am:
1981 added test_compose_mail.c
1982 * tests/dbus_api/test_compose_mail.c: (main):
1984 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1986 * src/modest-account-view.c:
1987 Fixed bug projects.maemo.org bug NB#59307
1989 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1991 * src/maemo/easysetup/modest-easysetup-wizard.c:
1992 (get_serverport_incoming), (on_before_next), (create_account):
1993 * src/maemo/modest-account-settings-dialog.c:
1994 (modest_account_settings_dialog_set_account_name):
1995 * src/maemo/modest-maemo-utils.c:
1996 (on_camel_account_get_supported_secure_authentication_status),
1997 (on_camel_account_get_supported_secure_authentication),
1998 (on_secure_auth_cancel),
1999 (modest_maemo_utils_get_supported_secure_authentication_methods):
2001 Implemented security authentication for settings and easysetup.
2003 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2005 * src/maemo/modest-main-window.c: (create_details_widget):
2006 Show the total size for memory card accounts too, instead of showing
2007 the name again. Fixes bug projects.maemo.org bug NB#59307.
2009 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-tny-simple-folder-store.c:
2013 * src/modest-tny-simple-folder-store.h: Removed.
2015 * src/modest-tny-local-folders-account.h
2016 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2017 for the local-folders maildir, with an extra TnyMergedFolder containing
2018 the folders of the per-account outbox store accounts.
2019 * src/modest-tny-account-store.c: (get_server_accounts):
2020 Add the outboxes to the special local folders account after creating it.
2022 * src/modest-tny-account.c:
2023 (modest_tny_account_new_for_local_folders): Create the derived
2024 account when creating the main local-folders account.
2026 * src/maemo/modest-main-window.c: (create_details_widget),
2027 (modest_main_window_set_contents_style):
2028 Adapted to the use of the derived account instead of the folder store.
2030 * src/modest-ui-actions.c:
2031 (modest_ui_actions_on_folder_selection_changed):
2032 * src/modest-ui-dimming-rules.c:
2033 (modest_ui_dimming_rules_on_new_folder):
2034 * src/widgets/modest-folder-view.c: (text_cell_data),
2035 (icon_cell_data), (filter_row), (update_model),
2036 (get_cmp_rows_type_pos):
2039 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2040 Do not get the priv struct, because no priv struct has been set,
2041 to avoid a runtime warning.
2043 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2044 #ifelse with #else, to fix a warning, to fix the build.
2047 2007-06-05 Christian Kellner <ckellner@openismus.com>
2049 * libmodest-dbus-client/libmodest-dbus-client.c:
2050 Fix small typo in doc (why do you always see them
2051 AFTER committing stuff?)
2054 2007-06-05 Christian Kellner <ckellner@openismus.com>
2056 * libmodest-dbus-client/libmodest-dbus-client.c:
2057 (libmodest_dbus_client_search):
2058 Initialize hit list with NULL. Also set folder list
2059 to "" if NULL was supplied.
2062 2007-06-03 Christian Kellner <ckellner@openismus.com>
2064 * libmodest-dbus-client/libmodest-dbus-client.c:
2065 (modest_search_hit_list_free):
2066 Make it save to call it with NULL.
2068 * src/dbus_api/modest-dbus-callbacks.c:
2069 * src/modest-search.c:
2070 Return full ModestSearchHits as the search result list not TnyHeader
2071 since can't be around withouth the correspoding TnyFolder.
2073 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2075 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2076 Added currently commented code to check for secure auth
2078 * src/maemo/modest-account-settings-dialog.c: (on_response),
2079 (save_configuration), (show_ok):
2080 Fixed projects.maemo.org bugs NB #59248 and #59251
2082 * src/maemo/modest-maemo-utils.c:
2083 (on_camel_account_get_supported_secure_authentication_status),
2084 (on_camel_account_get_supported_secure_authentication),
2085 (modest_maemo_utils_get_supported_secure_authentication_methods):
2086 * src/maemo/modest-maemo-utils.h:
2087 Moved get_supported_secure_authentication() method here to be able
2088 to use it from easysetup wizard.
2090 * src/modest-pair.c: (on_pair_compare_as_string):
2091 Should compare string with first part of pair and not
2092 strcmp pairs which will crash.
2094 * src/modest-protocol-info.c:
2095 (modest_protocol_info_protocol_is_store):
2096 * src/modest-protocol-info.h:
2097 Added modest_protocol_info_get_auth_protocol_name()
2099 2007-06-03 Armin Burgmeier <armin@openismus.com>
2101 * src/modest-mail-operation.c:
2102 (modest_mail_operation_get_msgs_full): Set priv->account also when
2103 only retrieving a single message. This avoids a crash when canceling
2106 (modest_mail_operation_notify_end): Do not explicitely remove the
2107 operation from the queue but only emit the progress_changed signal.
2108 The queue itself listens to that signal to remove the operation when
2109 it is finished. This reduces coupling and removes a potential deadlock
2110 when modest_mail_operation_notify_end() is called from the queue
2111 itself. If that is a problem performance-wise, I would suggest to
2112 implement a status-changed signal or something.
2114 * src/modest-mail-operation-queue.c: Make sure to never call a
2115 function from another file while the queue is locked. This (hopefully)
2116 fixes another deadlock when exiting the application while retrieving
2119 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2121 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2122 Fixed build if libogs is not available
2124 2007-06-03 Christian Kellner <ckellner@openismus.com>
2126 * libmodest-dbus-client/libmodest-dbus-client.h:
2127 * libmodest-dbus-client/libmodest-dbus-client.c:
2128 (libmodest_dbus_client_delete_message):
2129 Implement deletion of messages (Client side).
2131 (modest_search_hit_free),
2132 (modest_search_hit_list_free):
2133 Utility functions to free the result hits.
2135 * src/dbus_api/modest-dbus-api.h:
2136 * src/dbus_api/modest-dbus-callbacks.c:
2137 (on_delete_message),
2138 (modest_dbus_req_handler):
2139 Implement deletion of messages (Server side).
2141 * tests/dbus_api/test_search.c: (main):
2144 * tests/dbus_api/Makefile.am:
2145 * tests/dbus_api/test_delete_message:
2146 Add little test for the message deletion logic
2148 2007-06-03 Armin Burgmeier <armin@openismus.com>
2150 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2151 when the operation queue was not empty. projects.maemo.org bug
2154 2007-06-03 Armin Burgmeier <armin@openismus.com>
2156 * src/widgets/modest-account-view.c
2157 (on_account_default_toggled): Toggle default account column
2158 explicitely instead of waiting for gconf notification (which is
2159 currently ignored). This should fix projects.maemo.org bug NB#56910
2160 for now. It should probably be removed when gconf notifications are
2163 2007-06-03 Christian Kellner <ckellner@openismus.com>
2165 * libmodest-dbus-client/libmodest-dbus-client.c:
2166 Removed debugging spew.
2168 * src/dbus_api/modest-dbus-callbacks.c:
2169 Added debugging info.
2171 * src/modest-search.c:
2172 (modest_search_all_accounts):
2173 Use tny_account_store_get_accounts () on the account store
2174 to get all accounts which is the way to get all accounts.
2176 * tests/dbus_api/test_search.c: (main):
2177 Make it possible to supply the search term on the command line.
2179 2007-06-03 Christian Kellner <ckellner@openismus.com>
2181 * libmodest-dbus-client/libmodest-dbus-client.c:
2182 * libmodest-dbus-client/libmodest-dbus-client.h:
2183 Implement searching for mesages over raw dbus. (Client side)
2185 * src/dbus_api/Makefile.am:
2186 * src/dbus_api/modest-dbus-api.h:
2187 * src/dbus_api/modest-dbus-callbacks.c:
2188 * src/dbus_api/modest-dbus-callbacks.h:
2189 Search framework (Server side). Also implement on_idle_open_message().
2191 * src/maemo/modest-platform.c: (modest_platform_init):
2192 Prepare for raw dbus/osso rpc interaction.
2194 * src/modest-search.h:
2195 Changed minsize from unspecific guint to guint32.
2197 * src/modest-search.c:
2199 Added strange hack which magically made tnymail work.
2201 (modest_search_folder),
2202 (modest_search_account),
2203 (modest_search_all_accounts):
2204 Implement helper functions to search all accounts, specific account
2207 * tests/dbus_api/Makefile.am:
2208 * tests/dbus_api/test_open_message.c:
2209 Read url to open from commandline.
2211 * tests/dbus_api/test_search.c:
2212 Implement small test for dbus search stuff
2214 2007-06-02 Armin Burgmeier <armin@openismus.com>
2216 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2217 include account type and account title. This fixes projects.maemo.org
2220 * src/maemo/modest-account-view-window.c: Set a title for the window.
2222 2007-06-02 Armin Burgmeier <armin@openismus.com>
2224 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2225 incoming and outgoing server name based on email address and server
2226 types as long as the names have not been edited manually. This fixes
2227 projects.maemo.org bug NB#58671.
2229 2007-06-02 Armin Burgmeier <armin@openismus.com>
2231 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2232 server type cannot be changed in future to the incoming details page
2233 when creating an account. This fixes projects.maemo.org bug NB#59029.
2235 2007-06-02 Armin Burgmeier <armin@openismus.com>
2237 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2238 and assigned max width chars so that they wrap instead of being
2239 truncated. Fixes projects.maemo.org bug NB#56126.
2241 2007-06-02 Armin Burgmeier <armin@openismus.com>
2243 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2244 introductory note to the connection specific smtp servers dialog, as
2245 section 8.12 of the email UI specification requires. This fixes
2246 projects.maemo.org bug NB#59212.
2248 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2250 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2251 Check for running mail operations, and offer to cancel them, as per the UI
2252 spec. This fixes projects.maemo.org bug NB#59041 .
2253 However, I suspect that tinymail may still use the network connection
2254 in ways that we cannot detect or cancel. But it should at least adapt to
2255 changes fairly well.
2257 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2259 * src/modest-tny-account-store.c: (recreate_all_accounts),
2260 (get_cached_accounts), (get_server_accounts): Do more sensible
2261 ref-counting of the temporarily-cached outbox accounts list. This seems
2262 to fix a crash when entering the password when the password was wrong.
2264 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2266 * src/gnome/modest-main-window.c: (connect_signals):
2267 * src/modest-tny-account-store.c: (get_password),
2268 (modest_tny_account_store_alert): Added comments and clues and
2269 commented-out code about how we currently fail to deal with connection
2270 errors and wrong passwords, and how we should.
2272 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2274 * src/widgets/modest-retrieve-combo-box.c:
2275 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2276 This fixes projects.maemo.org bug NB#58472 .
2278 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2280 * src/maemo/easysetup/modest-easysetup-wizard.c:
2281 (create_page_complete_easysetup):
2282 (create_page_complete_custom): Correct the last commit,
2283 putting the correct sentences in the correct pages.
2285 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/easysetup/modest-easysetup-wizard.c:
2288 (create_page_complete_custom): Show the second sentence of text
2289 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2292 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2294 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2295 Set the leave-on-server conf key by default. This fixes
2296 projects.maemo.org bug NB#59258 .
2298 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2300 * src/maemo/modest-account-view-window.c:
2301 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2302 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2305 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/easysetup/modest-easysetup-wizard.c:
2308 (create_caption_new_with_asterisk):
2309 * src/maemo/modest-account-settings-dialog.c:
2310 (create_caption_new_with_asterisk):
2311 Uncomment the code to add the asterisk, because they are no longer in the
2312 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2313 (update_incoming_server_title): Add an asterisk here too.
2315 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2317 * src/maemo/modest-maemo-global-settings-dialog.c:
2318 (current_connection): Check that we are even connected before trying to
2319 get the current connection name, to prevent a warning.
2321 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2322 Change the comments because tny_maemo_conic_device_connect() is now meant to
2324 * src/modest-mail-operation.c:
2325 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2326 make sure we have a connection and fail if we can't connect.
2328 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2330 * src/maemo/modest-main-window.c:
2331 (on_account_store_connecting_finished): Do not try to get the
2332 connection ID if we are not really connected. I am surprised that
2333 this signal handler is called when we are not connected.
2335 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2337 * src/modest-error.h:
2338 * src/modest-ui-actions.c:
2339 (modest_ui_actions_get_msgs_full_error_handler):
2340 Renamed an enum, added comments, added an enum
2341 for retrieve-limit errors.
2343 * src/modest-mail-operation.c: (foreach_add_item),
2344 (internal_folder_observer_update), (update_account_thread),
2345 (modest_mail_operation_get_msgs_full):
2346 (modest_mail_operation_update_account),
2347 Added comments about how this works, and some code that should
2348 (but does not) check the retrieve-limit. See the TODO comment.
2350 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2352 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2353 Initialize help_id to fix the build. Warnings are good.
2355 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2357 * src/widgets/modest-hbox-cell-renderer.c:
2358 (modest_hbox_cell_renderer_append):
2359 * src/widgets/modest-vbox-cell-renderer.c:
2360 (modest_vbox_cell_renderer_append):
2361 Fix the last commit by doing an extra ref.
2363 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2365 * src/widgets/modest-hbox-cell-renderer.c:
2366 (modest_hbox_cell_renderer_append):
2367 * src/widgets/modest-vbox-cell-renderer.c:
2368 (modest_vbox_cell_renderer_append):
2369 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2370 to fix the build with Maemo Bora.
2371 However, there seems to be a remaining crash, probably due to reference
2374 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2376 * src/modest-tny-account.c:
2377 (modest_tny_account_new_for_local_folders):
2378 Use hildon_file_system_info_async_new() to get a better name for
2379 the memory card account, setting it as the account name.
2380 The timing seems to work, but this is probably
2381 not the best place to do this. See the TODO comment.
2382 * src/maemo/modest-main-window.c: (create_details_widget):
2383 * src/widgets/modest-folder-view.c: (text_cell_data):
2384 Use the tny account name instead of hardcoding a name.
2386 2007-05-30 Christian Kellner <ckellner@openismus.com>
2388 * src/modest-search.c: (modest_search):
2389 Correctly set part_search_func even if we have already parsed
2390 the query and thus a valid OgsTextSearcher object.
2392 2007-05-30 Christian Kellner <ckellner@openismus.com>
2395 Search and check for libogs.
2398 Incooparte the ogs build env.
2400 * src/modest-mime-part-search-stream.c:
2401 * src/modest-mime-part-search-stream.h:
2402 Removed since we do the real searching now in modest-search.c.
2404 * src/modest-search.c:
2405 * src/modest-search.h:
2406 Implement support for ogs. We use that if available and requested
2407 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2408 should now handle the corner case when the search term is spread
2409 across multiple reads.
2410 Also the logic in modest_search () was corrected to search all
2411 requested fields until one is found.
2413 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2415 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2417 * src/modest-init.h:
2418 * src/modest-init.c: Made modest_init_local_folders() take a
2419 path and be public so we can iniitialize maildir folders on
2422 * src/modest-local-folder-info.h:
2423 * src/modest-local-folder-info.c:
2424 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2426 * src/modest-tny-account.c:
2427 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2428 still means the standard local-folders path on the local volume.
2430 * src/modest-tny-account-store.c:
2431 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2432 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2433 all accounts when that happens.
2434 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2435 this too, so it shows up in the treeview.
2437 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/modest-maemo-global-settings-dialog.c:
2440 (current_connection):
2441 * src/widgets/modest-global-settings-dialog.c:
2442 (current_connection_default):
2443 Use the enum values instead of 0, 1 and -1,
2444 to make the code clearer.
2446 * src/modest-account-mgr-helpers.c:
2447 (modest_account_mgr_get_connection_specific_smtp): Make this code
2450 * src/modest-runtime.h:
2451 * src/modest-runtime.c:
2452 Added modest_runtime_remove_all_send_queues().
2453 * src/maemo/modest-main-window.c:
2454 (on_account_store_connecting_finished): Recreate the send queues,
2455 using the appropriate transport accounts for this new connection.
2456 Some futher adapting might be needed if the old send queues are not
2457 automatically stopped at this point.
2459 * src/modest-tny-account-store.c: (get_server_accounts):
2460 Create the connection-specific transport accounts, so that they can
2461 be found later by their ID.
2463 * src/modest-tny-account.h:
2464 * src/modest-tny-account.c:
2465 Added modest_tny_account_new_from_server_account_name().
2466 modest_tny_account_new_from_server_account(): Do not create the
2467 send queues here, because they will be
2468 recreated anyway when the connection changes for the first time.
2470 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2472 * src/modest-local-folder-info.h:
2473 * src/modest-local-folder-info.c:
2474 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2475 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2476 tbox_folder): Take a modest account name instead of a server TnyAccount,
2477 so we can have per-modest-account rather than per-transport-account
2479 We must make sure that we change or recreate the exisitng send queues
2480 when the connection changes for connection-specific transport accounts.
2482 * src/modest-tny-account-store.c:
2483 (create_per_account_local_outbox_folders): Create outboxed per modest
2484 account, not per transport account.
2486 * src/modest-tny-account.h:
2487 * src/modest-tny-account.c:
2488 (modest_tny_account_get_special_folder): For outboxes, get the
2489 parent modest account name. The account is ignored for other folders.
2490 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2491 modest account name rather than a server TnyAccount.
2493 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2495 * src/modest-tny-account.c:
2496 (modest_tny_account_new_from_server_account):
2497 Call modest_runtime_get_send_queue() immediately after creating transport
2498 accounts, so that they start trying to send email from the outbox as soon
2499 as possible at startup. This is probably what we want.
2501 * src/modest-mail-operation.c: (update_account_thread):
2502 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2503 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2504 * src/modest-tny-send-queue.h:
2505 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2506 (modest_ui_actions_on_send):
2507 Added comments about how sending works, though it needs some more work.
2509 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2511 * src/modest-tny-account.c:
2512 (modest_tny_account_get_special_folder): Add TODO because this fails when
2513 the network is busy.
2514 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2515 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2516 Do not try to show this window when there is no active account. The UI
2517 specs does not tell us what to do in this case.
2519 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2523 * src/maemo/Makefile.am:
2524 * src/widgets/Makefile.am: Some dist fixes.
2526 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/modest-connection-specific-smtp-window.c:
2529 (on_button_edit): Make the code clearer, to prevent a double free.
2531 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2533 * src/maemo/modest-account-settings-dialog.c:
2534 (modest_account_settings_dialog_set_account_name),
2535 Check the connection-specific smtp servers checkbox if there are any.
2537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2538 (modest_connection_specific_smtp_edit_window_init):
2539 Start with a suitable port number.
2541 * src/modest-account-mgr-helpers.h:
2542 * src/modest-account-mgr-helpers.c: Added
2543 modest_account_mgr_get_has_connection_specific_smtp().
2545 (modest_account_mgr_set_connection_specific_smtp),
2546 (modest_account_mgr_remove_connection_specific_smtp),
2547 (modest_account_mgr_get_has_connection_specific_smtp),
2548 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2549 connection-specific smtp server accounts in the account, rather than
2550 the server account conf dir.
2552 This fixes bug projects.maemo.org bug NB#58263 .
2554 * src/modest-tny-account-store.c:
2555 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2556 if there are no server accounts yet, to prevent an infinite loop when there
2557 are no accounts. Document that one must be called before the other.
2559 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2561 * src/modest-account-mgr-helpers.c:
2562 (modest_account_mgr_get_default_account): Make sure that at least
2563 one account is always the default, if there are any enabled accounts.
2564 This is just a sanity check that shouldn't be necessary.
2566 * src/modest-account-mgr-priv.c:
2567 (_modest_account_mgr_account_from_key): Unescape the conf key to
2568 get the real account name. For instance, this is an issue if a space
2569 was in the account name, which can happen because the account name
2570 is generated from the display name.
2571 (_modest_account_mgr_get_account_keyname): Always escape the
2573 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2574 Unescape the conf keys to get the real account names.
2576 For instance, previously the is-default radio button in the accounts
2577 list was not checked for any accounts at first. This fixes that,
2578 and might fix several similar bugs.
2580 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2582 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2583 Removed some debug printfs.
2585 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2587 Modest on-disk outbox directories are now here, for instance:
2588 $HOME/.modest/outboxes/<account-id-1>/outbox
2589 $HOME/.modest/outboxes/<account-id-2>/outbox
2591 $HOME/.modest/local-folders/outbox
2592 so we can have a separate outbox for each account.
2593 But they are shown as one outbox in the GtkTreeView, by using a
2594 TnyMergeFolder in a ModestTnySimpleFolderStore.
2597 * src/modest-tny-simple-folder-store.c:
2598 * src/modest-tny-simple-folder-store.h:
2599 Added ModestTnySimpleFolderStore, used to contain folders from
2600 other folder stores, such as other accounts.
2602 * src/modest-tny-outbox-account.h:
2603 * src/modest-tny-outbox-account.c:
2604 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2605 used for the per-account local outbox folders.
2607 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2608 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2609 only use this (internally) now for the non-outbox local folders.
2611 * src/modest-init.h:
2612 * src/modest-init.c: Added modest_init_one_local_folder(), for
2613 setting up the directory structure for each local folder.
2615 * src/modest-local-folder-info.c:
2616 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2617 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2619 * src/modest-local-folder-info.h:
2620 * src/modest-tny-account-store.c: (on_account_removed),
2621 (on_account_changed), (create_per_account_local_outbox_folders),
2622 (get_server_accounts), (modest_tny_account_store_get_accounts),
2623 (modest_tny_account_store_get_tny_account_by_account),
2624 (modest_tny_folder_store_is_virtual_local_folders):
2626 * src/modest-tny-account.h:
2627 * src/modest-tny-account.c:
2628 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2629 to create an on-disk per-account local outbox folder for each
2631 (create_per_account_local_outbox_folders): Create a local outbox folder
2632 for each transport account.
2633 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2634 for all local folders.
2636 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2637 instead of using g_object_get/set() directly. It is clearer.
2639 (modest_tny_folder_store_get_message_count),
2640 (modest_tny_folder_store_get_local_size
2641 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2642 because we now use these with non-acount folder stores.
2644 (modest_tny_account_get_special_folder),
2645 (modest_tny_account_new_from_server_account),
2646 (modest_tny_account_new_from_account):
2647 (recurse_folders): Adjust to the new outbox system.
2649 * src/modest-tny-folder.h:
2650 * src/modest-tny-folder.c:
2651 (modest_tny_folder_is_local_folder),
2652 (modest_tny_folder_get_local_folder_type),
2653 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2655 * src/widgets/modest-main-window.h:
2656 * src/maemo/modest-main-window.c: (create_details_widget),
2657 (modest_main_window_set_contents_style): Show details for any folder store,
2660 (modest_tny_folder_get_rules):
2661 Remove the const. C does not support constness enough for this.
2663 * src/modest-ui-actions.c:
2664 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2665 make all outboxes appear as one, in the usual local-folders tree node.
2667 (set_active_account_from_tny_account),
2668 (modest_ui_actions_on_folder_selection_changed):
2669 * src/widgets/modest-folder-view.c: (text_cell_data),
2670 (icon_cell_data), (filter_row),
2671 (add_account_folders_to_merged_folder),
2672 (add_account_folders_to_simple_folder_store), (),
2673 (get_cmp_rows_type_pos), (cmp_rows),
2674 (modest_folder_view_set_account_id_of_visible_server_account):
2675 Adjust to the new outbox system, using generic folder stores and folders
2676 in the GtkTreeModel.
2678 2007-05-23 Christian Kellner <ckellner@openismus.com>
2680 * src/modest-mail-operation.c:
2681 (modest_mail_operation_update_account):
2682 Use info->max_size instead of unintialized local var [small
2683 build fix]. (Added TODO to review that change since I don't
2686 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2688 * libmodest-dbus-client/libmodest-dbus-client.c:
2689 (libmodest_dbus_client_compose_mail): function added
2690 * src/dbus_api/modest-dbus-api.h:
2691 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2692 (on_compose_mail): Implementation of the SendAsMail functionality
2694 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2696 * src/modest-account-mgr.c:
2697 (modest_account_mgr_add_server_account): Set the secure-connection
2698 conf key for transport accounts as well as store accounts. I don't know
2699 why the if was there. For instance, this makes sure that we use SSL
2700 for the gmail preset from the easysetup wizard.
2702 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2704 * src/gnome/modest-main-window.c:
2705 (on_account_store_connecting_finished), (connect_signals):
2706 * src/maemo/modest-main-window.c:
2707 (on_account_store_connecting_finished), (connect_signals),
2708 (modest_main_window_new):
2709 Handle TnyAccountStore::connecting-finished instead of
2710 TnyDevice::connection-changed, because we cannot actually perform
2711 operations on accounts until TnyAccountStore has itself responded to
2712 the TnyDevice::connection-changed signal. This prevents a GError from
2714 Do not try to update at startup, because we (at least on scratchbox)
2715 already do an update at startup when the device goes online.
2716 This prevents a GError from tinymail.
2717 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2718 Added TODO about stopping simultaneous operations.
2720 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2722 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2723 * src/modest-mail-operation-queue.c:
2724 (modest_mail_operation_queue_remove):
2725 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2726 about where they happened.
2728 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2730 * src/modest-ui-actions.c:
2731 (modest_ui_actions_on_password_requested): Make sure that the remember
2732 output parameter is always TRUE.
2734 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2736 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2737 Show a OK/Cancel dialog if the error is a question, though we still do not
2738 know anything more about what we are asking the user.
2739 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2740 Fix an uninitialized variable (helper). This is a logic error, however.
2742 2007-05-21 Christian Kellner <ckellner@openismus.com>
2744 * src/modest-search.h:
2745 Correct bit shifting in the ModestSearchFlags enum.
2747 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2749 * src/modest-tny-account.c:
2750 (modest_tny_account_new_from_server_account): Do not use the lsub and
2751 check-all hard-coded IMAP options when using POP.
2753 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2755 * src/modest-tny-account.c:
2756 (modest_tny_account_new_from_server_account):
2757 Use NULL for the secure-auth method for POP when Password auth has been
2758 specified by the user, as we already do for IMAP. "auth=Login" causes
2759 an error from camel or the server.
2761 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2763 * src/maemo/modest-account-settings-dialog.c:
2764 (create_page_account_details),
2765 (modest_account_settings_dialog_set_account_name):
2766 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2767 for the leave-on-server checkbox, rathr than just the checkbox, when
2768 the protocol is not POP.
2770 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2772 * src/widgets/modest-account-view.c:
2773 * src/widgets/modest-account-view.h:
2774 Added modest_account_view_select_account() which will be useful later
2775 to asynchronously re-select the edited account.
2777 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2779 * src/maemo/modest-account-settings-dialog.c:
2780 (modest_account_settings_dialog_set_account_name):
2781 Automatically choose the port numbers based on the secure authentication
2782 methods, if they have not been chosen before.
2783 This fixes projects.maemo.org bug NB#56273 .
2785 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/modest-main-window-ui.h:
2788 * src/modest-ui-actions.c:
2789 * src/modest-ui-actions.h:
2790 Connect the Tools/SMTP Servers menu item to
2791 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2792 SMTP servers dialog, as in the UI specification and saves changes when it
2793 is closed. This fixed projects.maemo.org bug NB#56305 .
2795 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2797 * src/maemo/modest-connection-specific-smtp-window.c:
2798 (modest_connection_specific_smtp_window_init):
2799 Use gtk_window_set_default_size() to make this window big enough, so
2800 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2802 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2804 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2805 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2806 (modest_connection_specific_smtp_edit_window_init),
2807 Do not try to connect to a combobox signal before the combobox exists.
2808 This fixes the cras in projects.maemo.org bug NB#56288 .
2809 (modest_connection_specific_smtp_edit_window_get_settings):
2810 Remove the server_account_name parameter which was being checked for NULL
2811 though it was not used.
2813 * src/maemo/modest-connection-specific-smtp-window.c:
2814 (modest_connection_specific_smtp_window_fill_with_connections),
2815 (on_button_edit), (modest_connection_specific_smtp_window_init):
2816 Correct the number of treemodel columns to prevent a warning.
2817 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2818 libconic does not work.
2820 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-tny-account.c:
2823 (modest_tny_account_new_from_server_account):
2824 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2825 SMTP when "None" was chosen by the user. However, with my SMTP server that
2826 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2829 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2831 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2832 to explain the memory management issue with the ID in the ModestPair.
2834 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2835 (add_sending_page), (modest_account_assistant_finalize):
2836 * src/gnome/modest-gnome-global-settings-dialog.c:
2837 (create_updating_page), (create_composing_page):
2838 * src/gnome/modest-msg-edit-window.c: (get_transports),
2839 (init_window), (modest_msg_edit_window_finalize),
2840 (modest_msg_edit_window_get_msg_data):
2841 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2842 * src/gnome/modest-transport-widget.c:
2843 (modest_transport_widget_finalize), (smtp_configuration):
2844 * src/maemo/modest-maemo-global-settings-dialog.c:
2845 (create_updating_page), (create_composing_page):
2846 * src/maemo/modest-msg-edit-window.c: (get_transports),
2847 (init_window), (modest_msg_edit_window_finalize),
2848 (modest_msg_edit_window_get_msg_data),
2849 (modest_msg_edit_window_free_msg_data):
2850 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2851 (modest_store_widget_finalize):
2852 * src/maemo/modest-transport-widget.c:
2853 (modest_transport_widget_finalize), (smtp_configuration):
2854 * src/modest-main.c: (send_mail):
2855 * src/widgets/modest-combo-box.h:
2856 * src/widgets/modest-global-settings-dialog-priv.h:
2857 * src/widgets/modest-global-settings-dialog.c:
2858 (modest_global_settings_dialog_finalize):
2859 * src/widgets/modest-msg-edit-window.h:
2860 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2861 as long as the combo box, to prevent use of freed memory for the ID.
2863 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2865 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2866 get_accounts(), to make this clearer. Do not check for the enabled gconf
2867 key, because we do not use this for server accounts (at least, not yet).
2868 This allows us to send email again.
2870 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2872 * src/maemo/modest-platform.c:
2873 (on_modest_conf_update_interval_changed), (modest_platform_init):
2874 Only respond to this particular key change. All these strcmp()s cannot be
2877 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2879 * src/maemo/modest-maemo-global-settings-dialog.c:
2880 (current_connection): Prevent a crash in scratchbox when
2881 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2882 * src/maemo/modest-platform.c:
2883 (on_modest_conf_update_interval_changed), (modest_platform_init):
2884 Get the update interval from gconf and reset it when the gconf key changes.
2886 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2888 * src/modest-protocol-info.c:
2889 * src/modest-protocol-info.h: Adde enum-specific get functions,
2890 instead of using a ModestProtocolType enum parameter.
2892 * src/gnome/modest-account-assistant.c:
2893 * src/gnome/modest-store-widget.c:
2894 * src/gnome/modest-store-widget.h:
2895 * src/gnome/modest-transport-widget.c:
2896 * src/gnome/modest-transport-widget.h:
2897 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2898 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2899 * src/maemo/easysetup/modest-easysetup-wizard.c:
2900 * src/maemo/modest-account-settings-dialog.c:
2901 * src/maemo/modest-account-settings-dialog.h:
2902 * src/maemo/modest-store-widget.c:
2903 * src/maemo/modest-store-widget.h:
2904 * src/maemo/modest-transport-widget.c:
2905 * src/maemo/modest-transport-widget.h:
2906 * src/modest-account-mgr-helpers.c:
2907 * src/modest-account-mgr-helpers.h:
2908 * src/modest-account-mgr.c:
2909 * src/modest-account-mgr.h:
2910 * src/modest-tny-account.c:
2911 * src/modest-tny-folder.c:
2912 * src/widgets/modest-account-view.c:
2913 * src/widgets/modest-retrieve-combo-box.c:
2914 * src/widgets/modest-retrieve-combo-box.h:
2915 * src/widgets/modest-secureauth-combo-box.c:
2916 * src/widgets/modest-serversecurity-combo-box.c:
2917 * src/widgets/modest-serversecurity-combo-box.h:
2918 * tests/check_account-mgr.c:
2919 Use the specific functions, and use the re-renamed enum values for GNOME too.
2921 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2923 * src/modest-pair.h:
2924 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2925 so we can get the second based on the first.
2927 * src/maemo/modest-account-settings-dialog.h:
2928 * src/maemo/modest-account-settings-dialog.c:
2929 Added get_supported_secure_authentication_methods(), though it is mostly
2930 commented-out for now until the necessary API is committed to tinymail.
2931 (modest_account_settings_dialog_set_account_name),
2932 (save_configuration): Request the supported authentication methods from the
2933 server, so we can choose a working method.
2935 * src/modest-tny-account-store.h:
2936 * src/modest-tny-account-store.c:
2937 (modest_tny_account_store_get_session): Rename from
2938 tny_account_store_get_session().
2940 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2942 * src/modest-protocol-info.h: Split the ModestProtocol enum
2943 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2944 There was no need to have these unrelated values in one enum.
2946 * src/: many files: Adapted to changed enum. This makes the code a bit
2947 clearer, and the compiler could catch some errors.
2949 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2951 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2952 Show the detailed internal camel error message when an error happens
2953 during the configuration, so that our testers can give us more clues.
2954 For instance, in projects.maemo.org bug NB#56910 .
2956 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2958 * src/modest-tny-account.c:
2959 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2960 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2962 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2964 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2965 * src/maemo/modest-account-settings-dialog.c:
2966 (modest_account_settings_dialog_set_account_name),
2967 (save_configuration): For the incoming secure authentication checkbox,
2968 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2969 the UI specification. PLAIN does not seem to be supported for most IMAP
2970 servers anyway, and I am not sure what it would mean.
2971 However, we probably need to discover which of the secure-authentication
2972 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2973 * src/modest-account-mgr-helpers.c:
2974 (modest_account_mgr_get_server_account_data):
2976 * src/modest-tny-account.c:
2977 (modest_tny_account_new_from_server_account):
2978 Use tny_account_set_mech() to set secure-authentication methods,
2979 with some special-casing for IMAP, based on my observations of how
2982 * src/modest-account-mgr-helpers.h:
2983 * src/modest-account-mgr.c:
2984 * src/modest-defs.h: Comment that the URI is only used for local folders.
2986 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2988 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2989 parameter const, just to be neat.
2990 * src/modest-text-utils.c: (modest_text_utils_inline):
2991 End g_strconcat() with NULL, as its documentation says. This is almost
2992 certainly the cause of my crash at startup on the device. Interestingly,
2993 valgrind doesn't tell us about these errors.
2995 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2997 * scripts/build-packages: Added more precise comments about how to use
2998 this script, though I still get this error:
2999 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3000 error building tinymail
3002 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3004 * src/maemo/modest-main-window.c: (on_account_update):
3005 Very slight cleanup, hoping to make it simpler to discover what causes
3006 a crash here sometimes.
3008 * src/modest-tny-account.c:
3009 (modest_tny_account_new_from_server_account): Set the port. Added
3010 comments about the options and a TODO comment because I need to find out
3011 how to specify the secure authentication method.
3013 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3015 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3016 changed CFlags paths form modest to libmodest
3018 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3020 * src/modest-account-mgr-helpers.c:
3021 (modest_account_mgr_get_server_account_data),
3022 (modest_account_mgr_free_server_account_data):
3023 * src/modest-account-mgr-helpers.h:
3024 * src/modest-account-mgr.c:
3025 (modest_account_mgr_add_server_account):
3026 * src/modest-defs.h:
3027 * src/modest-tny-account.c:
3028 (modest_tny_account_new_from_server_account):
3029 Determine the options for tny_camel_account_add_option() here,
3030 based on the settings, rather than storing them directly in gconf.
3032 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3034 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3035 Show a more friendly error dialog now that we expect (from the tinymail
3036 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3038 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3040 * src/maemo/modest-main-window.c: (on_account_update): Check that
3041 account_name is not NULL, to prevent a crash at startup that I am
3042 seeing on the N800. I do wonder why it is NULL.
3044 * src/maemo/easysetup/modest-easysetup-wizard.c:
3045 (create_page_user_details):
3046 * src/maemo/modest-account-settings-dialog.c:
3047 (create_page_user_details), (create_page_outgoing):
3048 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3049 (modest_connection_specific_smtp_edit_window_init):
3050 * src/modest-ui-actions.c:
3051 (modest_ui_actions_on_password_requested):
3052 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3053 might do something useful with the on-screen keyboard.
3055 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3057 * src/maemo/modest-main-window.c: (on_account_update):
3058 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3059 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3061 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3063 * src/modest-tny-account-store.c: (on_account_changed):
3064 Correct the signature of this signal handler.
3066 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3068 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3069 Show a HildonNote instead of a GtkDialog for Maemo.
3071 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3073 * src/widgets/modest-account-view.h:
3074 * src/widgets/modest-account-view.c: (on_account_changed),
3075 (on_account_removed). Added a boolean flag, set/unset by
3076 modest_account_view_block_conf_updates(),
3077 modest_account_view_unblock_conf_updates() to prevent unnecessary
3078 updates, but this is not very useful because the gconf notifications are
3079 so delays (maybe only on Maemo Bora).
3080 So auto-updating is turned off, and these functions do an explicit
3081 update when necessary.
3082 However, something else is still doing too much work when adding/removing
3083 accounts, probably in another part of the application.
3085 * src/maemo/modest-account-view-window.c:
3086 (on_delete_button_clicked), (on_edit_button_clicked),
3087 (on_new_button_clicked): Use the new functions.
3089 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3091 * src/modest-account-mgr-helpers.c:
3092 (modest_account_mgr_set_first_account_as_default):
3093 Sort the list of names alphabetically-by-title, so we choose the first one
3095 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3096 alphabetically by the title.
3098 This fixes projects.maemo.org bug NB#56418 .
3100 * src/modest-account-mgr-priv.c:
3101 (_modest_account_mgr_account_from_key):
3102 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3103 avoid a valgrind error, and possible random behaviour.
3105 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3107 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3108 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3109 tinymail documentation to say that this can be expected.
3110 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3111 pretty, and should not happen, but I would prefer to know when it does.
3113 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3115 * configure.ac: When using the older hildon version, probably on Bora,
3116 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3118 * src/widgets/modest-attachment-view.c:
3119 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3122 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3124 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3125 Implemented the prototype. Can be tested with
3126 tests/dbus_api/test_open_message:
3128 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3130 * src/modest-tny-account-store.c:
3131 (modest_tny_account_store_instance_init), (get_password):
3132 * src/modest-ui-actions.c:
3133 (modest_ui_actions_on_password_requested):
3134 Do not store the password in gconf, because this function is called
3135 for non-remembered passwords. Actually use the cached (in the hash map)
3136 password instead of releasing it.
3137 The password will now not be remembered if it is asked via the protected
3138 password dialog, as per the UI spec.
3140 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3142 * src/modest-defs.h:
3143 * src/modest-account-mgr-helpers.h:
3144 * src/modest-account-mgr-helpers.c:
3145 Added modest_server_account_get_username_has_succeeded(),
3146 modest_server_account_set_username_has_succeeded().
3147 (modest_server_account_set_username),
3148 Reset the has-succeeded flag if the username changes.
3150 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3151 * src/maemo/modest-connection-specific-smtp-window.c:
3152 (modest_connection_specific_smtp_window_save_server_accounts):
3153 Use modest_server_account_set_username() instead of using
3154 modest_conf_set_string() directly, so that the has-succeeded flag is always
3157 * src/modest-ui-actions.c:
3158 (modest_ui_actions_on_password_requested): Dim the username entry if
3159 the username has ever worked, as per the UI spec.
3161 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3163 * src/modest-tny-account-store.c: (get_password):
3164 * src/modest-ui-actions.c:
3165 (modest_ui_actions_on_password_requested):
3166 Allow the username to be changed too, though there is more work to
3167 be done on exactly how this behaves.
3169 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3171 * src/modest-account-mgr-helpers.h:
3172 * src/modest-account-mgr-helpers.c:
3173 Added modest_account_mgr_get_display_name(),
3174 modest_server_account_get_username(),
3175 modest_server_account_set_username(),
3176 modest_server_account_set_password(),
3177 modest_server_account_get_hostname() functions so we do not need to
3178 use the conf API directly.
3180 * src/maemo/modest-main-window.c: (connect_signals):
3181 Actually connect ot the ModestAccountStore::request-password signal,
3182 so that we show the dialog when the password is requested by Tinymail,
3183 for isntance if it is empty.
3185 * src/modest-marshal.list:
3186 * src/modest-tny-account-store.c:
3187 (modest_tny_account_store_class_init), (get_password),
3188 (modest_tny_account_store_alert):
3189 * src/modest-tny-account-store.h:
3190 * src/modest-ui-actions.h:
3191 * src/modest-ui-actions.c:
3192 (modest_ui_actions_on_password_requested):
3193 Change the signal parameters, so it is obvious that we are providing
3194 the non human-readable server name, and receiving both the username
3195 and password, though changing of the username is not yet implemented.
3196 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3197 for the GNOME version.
3199 This should fix the projects.maemo.org bug NB#56209, though it does not
3200 work on Bora, because the gconf_client_get() for the password fails
3201 immediately after we save it with gconf_client_set().
3203 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3206 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3207 caused an undefined symbol error:
3208 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3210 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3212 * src/modest-tny-account-store.c:
3213 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3214 using a GError instead of a string message, so we can translate it in
3217 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3219 * src/maemo/modest-address-book.c:
3220 (modest_address_book_check_names):
3221 * src/maemo/modest-msg-view-window.c:
3222 (modest_msg_view_window_clipboard_owner_change):
3223 * src/modest-init.c: (modest_init_init_ui):
3224 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3225 (update_folders_cb), (modest_mail_operation_update_account):
3226 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3227 (modest_ui_actions_on_msg_attachment_clicked),
3228 (modest_ui_actions_on_msg_recpt_activated):
3229 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3230 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3231 (modest_msg_view_search_next):
3232 * src/widgets/modest-recpt-editor.c:
3233 (modest_recpt_editor_on_button_release_event),
3234 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3235 g_message(). At this point we should only be seeing interesting errors on
3236 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3238 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3240 (modest_wizard_dialog_force_title_update):
3241 * src/maemo/easysetup/modest-wizard-dialog.h:
3242 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3243 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3244 can update the title when appropriate. Otherwise the title is wrong if the
3245 pages are added after adding the notebook to the dialog.
3246 This must be a problem in HildonWizardDialog too.
3247 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3249 * src/maemo/easysetup/modest-easysetup-wizard.c:
3250 (create_subsequent_customsetup_pages),
3251 (create_subsequent_easysetup_pages):
3252 Call modest_wizard_dialog_force_title_update() so that the title is
3253 correct even with GTK+ < 2.10.
3254 This fixes projects.maemo.org bug NB#56145 .
3256 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/modest-platform.c:
3259 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3260 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3263 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3265 * src/widgets/modest-window.h:
3266 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3267 and modest_window_save_state(), which invokes it.
3269 * src/widgets/modest-window-mgr.h:
3270 * src/widgets/modest-window-mgr.c:
3271 Added modest_window_mgr_save_state_for_all_windows(), which calls
3272 the save_state vfunc on all registered windows, if implemented.
3274 * src/gnome/modest-msg-edit-window.c:
3275 * src/gnome/modest-msg-view-window.c:
3276 * src/maemo/modest-msg-edit-window.c:
3277 * src/maemo/modest-msg-view-window.c:
3278 * src/maemo/modest-main-window.c:
3279 Specify the existing save_settings functions as implementations of
3280 ModestWindow::save_state_func().
3282 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3283 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3284 enabling hibernation, for instance.
3286 We may need to do the same thing for restoring settings.
3289 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3291 * src/widgets/modest-window-mgr.c:
3292 * src/widgets/modest-window-mgr.h:
3293 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3294 modest_window_mgr_get_hibernation_is_prevented().
3296 * src/maemo/modest-main-window.c:
3297 (on_hildon_program_is_topmost_notify): Prevent hibernation
3298 (possible when the application goes to the background in the WM),
3299 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3301 * src/maemo/easysetup/modest-easysetup-wizard.c:
3302 (modest_easysetup_wizard_dialog_init):
3303 * src/maemo/modest-account-settings-dialog.c:
3304 (modest_account_settings_dialog_init):
3305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3306 (modest_connection_specific_smtp_edit_window_init):
3307 * src/maemo/modest-connection-specific-smtp-window.c:
3308 (modest_connection_specific_smtp_window_init):
3309 * src/maemo/modest-signature-editor-dialog.c:
3310 (modest_signature_editor_dialog_init):
3311 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3312 prevent hibernation while any of these account settings dialogs are open.
3314 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3316 * src/maemo/Makefile.am:
3317 * src/maemo/modest-osso-state-saving.c:
3318 * src/maemo/modest-osso-state-saving.h: Added
3319 modest_osso_load_state() and modest_osso_save_state() though they do
3320 nothing now. They should iterate through all the open windows and load/save
3322 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3323 save state when closing.
3325 * src/maemo/modest-main-window.c:
3326 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3327 Add a notification handler for the HildonProgram::is-topmost property,
3328 so we can allow hibernation when the application goes into the background.
3329 But we still need to detect when the accounts setup windows are open so
3330 we can stop hibernation when they are open.
3331 To do this, I also added the main window the HildonProgram. This might have
3332 other side-effects/benefits, and should maybe be done for other windows.
3334 * src/maemo/modest-osso-autosave-callbacks.h:
3335 * src/maemo/modest-osso-autosave-callbacks.c:
3336 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3337 though it does not do anything yet, and we might never need this to do
3338 anything. For instance, we already save drafts.
3340 * src/maemo/modest-platform.c: (modest_platform_init):
3341 Specify the libosso auto-save callback.
3343 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3345 * src/maemo/modest-platform.c:
3346 (modest_platform_set_update_interval):
3347 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3348 aparently stays valid between application instances, so we can use this
3349 to remove and reset it later. According to a maemo-developers email from
3352 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3354 * configure.ac: Depend on libalarm for Maemo.
3356 * src/dbus_api/modest-dbus-api.h:
3357 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3358 (on_send_receive), (modest_dbus_req_handler):
3359 Handle a SEND_RECEIVE D-Bus method.
3361 * libmodest-dbus-client/libmodest-dbus-client.c:
3362 (libmodest_dbus_client_send_and_receive):
3363 * libmodest-dbus-client/libmodest-dbus-client.h:
3364 Add C convenience functions for calling the new D-Bus method.
3366 * src/modest-platform.h:
3367 * src/gnome/modest-platform.c:
3368 * src/maemo/modest-platform.c:
3369 Added modest_platform_set_update_interval(), which uses the
3370 alarmd API on Maemo.
3371 (modest_platform_init),
3372 Call modest_platform_set_update_interval(), using a hard-coded
3373 interval for now (until the global settings dialog is implemented),
3374 though I am not sure that this makes sense yet.
3376 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3378 * src/dbus_api/modest-dbus-callbacks.c:
3379 (modest_osso_cb_hw_state_handler):
3380 * src/dbus_api/modest-dbus-callbacks.h:
3381 * src/maemo/modest-platform.c: (modest_platform_init):
3382 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3383 in case this has some effect on the ability for Maemo to ping the
3386 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3388 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3389 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3390 warning. It is probably a logic error, but I need to fix the build.
3392 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3394 * src/modest-account-mgr.h:
3395 * src/modest-account-mgr.c:
3396 (modest_account_mgr_account_names): Add a gboolean enabled_only
3397 parameter, so we can get lists of onlt the enabled accounts.
3399 (modest_account_mgr_add_account),,
3400 (modest_account_mgr_account_with_display_name_exists):
3401 * src/maemo/modest-msg-edit-window.c: (get_transports):
3402 * src/modest-account-mgr-helpers.c:
3403 (modest_account_mgr_set_first_account_as_default):
3404 * src/modest-init.c: (init_default_account_maybe):
3405 * src/modest-tny-account-store.c: (get_accounts):
3406 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3407 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3408 * tests/check_account-mgr.c: (START_TEST):
3409 Provide the extra parameter, as appropriate.
3411 * src/widgets/modest-account-view.c: (update_account_view):
3412 Do not show disabled accounts (meaning that there is no way to
3413 enable/disable accounts in the UI (the feature is not in our UI
3414 specification), so we can use this internally only to mark unfinished
3415 or temporary account data.
3417 * src/maemo/easysetup/modest-easysetup-wizard.c:
3418 (create_account): Add boolean enable parameter, so we can specify FALSE
3419 to create the temporary account.
3420 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3421 (on_before_next): When finishing, when there is a temporary account, just
3423 Also, use a timeout to delay the showing of the dialog until gconf is likely
3424 to return correct information, due to a maemo gconf bug that is fixed in
3425 osso 1.1, but not yet in Bora.
3426 However, the dialog stays on screen after it is destroyed.
3428 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3429 for invalid data when cancelling. Use a hildon note instead of a dialog
3430 to complain about invalid data. Do not show the account-saved note if the
3431 account is disabled (a temporary account that will not really be saved for use
3434 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3436 * src/modest-account-mgr-helpers.h:
3437 * src/modest-account-mgr-helpers.c:
3438 Added modest_account_mgr_unset_default_account(),
3439 Added modest_account_mgr_set_first_account_as_default().
3441 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3442 If it was the default account, unset the default account name.
3444 * src/maemo/modest-account-view-window.c:
3445 (on_delete_button_clicked): If it was the default account,
3446 set the first remaining account as the default instead.
3448 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3449 a NULL account or a NULL default account, to prevent a crash. This should
3450 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3453 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3455 * src/widgets/modest-recpt-editor.c:
3456 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3457 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3458 TODO comment for this. This fixes the build.
3460 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3461 be the best place for it. This will in future update all auto-update accounts,
3462 rather than just the current/default account, when that gconf key exists.
3463 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3464 if there are no accounts, before calling do_send_receive().
3465 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3467 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3468 * src/maemo/modest-main-window-ui.h:
3469 * src/maemo/modest-main-window.c: (on_connection_changed),
3470 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3471 directly, becaue the signal handler does more.
3473 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3475 * src/modest-account-mgr-helpers.c:
3476 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3477 for the case that the account does not exist.
3479 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3480 (equivalent to the modest account name) rather than the tinymail account name
3481 (equivalent to the modest account title - human readable) to get the account data.
3482 Check for null account data to prevent the crash, and add a TODO comment saying that
3483 this needs fixing because it is using the server account name instead of the account name.
3485 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3488 * src/maemo/modest-account-settings-dialog.c: (show_error),
3490 Use hildon_note_new_information() for informative and error messages,
3491 which seems to be expected for Maemo applications (no documentation that I know of
3492 says this). I am surprised that there is no distinction between info and error
3495 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3497 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3498 it is easy to find where this is used.
3500 * src/maemo/easysetup/modest-easysetup-wizard.c:
3501 (create_page_welcome), (create_page_account_details),
3502 (create_page_user_details), (create_page_complete_easysetup),
3503 (create_page_custom_incoming), (create_page_custom_outgoing),
3504 (create_page_complete_custom):
3505 * src/maemo/modest-account-settings-dialog.c:
3506 (create_page_account_details), (create_page_user_details),
3507 (create_page_incoming), (create_page_outgoing):
3508 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3509 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3510 (modest_connection_specific_smtp_edit_window_init):
3511 * src/maemo/modest-connection-specific-smtp-window.c:
3512 (modest_connection_specific_smtp_window_init):
3513 * src/maemo/modest-signature-editor-dialog.c:
3514 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3515 and scrolling policy as per the Email Application Layout Guide, if I have
3518 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3520 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3521 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3522 which were empty, because these vfuncs have been removed from TnyAccountStore.
3523 This fixes the build.
3525 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3527 * src/maemo/modest-main-window.c:
3528 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3529 showing/hiding it. Added TODO because it probably should not be NULL.
3530 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3531 because unnecessary g_warnings() make degugging difficult.
3533 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3535 * src/maemo/modest-msg-edit-window.c:
3536 (modest_msg_edit_window_select_color),
3537 (modest_msg_edit_window_select_background_color): 2 const corrections and
3538 moving 2 #endifs before closing brackets, to fix the build.
3540 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3542 * src/maemo/easysetup/modest-easysetup-wizard.h:
3543 * src/maemo/easysetup/modest-easysetup-wizard.c:
3544 (modest_easysetup_wizard_dialog_finalize),
3545 (on_button_edit_advanced_settings), (create_page_complete_custom),
3546 (on_response), (create_account):
3547 Implement the Advanced Settings edit button, by saving the account information,
3548 for the Advanded Settings dialog to use directly from gconf, and removing it
3549 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3550 Bug #5533 in the projects.maemo.org bugzilla.
3552 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3554 * src/maemo/modest-msg-view-window.c:
3555 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3556 when opening a message window.
3558 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3560 * src/maemo/easysetup/modest-easysetup-wizard.c:
3561 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3564 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3565 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3566 gconf settings. I probably added more checks than necessary, but that is safer.
3568 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3569 variable to fix the build, but this seems to be used when it is still NULL.
3571 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3573 * src/modest-platform.h:
3574 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3575 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3576 * src/modest-main.c: Implement this function so we can avoid using
3577 maemo-specific API from cross-platform code.
3579 * src/modest-tny-account-store.c:
3580 (get_smtp_specific_transport_account_for_open_connection):
3581 * src/modest-ui-actions.c: (check_for_connection),
3582 (modest_ui_actions_on_item_not_found):
3583 Use modest_platform_connect_and_wait() and put #idefs around other
3584 maemo-specific code, because only maemo currently has a way to
3585 identify connection names.
3587 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3589 * src/modest-tny-account-store.h:
3590 * src/modest-tny-account-store.c:
3591 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3592 the connection-specific SMTP server settings in the configuration.
3594 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3596 * src/maemo/modest-main-window.c: (on_connection_changed),
3598 * src/modest-main.c: (main), (start_ui), (send_mail):
3599 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3600 that is what is intended.
3602 * src/modest-ui-actions.c: (action_send), (action_receive),
3603 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3604 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3605 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3606 SMTP server is used when it is specified.
3608 (modest_ui_actions_on_send_receive):
3609 Check that a connection is open before proceeding.
3610 Receive and then send, instead of vice-versa, as per the specification.
3612 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3614 * src/modest-mail-operation.c:
3615 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3616 though I guess it should be something other than NULL.
3618 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3620 * src/maemo/easysetup/modest-easysetup-wizard.c:
3621 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3622 combo twice, to avoid an g_warning and to make it visible again.
3623 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3624 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3625 (already intended) dereference when detaching, because we then recreate the menu.
3626 But I am not sure why the warning was happening, and it is possible that this is a memory
3629 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3631 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3632 and uri_parse_mailto() utility functions.
3633 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3635 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3637 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3639 * src/dbus_api/modest-dbus-api.h:
3640 * src/dbus_api/modest-dbus-callbacks.c:
3641 Use an idle callback to execute the modest code in the application's own thread.
3642 Remove the helloworld example method.
3643 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3644 parsed, and the open-message method is not implemented because this is not yet implemented in
3646 * libmodest-dbus-client/libmodest-dbus-client.c:
3647 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3648 (libmodest_dbus_client_open_message):
3649 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3651 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3652 body without crashing.
3654 * tests/dbus_api/Makefile.am:
3655 * tests/dbus_api/test_mail_to.c:
3656 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3658 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3660 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3661 Added file to fix the build. Sorry.
3663 * src/dbus_api/Makefile.am:
3664 * src/dbus_api/modest-dbus-api.h:
3665 * src/dbus_api/modest-dbus-callbacks.h:
3666 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3667 (modest_dbus_req_handler):
3668 Put constants in a separate header so it can be reused by the
3669 client library, without duplication
3671 * libmodest-dbus-client/Makefile.am:
3672 * libmodest-dbus-client/libmodest-dbus-client.c:
3673 (libmodest_dbus_client_call_helloworld),
3674 (libmodfest_dbus_client_send_mail),
3675 (libmodfest_dbus_client_mailto),
3676 (libmodfest_dbus_client_open_message):
3677 * libmodest-dbus-client/libmodest-dbus-client.h:
3678 (Partly) Implement a send_mail D-Bus method.
3680 * tests/dbus_api/Makefile.am:
3681 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3682 the send_email D-Bus method.
3684 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3688 * libmodest-dbus-client/Makefile.am:
3689 * libmodest-dbus-client/libmodest-dbus-client.c:
3690 * libmodest-dbus-client/libmodest-dbus-client.h:
3691 * tests/dbus_api/Makefile.am:
3692 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3693 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3695 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3697 * src/maemo/easysetup/modest-easysetup-wizard.c:
3698 (create_page_account_details):
3699 * src/maemo/modest-account-settings-dialog.c:
3700 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3701 widgets, because this might not be the default in future versions of the Maemo GTK+.
3702 However, I can not not get capitalization to work even in a simple test case.
3704 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3706 * src/maemo/easysetup/modest-easysetup-wizard.c:
3707 (create_page_custom_incoming), (create_page_custom_outgoing):
3708 * src/maemo/modest-account-settings-dialog.c:
3709 (create_page_account_details), (create_page_incoming),
3710 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3711 instead of using gtk_check_button_with_label(), so they are aligned like the other
3712 widgets, as per the UI spec.
3714 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3716 * src/maemo/easysetup/modest-easysetup-wizard.c:
3717 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3718 * src/widgets/modest-validating-entry.c:
3719 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3720 Modest prefix instead of an EasySetup prefix.
3722 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3724 * src/widgets/modest-validating-entry.h:
3725 * src/widgets/modest-validating-entry.c: (on_insert_text),
3726 Added easysetup_validating_entry_set_max_func(), used to set a callback
3727 to call when the max number of characters is reached. GtkEntry has a max-length
3728 already but is silent about it.
3730 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3731 (create_page_account_details), (create_page_user_details),
3733 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3734 (create_page_account_details), (create_page_user_details),
3735 (create_page_outgoing):
3736 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3737 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3738 the UI spec, when the user tries to enter more than the max number of characters.
3740 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3742 * src/maemo/easysetup/modest-easysetup-wizard.c:
3743 (create_page_user_details), (create_page_custom_incoming),
3744 (create_page_custom_outgoing):
3745 * src/maemo/modest-account-settings-dialog.c:
3746 (create_page_user_details), (create_page_incoming),
3747 (create_page_outgoing):
3748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3749 (modest_connection_specific_smtp_edit_window_init):
3750 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3751 not appropriate. Bad Maemo-specific defaults!.
3753 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3755 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3756 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3757 (modest_signature_editor_dialog_set_settings):
3758 Disable the label and textview when the checkbox is disabled, and use the
3759 specified (UI spec) default signature text.
3761 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3763 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3764 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3766 * src/modest-defs.h:
3767 * src/modest-account-mgr-helpers.h:
3768 * src/modest-account-mgr-helpers.c:
3769 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3771 * src/maemo/Makefile.am:
3772 * src/maemo/modest-signature-editor-dialog.c:
3773 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3776 * src/maemo/modest-account-settings-dialog.h:
3777 * src/maemo/modest-account-settings-dialog.c:
3778 (modest_account_settings_dialog_finalize), (on_button_signature),
3779 (save_configuration): Use the new dialog when the Edit button is pressed, and
3780 save the changes if necessary, as per the UI spec.
3782 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3784 * src/maemo/Makefile.am:
3785 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3786 based on maemo-develoers email from Dirk.
3788 * src/maemo/easysetup/modest-easysetup-wizard.c:
3789 (create_page_welcome), (create_page_account_details),
3790 (create_page_user_details), (create_page_complete_easysetup),
3791 (create_page_custom_incoming), (create_page_custom_outgoing),
3792 (create_page_complete_custom),
3793 (modest_easysetup_wizard_dialog_init):
3794 * src/maemo/modest-account-settings-dialog.c:
3795 (create_page_account_details), (create_page_user_details),
3796 (create_page_incoming), (create_page_outgoing),
3797 (modest_account_settings_dialog_init):
3798 * src/maemo/modest-connection-specific-smtp-window.c:
3799 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3801 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3803 * src/maemo/easysetup/modest-easysetup-wizard.c:
3804 (create_page_account_details), (create_page_custom_outgoing),
3805 (create_page_complete_custom):
3806 * src/maemo/modest-account-settings-dialog.c:
3807 (create_page_user_details), (create_page_incoming),
3808 (create_page_outgoing):
3809 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3810 (modest_connection_specific_smtp_edit_window_init):
3811 Use the correct (UI spec) port min/max, and use horizontal separators,
3814 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3816 * src/maemo/easysetup/modest-easysetup-wizard.c:
3817 (set_default_custom_servernames):
3818 * src/maemo/modest-account-settings-dialog.c:
3819 (create_page_incoming), (on_combo_outgoing_security_changed),
3820 (on_combo_incoming_security_changed), (create_page_outgoing),
3821 (modest_account_settings_dialog_set_account_name),
3822 (save_configuration):
3823 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3824 (on_combo_security_changed),
3825 (modest_connection_specific_smtp_edit_window_init),
3826 (modest_connection_specific_smtp_edit_window_set_connection),
3827 (modest_connection_specific_smtp_edit_window_get_settings):
3828 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3831 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3834 * src/maemo/easysetup/modest-easysetup-wizard.c:
3835 (create_page_custom_outgoing), (create_page_complete_custom):
3836 * src/maemo/modest-account-settings-dialog.c:
3837 (create_page_user_details), (create_page_outgoing):
3838 * src/maemo/modest-account-view-window.c: (button_box_new):
3839 Use changed logical IDs as per the most recent UI spec:
3840 mcen_bd_emailsetup_edit -> mcen_bd_edit
3841 mcen_bd_emailsetup_delete -> mcen_bd_delete
3842 mcen_bd_emailsetup_close -> mcen_bd_close
3844 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3848 * src/dbus_api/Makefile.am:
3849 * src/dbus_api/modest-dbus-callbacks.c:
3850 * src/dbus_api/modest-dbus-callbacks.h:
3851 * src/maemo/modest-platform.c: (modest_platform_init):
3852 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3854 * tests/Makefile.am:
3855 * tests/dbus_api/Makefile.am:
3856 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3858 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3860 * src/maemo/modest-account-settings-dialog.c:
3861 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3862 Removed unnecessary includes.
3864 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3866 * src/maemo/easysetup/modest-easysetup-wizard.c:
3867 * src/maemo/modest-account-settings-dialog.c:
3868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3869 * src/widgets/Makefile.am:
3870 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3871 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3872 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3873 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3874 * src/widgets/modest-secureauth-combo-box.c:
3875 * src/widgets/modest-secureauth-combo-box.h:
3876 * src/widgets/modest-serversecurity-combo-box.c:
3877 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3878 made the GObject names more consistent with the rest of the Modest code.
3880 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3882 * src/maemo/easysetup/Makefile.am:
3883 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3884 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3885 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3886 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3887 * src/maemo/easysetup/modest-easysetup-wizard.c:
3888 * src/maemo/easysetup/modest-validating-entry.c:
3889 * src/maemo/easysetup/modest-validating-entry.h:
3890 * src/maemo/modest-account-settings-dialog.c:
3891 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3892 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3893 widgets/ because they are used outside of easysetup too. After checking in,
3894 svn will allow me to rename them too.
3896 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3898 * src/gnome/modest-msg-edit-window.c:
3899 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3900 linker error, to fix the build on the GNOME platform.
3901 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3902 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3903 ifdefed out to avoid a warning.
3905 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3907 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3908 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3909 some alternative for GTK+ 2.6.
3911 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3913 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3915 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3916 specified for EmailAccountsDialog in UI spec.
3918 * src/maemo/easysetup/modest-easysetup-wizard.c:
3919 * src/maemo/easysetup/modest-easysetup-wizard.h:
3920 * src/maemo/modest-account-settings-dialog.c:
3921 * src/maemo/modest-account-settings-dialog.h:
3922 Reuse a member window widget for the connection-specific SMTP server accounts,
3923 so we can tell it to create/save the accounts only if we actually save changes.
3925 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3926 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3927 (modest_connection_specific_smtp_edit_window_get_settings):
3928 Return a struct instance for temporarily remembering the entered data.
3930 * src/maemo/modest-connection-specific-smtp-window.h:
3931 * src/maemo/modest-connection-specific-smtp-window.c:
3932 (modest_connection_specific_smtp_window_finalize),
3933 (modest_connection_specific_smtp_window_fill_with_connections),
3935 (modest_connection_specific_smtp_window_save_server_accounts),
3936 (update_model_server_names): Do not actually save data until asked,
3937 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3939 (on_selection_changed),
3940 (modest_connection_specific_smtp_window_init): Disable the edit
3941 button when nothing is selected.
3943 * src/modest-account-mgr-helpers.c:
3944 * src/modest-account-mgr-helpers.h:
3945 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3948 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3950 * src/modest-account-mgr-helpers.h:
3951 * src/modest-account-mgr-helpers.c:
3952 (modest_account_mgr_get_unused_account_name),
3953 (modest_account_mgr_get_unused_account_display_name): Added these
3954 utility functions, to avoid code duplication.
3956 * src/maemo/easysetup/modest-easysetup-wizard.c:
3957 (create_page_account_details), (create_account):
3958 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3959 (on_combo_security_changed),
3960 (modest_connection_specific_smtp_edit_window_init),
3961 (modest_connection_specific_smtp_edit_window_save_settings):
3962 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3963 * src/maemo/modest-connection-specific-smtp-window.c:
3964 (modest_connection_specific_smtp_window_finalize),
3965 (modest_connection_specific_smtp_window_fill_with_connections),
3966 (on_button_edit), (modest_connection_specific_smtp_window_init):
3967 * src/maemo/modest-connection-specific-smtp-window.h:
3968 Implementing saving of connection-specific server accounts.
3970 But I need to refactor this so we can save the data for each
3971 possible connection-specific account and only actually create the server accounts
3972 when the easysetup finished, or the OK button is pressed on the account settings
3975 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3977 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3978 (on_combo_security_changed):
3979 (modest_connection_specific_smtp_edit_window_init):
3980 Auto-fill the port number as in the account settings.
3982 (modest_connection_specific_smtp_edit_window_set_connection):
3983 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3984 * src/maemo/modest-connection-specific-smtp-window.c:
3985 (fill_with_connections), (on_button_edit),
3986 (modest_connection_specific_smtp_window_init):
3987 Turn the edit window into a dialog to simplify the code, and
3988 set a WM hint as in a GtkDialog, because only a popup can be on top of
3989 another window in Maemo, and popups usually have no WM decoration.
3991 * src/modest-defs.h:
3992 * src/modest-account-mgr-helpers.c:
3993 (modest_account_mgr_set_connection_specific_smtp),
3994 (modest_account_mgr_remove_connection_specific_smtp),
3995 (modest_account_mgr_get_connection_specific_smtp):
3996 * src/modest-account-mgr-helpers.h: Some functions to write the
3997 connection-specific SMTP server information. Not yet used.
4000 * src/widgets/modest-folder-view.c: (text_cell_data):
4001 Fix a warning about an uninitialized variable.
4002 (on_configuration_key_changed): Put an #ifdef around the use
4003 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4005 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4007 * src/maemo/modest-account-settings-dialog.h:
4008 * src/maemo/modest-account-settings-dialog.c:
4009 Added connect_for_modified() utility function to mark the new modified boolean.
4011 (create_page_account_details), (create_page_user_details),
4012 (create_page_incoming), (create_page_outgoing), (on_response),
4013 (modest_account_settings_dialog_init),
4014 (modest_account_settings_dialog_set_account_name):
4015 Only warn about unsaved changes when there are actually unsaved changes.
4017 * src/modest-account-mgr-helpers.c:
4018 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4019 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4020 to get the data from there in future.
4022 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4024 * src/modest-defs.h:
4026 * src/modest-account-mgr-helpers.h:
4027 * src/modest-account-mgr-helpers.c:
4028 Store the security account setting in a single conf key instead of using
4029 the options list, so that the list is left for just the to-be-removed camel hack,
4030 and because gconf_client_set_list() is failing for some reason.
4032 * src/modest-account-mgr.c:
4033 (modest_account_mgr_add_server_account):
4034 * src/maemo/modest-account-settings-dialog.c:
4035 (modest_account_settings_dialog_set_account_name),
4036 (save_configuration): Use the renamed functions.
4039 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4041 * src/widgets/Makefile.am:
4042 * src/widgets/modest-limit-retrieve-combo-box.c:
4043 * src/widgets/modest-limit-retrieve-combo-box.h:
4044 * src/widgets/modest-retrieve-combo-box.c:
4045 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4046 the account settings dialog.
4048 * src/modest-defs.h:
4049 * src/modest-account-mgr-helpers.h:
4050 * src/modest-account-mgr-helpers.c:
4051 (modest_server_account_get_option_secure_auth),
4052 (modest_server_account_set_option_secure_auth):
4053 * src/modest-account-mgr.c:
4054 (modest_account_mgr_add_server_account):
4055 Use the existing AUTH_MECH conf key for the secure-auth setting,
4056 instead of putting it in the list options, because this was actually used already.
4058 * src/maemo/modest-account-settings-dialog.c:
4059 (create_page_account_details),
4060 (modest_account_settings_dialog_set_account_name),
4061 (save_configuration):
4062 * src/maemo/modest-account-settings-dialog.h:
4063 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4064 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4066 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4068 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4069 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4070 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4072 * src/modest-defs.h:
4073 * src/maemo/modest-account-settings-dialog.c:
4074 (create_page_incoming), (on_combo_outgoing_security_changed),
4075 (on_combo_incoming_security_changed), (create_page_outgoing),
4076 (modest_account_settings_dialog_set_account_name),
4077 (save_configuration): Load/Save the port number, and change it when the
4078 security combo changes, to suitable defaults.
4080 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4082 * src/modest-account-mgr.c:
4083 (modest_account_mgr_add_server_account): Set the security and secure-auth
4084 options, and add a comment saying that the other camel-specific options should be
4087 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4089 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4091 * src/modest-tny-account-store.c: (account_list_free),
4092 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4093 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4096 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4098 * src/modest-protocol-info.c:
4099 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4100 is required by our UI spec. Maybe something in our implementation will use this eventually.
4101 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4102 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4103 instead of the previous 0 placeholder.
4105 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4106 secure-auth settings.
4107 * src/modest-account-mgr-helpers.h:
4108 * src/modest-account-mgr-helpers.c:
4109 (modest_server_account_data_get_option_secure_auth),
4110 (modest_server_account_set_option_secure_auth),
4111 (modest_server_account_data_get_option_security),
4112 (modest_server_account_set_option_security): Added this API for getting and setting the security
4113 and secure-auth settings.
4115 * src/maemo/modest-account-settings-dialog.h:
4116 * src/maemo/modest-account-settings-dialog.c:
4117 (modest_account_settings_dialog_finalize), (check_data),
4118 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4119 about changing titles.
4120 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4121 (save_configuration): Save the security and secure-auth settings.
4123 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4124 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4126 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4128 * src/modest-defs.h:
4129 * src/modest-account-mgr.c:
4130 (modest_account_mgr_add_server_account):
4131 Added and used defines for the options key and value pair strings,
4132 that are used so far, though they do not seem to correspond to anything in our
4133 UI specs or ModestProtocol enum.
4135 * src/modest-account-mgr-helpers.h:
4136 * src/modest-account-mgr-helpers.c:
4137 (compare_option_strings_for_name),
4138 (modest_server_account_data_get_option_value),
4139 (modest_server_account_data_get_option_bool),
4140 (modest_account_mgr_get_server_account_option):
4141 Added helper functions for parsing the options GSList.
4143 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4145 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4146 display name is based on the supplied account name.
4147 * src/modest-account-mgr.c:
4148 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4149 with an inefficient, but good-enough, implementation.
4151 * src/maemo/easysetup/modest-easysetup-wizard.c:
4152 (create_page_account_details), (on_before_next), (create_account):
4153 Check for existing display names rather than (non-user-visible) account names, and just
4154 create and set a unique account name at the end.
4156 * src/maemo/modest-account-settings-dialog.c:
4157 (modest_account_settings_dialog_init),
4158 (modest_account_settings_dialog_set_account_name),
4159 (create_page_incoming): Show the display name, instead of the account name.
4160 (on_response): Do some (not all) extra checks, as in the UI spec.
4161 (save_configuration): Save the display name if it was changed.
4163 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4165 * po/en_GB.po: Added needed logical ID and translation.
4166 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4167 (init_view): Made the is-default column clicking work.
4169 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4172 * src/maemo/easysetup/Makefile.am:
4173 * src/maemo/easysetup/modest-easysetup-wizard.c:
4174 (modest_easysetup_wizard_dialog_init):
4175 * src/maemo/easysetup/provider-data-test.keyfile:
4176 * src/maemo/easysetup/provider-data.keyfile:
4177 Moved the provider data file to the new modest-providers-data package and used it from there.
4179 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4181 * src/modest-local-folder-info.c:
4182 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4183 N_() was already used on the static strings, but this just marks it for translation without
4184 using the translation.
4186 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/modest-account-settings-dialog.c:
4189 (create_page_incoming),
4190 (modest_account_settings_dialog_set_account_name):
4191 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4192 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4193 I will do this if nobody else gets there first.
4195 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4197 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4198 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4199 save the security stuff.
4201 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4203 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4204 Set the email address and user fullname, which I now see must be
4207 * src/maemo/modest-account-settings-dialog.h:
4208 * src/maemo/modest-account-settings-dialog.c:
4210 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4211 leave-on-server and authentication.
4212 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4215 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4218 * src/maemo/modest-account-settings-dialog.c:
4219 * src/maemo/modest-account-settings-dialog.h:
4220 Most (but not all) of the widgets are now present as specified by the UI spec.
4221 No changes are yet saved, and some details are not properly shown yet.
4223 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4225 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4227 * src/maemo/Makefile.am:
4228 * src/maemo/modest-account-settings-dialog.c:
4229 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4230 an existing account. Doesn't do much yet.
4232 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4233 Open the accounts settings dialog when Edit is clicked.
4235 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4237 * src/maemo/easysetup/Makefile.am:
4238 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4240 * src/maemo/easysetup/modest-easysetup-wizard.c:
4241 (modest_easysetup_wizard_dialog_init):
4242 Try to get the source directory from the build system,
4243 instead of hard-coding "./" into the source code, when opening our local
4244 copies of the configuration files.
4245 But this still fails when opening the wizard from the Accounts window,
4246 maybe because the working directory seems to change at runtime.
4247 So the wizard will fail the second time unless you copy the files into their
4248 proper locations - see the stdout warnings for the paths.
4250 (create_page_account_details),(on_before_next):
4251 Check for existing non-server accounts instead of server accounts,
4252 so the default account name is useful again, and to prevent trying to
4255 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4256 Show the wizard when New is clicked.
4258 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4259 (init_view): Show the column headers, and show the columns that are
4260 specified in the UI specs. However, something in Maemo's GTK+ prevents
4261 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4262 change the default account. This is despite unsetting the special properties.
4264 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4266 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4267 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4268 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4269 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4270 to make that clearer.
4271 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4273 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4275 * src/maemo/modest-account-view-window.c:
4276 (modest_account_view_window_init),
4277 (modest_account_view_window_new):
4278 Use the same buttons as specified in the
4279 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4280 the existing widgets, which never had a chance of working.
4281 Put the ModestAccountView treeview in a scrolled window.
4282 Do not repeat the initialization in both _init() and _new().
4284 * src/widgets/modest-account-view.c: (update_account_view):
4285 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4286 this widget and window shows no accounts.
4288 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4290 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4292 * src/maemo/easysetup/modest-easysetup-wizard.c:
4293 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4294 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4295 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4298 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4299 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4300 accounts exist yet, as in the UI spec.
4302 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4304 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4306 * src/maemo/Makefile.am:
4307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4308 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4309 New window for editing connection-specific smtp details.
4310 Not fully implemented.
4312 * src/maemo/modest-connection-specific-smtp-window.c:
4313 (modest_connection_specific_smtp_window_finalize) :
4314 unref the tree model.
4315 (on_button_edit): Show the edit window.
4317 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4319 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4322 * src/maemo/Makefile.am:
4323 * src/maemo/modest-connection-specific-smtp-window.c:
4324 * src/maemo/modest-connection-specific-smtp-window.h:
4325 New window for showing the list of connections, for connection-specific
4326 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4327 * src/maemo/easysetup/modest-easysetup-wizard.c:
4328 (create_page_custom_outgoing): Show the new window when the button is clicked.
4330 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4332 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4333 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4334 * src/maemo/modest-msg-edit-window.c:
4335 (modest_msg_edit_window_insert_image):
4336 * src/modest-conf.c: (modest_conf_key_escape):
4337 * src/modest-mail-operation.c:
4338 (modest_mail_operation_send_new_mail):
4339 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4340 (modest_ui_actions_on_new_account):
4341 * src/widgets/modest-attachment-view.c: (update_filename_request):
4342 * src/widgets/modest-mail-header-view.c:
4343 Corrected warnings that were breaking the build, by commenting out unused variables,
4344 and a function, and by including a header.
4346 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4348 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4349 so we can #ifdef around platform-specific code when necessary.
4350 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4351 to allow this to build for the GNOME platform too.
4353 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4355 * src/maemo/easysetup/modest-easysetup-wizard.c:
4356 Added util_increment_name() and used it in create_page_account_details()
4357 to make sure that the default account name is always a new name.
4359 (modest_easysetup_wizard_dialog_init),
4360 (set_default_custom_servernames): Some minor memory management fixes.
4362 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4366 * src/modest-runtime.c: (init_i18n): Restored the translation
4367 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4368 are defined in config.h, and the translations are installed.
4370 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4371 is defined for translation.
4373 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4375 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4377 * src/maemo/easysetup/modest-easysetup-wizard.c:
4378 (modest_easysetup_wizard_dialog_init):
4379 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4380 Use realistic paths (though they should use $prefix generically) to the
4381 mcc_mapping and provider-data.keyfile files which might work when they
4382 are installed by the future version of the operator-wizard package,
4383 and then fallback to paths in our source code, with an explanatory
4386 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4390 * src/maemo/Makefile.am:
4391 * src/maemo/easysetup/: Added files from the previously-exernal
4392 osso-modest-easysetup.
4393 * src/maemo/modest-main-window-ui.h:
4394 * src/modest-ui-actions.c:
4395 * src/modest-ui-actions.h:
4396 Added modest_ui_actions_on_new_account() as a signal handler for the
4397 New Account menu item. It shows the easysetup wizard.
4398 * po/en_GB.po: Added additional needed logical IDs and translations.