1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
4 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
5 (on_idle_send_receive), (on_idle_open_default_inbox):
6 * src/maemo/modest-msg-edit-window.c:
7 (modest_msg_edit_window_attach_file_noninteractive):
8 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
9 to prevent a hang. I don't quite understand why these are necessary,
10 beause we should already be in the main loop. I guess something outside
11 of the main loop is taking the lock.
13 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
14 we are really using URIs, and use files that are more likely to exist.
16 2007-06-26 Murray Cumming <murrayc@murrayc.com>
18 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
19 necessary because configure.ac now defines different variables.
21 2007-06-26 Murray Cumming <murrayc@murrayc.com>
23 * libmodest-dbus-client/libmodest-dbus-client.c:
24 * libmodest-dbus-client/libmodest-dbus-client.h:
25 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
26 libmodest_dbus_client_compose_mail() is what things actually use.
28 * src/dbus_api/modest-dbus-api.h:
29 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
30 * tests/dbus_api/Makefile.am:
31 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
34 2007-06-26 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-init.c: (modest_init_local_folders):
37 For memory-card (or other non local-folders) maildir accounts,
38 always create an Archive folder, so that there is somewhere to put
39 messages. This should be less confusing, because the user does not need
40 to guess that the need to create a folder.
42 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
44 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
45 Fixed icon size by using (50, 50) which is the same as defined by
48 2007-06-25 Armin Burgmeier <armin@openismus.com>
50 * src/widgets/modest-window-mgr.c:
52 * configure.ac: Correctly recognize hildon-notify presence and fixed
53 the build without it being installed.
55 2007-06-25 Murray Cumming <murrayc@murrayc.com>
57 * libmodest-dbus-client/libmodest-dbus-client.c:
58 (libmodest_dbus_client_search): Fix the build. Sorry.
59 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
60 (reply_forward_cb): Initialize variables to fix the build.
62 * src/modest-tny-account-store.c:
63 (modest_tny_account_store_get_tny_account_by): Fix the account URI
64 comparison (a silly typo) so that email search results can be opened
65 when there are more than one account.
67 2007-06-25 Murray Cumming <murrayc@murrayc.com>
69 * libmodest-dbus-client/libmodest-dbus-client.c:
70 (libmodest_dbus_client_search),
71 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
72 instead of 1 second, because the search gets folders and messages from
73 the server, which can take a long time. When it times out,
74 osso-global-search will report no results.
76 We need to specify whether we should search only cached information
77 (maybe with a user preference), and the osso-email-search-plugin
78 API should really be improved to allow that option, and to allow results
79 to be delivered asynchronously in batches.
81 2007-06-25 Murray Cumming <murrayc@murrayc.com>
83 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
84 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
85 GTK_ICON_SIZE_DIALOG is probably the wrong size.
87 2007-06-25 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
90 that is an empty string. D-Bus seems to give us these instead of NULL.
92 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
94 * src/dbus_api/modest-dbus-callbacks.c:
95 * src/maemo/easysetup/modest-easysetup-wizard.h:
96 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
97 * src/maemo/modest-connection-specific-smtp-edit-window.c:
98 (modest_connection_specific_smtp_edit_window_init):
99 * src/maemo/modest-maemo-global-settings-dialog.c:
101 * src/maemo/modest-maemo-utils.c:
102 (modest_maemo_utils_setup_images_filechooser):
103 * src/maemo/modest-main-window.c: (create_details_widget):
104 * src/maemo/modest-msg-edit-window.c:
105 (modest_msg_edit_window_attach_file_noninteractive),
106 (modest_msg_edit_window_color_button_change),
107 (modest_msg_edit_window_set_zoom):
108 * src/modest-mail-operation.c: (update_account_thread):
109 * src/modest-tny-account-store.c:
110 * src/modest-tny-account.c:
111 * src/widgets/modest-global-settings-dialog.c:
112 * src/widgets/modest-window.h:
116 2007-06-25 Murray Cumming <murrayc@murrayc.com>
118 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
119 * src/modest-search.c: (modest_search_folder),
120 (modest_search_all_accounts): Actually search only in the specified folder,
121 doing a simple match on the folder ID.
122 * src/modest-search.h: Added a folder field to the ModestSearch struct,
123 and added some documentation.
125 2007-06-22 Armin Burgmeier <armin@openismus.com>
127 * src/maemo/modest-maemo-utils.h:
128 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
129 modest_maemo_utils_get_supported_secure_authentication_methods.
131 * src/maemo/easysetup/modest-easysetup-wizard.c:
132 * src/maemo/modest-account-settings-dialog.c: Show correct error if
133 one occured, not just "Server does not support secure authentication".
135 2007-06-22 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-tny-account-store.c: (get_password):
138 Restored the call to tny_account_set_user() because Philip seems to have
139 stopped this from crashing (by not using the freed string). It still does
140 not work, but now we can test it.
142 2007-06-22 Murray Cumming <murrayc@murrayc.com>
144 * src/maemo/modest-msg-edit-window.c: (init_window):
145 Comment out use of an uninitialzed GtkScrolledWindow variable,
146 to fix the build and stop a crash. Yet again.
148 2007-06-22 Murray Cumming <murrayc@murrayc.com>
150 * src/modest-tny-account-store.c: (get_password):
151 Remove the call to tny_account_set_user() because this actually crashes.
152 As mentioned in the last commit, it is known to not work anyway.
154 2007-06-22 Murray Cumming <murrayc@murrayc.com>
156 * src/modest-tny-account-store.c: (get_password):
157 Use tny_account_set_username() to tell tinymail that the username might
158 have changed too. But tinymail ignores this: see projects.maemo.org
160 * src/modest-ui-actions.c:
161 (modest_ui_actions_on_password_requested): Remove the useless attempt to
162 reset the connection when changing the username, and improve the comments.
163 Save the changed username to gconf at least, so it is used when Modest is
166 2007-06-21 Murray Cumming <murrayc@murrayc.com>
168 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
169 Do not use a query, so that we get all folders, including for POP and
170 local-folders. They work as search criteria too.
171 This fixes projects.maemo.org bug NB#57740.
173 2007-06-21 Murray Cumming <murrayc@murrayc.com>
175 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
176 Comment out the use of hildon_notification_set_sound() because it is
177 not declared, to fix the build. Warnings are serious, people.
179 2007-06-21 Armin Burgmeier <armin@openismus.com>
181 * src/maemo/modest-maemo-utils.h:
182 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
183 modest_maemo_utils_get_supported_secure_authentication_methods()
184 to query authentication methods for a specific user. This should fix
185 projects.maemo.org bug NB#61369.
187 * src/maemo/easysetup/modest-easysetup-wizard.c:
188 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
191 2007-06-21 Murray Cumming <murrayc@murrayc.com>
193 * libmodest-dbus-client/libmodest-dbus-client.h:
194 * libmodest-dbus-client/libmodest-dbus-client.c:
195 (modest_dbus_message_iter_get_search_hit),
196 (libmodest_dbus_client_search):
197 Reorganised and commented this.
198 Removed modest_search_hit_free() from the public API because it
201 Added libmodest_dbus_client_get_folders() and
202 modest_folder_result_list_free().
204 * src/dbus_api/modest-dbus-api.h:
205 * src/dbus_api/modest-dbus-callbacks.c:
206 (modest_dbus_req_filter): Commented. Moved most code to
207 on_dbus_method_search() and added on_dbus_method_get_folders().
209 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
210 of the extra D-Bus handler.
212 * tests/dbus_api/Makefile.am:
213 * tests/dbus_api/test_get_folders.c: New test for
214 libmodest_dbus_client_get_folders(). This seems to return an empty list
215 at the moment. That could be the same error that causes the message list
216 to be empty sometimes.
217 This should help with projects.maemo.org bug NB#57740.
219 2007-06-21 Armin Burgmeier <armin@openismus.com>
221 * src/modest-mail-operation.c: Do not call
222 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
223 notify the operation's end after having set the status to CANCELED for
224 the operation queue to listen on. This fixes a deadlock when there
225 were mail operations in the queue during its finalization.
227 * src/modest-singletons.c: Reordered uninitialization of the account
228 manager to happen after the mail operation queue was uninitialized
229 because the mail operation's in the queue might still try to access
230 the account manager (see modest_mail_operation_notify_end()). This
231 fixes a potential crash when terminating the application.
233 2007-06-21 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-search.c:
236 (search_mime_part_and_child_parts): Moved some code here so we
237 can search recursively in child folders.
238 (modest_search_folder): Search in the message as a mime part, instead
239 of just its child mime parts.
240 (read_chunk), (search_mime_part_ogs):
241 Check how many bytes were read, to prevent an endless loop.
242 Searching in message bodies now works. This finishes the fix for
243 projects.maemo.org bug NB#61007.
245 2007-06-20 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
248 Add a g_warning when the item is not a folder.
250 * src/modest-ui-dimming-rules.c:
251 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
252 when selected item is not a folder (for instance, an account), because
253 the UI spec only talks about folders.
254 I am not sure what the UI spec wants, so this might not totally fix
255 projects.maemo.org bug NB#60794.
257 2007-06-20 Murray Cumming <murrayc@murrayc.com>
259 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
260 (load_from_file): Sort the list. The unsorted list would be more noticeable
261 in non-English locales.
263 * src/maemo/modest-msg-edit-window.c:
264 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
265 warning and fix the build.
267 * src/maemo/modest-progress-bar-widget.c:
268 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
269 avoid a g_warning, and probably to avoid a crash.
271 2007-06-20 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-search.c: (modest_search_folder): Check for a GError
274 when calling tny_folder_get_headers(), to show that this is not the cause
277 2007-06-20 Murray Cumming <murrayc@murrayc.com>
279 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
280 Actually set the body query instead of the subject query.
282 * src/modest-search.c: (search_mime_part_ogs),
283 (search_mime_part_strcmp): Remove extra space from the text/* regex,
284 which would probably cause it to fail if we got this far.
286 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
287 to simplify the code.
288 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
289 be causing search-in-body to fail.
291 2007-06-20 Murray Cumming <murrayc@murrayc.com>
293 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
295 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
296 Better debug message when the folder cannot be found.
297 This should help with fixing projects.maemo.org bug #61287.
298 * src/modest-search.c: (add_hit): Do not leak the furl string.
300 2007-06-20 Murray Cumming <murrayc@murrayc.com>
302 * src/modest-ui-actions.c:
303 (modest_ui_actions_on_folder_selection_changed):
304 Do not special-case TNY_MERGE_FOLDER here, because
305 modest_tny_folder_get_account() already does that. This fixes
306 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
307 shown when the Outbox was selected).
309 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
311 * libmodest-dbus-client/libmodest-dbus-client.c:
312 (_dbus_iter_get_string_or_null): Initialize the string variable in
313 case this helps with Dirk's crash.
315 2007-06-19 Murray Cumming <murrayc@murrayc.com>
317 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
318 though it is not implemented yet (this function is maybe not even used),
319 to avoid breaking ABI in future.
320 * libmodest-dbus-client/libmodest-dbus-client.c:
321 (get_attachments_string): Moved some code into this generic function.
322 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
323 sends email. It is maybe not used.
324 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
325 (on_send_mail): Use attachments.
327 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
328 * src/maemo/modest-msg-edit-window.c:
329 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
330 a filename before using it, to fix projects.maemo.org bug NB#58233.
332 2007-06-19 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
335 Initialize the continue_download variable to fix the build, and probably
336 to fix randome behaviour.
338 2007-06-18 Armin Burgmeier <armin@openismus.com>
340 * src/modest-tny-send-queue.h:
341 * src/modest-tny-send-queue.c: Keep track of the status of messages in
342 the queue so we can later show it in the UI. Replaced
343 modest_tny_send_queue_msg_is_being_sent() by
344 modest_tny_send_queue_get_msg_status().
346 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
348 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
349 gpointer. This probably was not harmful, but just to be sure.
351 2007-06-18 Murray Cumming <murrayc@murrayc.com>
353 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
354 Fix the build, but leave the function broken on Bora, because
355 hildon_uri_action_get_service() does not exist.
356 osso_uri_action_get_service() does not exist either, it seems.
358 2007-06-18 Murray Cumming <murrayc@murrayc.com>
360 * src/modest-tny-account.c:
361 (modest_tny_account_new_from_server_account):
362 Uncommented the url debug output again, because it is useful for
363 debugging, as I said in the comment.
365 2007-06-18 Murray Cumming <murrayc@murrayc.com>
367 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
369 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
370 for Mameo Bora, to fix the build.
372 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
375 Fixed build with hildon < 0.99
377 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
378 Check if the selected account is busy instead of checking all accounts
380 * src/modest-account-mgr-priv.h:
381 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
382 (modest_account_mgr_init), (compare_account_name),
383 (modest_account_mgr_set_account_busy),
384 (modest_account_mgr_account_is_busy):
385 * src/modest-account-mgr.h:
386 Added busy information to the account manager. It possible to
387 set an account to busy or not busy now.
389 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
390 (modest_mail_operation_update_account),
391 (modest_mail_operation_notify_end):
392 Set the account to busy/not busy depending on the operation state.
394 * src/widgets/modest-account-view.c:
395 (modest_account_view_finalize), (get_last_updated_string),
396 (update_account_view), (on_account_busy_changed), (init_view):
397 Show string "Refreshing..." if the account is currently busy.
399 All this fixes projects.maemo.org bug NB#59711
401 2007-06-14 Armin Burgmeier <armin@openismus.com>
403 * src/widgets/modest-attachments-view.h:
404 * src/widgets/modest-attachments-view.c: Added
405 modest_attachments_view_has_attachments() and fixed coordinate
406 transformation in get_att_view_at_coords(). This fixes attachment
409 * src/widgets/modest-msg-view.c: Make use of
410 modest_attachments_view_has_attachments() to decide whether to show
411 attachments in the header.
413 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
415 * src/maemo/modest-connection-specific-smtp-edit-window.c:
416 (on_change), (on_combo_security_changed),
417 (modest_connection_specific_smtp_edit_window_init),
418 (modest_connection_specific_smtp_edit_window_set_connection),
419 (modest_connection_specific_smtp_edit_window_is_dirty):
420 * src/maemo/modest-connection-specific-smtp-edit-window.h:
421 * src/maemo/modest-connection-specific-smtp-window.c:
424 Show an comfirmation dialog for the smpt-edit-window if there are
425 unsaved changes and the user hits cancel.
426 (projects.maemo.org bug NB#60479)
428 2007-06-14 Armin Burgmeier <armin@openismus.com>
430 * src/maemo/easysetup/modest-easysetup-wizard.c:
431 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
432 address" info in banner instead of node, and select all the text as
433 per UI spec. This fixes projects.maemo.org bug NB#60550.
435 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
437 reviewed by: <delete if not using a buddy>
439 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
440 * src/modest-ui-actions.c: (folder_refreshed_cb):
442 2007-06-14 Murray Cumming <murrayc@murrayc.com>
444 * src/widgets/modest-folder-view.c: (filter_row):
445 Explictly filter out the per-account outbox accounts. I don't know why
446 these only sometimes show up, but now they should never show up in the UI.
447 This should fix projects.maemo.org bug NB#60160.
449 2007-06-14 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
452 when the toolbar does not exist yet.
453 * src/modest-widget-memory.c: (save_settings_header_view):
454 Added g_warnings() to help us to discover when we are trying to set
455 an empty columns list in gconf.
457 2007-06-14 Murray Cumming <murrayc@murrayc.com>
461 Added modest_init_get_default_header_view_column_ids().
463 * src/modest-widget-memory.c: (restore_settings_header_view):
464 Use the new function to get defaults, if the gconf key is empty,
465 instead of not creating any columns. This seems to fix the
466 empty right-hand pane problems.
468 * src/widgets/modest-header-view.h: Improved documentation.
470 2007-06-13 Murray Cumming <murrayc@murrayc.com>
472 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
473 Revert the use of the display name as the account name, because this
474 is generally wrong and would break the code that follows.
476 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
478 * src/maemo/easysetup/modest-easysetup-wizard.c:
479 (check_for_supported_auth_methods), (on_before_next),
482 More correct fix for projects.maemo.org bug NB# 58991
483 Do not longer accept AUTH_PASSWORD as secure method and choose
484 correct method when creating the account.
486 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
488 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
489 Fixed projects.maemo.org bug NB# 58991
491 2007-06-13 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-init.c: (modest_init_init_core),
494 (modest_init_local_folders): Fixed compilation errors.
496 2007-06-13 Murray Cumming <murrayc@murrayc.com>
498 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
499 Remove unnecessary lib/include, though it is good in principle when needed.
501 * src/modest-init.c: (modest_init_one_local_folder),
502 (modest_init_local_folders):
503 * src/modest-init.h: Initialize the .modest library for memory cards,
504 instead of just doing nothing for them. This should allow us to create
505 folders there, fixing projects.maemo.org bug NB#59297.
507 2007-06-13 Murray Cumming <murrayc@murrayc.com>
509 * libmodest-dbus-client/libmodest-dbus-client.c:
510 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
511 (libmodest_dbus_client_compose_mail),
512 (libmodest_dbus_client_open_message),
513 (libmodest_dbus_client_send_and_receive),
514 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
516 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
517 (on_idle_open_message), (modest_dbus_req_handler),
518 (search_result_to_message), (modest_dbus_req_filter):
519 * src/modest-search.c: (add_hit), (modest_search_folder),
520 (modest_search_all_accounts): Improved debug messages.
522 * tests/dbus_api/test_open_message.c: (main): Improved comments.
524 * src/modest-tny-account-store.c:
525 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
528 2007-06-13 Murray Cumming <murrayc@murrayc.com>
531 2007-06-12 Murray Cumming <murrayc@murrayc.com>
533 * src/modest-tny-account-store.c: (get_server_accounts):
534 Call modest_tny_local_folders_account_add_merged_outbox_folders()
535 even when there are no accounts, so that the Outbox folder is always
536 visible. This fixes projects.maemo.org bug NB#60158.
538 2007-06-12 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/modest-main-window.c: (create_details_widget):
541 Use the mcen_va_never logical ID.
543 2007-06-12 Murray Cumming <murrayc@murrayc.com>
545 * src/dbus_api/modest-dbus-api.h:
546 * src/dbus_api/modest-dbus-callbacks.c:
547 (on_idle_open_default_inbox), (on_open_default_inbox),
548 (modest_dbus_req_handler):
549 Added a new OpenDefaultInbox method.
551 * libmodest-dbus-client/libmodest-dbus-client.h:
552 * libmodest-dbus-client/libmodest-dbus-client.c:
553 Added libmodest_dbus_client_open_default_inbox() to call the new
554 dbus method. This should be useful to projects.maemo.org bug NB#57214,
555 though it should maybe be used by a new osso-email-interface function.
557 * tests/dbus_api/Makefile.am:
558 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
561 2007-06-12 Murray Cumming <murrayc@murrayc.com>
563 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
564 NULL, so that the signals get all the keys. This should not actually
565 change any behaviour because we currently update everything when anything
568 2007-06-12 Murray Cumming <murrayc@murrayc.com>
570 * src/widgets/modest-folder-view.c: (text_cell_data),
571 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
572 (find_inbox_iter): If tinymail tells us that the folder is
573 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
574 This causes the inbox to be selected at startup, fixing part of
575 projects.maemo.org bug NB#56305.
577 * src/modest-ui-dimming-rules.c:
578 (modest_ui_dimming_rules_on_tools_smtp_servers):
579 * src/modest-ui-dimming-rules.h: Added a callback function to dim
580 the SMTP servers menu item.
581 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
582 that the SMTP Servers menu item is dimmed when there are no accounts,
583 as a future version of the UI spec will require. This fixes
584 projects.maemo.org bug NB#56305.
586 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
588 * src/maemo/modest-maemo-utils.c:
589 (modest_maemo_utils_get_supported_secure_authentication_methods):
590 Added label to dialog instead of unreadable title
592 * src/maemo/modest-main-window.c: (sync_accounts_cb),
593 (modest_main_window_new):
594 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
597 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
598 * src/modest-account-mgr.h:
599 Added method to avoid code duplication
601 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
602 (modest_ui_actions_on_send_receive):
603 Use modest_account_mgr_has_accounts
605 2007-06-11 Murray Cumming <murrayc@murrayc.com>
607 * src/maemo/easysetup/modest-presets.c:
608 (modest_presets_get_info_server_security): Do not report secure auth
610 * src/modest-protocol-info.c: Use the defines for the gconf key names
611 for secure authentication. This was not working because we were writing
612 Password and reading password, and the check was case sensitive.
613 With this, gmail now works for receiving and sending when created via
616 2007-06-11 Murray Cumming <murrayc@murrayc.com>
618 * src/maemo/easysetup/modest-presets.c:
619 (modest_presets_get_info_server_security): Correct the key name for
620 SecureSmtp, because it seems to be case-sensitive.
621 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
622 Do not try to get the 0th notebook page if there are 0 pages, to
625 2007-06-11 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
628 Prevent use of the new notification feature for now, because it currently
629 shows one dialog for each new email, which is annoying.
631 2007-06-11 Murray Cumming <murrayc@murrayc.com>
633 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
634 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
635 when no country was selected, so that we show the global ones.
636 * src/maemo/easysetup/modest-presets.c:
637 (modest_presets_get_providers): Return only the global providers, not
638 all providers when mmc=0 was requested.
640 2007-06-11 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
643 (easysetup_provider_combo_box_fill): Remove debug code that showed the
644 provider ID in the combo.
646 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
647 Do not show the page numbers, because it would be confusing when we add
648 the 2 extra pages for the custom setup, when the user chooses the "Other"
649 provider. This fixes projects.maemo.org bug NB#59028
651 * src/modest-init.c: (modest_init_init_core),
652 (modest_init_local_folders):
654 * src/modest-tny-account.c:
655 (modest_tny_account_new_for_local_folders): Do not create default folders
656 for the memory card. This should fix projects.maemo.org bug NB#59328.
658 2007-06-11 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
661 Free the changed_conf_keys string items. They are already freed in the
662 idle handler if that runs first.
664 2007-06-11 Murray Cumming <murrayc@murrayc.com>
666 * src/modest-ui-actions.c:
667 (modest_ui_actions_on_password_requested): Check that the server name
668 is not NULL, because I just saw a password dialog with (null) as the
671 * src/modest-tny-folder.[h|c]: Added
672 modest_tny_folder_is_memory_card_folder().
673 * src/modest-ui-dimming-rules.c:
674 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
675 menu item for memory cards, as per the UI spec (section 7.4). This should
676 fix projects.maemo.org bug NB#59297.
678 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
680 * src/maemo/modest-main-window.c: (sync_accounts_cb):
681 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
682 is another problem with the code, see Murray's comment at line 772)
684 2007-06-08 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
687 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
688 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
689 (load_from_file), (easysetup_country_combo_box_init),
690 (easysetup_country_combo_box_get_active_country_ids),
691 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
692 instead of just one ID, to avoid duplicate country names in the UI.
694 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
695 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
696 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
697 a single ID, avoiding duplicate providers.
698 * src/maemo/easysetup/modest-easysetup-wizard.c:
699 (on_combo_account_country): Adapt to use a list.
701 2007-06-08 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
704 keys changed in the last X seconds.
706 * src/modest-account-mgr.h:
707 * src/modest-account-mgr.c: (on_timeout_notify_changes),
708 (on_key_change), (modest_account_mgr_class_init),
709 (modest_account_mgr_init), (modest_account_mgr_finalize):
710 As the keys are changed, save them in a GSList* and signal that GSList*
711 further every X seconds, to batch changes, to allow us to do just one
712 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
713 bug NB#56941 and other (UI-blocking) delays when changing account settings.
715 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
716 changed signal signature.
718 * src/modest-conf.c: (modest_conf_set_list),
719 (modest_conf_on_change): Reenable notification.
721 (modest_conf_maemo_fake_on_change): Comment out the hack that
722 notified immediately instead of asynchronously.
724 * src/widgets/modest-account-view.h:
725 * src/widgets/modest-account-view.c:
726 (update_account_view): Select the previously-selected account ID,
727 if possible. This fixes projects.maemo.org bug NB#56933.
729 (on_account_changed), (on_account_removed),
730 (modest_account_view_select_account):
732 Remove the block/unblock functions
733 because they were not useful.
735 * src/maemo/modest-account-view-window.c:
736 (on_delete_button_clicked), (on_edit_button_clicked),
737 (on_new_button_clicked): Remove the use of the non-working block/unblock.
739 2007-06-08 Murray Cumming <murrayc@murrayc.com>
741 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
742 Improve the error dialog to show Incorrect Account Settings, which seems
743 clearer, and say that the internal error message (to be removed from the
744 dialog later) is often misleading.
745 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
747 * src/modest-tny-account.c:
748 (modest_tny_account_new_from_server_account): Uncomment the printf of the
749 URL because this is so useful for debugging on the device.
751 * src/widgets/modest-serversecurity-combo-box.c:
752 (modest_serversecurity_combo_box_fill): Correct a logical ID.
754 2007-06-08 Murray Cumming <murrayc@murrayc.com>
756 * src/modest-mail-operation.c:
757 (modest_mail_operation_send_new_mail):
758 Added a comment about a nasty but apparently harmless message. Details
759 added to the wiki g_warnings() page.
761 2007-06-08 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
764 (modest_tny_send_queue_class_init):
765 Do not use the priv struct because it is empty, to avoid g_warnings
766 about a non-existant priv struct.
768 * src/modest-tny-account-store.c:
769 (modest_tny_account_store_get_server_account),
770 (modest_tny_account_store_get_transport_account_for_open_connection
771 ): Do not try to get transport server accounts for local folders,
772 because they don't have any. This avoids a g_warning().
774 * src/maemo/modest-main-window.c:
775 (modest_main_window_notify_send_receive_initied),
776 (on_configuration_key_changed):
777 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
779 * src/modest-mail-operation.c:
780 (modest_mail_operation_update_account):
781 * src/modest-tny-account-store.h:
782 * src/modest-tny-account.c:
783 (modest_tny_account_get_special_folder),
784 (modest_tny_account_new_for_local_folders),
785 (modest_tny_account_new_for_per_account_local_outbox_folder):
786 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
787 * src/modest-tny-local-folders-account.c:
788 (add_account_folders_to_merged_folder):
789 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
790 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
791 (modest_ui_actions_on_send):
792 * src/widgets/modest-folder-view.c: (update_model):
793 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
794 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
795 modest_tny_account_store_get_tny_account_by_account() to
796 modest_tny_account_store_get_server_account() to make the code clearer.
798 2007-06-07 Marcus Bauer <marcusb@openismus.com>
800 * src/dbus_api/modest-dbus-api.h:
801 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
802 * src/maemo/modest-msg-edit-window.c:
803 (modest_msg_edit_window_attach_file_noninteractive):
804 added g_warning in case the file to be attached does not exist
805 * tests/dbus_api/test_compose_mail.c: (main):
806 removed obsolete comment, added generic files as test case
808 2007-06-07 Murray Cumming <murrayc@murrayc.com>
810 * src/modest-tny-account-store.c: (get_server_accounts):
811 Create the local folders account only once, not once for each outbox, and
812 not only when there are some outboxes.
814 2007-06-07 Murray Cumming <murrayc@murrayc.com>
816 * src/widgets/modest-folder-view.c: (update_model): Comment out some
817 code that is causing a crash at startup. Sergio says that he is fixing this.
819 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
821 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
822 * src/maemo/modest-account-settings-dialog.c:
823 (create_page_outgoing),
824 (modest_account_settings_dialog_set_account_name),
825 (save_configuration):
826 - Fixed handling of the "Use secure authentication" toggle to comply with
827 the ui specification. See also projects.maemo.org bug NB#58400
829 - Restore the Secure connection setting combo correctly when loading
832 * src/maemo/modest-maemo-utils.c:
833 (on_camel_account_get_supported_secure_authentication),
834 (modest_maemo_utils_get_supported_secure_authentication_methods):
835 Fixed a crasher if operation is canceled
837 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
838 (modest_protocol_info_auth_is_secure):
839 * src/modest-protocol-info.h:
841 Added two new methods to determine if a protocol/auth method is secure/encrypted in
842 the sense of the "Use secure authentication" toggle.
844 2007-06-07 Murray Cumming <murrayc@murrayc.com>
846 * src/modest-tny-account-store.h:
847 * src/modest-tny-account-store.c:
848 Added modest_tny_account_store_get_local_folders_account().
850 * src/modest-tny-folder.h:
851 * src/modest-tny-folder.c:
852 (modest_tny_folder_get_account):
853 Added this replacement for tny_folder_get_account() which returns
854 the local-folders account for TnyMergeFolders, to avoid the
855 warning about the unimplemented get_account_func() vfunc().
857 (modest_tny_folder_get_rules),
858 * src/modest-ui-actions.c:
859 (modest_ui_actions_on_folder_selection_changed):
860 * src/modest-mail-operation.c:
861 (modest_mail_operation_remove_folder),
862 (modest_mail_operation_xfer_folder),
863 (modest_mail_operation_rename_folder),
864 (modest_mail_operation_get_msg),
865 (modest_mail_operation_get_msgs_full),
866 (modest_mail_operation_remove_msg),
867 (modest_mail_operation_xfer_msgs),
868 (modest_mail_operation_refresh_folder):
869 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
871 2007-06-07 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
874 (modest_server_account_set_security):
875 * src/modest-defs.h: Add comments explaining that our
876 UI spec means TLS when it says Normal, so these do not look like errors.
878 * src/modest-tny-account.c:
879 (modest_tny_account_new_from_server_account): Use the new tinymail
880 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
881 for TLS. This should fix projects.maemo.org bug NB#58460.
883 2007-06-06 Murray Cumming <murrayc@murrayc.com>
885 * src/maemo/easysetup/modest-easysetup-wizard.c:
886 (create_account): Correct the position of the gconf sanity check warning.
887 (on_button_edit_advanced_settings): Show the dialog immediately, instead
888 of using the g_idle_add() hack, because this does not seem to be necessary
889 on osso 1.1. It might even work on Maemo Bora if the problems were actually
890 caused by something other than maemo's gconf.
891 This fixes projects.maemo.org bug #59022.
893 2007-06-06 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-account-mgr-helpers.c:
896 (modest_account_mgr_get_default_account): Do not check that the account
897 exists if there is no default account (NULL), to fix a runtime warning.
899 2007-06-06 Murray Cumming <murrayc@murrayc.com>
901 * src/widgets/modest-folder-view.c: (update_model):
902 Do not unref the treemodel before we have finished with it.
903 This prevents a valgrind warning and an occasional crash at startup.
905 2007-06-06 Marcus Bauer <marcusb@openismus.com>
907 * libmodest-dbus-client/libmodest-dbus-client.h:
908 added libmodest_dbus_client_compose_mail()
909 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
911 added functions needed for SendAsMail() functionality
912 * src/maemo/modest-msg-edit-window.c:
913 (modest_msg_edit_window_attach_file_noninteractive):
914 non interactively attaching files to message edit window
915 * src/widgets/modest-msg-edit-window.h:
916 * tests/dbus_api/Makefile.am:
917 added test_compose_mail.c
918 * tests/dbus_api/test_compose_mail.c: (main):
920 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
922 * src/modest-account-view.c:
923 Fixed bug projects.maemo.org bug NB#59307
925 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
927 * src/maemo/easysetup/modest-easysetup-wizard.c:
928 (get_serverport_incoming), (on_before_next), (create_account):
929 * src/maemo/modest-account-settings-dialog.c:
930 (modest_account_settings_dialog_set_account_name):
931 * src/maemo/modest-maemo-utils.c:
932 (on_camel_account_get_supported_secure_authentication_status),
933 (on_camel_account_get_supported_secure_authentication),
934 (on_secure_auth_cancel),
935 (modest_maemo_utils_get_supported_secure_authentication_methods):
937 Implemented security authentication for settings and easysetup.
939 2007-06-05 Murray Cumming <murrayc@murrayc.com>
941 * src/maemo/modest-main-window.c: (create_details_widget):
942 Show the total size for memory card accounts too, instead of showing
943 the name again. Fixes bug projects.maemo.org bug NB#59307.
945 2007-06-05 Murray Cumming <murrayc@murrayc.com>
948 * src/modest-tny-simple-folder-store.c:
949 * src/modest-tny-simple-folder-store.h: Removed.
951 * src/modest-tny-local-folders-account.h
952 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
953 for the local-folders maildir, with an extra TnyMergedFolder containing
954 the folders of the per-account outbox store accounts.
955 * src/modest-tny-account-store.c: (get_server_accounts):
956 Add the outboxes to the special local folders account after creating it.
958 * src/modest-tny-account.c:
959 (modest_tny_account_new_for_local_folders): Create the derived
960 account when creating the main local-folders account.
962 * src/maemo/modest-main-window.c: (create_details_widget),
963 (modest_main_window_set_contents_style):
964 Adapted to the use of the derived account instead of the folder store.
966 * src/modest-ui-actions.c:
967 (modest_ui_actions_on_folder_selection_changed):
968 * src/modest-ui-dimming-rules.c:
969 (modest_ui_dimming_rules_on_new_folder):
970 * src/widgets/modest-folder-view.c: (text_cell_data),
971 (icon_cell_data), (filter_row), (update_model),
972 (get_cmp_rows_type_pos):
975 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
976 Do not get the priv struct, because no priv struct has been set,
977 to avoid a runtime warning.
979 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
980 #ifelse with #else, to fix a warning, to fix the build.
983 2007-06-05 Christian Kellner <ckellner@openismus.com>
985 * libmodest-dbus-client/libmodest-dbus-client.c:
986 Fix small typo in doc (why do you always see them
987 AFTER committing stuff?)
990 2007-06-05 Christian Kellner <ckellner@openismus.com>
992 * libmodest-dbus-client/libmodest-dbus-client.c:
993 (libmodest_dbus_client_search):
994 Initialize hit list with NULL. Also set folder list
995 to "" if NULL was supplied.
998 2007-06-03 Christian Kellner <ckellner@openismus.com>
1000 * libmodest-dbus-client/libmodest-dbus-client.c:
1001 (modest_search_hit_list_free):
1002 Make it save to call it with NULL.
1004 * src/dbus_api/modest-dbus-callbacks.c:
1005 * src/modest-search.c:
1006 Return full ModestSearchHits as the search result list not TnyHeader
1007 since can't be around withouth the correspoding TnyFolder.
1009 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1011 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1012 Added currently commented code to check for secure auth
1014 * src/maemo/modest-account-settings-dialog.c: (on_response),
1015 (save_configuration), (show_ok):
1016 Fixed projects.maemo.org bugs NB #59248 and #59251
1018 * src/maemo/modest-maemo-utils.c:
1019 (on_camel_account_get_supported_secure_authentication_status),
1020 (on_camel_account_get_supported_secure_authentication),
1021 (modest_maemo_utils_get_supported_secure_authentication_methods):
1022 * src/maemo/modest-maemo-utils.h:
1023 Moved get_supported_secure_authentication() method here to be able
1024 to use it from easysetup wizard.
1026 * src/modest-pair.c: (on_pair_compare_as_string):
1027 Should compare string with first part of pair and not
1028 strcmp pairs which will crash.
1030 * src/modest-protocol-info.c:
1031 (modest_protocol_info_protocol_is_store):
1032 * src/modest-protocol-info.h:
1033 Added modest_protocol_info_get_auth_protocol_name()
1035 2007-06-03 Armin Burgmeier <armin@openismus.com>
1037 * src/modest-mail-operation.c:
1038 (modest_mail_operation_get_msgs_full): Set priv->account also when
1039 only retrieving a single message. This avoids a crash when canceling
1042 (modest_mail_operation_notify_end): Do not explicitely remove the
1043 operation from the queue but only emit the progress_changed signal.
1044 The queue itself listens to that signal to remove the operation when
1045 it is finished. This reduces coupling and removes a potential deadlock
1046 when modest_mail_operation_notify_end() is called from the queue
1047 itself. If that is a problem performance-wise, I would suggest to
1048 implement a status-changed signal or something.
1050 * src/modest-mail-operation-queue.c: Make sure to never call a
1051 function from another file while the queue is locked. This (hopefully)
1052 fixes another deadlock when exiting the application while retrieving
1055 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1057 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1058 Fixed build if libogs is not available
1060 2007-06-03 Christian Kellner <ckellner@openismus.com>
1062 * libmodest-dbus-client/libmodest-dbus-client.h:
1063 * libmodest-dbus-client/libmodest-dbus-client.c:
1064 (libmodest_dbus_client_delete_message):
1065 Implement deletion of messages (Client side).
1067 (modest_search_hit_free),
1068 (modest_search_hit_list_free):
1069 Utility functions to free the result hits.
1071 * src/dbus_api/modest-dbus-api.h:
1072 * src/dbus_api/modest-dbus-callbacks.c:
1073 (on_delete_message),
1074 (modest_dbus_req_handler):
1075 Implement deletion of messages (Server side).
1077 * tests/dbus_api/test_search.c: (main):
1080 * tests/dbus_api/Makefile.am:
1081 * tests/dbus_api/test_delete_message:
1082 Add little test for the message deletion logic
1084 2007-06-03 Armin Burgmeier <armin@openismus.com>
1086 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1087 when the operation queue was not empty. projects.maemo.org bug
1090 2007-06-03 Armin Burgmeier <armin@openismus.com>
1092 * src/widgets/modest-account-view.c
1093 (on_account_default_toggled): Toggle default account column
1094 explicitely instead of waiting for gconf notification (which is
1095 currently ignored). This should fix projects.maemo.org bug NB#56910
1096 for now. It should probably be removed when gconf notifications are
1099 2007-06-03 Christian Kellner <ckellner@openismus.com>
1101 * libmodest-dbus-client/libmodest-dbus-client.c:
1102 Removed debugging spew.
1104 * src/dbus_api/modest-dbus-callbacks.c:
1105 Added debugging info.
1107 * src/modest-search.c:
1108 (modest_search_all_accounts):
1109 Use tny_account_store_get_accounts () on the account store
1110 to get all accounts which is the way to get all accounts.
1112 * tests/dbus_api/test_search.c: (main):
1113 Make it possible to supply the search term on the command line.
1115 2007-06-03 Christian Kellner <ckellner@openismus.com>
1117 * libmodest-dbus-client/libmodest-dbus-client.c:
1118 * libmodest-dbus-client/libmodest-dbus-client.h:
1119 Implement searching for mesages over raw dbus. (Client side)
1121 * src/dbus_api/Makefile.am:
1122 * src/dbus_api/modest-dbus-api.h:
1123 * src/dbus_api/modest-dbus-callbacks.c:
1124 * src/dbus_api/modest-dbus-callbacks.h:
1125 Search framework (Server side). Also implement on_idle_open_message().
1127 * src/maemo/modest-platform.c: (modest_platform_init):
1128 Prepare for raw dbus/osso rpc interaction.
1130 * src/modest-search.h:
1131 Changed minsize from unspecific guint to guint32.
1133 * src/modest-search.c:
1135 Added strange hack which magically made tnymail work.
1137 (modest_search_folder),
1138 (modest_search_account),
1139 (modest_search_all_accounts):
1140 Implement helper functions to search all accounts, specific account
1143 * tests/dbus_api/Makefile.am:
1144 * tests/dbus_api/test_open_message.c:
1145 Read url to open from commandline.
1147 * tests/dbus_api/test_search.c:
1148 Implement small test for dbus search stuff
1150 2007-06-02 Armin Burgmeier <armin@openismus.com>
1152 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1153 include account type and account title. This fixes projects.maemo.org
1156 * src/maemo/modest-account-view-window.c: Set a title for the window.
1158 2007-06-02 Armin Burgmeier <armin@openismus.com>
1160 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1161 incoming and outgoing server name based on email address and server
1162 types as long as the names have not been edited manually. This fixes
1163 projects.maemo.org bug NB#58671.
1165 2007-06-02 Armin Burgmeier <armin@openismus.com>
1167 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1168 server type cannot be changed in future to the incoming details page
1169 when creating an account. This fixes projects.maemo.org bug NB#59029.
1171 2007-06-02 Armin Burgmeier <armin@openismus.com>
1173 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1174 and assigned max width chars so that they wrap instead of being
1175 truncated. Fixes projects.maemo.org bug NB#56126.
1177 2007-06-02 Armin Burgmeier <armin@openismus.com>
1179 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1180 introductory note to the connection specific smtp servers dialog, as
1181 section 8.12 of the email UI specification requires. This fixes
1182 projects.maemo.org bug NB#59212.
1184 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1187 Check for running mail operations, and offer to cancel them, as per the UI
1188 spec. This fixes projects.maemo.org bug NB#59041 .
1189 However, I suspect that tinymail may still use the network connection
1190 in ways that we cannot detect or cancel. But it should at least adapt to
1191 changes fairly well.
1193 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-tny-account-store.c: (recreate_all_accounts),
1196 (get_cached_accounts), (get_server_accounts): Do more sensible
1197 ref-counting of the temporarily-cached outbox accounts list. This seems
1198 to fix a crash when entering the password when the password was wrong.
1200 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1202 * src/gnome/modest-main-window.c: (connect_signals):
1203 * src/modest-tny-account-store.c: (get_password),
1204 (modest_tny_account_store_alert): Added comments and clues and
1205 commented-out code about how we currently fail to deal with connection
1206 errors and wrong passwords, and how we should.
1208 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1210 * src/widgets/modest-retrieve-combo-box.c:
1211 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1212 This fixes projects.maemo.org bug NB#58472 .
1214 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1216 * src/maemo/easysetup/modest-easysetup-wizard.c:
1217 (create_page_complete_easysetup):
1218 (create_page_complete_custom): Correct the last commit,
1219 putting the correct sentences in the correct pages.
1221 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/easysetup/modest-easysetup-wizard.c:
1224 (create_page_complete_custom): Show the second sentence of text
1225 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1228 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1231 Set the leave-on-server conf key by default. This fixes
1232 projects.maemo.org bug NB#59258 .
1234 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1236 * src/maemo/modest-account-view-window.c:
1237 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1238 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1241 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/easysetup/modest-easysetup-wizard.c:
1244 (create_caption_new_with_asterisk):
1245 * src/maemo/modest-account-settings-dialog.c:
1246 (create_caption_new_with_asterisk):
1247 Uncomment the code to add the asterisk, because they are no longer in the
1248 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1249 (update_incoming_server_title): Add an asterisk here too.
1251 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/modest-maemo-global-settings-dialog.c:
1254 (current_connection): Check that we are even connected before trying to
1255 get the current connection name, to prevent a warning.
1257 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1258 Change the comments because tny_maemo_conic_device_connect() is now meant to
1260 * src/modest-mail-operation.c:
1261 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1262 make sure we have a connection and fail if we can't connect.
1264 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1266 * src/maemo/modest-main-window.c:
1267 (on_account_store_connecting_finished): Do not try to get the
1268 connection ID if we are not really connected. I am surprised that
1269 this signal handler is called when we are not connected.
1271 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-error.h:
1274 * src/modest-ui-actions.c:
1275 (modest_ui_actions_get_msgs_full_error_handler):
1276 Renamed an enum, added comments, added an enum
1277 for retrieve-limit errors.
1279 * src/modest-mail-operation.c: (foreach_add_item),
1280 (internal_folder_observer_update), (update_account_thread),
1281 (modest_mail_operation_get_msgs_full):
1282 (modest_mail_operation_update_account),
1283 Added comments about how this works, and some code that should
1284 (but does not) check the retrieve-limit. See the TODO comment.
1286 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1288 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1289 Initialize help_id to fix the build. Warnings are good.
1291 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1293 * src/widgets/modest-hbox-cell-renderer.c:
1294 (modest_hbox_cell_renderer_append):
1295 * src/widgets/modest-vbox-cell-renderer.c:
1296 (modest_vbox_cell_renderer_append):
1297 Fix the last commit by doing an extra ref.
1299 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1301 * src/widgets/modest-hbox-cell-renderer.c:
1302 (modest_hbox_cell_renderer_append):
1303 * src/widgets/modest-vbox-cell-renderer.c:
1304 (modest_vbox_cell_renderer_append):
1305 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1306 to fix the build with Maemo Bora.
1307 However, there seems to be a remaining crash, probably due to reference
1310 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1312 * src/modest-tny-account.c:
1313 (modest_tny_account_new_for_local_folders):
1314 Use hildon_file_system_info_async_new() to get a better name for
1315 the memory card account, setting it as the account name.
1316 The timing seems to work, but this is probably
1317 not the best place to do this. See the TODO comment.
1318 * src/maemo/modest-main-window.c: (create_details_widget):
1319 * src/widgets/modest-folder-view.c: (text_cell_data):
1320 Use the tny account name instead of hardcoding a name.
1322 2007-05-30 Christian Kellner <ckellner@openismus.com>
1324 * src/modest-search.c: (modest_search):
1325 Correctly set part_search_func even if we have already parsed
1326 the query and thus a valid OgsTextSearcher object.
1328 2007-05-30 Christian Kellner <ckellner@openismus.com>
1331 Search and check for libogs.
1334 Incooparte the ogs build env.
1336 * src/modest-mime-part-search-stream.c:
1337 * src/modest-mime-part-search-stream.h:
1338 Removed since we do the real searching now in modest-search.c.
1340 * src/modest-search.c:
1341 * src/modest-search.h:
1342 Implement support for ogs. We use that if available and requested
1343 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1344 should now handle the corner case when the search term is spread
1345 across multiple reads.
1346 Also the logic in modest_search () was corrected to search all
1347 requested fields until one is found.
1349 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1351 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1353 * src/modest-init.h:
1354 * src/modest-init.c: Made modest_init_local_folders() take a
1355 path and be public so we can iniitialize maildir folders on
1358 * src/modest-local-folder-info.h:
1359 * src/modest-local-folder-info.c:
1360 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1362 * src/modest-tny-account.c:
1363 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1364 still means the standard local-folders path on the local volume.
1366 * src/modest-tny-account-store.c:
1367 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1368 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1369 all accounts when that happens.
1370 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1371 this too, so it shows up in the treeview.
1373 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1375 * src/maemo/modest-maemo-global-settings-dialog.c:
1376 (current_connection):
1377 * src/widgets/modest-global-settings-dialog.c:
1378 (current_connection_default):
1379 Use the enum values instead of 0, 1 and -1,
1380 to make the code clearer.
1382 * src/modest-account-mgr-helpers.c:
1383 (modest_account_mgr_get_connection_specific_smtp): Make this code
1386 * src/modest-runtime.h:
1387 * src/modest-runtime.c:
1388 Added modest_runtime_remove_all_send_queues().
1389 * src/maemo/modest-main-window.c:
1390 (on_account_store_connecting_finished): Recreate the send queues,
1391 using the appropriate transport accounts for this new connection.
1392 Some futher adapting might be needed if the old send queues are not
1393 automatically stopped at this point.
1395 * src/modest-tny-account-store.c: (get_server_accounts):
1396 Create the connection-specific transport accounts, so that they can
1397 be found later by their ID.
1399 * src/modest-tny-account.h:
1400 * src/modest-tny-account.c:
1401 Added modest_tny_account_new_from_server_account_name().
1402 modest_tny_account_new_from_server_account(): Do not create the
1403 send queues here, because they will be
1404 recreated anyway when the connection changes for the first time.
1406 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1408 * src/modest-local-folder-info.h:
1409 * src/modest-local-folder-info.c:
1410 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1411 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1412 tbox_folder): Take a modest account name instead of a server TnyAccount,
1413 so we can have per-modest-account rather than per-transport-account
1415 We must make sure that we change or recreate the exisitng send queues
1416 when the connection changes for connection-specific transport accounts.
1418 * src/modest-tny-account-store.c:
1419 (create_per_account_local_outbox_folders): Create outboxed per modest
1420 account, not per transport account.
1422 * src/modest-tny-account.h:
1423 * src/modest-tny-account.c:
1424 (modest_tny_account_get_special_folder): For outboxes, get the
1425 parent modest account name. The account is ignored for other folders.
1426 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1427 modest account name rather than a server TnyAccount.
1429 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-tny-account.c:
1432 (modest_tny_account_new_from_server_account):
1433 Call modest_runtime_get_send_queue() immediately after creating transport
1434 accounts, so that they start trying to send email from the outbox as soon
1435 as possible at startup. This is probably what we want.
1437 * src/modest-mail-operation.c: (update_account_thread):
1438 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1439 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1440 * src/modest-tny-send-queue.h:
1441 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1442 (modest_ui_actions_on_send):
1443 Added comments about how sending works, though it needs some more work.
1445 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1447 * src/modest-tny-account.c:
1448 (modest_tny_account_get_special_folder): Add TODO because this fails when
1449 the network is busy.
1450 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1451 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1452 Do not try to show this window when there is no active account. The UI
1453 specs does not tell us what to do in this case.
1455 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1459 * src/maemo/Makefile.am:
1460 * src/widgets/Makefile.am: Some dist fixes.
1462 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1464 * src/maemo/modest-connection-specific-smtp-window.c:
1465 (on_button_edit): Make the code clearer, to prevent a double free.
1467 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1469 * src/maemo/modest-account-settings-dialog.c:
1470 (modest_account_settings_dialog_set_account_name),
1471 Check the connection-specific smtp servers checkbox if there are any.
1473 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1474 (modest_connection_specific_smtp_edit_window_init):
1475 Start with a suitable port number.
1477 * src/modest-account-mgr-helpers.h:
1478 * src/modest-account-mgr-helpers.c: Added
1479 modest_account_mgr_get_has_connection_specific_smtp().
1481 (modest_account_mgr_set_connection_specific_smtp),
1482 (modest_account_mgr_remove_connection_specific_smtp),
1483 (modest_account_mgr_get_has_connection_specific_smtp),
1484 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1485 connection-specific smtp server accounts in the account, rather than
1486 the server account conf dir.
1488 This fixes bug projects.maemo.org bug NB#58263 .
1490 * src/modest-tny-account-store.c:
1491 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1492 if there are no server accounts yet, to prevent an infinite loop when there
1493 are no accounts. Document that one must be called before the other.
1495 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1497 * src/modest-account-mgr-helpers.c:
1498 (modest_account_mgr_get_default_account): Make sure that at least
1499 one account is always the default, if there are any enabled accounts.
1500 This is just a sanity check that shouldn't be necessary.
1502 * src/modest-account-mgr-priv.c:
1503 (_modest_account_mgr_account_from_key): Unescape the conf key to
1504 get the real account name. For instance, this is an issue if a space
1505 was in the account name, which can happen because the account name
1506 is generated from the display name.
1507 (_modest_account_mgr_get_account_keyname): Always escape the
1509 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1510 Unescape the conf keys to get the real account names.
1512 For instance, previously the is-default radio button in the accounts
1513 list was not checked for any accounts at first. This fixes that,
1514 and might fix several similar bugs.
1516 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1518 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1519 Removed some debug printfs.
1521 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1523 Modest on-disk outbox directories are now here, for instance:
1524 $HOME/.modest/outboxes/<account-id-1>/outbox
1525 $HOME/.modest/outboxes/<account-id-2>/outbox
1527 $HOME/.modest/local-folders/outbox
1528 so we can have a separate outbox for each account.
1529 But they are shown as one outbox in the GtkTreeView, by using a
1530 TnyMergeFolder in a ModestTnySimpleFolderStore.
1533 * src/modest-tny-simple-folder-store.c:
1534 * src/modest-tny-simple-folder-store.h:
1535 Added ModestTnySimpleFolderStore, used to contain folders from
1536 other folder stores, such as other accounts.
1538 * src/modest-tny-outbox-account.h:
1539 * src/modest-tny-outbox-account.c:
1540 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1541 used for the per-account local outbox folders.
1543 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1544 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1545 only use this (internally) now for the non-outbox local folders.
1547 * src/modest-init.h:
1548 * src/modest-init.c: Added modest_init_one_local_folder(), for
1549 setting up the directory structure for each local folder.
1551 * src/modest-local-folder-info.c:
1552 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1553 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1555 * src/modest-local-folder-info.h:
1556 * src/modest-tny-account-store.c: (on_account_removed),
1557 (on_account_changed), (create_per_account_local_outbox_folders),
1558 (get_server_accounts), (modest_tny_account_store_get_accounts),
1559 (modest_tny_account_store_get_tny_account_by_account),
1560 (modest_tny_folder_store_is_virtual_local_folders):
1562 * src/modest-tny-account.h:
1563 * src/modest-tny-account.c:
1564 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1565 to create an on-disk per-account local outbox folder for each
1567 (create_per_account_local_outbox_folders): Create a local outbox folder
1568 for each transport account.
1569 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1570 for all local folders.
1572 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1573 instead of using g_object_get/set() directly. It is clearer.
1575 (modest_tny_folder_store_get_message_count),
1576 (modest_tny_folder_store_get_local_size
1577 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1578 because we now use these with non-acount folder stores.
1580 (modest_tny_account_get_special_folder),
1581 (modest_tny_account_new_from_server_account),
1582 (modest_tny_account_new_from_account):
1583 (recurse_folders): Adjust to the new outbox system.
1585 * src/modest-tny-folder.h:
1586 * src/modest-tny-folder.c:
1587 (modest_tny_folder_is_local_folder),
1588 (modest_tny_folder_get_local_folder_type),
1589 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1591 * src/widgets/modest-main-window.h:
1592 * src/maemo/modest-main-window.c: (create_details_widget),
1593 (modest_main_window_set_contents_style): Show details for any folder store,
1596 (modest_tny_folder_get_rules):
1597 Remove the const. C does not support constness enough for this.
1599 * src/modest-ui-actions.c:
1600 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1601 make all outboxes appear as one, in the usual local-folders tree node.
1603 (set_active_account_from_tny_account),
1604 (modest_ui_actions_on_folder_selection_changed):
1605 * src/widgets/modest-folder-view.c: (text_cell_data),
1606 (icon_cell_data), (filter_row),
1607 (add_account_folders_to_merged_folder),
1608 (add_account_folders_to_simple_folder_store), (),
1609 (get_cmp_rows_type_pos), (cmp_rows),
1610 (modest_folder_view_set_account_id_of_visible_server_account):
1611 Adjust to the new outbox system, using generic folder stores and folders
1612 in the GtkTreeModel.
1614 2007-05-23 Christian Kellner <ckellner@openismus.com>
1616 * src/modest-mail-operation.c:
1617 (modest_mail_operation_update_account):
1618 Use info->max_size instead of unintialized local var [small
1619 build fix]. (Added TODO to review that change since I don't
1622 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1624 * libmodest-dbus-client/libmodest-dbus-client.c:
1625 (libmodest_dbus_client_compose_mail): function added
1626 * src/dbus_api/modest-dbus-api.h:
1627 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1628 (on_compose_mail): Implementation of the SendAsMail functionality
1630 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1632 * src/modest-account-mgr.c:
1633 (modest_account_mgr_add_server_account): Set the secure-connection
1634 conf key for transport accounts as well as store accounts. I don't know
1635 why the if was there. For instance, this makes sure that we use SSL
1636 for the gmail preset from the easysetup wizard.
1638 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1640 * src/gnome/modest-main-window.c:
1641 (on_account_store_connecting_finished), (connect_signals):
1642 * src/maemo/modest-main-window.c:
1643 (on_account_store_connecting_finished), (connect_signals),
1644 (modest_main_window_new):
1645 Handle TnyAccountStore::connecting-finished instead of
1646 TnyDevice::connection-changed, because we cannot actually perform
1647 operations on accounts until TnyAccountStore has itself responded to
1648 the TnyDevice::connection-changed signal. This prevents a GError from
1650 Do not try to update at startup, because we (at least on scratchbox)
1651 already do an update at startup when the device goes online.
1652 This prevents a GError from tinymail.
1653 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1654 Added TODO about stopping simultaneous operations.
1656 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1659 * src/modest-mail-operation-queue.c:
1660 (modest_mail_operation_queue_remove):
1661 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1662 about where they happened.
1664 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-ui-actions.c:
1667 (modest_ui_actions_on_password_requested): Make sure that the remember
1668 output parameter is always TRUE.
1670 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1673 Show a OK/Cancel dialog if the error is a question, though we still do not
1674 know anything more about what we are asking the user.
1675 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1676 Fix an uninitialized variable (helper). This is a logic error, however.
1678 2007-05-21 Christian Kellner <ckellner@openismus.com>
1680 * src/modest-search.h:
1681 Correct bit shifting in the ModestSearchFlags enum.
1683 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1685 * src/modest-tny-account.c:
1686 (modest_tny_account_new_from_server_account): Do not use the lsub and
1687 check-all hard-coded IMAP options when using POP.
1689 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-tny-account.c:
1692 (modest_tny_account_new_from_server_account):
1693 Use NULL for the secure-auth method for POP when Password auth has been
1694 specified by the user, as we already do for IMAP. "auth=Login" causes
1695 an error from camel or the server.
1697 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1699 * src/maemo/modest-account-settings-dialog.c:
1700 (create_page_account_details),
1701 (modest_account_settings_dialog_set_account_name):
1702 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1703 for the leave-on-server checkbox, rathr than just the checkbox, when
1704 the protocol is not POP.
1706 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1708 * src/widgets/modest-account-view.c:
1709 * src/widgets/modest-account-view.h:
1710 Added modest_account_view_select_account() which will be useful later
1711 to asynchronously re-select the edited account.
1713 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1715 * src/maemo/modest-account-settings-dialog.c:
1716 (modest_account_settings_dialog_set_account_name):
1717 Automatically choose the port numbers based on the secure authentication
1718 methods, if they have not been chosen before.
1719 This fixes projects.maemo.org bug NB#56273 .
1721 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1723 * src/maemo/modest-main-window-ui.h:
1724 * src/modest-ui-actions.c:
1725 * src/modest-ui-actions.h:
1726 Connect the Tools/SMTP Servers menu item to
1727 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1728 SMTP servers dialog, as in the UI specification and saves changes when it
1729 is closed. This fixed projects.maemo.org bug NB#56305 .
1731 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1733 * src/maemo/modest-connection-specific-smtp-window.c:
1734 (modest_connection_specific_smtp_window_init):
1735 Use gtk_window_set_default_size() to make this window big enough, so
1736 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1738 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1740 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1742 (modest_connection_specific_smtp_edit_window_init),
1743 Do not try to connect to a combobox signal before the combobox exists.
1744 This fixes the cras in projects.maemo.org bug NB#56288 .
1745 (modest_connection_specific_smtp_edit_window_get_settings):
1746 Remove the server_account_name parameter which was being checked for NULL
1747 though it was not used.
1749 * src/maemo/modest-connection-specific-smtp-window.c:
1750 (modest_connection_specific_smtp_window_fill_with_connections),
1751 (on_button_edit), (modest_connection_specific_smtp_window_init):
1752 Correct the number of treemodel columns to prevent a warning.
1753 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1754 libconic does not work.
1756 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1758 * src/modest-tny-account.c:
1759 (modest_tny_account_new_from_server_account):
1760 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1761 SMTP when "None" was chosen by the user. However, with my SMTP server that
1762 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1765 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1767 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1768 to explain the memory management issue with the ID in the ModestPair.
1770 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1771 (add_sending_page), (modest_account_assistant_finalize):
1772 * src/gnome/modest-gnome-global-settings-dialog.c:
1773 (create_updating_page), (create_composing_page):
1774 * src/gnome/modest-msg-edit-window.c: (get_transports),
1775 (init_window), (modest_msg_edit_window_finalize),
1776 (modest_msg_edit_window_get_msg_data):
1777 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1778 * src/gnome/modest-transport-widget.c:
1779 (modest_transport_widget_finalize), (smtp_configuration):
1780 * src/maemo/modest-maemo-global-settings-dialog.c:
1781 (create_updating_page), (create_composing_page):
1782 * src/maemo/modest-msg-edit-window.c: (get_transports),
1783 (init_window), (modest_msg_edit_window_finalize),
1784 (modest_msg_edit_window_get_msg_data),
1785 (modest_msg_edit_window_free_msg_data):
1786 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1787 (modest_store_widget_finalize):
1788 * src/maemo/modest-transport-widget.c:
1789 (modest_transport_widget_finalize), (smtp_configuration):
1790 * src/modest-main.c: (send_mail):
1791 * src/widgets/modest-combo-box.h:
1792 * src/widgets/modest-global-settings-dialog-priv.h:
1793 * src/widgets/modest-global-settings-dialog.c:
1794 (modest_global_settings_dialog_finalize):
1795 * src/widgets/modest-msg-edit-window.h:
1796 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1797 as long as the combo box, to prevent use of freed memory for the ID.
1799 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1802 get_accounts(), to make this clearer. Do not check for the enabled gconf
1803 key, because we do not use this for server accounts (at least, not yet).
1804 This allows us to send email again.
1806 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/modest-platform.c:
1809 (on_modest_conf_update_interval_changed), (modest_platform_init):
1810 Only respond to this particular key change. All these strcmp()s cannot be
1813 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/modest-maemo-global-settings-dialog.c:
1816 (current_connection): Prevent a crash in scratchbox when
1817 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1818 * src/maemo/modest-platform.c:
1819 (on_modest_conf_update_interval_changed), (modest_platform_init):
1820 Get the update interval from gconf and reset it when the gconf key changes.
1822 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-protocol-info.c:
1825 * src/modest-protocol-info.h: Adde enum-specific get functions,
1826 instead of using a ModestProtocolType enum parameter.
1828 * src/gnome/modest-account-assistant.c:
1829 * src/gnome/modest-store-widget.c:
1830 * src/gnome/modest-store-widget.h:
1831 * src/gnome/modest-transport-widget.c:
1832 * src/gnome/modest-transport-widget.h:
1833 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1834 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1835 * src/maemo/easysetup/modest-easysetup-wizard.c:
1836 * src/maemo/modest-account-settings-dialog.c:
1837 * src/maemo/modest-account-settings-dialog.h:
1838 * src/maemo/modest-store-widget.c:
1839 * src/maemo/modest-store-widget.h:
1840 * src/maemo/modest-transport-widget.c:
1841 * src/maemo/modest-transport-widget.h:
1842 * src/modest-account-mgr-helpers.c:
1843 * src/modest-account-mgr-helpers.h:
1844 * src/modest-account-mgr.c:
1845 * src/modest-account-mgr.h:
1846 * src/modest-tny-account.c:
1847 * src/modest-tny-folder.c:
1848 * src/widgets/modest-account-view.c:
1849 * src/widgets/modest-retrieve-combo-box.c:
1850 * src/widgets/modest-retrieve-combo-box.h:
1851 * src/widgets/modest-secureauth-combo-box.c:
1852 * src/widgets/modest-serversecurity-combo-box.c:
1853 * src/widgets/modest-serversecurity-combo-box.h:
1854 * tests/check_account-mgr.c:
1855 Use the specific functions, and use the re-renamed enum values for GNOME too.
1857 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1859 * src/modest-pair.h:
1860 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1861 so we can get the second based on the first.
1863 * src/maemo/modest-account-settings-dialog.h:
1864 * src/maemo/modest-account-settings-dialog.c:
1865 Added get_supported_secure_authentication_methods(), though it is mostly
1866 commented-out for now until the necessary API is committed to tinymail.
1867 (modest_account_settings_dialog_set_account_name),
1868 (save_configuration): Request the supported authentication methods from the
1869 server, so we can choose a working method.
1871 * src/modest-tny-account-store.h:
1872 * src/modest-tny-account-store.c:
1873 (modest_tny_account_store_get_session): Rename from
1874 tny_account_store_get_session().
1876 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1878 * src/modest-protocol-info.h: Split the ModestProtocol enum
1879 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1880 There was no need to have these unrelated values in one enum.
1882 * src/: many files: Adapted to changed enum. This makes the code a bit
1883 clearer, and the compiler could catch some errors.
1885 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1887 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1888 Show the detailed internal camel error message when an error happens
1889 during the configuration, so that our testers can give us more clues.
1890 For instance, in projects.maemo.org bug NB#56910 .
1892 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-tny-account.c:
1895 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1896 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1898 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1900 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1901 * src/maemo/modest-account-settings-dialog.c:
1902 (modest_account_settings_dialog_set_account_name),
1903 (save_configuration): For the incoming secure authentication checkbox,
1904 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1905 the UI specification. PLAIN does not seem to be supported for most IMAP
1906 servers anyway, and I am not sure what it would mean.
1907 However, we probably need to discover which of the secure-authentication
1908 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1909 * src/modest-account-mgr-helpers.c:
1910 (modest_account_mgr_get_server_account_data):
1912 * src/modest-tny-account.c:
1913 (modest_tny_account_new_from_server_account):
1914 Use tny_account_set_mech() to set secure-authentication methods,
1915 with some special-casing for IMAP, based on my observations of how
1918 * src/modest-account-mgr-helpers.h:
1919 * src/modest-account-mgr.c:
1920 * src/modest-defs.h: Comment that the URI is only used for local folders.
1922 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1924 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1925 parameter const, just to be neat.
1926 * src/modest-text-utils.c: (modest_text_utils_inline):
1927 End g_strconcat() with NULL, as its documentation says. This is almost
1928 certainly the cause of my crash at startup on the device. Interestingly,
1929 valgrind doesn't tell us about these errors.
1931 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1933 * scripts/build-packages: Added more precise comments about how to use
1934 this script, though I still get this error:
1935 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1936 error building tinymail
1938 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1940 * src/maemo/modest-main-window.c: (on_account_update):
1941 Very slight cleanup, hoping to make it simpler to discover what causes
1942 a crash here sometimes.
1944 * src/modest-tny-account.c:
1945 (modest_tny_account_new_from_server_account): Set the port. Added
1946 comments about the options and a TODO comment because I need to find out
1947 how to specify the secure authentication method.
1949 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1951 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1952 changed CFlags paths form modest to libmodest
1954 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1956 * src/modest-account-mgr-helpers.c:
1957 (modest_account_mgr_get_server_account_data),
1958 (modest_account_mgr_free_server_account_data):
1959 * src/modest-account-mgr-helpers.h:
1960 * src/modest-account-mgr.c:
1961 (modest_account_mgr_add_server_account):
1962 * src/modest-defs.h:
1963 * src/modest-tny-account.c:
1964 (modest_tny_account_new_from_server_account):
1965 Determine the options for tny_camel_account_add_option() here,
1966 based on the settings, rather than storing them directly in gconf.
1968 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1971 Show a more friendly error dialog now that we expect (from the tinymail
1972 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1974 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1976 * src/maemo/modest-main-window.c: (on_account_update): Check that
1977 account_name is not NULL, to prevent a crash at startup that I am
1978 seeing on the N800. I do wonder why it is NULL.
1980 * src/maemo/easysetup/modest-easysetup-wizard.c:
1981 (create_page_user_details):
1982 * src/maemo/modest-account-settings-dialog.c:
1983 (create_page_user_details), (create_page_outgoing):
1984 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1985 (modest_connection_specific_smtp_edit_window_init):
1986 * src/modest-ui-actions.c:
1987 (modest_ui_actions_on_password_requested):
1988 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1989 might do something useful with the on-screen keyboard.
1991 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1993 * src/maemo/modest-main-window.c: (on_account_update):
1994 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1995 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1997 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1999 * src/modest-tny-account-store.c: (on_account_changed):
2000 Correct the signature of this signal handler.
2002 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2004 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2005 Show a HildonNote instead of a GtkDialog for Maemo.
2007 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2009 * src/widgets/modest-account-view.h:
2010 * src/widgets/modest-account-view.c: (on_account_changed),
2011 (on_account_removed). Added a boolean flag, set/unset by
2012 modest_account_view_block_conf_updates(),
2013 modest_account_view_unblock_conf_updates() to prevent unnecessary
2014 updates, but this is not very useful because the gconf notifications are
2015 so delays (maybe only on Maemo Bora).
2016 So auto-updating is turned off, and these functions do an explicit
2017 update when necessary.
2018 However, something else is still doing too much work when adding/removing
2019 accounts, probably in another part of the application.
2021 * src/maemo/modest-account-view-window.c:
2022 (on_delete_button_clicked), (on_edit_button_clicked),
2023 (on_new_button_clicked): Use the new functions.
2025 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2027 * src/modest-account-mgr-helpers.c:
2028 (modest_account_mgr_set_first_account_as_default):
2029 Sort the list of names alphabetically-by-title, so we choose the first one
2031 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2032 alphabetically by the title.
2034 This fixes projects.maemo.org bug NB#56418 .
2036 * src/modest-account-mgr-priv.c:
2037 (_modest_account_mgr_account_from_key):
2038 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2039 avoid a valgrind error, and possible random behaviour.
2041 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2043 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2044 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2045 tinymail documentation to say that this can be expected.
2046 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2047 pretty, and should not happen, but I would prefer to know when it does.
2049 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2051 * configure.ac: When using the older hildon version, probably on Bora,
2052 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2054 * src/widgets/modest-attachment-view.c:
2055 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2058 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2060 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2061 Implemented the prototype. Can be tested with
2062 tests/dbus_api/test_open_message:
2064 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2066 * src/modest-tny-account-store.c:
2067 (modest_tny_account_store_instance_init), (get_password):
2068 * src/modest-ui-actions.c:
2069 (modest_ui_actions_on_password_requested):
2070 Do not store the password in gconf, because this function is called
2071 for non-remembered passwords. Actually use the cached (in the hash map)
2072 password instead of releasing it.
2073 The password will now not be remembered if it is asked via the protected
2074 password dialog, as per the UI spec.
2076 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2078 * src/modest-defs.h:
2079 * src/modest-account-mgr-helpers.h:
2080 * src/modest-account-mgr-helpers.c:
2081 Added modest_server_account_get_username_has_succeeded(),
2082 modest_server_account_set_username_has_succeeded().
2083 (modest_server_account_set_username),
2084 Reset the has-succeeded flag if the username changes.
2086 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2087 * src/maemo/modest-connection-specific-smtp-window.c:
2088 (modest_connection_specific_smtp_window_save_server_accounts):
2089 Use modest_server_account_set_username() instead of using
2090 modest_conf_set_string() directly, so that the has-succeeded flag is always
2093 * src/modest-ui-actions.c:
2094 (modest_ui_actions_on_password_requested): Dim the username entry if
2095 the username has ever worked, as per the UI spec.
2097 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2099 * src/modest-tny-account-store.c: (get_password):
2100 * src/modest-ui-actions.c:
2101 (modest_ui_actions_on_password_requested):
2102 Allow the username to be changed too, though there is more work to
2103 be done on exactly how this behaves.
2105 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-account-mgr-helpers.h:
2108 * src/modest-account-mgr-helpers.c:
2109 Added modest_account_mgr_get_display_name(),
2110 modest_server_account_get_username(),
2111 modest_server_account_set_username(),
2112 modest_server_account_set_password(),
2113 modest_server_account_get_hostname() functions so we do not need to
2114 use the conf API directly.
2116 * src/maemo/modest-main-window.c: (connect_signals):
2117 Actually connect ot the ModestAccountStore::request-password signal,
2118 so that we show the dialog when the password is requested by Tinymail,
2119 for isntance if it is empty.
2121 * src/modest-marshal.list:
2122 * src/modest-tny-account-store.c:
2123 (modest_tny_account_store_class_init), (get_password),
2124 (modest_tny_account_store_alert):
2125 * src/modest-tny-account-store.h:
2126 * src/modest-ui-actions.h:
2127 * src/modest-ui-actions.c:
2128 (modest_ui_actions_on_password_requested):
2129 Change the signal parameters, so it is obvious that we are providing
2130 the non human-readable server name, and receiving both the username
2131 and password, though changing of the username is not yet implemented.
2132 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2133 for the GNOME version.
2135 This should fix the projects.maemo.org bug NB#56209, though it does not
2136 work on Bora, because the gconf_client_get() for the password fails
2137 immediately after we save it with gconf_client_set().
2139 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2142 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2143 caused an undefined symbol error:
2144 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2146 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account-store.c:
2149 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2150 using a GError instead of a string message, so we can translate it in
2153 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2155 * src/maemo/modest-address-book.c:
2156 (modest_address_book_check_names):
2157 * src/maemo/modest-msg-view-window.c:
2158 (modest_msg_view_window_clipboard_owner_change):
2159 * src/modest-init.c: (modest_init_init_ui):
2160 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2161 (update_folders_cb), (modest_mail_operation_update_account):
2162 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2163 (modest_ui_actions_on_msg_attachment_clicked),
2164 (modest_ui_actions_on_msg_recpt_activated):
2165 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2166 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2167 (modest_msg_view_search_next):
2168 * src/widgets/modest-recpt-editor.c:
2169 (modest_recpt_editor_on_button_release_event),
2170 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2171 g_message(). At this point we should only be seeing interesting errors on
2172 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2174 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2176 (modest_wizard_dialog_force_title_update):
2177 * src/maemo/easysetup/modest-wizard-dialog.h:
2178 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2179 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2180 can update the title when appropriate. Otherwise the title is wrong if the
2181 pages are added after adding the notebook to the dialog.
2182 This must be a problem in HildonWizardDialog too.
2183 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2185 * src/maemo/easysetup/modest-easysetup-wizard.c:
2186 (create_subsequent_customsetup_pages),
2187 (create_subsequent_easysetup_pages):
2188 Call modest_wizard_dialog_force_title_update() so that the title is
2189 correct even with GTK+ < 2.10.
2190 This fixes projects.maemo.org bug NB#56145 .
2192 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/modest-platform.c:
2195 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2196 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2199 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2201 * src/widgets/modest-window.h:
2202 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2203 and modest_window_save_state(), which invokes it.
2205 * src/widgets/modest-window-mgr.h:
2206 * src/widgets/modest-window-mgr.c:
2207 Added modest_window_mgr_save_state_for_all_windows(), which calls
2208 the save_state vfunc on all registered windows, if implemented.
2210 * src/gnome/modest-msg-edit-window.c:
2211 * src/gnome/modest-msg-view-window.c:
2212 * src/maemo/modest-msg-edit-window.c:
2213 * src/maemo/modest-msg-view-window.c:
2214 * src/maemo/modest-main-window.c:
2215 Specify the existing save_settings functions as implementations of
2216 ModestWindow::save_state_func().
2218 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2219 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2220 enabling hibernation, for instance.
2222 We may need to do the same thing for restoring settings.
2225 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2227 * src/widgets/modest-window-mgr.c:
2228 * src/widgets/modest-window-mgr.h:
2229 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2230 modest_window_mgr_get_hibernation_is_prevented().
2232 * src/maemo/modest-main-window.c:
2233 (on_hildon_program_is_topmost_notify): Prevent hibernation
2234 (possible when the application goes to the background in the WM),
2235 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2237 * src/maemo/easysetup/modest-easysetup-wizard.c:
2238 (modest_easysetup_wizard_dialog_init):
2239 * src/maemo/modest-account-settings-dialog.c:
2240 (modest_account_settings_dialog_init):
2241 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2242 (modest_connection_specific_smtp_edit_window_init):
2243 * src/maemo/modest-connection-specific-smtp-window.c:
2244 (modest_connection_specific_smtp_window_init):
2245 * src/maemo/modest-signature-editor-dialog.c:
2246 (modest_signature_editor_dialog_init):
2247 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2248 prevent hibernation while any of these account settings dialogs are open.
2250 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2252 * src/maemo/Makefile.am:
2253 * src/maemo/modest-osso-state-saving.c:
2254 * src/maemo/modest-osso-state-saving.h: Added
2255 modest_osso_load_state() and modest_osso_save_state() though they do
2256 nothing now. They should iterate through all the open windows and load/save
2258 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2259 save state when closing.
2261 * src/maemo/modest-main-window.c:
2262 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2263 Add a notification handler for the HildonProgram::is-topmost property,
2264 so we can allow hibernation when the application goes into the background.
2265 But we still need to detect when the accounts setup windows are open so
2266 we can stop hibernation when they are open.
2267 To do this, I also added the main window the HildonProgram. This might have
2268 other side-effects/benefits, and should maybe be done for other windows.
2270 * src/maemo/modest-osso-autosave-callbacks.h:
2271 * src/maemo/modest-osso-autosave-callbacks.c:
2272 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2273 though it does not do anything yet, and we might never need this to do
2274 anything. For instance, we already save drafts.
2276 * src/maemo/modest-platform.c: (modest_platform_init):
2277 Specify the libosso auto-save callback.
2279 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/modest-platform.c:
2282 (modest_platform_set_update_interval):
2283 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2284 aparently stays valid between application instances, so we can use this
2285 to remove and reset it later. According to a maemo-developers email from
2288 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2290 * configure.ac: Depend on libalarm for Maemo.
2292 * src/dbus_api/modest-dbus-api.h:
2293 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2294 (on_send_receive), (modest_dbus_req_handler):
2295 Handle a SEND_RECEIVE D-Bus method.
2297 * libmodest-dbus-client/libmodest-dbus-client.c:
2298 (libmodest_dbus_client_send_and_receive):
2299 * libmodest-dbus-client/libmodest-dbus-client.h:
2300 Add C convenience functions for calling the new D-Bus method.
2302 * src/modest-platform.h:
2303 * src/gnome/modest-platform.c:
2304 * src/maemo/modest-platform.c:
2305 Added modest_platform_set_update_interval(), which uses the
2306 alarmd API on Maemo.
2307 (modest_platform_init),
2308 Call modest_platform_set_update_interval(), using a hard-coded
2309 interval for now (until the global settings dialog is implemented),
2310 though I am not sure that this makes sense yet.
2312 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2314 * src/dbus_api/modest-dbus-callbacks.c:
2315 (modest_osso_cb_hw_state_handler):
2316 * src/dbus_api/modest-dbus-callbacks.h:
2317 * src/maemo/modest-platform.c: (modest_platform_init):
2318 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2319 in case this has some effect on the ability for Maemo to ping the
2322 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2324 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2325 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2326 warning. It is probably a logic error, but I need to fix the build.
2328 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2330 * src/modest-account-mgr.h:
2331 * src/modest-account-mgr.c:
2332 (modest_account_mgr_account_names): Add a gboolean enabled_only
2333 parameter, so we can get lists of onlt the enabled accounts.
2335 (modest_account_mgr_add_account),,
2336 (modest_account_mgr_account_with_display_name_exists):
2337 * src/maemo/modest-msg-edit-window.c: (get_transports):
2338 * src/modest-account-mgr-helpers.c:
2339 (modest_account_mgr_set_first_account_as_default):
2340 * src/modest-init.c: (init_default_account_maybe):
2341 * src/modest-tny-account-store.c: (get_accounts):
2342 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2343 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2344 * tests/check_account-mgr.c: (START_TEST):
2345 Provide the extra parameter, as appropriate.
2347 * src/widgets/modest-account-view.c: (update_account_view):
2348 Do not show disabled accounts (meaning that there is no way to
2349 enable/disable accounts in the UI (the feature is not in our UI
2350 specification), so we can use this internally only to mark unfinished
2351 or temporary account data.
2353 * src/maemo/easysetup/modest-easysetup-wizard.c:
2354 (create_account): Add boolean enable parameter, so we can specify FALSE
2355 to create the temporary account.
2356 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2357 (on_before_next): When finishing, when there is a temporary account, just
2359 Also, use a timeout to delay the showing of the dialog until gconf is likely
2360 to return correct information, due to a maemo gconf bug that is fixed in
2361 osso 1.1, but not yet in Bora.
2362 However, the dialog stays on screen after it is destroyed.
2364 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2365 for invalid data when cancelling. Use a hildon note instead of a dialog
2366 to complain about invalid data. Do not show the account-saved note if the
2367 account is disabled (a temporary account that will not really be saved for use
2370 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2372 * src/modest-account-mgr-helpers.h:
2373 * src/modest-account-mgr-helpers.c:
2374 Added modest_account_mgr_unset_default_account(),
2375 Added modest_account_mgr_set_first_account_as_default().
2377 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2378 If it was the default account, unset the default account name.
2380 * src/maemo/modest-account-view-window.c:
2381 (on_delete_button_clicked): If it was the default account,
2382 set the first remaining account as the default instead.
2384 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2385 a NULL account or a NULL default account, to prevent a crash. This should
2386 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2389 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2391 * src/widgets/modest-recpt-editor.c:
2392 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2393 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2394 TODO comment for this. This fixes the build.
2396 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2397 be the best place for it. This will in future update all auto-update accounts,
2398 rather than just the current/default account, when that gconf key exists.
2399 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2400 if there are no accounts, before calling do_send_receive().
2401 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2403 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2404 * src/maemo/modest-main-window-ui.h:
2405 * src/maemo/modest-main-window.c: (on_connection_changed),
2406 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2407 directly, becaue the signal handler does more.
2409 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2411 * src/modest-account-mgr-helpers.c:
2412 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2413 for the case that the account does not exist.
2415 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2416 (equivalent to the modest account name) rather than the tinymail account name
2417 (equivalent to the modest account title - human readable) to get the account data.
2418 Check for null account data to prevent the crash, and add a TODO comment saying that
2419 this needs fixing because it is using the server account name instead of the account name.
2421 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2424 * src/maemo/modest-account-settings-dialog.c: (show_error),
2426 Use hildon_note_new_information() for informative and error messages,
2427 which seems to be expected for Maemo applications (no documentation that I know of
2428 says this). I am surprised that there is no distinction between info and error
2431 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2433 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2434 it is easy to find where this is used.
2436 * src/maemo/easysetup/modest-easysetup-wizard.c:
2437 (create_page_welcome), (create_page_account_details),
2438 (create_page_user_details), (create_page_complete_easysetup),
2439 (create_page_custom_incoming), (create_page_custom_outgoing),
2440 (create_page_complete_custom):
2441 * src/maemo/modest-account-settings-dialog.c:
2442 (create_page_account_details), (create_page_user_details),
2443 (create_page_incoming), (create_page_outgoing):
2444 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2445 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2446 (modest_connection_specific_smtp_edit_window_init):
2447 * src/maemo/modest-connection-specific-smtp-window.c:
2448 (modest_connection_specific_smtp_window_init):
2449 * src/maemo/modest-signature-editor-dialog.c:
2450 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2451 and scrolling policy as per the Email Application Layout Guide, if I have
2454 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2456 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2457 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2458 which were empty, because these vfuncs have been removed from TnyAccountStore.
2459 This fixes the build.
2461 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2463 * src/maemo/modest-main-window.c:
2464 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2465 showing/hiding it. Added TODO because it probably should not be NULL.
2466 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2467 because unnecessary g_warnings() make degugging difficult.
2469 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2471 * src/maemo/modest-msg-edit-window.c:
2472 (modest_msg_edit_window_select_color),
2473 (modest_msg_edit_window_select_background_color): 2 const corrections and
2474 moving 2 #endifs before closing brackets, to fix the build.
2476 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2478 * src/maemo/easysetup/modest-easysetup-wizard.h:
2479 * src/maemo/easysetup/modest-easysetup-wizard.c:
2480 (modest_easysetup_wizard_dialog_finalize),
2481 (on_button_edit_advanced_settings), (create_page_complete_custom),
2482 (on_response), (create_account):
2483 Implement the Advanced Settings edit button, by saving the account information,
2484 for the Advanded Settings dialog to use directly from gconf, and removing it
2485 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2486 Bug #5533 in the projects.maemo.org bugzilla.
2488 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/modest-msg-view-window.c:
2491 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2492 when opening a message window.
2494 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2496 * src/maemo/easysetup/modest-easysetup-wizard.c:
2497 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2500 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2501 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2502 gconf settings. I probably added more checks than necessary, but that is safer.
2504 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2505 variable to fix the build, but this seems to be used when it is still NULL.
2507 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-platform.h:
2510 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2511 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2512 * src/modest-main.c: Implement this function so we can avoid using
2513 maemo-specific API from cross-platform code.
2515 * src/modest-tny-account-store.c:
2516 (get_smtp_specific_transport_account_for_open_connection):
2517 * src/modest-ui-actions.c: (check_for_connection),
2518 (modest_ui_actions_on_item_not_found):
2519 Use modest_platform_connect_and_wait() and put #idefs around other
2520 maemo-specific code, because only maemo currently has a way to
2521 identify connection names.
2523 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2525 * src/modest-tny-account-store.h:
2526 * src/modest-tny-account-store.c:
2527 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2528 the connection-specific SMTP server settings in the configuration.
2530 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2532 * src/maemo/modest-main-window.c: (on_connection_changed),
2534 * src/modest-main.c: (main), (start_ui), (send_mail):
2535 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2536 that is what is intended.
2538 * src/modest-ui-actions.c: (action_send), (action_receive),
2539 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2540 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2541 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2542 SMTP server is used when it is specified.
2544 (modest_ui_actions_on_send_receive):
2545 Check that a connection is open before proceeding.
2546 Receive and then send, instead of vice-versa, as per the specification.
2548 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2550 * src/modest-mail-operation.c:
2551 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2552 though I guess it should be something other than NULL.
2554 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/easysetup/modest-easysetup-wizard.c:
2557 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2558 combo twice, to avoid an g_warning and to make it visible again.
2559 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2560 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2561 (already intended) dereference when detaching, because we then recreate the menu.
2562 But I am not sure why the warning was happening, and it is possible that this is a memory
2565 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2567 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2568 and uri_parse_mailto() utility functions.
2569 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2571 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2573 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2575 * src/dbus_api/modest-dbus-api.h:
2576 * src/dbus_api/modest-dbus-callbacks.c:
2577 Use an idle callback to execute the modest code in the application's own thread.
2578 Remove the helloworld example method.
2579 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2580 parsed, and the open-message method is not implemented because this is not yet implemented in
2582 * libmodest-dbus-client/libmodest-dbus-client.c:
2583 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2584 (libmodest_dbus_client_open_message):
2585 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2587 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2588 body without crashing.
2590 * tests/dbus_api/Makefile.am:
2591 * tests/dbus_api/test_mail_to.c:
2592 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2594 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2596 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2597 Added file to fix the build. Sorry.
2599 * src/dbus_api/Makefile.am:
2600 * src/dbus_api/modest-dbus-api.h:
2601 * src/dbus_api/modest-dbus-callbacks.h:
2602 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2603 (modest_dbus_req_handler):
2604 Put constants in a separate header so it can be reused by the
2605 client library, without duplication
2607 * libmodest-dbus-client/Makefile.am:
2608 * libmodest-dbus-client/libmodest-dbus-client.c:
2609 (libmodest_dbus_client_call_helloworld),
2610 (libmodfest_dbus_client_send_mail),
2611 (libmodfest_dbus_client_mailto),
2612 (libmodfest_dbus_client_open_message):
2613 * libmodest-dbus-client/libmodest-dbus-client.h:
2614 (Partly) Implement a send_mail D-Bus method.
2616 * tests/dbus_api/Makefile.am:
2617 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2618 the send_email D-Bus method.
2620 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2624 * libmodest-dbus-client/Makefile.am:
2625 * libmodest-dbus-client/libmodest-dbus-client.c:
2626 * libmodest-dbus-client/libmodest-dbus-client.h:
2627 * tests/dbus_api/Makefile.am:
2628 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2629 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2631 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/easysetup/modest-easysetup-wizard.c:
2634 (create_page_account_details):
2635 * src/maemo/modest-account-settings-dialog.c:
2636 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2637 widgets, because this might not be the default in future versions of the Maemo GTK+.
2638 However, I can not not get capitalization to work even in a simple test case.
2640 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2642 * src/maemo/easysetup/modest-easysetup-wizard.c:
2643 (create_page_custom_incoming), (create_page_custom_outgoing):
2644 * src/maemo/modest-account-settings-dialog.c:
2645 (create_page_account_details), (create_page_incoming),
2646 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2647 instead of using gtk_check_button_with_label(), so they are aligned like the other
2648 widgets, as per the UI spec.
2650 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2652 * src/maemo/easysetup/modest-easysetup-wizard.c:
2653 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2654 * src/widgets/modest-validating-entry.c:
2655 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2656 Modest prefix instead of an EasySetup prefix.
2658 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2660 * src/widgets/modest-validating-entry.h:
2661 * src/widgets/modest-validating-entry.c: (on_insert_text),
2662 Added easysetup_validating_entry_set_max_func(), used to set a callback
2663 to call when the max number of characters is reached. GtkEntry has a max-length
2664 already but is silent about it.
2666 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2667 (create_page_account_details), (create_page_user_details),
2669 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2670 (create_page_account_details), (create_page_user_details),
2671 (create_page_outgoing):
2672 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2673 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2674 the UI spec, when the user tries to enter more than the max number of characters.
2676 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/easysetup/modest-easysetup-wizard.c:
2679 (create_page_user_details), (create_page_custom_incoming),
2680 (create_page_custom_outgoing):
2681 * src/maemo/modest-account-settings-dialog.c:
2682 (create_page_user_details), (create_page_incoming),
2683 (create_page_outgoing):
2684 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2685 (modest_connection_specific_smtp_edit_window_init):
2686 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2687 not appropriate. Bad Maemo-specific defaults!.
2689 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2691 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2692 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2693 (modest_signature_editor_dialog_set_settings):
2694 Disable the label and textview when the checkbox is disabled, and use the
2695 specified (UI spec) default signature text.
2697 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2700 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2702 * src/modest-defs.h:
2703 * src/modest-account-mgr-helpers.h:
2704 * src/modest-account-mgr-helpers.c:
2705 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2707 * src/maemo/Makefile.am:
2708 * src/maemo/modest-signature-editor-dialog.c:
2709 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2712 * src/maemo/modest-account-settings-dialog.h:
2713 * src/maemo/modest-account-settings-dialog.c:
2714 (modest_account_settings_dialog_finalize), (on_button_signature),
2715 (save_configuration): Use the new dialog when the Edit button is pressed, and
2716 save the changes if necessary, as per the UI spec.
2718 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2720 * src/maemo/Makefile.am:
2721 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2722 based on maemo-develoers email from Dirk.
2724 * src/maemo/easysetup/modest-easysetup-wizard.c:
2725 (create_page_welcome), (create_page_account_details),
2726 (create_page_user_details), (create_page_complete_easysetup),
2727 (create_page_custom_incoming), (create_page_custom_outgoing),
2728 (create_page_complete_custom),
2729 (modest_easysetup_wizard_dialog_init):
2730 * src/maemo/modest-account-settings-dialog.c:
2731 (create_page_account_details), (create_page_user_details),
2732 (create_page_incoming), (create_page_outgoing),
2733 (modest_account_settings_dialog_init):
2734 * src/maemo/modest-connection-specific-smtp-window.c:
2735 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2737 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2739 * src/maemo/easysetup/modest-easysetup-wizard.c:
2740 (create_page_account_details), (create_page_custom_outgoing),
2741 (create_page_complete_custom):
2742 * src/maemo/modest-account-settings-dialog.c:
2743 (create_page_user_details), (create_page_incoming),
2744 (create_page_outgoing):
2745 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2746 (modest_connection_specific_smtp_edit_window_init):
2747 Use the correct (UI spec) port min/max, and use horizontal separators,
2750 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/easysetup/modest-easysetup-wizard.c:
2753 (set_default_custom_servernames):
2754 * src/maemo/modest-account-settings-dialog.c:
2755 (create_page_incoming), (on_combo_outgoing_security_changed),
2756 (on_combo_incoming_security_changed), (create_page_outgoing),
2757 (modest_account_settings_dialog_set_account_name),
2758 (save_configuration):
2759 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2760 (on_combo_security_changed),
2761 (modest_connection_specific_smtp_edit_window_init),
2762 (modest_connection_specific_smtp_edit_window_set_connection),
2763 (modest_connection_specific_smtp_edit_window_get_settings):
2764 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2767 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2770 * src/maemo/easysetup/modest-easysetup-wizard.c:
2771 (create_page_custom_outgoing), (create_page_complete_custom):
2772 * src/maemo/modest-account-settings-dialog.c:
2773 (create_page_user_details), (create_page_outgoing):
2774 * src/maemo/modest-account-view-window.c: (button_box_new):
2775 Use changed logical IDs as per the most recent UI spec:
2776 mcen_bd_emailsetup_edit -> mcen_bd_edit
2777 mcen_bd_emailsetup_delete -> mcen_bd_delete
2778 mcen_bd_emailsetup_close -> mcen_bd_close
2780 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2784 * src/dbus_api/Makefile.am:
2785 * src/dbus_api/modest-dbus-callbacks.c:
2786 * src/dbus_api/modest-dbus-callbacks.h:
2787 * src/maemo/modest-platform.c: (modest_platform_init):
2788 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2790 * tests/Makefile.am:
2791 * tests/dbus_api/Makefile.am:
2792 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2794 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/modest-account-settings-dialog.c:
2797 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2798 Removed unnecessary includes.
2800 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/easysetup/modest-easysetup-wizard.c:
2803 * src/maemo/modest-account-settings-dialog.c:
2804 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2805 * src/widgets/Makefile.am:
2806 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2807 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2808 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2809 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2810 * src/widgets/modest-secureauth-combo-box.c:
2811 * src/widgets/modest-secureauth-combo-box.h:
2812 * src/widgets/modest-serversecurity-combo-box.c:
2813 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2814 made the GObject names more consistent with the rest of the Modest code.
2816 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2818 * src/maemo/easysetup/Makefile.am:
2819 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2820 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2821 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2822 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2823 * src/maemo/easysetup/modest-easysetup-wizard.c:
2824 * src/maemo/easysetup/modest-validating-entry.c:
2825 * src/maemo/easysetup/modest-validating-entry.h:
2826 * src/maemo/modest-account-settings-dialog.c:
2827 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2828 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2829 widgets/ because they are used outside of easysetup too. After checking in,
2830 svn will allow me to rename them too.
2832 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2834 * src/gnome/modest-msg-edit-window.c:
2835 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2836 linker error, to fix the build on the GNOME platform.
2837 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2838 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2839 ifdefed out to avoid a warning.
2841 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2843 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2844 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2845 some alternative for GTK+ 2.6.
2847 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2849 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2851 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2852 specified for EmailAccountsDialog in UI spec.
2854 * src/maemo/easysetup/modest-easysetup-wizard.c:
2855 * src/maemo/easysetup/modest-easysetup-wizard.h:
2856 * src/maemo/modest-account-settings-dialog.c:
2857 * src/maemo/modest-account-settings-dialog.h:
2858 Reuse a member window widget for the connection-specific SMTP server accounts,
2859 so we can tell it to create/save the accounts only if we actually save changes.
2861 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2862 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2863 (modest_connection_specific_smtp_edit_window_get_settings):
2864 Return a struct instance for temporarily remembering the entered data.
2866 * src/maemo/modest-connection-specific-smtp-window.h:
2867 * src/maemo/modest-connection-specific-smtp-window.c:
2868 (modest_connection_specific_smtp_window_finalize),
2869 (modest_connection_specific_smtp_window_fill_with_connections),
2871 (modest_connection_specific_smtp_window_save_server_accounts),
2872 (update_model_server_names): Do not actually save data until asked,
2873 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2875 (on_selection_changed),
2876 (modest_connection_specific_smtp_window_init): Disable the edit
2877 button when nothing is selected.
2879 * src/modest-account-mgr-helpers.c:
2880 * src/modest-account-mgr-helpers.h:
2881 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2884 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2886 * src/modest-account-mgr-helpers.h:
2887 * src/modest-account-mgr-helpers.c:
2888 (modest_account_mgr_get_unused_account_name),
2889 (modest_account_mgr_get_unused_account_display_name): Added these
2890 utility functions, to avoid code duplication.
2892 * src/maemo/easysetup/modest-easysetup-wizard.c:
2893 (create_page_account_details), (create_account):
2894 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2895 (on_combo_security_changed),
2896 (modest_connection_specific_smtp_edit_window_init),
2897 (modest_connection_specific_smtp_edit_window_save_settings):
2898 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2899 * src/maemo/modest-connection-specific-smtp-window.c:
2900 (modest_connection_specific_smtp_window_finalize),
2901 (modest_connection_specific_smtp_window_fill_with_connections),
2902 (on_button_edit), (modest_connection_specific_smtp_window_init):
2903 * src/maemo/modest-connection-specific-smtp-window.h:
2904 Implementing saving of connection-specific server accounts.
2906 But I need to refactor this so we can save the data for each
2907 possible connection-specific account and only actually create the server accounts
2908 when the easysetup finished, or the OK button is pressed on the account settings
2911 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2914 (on_combo_security_changed):
2915 (modest_connection_specific_smtp_edit_window_init):
2916 Auto-fill the port number as in the account settings.
2918 (modest_connection_specific_smtp_edit_window_set_connection):
2919 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2920 * src/maemo/modest-connection-specific-smtp-window.c:
2921 (fill_with_connections), (on_button_edit),
2922 (modest_connection_specific_smtp_window_init):
2923 Turn the edit window into a dialog to simplify the code, and
2924 set a WM hint as in a GtkDialog, because only a popup can be on top of
2925 another window in Maemo, and popups usually have no WM decoration.
2927 * src/modest-defs.h:
2928 * src/modest-account-mgr-helpers.c:
2929 (modest_account_mgr_set_connection_specific_smtp),
2930 (modest_account_mgr_remove_connection_specific_smtp),
2931 (modest_account_mgr_get_connection_specific_smtp):
2932 * src/modest-account-mgr-helpers.h: Some functions to write the
2933 connection-specific SMTP server information. Not yet used.
2936 * src/widgets/modest-folder-view.c: (text_cell_data):
2937 Fix a warning about an uninitialized variable.
2938 (on_configuration_key_changed): Put an #ifdef around the use
2939 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2941 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2943 * src/maemo/modest-account-settings-dialog.h:
2944 * src/maemo/modest-account-settings-dialog.c:
2945 Added connect_for_modified() utility function to mark the new modified boolean.
2947 (create_page_account_details), (create_page_user_details),
2948 (create_page_incoming), (create_page_outgoing), (on_response),
2949 (modest_account_settings_dialog_init),
2950 (modest_account_settings_dialog_set_account_name):
2951 Only warn about unsaved changes when there are actually unsaved changes.
2953 * src/modest-account-mgr-helpers.c:
2954 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2955 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2956 to get the data from there in future.
2958 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2960 * src/modest-defs.h:
2962 * src/modest-account-mgr-helpers.h:
2963 * src/modest-account-mgr-helpers.c:
2964 Store the security account setting in a single conf key instead of using
2965 the options list, so that the list is left for just the to-be-removed camel hack,
2966 and because gconf_client_set_list() is failing for some reason.
2968 * src/modest-account-mgr.c:
2969 (modest_account_mgr_add_server_account):
2970 * src/maemo/modest-account-settings-dialog.c:
2971 (modest_account_settings_dialog_set_account_name),
2972 (save_configuration): Use the renamed functions.
2975 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2977 * src/widgets/Makefile.am:
2978 * src/widgets/modest-limit-retrieve-combo-box.c:
2979 * src/widgets/modest-limit-retrieve-combo-box.h:
2980 * src/widgets/modest-retrieve-combo-box.c:
2981 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2982 the account settings dialog.
2984 * src/modest-defs.h:
2985 * src/modest-account-mgr-helpers.h:
2986 * src/modest-account-mgr-helpers.c:
2987 (modest_server_account_get_option_secure_auth),
2988 (modest_server_account_set_option_secure_auth):
2989 * src/modest-account-mgr.c:
2990 (modest_account_mgr_add_server_account):
2991 Use the existing AUTH_MECH conf key for the secure-auth setting,
2992 instead of putting it in the list options, because this was actually used already.
2994 * src/maemo/modest-account-settings-dialog.c:
2995 (create_page_account_details),
2996 (modest_account_settings_dialog_set_account_name),
2997 (save_configuration):
2998 * src/maemo/modest-account-settings-dialog.h:
2999 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3000 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3002 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3004 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3005 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3006 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3008 * src/modest-defs.h:
3009 * src/maemo/modest-account-settings-dialog.c:
3010 (create_page_incoming), (on_combo_outgoing_security_changed),
3011 (on_combo_incoming_security_changed), (create_page_outgoing),
3012 (modest_account_settings_dialog_set_account_name),
3013 (save_configuration): Load/Save the port number, and change it when the
3014 security combo changes, to suitable defaults.
3016 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3018 * src/modest-account-mgr.c:
3019 (modest_account_mgr_add_server_account): Set the security and secure-auth
3020 options, and add a comment saying that the other camel-specific options should be
3023 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3025 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3027 * src/modest-tny-account-store.c: (account_list_free),
3028 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3029 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3032 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3034 * src/modest-protocol-info.c:
3035 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3036 is required by our UI spec. Maybe something in our implementation will use this eventually.
3037 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3038 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3039 instead of the previous 0 placeholder.
3041 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3042 secure-auth settings.
3043 * src/modest-account-mgr-helpers.h:
3044 * src/modest-account-mgr-helpers.c:
3045 (modest_server_account_data_get_option_secure_auth),
3046 (modest_server_account_set_option_secure_auth),
3047 (modest_server_account_data_get_option_security),
3048 (modest_server_account_set_option_security): Added this API for getting and setting the security
3049 and secure-auth settings.
3051 * src/maemo/modest-account-settings-dialog.h:
3052 * src/maemo/modest-account-settings-dialog.c:
3053 (modest_account_settings_dialog_finalize), (check_data),
3054 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3055 about changing titles.
3056 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3057 (save_configuration): Save the security and secure-auth settings.
3059 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3060 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3062 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3064 * src/modest-defs.h:
3065 * src/modest-account-mgr.c:
3066 (modest_account_mgr_add_server_account):
3067 Added and used defines for the options key and value pair strings,
3068 that are used so far, though they do not seem to correspond to anything in our
3069 UI specs or ModestProtocol enum.
3071 * src/modest-account-mgr-helpers.h:
3072 * src/modest-account-mgr-helpers.c:
3073 (compare_option_strings_for_name),
3074 (modest_server_account_data_get_option_value),
3075 (modest_server_account_data_get_option_bool),
3076 (modest_account_mgr_get_server_account_option):
3077 Added helper functions for parsing the options GSList.
3079 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3081 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3082 display name is based on the supplied account name.
3083 * src/modest-account-mgr.c:
3084 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3085 with an inefficient, but good-enough, implementation.
3087 * src/maemo/easysetup/modest-easysetup-wizard.c:
3088 (create_page_account_details), (on_before_next), (create_account):
3089 Check for existing display names rather than (non-user-visible) account names, and just
3090 create and set a unique account name at the end.
3092 * src/maemo/modest-account-settings-dialog.c:
3093 (modest_account_settings_dialog_init),
3094 (modest_account_settings_dialog_set_account_name),
3095 (create_page_incoming): Show the display name, instead of the account name.
3096 (on_response): Do some (not all) extra checks, as in the UI spec.
3097 (save_configuration): Save the display name if it was changed.
3099 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3101 * po/en_GB.po: Added needed logical ID and translation.
3102 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3103 (init_view): Made the is-default column clicking work.
3105 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3108 * src/maemo/easysetup/Makefile.am:
3109 * src/maemo/easysetup/modest-easysetup-wizard.c:
3110 (modest_easysetup_wizard_dialog_init):
3111 * src/maemo/easysetup/provider-data-test.keyfile:
3112 * src/maemo/easysetup/provider-data.keyfile:
3113 Moved the provider data file to the new modest-providers-data package and used it from there.
3115 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3117 * src/modest-local-folder-info.c:
3118 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3119 N_() was already used on the static strings, but this just marks it for translation without
3120 using the translation.
3122 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3124 * src/maemo/modest-account-settings-dialog.c:
3125 (create_page_incoming),
3126 (modest_account_settings_dialog_set_account_name):
3127 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3128 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3129 I will do this if nobody else gets there first.
3131 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3133 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3134 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3135 save the security stuff.
3137 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3139 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3140 Set the email address and user fullname, which I now see must be
3143 * src/maemo/modest-account-settings-dialog.h:
3144 * src/maemo/modest-account-settings-dialog.c:
3146 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3147 leave-on-server and authentication.
3148 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3151 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3154 * src/maemo/modest-account-settings-dialog.c:
3155 * src/maemo/modest-account-settings-dialog.h:
3156 Most (but not all) of the widgets are now present as specified by the UI spec.
3157 No changes are yet saved, and some details are not properly shown yet.
3159 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3161 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3163 * src/maemo/Makefile.am:
3164 * src/maemo/modest-account-settings-dialog.c:
3165 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3166 an existing account. Doesn't do much yet.
3168 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3169 Open the accounts settings dialog when Edit is clicked.
3171 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3173 * src/maemo/easysetup/Makefile.am:
3174 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3176 * src/maemo/easysetup/modest-easysetup-wizard.c:
3177 (modest_easysetup_wizard_dialog_init):
3178 Try to get the source directory from the build system,
3179 instead of hard-coding "./" into the source code, when opening our local
3180 copies of the configuration files.
3181 But this still fails when opening the wizard from the Accounts window,
3182 maybe because the working directory seems to change at runtime.
3183 So the wizard will fail the second time unless you copy the files into their
3184 proper locations - see the stdout warnings for the paths.
3186 (create_page_account_details),(on_before_next):
3187 Check for existing non-server accounts instead of server accounts,
3188 so the default account name is useful again, and to prevent trying to
3191 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3192 Show the wizard when New is clicked.
3194 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3195 (init_view): Show the column headers, and show the columns that are
3196 specified in the UI specs. However, something in Maemo's GTK+ prevents
3197 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3198 change the default account. This is despite unsetting the special properties.
3200 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3202 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3203 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3204 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3205 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3206 to make that clearer.
3207 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3209 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/modest-account-view-window.c:
3212 (modest_account_view_window_init),
3213 (modest_account_view_window_new):
3214 Use the same buttons as specified in the
3215 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3216 the existing widgets, which never had a chance of working.
3217 Put the ModestAccountView treeview in a scrolled window.
3218 Do not repeat the initialization in both _init() and _new().
3220 * src/widgets/modest-account-view.c: (update_account_view):
3221 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3222 this widget and window shows no accounts.
3224 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3226 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3228 * src/maemo/easysetup/modest-easysetup-wizard.c:
3229 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3230 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3231 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3234 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3235 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3236 accounts exist yet, as in the UI spec.
3238 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3240 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/Makefile.am:
3243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3244 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3245 New window for editing connection-specific smtp details.
3246 Not fully implemented.
3248 * src/maemo/modest-connection-specific-smtp-window.c:
3249 (modest_connection_specific_smtp_window_finalize) :
3250 unref the tree model.
3251 (on_button_edit): Show the edit window.
3253 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3255 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3258 * src/maemo/Makefile.am:
3259 * src/maemo/modest-connection-specific-smtp-window.c:
3260 * src/maemo/modest-connection-specific-smtp-window.h:
3261 New window for showing the list of connections, for connection-specific
3262 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3263 * src/maemo/easysetup/modest-easysetup-wizard.c:
3264 (create_page_custom_outgoing): Show the new window when the button is clicked.
3266 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3268 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3269 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3270 * src/maemo/modest-msg-edit-window.c:
3271 (modest_msg_edit_window_insert_image):
3272 * src/modest-conf.c: (modest_conf_key_escape):
3273 * src/modest-mail-operation.c:
3274 (modest_mail_operation_send_new_mail):
3275 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3276 (modest_ui_actions_on_new_account):
3277 * src/widgets/modest-attachment-view.c: (update_filename_request):
3278 * src/widgets/modest-mail-header-view.c:
3279 Corrected warnings that were breaking the build, by commenting out unused variables,
3280 and a function, and by including a header.
3282 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3284 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3285 so we can #ifdef around platform-specific code when necessary.
3286 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3287 to allow this to build for the GNOME platform too.
3289 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/easysetup/modest-easysetup-wizard.c:
3292 Added util_increment_name() and used it in create_page_account_details()
3293 to make sure that the default account name is always a new name.
3295 (modest_easysetup_wizard_dialog_init),
3296 (set_default_custom_servernames): Some minor memory management fixes.
3298 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3302 * src/modest-runtime.c: (init_i18n): Restored the translation
3303 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3304 are defined in config.h, and the translations are installed.
3306 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3307 is defined for translation.
3309 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3311 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3313 * src/maemo/easysetup/modest-easysetup-wizard.c:
3314 (modest_easysetup_wizard_dialog_init):
3315 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3316 Use realistic paths (though they should use $prefix generically) to the
3317 mcc_mapping and provider-data.keyfile files which might work when they
3318 are installed by the future version of the operator-wizard package,
3319 and then fallback to paths in our source code, with an explanatory
3322 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3326 * src/maemo/Makefile.am:
3327 * src/maemo/easysetup/: Added files from the previously-exernal
3328 osso-modest-easysetup.
3329 * src/maemo/modest-main-window-ui.h:
3330 * src/modest-ui-actions.c:
3331 * src/modest-ui-actions.h:
3332 Added modest_ui_actions_on_new_account() as a signal handler for the
3333 New Account menu item. It shows the easysetup wizard.
3334 * po/en_GB.po: Added additional needed logical IDs and translations.