2007-06-08 Murray Cumming <murrayc@murrayc.com>

[modest] / ChangeLog2

2007-06-08  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
        (modest_tny_send_queue_class_init):
        Do not use the priv struct because it is empty, to avoid g_warnings 
        about a non-existant priv struct.
        
        * src/modest-tny-account-store.c:
        (modest_tny_account_store_get_server_account),
        (modest_tny_account_store_get_transport_account_for_open_connection
        ): Do not try to get transport server accounts for local folders, 
        because they don't have any. This avoids a g_warning().
        
        * src/maemo/modest-main-window.c:
        (modest_main_window_notify_send_receive_initied),
        (on_configuration_key_changed):
        * src/maemo/modest-msg-edit-window.c: (on_delete_event):
        * src/modest-defs.h:
        * src/modest-mail-operation.c:
        (modest_mail_operation_update_account):
        * src/modest-tny-account-store.h:
        * src/modest-tny-account.c:
        (modest_tny_account_get_special_folder),
        (modest_tny_account_new_for_local_folders),
        (modest_tny_account_new_for_per_account_local_outbox_folder):
        * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
        * src/modest-tny-local-folders-account.c:
        (add_account_folders_to_merged_folder):
        * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
        (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
        (modest_ui_actions_on_send):
        * src/widgets/modest-folder-view.c: (update_model):
        Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to 
        MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename 
        modest_tny_account_store_get_tny_account_by_account() to 
        modest_tny_account_store_get_server_account() to make the code clearer.

2007-06-07  Marcus Bauer  <marcusb@openismus.com>

        * src/dbus_api/modest-dbus-api.h:
        changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
        * src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_attach_file_noninteractive):
        added g_warning in case the file to be attached does not exist
        * tests/dbus_api/test_compose_mail.c: (main):
        removed obsolete comment, added generic files as test case

2007-06-07  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (get_server_accounts): 
        Create the local folders account only once, not once for each outbox, and 
        not only when there are some outboxes.

2007-06-07  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-folder-view.c: (update_model): Comment out some 
        code that is causing a crash at startup. Sergio says that he is fixing this.

2007-06-07  Johannes Schmid <johannes.schmid@openismus.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_outgoing),
        (modest_account_settings_dialog_set_account_name),
        (save_configuration):
        - Fixed handling of the "Use secure authentication" toggle to comply with
        the ui specification. See also projects.maemo.org bug NB#58400
        
        - Restore the Secure connection setting combo correctly when loading
        the settings dialog
        
        * src/maemo/modest-maemo-utils.c:
        (on_camel_account_get_supported_secure_authentication),
        (modest_maemo_utils_get_supported_secure_authentication_methods):
        Fixed a crasher if operation is canceled
        
        * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
        (modest_protocol_info_auth_is_secure):
        * src/modest-protocol-info.h:
        
        Added two new methods to determine if a protocol/auth method is secure/encrypted in 
        the sense of the "Use secure authentication" toggle.

2007-06-07  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.h:
        * src/modest-tny-account-store.c:
        Added modest_tny_account_store_get_local_folders_account().
        
        * src/modest-tny-folder.h:
        * src/modest-tny-folder.c:
        (modest_tny_folder_get_account):
        Added this replacement for tny_folder_get_account() which returns 
        the local-folders account for TnyMergeFolders, to avoid the 
        warning about the unimplemented get_account_func() vfunc().
        
        (modest_tny_folder_get_rules),
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_folder_selection_changed):
        * src/modest-mail-operation.c:
        (modest_mail_operation_remove_folder),
        (modest_mail_operation_xfer_folder),
        (modest_mail_operation_rename_folder),
        (modest_mail_operation_get_msg),
        (modest_mail_operation_get_msgs_full),
        (modest_mail_operation_remove_msg),
        (modest_mail_operation_xfer_msgs),
        (modest_mail_operation_refresh_folder):
        Use modest_tny_folder_get_account() instead of tny_folder_get_account().
        
2007-06-07  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
        (modest_server_account_set_security): 
        * src/modest-defs.h: Add comments explaining that our 
        UI spec means TLS when it says Normal, so these do not look like errors.
        
        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account): Use the new tinymail 
        'wrapped' option for regular SSL, and use the new tinymail 'tls' option 
        for TLS. This should fix projects.maemo.org bug NB#58460.

2007-06-06  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_account): Correct the position of the gconf sanity check warning.
        (on_button_edit_advanced_settings): Show the dialog immediately, instead 
        of using the g_idle_add() hack, because this does not seem to be necessary 
        on osso 1.1. It might even work on Maemo Bora if the problems were actually 
        caused by something other than maemo's gconf.
        This fixes projects.maemo.org bug #59022.

2007-06-06  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_default_account): Do not check that the account 
        exists if there is no default account (NULL), to fix a runtime warning.

2007-06-06  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-folder-view.c: (update_model):
        Do not unref the treemodel before we have finished with it.
        This prevents a valgrind warning and an occasional crash at startup.
        
2007-06-06  Marcus Bauer  <marcusb@openismus.com>

        * libmodest-dbus-client/libmodest-dbus-client.h:
        added libmodest_dbus_client_compose_mail()
        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
        (on_compose_mail):
        added functions needed for SendAsMail() functionality
        * src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_attach_file_noninteractive):
        non interactively attaching files to message edit window
        * src/widgets/modest-msg-edit-window.h:
        * tests/dbus_api/Makefile.am:
        added test_compose_mail.c
        * tests/dbus_api/test_compose_mail.c: (main):

2007-06-05  Johannes Schmid <johannes.schmid@openismus.com>

        * src/modest-account-view.c:
        Fixed bug projects.maemo.org bug NB#59307

2007-06-05  Johannes Schmid <johannes.schmid@openismus.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (get_serverport_incoming), (on_before_next), (create_account):
        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_set_account_name):
        * src/maemo/modest-maemo-utils.c:
        (on_camel_account_get_supported_secure_authentication_status),
        (on_camel_account_get_supported_secure_authentication),
        (on_secure_auth_cancel),
        (modest_maemo_utils_get_supported_secure_authentication_methods):

        Implemented security authentication for settings and easysetup.

2007-06-05  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window.c: (create_details_widget):
        Show the total size for memory card accounts too, instead of showing 
        the name again. Fixes bug projects.maemo.org bug NB#59307.

2007-06-05  Murray Cumming  <murrayc@murrayc.com>

        * src/Makefile.am:
        * src/modest-tny-simple-folder-store.c:
        * src/modest-tny-simple-folder-store.h: Removed.
        
        * src/modest-tny-local-folders-account.h
        * src/modest-tny-local-folders-account.c: Added a derived TnyAccount 
        for the local-folders maildir, with an extra TnyMergedFolder containing 
        the folders of the per-account outbox store accounts.
        * src/modest-tny-account-store.c: (get_server_accounts):
        Add the outboxes to the special local folders account after creating it.
                
        * src/modest-tny-account.c:
        (modest_tny_account_new_for_local_folders): Create the derived 
        account when creating the main local-folders account.
        
        * src/maemo/modest-main-window.c: (create_details_widget),
        (modest_main_window_set_contents_style):
        Adapted to the use of the derived account instead of the folder store.
        
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_folder_selection_changed):
        * src/modest-ui-dimming-rules.c:
        (modest_ui_dimming_rules_on_new_folder):
        * src/widgets/modest-folder-view.c: (text_cell_data),
        (icon_cell_data), (filter_row), (update_model),
        (get_cmp_rows_type_pos):
        

        * src/modest-tny-send-queue.c: (modest_tny_send_queue_new): 
        Do not get the priv struct, because no priv struct has been set, 
        to avoid a runtime warning.
        
        * src/maemo/modest-platform.c: (modest_platform_show_help): Replace 
        #ifelse with #else, to fix a warning, to fix the build.
        
        
2007-06-05  Christian Kellner  <ckellner@openismus.com> 

        * libmodest-dbus-client/libmodest-dbus-client.c:
        Fix small typo in doc (why do you always see them
        AFTER committing stuff?)


2007-06-05  Christian Kellner  <ckellner@openismus.com> 

        * libmodest-dbus-client/libmodest-dbus-client.c:
        (libmodest_dbus_client_search):
        Initialize hit list with NULL. Also set folder list 
        to "" if NULL was supplied. 
        Add documentation.

2007-06-03  Christian Kellner  <ckellner@openismus.com> 

        * libmodest-dbus-client/libmodest-dbus-client.c:
        (modest_search_hit_list_free):
        Make it save to call it with NULL.

        * src/dbus_api/modest-dbus-callbacks.c:
        * src/modest-search.c:
        Return full ModestSearchHits as the search result list not TnyHeader
        since can't be around withouth the correspoding TnyFolder.

2007-06-03  Johannes Schmid <johannes.schmid@openismus.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
        Added currently commented code to check for secure auth
        
        * src/maemo/modest-account-settings-dialog.c: (on_response),
        (save_configuration), (show_ok):
        Fixed projects.maemo.org bugs NB #59248 and #59251
        
        * src/maemo/modest-maemo-utils.c:
        (on_camel_account_get_supported_secure_authentication_status),
        (on_camel_account_get_supported_secure_authentication),
        (modest_maemo_utils_get_supported_secure_authentication_methods):
        * src/maemo/modest-maemo-utils.h:
        Moved get_supported_secure_authentication() method here to be able
        to use it from easysetup wizard.
        
        * src/modest-pair.c: (on_pair_compare_as_string):
        Should compare string with first part of pair and not
        strcmp pairs which will crash.
        
        * src/modest-protocol-info.c:
        (modest_protocol_info_protocol_is_store):
        * src/modest-protocol-info.h:
        Added modest_protocol_info_get_auth_protocol_name()

2007-06-03  Armin Burgmeier  <armin@openismus.com>

        * src/modest-mail-operation.c:
        (modest_mail_operation_get_msgs_full): Set priv->account also when
        only retrieving a single message. This avoids a crash when canceling
        the operation.

        (modest_mail_operation_notify_end): Do not explicitely remove the
        operation from the queue but only emit the progress_changed signal.
        The queue itself listens to that signal to remove the operation when
        it is finished. This reduces coupling and removes a potential deadlock
        when modest_mail_operation_notify_end() is called from the queue
        itself. If that is a problem performance-wise, I would suggest to
        implement a status-changed signal or something.

        * src/modest-mail-operation-queue.c: Make sure to never call a
        function from another file while the queue is locked. This (hopefully)
        fixes another deadlock when exiting the application while retrieving
        mail.

2007-06-03  Johannes Schmid <johannes.schmid@openismus.com>

        * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
        Fixed build if libogs is not available
        
2007-06-03  Christian Kellner  <ckellner@openismus.com>

        * libmodest-dbus-client/libmodest-dbus-client.h:
        * libmodest-dbus-client/libmodest-dbus-client.c:
        (libmodest_dbus_client_delete_message):
        Implement deletion of messages (Client side).

        (modest_search_hit_free),
        (modest_search_hit_list_free):
        Utility functions to free the result hits.

        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c:
        (on_delete_message),
        (modest_dbus_req_handler):
        Implement deletion of messages (Server side).
        
        * tests/dbus_api/test_search.c: (main):
        Free the hits.

        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_delete_message:
        Add little test for the message deletion logic

2007-06-03  Armin Burgmeier  <armin@openismus.com>

        * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
        when the operation queue was not empty. projects.maemo.org bug
        NB#58976.

2007-06-03  Armin Burgmeier  <armin@openismus.com>

        * src/widgets/modest-account-view.c
        (on_account_default_toggled): Toggle default account column
        explicitely instead of waiting for gconf notification (which is
        currently ignored). This should fix projects.maemo.org bug NB#56910
        for now. It should probably be removed when gconf notifications are
        re-enabled.

2007-06-03  Christian Kellner  <ckellner@openismus.com>

        * libmodest-dbus-client/libmodest-dbus-client.c:
        Removed debugging spew.

        * src/dbus_api/modest-dbus-callbacks.c:
        Added debugging info.

        * src/modest-search.c: 
        (modest_search_all_accounts):
        Use tny_account_store_get_accounts () on the account store
        to get all accounts which is the way to get all accounts.

        * tests/dbus_api/test_search.c: (main):
        Make it possible to supply the search term on the command line.

2007-06-03  Christian Kellner  <ckellner@openismus.com>

        * libmodest-dbus-client/libmodest-dbus-client.c:
        * libmodest-dbus-client/libmodest-dbus-client.h:
        Implement searching for mesages over raw dbus. (Client side)
        
        * src/dbus_api/Makefile.am:
        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c:
        * src/dbus_api/modest-dbus-callbacks.h:
        Search framework (Server side). Also implement on_idle_open_message().

        * src/maemo/modest-platform.c: (modest_platform_init):
        Prepare for raw dbus/osso rpc interaction.

        * src/modest-search.h:
        Changed minsize from unspecific guint to guint32.

        * src/modest-search.c: 
        (add_header):
        Added strange hack which magically made tnymail work.
        
        (modest_search_folder),
        (modest_search_account),
        (modest_search_all_accounts):
        Implement helper functions to search all accounts, specific account
        and folder.

        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_open_message.c:
        Read url to open from commandline.

        * tests/dbus_api/test_search.c:
        Implement small test for dbus search stuff

2007-06-02  Armin Burgmeier  <armin@openismus.com>

        * src/maemo/modest-account-settings-dialog.c: Changed window title to
        include account type and account title. This fixes projects.maemo.org
        bug NB#59000.

        * src/maemo/modest-account-view-window.c: Set a title for the window.

2007-06-02  Armin Burgmeier  <armin@openismus.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
        incoming and outgoing server name based on email address and server
        types as long as the names have not been edited manually. This fixes
        projects.maemo.org bug NB#58671.

2007-06-02  Armin Burgmeier  <armin@openismus.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
        server type cannot be changed in future to the incoming details page
        when creating an account. This fixes projects.maemo.org bug NB#59029.

2007-06-02  Armin Burgmeier  <armin@openismus.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
        and assigned max width chars so that they wrap instead of being
        truncated. Fixes projects.maemo.org bug NB#56126.

2007-06-02  Armin Burgmeier  <armin@openismus.com>

        * src/maemo/modest-connection-specific-smtp-window.c: Add an
        introductory note to the connection specific smtp servers dialog, as
        section 8.12 of the email UI specification requires. This fixes
        projects.maemo.org bug NB#59212.

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
        Check for running mail operations, and offer to cancel them, as per the UI 
        spec. This fixes projects.maemo.org bug NB#59041 .
        However, I suspect that tinymail may still use the network connection 
        in ways that we cannot detect or cancel. But it should at least adapt to 
        changes fairly well.

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (recreate_all_accounts),
        (get_cached_accounts), (get_server_accounts): Do more sensible 
        ref-counting of the temporarily-cached outbox accounts list. This seems 
        to fix a crash when entering the password when the password was wrong.

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/gnome/modest-main-window.c: (connect_signals):
        * src/modest-tny-account-store.c: (get_password),
        (modest_tny_account_store_alert): Added comments and clues and 
        commented-out code about how we currently fail to deal with connection 
        errors and wrong passwords, and how we should.

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-retrieve-combo-box.c:
        (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
        This fixes projects.maemo.org bug NB#58472 .

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_complete_easysetup): 
        (create_page_complete_custom): Correct the last commit, 
        putting the correct sentences in the correct pages.

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_complete_custom): Show the second sentence of text 
        (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug 
        NB#59023 .

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr.c: (modest_account_mgr_add_account):
        Set the leave-on-server conf key by default. This fixes 
        projects.maemo.org bug NB#59258 .

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-view-window.c:
        (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap 
        logical ID for the confirmation messages. Fixed projects.maemo.org bug 
        NB#59037 .

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_caption_new_with_asterisk): 
        * src/maemo/modest-account-settings-dialog.c:
        (create_caption_new_with_asterisk):
        Uncomment the code to add the asterisk, because they are no longer in the 
        translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
        (update_incoming_server_title): Add an asterisk here too.

2007-06-01  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-maemo-global-settings-dialog.c:
        (current_connection): Check that we are even connected before trying to 
        get the current connection name, to prevent a warning.
        
        * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
        Change the comments because tny_maemo_conic_device_connect() is now meant to 
        block.
        * src/modest-mail-operation.c:
        (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to 
        make sure we have a connection and fail if we can't connect.

2007-05-31  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window.c:
        (on_account_store_connecting_finished): Do not try to get the 
        connection ID if we are not really connected. I am surprised that 
        this signal handler is called when we are not connected.

2007-05-31  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-error.h: 
        * src/modest-ui-actions.c:
        (modest_ui_actions_get_msgs_full_error_handler):
        Renamed an enum, added comments, added an enum 
        for retrieve-limit errors.
        
        * src/modest-mail-operation.c: (foreach_add_item),
        (internal_folder_observer_update), (update_account_thread),
        (modest_mail_operation_get_msgs_full):
        (modest_mail_operation_update_account),
        Added comments about how this works, and some code that should 
        (but does not) check the retrieve-limit. See the TODO comment.

2007-05-31  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-ui-actions.c: (modest_ui_actions_on_help):
        Initialize help_id to fix the build. Warnings are good.

2007-05-31  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-hbox-cell-renderer.c:
        (modest_hbox_cell_renderer_append):
        * src/widgets/modest-vbox-cell-renderer.c:
        (modest_vbox_cell_renderer_append):
        Fix the last commit by doing an extra ref.

2007-05-31  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-hbox-cell-renderer.c:
        (modest_hbox_cell_renderer_append):
        * src/widgets/modest-vbox-cell-renderer.c:
        (modest_vbox_cell_renderer_append):
        For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(), 
        to fix the build with Maemo Bora.
        However, there seems to be a remaining crash, probably due to reference 
        counting errors.

2007-05-30  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account.c:
        (modest_tny_account_new_for_local_folders):
        Use hildon_file_system_info_async_new() to get a better name for 
        the memory card account, setting it as the account name.
        The timing seems to work, but this is probably 
        not the best place to do this. See the TODO comment.
        * src/maemo/modest-main-window.c: (create_details_widget):
        * src/widgets/modest-folder-view.c: (text_cell_data):
        Use the tny account name instead of hardcoding a name.

2007-05-30  Christian Kellner  <ckellner@openismus.com>

        * src/modest-search.c: (modest_search):
        Correctly set part_search_func even if we have already parsed
        the query and thus a valid OgsTextSearcher object.

2007-05-30  Christian Kellner  <ckellner@openismus.com>

        * configure.ac:
        Search and check for libogs.

        * src/Makefile.am:
        Incooparte the ogs build env.

        * src/modest-mime-part-search-stream.c:
        * src/modest-mime-part-search-stream.h:
        Removed since we do the real searching now in modest-search.c.

        * src/modest-search.c:
        * src/modest-search.h:
        Implement support for ogs. We use that if available and requested
        and fall back to modest_text_utils_utf8_strcmp (). The search logic
        should now handle the corner case when the search term is spread
        across multiple reads.
        Also the logic in modest_search () was corrected to search all
        requested fields until one is found.

2007-05-30  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
        
        * src/modest-init.h:
        * src/modest-init.c: Made modest_init_local_folders() take a
        path and be public so we can iniitialize maildir folders on 
        arbitrary volumes.

        * src/modest-local-folder-info.h:
        * src/modest-local-folder-info.c:
        (modest_local_folder_info_get_maildir_path): Add a path parameter.

        * src/modest-tny-account.c:
        (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL 
        still means the standard local-folders path on the local volume.
        
        * src/modest-tny-account-store.c:
        (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor 
        signal so we can detect mount/unmount of the MMC1 card, and do an update of 
        all accounts when that happens.
        (get_server_accounts): If the MMC1 card is mounted, create a store account for 
        this too, so it shows up in the treeview.

2007-05-28  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-maemo-global-settings-dialog.c:
        (current_connection):
        * src/widgets/modest-global-settings-dialog.c:
        (current_connection_default):
        Use the enum values instead of 0, 1 and -1,
        to make the code clearer.
        
        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_connection_specific_smtp): Make this code 
        more robust.
        
        * src/modest-runtime.h:
        * src/modest-runtime.c:
        Added modest_runtime_remove_all_send_queues().
        * src/maemo/modest-main-window.c:
        (on_account_store_connecting_finished): Recreate the send queues, 
        using the appropriate transport accounts for this new connection.
        Some futher adapting might be needed if the old send queues are not 
        automatically stopped at this point.

        * src/modest-tny-account-store.c: (get_server_accounts):
        Create the connection-specific transport accounts, so that they can 
        be found later by their ID.
        
        * src/modest-tny-account.h:
        * src/modest-tny-account.c:
        Added modest_tny_account_new_from_server_account_name().
        modest_tny_account_new_from_server_account(): Do not create the 
        send queues here, because they will be 
        recreated anyway when the connection changes for the first time.

2007-05-28  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-local-folder-info.h:
        * src/modest-local-folder-info.c:
        (modest_per_account_local_outbox_folder_info_get_maildir_path),
        (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
        tbox_folder): Take a modest account name instead of a server TnyAccount,
        so we can have per-modest-account rather than per-transport-account 
        outboxes.
        We must make sure that we change or recreate the exisitng send queues 
        when the connection changes for connection-specific transport accounts.
        
        * src/modest-tny-account-store.c:
        (create_per_account_local_outbox_folders): Create outboxed per modest 
        account, not per transport account.
        
        * src/modest-tny-account.h:
        * src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): For outboxes, get the 
        parent modest account name. The account is ignored for other folders.
        (modest_tny_account_new_for_per_account_local_outbox_folder): Take a 
        modest account name rather than a server TnyAccount.

2007-05-25  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account): 
        Call modest_runtime_get_send_queue() immediately after creating transport 
        accounts, so that they start trying to send email from the outbox as soon 
        as possible at startup. This is probably what we want.
        
        * src/modest-mail-operation.c: (update_account_thread):
        * src/modest-runtime.c: (modest_runtime_get_send_queue):
        * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
        * src/modest-tny-send-queue.h:
        * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
        (modest_ui_actions_on_send):
        Added comments about how sending works, though it needs some more work.

2007-05-25  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): Add TODO because this fails when 
        the network is busy.
        (modest_tny_folder_store_get_local_size):  Fix an incorrect type check.
        * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers): 
        Do not try to show this window when there is no active account. The UI 
        specs does not tell us what to do in this case.

2007-05-24  Murray Cumming  <murrayc@murrayc.com>

        * Makefile.am:
        * po/POTFILES.in:
        * src/maemo/Makefile.am:
        * src/widgets/Makefile.am: Some dist fixes.

2007-05-24  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-connection-specific-smtp-window.c:
        (on_button_edit): Make the code clearer, to prevent a double free.

2007-05-24   Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_set_account_name),
        Check the connection-specific smtp servers checkbox if there are any.
        
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init): 
        Start with a suitable port number.
        
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c: Added 
        modest_account_mgr_get_has_connection_specific_smtp().
        
        (modest_account_mgr_set_connection_specific_smtp),
        (modest_account_mgr_remove_connection_specific_smtp),
        (modest_account_mgr_get_has_connection_specific_smtp),
        (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of 
        connection-specific smtp server accounts in the account, rather than 
        the server account conf dir.
        
        This fixes bug projects.maemo.org bug NB#58263 .

        * src/modest-tny-account-store.c:
        (create_per_account_local_outbox_folders): Do not call get_server_accounts() 
        if there are no server accounts yet, to prevent an infinite loop when there 
        are no accounts. Document that one must be called before the other.

2007-05-24  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_default_account): Make sure that at least 
        one account is always the default, if there are any enabled accounts. 
        This is just a sanity check that shouldn't be necessary.
        
        * src/modest-account-mgr-priv.c:
        (_modest_account_mgr_account_from_key): Unescape the conf key to 
        get the real account name. For instance, this is an issue if a space 
        was in the account name, which can happen because the account name 
        is generated from the display name.
        (_modest_account_mgr_get_account_keyname): Always escape the 
        account name.
        * src/modest-account-mgr.c: (modest_account_mgr_account_names): 
        Unescape the conf keys to get the real account names.
        
        For instance, previously the is-default radio button in the accounts 
        list was not checked for any accounts at first. This fixes that,
        and might fix several similar bugs.

2007-05-23  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-ui-actions.c: (set_active_account_from_tny_account):
        Removed some debug printfs.

2007-05-23  Murray Cumming  <murrayc@murrayc.com>

        Modest on-disk outbox directories are now here, for instance:
        $HOME/.modest/outboxes/<account-id-1>/outbox
        $HOME/.modest/outboxes/<account-id-2>/outbox
        instead of here:
        $HOME/.modest/local-folders/outbox
        so we can have a separate outbox for each account.
        But they are shown as one outbox in the GtkTreeView, by using a 
        TnyMergeFolder in a ModestTnySimpleFolderStore.
        
        * src/Makefile.am:
        * src/modest-tny-simple-folder-store.c:
        * src/modest-tny-simple-folder-store.h:
        Added ModestTnySimpleFolderStore, used to contain folders from 
        other folder stores, such as other accounts.
        
        * src/modest-tny-outbox-account.h:
        * src/modest-tny-outbox-account.c:
        Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount, 
        used for the per-account local outbox folders.
        
        * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to 
        MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we 
        only use this (internally) now for the non-outbox local folders.

        * src/modest-init.h:
        * src/modest-init.c: Added modest_init_one_local_folder(), for 
        setting up the directory structure for each local folder.

        * src/modest-local-folder-info.c:
        (modest_per_account_local_outbox_folder_info_get_maildir_path),
        (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
        tbox_folder):
        * src/modest-local-folder-info.h:
        * src/modest-tny-account-store.c: (on_account_removed),
        (on_account_changed), (create_per_account_local_outbox_folders),
        (get_server_accounts), (modest_tny_account_store_get_accounts),
        (modest_tny_account_store_get_tny_account_by_account),
        (modest_tny_folder_store_is_virtual_local_folders):

        * src/modest-tny-account.h:
        * src/modest-tny-account.c:
        Added modest_tny_account_new_for_per_account_local_outbox_folder(), 
        to create an on-disk per-account local outbox folder for each 
        transport account.
        (create_per_account_local_outbox_folders): Create a local outbox folder 
        for each transport account.
        (modest_tny_account_new_for_local_folders): Do not create an outbox folder 
        for all local folders.
        
        Added modest_tny_account_get/set_parent_modest_account_name_for_server_account() 
        instead of using g_object_get/set() directly. It is clearer.
        
        (modest_tny_folder_store_get_message_count),
        (modest_tny_folder_store_get_local_size
        (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*, 
        because we now use these with non-acount folder stores.
        
        (modest_tny_account_get_special_folder),
        (modest_tny_account_new_from_server_account),
        (modest_tny_account_new_from_account):
        (recurse_folders): Adjust to the new outbox system.
        
        * src/modest-tny-folder.h:
        * src/modest-tny-folder.c: 
        (modest_tny_folder_is_local_folder),
        (modest_tny_folder_get_local_folder_type),
        (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
        
        * src/widgets/modest-main-window.h:
        * src/maemo/modest-main-window.c: (create_details_widget),
        (modest_main_window_set_contents_style): Show details for any folder store, 
        not just accounts.
        
        (modest_tny_folder_get_rules): 
        Remove the const. C does not support constness enough for this.
        
        * src/modest-ui-actions.c:
        update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to 
        make all outboxes appear as one, in the usual local-folders tree node.
        
        (set_active_account_from_tny_account),
        (modest_ui_actions_on_folder_selection_changed):
        * src/widgets/modest-folder-view.c: (text_cell_data),
        (icon_cell_data), (filter_row),
        (add_account_folders_to_merged_folder),
        (add_account_folders_to_simple_folder_store), (),
        (get_cmp_rows_type_pos), (cmp_rows),
        (modest_folder_view_set_account_id_of_visible_server_account):
        Adjust to the new outbox system, using generic folder stores and folders 
        in the GtkTreeModel.

2007-05-23  Christian Kellner  <ckellner@openismus.com>

        * src/modest-mail-operation.c:
        (modest_mail_operation_update_account):
        Use info->max_size instead of unintialized local var [small
        build fix]. (Added TODO to review that change since I don't
        know the code)

2007-05-23  Marcus Bauer  <marcusb@openismus.com>

        * libmodest-dbus-client/libmodest-dbus-client.c:
        (libmodest_dbus_client_compose_mail): function added
        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
        (on_compose_mail): Implementation of the SendAsMail functionality

2007-05-22 Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr.c:
        (modest_account_mgr_add_server_account): Set the secure-connection 
        conf key for transport accounts as well as store accounts. I don't know 
        why the if was there. For instance, this makes sure that we use SSL 
        for the gmail preset from the easysetup wizard.

2007-05-22 Murray Cumming  <murrayc@murrayc.com>

        * src/gnome/modest-main-window.c:
        (on_account_store_connecting_finished), (connect_signals):
        * src/maemo/modest-main-window.c:
        (on_account_store_connecting_finished), (connect_signals),
        (modest_main_window_new):
        Handle TnyAccountStore::connecting-finished instead of 
        TnyDevice::connection-changed, because we cannot actually perform 
        operations on accounts until TnyAccountStore has itself responded to 
        the TnyDevice::connection-changed signal. This prevents a GError from 
        tinymail.
        Do not try to update at startup, because we (at least on scratchbox) 
        already do an update at startup when the device goes online. 
        This prevents a GError from tinymail.
        * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive): 
        Added TODO about stopping simultaneous operations.

2007-05-21  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr.c: (modest_account_mgr_add_account):
        * src/modest-mail-operation-queue.c:
        (modest_mail_operation_queue_remove):
        * src/modest-tny-account-store.c: When GErrors happen, give more clues 
        about where they happened.

2007-05-21  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested): Make sure that the remember 
        output parameter is always TRUE.

2007-05-21  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Show a OK/Cancel dialog if the error is a question, though we still do not 
        know anything more about what we are asking the user.
        * src/widgets/modest-folder-view.c: (on_drag_data_received):
        Fix an uninitialized variable (helper). This is a logic error, however.

2007-05-21  Christian Kellner  <ckellner@openismus.com>
        
        * src/modest-search.h:
        Correct bit shifting in the ModestSearchFlags enum.

2007-05-21  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account): Do not use the lsub and 
        check-all hard-coded IMAP options when using POP.

2007-05-21  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account): 
        Use NULL for the secure-auth method for POP when Password auth has been 
        specified by the user, as we already do for IMAP. "auth=Login" causes 
        an error from camel or the server.

2007-05-17  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details),
        (modest_account_settings_dialog_set_account_name):
        * src/maemo/modest-account-settings-dialog.h: Hide the whole caption 
        for the leave-on-server checkbox, rathr than just the checkbox, when 
        the protocol is not POP.

2007-05-17  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-account-view.c:
        * src/widgets/modest-account-view.h:
        Added modest_account_view_select_account() which will be useful later 
        to asynchronously re-select the edited account.

2007-05-17  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_set_account_name): 
        Automatically choose the port numbers based on the secure authentication 
        methods, if they have not been chosen before.
        This fixes projects.maemo.org bug NB#56273 .

2007-05-17  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window-ui.h:
        * src/modest-ui-actions.c:
        * src/modest-ui-actions.h:
        Connect the Tools/SMTP Servers menu item to 
        modest_ui_actions_on_smtp_servers(), which shows the connection-specific 
        SMTP servers dialog, as in the UI specification and saves changes when it 
        is closed. This fixed  projects.maemo.org bug NB#56305 .

2007-05-17  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_init):
        Use gtk_window_set_default_size() to make this window big enough, so 
        we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .

2007-05-17  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-connection-specific-smtp-edit-window.h:
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init),
        Do not try to connect to a combobox signal before the combobox exists.
        This fixes the cras in projects.maemo.org bug NB#56288 .
        (modest_connection_specific_smtp_edit_window_get_settings):
        Remove the server_account_name parameter which was being checked for NULL 
        though it was not used.

        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_fill_with_connections),
        (on_button_edit), (modest_connection_specific_smtp_window_init):
        Correct the number of treemodel columns to prevent a warning.
        Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where 
        libconic does not work.

2007-05-16  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for 
        SMTP when "None" was chosen by the user. However, with my SMTP server that 
        does not support ANONYMOUS, the emails do not leave the Outbox and I see 
        no error dialog.

2007-05-16  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-pair.h: Improve the documentation for modest_combo_box_new() 
        to explain the memory management issue with the ID in the ModestPair.
        
        * src/gnome/modest-account-assistant.c: (add_receiving_page),
        (add_sending_page), (modest_account_assistant_finalize):
        * src/gnome/modest-gnome-global-settings-dialog.c:
        (create_updating_page), (create_composing_page):
        * src/gnome/modest-msg-edit-window.c: (get_transports),
        (init_window), (modest_msg_edit_window_finalize),
        (modest_msg_edit_window_get_msg_data):
        * src/gnome/modest-store-widget.c: (imap_pop_configuration):
        * src/gnome/modest-transport-widget.c:
        (modest_transport_widget_finalize), (smtp_configuration):
        * src/maemo/modest-maemo-global-settings-dialog.c:
        (create_updating_page), (create_composing_page):
        * src/maemo/modest-msg-edit-window.c: (get_transports),
        (init_window), (modest_msg_edit_window_finalize),
        (modest_msg_edit_window_get_msg_data),
        (modest_msg_edit_window_free_msg_data):
        * src/maemo/modest-store-widget.c: (imap_pop_configuration),
        (modest_store_widget_finalize):
        * src/maemo/modest-transport-widget.c:
        (modest_transport_widget_finalize), (smtp_configuration):
        * src/modest-main.c: (send_mail):
        * src/widgets/modest-combo-box.h:
        * src/widgets/modest-global-settings-dialog-priv.h:
        * src/widgets/modest-global-settings-dialog.c:
        (modest_global_settings_dialog_finalize):
        * src/widgets/modest-msg-edit-window.h:
        Whenever using modest_combo_box_new(), keep the ModestPairList alive
        as long as the combo box, to prevent use of freed memory for the ID.

2007-05-15  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (get_server_accounts): Renamed from 
        get_accounts(), to make this clearer. Do not check for the enabled gconf
        key, because we do not use this for server accounts (at least, not yet).
        This allows us to send email again.

2007-05-15  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-platform.c:
        (on_modest_conf_update_interval_changed), (modest_platform_init):
        Only respond to this particular key change. All these strcmp()s cannot be 
        efficient.

2007-05-15  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-maemo-global-settings-dialog.c:
        (current_connection): Prevent a crash in scratchbox when 
        ny_maemo_conic_device_get_current_iap_id() returns NULL.
        * src/maemo/modest-platform.c:
        (on_modest_conf_update_interval_changed), (modest_platform_init):
        Get the update interval from gconf and reset it when the gconf key changes.

2007-05-15  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-protocol-info.c:
        * src/modest-protocol-info.h: Adde enum-specific get functions, 
        instead of using a ModestProtocolType enum parameter.
        
        * src/gnome/modest-account-assistant.c:
        * src/gnome/modest-store-widget.c:
        * src/gnome/modest-store-widget.h:
        * src/gnome/modest-transport-widget.c:
        * src/gnome/modest-transport-widget.h:
        * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
        * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-account-settings-dialog.h:
        * src/maemo/modest-store-widget.c:
        * src/maemo/modest-store-widget.h:
        * src/maemo/modest-transport-widget.c:
        * src/maemo/modest-transport-widget.h:
        * src/modest-account-mgr-helpers.c:
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr.c:
        * src/modest-account-mgr.h:
        * src/modest-tny-account.c:
        * src/modest-tny-folder.c: 
        * src/widgets/modest-account-view.c:
        * src/widgets/modest-retrieve-combo-box.c:
        * src/widgets/modest-retrieve-combo-box.h:
        * src/widgets/modest-secureauth-combo-box.c:
        * src/widgets/modest-serversecurity-combo-box.c:
        * src/widgets/modest-serversecurity-combo-box.h:
        * tests/check_account-mgr.c: 
        Use the specific functions, and use the re-renamed enum values for GNOME too.

2007-05-15  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-pair.h: 
        * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
        so we can get the second based on the first.

        * src/maemo/modest-account-settings-dialog.h: 
        * src/maemo/modest-account-settings-dialog.c:
        Added get_supported_secure_authentication_methods(), though it is mostly 
        commented-out for now until the necessary API is committed to tinymail.
        (modest_account_settings_dialog_set_account_name),
        (save_configuration): Request the supported authentication methods from the 
        server, so we can choose a working method.
        
        * src/modest-tny-account-store.h:
        * src/modest-tny-account-store.c:
        (modest_tny_account_store_get_session): Rename from 
        tny_account_store_get_session().

2007-05-14  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-protocol-info.h: Split the ModestProtocol enum 
        into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
        There was no need to have these unrelated values in one enum.
        
        * src/: many files: Adapted to changed enum. This makes the code a bit
        clearer, and the compiler could catch some errors.

2007-05-14  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Show the detailed internal camel error message when an error happens 
        during the configuration, so that our testers can give us more clues.
        For instance, in projects.maemo.org bug NB#56910 .

2007-05-14  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account): Adapt to changed tinymail API: 
        change tny_account_set_mech() to tny_account_set_secure_auth_mech().

2007-05-14  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_set_account_name),
        (save_configuration): For the incoming secure authentication checkbox, 
        use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread 
        the UI specification. PLAIN does not seem to be supported for most IMAP 
        servers anyway, and I am not sure what it would mean.
        However, we probably need to discover which of the secure-authentication 
        mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_server_account_data):

        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Use tny_account_set_mech() to set secure-authentication methods, 
        with some special-casing for IMAP, based on my observations of how 
        evolution behaves.
        
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr.c:
        * src/modest-defs.h: Comment that the URI is only used for local folders.

2007-05-11  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window.c: (on_account_update): Make the gchar* 
        parameter const, just to be neat.
        * src/modest-text-utils.c: (modest_text_utils_inline):
        End g_strconcat() with NULL, as its documentation says. This is almost 
        certainly the cause of my crash at startup on the device. Interestingly, 
        valgrind doesn't tell us about these errors.

2007-05-11  Murray Cumming  <murrayc@murrayc.com>

        * scripts/build-packages: Added more precise comments about how to use 
        this script, though I still get this error:
        dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
        error building tinymail
        
2007-05-11  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window.c: (on_account_update):
        Very slight cleanup, hoping to make it simpler to discover what causes 
        a crash here sometimes.
        
        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account): Set the port. Added 
        comments about the options and a TODO comment because I need to find out 
        how to specify the secure authentication method.

2007-05-11  Marcus Bauer  <marcusb@openismus.com>

        * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
        changed CFlags paths form modest to libmodest

2007-05-10  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_server_account_data),
        (modest_account_mgr_free_server_account_data):
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr.c:
        (modest_account_mgr_add_server_account):
        * src/modest-defs.h:
        * src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Determine the options for tny_camel_account_add_option() here, 
        based on the settings, rather than storing them directly in gconf.

2007-05-10  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Show a more friendly error dialog now that we expect (from the tinymail 
        documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.

2007-05-10  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window.c: (on_account_update): Check that 
        account_name is not NULL, to prevent a crash at startup that I am 
        seeing on the N800. I do wonder why it is NULL.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_user_details):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_user_details), (create_page_outgoing):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init):
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested):
        Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which 
        might do something useful with the on-screen keyboard.

2007-05-10  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window.c: (on_account_update):
        Avoid adding a menu item to priv->accounts_popup if accounts_popup is 
        NULL, to avoid lots of warnings. However, it probably should not be NULL.

2007-05-09  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (on_account_changed): 
        Correct the signature of this signal handler.

2007-05-09  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Show a HildonNote instead of a GtkDialog for Maemo.

2007-05-09  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-account-view.h:
        * src/widgets/modest-account-view.c: (on_account_changed),
        (on_account_removed). Added a boolean flag, set/unset by 
        modest_account_view_block_conf_updates(), 
        modest_account_view_unblock_conf_updates() to prevent unnecessary 
        updates, but this is not very useful because the gconf notifications are 
        so delays (maybe only on Maemo Bora).
        So auto-updating is turned off, and these functions do an explicit 
        update when necessary.
        However, something else is still doing too much work when adding/removing 
        accounts, probably in another part of the application.
        
        * src/maemo/modest-account-view-window.c:
        (on_delete_button_clicked), (on_edit_button_clicked),
        (on_new_button_clicked): Use the new functions.

2007-05-09  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_set_first_account_as_default):
        Sort the list of names alphabetically-by-title, so we choose the first one 
        based on that.
        * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel 
        alphabetically by the title.
        
        This fixes projects.maemo.org bug NB#56418 .
        
        * src/modest-account-mgr-priv.c:
        (_modest_account_mgr_account_from_key):
        * src/modest-account-mgr.c: (on_key_change): Initialize variables to 
        avoid a valgrind error, and possible random behaviour.

2007-05-09  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the 
        tinymail documentation to say that this can be expected.
        Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not 
        pretty, and should not happen, but I would prefer to know when it does.

2007-05-09  Murray Cumming  <murrayc@murrayc.com>

        * configure.ac: When using the older hildon version, probably on Bora, 
        require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
        to fix the build.
        * src/widgets/modest-attachment-view.c:
        (modest_attachment_view_set_part_default): Initialize variables, to fix the 
        build.

2007-05-09  Marcus Bauer  <marcusb@openismus.com>

        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
        Implemented the prototype. Can be tested with
        tests/dbus_api/test_open_message: 

2007-05-08  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c:
        (modest_tny_account_store_instance_init), (get_password):
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested):
        Do not store the password in gconf, because this function is called 
        for non-remembered passwords. Actually use the cached (in the hash map) 
        password instead of releasing it.
        The password will now not be remembered if it is asked via the protected 
        password dialog, as per the UI spec.

2007-05-08  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-defs.h:
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        Added modest_server_account_get_username_has_succeeded(),
        modest_server_account_set_username_has_succeeded().
        (modest_server_account_set_username),
        Reset the has-succeeded flag if the username changes.
        
        * src/maemo/modest-account-settings-dialog.c: (save_configuration):
        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_save_server_accounts):
        Use modest_server_account_set_username() instead of using 
        modest_conf_set_string() directly, so that the has-succeeded flag is always 
        reset.
        
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested): Dim the username entry if 
        the username has ever worked, as per the UI spec.

2007-05-08  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (get_password):
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested):
        Allow the username to be changed too, though there is more work to 
        be done on exactly how this behaves.

2007-05-08  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        Added modest_account_mgr_get_display_name(),
        modest_server_account_get_username(),
        modest_server_account_set_username(),
        modest_server_account_set_password(),
        modest_server_account_get_hostname() functions so we do not need to 
        use the conf API directly.
        
        * src/maemo/modest-main-window.c: (connect_signals):
        Actually connect ot the ModestAccountStore::request-password signal, 
        so that we show the dialog when the password is requested by Tinymail, 
        for isntance if it is empty.

        * src/modest-marshal.list:
        * src/modest-tny-account-store.c:
        (modest_tny_account_store_class_init), (get_password),
        (modest_tny_account_store_alert):
        * src/modest-tny-account-store.h:
        * src/modest-ui-actions.h:
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested):
        Change the signal parameters, so it is obvious that we are providing 
        the non human-readable server name, and receiving both the username 
        and password, though changing of the username is not yet implemented.
        Change the dialog UI to match the Maemo UI specifications, with #idfefing 
        for the GNOME version.
        
        This should fix the projects.maemo.org bug NB#56209, though it does not 
        work on Bora, because the gconf_client_get() for the password fails 
        immediately after we save it with gconf_client_set().

2007-05-08  Murray Cumming  <murrayc@murrayc.com>

        * configure.ac:
        * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it 
        caused an undefined symbol error:
        modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler

2007-05-08  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c:
        (modest_tny_account_store_alert): Adapt to the changed tinymail API, 
        using a GError instead of a string message, so we can translate it in 
        Modest.

2007-05-08  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-address-book.c:
        (modest_address_book_check_names):
        * src/maemo/modest-msg-view-window.c:
        (modest_msg_view_window_clipboard_owner_change):
        * src/modest-init.c: (modest_init_init_ui):
        * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
        (update_folders_cb), (modest_mail_operation_update_account):
        * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
        (modest_ui_actions_on_msg_attachment_clicked),
        (modest_ui_actions_on_msg_recpt_activated):
        * src/widgets/modest-header-view.c: (drag_data_get_cb):
        * src/widgets/modest-msg-view.c: (modest_msg_view_search),
        (modest_msg_view_search_next):
        * src/widgets/modest-recpt-editor.c:
        (modest_recpt_editor_on_button_release_event),
        (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to 
        g_message(). At this point we should only be seeing interesting errors on 
        stdout. Debugging messages could be #ifdefed-out if they are still useful.

2007-05-07  Murray Cumming  <murrayc@murrayc.com>
        
        (modest_wizard_dialog_force_title_update):
        * src/maemo/easysetup/modest-wizard-dialog.h:
        * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
        For GTK+ 2.10, when present, connect to the GtkNotebook signals so we 
        can update the title when appropriate. Otherwise the title is wrong if the 
        pages are added after adding the notebook to the dialog.
        This must be a problem in HildonWizardDialog too.
        Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_subsequent_customsetup_pages),
        (create_subsequent_easysetup_pages): 
        Call modest_wizard_dialog_force_title_update() so that the title is 
        correct even with GTK+ < 2.10.
        This fixes projects.maemo.org bug NB#56145 .
        
2007-05-07  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-platform.c:
        (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG 
        flag (awful lack of namespacing in this API) to prevent a useless %s dialog 
        from being shown.

2007-05-07  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-window.h:  
        * src/widgets/modest-window.c: Added a save_state_func vfunc, 
        and modest_window_save_state(), which invokes it.

        * src/widgets/modest-window-mgr.h:
        * src/widgets/modest-window-mgr.c:
        Added modest_window_mgr_save_state_for_all_windows(), which calls 
        the save_state vfunc on all registered windows, if implemented.
        
        * src/gnome/modest-msg-edit-window.c:
        * src/gnome/modest-msg-view-window.c:
        * src/maemo/modest-msg-edit-window.c:
        * src/maemo/modest-msg-view-window.c:
        * src/maemo/modest-main-window.c: 
        Specify the existing save_settings functions as implementations of 
        ModestWindow::save_state_func().

        * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
        Call modest_window_mgr_save_state_for_all_windows(). This happens before 
        enabling hibernation, for instance.
        
        We may need to do the same thing for restoring settings.


2007-05-07  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-window-mgr.c: 
        * src/widgets/modest-window-mgr.h:
        Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
        modest_window_mgr_get_hibernation_is_prevented().
        
        * src/maemo/modest-main-window.c:
        (on_hildon_program_is_topmost_notify): Prevent hibernation 
        (possible when the application goes to the background in the WM), 
        if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (modest_easysetup_wizard_dialog_init):
        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_init):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init):
        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_init):
        * src/maemo/modest-signature-editor-dialog.c:
        (modest_signature_editor_dialog_init):
        Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to 
        prevent hibernation while any of these account settings dialogs are open.

2007-05-04  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/Makefile.am:
        * src/maemo/modest-osso-state-saving.c: 
        * src/maemo/modest-osso-state-saving.h: Added 
        modest_osso_load_state() and modest_osso_save_state() though they do 
        nothing now. They should iterate through all the open windows and load/save 
        their state.
        * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo, 
        save state when closing.
        
        * src/maemo/modest-main-window.c:
        (on_hildon_program_is_topmost_notify), (modest_main_window_new):
        Add a notification handler for the HildonProgram::is-topmost property, 
        so we can allow hibernation when the application goes into the background.
        But we still need to detect when the accounts setup windows are open so 
        we can stop hibernation when they are open.
        To do this, I also added the main window the HildonProgram. This might have 
        other side-effects/benefits, and should maybe be done for other windows.

        * src/maemo/modest-osso-autosave-callbacks.h:
        * src/maemo/modest-osso-autosave-callbacks.c:
        (modest_on_osso_application_autosave): Add a libosso auto-save callback, 
        though it does not do anything yet, and we might never need this to do 
        anything. For instance, we already save drafts.
        
        * src/maemo/modest-platform.c: (modest_platform_init):
        Specify the libosso auto-save callback.

2007-05-03  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-platform.c:
        (modest_platform_set_update_interval):
        * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it 
        aparently stays valid between application instances, so we can use this 
        to remove and reset it later. According to a maemo-developers email from 
        David Weinehall.

2007-05-03  Murray Cumming  <murrayc@murrayc.com>

        * configure.ac: Depend on libalarm for Maemo.

        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
        (on_send_receive), (modest_dbus_req_handler):
        Handle a SEND_RECEIVE D-Bus method.
        
        * libmodest-dbus-client/libmodest-dbus-client.c:
        (libmodest_dbus_client_send_and_receive):
        * libmodest-dbus-client/libmodest-dbus-client.h:
        Add C convenience functions for calling the new D-Bus method.
        
        * src/modest-platform.h:
        * src/gnome/modest-platform.c:
        * src/maemo/modest-platform.c: 
        Added modest_platform_set_update_interval(), which uses the 
        alarmd API on Maemo.
        (modest_platform_init),
        Call modest_platform_set_update_interval(), using a hard-coded 
        interval for now (until the global settings dialog is implemented), 
        though I am not sure that this makes sense yet.

2007-05-02  Murray Cumming  <murrayc@murrayc.com>

        * src/dbus_api/modest-dbus-callbacks.c:
        (modest_osso_cb_hw_state_handler):
        * src/dbus_api/modest-dbus-callbacks.h:
        * src/maemo/modest-platform.c: (modest_platform_init):
        Registered (empty) callbacks for the osso hardware state D-Bus signals, 
        in case this has some effect on the ability for Maemo to ping the 
        application.

2007-05-02  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
        Comment out an if() that checks a gchar for < 0, causing a build-breaking 
        warning. It is probably a logic error, but I need to fix the build.

2007-05-02  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr.h:
        * src/modest-account-mgr.c: 
        (modest_account_mgr_account_names): Add a gboolean enabled_only 
        parameter, so we can get lists of onlt the enabled accounts.
        
        (modest_account_mgr_add_account),,
        (modest_account_mgr_account_with_display_name_exists):
        * src/maemo/modest-msg-edit-window.c: (get_transports):
        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_set_first_account_as_default):
        * src/modest-init.c: (init_default_account_maybe):
        * src/modest-tny-account-store.c: (get_accounts):
        * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
        (do_send_receive_auto), (modest_ui_actions_on_send_receive):
        * tests/check_account-mgr.c: (START_TEST):
        Provide the extra parameter, as appropriate.
        
        * src/widgets/modest-account-view.c: (update_account_view):
        Do not show disabled accounts (meaning that there is no way to 
        enable/disable accounts in the UI (the feature is not in our UI 
        specification), so we can use this internally only to mark unfinished 
        or temporary account data.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_account): Add boolean enable parameter, so we can specify FALSE 
        to create the temporary account.
        (on_button_edit_advanced_settings): Create the temporary account as disabled.
        (on_before_next): When finishing, when there is a temporary account, just 
        set it as enabled.
        Also, use a timeout to delay the showing of the dialog until gconf is likely 
        to return correct information, due to a maemo gconf bug that is fixed in 
        osso 1.1, but not yet in Bora.
        However, the dialog stays on screen after it is destroyed.
        
        * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check 
        for invalid data when cancelling. Use a hildon note instead of a dialog 
        to complain about invalid data. Do not show the account-saved note if the 
        account is disabled (a temporary account that will not really be saved for use 
        until later.)

2007-04-30  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        Added modest_account_mgr_unset_default_account(),
        Added modest_account_mgr_set_first_account_as_default().

        * src/modest-account-mgr.c: (modest_account_mgr_remove_account): 
        If it was the default account, unset the default account name.
        
        * src/maemo/modest-account-view-window.c:
        (on_delete_button_clicked): If it was the default account, 
        set the first remaining account as the default instead.
        
        * src/maemo/modest-main-window.c: (on_account_update): Do not try to use 
        a NULL account or a NULL default account, to prevent a crash. This should 
        not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
        

2007-04-30  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-recpt-editor.c:
        (modest_recpt_editor_on_key_press_event): Put an #ifdef around the 
        use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a 
        TODO comment for this. This fixes the build.
        
        * src/modest-ui-actions.c: Add do_send_receive(), though it might not 
        be the best place for it. This will in future update all auto-update accounts, 
        rather than just the current/default account, when that gconf key exists.
        (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard) 
        if there are no accounts, before calling do_send_receive().
        * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
        
        * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
        * src/maemo/modest-main-window-ui.h:
        * src/maemo/modest-main-window.c: (on_connection_changed),
        (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler 
        directly, becaue the signal handler does more.

2007-04-30  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_account_data): Add a more helpful error message, and comment, 
        for the case that the account does not exist.
        
        * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID 
        (equivalent to the modest account name) rather than the tinymail account name 
        (equivalent to the modest account title - human readable) to get the account data.
        Check for null account data to prevent the crash, and add a TODO comment saying that 
        this needs fixing because it is using the server account name instead of the account name.

2007-04-29  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
        * src/maemo/modest-account-settings-dialog.c: (show_error),
        (show_ok):
        Use hildon_note_new_information() for informative and error messages, 
        which seems to be expected for Maemo applications (no documentation that I know of 
        says this). I am surprised that there is no distinction between info and error 
        dialogs.

2007-04-29  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so 
        it is easy to find where this is used.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_welcome), (create_page_account_details),
        (create_page_user_details), (create_page_complete_easysetup),
        (create_page_custom_incoming), (create_page_custom_outgoing),
        (create_page_complete_custom):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details), (create_page_user_details),
        (create_page_incoming), (create_page_outgoing):
        * src/maemo/modest-account-view-window.c: (window_vbox_new):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init):
        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_init):
        * src/maemo/modest-signature-editor-dialog.c:
        (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders 
        and scrolling policy as per the Email Application Layout Guide, if I have 
        understood it.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.c: (modest_tny_account_store_init): 
        Remove the add_transport_account_func and add_store_account_func vfunc implementations, 
        which were empty, because these vfuncs have been removed from TnyAccountStore.
        This fixes the build.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-main-window.c:
        (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before 
        showing/hiding it. Added TODO because it probably should not be NULL.
        * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning() 
        because unnecessary g_warnings() make degugging difficult.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_select_color),
        (modest_msg_edit_window_select_background_color): 2 const corrections and 
        moving 2 #endifs before closing brackets, to fix the build.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.h:
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (modest_easysetup_wizard_dialog_finalize),
        (on_button_edit_advanced_settings), (create_page_complete_custom),
        (on_response), (create_account):
        Implement the Advanced Settings edit button, by saving the account information, 
        for the Advanded Settings dialog to use directly from gconf, and removing it 
        if Finish is never clicked. There is still some UI strangeness, so this is not finished.
        Bug #5533 in the projects.maemo.org bugzilla.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-msg-view-window.c:
        (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget, 
        when opening a message window.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_custom_outgoing): Correct the position of the horizontal separator to 
        match the UI spec.
        
        * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL 
        before showing/hiding them, to avoid a crash when clicking on folders when there are no 
        gconf settings. I probably added more checks than necessary, but that is safer.
        
        * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op 
        variable to fix the build, but this seems to be used when it is still NULL.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-platform.h:
        * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
        * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
        * src/modest-main.c: Implement this function so we can avoid using 
        maemo-specific API from cross-platform code.
        (main):
        * src/modest-tny-account-store.c:
        (get_smtp_specific_transport_account_for_open_connection):
        * src/modest-ui-actions.c: (check_for_connection),
        (modest_ui_actions_on_item_not_found):
        Use modest_platform_connect_and_wait() and put #idefs around other 
        maemo-specific code, because only maemo currently has a way to 
        identify connection names.

2007-04-27  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-tny-account-store.h:
        * src/modest-tny-account-store.c:
        Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects 
        the connection-specific SMTP server settings in the configuration.
        
        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
        (on_idle_mail_to):
        * src/maemo/modest-main-window.c: (on_connection_changed),
        (connect_signals):
        * src/modest-main.c: (main), (start_ui), (send_mail):
        Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when 
        that is what is intended.
        
        * src/modest-ui-actions.c: (action_send), (action_receive),
        (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
        Use modest_tny_account_store_get_transport_account_for_open_connection() instead of 
        modest_tny_account_store_get_tny_account_by_account() so that the connection-specific 
        SMTP server is used when it is specified.
        
        (modest_ui_actions_on_send_receive): 
        Check that a connection is open before proceeding.
        Receive and then send, instead of vice-versa, as per the specification.

2007-04-26  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-mail-operation.c:
        (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build, 
        though I guess it should be something other than NULL.

2007-04-26  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_custom_incoming): Add the checkbox to the caption instead of adding the 
        combo twice, to avoid an g_warning and to make it visible again.
        * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is 
        attached before detaching it, to avoid a g_warning, and add comment about the implicit 
        (already intended) dereference when detaching, because we then recreate the menu.
        But I am not sure why the warning was happening, and it is possible that this is a memory 
        leak.

2007-04-25  Murray Cumming  <murrayc@murrayc.com>

        * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
        and uri_parse_mailto() utility functions.
        (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in 
        the mailto URI.
        * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.

2007-04-24  Murray Cumming  <murrayc@murrayc.com>

        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c:
        Use an idle callback to execute the modest code in the application's own thread.
        Remove the helloworld example method.
        Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be 
        parsed, and the open-message method is not implemented because this is not yet implemented in 
        modest itself.
        * libmodest-dbus-client/libmodest-dbus-client.c:
        (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
        (libmodest_dbus_client_open_message):
        * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
        
        * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and 
        body without crashing.
        
        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_mail_to.c:
        * tests/dbus_api/test_open_message.c: New tests for the new methods.

2007-04-24  Murray Cumming  <murrayc@murrayc.com>

        * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
        Added file to fix the build. Sorry.
        
        * src/dbus_api/Makefile.am:
        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.h:
        * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
        (modest_dbus_req_handler):
        Put constants in a separate header so it can be reused by the 
        client library, without duplication
        
        * libmodest-dbus-client/Makefile.am:
        * libmodest-dbus-client/libmodest-dbus-client.c:
        (libmodest_dbus_client_call_helloworld),
        (libmodfest_dbus_client_send_mail),
        (libmodfest_dbus_client_mailto),
        (libmodfest_dbus_client_open_message):
        * libmodest-dbus-client/libmodest-dbus-client.h:
        (Partly) Implement a send_mail D-Bus method.
        
        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_send_mail.c: (main): Added a test for 
        the send_email D-Bus method.

2007-04-24  Murray Cumming  <murrayc@murrayc.com>

        * Makefile.am:
        * configure.ac:
        * libmodest-dbus-client/Makefile.am:
        * libmodest-dbus-client/libmodest-dbus-client.c:
        * libmodest-dbus-client/libmodest-dbus-client.h:
        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library 
        for using the modest D-Bus API, and used that from the test. It is still just a helloworld.

2007-04-24  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_account_details):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details): Explicitly set auto-capitalization mode for the title 
        widgets, because this might not be the default in future versions of the Maemo GTK+. 
        However, I can not not get capitalization to work even in a simple test case.

2007-04-24  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_custom_incoming), (create_page_custom_outgoing):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details), (create_page_incoming),
        (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons, 
        instead of using gtk_check_button_with_label(), so they are aligned like the other 
        widgets, as per the UI spec.

2007-04-24  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        * src/widgets/modest-validating-entry.c:
        * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a 
        Modest prefix instead of an EasySetup prefix.

2007-04-23  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-validating-entry.h:
        * src/widgets/modest-validating-entry.c: (on_insert_text),
        Added easysetup_validating_entry_set_max_func(), used to set a callback 
        to call when the max number of characters is reached. GtkEntry has a max-length 
        already but is silent about it.

        * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
        (create_page_account_details), (create_page_user_details),
        (create_account):
        * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
        (create_page_account_details), (create_page_user_details),
        (create_page_outgoing):
        * src/modest-ui-actions.c: (modest_ui_actions_on_details): 
        Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per 
        the UI spec, when the user tries to enter more than the max number of characters.

2007-04-23  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_user_details), (create_page_custom_incoming),
        (create_page_custom_outgoing):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_user_details), (create_page_incoming),
        (create_page_outgoing):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init):
        Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is 
        not appropriate. Bad Maemo-specific defaults!.

2007-04-23  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
        (on_toggle_button_changed), (modest_signature_editor_dialog_init),
        (modest_signature_editor_dialog_set_settings): 
        Disable the label and textview when the checkbox is disabled, and use the 
        specified (UI spec) default signature text.

2007-04-23  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
        
        * src/modest-defs.h:
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        Added modest_account_mgr_get/set_signature(), using new gconf keys.
        
        * src/maemo/Makefile.am:
        * src/maemo/modest-signature-editor-dialog.c:
        * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures, 
        as per the UI spec.
        
        * src/maemo/modest-account-settings-dialog.h:
        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_finalize), (on_button_signature),
        (save_configuration): Use the new dialog when the Edit button is pressed, and 
        save the changes if necessary, as per the UI spec.

2007-04-23  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/Makefile.am:
        * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing, 
        based on maemo-develoers email from Dirk.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_welcome), (create_page_account_details),
        (create_page_user_details), (create_page_complete_easysetup),
        (create_page_custom_incoming), (create_page_custom_outgoing),
        (create_page_complete_custom),
        (modest_easysetup_wizard_dialog_init):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details), (create_page_user_details),
        (create_page_incoming), (create_page_outgoing),
        (modest_account_settings_dialog_init):
        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.

2007-04-23  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_account_details), (create_page_custom_outgoing),
        (create_page_complete_custom):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_user_details), (create_page_incoming),
        (create_page_outgoing):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init): 
        Use the correct (UI spec) port min/max, and use horizontal separators, 
        as per the UI spec.

2007-04-23  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (set_default_custom_servernames):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_incoming), (on_combo_outgoing_security_changed),
        (on_combo_incoming_security_changed), (create_page_outgoing),
        (modest_account_settings_dialog_set_account_name),
        (save_configuration):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (on_combo_security_changed),
        (modest_connection_specific_smtp_edit_window_init),
        (modest_connection_specific_smtp_edit_window_set_connection),
        (modest_connection_specific_smtp_edit_window_get_settings): 
        Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
        as per the UI spec.

2007-04-20  Murray Cumming  <murrayc@murrayc.com>

        * po/en_GB.po:
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_custom_outgoing), (create_page_complete_custom):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_user_details), (create_page_outgoing):
        * src/maemo/modest-account-view-window.c: (button_box_new):
        Use changed logical IDs as per the most recent UI spec:
        mcen_bd_emailsetup_edit -> mcen_bd_edit
        mcen_bd_emailsetup_delete -> mcen_bd_delete
        mcen_bd_emailsetup_close -> mcen_bd_close

2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>

        * configure.ac:
        * src/Makefile.am:
        * src/dbus_api/Makefile.am:
        * src/dbus_api/modest-dbus-callbacks.c:
        * src/dbus_api/modest-dbus-callbacks.h:
        * src/maemo/modest-platform.c: (modest_platform_init):
        Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld 
        method.
        * tests/Makefile.am:
        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.

2007-04-20  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        Removed unnecessary includes.

2007-04-20  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        * src/widgets/Makefile.am:
        * src/widgets/modest-easysetup-secureauth-combo-box.c:
        * src/widgets/modest-easysetup-secureauth-combo-box.h:
        * src/widgets/modest-easysetup-serversecurity-combo-box.c:
        * src/widgets/modest-easysetup-serversecurity-combo-box.h:
        * src/widgets/modest-secureauth-combo-box.c:
        * src/widgets/modest-secureauth-combo-box.h:
        * src/widgets/modest-serversecurity-combo-box.c:
        * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and 
        made the GObject names more consistent with the rest of the Modest code.

2007-04-20  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/Makefile.am:
        * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
        * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
        * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
        * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        * src/maemo/easysetup/modest-validating-entry.c:
        * src/maemo/easysetup/modest-validating-entry.h:
        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into 
        widgets/ because they are used outside of easysetup too. After checking in, 
        svn will allow me to rename them too.

2007-04-20  Murray Cumming  <murrayc@murrayc.com>

        * src/gnome/modest-msg-edit-window.c:
        (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a 
        linker error, to fix the build on the GNOME platform.
        modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(), 
        modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
        ifdefed out to avoid a warning.

2007-04-20  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the 
        use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs 
        some alternative for GTK+ 2.6.

2007-04-19  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-address-book.c: Added include to avoid a warning.

        * po/en_GB.po: Added missing mcen_bd_emailsetup_close string, 
        specified for EmailAccountsDialog in UI spec.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        * src/maemo/easysetup/modest-easysetup-wizard.h:
        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-account-settings-dialog.h:
        Reuse a member window widget for the connection-specific SMTP server accounts, 
        so we can tell it to create/save the accounts only if we actually save changes.

        * src/maemo/modest-connection-specific-smtp-edit-window.h:      
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_get_settings): 
        Return a struct instance for temporarily remembering the entered data.

        * src/maemo/modest-connection-specific-smtp-window.h:
        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_finalize),
        (modest_connection_specific_smtp_window_fill_with_connections),
        (on_button_edit),
        (modest_connection_specific_smtp_window_save_server_accounts),
        (update_model_server_names): Do not actually save data until asked, 
        when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
        
        (on_selection_changed),
        (modest_connection_specific_smtp_window_init): Disable the edit 
        button when nothing is selected.
        
        * src/modest-account-mgr-helpers.c:
        * src/modest-account-mgr-helpers.h: 
        Put modest_account_mgr_free_server_account_data() in the header now that I use the struct 
        elsewhere.

2007-04-19  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_unused_account_name),
        (modest_account_mgr_get_unused_account_display_name): Added these 
        utility functions, to avoid code duplication.

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_account_details), (create_account):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (on_combo_security_changed),
        (modest_connection_specific_smtp_edit_window_init),
        (modest_connection_specific_smtp_edit_window_save_settings):
        * src/maemo/modest-connection-specific-smtp-edit-window.h:
        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_finalize),
        (modest_connection_specific_smtp_window_fill_with_connections),
        (on_button_edit), (modest_connection_specific_smtp_window_init):
        * src/maemo/modest-connection-specific-smtp-window.h:
        Implementing saving of connection-specific server accounts.
        
        But I need to refactor this so we can save the data for each 
        possible connection-specific account and only actually create the server accounts 
        when the easysetup finished, or the OK button is pressed on the account settings 
        dialog.

2007-04-18  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (on_combo_security_changed): 
        (modest_connection_specific_smtp_edit_window_init):
        Auto-fill the port number as in the account settings.
        
        (modest_connection_specific_smtp_edit_window_set_connection):
        * src/maemo/modest-connection-specific-smtp-edit-window.h:
        * src/maemo/modest-connection-specific-smtp-window.c:
        (fill_with_connections), (on_button_edit),
        (modest_connection_specific_smtp_window_init): 
        Turn the edit window into a dialog to simplify the code, and 
        set a WM hint as in a GtkDialog, because only a popup can be on top of 
        another window in Maemo, and popups usually have no WM decoration.
        
        * src/modest-defs.h:
        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_set_connection_specific_smtp),
        (modest_account_mgr_remove_connection_specific_smtp),
        (modest_account_mgr_get_connection_specific_smtp):
        * src/modest-account-mgr-helpers.h: Some functions to write the 
        connection-specific SMTP server information. Not yet used.

        
        * src/widgets/modest-folder-view.c: (text_cell_data):
        Fix a warning about an uninitialized variable.
        (on_configuration_key_changed): Put an #ifdef around the use 
        of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.

2007-04-18  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.h:
        * src/maemo/modest-account-settings-dialog.c:
        Added connect_for_modified() utility function to mark the new modified boolean.
        
        (create_page_account_details), (create_page_user_details),
        (create_page_incoming), (create_page_outgoing), (on_response),
        (modest_account_settings_dialog_init),
        (modest_account_settings_dialog_set_account_name):
        Only warn about unsaved changes when there are actually unsaved changes.
        
        * src/modest-account-mgr-helpers.c:
        * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information 
        into the ModestServerAccountData struct. I do not use it yet, but someone might expect 
        to get the data from there in future.

2007-04-18  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-defs.h:

        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        Store the security account setting in a single conf key instead of using 
        the options list, so that the list is left for just the to-be-removed camel hack, 
        and because gconf_client_set_list() is failing for some reason.

        * src/modest-account-mgr.c:
        (modest_account_mgr_add_server_account):
        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_set_account_name),
        (save_configuration): Use the renamed functions.


2007-04-18  Murray Cumming  <murrayc@murrayc.com>

        * src/widgets/Makefile.am:
        * src/widgets/modest-limit-retrieve-combo-box.c:
        * src/widgets/modest-limit-retrieve-combo-box.h:
        * src/widgets/modest-retrieve-combo-box.c:
        * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in 
        the account settings dialog.
        
        * src/modest-defs.h:
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        (modest_server_account_get_option_secure_auth),
        (modest_server_account_set_option_secure_auth):
        * src/modest-account-mgr.c:
        (modest_account_mgr_add_server_account):
        Use the existing AUTH_MECH conf key for the secure-auth setting, 
        instead of putting it in the list options, because this was actually used already.
        
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details),
        (modest_account_settings_dialog_set_account_name),
        (save_configuration):
        * src/maemo/modest-account-settings-dialog.h:
        Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
        Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.

2007-04-18  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
        * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
        Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()

        * src/modest-defs.h:
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_incoming), (on_combo_outgoing_security_changed),
        (on_combo_incoming_security_changed), (create_page_outgoing),
        (modest_account_settings_dialog_set_account_name),
        (save_configuration): Load/Save the port number, and change it when the 
        security combo changes, to suitable defaults.

2007-04-17  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr.c:
        (modest_account_mgr_add_server_account): Set the security and secure-auth 
        options, and add a comment saying that the other camel-specific options should be 
        removed in future.

2007-04-17  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something, 
        found by valgrind.
        * src/modest-tny-account-store.c: (account_list_free),
        (on_account_changed): Add a TODO comment about a valgrind error, caused by using 
        cursor->data after unreffing it. But there is some strange stuff there so it might not be 
        easy to fix.

2007-04-17  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-protocol-info.c:
        * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it 
        is required by our UI spec. Maybe something in our implementation will use this eventually.
        * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c: 
        (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value 
        instead of the previous 0 placeholder.
        
        * src/modest-defs.h: Added gconf list pair key names and value strings for the security and 
        secure-auth settings.
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        (modest_server_account_data_get_option_secure_auth),
        (modest_server_account_set_option_secure_auth),
        (modest_server_account_data_get_option_security),
        (modest_server_account_set_option_security): Added this API for getting and setting the security 
        and secure-auth settings.
        
        * src/maemo/modest-account-settings-dialog.h:
        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_finalize), (check_data),
        (on_response): Store the original title as well as the name, to avoid unnececessary warnings 
        about changing titles.
        (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
        (save_configuration): Save the security and secure-auth settings.

        * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this 
        is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.

2007-04-17  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-defs.h: 
        * src/modest-account-mgr.c:
        (modest_account_mgr_add_server_account):
        Added and used defines for the options key and value pair strings, 
        that are used so far, though they do not seem to correspond to anything in our 
        UI specs or ModestProtocol enum.
        
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        (compare_option_strings_for_name),
        (modest_server_account_data_get_option_value),
        (modest_server_account_data_get_option_bool),
        (modest_account_mgr_get_server_account_option):
        Added helper functions for parsing the options GSList.

2007-04-16  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial 
        display name is based on the supplied account name.
        * src/modest-account-mgr.c:
        * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(), 
        with an inefficient, but good-enough, implementation.
        
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_account_details), (on_before_next), (create_account): 
        Check for existing display names rather than (non-user-visible) account names, and just 
        create and set a unique account name at the end.
        
        * src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_init),
        (modest_account_settings_dialog_set_account_name),
        (create_page_incoming): Show the display name, instead of the account name.
        (on_response): Do some (not all) extra checks, as in the UI spec.
        (save_configuration): Save the display name if it was changed.

2007-04-16  Murray Cumming  <murrayc@murrayc.com>

        * po/en_GB.po: Added needed logical ID and translation.
        * src/widgets/modest-account-view.c: (on_account_default_toggled),
        (init_view): Made the is-default column clicking work.

2007-04-16  Murray Cumming  <murrayc@murrayc.com>

        * configure.ac:
        * src/maemo/easysetup/Makefile.am:
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (modest_easysetup_wizard_dialog_init):
        * src/maemo/easysetup/provider-data-test.keyfile:
        * src/maemo/easysetup/provider-data.keyfile: 
        Moved the provider data file to the new modest-providers-data package and used it from there.

2007-04-16  Murray Cumming  <murrayc@murrayc.com>

        * src/modest-local-folder-info.c:
        (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string. 
        N_() was already used on the static strings, but this just marks it for translation without 
        using the translation.

2007-04-06  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.c:
        (create_page_incoming),
        (modest_account_settings_dialog_set_account_name): 
        Added comments about the need for new API in ModestAccountMgr to handle the authentication 
        and secure-connection stuff that is stored in the options GSList* with hard-coded names.
        I will do this if nobody else gets there first.

2007-04-06  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-settings-dialog.c: (save_configuration): 
        Saved much of the incoming and outgoing data too, though I cannot yet see how to 
        save the security stuff.

2007-04-06  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
        Set the email address and user fullname, which I now see must be 
        done separately.
        
        * src/maemo/modest-account-settings-dialog.h:
        * src/maemo/modest-account-settings-dialog.c:
         (on_response),
        (modest_account_settings_dialog_set_account_name): Show the email address, fullname, 
        leave-on-server and authentication.
        (save_configuration): Save most of the non-server-account specific stuff, but I don't see 
        how to do the rest.

2007-04-06  Murray Cumming  <murrayc@murrayc.com>


        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-account-settings-dialog.h:
        Most (but not all) of the widgets are now present as specified by the UI spec.
        No changes are yet saved, and some details are not properly shown yet.
        
        * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.

2007-04-06  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/Makefile.am:
        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit 
        an existing account. Doesn't do much yet.
        
        * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): 
        Open the accounts settings dialog when Edit is clicked.

2007-04-05  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/Makefile.am:
        * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
        (load_from_file): 
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (modest_easysetup_wizard_dialog_init):
        Try to get the source directory from the build system,
        instead of hard-coding "./" into the source code, when opening our local 
        copies of the configuration files.
        But this still fails when opening the wizard from the Accounts window, 
        maybe because the working directory seems to change at runtime.
        So the wizard will fail the second time unless you copy the files into their 
        proper locations - see the stdout warnings for the paths.
        
        (create_page_account_details),(on_before_next): 
        Check for existing non-server accounts instead of server accounts, 
        so the default account name is useful again, and to prevent trying to 
        recreate accounts.
        
        * src/maemo/modest-account-view-window.c: (on_new_button_clicked): 
        Show the wizard when New is clicked.
        
        * src/widgets/modest-account-view.c: (on_account_default_toggled),
        (init_view): Show the column headers, and show the columns that are 
        specified in the UI specs. However, something in Maemo's GTK+ prevents 
        us from handling the GtkCellRendererToggle::toggled signal, so we cannot 
        change the default account. This is despite unsetting the special properties.

2007-04-05  Murray Cumming  <murrayc@murrayc.com>

        * docs/reference/modest-design.sgml: Corrected spelling mistake.
        * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
        Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
        This seems to be how this should be used. If it is, then I will update the AccountMgr documentation 
        to make that clearer.
        * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.

2007-04-05  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/modest-account-view-window.c:
        (modest_account_view_window_init),
        (modest_account_view_window_new):
        Use the same buttons as specified in the 
        UI spec. Add the widgets to the vbox and action_area instead of just assigning them to 
        the existing widgets, which never had a chance of working.
        Put the ModestAccountView treeview in a scrolled window.
        Do not repeat the initialization in both _init() and _new().
        
        * src/widgets/modest-account-view.c: (update_account_view):
        Add a warning about modest_account_mgr_account_names() returning NULL, which is why 
        this widget and window shows no accounts.
        
        * po/en_GB.po: Added translations needed for the dialog button logical IDs.
        
2007-04-05  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
        (create_account): Do a sanity check, showing that modest_account_mgr_account_names() 
        returns NULL after modest_account_mgr_add_server_account() returned TRUE, 
        which seems wrong.
        
        * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
        * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no 
        accounts exist yet, as in the UI spec.
        
        * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.

2007-04-05  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/Makefile.am:
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        * src/maemo/modest-connection-specific-smtp-edit-window.h: 
        New window for editing connection-specific smtp details.
        Not fully implemented.

        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_finalize) :
        unref the tree model.
        (on_button_edit): Show the edit window.

2007-04-05  Murray Cumming  <murrayc@murrayc.com>

        * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol 
        error for me.
        
        * src/maemo/Makefile.am:
        * src/maemo/modest-connection-specific-smtp-window.c:
        * src/maemo/modest-connection-specific-smtp-window.h:
        New window for showing the list of connections, for connection-specific 
        SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_custom_outgoing): Show the new window when the button is clicked.

2007-04-04  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
        * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
        * src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_insert_image):
        * src/modest-conf.c: (modest_conf_key_escape):
        * src/modest-mail-operation.c:
        (modest_mail_operation_send_new_mail):
        * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
        (modest_ui_actions_on_new_account):
        * src/widgets/modest-attachment-view.c: (update_filename_request):
        * src/widgets/modest-mail-header-view.c: 
        Corrected warnings that were breaking the build, by commenting out unused variables, 
        and a function, and by including a header.

2007-04-04  Murray Cumming  <murrayc@murrayc.com>

        * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h, 
        so we can #ifdef around platform-specific code when necessary.
        * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO 
        to allow this to build for the GNOME platform too.

2007-04-04  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        Added util_increment_name() and used it in create_page_account_details() 
        to make sure that the default account name is always a new name.
        
        (modest_easysetup_wizard_dialog_init), 
        (set_default_custom_servernames): Some minor memory management fixes.

2007-04-04  Murray Cumming  <murrayc@murrayc.com>

        * Makefile.am:
        * configure.ac:
        * src/modest-runtime.c: (init_i18n): Restored the translation 
        infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR 
        are defined in config.h, and the translations are installed.
        
        * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE 
        is defined for translation.

2007-04-03  Murray Cumming  <murrayc@murrayc.com>

        * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
        (load_from_file):
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (modest_easysetup_wizard_dialog_init):
        * src/maemo/easysetup/modest-presets.c: (modest_presets_new): 
        Use realistic paths (though they should use $prefix generically) to the 
        mcc_mapping and provider-data.keyfile files which might work when they 
        are installed by the future version of the operator-wizard package, 
        and then fallback to paths in our source code, with an explanatory 
        warning.

2007-04-03  Murray Cumming  <murrayc@murrayc.com>

        * configure.ac:
        * src/Makefile.am:
        * src/maemo/Makefile.am:
        * src/maemo/easysetup/: Added files from the previously-exernal 
        osso-modest-easysetup.
        * src/maemo/modest-main-window-ui.h:
        * src/modest-ui-actions.c: 
        * src/modest-ui-actions.h:
        Added modest_ui_actions_on_new_account() as a signal handler for the 
        New Account menu item. It shows the easysetup wizard.
        * po/en_GB.po: Added additional needed logical IDs and translations.
        
Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
Apparently ChangeLog is not used for some vague Nokia legal reasons.