git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-msg-edit-window.c:
   4         (modest_msg_edit_window_select_color),
   5         (modest_msg_edit_window_select_background_color): 2 const corrections and
   6         moving 2 #endifs before closing brackets, to fix the build.
   7
   8 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
   9
  10         * src/maemo/easysetup/modest-easysetup-wizard.h:
  11         * src/maemo/easysetup/modest-easysetup-wizard.c:
  12         (modest_easysetup_wizard_dialog_finalize),
  13         (on_button_edit_advanced_settings), (create_page_complete_custom),
  14         (on_response), (create_account):
  15         Implement the Advanced Settings edit button, by saving the account information,
  16         for the Advanded Settings dialog to use directly from gconf, and removing it
  17         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
  18         Bug #5533 in the projects.maemo.org bugzilla.
  19
  20 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  21
  22         * src/maemo/modest-msg-view-window.c:
  23         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
  24         when opening a message window.
  25
  26 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  27
  28         * src/maemo/easysetup/modest-easysetup-wizard.c:
  29         (create_page_custom_outgoing): Correct the position of the horizontal separator to
  30         match the UI spec.
  31
  32         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
  33         before showing/hiding them, to avoid a crash when clicking on folders when there are no
  34         gconf settings. I probably added more checks than necessary, but that is safer.
  35
  36         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
  37         variable to fix the build, but this seems to be used when it is still NULL.
  38
  39 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  40
  41         * src/modest-platform.h:
  42         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
  43         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
  44         * src/modest-main.c: Implement this function so we can avoid using
  45         maemo-specific API from cross-platform code.
  46         (main):
  47         * src/modest-tny-account-store.c:
  48         (get_smtp_specific_transport_account_for_open_connection):
  49         * src/modest-ui-actions.c: (check_for_connection),
  50         (modest_ui_actions_on_item_not_found):
  51         Use modest_platform_connect_and_wait() and put #idefs around other
  52         maemo-specific code, because only maemo currently has a way to
  53         identify connection names.
  54
  55 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  56
  57         * src/modest-tny-account-store.h:
  58         * src/modest-tny-account-store.c:
  59         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
  60         the connection-specific SMTP server settings in the configuration.
  61
  62         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
  63         (on_idle_mail_to):
  64         * src/maemo/modest-main-window.c: (on_connection_changed),
  65         (connect_signals):
  66         * src/modest-main.c: (main), (start_ui), (send_mail):
  67         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
  68         that is what is intended.
  69
  70         * src/modest-ui-actions.c: (action_send), (action_receive),
  71         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
  72         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
  73         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
  74         SMTP server is used when it is specified.
  75
  76         (modest_ui_actions_on_send_receive):
  77         Check that a connection is open before proceeding.
  78         Receive and then send, instead of vice-versa, as per the specification.
  79
  80 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  81
  82         * src/modest-mail-operation.c:
  83         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
  84         though I guess it should be something other than NULL.
  85
  86 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  87
  88         * src/maemo/easysetup/modest-easysetup-wizard.c:
  89         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
  90         combo twice, to avoid an g_warning and to make it visible again.
  91         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
  92         attached before detaching it, to avoid a g_warning, and add comment about the implicit
  93         (already intended) dereference when detaching, because we then recreate the menu.
  94         But I am not sure why the warning was happening, and it is possible that this is a memory
  95         leak.
  96
  97 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
  98
  99         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 100         and uri_parse_mailto() utility functions.
 101         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 102         the mailto URI.
 103         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 104
 105 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 106
 107         * src/dbus_api/modest-dbus-api.h:
 108         * src/dbus_api/modest-dbus-callbacks.c:
 109         Use an idle callback to execute the modest code in the application's own thread.
 110         Remove the helloworld example method.
 111         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 112         parsed, and the open-message method is not implemented because this is not yet implemented in
 113         modest itself.
 114         * libmodest-dbus-client/libmodest-dbus-client.c:
 115         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 116         (libmodest_dbus_client_open_message):
 117         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 118
 119         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 120         body without crashing.
 121
 122         * tests/dbus_api/Makefile.am:
 123         * tests/dbus_api/test_mail_to.c:
 124         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 125
 126 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 127
 128         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 129         Added file to fix the build. Sorry.
 130
 131         * src/dbus_api/Makefile.am:
 132         * src/dbus_api/modest-dbus-api.h:
 133         * src/dbus_api/modest-dbus-callbacks.h:
 134         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 135         (modest_dbus_req_handler):
 136         Put constants in a separate header so it can be reused by the
 137         client library, without duplication
 138
 139         * libmodest-dbus-client/Makefile.am:
 140         * libmodest-dbus-client/libmodest-dbus-client.c:
 141         (libmodest_dbus_client_call_helloworld),
 142         (libmodfest_dbus_client_send_mail),
 143         (libmodfest_dbus_client_mailto),
 144         (libmodfest_dbus_client_open_message):
 145         * libmodest-dbus-client/libmodest-dbus-client.h:
 146         (Partly) Implement a send_mail D-Bus method.
 147
 148         * tests/dbus_api/Makefile.am:
 149         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 150         the send_email D-Bus method.
 151
 152 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 153
 154         * Makefile.am:
 155         * configure.ac:
 156         * libmodest-dbus-client/Makefile.am:
 157         * libmodest-dbus-client/libmodest-dbus-client.c:
 158         * libmodest-dbus-client/libmodest-dbus-client.h:
 159         * tests/dbus_api/Makefile.am:
 160         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 161         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 162
 163 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 164
 165         * src/maemo/easysetup/modest-easysetup-wizard.c:
 166         (create_page_account_details):
 167         * src/maemo/modest-account-settings-dialog.c:
 168         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 169         widgets, because this might not be the default in future versions of the Maemo GTK+.
 170         However, I can not not get capitalization to work even in a simple test case.
 171
 172 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 173
 174         * src/maemo/easysetup/modest-easysetup-wizard.c:
 175         (create_page_custom_incoming), (create_page_custom_outgoing):
 176         * src/maemo/modest-account-settings-dialog.c:
 177         (create_page_account_details), (create_page_incoming),
 178         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 179         instead of using gtk_check_button_with_label(), so they are aligned like the other
 180         widgets, as per the UI spec.
 181
 182 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 183
 184         * src/maemo/easysetup/modest-easysetup-wizard.c:
 185         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 186         * src/widgets/modest-validating-entry.c:
 187         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 188         Modest prefix instead of an EasySetup prefix.
 189
 190 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 191
 192         * src/widgets/modest-validating-entry.h:
 193         * src/widgets/modest-validating-entry.c: (on_insert_text),
 194         Added easysetup_validating_entry_set_max_func(), used to set a callback
 195         to call when the max number of characters is reached. GtkEntry has a max-length
 196         already but is silent about it.
 197
 198         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 199         (create_page_account_details), (create_page_user_details),
 200         (create_account):
 201         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 202         (create_page_account_details), (create_page_user_details),
 203         (create_page_outgoing):
 204         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 205         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 206         the UI spec, when the user tries to enter more than the max number of characters.
 207
 208 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 209
 210         * src/maemo/easysetup/modest-easysetup-wizard.c:
 211         (create_page_user_details), (create_page_custom_incoming),
 212         (create_page_custom_outgoing):
 213         * src/maemo/modest-account-settings-dialog.c:
 214         (create_page_user_details), (create_page_incoming),
 215         (create_page_outgoing):
 216         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 217         (modest_connection_specific_smtp_edit_window_init):
 218         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 219         not appropriate. Bad Maemo-specific defaults!.
 220
 221 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 222
 223         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 224         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 225         (modest_signature_editor_dialog_set_settings):
 226         Disable the label and textview when the checkbox is disabled, and use the
 227         specified (UI spec) default signature text.
 228
 229 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 230
 231         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 232         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 233
 234         * src/modest-defs.h:
 235         * src/modest-account-mgr-helpers.h:
 236         * src/modest-account-mgr-helpers.c:
 237         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 238
 239         * src/maemo/Makefile.am:
 240         * src/maemo/modest-signature-editor-dialog.c:
 241         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 242         as per the UI spec.
 243
 244         * src/maemo/modest-account-settings-dialog.h:
 245         * src/maemo/modest-account-settings-dialog.c:
 246         (modest_account_settings_dialog_finalize), (on_button_signature),
 247         (save_configuration): Use the new dialog when the Edit button is pressed, and
 248         save the changes if necessary, as per the UI spec.
 249
 250 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 251
 252         * src/maemo/Makefile.am:
 253         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 254         based on maemo-develoers email from Dirk.
 255
 256         * src/maemo/easysetup/modest-easysetup-wizard.c:
 257         (create_page_welcome), (create_page_account_details),
 258         (create_page_user_details), (create_page_complete_easysetup),
 259         (create_page_custom_incoming), (create_page_custom_outgoing),
 260         (create_page_complete_custom),
 261         (modest_easysetup_wizard_dialog_init):
 262         * src/maemo/modest-account-settings-dialog.c:
 263         (create_page_account_details), (create_page_user_details),
 264         (create_page_incoming), (create_page_outgoing),
 265         (modest_account_settings_dialog_init):
 266         * src/maemo/modest-connection-specific-smtp-window.c:
 267         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 268
 269 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 270
 271         * src/maemo/easysetup/modest-easysetup-wizard.c:
 272         (create_page_account_details), (create_page_custom_outgoing),
 273         (create_page_complete_custom):
 274         * src/maemo/modest-account-settings-dialog.c:
 275         (create_page_user_details), (create_page_incoming),
 276         (create_page_outgoing):
 277         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 278         (modest_connection_specific_smtp_edit_window_init):
 279         Use the correct (UI spec) port min/max, and use horizontal separators,
 280         as per the UI spec.
 281
 282 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 283
 284         * src/maemo/easysetup/modest-easysetup-wizard.c:
 285         (set_default_custom_servernames):
 286         * src/maemo/modest-account-settings-dialog.c:
 287         (create_page_incoming), (on_combo_outgoing_security_changed),
 288         (on_combo_incoming_security_changed), (create_page_outgoing),
 289         (modest_account_settings_dialog_set_account_name),
 290         (save_configuration):
 291         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 292         (on_combo_security_changed),
 293         (modest_connection_specific_smtp_edit_window_init),
 294         (modest_connection_specific_smtp_edit_window_set_connection),
 295         (modest_connection_specific_smtp_edit_window_get_settings):
 296         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 297         as per the UI spec.
 298
 299 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 300
 301         * po/en_GB.po:
 302         * src/maemo/easysetup/modest-easysetup-wizard.c:
 303         (create_page_custom_outgoing), (create_page_complete_custom):
 304         * src/maemo/modest-account-settings-dialog.c:
 305         (create_page_user_details), (create_page_outgoing):
 306         * src/maemo/modest-account-view-window.c: (button_box_new):
 307         Use changed logical IDs as per the most recent UI spec:
 308         mcen_bd_emailsetup_edit -> mcen_bd_edit
 309         mcen_bd_emailsetup_delete -> mcen_bd_delete
 310         mcen_bd_emailsetup_close -> mcen_bd_close
 311
 312 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 313
 314         * configure.ac:
 315         * src/Makefile.am:
 316         * src/dbus_api/Makefile.am:
 317         * src/dbus_api/modest-dbus-callbacks.c:
 318         * src/dbus_api/modest-dbus-callbacks.h:
 319         * src/maemo/modest-platform.c: (modest_platform_init):
 320         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 321         method.
 322         * tests/Makefile.am:
 323         * tests/dbus_api/Makefile.am:
 324         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 325
 326 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 327
 328         * src/maemo/modest-account-settings-dialog.c:
 329         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 330         Removed unnecessary includes.
 331
 332 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 333
 334         * src/maemo/easysetup/modest-easysetup-wizard.c:
 335         * src/maemo/modest-account-settings-dialog.c:
 336         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 337         * src/widgets/Makefile.am:
 338         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 339         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 340         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 341         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 342         * src/widgets/modest-secureauth-combo-box.c:
 343         * src/widgets/modest-secureauth-combo-box.h:
 344         * src/widgets/modest-serversecurity-combo-box.c:
 345         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 346         made the GObject names more consistent with the rest of the Modest code.
 347
 348 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 349
 350         * src/maemo/easysetup/Makefile.am:
 351         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 352         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 353         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 354         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 355         * src/maemo/easysetup/modest-easysetup-wizard.c:
 356         * src/maemo/easysetup/modest-validating-entry.c:
 357         * src/maemo/easysetup/modest-validating-entry.h:
 358         * src/maemo/modest-account-settings-dialog.c:
 359         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 360         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 361         widgets/ because they are used outside of easysetup too. After checking in,
 362         svn will allow me to rename them too.
 363
 364 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 365
 366         * src/gnome/modest-msg-edit-window.c:
 367         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 368         linker error, to fix the build on the GNOME platform.
 369         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 370         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 371         ifdefed out to avoid a warning.
 372
 373 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 374
 375         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 376         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 377         some alternative for GTK+ 2.6.
 378
 379 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 380
 381         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 382
 383         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 384         specified for EmailAccountsDialog in UI spec.
 385
 386         * src/maemo/easysetup/modest-easysetup-wizard.c:
 387         * src/maemo/easysetup/modest-easysetup-wizard.h:
 388         * src/maemo/modest-account-settings-dialog.c:
 389         * src/maemo/modest-account-settings-dialog.h:
 390         Reuse a member window widget for the connection-specific SMTP server accounts,
 391         so we can tell it to create/save the accounts only if we actually save changes.
 392
 393         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 394         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 395         (modest_connection_specific_smtp_edit_window_get_settings):
 396         Return a struct instance for temporarily remembering the entered data.
 397
 398         * src/maemo/modest-connection-specific-smtp-window.h:
 399         * src/maemo/modest-connection-specific-smtp-window.c:
 400         (modest_connection_specific_smtp_window_finalize),
 401         (modest_connection_specific_smtp_window_fill_with_connections),
 402         (on_button_edit),
 403         (modest_connection_specific_smtp_window_save_server_accounts),
 404         (update_model_server_names): Do not actually save data until asked,
 405         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 406
 407         (on_selection_changed),
 408         (modest_connection_specific_smtp_window_init): Disable the edit
 409         button when nothing is selected.
 410
 411         * src/modest-account-mgr-helpers.c:
 412         * src/modest-account-mgr-helpers.h:
 413         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 414         elsewhere.
 415
 416 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 417
 418         * src/modest-account-mgr-helpers.h:
 419         * src/modest-account-mgr-helpers.c:
 420         (modest_account_mgr_get_unused_account_name),
 421         (modest_account_mgr_get_unused_account_display_name): Added these
 422         utility functions, to avoid code duplication.
 423
 424         * src/maemo/easysetup/modest-easysetup-wizard.c:
 425         (create_page_account_details), (create_account):
 426         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 427         (on_combo_security_changed),
 428         (modest_connection_specific_smtp_edit_window_init),
 429         (modest_connection_specific_smtp_edit_window_save_settings):
 430         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 431         * src/maemo/modest-connection-specific-smtp-window.c:
 432         (modest_connection_specific_smtp_window_finalize),
 433         (modest_connection_specific_smtp_window_fill_with_connections),
 434         (on_button_edit), (modest_connection_specific_smtp_window_init):
 435         * src/maemo/modest-connection-specific-smtp-window.h:
 436         Implementing saving of connection-specific server accounts.
 437
 438         But I need to refactor this so we can save the data for each
 439         possible connection-specific account and only actually create the server accounts
 440         when the easysetup finished, or the OK button is pressed on the account settings
 441         dialog.
 442
 443 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 444
 445         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 446         (on_combo_security_changed):
 447         (modest_connection_specific_smtp_edit_window_init):
 448         Auto-fill the port number as in the account settings.
 449
 450         (modest_connection_specific_smtp_edit_window_set_connection):
 451         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 452         * src/maemo/modest-connection-specific-smtp-window.c:
 453         (fill_with_connections), (on_button_edit),
 454         (modest_connection_specific_smtp_window_init):
 455         Turn the edit window into a dialog to simplify the code, and
 456         set a WM hint as in a GtkDialog, because only a popup can be on top of
 457         another window in Maemo, and popups usually have no WM decoration.
 458
 459         * src/modest-defs.h:
 460         * src/modest-account-mgr-helpers.c:
 461         (modest_account_mgr_set_connection_specific_smtp),
 462         (modest_account_mgr_remove_connection_specific_smtp),
 463         (modest_account_mgr_get_connection_specific_smtp):
 464         * src/modest-account-mgr-helpers.h: Some functions to write the
 465         connection-specific SMTP server information. Not yet used.
 466
 467
 468         * src/widgets/modest-folder-view.c: (text_cell_data):
 469         Fix a warning about an uninitialized variable.
 470         (on_configuration_key_changed): Put an #ifdef around the use
 471         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 472
 473 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 474
 475         * src/maemo/modest-account-settings-dialog.h:
 476         * src/maemo/modest-account-settings-dialog.c:
 477         Added connect_for_modified() utility function to mark the new modified boolean.
 478
 479         (create_page_account_details), (create_page_user_details),
 480         (create_page_incoming), (create_page_outgoing), (on_response),
 481         (modest_account_settings_dialog_init),
 482         (modest_account_settings_dialog_set_account_name):
 483         Only warn about unsaved changes when there are actually unsaved changes.
 484
 485         * src/modest-account-mgr-helpers.c:
 486         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 487         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 488         to get the data from there in future.
 489
 490 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 491
 492         * src/modest-defs.h:
 493
 494         * src/modest-account-mgr-helpers.h:
 495         * src/modest-account-mgr-helpers.c:
 496         Store the security account setting in a single conf key instead of using
 497         the options list, so that the list is left for just the to-be-removed camel hack,
 498         and because gconf_client_set_list() is failing for some reason.
 499
 500         * src/modest-account-mgr.c:
 501         (modest_account_mgr_add_server_account):
 502         * src/maemo/modest-account-settings-dialog.c:
 503         (modest_account_settings_dialog_set_account_name),
 504         (save_configuration): Use the renamed functions.
 505
 506
 507 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 508
 509         * src/widgets/Makefile.am:
 510         * src/widgets/modest-limit-retrieve-combo-box.c:
 511         * src/widgets/modest-limit-retrieve-combo-box.h:
 512         * src/widgets/modest-retrieve-combo-box.c:
 513         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 514         the account settings dialog.
 515
 516         * src/modest-defs.h:
 517         * src/modest-account-mgr-helpers.h:
 518         * src/modest-account-mgr-helpers.c:
 519         (modest_server_account_get_option_secure_auth),
 520         (modest_server_account_set_option_secure_auth):
 521         * src/modest-account-mgr.c:
 522         (modest_account_mgr_add_server_account):
 523         Use the existing AUTH_MECH conf key for the secure-auth setting,
 524         instead of putting it in the list options, because this was actually used already.
 525
 526         * src/maemo/modest-account-settings-dialog.c:
 527         (create_page_account_details),
 528         (modest_account_settings_dialog_set_account_name),
 529         (save_configuration):
 530         * src/maemo/modest-account-settings-dialog.h:
 531         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 532         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 533
 534 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 535
 536         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 537         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 538         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 539
 540         * src/modest-defs.h:
 541         * src/maemo/modest-account-settings-dialog.c:
 542         (create_page_incoming), (on_combo_outgoing_security_changed),
 543         (on_combo_incoming_security_changed), (create_page_outgoing),
 544         (modest_account_settings_dialog_set_account_name),
 545         (save_configuration): Load/Save the port number, and change it when the
 546         security combo changes, to suitable defaults.
 547
 548 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 549
 550         * src/modest-account-mgr.c:
 551         (modest_account_mgr_add_server_account): Set the security and secure-auth
 552         options, and add a comment saying that the other camel-specific options should be
 553         removed in future.
 554
 555 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 556
 557         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 558         found by valgrind.
 559         * src/modest-tny-account-store.c: (account_list_free),
 560         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 561         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 562         easy to fix.
 563
 564 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 565
 566         * src/modest-protocol-info.c:
 567         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 568         is required by our UI spec. Maybe something in our implementation will use this eventually.
 569         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 570         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 571         instead of the previous 0 placeholder.
 572
 573         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 574         secure-auth settings.
 575         * src/modest-account-mgr-helpers.h:
 576         * src/modest-account-mgr-helpers.c:
 577         (modest_server_account_data_get_option_secure_auth),
 578         (modest_server_account_set_option_secure_auth),
 579         (modest_server_account_data_get_option_security),
 580         (modest_server_account_set_option_security): Added this API for getting and setting the security
 581         and secure-auth settings.
 582
 583         * src/maemo/modest-account-settings-dialog.h:
 584         * src/maemo/modest-account-settings-dialog.c:
 585         (modest_account_settings_dialog_finalize), (check_data),
 586         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 587         about changing titles.
 588         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 589         (save_configuration): Save the security and secure-auth settings.
 590
 591         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 592         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 593
 594 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 595
 596         * src/modest-defs.h:
 597         * src/modest-account-mgr.c:
 598         (modest_account_mgr_add_server_account):
 599         Added and used defines for the options key and value pair strings,
 600         that are used so far, though they do not seem to correspond to anything in our
 601         UI specs or ModestProtocol enum.
 602
 603         * src/modest-account-mgr-helpers.h:
 604         * src/modest-account-mgr-helpers.c:
 605         (compare_option_strings_for_name),
 606         (modest_server_account_data_get_option_value),
 607         (modest_server_account_data_get_option_bool),
 608         (modest_account_mgr_get_server_account_option):
 609         Added helper functions for parsing the options GSList.
 610
 611 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 612
 613         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 614         display name is based on the supplied account name.
 615         * src/modest-account-mgr.c:
 616         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 617         with an inefficient, but good-enough, implementation.
 618
 619         * src/maemo/easysetup/modest-easysetup-wizard.c:
 620         (create_page_account_details), (on_before_next), (create_account):
 621         Check for existing display names rather than (non-user-visible) account names, and just
 622         create and set a unique account name at the end.
 623
 624         * src/maemo/modest-account-settings-dialog.c:
 625         (modest_account_settings_dialog_init),
 626         (modest_account_settings_dialog_set_account_name),
 627         (create_page_incoming): Show the display name, instead of the account name.
 628         (on_response): Do some (not all) extra checks, as in the UI spec.
 629         (save_configuration): Save the display name if it was changed.
 630
 631 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 632
 633         * po/en_GB.po: Added needed logical ID and translation.
 634         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 635         (init_view): Made the is-default column clicking work.
 636
 637 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 638
 639         * configure.ac:
 640         * src/maemo/easysetup/Makefile.am:
 641         * src/maemo/easysetup/modest-easysetup-wizard.c:
 642         (modest_easysetup_wizard_dialog_init):
 643         * src/maemo/easysetup/provider-data-test.keyfile:
 644         * src/maemo/easysetup/provider-data.keyfile:
 645         Moved the provider data file to the new modest-providers-data package and used it from there.
 646
 647 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * src/modest-local-folder-info.c:
 650         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 651         N_() was already used on the static strings, but this just marks it for translation without
 652         using the translation.
 653
 654 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 655
 656         * src/maemo/modest-account-settings-dialog.c:
 657         (create_page_incoming),
 658         (modest_account_settings_dialog_set_account_name):
 659         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 660         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 661         I will do this if nobody else gets there first.
 662
 663 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 664
 665         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 666         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 667         save the security stuff.
 668
 669 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 670
 671         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 672         Set the email address and user fullname, which I now see must be
 673         done separately.
 674
 675         * src/maemo/modest-account-settings-dialog.h:
 676         * src/maemo/modest-account-settings-dialog.c:
 677          (on_response),
 678         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 679         leave-on-server and authentication.
 680         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 681         how to do the rest.
 682
 683 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 684
 685
 686         * src/maemo/modest-account-settings-dialog.c:
 687         * src/maemo/modest-account-settings-dialog.h:
 688         Most (but not all) of the widgets are now present as specified by the UI spec.
 689         No changes are yet saved, and some details are not properly shown yet.
 690
 691         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 692
 693 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 694
 695         * src/maemo/Makefile.am:
 696         * src/maemo/modest-account-settings-dialog.c:
 697         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 698         an existing account. Doesn't do much yet.
 699
 700         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 701         Open the accounts settings dialog when Edit is clicked.
 702
 703 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 704
 705         * src/maemo/easysetup/Makefile.am:
 706         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 707         (load_from_file):
 708         * src/maemo/easysetup/modest-easysetup-wizard.c:
 709         (modest_easysetup_wizard_dialog_init):
 710         Try to get the source directory from the build system,
 711         instead of hard-coding "./" into the source code, when opening our local
 712         copies of the configuration files.
 713         But this still fails when opening the wizard from the Accounts window,
 714         maybe because the working directory seems to change at runtime.
 715         So the wizard will fail the second time unless you copy the files into their
 716         proper locations - see the stdout warnings for the paths.
 717
 718         (create_page_account_details),(on_before_next):
 719         Check for existing non-server accounts instead of server accounts,
 720         so the default account name is useful again, and to prevent trying to
 721         recreate accounts.
 722
 723         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 724         Show the wizard when New is clicked.
 725
 726         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 727         (init_view): Show the column headers, and show the columns that are
 728         specified in the UI specs. However, something in Maemo's GTK+ prevents
 729         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 730         change the default account. This is despite unsetting the special properties.
 731
 732 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 733
 734         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 735         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 736         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 737         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 738         to make that clearer.
 739         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 740
 741 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 742
 743         * src/maemo/modest-account-view-window.c:
 744         (modest_account_view_window_init),
 745         (modest_account_view_window_new):
 746         Use the same buttons as specified in the
 747         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 748         the existing widgets, which never had a chance of working.
 749         Put the ModestAccountView treeview in a scrolled window.
 750         Do not repeat the initialization in both _init() and _new().
 751
 752         * src/widgets/modest-account-view.c: (update_account_view):
 753         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 754         this widget and window shows no accounts.
 755
 756         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 757
 758 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 759
 760         * src/maemo/easysetup/modest-easysetup-wizard.c:
 761         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 762         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 763         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 764         which seems wrong.
 765
 766         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 767         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 768         accounts exist yet, as in the UI spec.
 769
 770         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 771
 772 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 773
 774         * src/maemo/Makefile.am:
 775         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 776         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 777         New window for editing connection-specific smtp details.
 778         Not fully implemented.
 779
 780         * src/maemo/modest-connection-specific-smtp-window.c:
 781         (modest_connection_specific_smtp_window_finalize) :
 782         unref the tree model.
 783         (on_button_edit): Show the edit window.
 784
 785 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 786
 787         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 788         error for me.
 789
 790         * src/maemo/Makefile.am:
 791         * src/maemo/modest-connection-specific-smtp-window.c:
 792         * src/maemo/modest-connection-specific-smtp-window.h:
 793         New window for showing the list of connections, for connection-specific
 794         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 795         * src/maemo/easysetup/modest-easysetup-wizard.c:
 796         (create_page_custom_outgoing): Show the new window when the button is clicked.
 797
 798 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 799
 800         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 801         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 802         * src/maemo/modest-msg-edit-window.c:
 803         (modest_msg_edit_window_insert_image):
 804         * src/modest-conf.c: (modest_conf_key_escape):
 805         * src/modest-mail-operation.c:
 806         (modest_mail_operation_send_new_mail):
 807         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 808         (modest_ui_actions_on_new_account):
 809         * src/widgets/modest-attachment-view.c: (update_filename_request):
 810         * src/widgets/modest-mail-header-view.c:
 811         Corrected warnings that were breaking the build, by commenting out unused variables,
 812         and a function, and by including a header.
 813
 814 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 815
 816         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 817         so we can #ifdef around platform-specific code when necessary.
 818         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 819         to allow this to build for the GNOME platform too.
 820
 821 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 822
 823         * src/maemo/easysetup/modest-easysetup-wizard.c:
 824         Added util_increment_name() and used it in create_page_account_details()
 825         to make sure that the default account name is always a new name.
 826
 827         (modest_easysetup_wizard_dialog_init),
 828         (set_default_custom_servernames): Some minor memory management fixes.
 829
 830 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 831
 832         * Makefile.am:
 833         * configure.ac:
 834         * src/modest-runtime.c: (init_i18n): Restored the translation
 835         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 836         are defined in config.h, and the translations are installed.
 837
 838         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 839         is defined for translation.
 840
 841 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 842
 843         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 844         (load_from_file):
 845         * src/maemo/easysetup/modest-easysetup-wizard.c:
 846         (modest_easysetup_wizard_dialog_init):
 847         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 848         Use realistic paths (though they should use $prefix generically) to the
 849         mcc_mapping and provider-data.keyfile files which might work when they
 850         are installed by the future version of the operator-wizard package,
 851         and then fallback to paths in our source code, with an explanatory
 852         warning.
 853
 854 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 855
 856         * configure.ac:
 857         * src/Makefile.am:
 858         * src/maemo/Makefile.am:
 859         * src/maemo/easysetup/: Added files from the previously-exernal
 860         osso-modest-easysetup.
 861         * src/maemo/modest-main-window-ui.h:
 862         * src/modest-ui-actions.c:
 863         * src/modest-ui-actions.h:
 864         Added modest_ui_actions_on_new_account() as a signal handler for the
 865         New Account menu item. It shows the easysetup wizard.
 866         * po/en_GB.po: Added additional needed logical IDs and translations.
 867
 868 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 869 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 870