1 2007-07-09 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr-helpers.h:
4 * src/modest-account-mgr-helpers.c:
5 Added modest_account_mgr_get_store_protocol().
7 * src/maemo/modest-account-view-window.c:
8 (on_delete_button_clicked): Show different warning text depending on
9 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
10 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
13 2007-07-09 Murray Cumming <murrayc@murrayc.com>
15 * src/maemo/modest-msg-edit-window.c:
16 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
17 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
19 2007-07-07 Armin Burgmeier <armin@openismus.com>
21 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
22 ckdg_ib_maximum_characters_reached from correct package.
24 * src/modest-ui-actions.c: Show an error message when a folder could
25 not be created. Tinymail does not give us specific error codes about
26 what has gone wrong, so we assume that a folder with that name
27 already exists, though there might be other reasons.
29 2007-07-06 Murray Cumming <murrayc@murrayc.com>
31 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
32 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
33 give a more exact error message that can be partly translated.
35 2007-07-05 Murray Cumming <murrayc@murrayc.com>
37 * src/maemo/modest-address-book.c:
38 (select_email_addrs_for_contact): Specify a default window size for the
39 select-email-address dialog, so that it is probably big enough for the
40 title. This should fix projects.maemo.org bug NB#62277.
42 2007-07-05 Murray Cumming <murrayc@murrayc.com>
44 * src/maemo/easysetup/modest-easysetup-wizard.c:
45 (create_page_complete_easysetup): Use
46 gtk_widget_set_size() request to ensure that the text wraps
49 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
51 * src/maemo/easysetup/modest-easysetup-wizard.c:
52 (on_entry_invalid_character), (create_page_account_details),
53 (create_page_user_details):
54 Use new API of ModestValidatingEntry. But for some reason the banner is
55 not shown. I will have to investigate that further.
57 * src/widgets/modest-validating-entry.c: (on_insert_text),
58 (modest_validating_entry_set_func):
59 * src/widgets/modest-validating-entry.h:
60 Added a new callback function to be able to react to prevented
61 characters whitespaces to e.g show a banner.
63 2007-07-05 Armin Burgmeier <armin@openismus.com>
65 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
66 notification of HildonNumberEditor instead of remembering the port
67 number. Thanks to Johannes for pointing this out.
69 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
71 * src/maemo/easysetup/modest-easysetup-wizard.c:
72 Check if there are any user changes before showing a confirmation
73 dialog (projects.maemo.org NB#60946)
75 2007-07-05 Armin Burgmeier <armin@openismus.com>
77 * src/maemo/modest-account-settings-dialog.c: Remember custom port
78 number at the beginning of the dialog and set the modified flag at the
79 end if the port number has changed. This is necessary because
80 HildonNumberEditor does not support notification when the value has
83 2007-07-05 Murray Cumming <murrayc@murrayc.com>
85 * src/modest-ui-actions.c:
86 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
87 a connection before asking anything else. Correct the check for the destination
88 folder so that it succeeds when online.
89 This fixed projects.maemo.org bug NB#61645.
91 2007-07-05 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
94 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
95 to fix projects.maemo.org bug NB#62439.
97 2007-07-05 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-tny-account.c: (on_connection_status_changed):
100 Really do not use tny_device_force_offline() here. See the previous comment.
102 2007-07-04 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-account.c: (on_connection_status_changed):
105 Do not use tny_device_force_offline() when tinymail says that something
106 went wrong with the connection. It seems to report this unnecessarily.
108 2007-07-04 Murray Cumming <murrayc@murrayc.com>
110 * src/maemo/modest-connection-specific-smtp-window.c:
111 (modest_connection_specific_smtp_window_init):
112 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
113 does not seem to have any effect in osso 1.1 (though it works in
114 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
116 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
118 * src/maemo/modest-connection-specific-smtp-window.c:
119 Fix UI specification problems with projects.meamo.org NB#60479
121 2007-07-04 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
124 clue when this has failed, because the error dialog is not always shown
125 (at least in earlier version).
127 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
128 GError message, because the generic error dialog is not helpful.
130 'This message is not currently available (can't let a new connection go online)'
131 when trying to open an IMAP message.
133 (_modest_ui_actions_open): Offer a connection when some messages would
134 have to be downloaded and we are offline.
136 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
138 * src/widgets/modest-folder-view.c:
139 Don't check for MERGE type anymore as we use the correct type
141 NOTE: For the last two changes you need to update your tinymail copy
142 because of API changes!
144 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
146 * src/modest-tny-local-folders-account.c:
147 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
148 (see projects.maemo.org NB#61580)
150 2007-07-04 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-tny-account.c: (on_connection_status_changed):
153 Commented out the call to modest_platform_connect_and_wait() because this
154 seems to always hang, and I would like to know if this is the only thing
155 that causes a hang when showing the connection dialog.
156 It is not very useful anyway.
158 2007-07-04 Murray Cumming <murrayc@murrayc.com>
160 * src/maemo/modest-msg-view-window.c:
161 (modest_msg_view_window_select_next_message):
163 * src/modest-platform.h:
164 * src/maemo/modest-platform.c:
165 Added modest_platform_connect_and_wait(), which calls
166 tny_maemo_conic_device_connect() always in the main thread, by calling it
167 in an idle handler and waiting for the idle handler to run. It should be
168 in the main thread because it uses GTK+ UI code. It just returns TRUE
169 if the device is already online.
171 There is some nasty code to ensure that subsequent calls to
172 modest_platform_connect_and_wait() just wait for the first one to finish,
173 by checking repeatedly in another idle handler. This is necessary,
174 because other threads (or even the main thread, via another idle handler)
175 can call modest_platform_connect_and_wait() while
176 modest_platform_connect_and_wait() is running.
178 (modest_platform_connect_and_wait_if_network_account),
179 (modest_platform_connect_and_wait_if_network_folderstore):
180 Convenience functions that calls modest_platform_connect_and_wait() if
181 the account or folder might want network access.
183 * src/modest-mail-operation.c:
184 (modest_mail_operation_update_account):
185 * src/modest-ui-actions.c: (download_uncached_messages),
186 (modest_ui_actions_on_rename_folder), (delete_folder),
187 (modest_ui_actions_on_main_window_move_to),
188 (modest_ui_actions_on_msg_view_window_move_to):
189 * src/widgets/modest-folder-view.c:
190 (drag_and_drop_from_folder_view):
191 Offer a connection if we are offline.
193 * src/modest-tny-account.c: (on_connection_status_changed):
194 Document this as only handling errors during network operations in progress,
195 and replace the idle code with a simple call to
196 modest_platform_connect_and_wait(), which does this instead.
198 2007-07-03 Murray Cumming <murrayc@murrayc.com>
200 * src/modest-tny-account.c:
201 (modest_tny_account_get_special_folder): (util_on_idle),
202 Handle the GError so we can see when tny_folder_store_get_folders()
203 fails, as it currently does while something else is connecting.
205 Added util_run_in_main_thread_and_wait()
206 which uses an idlen handler and mainloop to ensure that the function
207 is called in the main thread.
208 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
209 to make sure that we call attempt the connection in the mainloop only,
210 which might solve some hangs.
212 2007-07-03 Murray Cumming <murrayc@murrayc.com>
214 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
215 be found by their display name. This is never useful.
216 * src/modest-tny-account-store.c: (on_account_removed): Find the account
217 by its ID, instead of trying to use its ID as its display name.
219 * src/modest-tny-account-store.h:
220 * src/modest-tny-account.c:
221 (modest_tny_account_get_special_folder): Add a g_warning() when
222 tny_folder_store_get_folders() returns an empty list for the maildir.
224 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
225 Add a g_warning() when this returns NULL, because that it not allowed
228 2007-07-02 Armin Burgmeier <armin@openismus.com>
230 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
231 note when trying to cancel the wizard. This fixes projects.maemo.org
234 2007-07-02 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-tny-account.h:
237 * src/modest-tny-account.c:
238 (modest_tny_account_new_from_server_account),
239 (modest_tny_account_new_from_server_account_name),
240 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
241 because this must now be set before setting the proto. This is usd in
242 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
243 warning in camel_session_get_service() caused by
244 tny_camel_transport_account_prepare().
246 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
249 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
253 (modest_connection_specific_smtp_edit_window_init):
255 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
258 2007-06-29 Murray Cumming <murrayc@murrayc.com>
260 * src/modest-tny-account.c:
261 (modest_tny_account_new_from_server_account):
262 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
263 now uses to request a connection when it needs one, and which it uses
264 to tell us that something is wrong with the connection, so we can force
265 the accounts offline to prevent further problems.
268 * src/modest-init.c: (init_default_settings):
269 * src/modest-mail-operation.c:
270 (modest_mail_operation_update_account):
271 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
272 This should not be necessary anymore. Do not set the conf key that
273 determined this (it was always TRUE and not set anywhere else).
275 * src/modest-ui-actions.h: Remove unused and unimplemented
276 modest_ui_actions_on_online_toggle_toggled().
278 2007-06-29 Murray Cumming <murrayc@murrayc.com
280 * src/maemo/modest-main-window.c: (connect_signals):
281 Don't connect to delete_event twice. Maybe this was harmless.
283 2007-06-29 Murray Cumming <murrayc@murrayc.com
285 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
286 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
287 Debug output to give some more clue when a folder move is not allowed.
289 2007-06-28 Murray Cumming <murrayc@murrayc.com
291 * src/modest-tny-account.c: (on_modest_file_system_info),
292 (modest_tny_account_get_mmc_account_name):
293 Always call the callback, without checking whether the name has changed.
294 * src/widgets/modest-folder-view.c: (strings_are_equal),
295 (on_model_foreach_set_name), (on_get_mmc_account_name),
296 (text_cell_data): Compare the name here, and use the name from
297 the account rather than from the
298 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
299 if the name was changed after the account was added to the model.
300 That's a tinymail bug but not one that I want to fix now.
302 This finally fixes projects.maemo.org bug NB#59301.
304 2007-06-27 Armin Burgmeier <armin@openismus.com>
306 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
309 2007-06-27 Murray Cumming <murrayc@murrayc.com
311 * src/modest-tny-account.h:
312 * src/modest-tny-account.c:
313 Added modest_tny_account_get_mmc_account_name(), to set the memory
314 card name asynchronously for the given account and then notify.
315 (modest_tny_account_new_for_local_folders): Use this new function instead
316 of using hildon_file_system_info_async_new() directly.
318 * src/widgets/modest-folder-view.c: (text_cell_data):
319 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
320 gtk_tree_model_row_changed() when it is available.
322 This should fix projects.maemo.org bug NB#59301.
324 2007-06-27 Murray Cumming <murrayc@murrayc.com
326 * src/modest-mail-operation.c: (update_account_thread),
327 (get_msgs_full_thread): Fix typo failures in the revert
330 2007-06-27 Murray Cumming <murrayc@murrayc.com
332 * src/maemo/modest-maemo-global-settings-dialog.c:
333 (idle_select_default_focus):
334 * src/modest-mail-operation.c: (idle_notify_progress),
335 (idle_notify_progress_once), (set_last_updated_idle),
336 (update_account_thread), (get_msgs_full_thread):
337 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
338 * src/widgets/modest-header-view.c:
339 (idle_notify_headers_count_changed_destroy),
340 (idle_notify_headers_count_changed):
341 Reverted the additions of gdk_threads_enter/leave(), in case this
342 helps with a startup hang on the device.
344 2007-06-26 Armin Burgmeier <armin@openismus.com>
346 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
347 for supported secure authentication methods from server by
348 gtk_dialog_run(), saving CPU time and a potential race condition.
350 2007-06-26 Armin Burgmeier <armin@openismus.com>
352 * src/maemo/modest-maemo-utils.h:
353 * src/maemo/modest-maemo-utils.c: Added a
354 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
355 only error code to tell the calling code when the user canceled the
358 * src/maemo/modest-account-settings-dialog.h:
359 * src/maemo/modest-account-settings-dialog.c:
360 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
361 message if the retrieval of secure authentication methods was canceled
362 by the user. Perform the check before saving anything to configuration
363 to not end up with half-committed configuration changes, do not show
364 a "Saving to configuration failed" note when authentication methods
365 could not be retrieved.
367 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
370 2007-06-26 Murray Cumming <murrayc@murrayc.com>
372 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
373 Only return the first level of folders under accounts, because the
374 osso-global-search UI spec doesn't want the rest.
375 This fixed projects.maemo.org bug NB#61811.
377 2007-06-26 Murray Cumming <murrayc@murrayc.com>
379 * src/modest-tny-account-store.c:
380 * src/modest-tny-account-store.h:
381 Added modest_tny_account_is_memory_card_account().
382 * src/maemo/modest-main-window.c: (create_details_widget):
383 Show the same information items for the memory card as we show for the
384 local-folders, to fix projects.maemo.org bug NB#59307.
386 2007-06-26 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-tny-account-store.c: (get_password):
389 Added some checks for NULL to maybe prevent crashes, though I think
390 it was Philip's last commit that actually prevented the crash here
391 when creating a first new account.
392 But the new account is still not usable (no messages are shown)
393 until a restart of the application.
395 2007-06-26 Murray Cumming <murrayc@murrayc.com>
397 * src/maemo/modest-maemo-global-settings-dialog.c:
398 (idle_select_default_focus):
399 * src/modest-mail-operation.c: (idle_notify_progress),
400 (idle_notify_progress_once), (idle_notify_update_account_queue),
401 (set_last_updated_idle), (update_account_thread),
402 (notify_get_msgs_full), (get_msgs_full_destroyer),
403 (get_msgs_full_thread):
404 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
405 * src/widgets/modest-header-view.c:
406 (idle_notify_headers_count_changed_destroy),
407 (idle_notify_headers_count_changed):
408 Use gdk_threads_enter() and gdk_threads_enter_leave() in
409 all idle handlers, because some other thread could be blocking
410 the GDK lock, so that it can do GUI stuff.
412 2007-06-26 Murray Cumming <murrayc@murrayc.com>
414 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
415 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
416 (on_idle_send_receive), (on_idle_open_default_inbox):
417 * src/maemo/modest-msg-edit-window.c:
418 (modest_msg_edit_window_attach_file_noninteractive):
419 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
420 to prevent a hang. I don't quite understand why these are necessary,
421 beause we should already be in the main loop. I guess something outside
422 of the main loop is taking the lock.
424 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
425 we are really using URIs, and use files that are more likely to exist.
427 2007-06-26 Murray Cumming <murrayc@murrayc.com>
429 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
430 necessary because configure.ac now defines different variables.
432 2007-06-26 Murray Cumming <murrayc@murrayc.com>
434 * libmodest-dbus-client/libmodest-dbus-client.c:
435 * libmodest-dbus-client/libmodest-dbus-client.h:
436 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
437 libmodest_dbus_client_compose_mail() is what things actually use.
439 * src/dbus_api/modest-dbus-api.h:
440 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
441 * tests/dbus_api/Makefile.am:
442 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
445 2007-06-26 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-init.c: (modest_init_local_folders):
448 For memory-card (or other non local-folders) maildir accounts,
449 always create an Archive folder, so that there is somewhere to put
450 messages. This should be less confusing, because the user does not need
451 to guess that the need to create a folder.
453 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
455 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
456 Fixed icon size by using (50, 50) which is the same as defined by
459 2007-06-25 Armin Burgmeier <armin@openismus.com>
461 * src/widgets/modest-window-mgr.c:
463 * configure.ac: Correctly recognize hildon-notify presence and fixed
464 the build without it being installed.
466 2007-06-25 Murray Cumming <murrayc@murrayc.com>
468 * libmodest-dbus-client/libmodest-dbus-client.c:
469 (libmodest_dbus_client_search): Fix the build. Sorry.
470 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
471 (reply_forward_cb): Initialize variables to fix the build.
473 * src/modest-tny-account-store.c:
474 (modest_tny_account_store_get_tny_account_by): Fix the account URI
475 comparison (a silly typo) so that email search results can be opened
476 when there are more than one account.
478 2007-06-25 Murray Cumming <murrayc@murrayc.com>
480 * libmodest-dbus-client/libmodest-dbus-client.c:
481 (libmodest_dbus_client_search),
482 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
483 instead of 1 second, because the search gets folders and messages from
484 the server, which can take a long time. When it times out,
485 osso-global-search will report no results.
487 We need to specify whether we should search only cached information
488 (maybe with a user preference), and the osso-email-search-plugin
489 API should really be improved to allow that option, and to allow results
490 to be delivered asynchronously in batches.
492 2007-06-25 Murray Cumming <murrayc@murrayc.com>
494 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
495 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
496 GTK_ICON_SIZE_DIALOG is probably the wrong size.
498 2007-06-25 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
501 that is an empty string. D-Bus seems to give us these instead of NULL.
503 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
505 * src/dbus_api/modest-dbus-callbacks.c:
506 * src/maemo/easysetup/modest-easysetup-wizard.h:
507 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
508 * src/maemo/modest-connection-specific-smtp-edit-window.c:
509 (modest_connection_specific_smtp_edit_window_init):
510 * src/maemo/modest-maemo-global-settings-dialog.c:
512 * src/maemo/modest-maemo-utils.c:
513 (modest_maemo_utils_setup_images_filechooser):
514 * src/maemo/modest-main-window.c: (create_details_widget):
515 * src/maemo/modest-msg-edit-window.c:
516 (modest_msg_edit_window_attach_file_noninteractive),
517 (modest_msg_edit_window_color_button_change),
518 (modest_msg_edit_window_set_zoom):
519 * src/modest-mail-operation.c: (update_account_thread):
520 * src/modest-tny-account-store.c:
521 * src/modest-tny-account.c:
522 * src/widgets/modest-global-settings-dialog.c:
523 * src/widgets/modest-window.h:
527 2007-06-25 Murray Cumming <murrayc@murrayc.com>
529 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
530 * src/modest-search.c: (modest_search_folder),
531 (modest_search_all_accounts): Actually search only in the specified folder,
532 doing a simple match on the folder ID.
533 * src/modest-search.h: Added a folder field to the ModestSearch struct,
534 and added some documentation.
536 2007-06-22 Armin Burgmeier <armin@openismus.com>
538 * src/maemo/modest-maemo-utils.h:
539 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
540 modest_maemo_utils_get_supported_secure_authentication_methods.
542 * src/maemo/easysetup/modest-easysetup-wizard.c:
543 * src/maemo/modest-account-settings-dialog.c: Show correct error if
544 one occured, not just "Server does not support secure authentication".
546 2007-06-22 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-tny-account-store.c: (get_password):
549 Restored the call to tny_account_set_user() because Philip seems to have
550 stopped this from crashing (by not using the freed string). It still does
551 not work, but now we can test it.
553 2007-06-22 Murray Cumming <murrayc@murrayc.com>
555 * src/maemo/modest-msg-edit-window.c: (init_window):
556 Comment out use of an uninitialzed GtkScrolledWindow variable,
557 to fix the build and stop a crash. Yet again.
559 2007-06-22 Murray Cumming <murrayc@murrayc.com>
561 * src/modest-tny-account-store.c: (get_password):
562 Remove the call to tny_account_set_user() because this actually crashes.
563 As mentioned in the last commit, it is known to not work anyway.
565 2007-06-22 Murray Cumming <murrayc@murrayc.com>
567 * src/modest-tny-account-store.c: (get_password):
568 Use tny_account_set_username() to tell tinymail that the username might
569 have changed too. But tinymail ignores this: see projects.maemo.org
571 * src/modest-ui-actions.c:
572 (modest_ui_actions_on_password_requested): Remove the useless attempt to
573 reset the connection when changing the username, and improve the comments.
574 Save the changed username to gconf at least, so it is used when Modest is
577 2007-06-21 Murray Cumming <murrayc@murrayc.com>
579 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
580 Do not use a query, so that we get all folders, including for POP and
581 local-folders. They work as search criteria too.
582 This fixes projects.maemo.org bug NB#57740.
584 2007-06-21 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
587 Comment out the use of hildon_notification_set_sound() because it is
588 not declared, to fix the build. Warnings are serious, people.
590 2007-06-21 Armin Burgmeier <armin@openismus.com>
592 * src/maemo/modest-maemo-utils.h:
593 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
594 modest_maemo_utils_get_supported_secure_authentication_methods()
595 to query authentication methods for a specific user. This should fix
596 projects.maemo.org bug NB#61369.
598 * src/maemo/easysetup/modest-easysetup-wizard.c:
599 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
602 2007-06-21 Murray Cumming <murrayc@murrayc.com>
604 * libmodest-dbus-client/libmodest-dbus-client.h:
605 * libmodest-dbus-client/libmodest-dbus-client.c:
606 (modest_dbus_message_iter_get_search_hit),
607 (libmodest_dbus_client_search):
608 Reorganised and commented this.
609 Removed modest_search_hit_free() from the public API because it
612 Added libmodest_dbus_client_get_folders() and
613 modest_folder_result_list_free().
615 * src/dbus_api/modest-dbus-api.h:
616 * src/dbus_api/modest-dbus-callbacks.c:
617 (modest_dbus_req_filter): Commented. Moved most code to
618 on_dbus_method_search() and added on_dbus_method_get_folders().
620 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
621 of the extra D-Bus handler.
623 * tests/dbus_api/Makefile.am:
624 * tests/dbus_api/test_get_folders.c: New test for
625 libmodest_dbus_client_get_folders(). This seems to return an empty list
626 at the moment. That could be the same error that causes the message list
627 to be empty sometimes.
628 This should help with projects.maemo.org bug NB#57740.
630 2007-06-21 Armin Burgmeier <armin@openismus.com>
632 * src/modest-mail-operation.c: Do not call
633 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
634 notify the operation's end after having set the status to CANCELED for
635 the operation queue to listen on. This fixes a deadlock when there
636 were mail operations in the queue during its finalization.
638 * src/modest-singletons.c: Reordered uninitialization of the account
639 manager to happen after the mail operation queue was uninitialized
640 because the mail operation's in the queue might still try to access
641 the account manager (see modest_mail_operation_notify_end()). This
642 fixes a potential crash when terminating the application.
644 2007-06-21 Murray Cumming <murrayc@murrayc.com>
646 * src/modest-search.c:
647 (search_mime_part_and_child_parts): Moved some code here so we
648 can search recursively in child folders.
649 (modest_search_folder): Search in the message as a mime part, instead
650 of just its child mime parts.
651 (read_chunk), (search_mime_part_ogs):
652 Check how many bytes were read, to prevent an endless loop.
653 Searching in message bodies now works. This finishes the fix for
654 projects.maemo.org bug NB#61007.
656 2007-06-20 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
659 Add a g_warning when the item is not a folder.
661 * src/modest-ui-dimming-rules.c:
662 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
663 when selected item is not a folder (for instance, an account), because
664 the UI spec only talks about folders.
665 I am not sure what the UI spec wants, so this might not totally fix
666 projects.maemo.org bug NB#60794.
668 2007-06-20 Murray Cumming <murrayc@murrayc.com>
670 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
671 (load_from_file): Sort the list. The unsorted list would be more noticeable
672 in non-English locales.
674 * src/maemo/modest-msg-edit-window.c:
675 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
676 warning and fix the build.
678 * src/maemo/modest-progress-bar-widget.c:
679 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
680 avoid a g_warning, and probably to avoid a crash.
682 2007-06-20 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-search.c: (modest_search_folder): Check for a GError
685 when calling tny_folder_get_headers(), to show that this is not the cause
688 2007-06-20 Murray Cumming <murrayc@murrayc.com>
690 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
691 Actually set the body query instead of the subject query.
693 * src/modest-search.c: (search_mime_part_ogs),
694 (search_mime_part_strcmp): Remove extra space from the text/* regex,
695 which would probably cause it to fail if we got this far.
697 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
698 to simplify the code.
699 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
700 be causing search-in-body to fail.
702 2007-06-20 Murray Cumming <murrayc@murrayc.com>
704 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
706 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
707 Better debug message when the folder cannot be found.
708 This should help with fixing projects.maemo.org bug #61287.
709 * src/modest-search.c: (add_hit): Do not leak the furl string.
711 2007-06-20 Murray Cumming <murrayc@murrayc.com>
713 * src/modest-ui-actions.c:
714 (modest_ui_actions_on_folder_selection_changed):
715 Do not special-case TNY_MERGE_FOLDER here, because
716 modest_tny_folder_get_account() already does that. This fixes
717 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
718 shown when the Outbox was selected).
720 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
722 * libmodest-dbus-client/libmodest-dbus-client.c:
723 (_dbus_iter_get_string_or_null): Initialize the string variable in
724 case this helps with Dirk's crash.
726 2007-06-19 Murray Cumming <murrayc@murrayc.com>
728 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
729 though it is not implemented yet (this function is maybe not even used),
730 to avoid breaking ABI in future.
731 * libmodest-dbus-client/libmodest-dbus-client.c:
732 (get_attachments_string): Moved some code into this generic function.
733 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
734 sends email. It is maybe not used.
735 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
736 (on_send_mail): Use attachments.
738 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
739 * src/maemo/modest-msg-edit-window.c:
740 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
741 a filename before using it, to fix projects.maemo.org bug NB#58233.
743 2007-06-19 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
746 Initialize the continue_download variable to fix the build, and probably
747 to fix randome behaviour.
749 2007-06-18 Armin Burgmeier <armin@openismus.com>
751 * src/modest-tny-send-queue.h:
752 * src/modest-tny-send-queue.c: Keep track of the status of messages in
753 the queue so we can later show it in the UI. Replaced
754 modest_tny_send_queue_msg_is_being_sent() by
755 modest_tny_send_queue_get_msg_status().
757 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
759 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
760 gpointer. This probably was not harmful, but just to be sure.
762 2007-06-18 Murray Cumming <murrayc@murrayc.com>
764 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
765 Fix the build, but leave the function broken on Bora, because
766 hildon_uri_action_get_service() does not exist.
767 osso_uri_action_get_service() does not exist either, it seems.
769 2007-06-18 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-tny-account.c:
772 (modest_tny_account_new_from_server_account):
773 Uncommented the url debug output again, because it is useful for
774 debugging, as I said in the comment.
776 2007-06-18 Murray Cumming <murrayc@murrayc.com>
778 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
780 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
781 for Mameo Bora, to fix the build.
783 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
786 Fixed build with hildon < 0.99
788 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
789 Check if the selected account is busy instead of checking all accounts
791 * src/modest-account-mgr-priv.h:
792 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
793 (modest_account_mgr_init), (compare_account_name),
794 (modest_account_mgr_set_account_busy),
795 (modest_account_mgr_account_is_busy):
796 * src/modest-account-mgr.h:
797 Added busy information to the account manager. It possible to
798 set an account to busy or not busy now.
800 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
801 (modest_mail_operation_update_account),
802 (modest_mail_operation_notify_end):
803 Set the account to busy/not busy depending on the operation state.
805 * src/widgets/modest-account-view.c:
806 (modest_account_view_finalize), (get_last_updated_string),
807 (update_account_view), (on_account_busy_changed), (init_view):
808 Show string "Refreshing..." if the account is currently busy.
810 All this fixes projects.maemo.org bug NB#59711
812 2007-06-14 Armin Burgmeier <armin@openismus.com>
814 * src/widgets/modest-attachments-view.h:
815 * src/widgets/modest-attachments-view.c: Added
816 modest_attachments_view_has_attachments() and fixed coordinate
817 transformation in get_att_view_at_coords(). This fixes attachment
820 * src/widgets/modest-msg-view.c: Make use of
821 modest_attachments_view_has_attachments() to decide whether to show
822 attachments in the header.
824 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
826 * src/maemo/modest-connection-specific-smtp-edit-window.c:
827 (on_change), (on_combo_security_changed),
828 (modest_connection_specific_smtp_edit_window_init),
829 (modest_connection_specific_smtp_edit_window_set_connection),
830 (modest_connection_specific_smtp_edit_window_is_dirty):
831 * src/maemo/modest-connection-specific-smtp-edit-window.h:
832 * src/maemo/modest-connection-specific-smtp-window.c:
835 Show an comfirmation dialog for the smpt-edit-window if there are
836 unsaved changes and the user hits cancel.
837 (projects.maemo.org bug NB#60479)
839 2007-06-14 Armin Burgmeier <armin@openismus.com>
841 * src/maemo/easysetup/modest-easysetup-wizard.c:
842 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
843 address" info in banner instead of node, and select all the text as
844 per UI spec. This fixes projects.maemo.org bug NB#60550.
846 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
848 reviewed by: <delete if not using a buddy>
850 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
851 * src/modest-ui-actions.c: (folder_refreshed_cb):
853 2007-06-14 Murray Cumming <murrayc@murrayc.com>
855 * src/widgets/modest-folder-view.c: (filter_row):
856 Explictly filter out the per-account outbox accounts. I don't know why
857 these only sometimes show up, but now they should never show up in the UI.
858 This should fix projects.maemo.org bug NB#60160.
860 2007-06-14 Murray Cumming <murrayc@murrayc.com>
862 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
863 when the toolbar does not exist yet.
864 * src/modest-widget-memory.c: (save_settings_header_view):
865 Added g_warnings() to help us to discover when we are trying to set
866 an empty columns list in gconf.
868 2007-06-14 Murray Cumming <murrayc@murrayc.com>
872 Added modest_init_get_default_header_view_column_ids().
874 * src/modest-widget-memory.c: (restore_settings_header_view):
875 Use the new function to get defaults, if the gconf key is empty,
876 instead of not creating any columns. This seems to fix the
877 empty right-hand pane problems.
879 * src/widgets/modest-header-view.h: Improved documentation.
881 2007-06-13 Murray Cumming <murrayc@murrayc.com>
883 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
884 Revert the use of the display name as the account name, because this
885 is generally wrong and would break the code that follows.
887 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
889 * src/maemo/easysetup/modest-easysetup-wizard.c:
890 (check_for_supported_auth_methods), (on_before_next),
893 More correct fix for projects.maemo.org bug NB# 58991
894 Do not longer accept AUTH_PASSWORD as secure method and choose
895 correct method when creating the account.
897 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
899 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
900 Fixed projects.maemo.org bug NB# 58991
902 2007-06-13 Murray Cumming <murrayc@murrayc.com>
904 * src/modest-init.c: (modest_init_init_core),
905 (modest_init_local_folders): Fixed compilation errors.
907 2007-06-13 Murray Cumming <murrayc@murrayc.com>
909 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
910 Remove unnecessary lib/include, though it is good in principle when needed.
912 * src/modest-init.c: (modest_init_one_local_folder),
913 (modest_init_local_folders):
914 * src/modest-init.h: Initialize the .modest library for memory cards,
915 instead of just doing nothing for them. This should allow us to create
916 folders there, fixing projects.maemo.org bug NB#59297.
918 2007-06-13 Murray Cumming <murrayc@murrayc.com>
920 * libmodest-dbus-client/libmodest-dbus-client.c:
921 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
922 (libmodest_dbus_client_compose_mail),
923 (libmodest_dbus_client_open_message),
924 (libmodest_dbus_client_send_and_receive),
925 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
927 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
928 (on_idle_open_message), (modest_dbus_req_handler),
929 (search_result_to_message), (modest_dbus_req_filter):
930 * src/modest-search.c: (add_hit), (modest_search_folder),
931 (modest_search_all_accounts): Improved debug messages.
933 * tests/dbus_api/test_open_message.c: (main): Improved comments.
935 * src/modest-tny-account-store.c:
936 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
939 2007-06-13 Murray Cumming <murrayc@murrayc.com>
942 2007-06-12 Murray Cumming <murrayc@murrayc.com>
944 * src/modest-tny-account-store.c: (get_server_accounts):
945 Call modest_tny_local_folders_account_add_merged_outbox_folders()
946 even when there are no accounts, so that the Outbox folder is always
947 visible. This fixes projects.maemo.org bug NB#60158.
949 2007-06-12 Murray Cumming <murrayc@murrayc.com>
951 * src/maemo/modest-main-window.c: (create_details_widget):
952 Use the mcen_va_never logical ID.
954 2007-06-12 Murray Cumming <murrayc@murrayc.com>
956 * src/dbus_api/modest-dbus-api.h:
957 * src/dbus_api/modest-dbus-callbacks.c:
958 (on_idle_open_default_inbox), (on_open_default_inbox),
959 (modest_dbus_req_handler):
960 Added a new OpenDefaultInbox method.
962 * libmodest-dbus-client/libmodest-dbus-client.h:
963 * libmodest-dbus-client/libmodest-dbus-client.c:
964 Added libmodest_dbus_client_open_default_inbox() to call the new
965 dbus method. This should be useful to projects.maemo.org bug NB#57214,
966 though it should maybe be used by a new osso-email-interface function.
968 * tests/dbus_api/Makefile.am:
969 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
972 2007-06-12 Murray Cumming <murrayc@murrayc.com>
974 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
975 NULL, so that the signals get all the keys. This should not actually
976 change any behaviour because we currently update everything when anything
979 2007-06-12 Murray Cumming <murrayc@murrayc.com>
981 * src/widgets/modest-folder-view.c: (text_cell_data),
982 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
983 (find_inbox_iter): If tinymail tells us that the folder is
984 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
985 This causes the inbox to be selected at startup, fixing part of
986 projects.maemo.org bug NB#56305.
988 * src/modest-ui-dimming-rules.c:
989 (modest_ui_dimming_rules_on_tools_smtp_servers):
990 * src/modest-ui-dimming-rules.h: Added a callback function to dim
991 the SMTP servers menu item.
992 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
993 that the SMTP Servers menu item is dimmed when there are no accounts,
994 as a future version of the UI spec will require. This fixes
995 projects.maemo.org bug NB#56305.
997 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
999 * src/maemo/modest-maemo-utils.c:
1000 (modest_maemo_utils_get_supported_secure_authentication_methods):
1001 Added label to dialog instead of unreadable title
1003 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1004 (modest_main_window_new):
1005 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1008 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1009 * src/modest-account-mgr.h:
1010 Added method to avoid code duplication
1012 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1013 (modest_ui_actions_on_send_receive):
1014 Use modest_account_mgr_has_accounts
1016 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1018 * src/maemo/easysetup/modest-presets.c:
1019 (modest_presets_get_info_server_security): Do not report secure auth
1021 * src/modest-protocol-info.c: Use the defines for the gconf key names
1022 for secure authentication. This was not working because we were writing
1023 Password and reading password, and the check was case sensitive.
1024 With this, gmail now works for receiving and sending when created via
1027 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1029 * src/maemo/easysetup/modest-presets.c:
1030 (modest_presets_get_info_server_security): Correct the key name for
1031 SecureSmtp, because it seems to be case-sensitive.
1032 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1033 Do not try to get the 0th notebook page if there are 0 pages, to
1034 avoid a g_warning().
1036 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1038 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1039 Prevent use of the new notification feature for now, because it currently
1040 shows one dialog for each new email, which is annoying.
1042 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1044 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1045 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1046 when no country was selected, so that we show the global ones.
1047 * src/maemo/easysetup/modest-presets.c:
1048 (modest_presets_get_providers): Return only the global providers, not
1049 all providers when mmc=0 was requested.
1051 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1053 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1054 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1055 provider ID in the combo.
1057 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1058 Do not show the page numbers, because it would be confusing when we add
1059 the 2 extra pages for the custom setup, when the user chooses the "Other"
1060 provider. This fixes projects.maemo.org bug NB#59028
1062 * src/modest-init.c: (modest_init_init_core),
1063 (modest_init_local_folders):
1064 * src/modest-init.h:
1065 * src/modest-tny-account.c:
1066 (modest_tny_account_new_for_local_folders): Do not create default folders
1067 for the memory card. This should fix projects.maemo.org bug NB#59328.
1069 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1072 Free the changed_conf_keys string items. They are already freed in the
1073 idle handler if that runs first.
1075 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-ui-actions.c:
1078 (modest_ui_actions_on_password_requested): Check that the server name
1079 is not NULL, because I just saw a password dialog with (null) as the
1082 * src/modest-tny-folder.[h|c]: Added
1083 modest_tny_folder_is_memory_card_folder().
1084 * src/modest-ui-dimming-rules.c:
1085 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1086 menu item for memory cards, as per the UI spec (section 7.4). This should
1087 fix projects.maemo.org bug NB#59297.
1089 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1091 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1092 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1093 is another problem with the code, see Murray's comment at line 772)
1095 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1097 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1098 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1099 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1100 (load_from_file), (easysetup_country_combo_box_init),
1101 (easysetup_country_combo_box_get_active_country_ids),
1102 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1103 instead of just one ID, to avoid duplicate country names in the UI.
1105 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1106 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1107 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1108 a single ID, avoiding duplicate providers.
1109 * src/maemo/easysetup/modest-easysetup-wizard.c:
1110 (on_combo_account_country): Adapt to use a list.
1112 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1114 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1115 keys changed in the last X seconds.
1117 * src/modest-account-mgr.h:
1118 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1119 (on_key_change), (modest_account_mgr_class_init),
1120 (modest_account_mgr_init), (modest_account_mgr_finalize):
1121 As the keys are changed, save them in a GSList* and signal that GSList*
1122 further every X seconds, to batch changes, to allow us to do just one
1123 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1124 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1126 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1127 changed signal signature.
1129 * src/modest-conf.c: (modest_conf_set_list),
1130 (modest_conf_on_change): Reenable notification.
1132 (modest_conf_maemo_fake_on_change): Comment out the hack that
1133 notified immediately instead of asynchronously.
1135 * src/widgets/modest-account-view.h:
1136 * src/widgets/modest-account-view.c:
1137 (update_account_view): Select the previously-selected account ID,
1138 if possible. This fixes projects.maemo.org bug NB#56933.
1140 (on_account_changed), (on_account_removed),
1141 (modest_account_view_select_account):
1143 Remove the block/unblock functions
1144 because they were not useful.
1146 * src/maemo/modest-account-view-window.c:
1147 (on_delete_button_clicked), (on_edit_button_clicked),
1148 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1150 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1153 Improve the error dialog to show Incorrect Account Settings, which seems
1154 clearer, and say that the internal error message (to be removed from the
1155 dialog later) is often misleading.
1156 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1158 * src/modest-tny-account.c:
1159 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1160 URL because this is so useful for debugging on the device.
1162 * src/widgets/modest-serversecurity-combo-box.c:
1163 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1165 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1167 * src/modest-mail-operation.c:
1168 (modest_mail_operation_send_new_mail):
1169 Added a comment about a nasty but apparently harmless message. Details
1170 added to the wiki g_warnings() page.
1172 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1174 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1175 (modest_tny_send_queue_class_init):
1176 Do not use the priv struct because it is empty, to avoid g_warnings
1177 about a non-existant priv struct.
1179 * src/modest-tny-account-store.c:
1180 (modest_tny_account_store_get_server_account),
1181 (modest_tny_account_store_get_transport_account_for_open_connection
1182 ): Do not try to get transport server accounts for local folders,
1183 because they don't have any. This avoids a g_warning().
1185 * src/maemo/modest-main-window.c:
1186 (modest_main_window_notify_send_receive_initied),
1187 (on_configuration_key_changed):
1188 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1189 * src/modest-defs.h:
1190 * src/modest-mail-operation.c:
1191 (modest_mail_operation_update_account):
1192 * src/modest-tny-account-store.h:
1193 * src/modest-tny-account.c:
1194 (modest_tny_account_get_special_folder),
1195 (modest_tny_account_new_for_local_folders),
1196 (modest_tny_account_new_for_per_account_local_outbox_folder):
1197 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1198 * src/modest-tny-local-folders-account.c:
1199 (add_account_folders_to_merged_folder):
1200 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1201 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1202 (modest_ui_actions_on_send):
1203 * src/widgets/modest-folder-view.c: (update_model):
1204 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1205 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1206 modest_tny_account_store_get_tny_account_by_account() to
1207 modest_tny_account_store_get_server_account() to make the code clearer.
1209 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1211 * src/dbus_api/modest-dbus-api.h:
1212 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1213 * src/maemo/modest-msg-edit-window.c:
1214 (modest_msg_edit_window_attach_file_noninteractive):
1215 added g_warning in case the file to be attached does not exist
1216 * tests/dbus_api/test_compose_mail.c: (main):
1217 removed obsolete comment, added generic files as test case
1219 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1221 * src/modest-tny-account-store.c: (get_server_accounts):
1222 Create the local folders account only once, not once for each outbox, and
1223 not only when there are some outboxes.
1225 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1227 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1228 code that is causing a crash at startup. Sergio says that he is fixing this.
1230 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1232 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1233 * src/maemo/modest-account-settings-dialog.c:
1234 (create_page_outgoing),
1235 (modest_account_settings_dialog_set_account_name),
1236 (save_configuration):
1237 - Fixed handling of the "Use secure authentication" toggle to comply with
1238 the ui specification. See also projects.maemo.org bug NB#58400
1240 - Restore the Secure connection setting combo correctly when loading
1243 * src/maemo/modest-maemo-utils.c:
1244 (on_camel_account_get_supported_secure_authentication),
1245 (modest_maemo_utils_get_supported_secure_authentication_methods):
1246 Fixed a crasher if operation is canceled
1248 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1249 (modest_protocol_info_auth_is_secure):
1250 * src/modest-protocol-info.h:
1252 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1253 the sense of the "Use secure authentication" toggle.
1255 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1257 * src/modest-tny-account-store.h:
1258 * src/modest-tny-account-store.c:
1259 Added modest_tny_account_store_get_local_folders_account().
1261 * src/modest-tny-folder.h:
1262 * src/modest-tny-folder.c:
1263 (modest_tny_folder_get_account):
1264 Added this replacement for tny_folder_get_account() which returns
1265 the local-folders account for TnyMergeFolders, to avoid the
1266 warning about the unimplemented get_account_func() vfunc().
1268 (modest_tny_folder_get_rules),
1269 * src/modest-ui-actions.c:
1270 (modest_ui_actions_on_folder_selection_changed):
1271 * src/modest-mail-operation.c:
1272 (modest_mail_operation_remove_folder),
1273 (modest_mail_operation_xfer_folder),
1274 (modest_mail_operation_rename_folder),
1275 (modest_mail_operation_get_msg),
1276 (modest_mail_operation_get_msgs_full),
1277 (modest_mail_operation_remove_msg),
1278 (modest_mail_operation_xfer_msgs),
1279 (modest_mail_operation_refresh_folder):
1280 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1282 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1284 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1285 (modest_server_account_set_security):
1286 * src/modest-defs.h: Add comments explaining that our
1287 UI spec means TLS when it says Normal, so these do not look like errors.
1289 * src/modest-tny-account.c:
1290 (modest_tny_account_new_from_server_account): Use the new tinymail
1291 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1292 for TLS. This should fix projects.maemo.org bug NB#58460.
1294 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1296 * src/maemo/easysetup/modest-easysetup-wizard.c:
1297 (create_account): Correct the position of the gconf sanity check warning.
1298 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1299 of using the g_idle_add() hack, because this does not seem to be necessary
1300 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1301 caused by something other than maemo's gconf.
1302 This fixes projects.maemo.org bug #59022.
1304 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1306 * src/modest-account-mgr-helpers.c:
1307 (modest_account_mgr_get_default_account): Do not check that the account
1308 exists if there is no default account (NULL), to fix a runtime warning.
1310 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1312 * src/widgets/modest-folder-view.c: (update_model):
1313 Do not unref the treemodel before we have finished with it.
1314 This prevents a valgrind warning and an occasional crash at startup.
1316 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1318 * libmodest-dbus-client/libmodest-dbus-client.h:
1319 added libmodest_dbus_client_compose_mail()
1320 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1322 added functions needed for SendAsMail() functionality
1323 * src/maemo/modest-msg-edit-window.c:
1324 (modest_msg_edit_window_attach_file_noninteractive):
1325 non interactively attaching files to message edit window
1326 * src/widgets/modest-msg-edit-window.h:
1327 * tests/dbus_api/Makefile.am:
1328 added test_compose_mail.c
1329 * tests/dbus_api/test_compose_mail.c: (main):
1331 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1333 * src/modest-account-view.c:
1334 Fixed bug projects.maemo.org bug NB#59307
1336 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1338 * src/maemo/easysetup/modest-easysetup-wizard.c:
1339 (get_serverport_incoming), (on_before_next), (create_account):
1340 * src/maemo/modest-account-settings-dialog.c:
1341 (modest_account_settings_dialog_set_account_name):
1342 * src/maemo/modest-maemo-utils.c:
1343 (on_camel_account_get_supported_secure_authentication_status),
1344 (on_camel_account_get_supported_secure_authentication),
1345 (on_secure_auth_cancel),
1346 (modest_maemo_utils_get_supported_secure_authentication_methods):
1348 Implemented security authentication for settings and easysetup.
1350 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/modest-main-window.c: (create_details_widget):
1353 Show the total size for memory card accounts too, instead of showing
1354 the name again. Fixes bug projects.maemo.org bug NB#59307.
1356 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1359 * src/modest-tny-simple-folder-store.c:
1360 * src/modest-tny-simple-folder-store.h: Removed.
1362 * src/modest-tny-local-folders-account.h
1363 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1364 for the local-folders maildir, with an extra TnyMergedFolder containing
1365 the folders of the per-account outbox store accounts.
1366 * src/modest-tny-account-store.c: (get_server_accounts):
1367 Add the outboxes to the special local folders account after creating it.
1369 * src/modest-tny-account.c:
1370 (modest_tny_account_new_for_local_folders): Create the derived
1371 account when creating the main local-folders account.
1373 * src/maemo/modest-main-window.c: (create_details_widget),
1374 (modest_main_window_set_contents_style):
1375 Adapted to the use of the derived account instead of the folder store.
1377 * src/modest-ui-actions.c:
1378 (modest_ui_actions_on_folder_selection_changed):
1379 * src/modest-ui-dimming-rules.c:
1380 (modest_ui_dimming_rules_on_new_folder):
1381 * src/widgets/modest-folder-view.c: (text_cell_data),
1382 (icon_cell_data), (filter_row), (update_model),
1383 (get_cmp_rows_type_pos):
1386 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1387 Do not get the priv struct, because no priv struct has been set,
1388 to avoid a runtime warning.
1390 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1391 #ifelse with #else, to fix a warning, to fix the build.
1394 2007-06-05 Christian Kellner <ckellner@openismus.com>
1396 * libmodest-dbus-client/libmodest-dbus-client.c:
1397 Fix small typo in doc (why do you always see them
1398 AFTER committing stuff?)
1401 2007-06-05 Christian Kellner <ckellner@openismus.com>
1403 * libmodest-dbus-client/libmodest-dbus-client.c:
1404 (libmodest_dbus_client_search):
1405 Initialize hit list with NULL. Also set folder list
1406 to "" if NULL was supplied.
1409 2007-06-03 Christian Kellner <ckellner@openismus.com>
1411 * libmodest-dbus-client/libmodest-dbus-client.c:
1412 (modest_search_hit_list_free):
1413 Make it save to call it with NULL.
1415 * src/dbus_api/modest-dbus-callbacks.c:
1416 * src/modest-search.c:
1417 Return full ModestSearchHits as the search result list not TnyHeader
1418 since can't be around withouth the correspoding TnyFolder.
1420 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1422 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1423 Added currently commented code to check for secure auth
1425 * src/maemo/modest-account-settings-dialog.c: (on_response),
1426 (save_configuration), (show_ok):
1427 Fixed projects.maemo.org bugs NB #59248 and #59251
1429 * src/maemo/modest-maemo-utils.c:
1430 (on_camel_account_get_supported_secure_authentication_status),
1431 (on_camel_account_get_supported_secure_authentication),
1432 (modest_maemo_utils_get_supported_secure_authentication_methods):
1433 * src/maemo/modest-maemo-utils.h:
1434 Moved get_supported_secure_authentication() method here to be able
1435 to use it from easysetup wizard.
1437 * src/modest-pair.c: (on_pair_compare_as_string):
1438 Should compare string with first part of pair and not
1439 strcmp pairs which will crash.
1441 * src/modest-protocol-info.c:
1442 (modest_protocol_info_protocol_is_store):
1443 * src/modest-protocol-info.h:
1444 Added modest_protocol_info_get_auth_protocol_name()
1446 2007-06-03 Armin Burgmeier <armin@openismus.com>
1448 * src/modest-mail-operation.c:
1449 (modest_mail_operation_get_msgs_full): Set priv->account also when
1450 only retrieving a single message. This avoids a crash when canceling
1453 (modest_mail_operation_notify_end): Do not explicitely remove the
1454 operation from the queue but only emit the progress_changed signal.
1455 The queue itself listens to that signal to remove the operation when
1456 it is finished. This reduces coupling and removes a potential deadlock
1457 when modest_mail_operation_notify_end() is called from the queue
1458 itself. If that is a problem performance-wise, I would suggest to
1459 implement a status-changed signal or something.
1461 * src/modest-mail-operation-queue.c: Make sure to never call a
1462 function from another file while the queue is locked. This (hopefully)
1463 fixes another deadlock when exiting the application while retrieving
1466 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1468 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1469 Fixed build if libogs is not available
1471 2007-06-03 Christian Kellner <ckellner@openismus.com>
1473 * libmodest-dbus-client/libmodest-dbus-client.h:
1474 * libmodest-dbus-client/libmodest-dbus-client.c:
1475 (libmodest_dbus_client_delete_message):
1476 Implement deletion of messages (Client side).
1478 (modest_search_hit_free),
1479 (modest_search_hit_list_free):
1480 Utility functions to free the result hits.
1482 * src/dbus_api/modest-dbus-api.h:
1483 * src/dbus_api/modest-dbus-callbacks.c:
1484 (on_delete_message),
1485 (modest_dbus_req_handler):
1486 Implement deletion of messages (Server side).
1488 * tests/dbus_api/test_search.c: (main):
1491 * tests/dbus_api/Makefile.am:
1492 * tests/dbus_api/test_delete_message:
1493 Add little test for the message deletion logic
1495 2007-06-03 Armin Burgmeier <armin@openismus.com>
1497 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1498 when the operation queue was not empty. projects.maemo.org bug
1501 2007-06-03 Armin Burgmeier <armin@openismus.com>
1503 * src/widgets/modest-account-view.c
1504 (on_account_default_toggled): Toggle default account column
1505 explicitely instead of waiting for gconf notification (which is
1506 currently ignored). This should fix projects.maemo.org bug NB#56910
1507 for now. It should probably be removed when gconf notifications are
1510 2007-06-03 Christian Kellner <ckellner@openismus.com>
1512 * libmodest-dbus-client/libmodest-dbus-client.c:
1513 Removed debugging spew.
1515 * src/dbus_api/modest-dbus-callbacks.c:
1516 Added debugging info.
1518 * src/modest-search.c:
1519 (modest_search_all_accounts):
1520 Use tny_account_store_get_accounts () on the account store
1521 to get all accounts which is the way to get all accounts.
1523 * tests/dbus_api/test_search.c: (main):
1524 Make it possible to supply the search term on the command line.
1526 2007-06-03 Christian Kellner <ckellner@openismus.com>
1528 * libmodest-dbus-client/libmodest-dbus-client.c:
1529 * libmodest-dbus-client/libmodest-dbus-client.h:
1530 Implement searching for mesages over raw dbus. (Client side)
1532 * src/dbus_api/Makefile.am:
1533 * src/dbus_api/modest-dbus-api.h:
1534 * src/dbus_api/modest-dbus-callbacks.c:
1535 * src/dbus_api/modest-dbus-callbacks.h:
1536 Search framework (Server side). Also implement on_idle_open_message().
1538 * src/maemo/modest-platform.c: (modest_platform_init):
1539 Prepare for raw dbus/osso rpc interaction.
1541 * src/modest-search.h:
1542 Changed minsize from unspecific guint to guint32.
1544 * src/modest-search.c:
1546 Added strange hack which magically made tnymail work.
1548 (modest_search_folder),
1549 (modest_search_account),
1550 (modest_search_all_accounts):
1551 Implement helper functions to search all accounts, specific account
1554 * tests/dbus_api/Makefile.am:
1555 * tests/dbus_api/test_open_message.c:
1556 Read url to open from commandline.
1558 * tests/dbus_api/test_search.c:
1559 Implement small test for dbus search stuff
1561 2007-06-02 Armin Burgmeier <armin@openismus.com>
1563 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1564 include account type and account title. This fixes projects.maemo.org
1567 * src/maemo/modest-account-view-window.c: Set a title for the window.
1569 2007-06-02 Armin Burgmeier <armin@openismus.com>
1571 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1572 incoming and outgoing server name based on email address and server
1573 types as long as the names have not been edited manually. This fixes
1574 projects.maemo.org bug NB#58671.
1576 2007-06-02 Armin Burgmeier <armin@openismus.com>
1578 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1579 server type cannot be changed in future to the incoming details page
1580 when creating an account. This fixes projects.maemo.org bug NB#59029.
1582 2007-06-02 Armin Burgmeier <armin@openismus.com>
1584 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1585 and assigned max width chars so that they wrap instead of being
1586 truncated. Fixes projects.maemo.org bug NB#56126.
1588 2007-06-02 Armin Burgmeier <armin@openismus.com>
1590 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1591 introductory note to the connection specific smtp servers dialog, as
1592 section 8.12 of the email UI specification requires. This fixes
1593 projects.maemo.org bug NB#59212.
1595 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1597 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1598 Check for running mail operations, and offer to cancel them, as per the UI
1599 spec. This fixes projects.maemo.org bug NB#59041 .
1600 However, I suspect that tinymail may still use the network connection
1601 in ways that we cannot detect or cancel. But it should at least adapt to
1602 changes fairly well.
1604 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-tny-account-store.c: (recreate_all_accounts),
1607 (get_cached_accounts), (get_server_accounts): Do more sensible
1608 ref-counting of the temporarily-cached outbox accounts list. This seems
1609 to fix a crash when entering the password when the password was wrong.
1611 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1613 * src/gnome/modest-main-window.c: (connect_signals):
1614 * src/modest-tny-account-store.c: (get_password),
1615 (modest_tny_account_store_alert): Added comments and clues and
1616 commented-out code about how we currently fail to deal with connection
1617 errors and wrong passwords, and how we should.
1619 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1621 * src/widgets/modest-retrieve-combo-box.c:
1622 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1623 This fixes projects.maemo.org bug NB#58472 .
1625 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1627 * src/maemo/easysetup/modest-easysetup-wizard.c:
1628 (create_page_complete_easysetup):
1629 (create_page_complete_custom): Correct the last commit,
1630 putting the correct sentences in the correct pages.
1632 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/easysetup/modest-easysetup-wizard.c:
1635 (create_page_complete_custom): Show the second sentence of text
1636 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1639 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1641 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1642 Set the leave-on-server conf key by default. This fixes
1643 projects.maemo.org bug NB#59258 .
1645 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/modest-account-view-window.c:
1648 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1649 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1652 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/easysetup/modest-easysetup-wizard.c:
1655 (create_caption_new_with_asterisk):
1656 * src/maemo/modest-account-settings-dialog.c:
1657 (create_caption_new_with_asterisk):
1658 Uncomment the code to add the asterisk, because they are no longer in the
1659 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1660 (update_incoming_server_title): Add an asterisk here too.
1662 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1664 * src/maemo/modest-maemo-global-settings-dialog.c:
1665 (current_connection): Check that we are even connected before trying to
1666 get the current connection name, to prevent a warning.
1668 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1669 Change the comments because tny_maemo_conic_device_connect() is now meant to
1671 * src/modest-mail-operation.c:
1672 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1673 make sure we have a connection and fail if we can't connect.
1675 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1677 * src/maemo/modest-main-window.c:
1678 (on_account_store_connecting_finished): Do not try to get the
1679 connection ID if we are not really connected. I am surprised that
1680 this signal handler is called when we are not connected.
1682 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1684 * src/modest-error.h:
1685 * src/modest-ui-actions.c:
1686 (modest_ui_actions_get_msgs_full_error_handler):
1687 Renamed an enum, added comments, added an enum
1688 for retrieve-limit errors.
1690 * src/modest-mail-operation.c: (foreach_add_item),
1691 (internal_folder_observer_update), (update_account_thread),
1692 (modest_mail_operation_get_msgs_full):
1693 (modest_mail_operation_update_account),
1694 Added comments about how this works, and some code that should
1695 (but does not) check the retrieve-limit. See the TODO comment.
1697 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1700 Initialize help_id to fix the build. Warnings are good.
1702 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1704 * src/widgets/modest-hbox-cell-renderer.c:
1705 (modest_hbox_cell_renderer_append):
1706 * src/widgets/modest-vbox-cell-renderer.c:
1707 (modest_vbox_cell_renderer_append):
1708 Fix the last commit by doing an extra ref.
1710 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1712 * src/widgets/modest-hbox-cell-renderer.c:
1713 (modest_hbox_cell_renderer_append):
1714 * src/widgets/modest-vbox-cell-renderer.c:
1715 (modest_vbox_cell_renderer_append):
1716 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1717 to fix the build with Maemo Bora.
1718 However, there seems to be a remaining crash, probably due to reference
1721 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1723 * src/modest-tny-account.c:
1724 (modest_tny_account_new_for_local_folders):
1725 Use hildon_file_system_info_async_new() to get a better name for
1726 the memory card account, setting it as the account name.
1727 The timing seems to work, but this is probably
1728 not the best place to do this. See the TODO comment.
1729 * src/maemo/modest-main-window.c: (create_details_widget):
1730 * src/widgets/modest-folder-view.c: (text_cell_data):
1731 Use the tny account name instead of hardcoding a name.
1733 2007-05-30 Christian Kellner <ckellner@openismus.com>
1735 * src/modest-search.c: (modest_search):
1736 Correctly set part_search_func even if we have already parsed
1737 the query and thus a valid OgsTextSearcher object.
1739 2007-05-30 Christian Kellner <ckellner@openismus.com>
1742 Search and check for libogs.
1745 Incooparte the ogs build env.
1747 * src/modest-mime-part-search-stream.c:
1748 * src/modest-mime-part-search-stream.h:
1749 Removed since we do the real searching now in modest-search.c.
1751 * src/modest-search.c:
1752 * src/modest-search.h:
1753 Implement support for ogs. We use that if available and requested
1754 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1755 should now handle the corner case when the search term is spread
1756 across multiple reads.
1757 Also the logic in modest_search () was corrected to search all
1758 requested fields until one is found.
1760 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1762 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1764 * src/modest-init.h:
1765 * src/modest-init.c: Made modest_init_local_folders() take a
1766 path and be public so we can iniitialize maildir folders on
1769 * src/modest-local-folder-info.h:
1770 * src/modest-local-folder-info.c:
1771 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1773 * src/modest-tny-account.c:
1774 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1775 still means the standard local-folders path on the local volume.
1777 * src/modest-tny-account-store.c:
1778 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1779 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1780 all accounts when that happens.
1781 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1782 this too, so it shows up in the treeview.
1784 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1786 * src/maemo/modest-maemo-global-settings-dialog.c:
1787 (current_connection):
1788 * src/widgets/modest-global-settings-dialog.c:
1789 (current_connection_default):
1790 Use the enum values instead of 0, 1 and -1,
1791 to make the code clearer.
1793 * src/modest-account-mgr-helpers.c:
1794 (modest_account_mgr_get_connection_specific_smtp): Make this code
1797 * src/modest-runtime.h:
1798 * src/modest-runtime.c:
1799 Added modest_runtime_remove_all_send_queues().
1800 * src/maemo/modest-main-window.c:
1801 (on_account_store_connecting_finished): Recreate the send queues,
1802 using the appropriate transport accounts for this new connection.
1803 Some futher adapting might be needed if the old send queues are not
1804 automatically stopped at this point.
1806 * src/modest-tny-account-store.c: (get_server_accounts):
1807 Create the connection-specific transport accounts, so that they can
1808 be found later by their ID.
1810 * src/modest-tny-account.h:
1811 * src/modest-tny-account.c:
1812 Added modest_tny_account_new_from_server_account_name().
1813 modest_tny_account_new_from_server_account(): Do not create the
1814 send queues here, because they will be
1815 recreated anyway when the connection changes for the first time.
1817 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1819 * src/modest-local-folder-info.h:
1820 * src/modest-local-folder-info.c:
1821 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1822 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1823 tbox_folder): Take a modest account name instead of a server TnyAccount,
1824 so we can have per-modest-account rather than per-transport-account
1826 We must make sure that we change or recreate the exisitng send queues
1827 when the connection changes for connection-specific transport accounts.
1829 * src/modest-tny-account-store.c:
1830 (create_per_account_local_outbox_folders): Create outboxed per modest
1831 account, not per transport account.
1833 * src/modest-tny-account.h:
1834 * src/modest-tny-account.c:
1835 (modest_tny_account_get_special_folder): For outboxes, get the
1836 parent modest account name. The account is ignored for other folders.
1837 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1838 modest account name rather than a server TnyAccount.
1840 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1842 * src/modest-tny-account.c:
1843 (modest_tny_account_new_from_server_account):
1844 Call modest_runtime_get_send_queue() immediately after creating transport
1845 accounts, so that they start trying to send email from the outbox as soon
1846 as possible at startup. This is probably what we want.
1848 * src/modest-mail-operation.c: (update_account_thread):
1849 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1850 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1851 * src/modest-tny-send-queue.h:
1852 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1853 (modest_ui_actions_on_send):
1854 Added comments about how sending works, though it needs some more work.
1856 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-tny-account.c:
1859 (modest_tny_account_get_special_folder): Add TODO because this fails when
1860 the network is busy.
1861 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1862 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1863 Do not try to show this window when there is no active account. The UI
1864 specs does not tell us what to do in this case.
1866 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1870 * src/maemo/Makefile.am:
1871 * src/widgets/Makefile.am: Some dist fixes.
1873 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1875 * src/maemo/modest-connection-specific-smtp-window.c:
1876 (on_button_edit): Make the code clearer, to prevent a double free.
1878 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1880 * src/maemo/modest-account-settings-dialog.c:
1881 (modest_account_settings_dialog_set_account_name),
1882 Check the connection-specific smtp servers checkbox if there are any.
1884 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1885 (modest_connection_specific_smtp_edit_window_init):
1886 Start with a suitable port number.
1888 * src/modest-account-mgr-helpers.h:
1889 * src/modest-account-mgr-helpers.c: Added
1890 modest_account_mgr_get_has_connection_specific_smtp().
1892 (modest_account_mgr_set_connection_specific_smtp),
1893 (modest_account_mgr_remove_connection_specific_smtp),
1894 (modest_account_mgr_get_has_connection_specific_smtp),
1895 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1896 connection-specific smtp server accounts in the account, rather than
1897 the server account conf dir.
1899 This fixes bug projects.maemo.org bug NB#58263 .
1901 * src/modest-tny-account-store.c:
1902 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1903 if there are no server accounts yet, to prevent an infinite loop when there
1904 are no accounts. Document that one must be called before the other.
1906 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1908 * src/modest-account-mgr-helpers.c:
1909 (modest_account_mgr_get_default_account): Make sure that at least
1910 one account is always the default, if there are any enabled accounts.
1911 This is just a sanity check that shouldn't be necessary.
1913 * src/modest-account-mgr-priv.c:
1914 (_modest_account_mgr_account_from_key): Unescape the conf key to
1915 get the real account name. For instance, this is an issue if a space
1916 was in the account name, which can happen because the account name
1917 is generated from the display name.
1918 (_modest_account_mgr_get_account_keyname): Always escape the
1920 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1921 Unescape the conf keys to get the real account names.
1923 For instance, previously the is-default radio button in the accounts
1924 list was not checked for any accounts at first. This fixes that,
1925 and might fix several similar bugs.
1927 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1930 Removed some debug printfs.
1932 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1934 Modest on-disk outbox directories are now here, for instance:
1935 $HOME/.modest/outboxes/<account-id-1>/outbox
1936 $HOME/.modest/outboxes/<account-id-2>/outbox
1938 $HOME/.modest/local-folders/outbox
1939 so we can have a separate outbox for each account.
1940 But they are shown as one outbox in the GtkTreeView, by using a
1941 TnyMergeFolder in a ModestTnySimpleFolderStore.
1944 * src/modest-tny-simple-folder-store.c:
1945 * src/modest-tny-simple-folder-store.h:
1946 Added ModestTnySimpleFolderStore, used to contain folders from
1947 other folder stores, such as other accounts.
1949 * src/modest-tny-outbox-account.h:
1950 * src/modest-tny-outbox-account.c:
1951 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1952 used for the per-account local outbox folders.
1954 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1955 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1956 only use this (internally) now for the non-outbox local folders.
1958 * src/modest-init.h:
1959 * src/modest-init.c: Added modest_init_one_local_folder(), for
1960 setting up the directory structure for each local folder.
1962 * src/modest-local-folder-info.c:
1963 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1964 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1966 * src/modest-local-folder-info.h:
1967 * src/modest-tny-account-store.c: (on_account_removed),
1968 (on_account_changed), (create_per_account_local_outbox_folders),
1969 (get_server_accounts), (modest_tny_account_store_get_accounts),
1970 (modest_tny_account_store_get_tny_account_by_account),
1971 (modest_tny_folder_store_is_virtual_local_folders):
1973 * src/modest-tny-account.h:
1974 * src/modest-tny-account.c:
1975 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1976 to create an on-disk per-account local outbox folder for each
1978 (create_per_account_local_outbox_folders): Create a local outbox folder
1979 for each transport account.
1980 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1981 for all local folders.
1983 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1984 instead of using g_object_get/set() directly. It is clearer.
1986 (modest_tny_folder_store_get_message_count),
1987 (modest_tny_folder_store_get_local_size
1988 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1989 because we now use these with non-acount folder stores.
1991 (modest_tny_account_get_special_folder),
1992 (modest_tny_account_new_from_server_account),
1993 (modest_tny_account_new_from_account):
1994 (recurse_folders): Adjust to the new outbox system.
1996 * src/modest-tny-folder.h:
1997 * src/modest-tny-folder.c:
1998 (modest_tny_folder_is_local_folder),
1999 (modest_tny_folder_get_local_folder_type),
2000 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2002 * src/widgets/modest-main-window.h:
2003 * src/maemo/modest-main-window.c: (create_details_widget),
2004 (modest_main_window_set_contents_style): Show details for any folder store,
2007 (modest_tny_folder_get_rules):
2008 Remove the const. C does not support constness enough for this.
2010 * src/modest-ui-actions.c:
2011 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2012 make all outboxes appear as one, in the usual local-folders tree node.
2014 (set_active_account_from_tny_account),
2015 (modest_ui_actions_on_folder_selection_changed):
2016 * src/widgets/modest-folder-view.c: (text_cell_data),
2017 (icon_cell_data), (filter_row),
2018 (add_account_folders_to_merged_folder),
2019 (add_account_folders_to_simple_folder_store), (),
2020 (get_cmp_rows_type_pos), (cmp_rows),
2021 (modest_folder_view_set_account_id_of_visible_server_account):
2022 Adjust to the new outbox system, using generic folder stores and folders
2023 in the GtkTreeModel.
2025 2007-05-23 Christian Kellner <ckellner@openismus.com>
2027 * src/modest-mail-operation.c:
2028 (modest_mail_operation_update_account):
2029 Use info->max_size instead of unintialized local var [small
2030 build fix]. (Added TODO to review that change since I don't
2033 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2035 * libmodest-dbus-client/libmodest-dbus-client.c:
2036 (libmodest_dbus_client_compose_mail): function added
2037 * src/dbus_api/modest-dbus-api.h:
2038 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2039 (on_compose_mail): Implementation of the SendAsMail functionality
2041 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2043 * src/modest-account-mgr.c:
2044 (modest_account_mgr_add_server_account): Set the secure-connection
2045 conf key for transport accounts as well as store accounts. I don't know
2046 why the if was there. For instance, this makes sure that we use SSL
2047 for the gmail preset from the easysetup wizard.
2049 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2051 * src/gnome/modest-main-window.c:
2052 (on_account_store_connecting_finished), (connect_signals):
2053 * src/maemo/modest-main-window.c:
2054 (on_account_store_connecting_finished), (connect_signals),
2055 (modest_main_window_new):
2056 Handle TnyAccountStore::connecting-finished instead of
2057 TnyDevice::connection-changed, because we cannot actually perform
2058 operations on accounts until TnyAccountStore has itself responded to
2059 the TnyDevice::connection-changed signal. This prevents a GError from
2061 Do not try to update at startup, because we (at least on scratchbox)
2062 already do an update at startup when the device goes online.
2063 This prevents a GError from tinymail.
2064 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2065 Added TODO about stopping simultaneous operations.
2067 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2070 * src/modest-mail-operation-queue.c:
2071 (modest_mail_operation_queue_remove):
2072 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2073 about where they happened.
2075 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-ui-actions.c:
2078 (modest_ui_actions_on_password_requested): Make sure that the remember
2079 output parameter is always TRUE.
2081 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2084 Show a OK/Cancel dialog if the error is a question, though we still do not
2085 know anything more about what we are asking the user.
2086 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2087 Fix an uninitialized variable (helper). This is a logic error, however.
2089 2007-05-21 Christian Kellner <ckellner@openismus.com>
2091 * src/modest-search.h:
2092 Correct bit shifting in the ModestSearchFlags enum.
2094 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2096 * src/modest-tny-account.c:
2097 (modest_tny_account_new_from_server_account): Do not use the lsub and
2098 check-all hard-coded IMAP options when using POP.
2100 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2102 * src/modest-tny-account.c:
2103 (modest_tny_account_new_from_server_account):
2104 Use NULL for the secure-auth method for POP when Password auth has been
2105 specified by the user, as we already do for IMAP. "auth=Login" causes
2106 an error from camel or the server.
2108 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2110 * src/maemo/modest-account-settings-dialog.c:
2111 (create_page_account_details),
2112 (modest_account_settings_dialog_set_account_name):
2113 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2114 for the leave-on-server checkbox, rathr than just the checkbox, when
2115 the protocol is not POP.
2117 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2119 * src/widgets/modest-account-view.c:
2120 * src/widgets/modest-account-view.h:
2121 Added modest_account_view_select_account() which will be useful later
2122 to asynchronously re-select the edited account.
2124 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2126 * src/maemo/modest-account-settings-dialog.c:
2127 (modest_account_settings_dialog_set_account_name):
2128 Automatically choose the port numbers based on the secure authentication
2129 methods, if they have not been chosen before.
2130 This fixes projects.maemo.org bug NB#56273 .
2132 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2134 * src/maemo/modest-main-window-ui.h:
2135 * src/modest-ui-actions.c:
2136 * src/modest-ui-actions.h:
2137 Connect the Tools/SMTP Servers menu item to
2138 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2139 SMTP servers dialog, as in the UI specification and saves changes when it
2140 is closed. This fixed projects.maemo.org bug NB#56305 .
2142 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2144 * src/maemo/modest-connection-specific-smtp-window.c:
2145 (modest_connection_specific_smtp_window_init):
2146 Use gtk_window_set_default_size() to make this window big enough, so
2147 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2149 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2151 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2152 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2153 (modest_connection_specific_smtp_edit_window_init),
2154 Do not try to connect to a combobox signal before the combobox exists.
2155 This fixes the cras in projects.maemo.org bug NB#56288 .
2156 (modest_connection_specific_smtp_edit_window_get_settings):
2157 Remove the server_account_name parameter which was being checked for NULL
2158 though it was not used.
2160 * src/maemo/modest-connection-specific-smtp-window.c:
2161 (modest_connection_specific_smtp_window_fill_with_connections),
2162 (on_button_edit), (modest_connection_specific_smtp_window_init):
2163 Correct the number of treemodel columns to prevent a warning.
2164 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2165 libconic does not work.
2167 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-tny-account.c:
2170 (modest_tny_account_new_from_server_account):
2171 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2172 SMTP when "None" was chosen by the user. However, with my SMTP server that
2173 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2176 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2179 to explain the memory management issue with the ID in the ModestPair.
2181 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2182 (add_sending_page), (modest_account_assistant_finalize):
2183 * src/gnome/modest-gnome-global-settings-dialog.c:
2184 (create_updating_page), (create_composing_page):
2185 * src/gnome/modest-msg-edit-window.c: (get_transports),
2186 (init_window), (modest_msg_edit_window_finalize),
2187 (modest_msg_edit_window_get_msg_data):
2188 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2189 * src/gnome/modest-transport-widget.c:
2190 (modest_transport_widget_finalize), (smtp_configuration):
2191 * src/maemo/modest-maemo-global-settings-dialog.c:
2192 (create_updating_page), (create_composing_page):
2193 * src/maemo/modest-msg-edit-window.c: (get_transports),
2194 (init_window), (modest_msg_edit_window_finalize),
2195 (modest_msg_edit_window_get_msg_data),
2196 (modest_msg_edit_window_free_msg_data):
2197 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2198 (modest_store_widget_finalize):
2199 * src/maemo/modest-transport-widget.c:
2200 (modest_transport_widget_finalize), (smtp_configuration):
2201 * src/modest-main.c: (send_mail):
2202 * src/widgets/modest-combo-box.h:
2203 * src/widgets/modest-global-settings-dialog-priv.h:
2204 * src/widgets/modest-global-settings-dialog.c:
2205 (modest_global_settings_dialog_finalize):
2206 * src/widgets/modest-msg-edit-window.h:
2207 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2208 as long as the combo box, to prevent use of freed memory for the ID.
2210 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2212 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2213 get_accounts(), to make this clearer. Do not check for the enabled gconf
2214 key, because we do not use this for server accounts (at least, not yet).
2215 This allows us to send email again.
2217 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/modest-platform.c:
2220 (on_modest_conf_update_interval_changed), (modest_platform_init):
2221 Only respond to this particular key change. All these strcmp()s cannot be
2224 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2226 * src/maemo/modest-maemo-global-settings-dialog.c:
2227 (current_connection): Prevent a crash in scratchbox when
2228 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2229 * src/maemo/modest-platform.c:
2230 (on_modest_conf_update_interval_changed), (modest_platform_init):
2231 Get the update interval from gconf and reset it when the gconf key changes.
2233 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2235 * src/modest-protocol-info.c:
2236 * src/modest-protocol-info.h: Adde enum-specific get functions,
2237 instead of using a ModestProtocolType enum parameter.
2239 * src/gnome/modest-account-assistant.c:
2240 * src/gnome/modest-store-widget.c:
2241 * src/gnome/modest-store-widget.h:
2242 * src/gnome/modest-transport-widget.c:
2243 * src/gnome/modest-transport-widget.h:
2244 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2245 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2246 * src/maemo/easysetup/modest-easysetup-wizard.c:
2247 * src/maemo/modest-account-settings-dialog.c:
2248 * src/maemo/modest-account-settings-dialog.h:
2249 * src/maemo/modest-store-widget.c:
2250 * src/maemo/modest-store-widget.h:
2251 * src/maemo/modest-transport-widget.c:
2252 * src/maemo/modest-transport-widget.h:
2253 * src/modest-account-mgr-helpers.c:
2254 * src/modest-account-mgr-helpers.h:
2255 * src/modest-account-mgr.c:
2256 * src/modest-account-mgr.h:
2257 * src/modest-tny-account.c:
2258 * src/modest-tny-folder.c:
2259 * src/widgets/modest-account-view.c:
2260 * src/widgets/modest-retrieve-combo-box.c:
2261 * src/widgets/modest-retrieve-combo-box.h:
2262 * src/widgets/modest-secureauth-combo-box.c:
2263 * src/widgets/modest-serversecurity-combo-box.c:
2264 * src/widgets/modest-serversecurity-combo-box.h:
2265 * tests/check_account-mgr.c:
2266 Use the specific functions, and use the re-renamed enum values for GNOME too.
2268 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2270 * src/modest-pair.h:
2271 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2272 so we can get the second based on the first.
2274 * src/maemo/modest-account-settings-dialog.h:
2275 * src/maemo/modest-account-settings-dialog.c:
2276 Added get_supported_secure_authentication_methods(), though it is mostly
2277 commented-out for now until the necessary API is committed to tinymail.
2278 (modest_account_settings_dialog_set_account_name),
2279 (save_configuration): Request the supported authentication methods from the
2280 server, so we can choose a working method.
2282 * src/modest-tny-account-store.h:
2283 * src/modest-tny-account-store.c:
2284 (modest_tny_account_store_get_session): Rename from
2285 tny_account_store_get_session().
2287 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-protocol-info.h: Split the ModestProtocol enum
2290 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2291 There was no need to have these unrelated values in one enum.
2293 * src/: many files: Adapted to changed enum. This makes the code a bit
2294 clearer, and the compiler could catch some errors.
2296 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2298 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2299 Show the detailed internal camel error message when an error happens
2300 during the configuration, so that our testers can give us more clues.
2301 For instance, in projects.maemo.org bug NB#56910 .
2303 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2305 * src/modest-tny-account.c:
2306 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2307 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2309 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2312 * src/maemo/modest-account-settings-dialog.c:
2313 (modest_account_settings_dialog_set_account_name),
2314 (save_configuration): For the incoming secure authentication checkbox,
2315 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2316 the UI specification. PLAIN does not seem to be supported for most IMAP
2317 servers anyway, and I am not sure what it would mean.
2318 However, we probably need to discover which of the secure-authentication
2319 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2320 * src/modest-account-mgr-helpers.c:
2321 (modest_account_mgr_get_server_account_data):
2323 * src/modest-tny-account.c:
2324 (modest_tny_account_new_from_server_account):
2325 Use tny_account_set_mech() to set secure-authentication methods,
2326 with some special-casing for IMAP, based on my observations of how
2329 * src/modest-account-mgr-helpers.h:
2330 * src/modest-account-mgr.c:
2331 * src/modest-defs.h: Comment that the URI is only used for local folders.
2333 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2335 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2336 parameter const, just to be neat.
2337 * src/modest-text-utils.c: (modest_text_utils_inline):
2338 End g_strconcat() with NULL, as its documentation says. This is almost
2339 certainly the cause of my crash at startup on the device. Interestingly,
2340 valgrind doesn't tell us about these errors.
2342 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2344 * scripts/build-packages: Added more precise comments about how to use
2345 this script, though I still get this error:
2346 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2347 error building tinymail
2349 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2351 * src/maemo/modest-main-window.c: (on_account_update):
2352 Very slight cleanup, hoping to make it simpler to discover what causes
2353 a crash here sometimes.
2355 * src/modest-tny-account.c:
2356 (modest_tny_account_new_from_server_account): Set the port. Added
2357 comments about the options and a TODO comment because I need to find out
2358 how to specify the secure authentication method.
2360 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2362 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2363 changed CFlags paths form modest to libmodest
2365 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2367 * src/modest-account-mgr-helpers.c:
2368 (modest_account_mgr_get_server_account_data),
2369 (modest_account_mgr_free_server_account_data):
2370 * src/modest-account-mgr-helpers.h:
2371 * src/modest-account-mgr.c:
2372 (modest_account_mgr_add_server_account):
2373 * src/modest-defs.h:
2374 * src/modest-tny-account.c:
2375 (modest_tny_account_new_from_server_account):
2376 Determine the options for tny_camel_account_add_option() here,
2377 based on the settings, rather than storing them directly in gconf.
2379 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2382 Show a more friendly error dialog now that we expect (from the tinymail
2383 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2385 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2387 * src/maemo/modest-main-window.c: (on_account_update): Check that
2388 account_name is not NULL, to prevent a crash at startup that I am
2389 seeing on the N800. I do wonder why it is NULL.
2391 * src/maemo/easysetup/modest-easysetup-wizard.c:
2392 (create_page_user_details):
2393 * src/maemo/modest-account-settings-dialog.c:
2394 (create_page_user_details), (create_page_outgoing):
2395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2396 (modest_connection_specific_smtp_edit_window_init):
2397 * src/modest-ui-actions.c:
2398 (modest_ui_actions_on_password_requested):
2399 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2400 might do something useful with the on-screen keyboard.
2402 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2404 * src/maemo/modest-main-window.c: (on_account_update):
2405 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2406 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2408 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2410 * src/modest-tny-account-store.c: (on_account_changed):
2411 Correct the signature of this signal handler.
2413 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2415 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2416 Show a HildonNote instead of a GtkDialog for Maemo.
2418 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2420 * src/widgets/modest-account-view.h:
2421 * src/widgets/modest-account-view.c: (on_account_changed),
2422 (on_account_removed). Added a boolean flag, set/unset by
2423 modest_account_view_block_conf_updates(),
2424 modest_account_view_unblock_conf_updates() to prevent unnecessary
2425 updates, but this is not very useful because the gconf notifications are
2426 so delays (maybe only on Maemo Bora).
2427 So auto-updating is turned off, and these functions do an explicit
2428 update when necessary.
2429 However, something else is still doing too much work when adding/removing
2430 accounts, probably in another part of the application.
2432 * src/maemo/modest-account-view-window.c:
2433 (on_delete_button_clicked), (on_edit_button_clicked),
2434 (on_new_button_clicked): Use the new functions.
2436 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2438 * src/modest-account-mgr-helpers.c:
2439 (modest_account_mgr_set_first_account_as_default):
2440 Sort the list of names alphabetically-by-title, so we choose the first one
2442 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2443 alphabetically by the title.
2445 This fixes projects.maemo.org bug NB#56418 .
2447 * src/modest-account-mgr-priv.c:
2448 (_modest_account_mgr_account_from_key):
2449 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2450 avoid a valgrind error, and possible random behaviour.
2452 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2455 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2456 tinymail documentation to say that this can be expected.
2457 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2458 pretty, and should not happen, but I would prefer to know when it does.
2460 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2462 * configure.ac: When using the older hildon version, probably on Bora,
2463 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2465 * src/widgets/modest-attachment-view.c:
2466 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2469 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2471 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2472 Implemented the prototype. Can be tested with
2473 tests/dbus_api/test_open_message:
2475 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-tny-account-store.c:
2478 (modest_tny_account_store_instance_init), (get_password):
2479 * src/modest-ui-actions.c:
2480 (modest_ui_actions_on_password_requested):
2481 Do not store the password in gconf, because this function is called
2482 for non-remembered passwords. Actually use the cached (in the hash map)
2483 password instead of releasing it.
2484 The password will now not be remembered if it is asked via the protected
2485 password dialog, as per the UI spec.
2487 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2489 * src/modest-defs.h:
2490 * src/modest-account-mgr-helpers.h:
2491 * src/modest-account-mgr-helpers.c:
2492 Added modest_server_account_get_username_has_succeeded(),
2493 modest_server_account_set_username_has_succeeded().
2494 (modest_server_account_set_username),
2495 Reset the has-succeeded flag if the username changes.
2497 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2498 * src/maemo/modest-connection-specific-smtp-window.c:
2499 (modest_connection_specific_smtp_window_save_server_accounts):
2500 Use modest_server_account_set_username() instead of using
2501 modest_conf_set_string() directly, so that the has-succeeded flag is always
2504 * src/modest-ui-actions.c:
2505 (modest_ui_actions_on_password_requested): Dim the username entry if
2506 the username has ever worked, as per the UI spec.
2508 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2510 * src/modest-tny-account-store.c: (get_password):
2511 * src/modest-ui-actions.c:
2512 (modest_ui_actions_on_password_requested):
2513 Allow the username to be changed too, though there is more work to
2514 be done on exactly how this behaves.
2516 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2518 * src/modest-account-mgr-helpers.h:
2519 * src/modest-account-mgr-helpers.c:
2520 Added modest_account_mgr_get_display_name(),
2521 modest_server_account_get_username(),
2522 modest_server_account_set_username(),
2523 modest_server_account_set_password(),
2524 modest_server_account_get_hostname() functions so we do not need to
2525 use the conf API directly.
2527 * src/maemo/modest-main-window.c: (connect_signals):
2528 Actually connect ot the ModestAccountStore::request-password signal,
2529 so that we show the dialog when the password is requested by Tinymail,
2530 for isntance if it is empty.
2532 * src/modest-marshal.list:
2533 * src/modest-tny-account-store.c:
2534 (modest_tny_account_store_class_init), (get_password),
2535 (modest_tny_account_store_alert):
2536 * src/modest-tny-account-store.h:
2537 * src/modest-ui-actions.h:
2538 * src/modest-ui-actions.c:
2539 (modest_ui_actions_on_password_requested):
2540 Change the signal parameters, so it is obvious that we are providing
2541 the non human-readable server name, and receiving both the username
2542 and password, though changing of the username is not yet implemented.
2543 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2544 for the GNOME version.
2546 This should fix the projects.maemo.org bug NB#56209, though it does not
2547 work on Bora, because the gconf_client_get() for the password fails
2548 immediately after we save it with gconf_client_set().
2550 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2553 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2554 caused an undefined symbol error:
2555 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2557 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2559 * src/modest-tny-account-store.c:
2560 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2561 using a GError instead of a string message, so we can translate it in
2564 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2566 * src/maemo/modest-address-book.c:
2567 (modest_address_book_check_names):
2568 * src/maemo/modest-msg-view-window.c:
2569 (modest_msg_view_window_clipboard_owner_change):
2570 * src/modest-init.c: (modest_init_init_ui):
2571 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2572 (update_folders_cb), (modest_mail_operation_update_account):
2573 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2574 (modest_ui_actions_on_msg_attachment_clicked),
2575 (modest_ui_actions_on_msg_recpt_activated):
2576 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2577 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2578 (modest_msg_view_search_next):
2579 * src/widgets/modest-recpt-editor.c:
2580 (modest_recpt_editor_on_button_release_event),
2581 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2582 g_message(). At this point we should only be seeing interesting errors on
2583 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2585 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2587 (modest_wizard_dialog_force_title_update):
2588 * src/maemo/easysetup/modest-wizard-dialog.h:
2589 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2590 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2591 can update the title when appropriate. Otherwise the title is wrong if the
2592 pages are added after adding the notebook to the dialog.
2593 This must be a problem in HildonWizardDialog too.
2594 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2596 * src/maemo/easysetup/modest-easysetup-wizard.c:
2597 (create_subsequent_customsetup_pages),
2598 (create_subsequent_easysetup_pages):
2599 Call modest_wizard_dialog_force_title_update() so that the title is
2600 correct even with GTK+ < 2.10.
2601 This fixes projects.maemo.org bug NB#56145 .
2603 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/modest-platform.c:
2606 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2607 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2610 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2612 * src/widgets/modest-window.h:
2613 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2614 and modest_window_save_state(), which invokes it.
2616 * src/widgets/modest-window-mgr.h:
2617 * src/widgets/modest-window-mgr.c:
2618 Added modest_window_mgr_save_state_for_all_windows(), which calls
2619 the save_state vfunc on all registered windows, if implemented.
2621 * src/gnome/modest-msg-edit-window.c:
2622 * src/gnome/modest-msg-view-window.c:
2623 * src/maemo/modest-msg-edit-window.c:
2624 * src/maemo/modest-msg-view-window.c:
2625 * src/maemo/modest-main-window.c:
2626 Specify the existing save_settings functions as implementations of
2627 ModestWindow::save_state_func().
2629 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2630 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2631 enabling hibernation, for instance.
2633 We may need to do the same thing for restoring settings.
2636 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2638 * src/widgets/modest-window-mgr.c:
2639 * src/widgets/modest-window-mgr.h:
2640 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2641 modest_window_mgr_get_hibernation_is_prevented().
2643 * src/maemo/modest-main-window.c:
2644 (on_hildon_program_is_topmost_notify): Prevent hibernation
2645 (possible when the application goes to the background in the WM),
2646 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2648 * src/maemo/easysetup/modest-easysetup-wizard.c:
2649 (modest_easysetup_wizard_dialog_init):
2650 * src/maemo/modest-account-settings-dialog.c:
2651 (modest_account_settings_dialog_init):
2652 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2653 (modest_connection_specific_smtp_edit_window_init):
2654 * src/maemo/modest-connection-specific-smtp-window.c:
2655 (modest_connection_specific_smtp_window_init):
2656 * src/maemo/modest-signature-editor-dialog.c:
2657 (modest_signature_editor_dialog_init):
2658 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2659 prevent hibernation while any of these account settings dialogs are open.
2661 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2663 * src/maemo/Makefile.am:
2664 * src/maemo/modest-osso-state-saving.c:
2665 * src/maemo/modest-osso-state-saving.h: Added
2666 modest_osso_load_state() and modest_osso_save_state() though they do
2667 nothing now. They should iterate through all the open windows and load/save
2669 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2670 save state when closing.
2672 * src/maemo/modest-main-window.c:
2673 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2674 Add a notification handler for the HildonProgram::is-topmost property,
2675 so we can allow hibernation when the application goes into the background.
2676 But we still need to detect when the accounts setup windows are open so
2677 we can stop hibernation when they are open.
2678 To do this, I also added the main window the HildonProgram. This might have
2679 other side-effects/benefits, and should maybe be done for other windows.
2681 * src/maemo/modest-osso-autosave-callbacks.h:
2682 * src/maemo/modest-osso-autosave-callbacks.c:
2683 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2684 though it does not do anything yet, and we might never need this to do
2685 anything. For instance, we already save drafts.
2687 * src/maemo/modest-platform.c: (modest_platform_init):
2688 Specify the libosso auto-save callback.
2690 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/modest-platform.c:
2693 (modest_platform_set_update_interval):
2694 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2695 aparently stays valid between application instances, so we can use this
2696 to remove and reset it later. According to a maemo-developers email from
2699 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2701 * configure.ac: Depend on libalarm for Maemo.
2703 * src/dbus_api/modest-dbus-api.h:
2704 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2705 (on_send_receive), (modest_dbus_req_handler):
2706 Handle a SEND_RECEIVE D-Bus method.
2708 * libmodest-dbus-client/libmodest-dbus-client.c:
2709 (libmodest_dbus_client_send_and_receive):
2710 * libmodest-dbus-client/libmodest-dbus-client.h:
2711 Add C convenience functions for calling the new D-Bus method.
2713 * src/modest-platform.h:
2714 * src/gnome/modest-platform.c:
2715 * src/maemo/modest-platform.c:
2716 Added modest_platform_set_update_interval(), which uses the
2717 alarmd API on Maemo.
2718 (modest_platform_init),
2719 Call modest_platform_set_update_interval(), using a hard-coded
2720 interval for now (until the global settings dialog is implemented),
2721 though I am not sure that this makes sense yet.
2723 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2725 * src/dbus_api/modest-dbus-callbacks.c:
2726 (modest_osso_cb_hw_state_handler):
2727 * src/dbus_api/modest-dbus-callbacks.h:
2728 * src/maemo/modest-platform.c: (modest_platform_init):
2729 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2730 in case this has some effect on the ability for Maemo to ping the
2733 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2735 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2736 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2737 warning. It is probably a logic error, but I need to fix the build.
2739 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2741 * src/modest-account-mgr.h:
2742 * src/modest-account-mgr.c:
2743 (modest_account_mgr_account_names): Add a gboolean enabled_only
2744 parameter, so we can get lists of onlt the enabled accounts.
2746 (modest_account_mgr_add_account),,
2747 (modest_account_mgr_account_with_display_name_exists):
2748 * src/maemo/modest-msg-edit-window.c: (get_transports):
2749 * src/modest-account-mgr-helpers.c:
2750 (modest_account_mgr_set_first_account_as_default):
2751 * src/modest-init.c: (init_default_account_maybe):
2752 * src/modest-tny-account-store.c: (get_accounts):
2753 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2754 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2755 * tests/check_account-mgr.c: (START_TEST):
2756 Provide the extra parameter, as appropriate.
2758 * src/widgets/modest-account-view.c: (update_account_view):
2759 Do not show disabled accounts (meaning that there is no way to
2760 enable/disable accounts in the UI (the feature is not in our UI
2761 specification), so we can use this internally only to mark unfinished
2762 or temporary account data.
2764 * src/maemo/easysetup/modest-easysetup-wizard.c:
2765 (create_account): Add boolean enable parameter, so we can specify FALSE
2766 to create the temporary account.
2767 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2768 (on_before_next): When finishing, when there is a temporary account, just
2770 Also, use a timeout to delay the showing of the dialog until gconf is likely
2771 to return correct information, due to a maemo gconf bug that is fixed in
2772 osso 1.1, but not yet in Bora.
2773 However, the dialog stays on screen after it is destroyed.
2775 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2776 for invalid data when cancelling. Use a hildon note instead of a dialog
2777 to complain about invalid data. Do not show the account-saved note if the
2778 account is disabled (a temporary account that will not really be saved for use
2781 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2783 * src/modest-account-mgr-helpers.h:
2784 * src/modest-account-mgr-helpers.c:
2785 Added modest_account_mgr_unset_default_account(),
2786 Added modest_account_mgr_set_first_account_as_default().
2788 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2789 If it was the default account, unset the default account name.
2791 * src/maemo/modest-account-view-window.c:
2792 (on_delete_button_clicked): If it was the default account,
2793 set the first remaining account as the default instead.
2795 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2796 a NULL account or a NULL default account, to prevent a crash. This should
2797 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2800 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2802 * src/widgets/modest-recpt-editor.c:
2803 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2804 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2805 TODO comment for this. This fixes the build.
2807 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2808 be the best place for it. This will in future update all auto-update accounts,
2809 rather than just the current/default account, when that gconf key exists.
2810 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2811 if there are no accounts, before calling do_send_receive().
2812 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2814 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2815 * src/maemo/modest-main-window-ui.h:
2816 * src/maemo/modest-main-window.c: (on_connection_changed),
2817 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2818 directly, becaue the signal handler does more.
2820 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-account-mgr-helpers.c:
2823 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2824 for the case that the account does not exist.
2826 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2827 (equivalent to the modest account name) rather than the tinymail account name
2828 (equivalent to the modest account title - human readable) to get the account data.
2829 Check for null account data to prevent the crash, and add a TODO comment saying that
2830 this needs fixing because it is using the server account name instead of the account name.
2832 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2835 * src/maemo/modest-account-settings-dialog.c: (show_error),
2837 Use hildon_note_new_information() for informative and error messages,
2838 which seems to be expected for Maemo applications (no documentation that I know of
2839 says this). I am surprised that there is no distinction between info and error
2842 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2844 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2845 it is easy to find where this is used.
2847 * src/maemo/easysetup/modest-easysetup-wizard.c:
2848 (create_page_welcome), (create_page_account_details),
2849 (create_page_user_details), (create_page_complete_easysetup),
2850 (create_page_custom_incoming), (create_page_custom_outgoing),
2851 (create_page_complete_custom):
2852 * src/maemo/modest-account-settings-dialog.c:
2853 (create_page_account_details), (create_page_user_details),
2854 (create_page_incoming), (create_page_outgoing):
2855 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2857 (modest_connection_specific_smtp_edit_window_init):
2858 * src/maemo/modest-connection-specific-smtp-window.c:
2859 (modest_connection_specific_smtp_window_init):
2860 * src/maemo/modest-signature-editor-dialog.c:
2861 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2862 and scrolling policy as per the Email Application Layout Guide, if I have
2865 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2867 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2868 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2869 which were empty, because these vfuncs have been removed from TnyAccountStore.
2870 This fixes the build.
2872 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2874 * src/maemo/modest-main-window.c:
2875 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2876 showing/hiding it. Added TODO because it probably should not be NULL.
2877 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2878 because unnecessary g_warnings() make degugging difficult.
2880 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2882 * src/maemo/modest-msg-edit-window.c:
2883 (modest_msg_edit_window_select_color),
2884 (modest_msg_edit_window_select_background_color): 2 const corrections and
2885 moving 2 #endifs before closing brackets, to fix the build.
2887 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/easysetup/modest-easysetup-wizard.h:
2890 * src/maemo/easysetup/modest-easysetup-wizard.c:
2891 (modest_easysetup_wizard_dialog_finalize),
2892 (on_button_edit_advanced_settings), (create_page_complete_custom),
2893 (on_response), (create_account):
2894 Implement the Advanced Settings edit button, by saving the account information,
2895 for the Advanded Settings dialog to use directly from gconf, and removing it
2896 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2897 Bug #5533 in the projects.maemo.org bugzilla.
2899 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2901 * src/maemo/modest-msg-view-window.c:
2902 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2903 when opening a message window.
2905 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2907 * src/maemo/easysetup/modest-easysetup-wizard.c:
2908 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2911 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2912 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2913 gconf settings. I probably added more checks than necessary, but that is safer.
2915 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2916 variable to fix the build, but this seems to be used when it is still NULL.
2918 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2920 * src/modest-platform.h:
2921 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2922 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2923 * src/modest-main.c: Implement this function so we can avoid using
2924 maemo-specific API from cross-platform code.
2926 * src/modest-tny-account-store.c:
2927 (get_smtp_specific_transport_account_for_open_connection):
2928 * src/modest-ui-actions.c: (check_for_connection),
2929 (modest_ui_actions_on_item_not_found):
2930 Use modest_platform_connect_and_wait() and put #idefs around other
2931 maemo-specific code, because only maemo currently has a way to
2932 identify connection names.
2934 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2936 * src/modest-tny-account-store.h:
2937 * src/modest-tny-account-store.c:
2938 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2939 the connection-specific SMTP server settings in the configuration.
2941 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2943 * src/maemo/modest-main-window.c: (on_connection_changed),
2945 * src/modest-main.c: (main), (start_ui), (send_mail):
2946 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2947 that is what is intended.
2949 * src/modest-ui-actions.c: (action_send), (action_receive),
2950 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2951 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2952 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2953 SMTP server is used when it is specified.
2955 (modest_ui_actions_on_send_receive):
2956 Check that a connection is open before proceeding.
2957 Receive and then send, instead of vice-versa, as per the specification.
2959 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2961 * src/modest-mail-operation.c:
2962 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2963 though I guess it should be something other than NULL.
2965 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/easysetup/modest-easysetup-wizard.c:
2968 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2969 combo twice, to avoid an g_warning and to make it visible again.
2970 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2971 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2972 (already intended) dereference when detaching, because we then recreate the menu.
2973 But I am not sure why the warning was happening, and it is possible that this is a memory
2976 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2978 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2979 and uri_parse_mailto() utility functions.
2980 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2982 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2984 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2986 * src/dbus_api/modest-dbus-api.h:
2987 * src/dbus_api/modest-dbus-callbacks.c:
2988 Use an idle callback to execute the modest code in the application's own thread.
2989 Remove the helloworld example method.
2990 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2991 parsed, and the open-message method is not implemented because this is not yet implemented in
2993 * libmodest-dbus-client/libmodest-dbus-client.c:
2994 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2995 (libmodest_dbus_client_open_message):
2996 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2998 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2999 body without crashing.
3001 * tests/dbus_api/Makefile.am:
3002 * tests/dbus_api/test_mail_to.c:
3003 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3005 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3007 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3008 Added file to fix the build. Sorry.
3010 * src/dbus_api/Makefile.am:
3011 * src/dbus_api/modest-dbus-api.h:
3012 * src/dbus_api/modest-dbus-callbacks.h:
3013 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3014 (modest_dbus_req_handler):
3015 Put constants in a separate header so it can be reused by the
3016 client library, without duplication
3018 * libmodest-dbus-client/Makefile.am:
3019 * libmodest-dbus-client/libmodest-dbus-client.c:
3020 (libmodest_dbus_client_call_helloworld),
3021 (libmodfest_dbus_client_send_mail),
3022 (libmodfest_dbus_client_mailto),
3023 (libmodfest_dbus_client_open_message):
3024 * libmodest-dbus-client/libmodest-dbus-client.h:
3025 (Partly) Implement a send_mail D-Bus method.
3027 * tests/dbus_api/Makefile.am:
3028 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3029 the send_email D-Bus method.
3031 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3035 * libmodest-dbus-client/Makefile.am:
3036 * libmodest-dbus-client/libmodest-dbus-client.c:
3037 * libmodest-dbus-client/libmodest-dbus-client.h:
3038 * tests/dbus_api/Makefile.am:
3039 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3040 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3042 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3044 * src/maemo/easysetup/modest-easysetup-wizard.c:
3045 (create_page_account_details):
3046 * src/maemo/modest-account-settings-dialog.c:
3047 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3048 widgets, because this might not be the default in future versions of the Maemo GTK+.
3049 However, I can not not get capitalization to work even in a simple test case.
3051 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3053 * src/maemo/easysetup/modest-easysetup-wizard.c:
3054 (create_page_custom_incoming), (create_page_custom_outgoing):
3055 * src/maemo/modest-account-settings-dialog.c:
3056 (create_page_account_details), (create_page_incoming),
3057 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3058 instead of using gtk_check_button_with_label(), so they are aligned like the other
3059 widgets, as per the UI spec.
3061 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3063 * src/maemo/easysetup/modest-easysetup-wizard.c:
3064 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3065 * src/widgets/modest-validating-entry.c:
3066 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3067 Modest prefix instead of an EasySetup prefix.
3069 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3071 * src/widgets/modest-validating-entry.h:
3072 * src/widgets/modest-validating-entry.c: (on_insert_text),
3073 Added easysetup_validating_entry_set_max_func(), used to set a callback
3074 to call when the max number of characters is reached. GtkEntry has a max-length
3075 already but is silent about it.
3077 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3078 (create_page_account_details), (create_page_user_details),
3080 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3081 (create_page_account_details), (create_page_user_details),
3082 (create_page_outgoing):
3083 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3084 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3085 the UI spec, when the user tries to enter more than the max number of characters.
3087 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3089 * src/maemo/easysetup/modest-easysetup-wizard.c:
3090 (create_page_user_details), (create_page_custom_incoming),
3091 (create_page_custom_outgoing):
3092 * src/maemo/modest-account-settings-dialog.c:
3093 (create_page_user_details), (create_page_incoming),
3094 (create_page_outgoing):
3095 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3096 (modest_connection_specific_smtp_edit_window_init):
3097 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3098 not appropriate. Bad Maemo-specific defaults!.
3100 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3102 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3103 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3104 (modest_signature_editor_dialog_set_settings):
3105 Disable the label and textview when the checkbox is disabled, and use the
3106 specified (UI spec) default signature text.
3108 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3110 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3111 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3113 * src/modest-defs.h:
3114 * src/modest-account-mgr-helpers.h:
3115 * src/modest-account-mgr-helpers.c:
3116 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3118 * src/maemo/Makefile.am:
3119 * src/maemo/modest-signature-editor-dialog.c:
3120 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3123 * src/maemo/modest-account-settings-dialog.h:
3124 * src/maemo/modest-account-settings-dialog.c:
3125 (modest_account_settings_dialog_finalize), (on_button_signature),
3126 (save_configuration): Use the new dialog when the Edit button is pressed, and
3127 save the changes if necessary, as per the UI spec.
3129 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3131 * src/maemo/Makefile.am:
3132 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3133 based on maemo-develoers email from Dirk.
3135 * src/maemo/easysetup/modest-easysetup-wizard.c:
3136 (create_page_welcome), (create_page_account_details),
3137 (create_page_user_details), (create_page_complete_easysetup),
3138 (create_page_custom_incoming), (create_page_custom_outgoing),
3139 (create_page_complete_custom),
3140 (modest_easysetup_wizard_dialog_init):
3141 * src/maemo/modest-account-settings-dialog.c:
3142 (create_page_account_details), (create_page_user_details),
3143 (create_page_incoming), (create_page_outgoing),
3144 (modest_account_settings_dialog_init):
3145 * src/maemo/modest-connection-specific-smtp-window.c:
3146 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3148 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/easysetup/modest-easysetup-wizard.c:
3151 (create_page_account_details), (create_page_custom_outgoing),
3152 (create_page_complete_custom):
3153 * src/maemo/modest-account-settings-dialog.c:
3154 (create_page_user_details), (create_page_incoming),
3155 (create_page_outgoing):
3156 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3157 (modest_connection_specific_smtp_edit_window_init):
3158 Use the correct (UI spec) port min/max, and use horizontal separators,
3161 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3163 * src/maemo/easysetup/modest-easysetup-wizard.c:
3164 (set_default_custom_servernames):
3165 * src/maemo/modest-account-settings-dialog.c:
3166 (create_page_incoming), (on_combo_outgoing_security_changed),
3167 (on_combo_incoming_security_changed), (create_page_outgoing),
3168 (modest_account_settings_dialog_set_account_name),
3169 (save_configuration):
3170 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3171 (on_combo_security_changed),
3172 (modest_connection_specific_smtp_edit_window_init),
3173 (modest_connection_specific_smtp_edit_window_set_connection),
3174 (modest_connection_specific_smtp_edit_window_get_settings):
3175 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3178 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3181 * src/maemo/easysetup/modest-easysetup-wizard.c:
3182 (create_page_custom_outgoing), (create_page_complete_custom):
3183 * src/maemo/modest-account-settings-dialog.c:
3184 (create_page_user_details), (create_page_outgoing):
3185 * src/maemo/modest-account-view-window.c: (button_box_new):
3186 Use changed logical IDs as per the most recent UI spec:
3187 mcen_bd_emailsetup_edit -> mcen_bd_edit
3188 mcen_bd_emailsetup_delete -> mcen_bd_delete
3189 mcen_bd_emailsetup_close -> mcen_bd_close
3191 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3195 * src/dbus_api/Makefile.am:
3196 * src/dbus_api/modest-dbus-callbacks.c:
3197 * src/dbus_api/modest-dbus-callbacks.h:
3198 * src/maemo/modest-platform.c: (modest_platform_init):
3199 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3201 * tests/Makefile.am:
3202 * tests/dbus_api/Makefile.am:
3203 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3205 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3207 * src/maemo/modest-account-settings-dialog.c:
3208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3209 Removed unnecessary includes.
3211 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/easysetup/modest-easysetup-wizard.c:
3214 * src/maemo/modest-account-settings-dialog.c:
3215 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3216 * src/widgets/Makefile.am:
3217 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3218 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3219 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3220 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3221 * src/widgets/modest-secureauth-combo-box.c:
3222 * src/widgets/modest-secureauth-combo-box.h:
3223 * src/widgets/modest-serversecurity-combo-box.c:
3224 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3225 made the GObject names more consistent with the rest of the Modest code.
3227 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3229 * src/maemo/easysetup/Makefile.am:
3230 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3231 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3232 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3233 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3234 * src/maemo/easysetup/modest-easysetup-wizard.c:
3235 * src/maemo/easysetup/modest-validating-entry.c:
3236 * src/maemo/easysetup/modest-validating-entry.h:
3237 * src/maemo/modest-account-settings-dialog.c:
3238 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3239 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3240 widgets/ because they are used outside of easysetup too. After checking in,
3241 svn will allow me to rename them too.
3243 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3245 * src/gnome/modest-msg-edit-window.c:
3246 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3247 linker error, to fix the build on the GNOME platform.
3248 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3249 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3250 ifdefed out to avoid a warning.
3252 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3254 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3255 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3256 some alternative for GTK+ 2.6.
3258 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3260 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3262 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3263 specified for EmailAccountsDialog in UI spec.
3265 * src/maemo/easysetup/modest-easysetup-wizard.c:
3266 * src/maemo/easysetup/modest-easysetup-wizard.h:
3267 * src/maemo/modest-account-settings-dialog.c:
3268 * src/maemo/modest-account-settings-dialog.h:
3269 Reuse a member window widget for the connection-specific SMTP server accounts,
3270 so we can tell it to create/save the accounts only if we actually save changes.
3272 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3273 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3274 (modest_connection_specific_smtp_edit_window_get_settings):
3275 Return a struct instance for temporarily remembering the entered data.
3277 * src/maemo/modest-connection-specific-smtp-window.h:
3278 * src/maemo/modest-connection-specific-smtp-window.c:
3279 (modest_connection_specific_smtp_window_finalize),
3280 (modest_connection_specific_smtp_window_fill_with_connections),
3282 (modest_connection_specific_smtp_window_save_server_accounts),
3283 (update_model_server_names): Do not actually save data until asked,
3284 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3286 (on_selection_changed),
3287 (modest_connection_specific_smtp_window_init): Disable the edit
3288 button when nothing is selected.
3290 * src/modest-account-mgr-helpers.c:
3291 * src/modest-account-mgr-helpers.h:
3292 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3295 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3297 * src/modest-account-mgr-helpers.h:
3298 * src/modest-account-mgr-helpers.c:
3299 (modest_account_mgr_get_unused_account_name),
3300 (modest_account_mgr_get_unused_account_display_name): Added these
3301 utility functions, to avoid code duplication.
3303 * src/maemo/easysetup/modest-easysetup-wizard.c:
3304 (create_page_account_details), (create_account):
3305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3306 (on_combo_security_changed),
3307 (modest_connection_specific_smtp_edit_window_init),
3308 (modest_connection_specific_smtp_edit_window_save_settings):
3309 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3310 * src/maemo/modest-connection-specific-smtp-window.c:
3311 (modest_connection_specific_smtp_window_finalize),
3312 (modest_connection_specific_smtp_window_fill_with_connections),
3313 (on_button_edit), (modest_connection_specific_smtp_window_init):
3314 * src/maemo/modest-connection-specific-smtp-window.h:
3315 Implementing saving of connection-specific server accounts.
3317 But I need to refactor this so we can save the data for each
3318 possible connection-specific account and only actually create the server accounts
3319 when the easysetup finished, or the OK button is pressed on the account settings
3322 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3324 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3325 (on_combo_security_changed):
3326 (modest_connection_specific_smtp_edit_window_init):
3327 Auto-fill the port number as in the account settings.
3329 (modest_connection_specific_smtp_edit_window_set_connection):
3330 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3331 * src/maemo/modest-connection-specific-smtp-window.c:
3332 (fill_with_connections), (on_button_edit),
3333 (modest_connection_specific_smtp_window_init):
3334 Turn the edit window into a dialog to simplify the code, and
3335 set a WM hint as in a GtkDialog, because only a popup can be on top of
3336 another window in Maemo, and popups usually have no WM decoration.
3338 * src/modest-defs.h:
3339 * src/modest-account-mgr-helpers.c:
3340 (modest_account_mgr_set_connection_specific_smtp),
3341 (modest_account_mgr_remove_connection_specific_smtp),
3342 (modest_account_mgr_get_connection_specific_smtp):
3343 * src/modest-account-mgr-helpers.h: Some functions to write the
3344 connection-specific SMTP server information. Not yet used.
3347 * src/widgets/modest-folder-view.c: (text_cell_data):
3348 Fix a warning about an uninitialized variable.
3349 (on_configuration_key_changed): Put an #ifdef around the use
3350 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3352 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3354 * src/maemo/modest-account-settings-dialog.h:
3355 * src/maemo/modest-account-settings-dialog.c:
3356 Added connect_for_modified() utility function to mark the new modified boolean.
3358 (create_page_account_details), (create_page_user_details),
3359 (create_page_incoming), (create_page_outgoing), (on_response),
3360 (modest_account_settings_dialog_init),
3361 (modest_account_settings_dialog_set_account_name):
3362 Only warn about unsaved changes when there are actually unsaved changes.
3364 * src/modest-account-mgr-helpers.c:
3365 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3366 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3367 to get the data from there in future.
3369 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3371 * src/modest-defs.h:
3373 * src/modest-account-mgr-helpers.h:
3374 * src/modest-account-mgr-helpers.c:
3375 Store the security account setting in a single conf key instead of using
3376 the options list, so that the list is left for just the to-be-removed camel hack,
3377 and because gconf_client_set_list() is failing for some reason.
3379 * src/modest-account-mgr.c:
3380 (modest_account_mgr_add_server_account):
3381 * src/maemo/modest-account-settings-dialog.c:
3382 (modest_account_settings_dialog_set_account_name),
3383 (save_configuration): Use the renamed functions.
3386 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3388 * src/widgets/Makefile.am:
3389 * src/widgets/modest-limit-retrieve-combo-box.c:
3390 * src/widgets/modest-limit-retrieve-combo-box.h:
3391 * src/widgets/modest-retrieve-combo-box.c:
3392 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3393 the account settings dialog.
3395 * src/modest-defs.h:
3396 * src/modest-account-mgr-helpers.h:
3397 * src/modest-account-mgr-helpers.c:
3398 (modest_server_account_get_option_secure_auth),
3399 (modest_server_account_set_option_secure_auth):
3400 * src/modest-account-mgr.c:
3401 (modest_account_mgr_add_server_account):
3402 Use the existing AUTH_MECH conf key for the secure-auth setting,
3403 instead of putting it in the list options, because this was actually used already.
3405 * src/maemo/modest-account-settings-dialog.c:
3406 (create_page_account_details),
3407 (modest_account_settings_dialog_set_account_name),
3408 (save_configuration):
3409 * src/maemo/modest-account-settings-dialog.h:
3410 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3411 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3413 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3415 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3416 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3417 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3419 * src/modest-defs.h:
3420 * src/maemo/modest-account-settings-dialog.c:
3421 (create_page_incoming), (on_combo_outgoing_security_changed),
3422 (on_combo_incoming_security_changed), (create_page_outgoing),
3423 (modest_account_settings_dialog_set_account_name),
3424 (save_configuration): Load/Save the port number, and change it when the
3425 security combo changes, to suitable defaults.
3427 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3429 * src/modest-account-mgr.c:
3430 (modest_account_mgr_add_server_account): Set the security and secure-auth
3431 options, and add a comment saying that the other camel-specific options should be
3434 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3436 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3438 * src/modest-tny-account-store.c: (account_list_free),
3439 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3440 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3443 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3445 * src/modest-protocol-info.c:
3446 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3447 is required by our UI spec. Maybe something in our implementation will use this eventually.
3448 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3449 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3450 instead of the previous 0 placeholder.
3452 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3453 secure-auth settings.
3454 * src/modest-account-mgr-helpers.h:
3455 * src/modest-account-mgr-helpers.c:
3456 (modest_server_account_data_get_option_secure_auth),
3457 (modest_server_account_set_option_secure_auth),
3458 (modest_server_account_data_get_option_security),
3459 (modest_server_account_set_option_security): Added this API for getting and setting the security
3460 and secure-auth settings.
3462 * src/maemo/modest-account-settings-dialog.h:
3463 * src/maemo/modest-account-settings-dialog.c:
3464 (modest_account_settings_dialog_finalize), (check_data),
3465 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3466 about changing titles.
3467 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3468 (save_configuration): Save the security and secure-auth settings.
3470 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3471 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3473 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3475 * src/modest-defs.h:
3476 * src/modest-account-mgr.c:
3477 (modest_account_mgr_add_server_account):
3478 Added and used defines for the options key and value pair strings,
3479 that are used so far, though they do not seem to correspond to anything in our
3480 UI specs or ModestProtocol enum.
3482 * src/modest-account-mgr-helpers.h:
3483 * src/modest-account-mgr-helpers.c:
3484 (compare_option_strings_for_name),
3485 (modest_server_account_data_get_option_value),
3486 (modest_server_account_data_get_option_bool),
3487 (modest_account_mgr_get_server_account_option):
3488 Added helper functions for parsing the options GSList.
3490 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3492 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3493 display name is based on the supplied account name.
3494 * src/modest-account-mgr.c:
3495 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3496 with an inefficient, but good-enough, implementation.
3498 * src/maemo/easysetup/modest-easysetup-wizard.c:
3499 (create_page_account_details), (on_before_next), (create_account):
3500 Check for existing display names rather than (non-user-visible) account names, and just
3501 create and set a unique account name at the end.
3503 * src/maemo/modest-account-settings-dialog.c:
3504 (modest_account_settings_dialog_init),
3505 (modest_account_settings_dialog_set_account_name),
3506 (create_page_incoming): Show the display name, instead of the account name.
3507 (on_response): Do some (not all) extra checks, as in the UI spec.
3508 (save_configuration): Save the display name if it was changed.
3510 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3512 * po/en_GB.po: Added needed logical ID and translation.
3513 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3514 (init_view): Made the is-default column clicking work.
3516 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3519 * src/maemo/easysetup/Makefile.am:
3520 * src/maemo/easysetup/modest-easysetup-wizard.c:
3521 (modest_easysetup_wizard_dialog_init):
3522 * src/maemo/easysetup/provider-data-test.keyfile:
3523 * src/maemo/easysetup/provider-data.keyfile:
3524 Moved the provider data file to the new modest-providers-data package and used it from there.
3526 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3528 * src/modest-local-folder-info.c:
3529 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3530 N_() was already used on the static strings, but this just marks it for translation without
3531 using the translation.
3533 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3535 * src/maemo/modest-account-settings-dialog.c:
3536 (create_page_incoming),
3537 (modest_account_settings_dialog_set_account_name):
3538 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3539 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3540 I will do this if nobody else gets there first.
3542 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3544 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3545 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3546 save the security stuff.
3548 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3550 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3551 Set the email address and user fullname, which I now see must be
3554 * src/maemo/modest-account-settings-dialog.h:
3555 * src/maemo/modest-account-settings-dialog.c:
3557 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3558 leave-on-server and authentication.
3559 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3562 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3565 * src/maemo/modest-account-settings-dialog.c:
3566 * src/maemo/modest-account-settings-dialog.h:
3567 Most (but not all) of the widgets are now present as specified by the UI spec.
3568 No changes are yet saved, and some details are not properly shown yet.
3570 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3572 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3574 * src/maemo/Makefile.am:
3575 * src/maemo/modest-account-settings-dialog.c:
3576 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3577 an existing account. Doesn't do much yet.
3579 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3580 Open the accounts settings dialog when Edit is clicked.
3582 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3584 * src/maemo/easysetup/Makefile.am:
3585 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3587 * src/maemo/easysetup/modest-easysetup-wizard.c:
3588 (modest_easysetup_wizard_dialog_init):
3589 Try to get the source directory from the build system,
3590 instead of hard-coding "./" into the source code, when opening our local
3591 copies of the configuration files.
3592 But this still fails when opening the wizard from the Accounts window,
3593 maybe because the working directory seems to change at runtime.
3594 So the wizard will fail the second time unless you copy the files into their
3595 proper locations - see the stdout warnings for the paths.
3597 (create_page_account_details),(on_before_next):
3598 Check for existing non-server accounts instead of server accounts,
3599 so the default account name is useful again, and to prevent trying to
3602 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3603 Show the wizard when New is clicked.
3605 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3606 (init_view): Show the column headers, and show the columns that are
3607 specified in the UI specs. However, something in Maemo's GTK+ prevents
3608 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3609 change the default account. This is despite unsetting the special properties.
3611 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3613 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3614 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3615 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3616 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3617 to make that clearer.
3618 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3620 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3622 * src/maemo/modest-account-view-window.c:
3623 (modest_account_view_window_init),
3624 (modest_account_view_window_new):
3625 Use the same buttons as specified in the
3626 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3627 the existing widgets, which never had a chance of working.
3628 Put the ModestAccountView treeview in a scrolled window.
3629 Do not repeat the initialization in both _init() and _new().
3631 * src/widgets/modest-account-view.c: (update_account_view):
3632 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3633 this widget and window shows no accounts.
3635 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3637 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3639 * src/maemo/easysetup/modest-easysetup-wizard.c:
3640 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3641 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3642 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3645 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3646 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3647 accounts exist yet, as in the UI spec.
3649 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3651 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3653 * src/maemo/Makefile.am:
3654 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3655 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3656 New window for editing connection-specific smtp details.
3657 Not fully implemented.
3659 * src/maemo/modest-connection-specific-smtp-window.c:
3660 (modest_connection_specific_smtp_window_finalize) :
3661 unref the tree model.
3662 (on_button_edit): Show the edit window.
3664 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3666 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3669 * src/maemo/Makefile.am:
3670 * src/maemo/modest-connection-specific-smtp-window.c:
3671 * src/maemo/modest-connection-specific-smtp-window.h:
3672 New window for showing the list of connections, for connection-specific
3673 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3674 * src/maemo/easysetup/modest-easysetup-wizard.c:
3675 (create_page_custom_outgoing): Show the new window when the button is clicked.
3677 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3679 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3680 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3681 * src/maemo/modest-msg-edit-window.c:
3682 (modest_msg_edit_window_insert_image):
3683 * src/modest-conf.c: (modest_conf_key_escape):
3684 * src/modest-mail-operation.c:
3685 (modest_mail_operation_send_new_mail):
3686 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3687 (modest_ui_actions_on_new_account):
3688 * src/widgets/modest-attachment-view.c: (update_filename_request):
3689 * src/widgets/modest-mail-header-view.c:
3690 Corrected warnings that were breaking the build, by commenting out unused variables,
3691 and a function, and by including a header.
3693 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3695 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3696 so we can #ifdef around platform-specific code when necessary.
3697 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3698 to allow this to build for the GNOME platform too.
3700 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3702 * src/maemo/easysetup/modest-easysetup-wizard.c:
3703 Added util_increment_name() and used it in create_page_account_details()
3704 to make sure that the default account name is always a new name.
3706 (modest_easysetup_wizard_dialog_init),
3707 (set_default_custom_servernames): Some minor memory management fixes.
3709 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3713 * src/modest-runtime.c: (init_i18n): Restored the translation
3714 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3715 are defined in config.h, and the translations are installed.
3717 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3718 is defined for translation.
3720 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3722 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3724 * src/maemo/easysetup/modest-easysetup-wizard.c:
3725 (modest_easysetup_wizard_dialog_init):
3726 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3727 Use realistic paths (though they should use $prefix generically) to the
3728 mcc_mapping and provider-data.keyfile files which might work when they
3729 are installed by the future version of the operator-wizard package,
3730 and then fallback to paths in our source code, with an explanatory
3733 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3737 * src/maemo/Makefile.am:
3738 * src/maemo/easysetup/: Added files from the previously-exernal
3739 osso-modest-easysetup.
3740 * src/maemo/modest-main-window-ui.h:
3741 * src/modest-ui-actions.c:
3742 * src/modest-ui-actions.h:
3743 Added modest_ui_actions_on_new_account() as a signal handler for the
3744 New Account menu item. It shows the easysetup wizard.
3745 * po/en_GB.po: Added additional needed logical IDs and translations.