git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
   4         Added file to fix the build. Sorry.
   5
   6         * src/dbus_api/Makefile.am:
   7         * src/dbus_api/modest-dbus-api.h:
   8         * src/dbus_api/modest-dbus-callbacks.h:
   9         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
  10         (modest_dbus_req_handler):
  11         Put constants in a separate header so it can be reused by the
  12         client library, without duplication
  13
  14         * libmodest-dbus-client/Makefile.am:
  15         * libmodest-dbus-client/libmodest-dbus-client.c:
  16         (libmodest_dbus_client_call_helloworld),
  17         (libmodfest_dbus_client_send_mail),
  18         (libmodfest_dbus_client_mailto),
  19         (libmodfest_dbus_client_open_message):
  20         * libmodest-dbus-client/libmodest-dbus-client.h:
  21         (Partly) Implement a send_mail D-Bus method.
  22
  23         * tests/dbus_api/Makefile.am:
  24         * tests/dbus_api/test_send_mail.c: (main): Added a test for
  25         the send_email D-Bus method.
  26
  27 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  28
  29         * Makefile.am:
  30         * configure.ac:
  31         * libmodest-dbus-client/Makefile.am:
  32         * libmodest-dbus-client/libmodest-dbus-client.c:
  33         * libmodest-dbus-client/libmodest-dbus-client.h:
  34         * tests/dbus_api/Makefile.am:
  35         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
  36         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
  37
  38 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  39
  40         * src/maemo/easysetup/modest-easysetup-wizard.c:
  41         (create_page_account_details):
  42         * src/maemo/modest-account-settings-dialog.c:
  43         (create_page_account_details): Explicitly set auto-capitalization mode for the title
  44         widgets, because this might not be the default in future versions of the Maemo GTK+.
  45         However, I can not not get capitalization to work even in a simple test case.
  46
  47 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  48
  49         * src/maemo/easysetup/modest-easysetup-wizard.c:
  50         (create_page_custom_incoming), (create_page_custom_outgoing):
  51         * src/maemo/modest-account-settings-dialog.c:
  52         (create_page_account_details), (create_page_incoming),
  53         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
  54         instead of using gtk_check_button_with_label(), so they are aligned like the other
  55         widgets, as per the UI spec.
  56
  57 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  58
  59         * src/maemo/easysetup/modest-easysetup-wizard.c:
  60         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  61         * src/widgets/modest-validating-entry.c:
  62         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
  63         Modest prefix instead of an EasySetup prefix.
  64
  65 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  66
  67         * src/widgets/modest-validating-entry.h:
  68         * src/widgets/modest-validating-entry.c: (on_insert_text),
  69         Added easysetup_validating_entry_set_max_func(), used to set a callback
  70         to call when the max number of characters is reached. GtkEntry has a max-length
  71         already but is silent about it.
  72
  73         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
  74         (create_page_account_details), (create_page_user_details),
  75         (create_account):
  76         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
  77         (create_page_account_details), (create_page_user_details),
  78         (create_page_outgoing):
  79         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
  80         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
  81         the UI spec, when the user tries to enter more than the max number of characters.
  82
  83 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  84
  85         * src/maemo/easysetup/modest-easysetup-wizard.c:
  86         (create_page_user_details), (create_page_custom_incoming),
  87         (create_page_custom_outgoing):
  88         * src/maemo/modest-account-settings-dialog.c:
  89         (create_page_user_details), (create_page_incoming),
  90         (create_page_outgoing):
  91         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  92         (modest_connection_specific_smtp_edit_window_init):
  93         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
  94         not appropriate. Bad Maemo-specific defaults!.
  95
  96 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  97
  98         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
  99         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 100         (modest_signature_editor_dialog_set_settings):
 101         Disable the label and textview when the checkbox is disabled, and use the
 102         specified (UI spec) default signature text.
 103
 104 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 105
 106         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 107         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 108
 109         * src/modest-defs.h:
 110         * src/modest-account-mgr-helpers.h:
 111         * src/modest-account-mgr-helpers.c:
 112         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 113
 114         * src/maemo/Makefile.am:
 115         * src/maemo/modest-signature-editor-dialog.c:
 116         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 117         as per the UI spec.
 118
 119         * src/maemo/modest-account-settings-dialog.h:
 120         * src/maemo/modest-account-settings-dialog.c:
 121         (modest_account_settings_dialog_finalize), (on_button_signature),
 122         (save_configuration): Use the new dialog when the Edit button is pressed, and
 123         save the changes if necessary, as per the UI spec.
 124
 125 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 126
 127         * src/maemo/Makefile.am:
 128         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 129         based on maemo-develoers email from Dirk.
 130
 131         * src/maemo/easysetup/modest-easysetup-wizard.c:
 132         (create_page_welcome), (create_page_account_details),
 133         (create_page_user_details), (create_page_complete_easysetup),
 134         (create_page_custom_incoming), (create_page_custom_outgoing),
 135         (create_page_complete_custom),
 136         (modest_easysetup_wizard_dialog_init):
 137         * src/maemo/modest-account-settings-dialog.c:
 138         (create_page_account_details), (create_page_user_details),
 139         (create_page_incoming), (create_page_outgoing),
 140         (modest_account_settings_dialog_init):
 141         * src/maemo/modest-connection-specific-smtp-window.c:
 142         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 143
 144 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 145
 146         * src/maemo/easysetup/modest-easysetup-wizard.c:
 147         (create_page_account_details), (create_page_custom_outgoing),
 148         (create_page_complete_custom):
 149         * src/maemo/modest-account-settings-dialog.c:
 150         (create_page_user_details), (create_page_incoming),
 151         (create_page_outgoing):
 152         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 153         (modest_connection_specific_smtp_edit_window_init):
 154         Use the correct (UI spec) port min/max, and use horizontal separators,
 155         as per the UI spec.
 156
 157 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 158
 159         * src/maemo/easysetup/modest-easysetup-wizard.c:
 160         (set_default_custom_servernames):
 161         * src/maemo/modest-account-settings-dialog.c:
 162         (create_page_incoming), (on_combo_outgoing_security_changed),
 163         (on_combo_incoming_security_changed), (create_page_outgoing),
 164         (modest_account_settings_dialog_set_account_name),
 165         (save_configuration):
 166         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 167         (on_combo_security_changed),
 168         (modest_connection_specific_smtp_edit_window_init),
 169         (modest_connection_specific_smtp_edit_window_set_connection),
 170         (modest_connection_specific_smtp_edit_window_get_settings):
 171         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 172         as per the UI spec.
 173
 174 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 175
 176         * po/en_GB.po:
 177         * src/maemo/easysetup/modest-easysetup-wizard.c:
 178         (create_page_custom_outgoing), (create_page_complete_custom):
 179         * src/maemo/modest-account-settings-dialog.c:
 180         (create_page_user_details), (create_page_outgoing):
 181         * src/maemo/modest-account-view-window.c: (button_box_new):
 182         Use changed logical IDs as per the most recent UI spec:
 183         mcen_bd_emailsetup_edit -> mcen_bd_edit
 184         mcen_bd_emailsetup_delete -> mcen_bd_delete
 185         mcen_bd_emailsetup_close -> mcen_bd_close
 186
 187 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 188
 189         * configure.ac:
 190         * src/Makefile.am:
 191         * src/dbus_api/Makefile.am:
 192         * src/dbus_api/modest-dbus-callbacks.c:
 193         * src/dbus_api/modest-dbus-callbacks.h:
 194         * src/maemo/modest-platform.c: (modest_platform_init):
 195         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 196         method.
 197         * tests/Makefile.am:
 198         * tests/dbus_api/Makefile.am:
 199         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 200
 201 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 202
 203         * src/maemo/modest-account-settings-dialog.c:
 204         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 205         Removed unnecessary includes.
 206
 207 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 208
 209         * src/maemo/easysetup/modest-easysetup-wizard.c:
 210         * src/maemo/modest-account-settings-dialog.c:
 211         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 212         * src/widgets/Makefile.am:
 213         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 214         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 215         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 216         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 217         * src/widgets/modest-secureauth-combo-box.c:
 218         * src/widgets/modest-secureauth-combo-box.h:
 219         * src/widgets/modest-serversecurity-combo-box.c:
 220         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 221         made the GObject names more consistent with the rest of the Modest code.
 222
 223 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 224
 225         * src/maemo/easysetup/Makefile.am:
 226         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 227         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 228         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 229         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 230         * src/maemo/easysetup/modest-easysetup-wizard.c:
 231         * src/maemo/easysetup/modest-validating-entry.c:
 232         * src/maemo/easysetup/modest-validating-entry.h:
 233         * src/maemo/modest-account-settings-dialog.c:
 234         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 235         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 236         widgets/ because they are used outside of easysetup too. After checking in,
 237         svn will allow me to rename them too.
 238
 239 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 240
 241         * src/gnome/modest-msg-edit-window.c:
 242         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 243         linker error, to fix the build on the GNOME platform.
 244         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 245         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 246         ifdefed out to avoid a warning.
 247
 248 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 249
 250         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 251         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 252         some alternative for GTK+ 2.6.
 253
 254 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 255
 256         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 257
 258         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 259         specified for EmailAccountsDialog in UI spec.
 260
 261         * src/maemo/easysetup/modest-easysetup-wizard.c:
 262         * src/maemo/easysetup/modest-easysetup-wizard.h:
 263         * src/maemo/modest-account-settings-dialog.c:
 264         * src/maemo/modest-account-settings-dialog.h:
 265         Reuse a member window widget for the connection-specific SMTP server accounts,
 266         so we can tell it to create/save the accounts only if we actually save changes.
 267
 268         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 269         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 270         (modest_connection_specific_smtp_edit_window_get_settings):
 271         Return a struct instance for temporarily remembering the entered data.
 272
 273         * src/maemo/modest-connection-specific-smtp-window.h:
 274         * src/maemo/modest-connection-specific-smtp-window.c:
 275         (modest_connection_specific_smtp_window_finalize),
 276         (modest_connection_specific_smtp_window_fill_with_connections),
 277         (on_button_edit),
 278         (modest_connection_specific_smtp_window_save_server_accounts),
 279         (update_model_server_names): Do not actually save data until asked,
 280         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 281
 282         (on_selection_changed),
 283         (modest_connection_specific_smtp_window_init): Disable the edit
 284         button when nothing is selected.
 285
 286         * src/modest-account-mgr-helpers.c:
 287         * src/modest-account-mgr-helpers.h:
 288         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 289         elsewhere.
 290
 291 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 292
 293         * src/modest-account-mgr-helpers.h:
 294         * src/modest-account-mgr-helpers.c:
 295         (modest_account_mgr_get_unused_account_name),
 296         (modest_account_mgr_get_unused_account_display_name): Added these
 297         utility functions, to avoid code duplication.
 298
 299         * src/maemo/easysetup/modest-easysetup-wizard.c:
 300         (create_page_account_details), (create_account):
 301         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 302         (on_combo_security_changed),
 303         (modest_connection_specific_smtp_edit_window_init),
 304         (modest_connection_specific_smtp_edit_window_save_settings):
 305         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 306         * src/maemo/modest-connection-specific-smtp-window.c:
 307         (modest_connection_specific_smtp_window_finalize),
 308         (modest_connection_specific_smtp_window_fill_with_connections),
 309         (on_button_edit), (modest_connection_specific_smtp_window_init):
 310         * src/maemo/modest-connection-specific-smtp-window.h:
 311         Implementing saving of connection-specific server accounts.
 312
 313         But I need to refactor this so we can save the data for each
 314         possible connection-specific account and only actually create the server accounts
 315         when the easysetup finished, or the OK button is pressed on the account settings
 316         dialog.
 317
 318 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 319
 320         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 321         (on_combo_security_changed):
 322         (modest_connection_specific_smtp_edit_window_init):
 323         Auto-fill the port number as in the account settings.
 324
 325         (modest_connection_specific_smtp_edit_window_set_connection):
 326         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 327         * src/maemo/modest-connection-specific-smtp-window.c:
 328         (fill_with_connections), (on_button_edit),
 329         (modest_connection_specific_smtp_window_init):
 330         Turn the edit window into a dialog to simplify the code, and
 331         set a WM hint as in a GtkDialog, because only a popup can be on top of
 332         another window in Maemo, and popups usually have no WM decoration.
 333
 334         * src/modest-defs.h:
 335         * src/modest-account-mgr-helpers.c:
 336         (modest_account_mgr_set_connection_specific_smtp),
 337         (modest_account_mgr_remove_connection_specific_smtp),
 338         (modest_account_mgr_get_connection_specific_smtp):
 339         * src/modest-account-mgr-helpers.h: Some functions to write the
 340         connection-specific SMTP server information. Not yet used.
 341
 342
 343         * src/widgets/modest-folder-view.c: (text_cell_data):
 344         Fix a warning about an uninitialized variable.
 345         (on_configuration_key_changed): Put an #ifdef around the use
 346         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 347
 348 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 349
 350         * src/maemo/modest-account-settings-dialog.h:
 351         * src/maemo/modest-account-settings-dialog.c:
 352         Added connect_for_modified() utility function to mark the new modified boolean.
 353
 354         (create_page_account_details), (create_page_user_details),
 355         (create_page_incoming), (create_page_outgoing), (on_response),
 356         (modest_account_settings_dialog_init),
 357         (modest_account_settings_dialog_set_account_name):
 358         Only warn about unsaved changes when there are actually unsaved changes.
 359
 360         * src/modest-account-mgr-helpers.c:
 361         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 362         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 363         to get the data from there in future.
 364
 365 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 366
 367         * src/modest-defs.h:
 368
 369         * src/modest-account-mgr-helpers.h:
 370         * src/modest-account-mgr-helpers.c:
 371         Store the security account setting in a single conf key instead of using
 372         the options list, so that the list is left for just the to-be-removed camel hack,
 373         and because gconf_client_set_list() is failing for some reason.
 374
 375         * src/modest-account-mgr.c:
 376         (modest_account_mgr_add_server_account):
 377         * src/maemo/modest-account-settings-dialog.c:
 378         (modest_account_settings_dialog_set_account_name),
 379         (save_configuration): Use the renamed functions.
 380
 381
 382 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 383
 384         * src/widgets/Makefile.am:
 385         * src/widgets/modest-limit-retrieve-combo-box.c:
 386         * src/widgets/modest-limit-retrieve-combo-box.h:
 387         * src/widgets/modest-retrieve-combo-box.c:
 388         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 389         the account settings dialog.
 390
 391         * src/modest-defs.h:
 392         * src/modest-account-mgr-helpers.h:
 393         * src/modest-account-mgr-helpers.c:
 394         (modest_server_account_get_option_secure_auth),
 395         (modest_server_account_set_option_secure_auth):
 396         * src/modest-account-mgr.c:
 397         (modest_account_mgr_add_server_account):
 398         Use the existing AUTH_MECH conf key for the secure-auth setting,
 399         instead of putting it in the list options, because this was actually used already.
 400
 401         * src/maemo/modest-account-settings-dialog.c:
 402         (create_page_account_details),
 403         (modest_account_settings_dialog_set_account_name),
 404         (save_configuration):
 405         * src/maemo/modest-account-settings-dialog.h:
 406         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 407         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 408
 409 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 410
 411         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 412         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 413         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 414
 415         * src/modest-defs.h:
 416         * src/maemo/modest-account-settings-dialog.c:
 417         (create_page_incoming), (on_combo_outgoing_security_changed),
 418         (on_combo_incoming_security_changed), (create_page_outgoing),
 419         (modest_account_settings_dialog_set_account_name),
 420         (save_configuration): Load/Save the port number, and change it when the
 421         security combo changes, to suitable defaults.
 422
 423 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 424
 425         * src/modest-account-mgr.c:
 426         (modest_account_mgr_add_server_account): Set the security and secure-auth
 427         options, and add a comment saying that the other camel-specific options should be
 428         removed in future.
 429
 430 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 431
 432         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 433         found by valgrind.
 434         * src/modest-tny-account-store.c: (account_list_free),
 435         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 436         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 437         easy to fix.
 438
 439 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 440
 441         * src/modest-protocol-info.c:
 442         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 443         is required by our UI spec. Maybe something in our implementation will use this eventually.
 444         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 445         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 446         instead of the previous 0 placeholder.
 447
 448         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 449         secure-auth settings.
 450         * src/modest-account-mgr-helpers.h:
 451         * src/modest-account-mgr-helpers.c:
 452         (modest_server_account_data_get_option_secure_auth),
 453         (modest_server_account_set_option_secure_auth),
 454         (modest_server_account_data_get_option_security),
 455         (modest_server_account_set_option_security): Added this API for getting and setting the security
 456         and secure-auth settings.
 457
 458         * src/maemo/modest-account-settings-dialog.h:
 459         * src/maemo/modest-account-settings-dialog.c:
 460         (modest_account_settings_dialog_finalize), (check_data),
 461         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 462         about changing titles.
 463         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 464         (save_configuration): Save the security and secure-auth settings.
 465
 466         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 467         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 468
 469 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 470
 471         * src/modest-defs.h:
 472         * src/modest-account-mgr.c:
 473         (modest_account_mgr_add_server_account):
 474         Added and used defines for the options key and value pair strings,
 475         that are used so far, though they do not seem to correspond to anything in our
 476         UI specs or ModestProtocol enum.
 477
 478         * src/modest-account-mgr-helpers.h:
 479         * src/modest-account-mgr-helpers.c:
 480         (compare_option_strings_for_name),
 481         (modest_server_account_data_get_option_value),
 482         (modest_server_account_data_get_option_bool),
 483         (modest_account_mgr_get_server_account_option):
 484         Added helper functions for parsing the options GSList.
 485
 486 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 487
 488         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 489         display name is based on the supplied account name.
 490         * src/modest-account-mgr.c:
 491         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 492         with an inefficient, but good-enough, implementation.
 493
 494         * src/maemo/easysetup/modest-easysetup-wizard.c:
 495         (create_page_account_details), (on_before_next), (create_account):
 496         Check for existing display names rather than (non-user-visible) account names, and just
 497         create and set a unique account name at the end.
 498
 499         * src/maemo/modest-account-settings-dialog.c:
 500         (modest_account_settings_dialog_init),
 501         (modest_account_settings_dialog_set_account_name),
 502         (create_page_incoming): Show the display name, instead of the account name.
 503         (on_response): Do some (not all) extra checks, as in the UI spec.
 504         (save_configuration): Save the display name if it was changed.
 505
 506 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 507
 508         * po/en_GB.po: Added needed logical ID and translation.
 509         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 510         (init_view): Made the is-default column clicking work.
 511
 512 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 513
 514         * configure.ac:
 515         * src/maemo/easysetup/Makefile.am:
 516         * src/maemo/easysetup/modest-easysetup-wizard.c:
 517         (modest_easysetup_wizard_dialog_init):
 518         * src/maemo/easysetup/provider-data-test.keyfile:
 519         * src/maemo/easysetup/provider-data.keyfile:
 520         Moved the provider data file to the new modest-providers-data package and used it from there.
 521
 522 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 523
 524         * src/modest-local-folder-info.c:
 525         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 526         N_() was already used on the static strings, but this just marks it for translation without
 527         using the translation.
 528
 529 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 530
 531         * src/maemo/modest-account-settings-dialog.c:
 532         (create_page_incoming),
 533         (modest_account_settings_dialog_set_account_name):
 534         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 535         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 536         I will do this if nobody else gets there first.
 537
 538 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 539
 540         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 541         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 542         save the security stuff.
 543
 544 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 545
 546         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 547         Set the email address and user fullname, which I now see must be
 548         done separately.
 549
 550         * src/maemo/modest-account-settings-dialog.h:
 551         * src/maemo/modest-account-settings-dialog.c:
 552          (on_response),
 553         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 554         leave-on-server and authentication.
 555         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 556         how to do the rest.
 557
 558 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 559
 560
 561         * src/maemo/modest-account-settings-dialog.c:
 562         * src/maemo/modest-account-settings-dialog.h:
 563         Most (but not all) of the widgets are now present as specified by the UI spec.
 564         No changes are yet saved, and some details are not properly shown yet.
 565
 566         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 567
 568 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 569
 570         * src/maemo/Makefile.am:
 571         * src/maemo/modest-account-settings-dialog.c:
 572         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 573         an existing account. Doesn't do much yet.
 574
 575         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 576         Open the accounts settings dialog when Edit is clicked.
 577
 578 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 579
 580         * src/maemo/easysetup/Makefile.am:
 581         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 582         (load_from_file):
 583         * src/maemo/easysetup/modest-easysetup-wizard.c:
 584         (modest_easysetup_wizard_dialog_init):
 585         Try to get the source directory from the build system,
 586         instead of hard-coding "./" into the source code, when opening our local
 587         copies of the configuration files.
 588         But this still fails when opening the wizard from the Accounts window,
 589         maybe because the working directory seems to change at runtime.
 590         So the wizard will fail the second time unless you copy the files into their
 591         proper locations - see the stdout warnings for the paths.
 592
 593         (create_page_account_details),(on_before_next):
 594         Check for existing non-server accounts instead of server accounts,
 595         so the default account name is useful again, and to prevent trying to
 596         recreate accounts.
 597
 598         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 599         Show the wizard when New is clicked.
 600
 601         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 602         (init_view): Show the column headers, and show the columns that are
 603         specified in the UI specs. However, something in Maemo's GTK+ prevents
 604         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 605         change the default account. This is despite unsetting the special properties.
 606
 607 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 608
 609         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 610         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 611         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 612         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 613         to make that clearer.
 614         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 615
 616 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 617
 618         * src/maemo/modest-account-view-window.c:
 619         (modest_account_view_window_init),
 620         (modest_account_view_window_new):
 621         Use the same buttons as specified in the
 622         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 623         the existing widgets, which never had a chance of working.
 624         Put the ModestAccountView treeview in a scrolled window.
 625         Do not repeat the initialization in both _init() and _new().
 626
 627         * src/widgets/modest-account-view.c: (update_account_view):
 628         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 629         this widget and window shows no accounts.
 630
 631         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 632
 633 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 634
 635         * src/maemo/easysetup/modest-easysetup-wizard.c:
 636         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 637         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 638         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 639         which seems wrong.
 640
 641         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 642         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 643         accounts exist yet, as in the UI spec.
 644
 645         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 646
 647 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * src/maemo/Makefile.am:
 650         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 651         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 652         New window for editing connection-specific smtp details.
 653         Not fully implemented.
 654
 655         * src/maemo/modest-connection-specific-smtp-window.c:
 656         (modest_connection_specific_smtp_window_finalize) :
 657         unref the tree model.
 658         (on_button_edit): Show the edit window.
 659
 660 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 661
 662         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 663         error for me.
 664
 665         * src/maemo/Makefile.am:
 666         * src/maemo/modest-connection-specific-smtp-window.c:
 667         * src/maemo/modest-connection-specific-smtp-window.h:
 668         New window for showing the list of connections, for connection-specific
 669         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 670         * src/maemo/easysetup/modest-easysetup-wizard.c:
 671         (create_page_custom_outgoing): Show the new window when the button is clicked.
 672
 673 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 674
 675         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 676         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 677         * src/maemo/modest-msg-edit-window.c:
 678         (modest_msg_edit_window_insert_image):
 679         * src/modest-conf.c: (modest_conf_key_escape):
 680         * src/modest-mail-operation.c:
 681         (modest_mail_operation_send_new_mail):
 682         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 683         (modest_ui_actions_on_new_account):
 684         * src/widgets/modest-attachment-view.c: (update_filename_request):
 685         * src/widgets/modest-mail-header-view.c:
 686         Corrected warnings that were breaking the build, by commenting out unused variables,
 687         and a function, and by including a header.
 688
 689 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 690
 691         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 692         so we can #ifdef around platform-specific code when necessary.
 693         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 694         to allow this to build for the GNOME platform too.
 695
 696 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 697
 698         * src/maemo/easysetup/modest-easysetup-wizard.c:
 699         Added util_increment_name() and used it in create_page_account_details()
 700         to make sure that the default account name is always a new name.
 701
 702         (modest_easysetup_wizard_dialog_init),
 703         (set_default_custom_servernames): Some minor memory management fixes.
 704
 705 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 706
 707         * Makefile.am:
 708         * configure.ac:
 709         * src/modest-runtime.c: (init_i18n): Restored the translation
 710         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 711         are defined in config.h, and the translations are installed.
 712
 713         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 714         is defined for translation.
 715
 716 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 717
 718         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 719         (load_from_file):
 720         * src/maemo/easysetup/modest-easysetup-wizard.c:
 721         (modest_easysetup_wizard_dialog_init):
 722         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 723         Use realistic paths (though they should use $prefix generically) to the
 724         mcc_mapping and provider-data.keyfile files which might work when they
 725         are installed by the future version of the operator-wizard package,
 726         and then fallback to paths in our source code, with an explanatory
 727         warning.
 728
 729 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 730
 731         * configure.ac:
 732         * src/Makefile.am:
 733         * src/maemo/Makefile.am:
 734         * src/maemo/easysetup/: Added files from the previously-exernal
 735         osso-modest-easysetup.
 736         * src/maemo/modest-main-window-ui.h:
 737         * src/modest-ui-actions.c:
 738         * src/modest-ui-actions.h:
 739         Added modest_ui_actions_on_new_account() as a signal handler for the
 740         New Account menu item. It shows the easysetup wizard.
 741         * po/en_GB.po: Added additional needed logical IDs and translations.
 742
 743 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 744 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 745