1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
4 Set the leave-on-server conf key by default. This fixes
5 projects.maemo.org bug NB#59258 .
7 2007-06-01 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/modest-account-view-window.c:
10 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
11 logical ID for the confirmation messages. Fixed projects.maemo.org bug
14 2007-06-01 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/easysetup/modest-easysetup-wizard.c:
17 (create_caption_new_with_asterisk):
18 * src/maemo/modest-account-settings-dialog.c:
19 (create_caption_new_with_asterisk):
20 Uncomment the code to add the asterisk, because they are no longer in the
21 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
22 (update_incoming_server_title): Add an asterisk here too.
24 2007-06-01 Murray Cumming <murrayc@murrayc.com>
26 * src/maemo/modest-maemo-global-settings-dialog.c:
27 (current_connection): Check that we are even connected before trying to
28 get the current connection name, to prevent a warning.
30 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
31 Change the comments because tny_maemo_conic_device_connect() is now meant to
33 * src/modest-mail-operation.c:
34 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
35 make sure we have a connection and fail if we can't connect.
37 2007-05-31 Murray Cumming <murrayc@murrayc.com>
39 * src/maemo/modest-main-window.c:
40 (on_account_store_connecting_finished): Do not try to get the
41 connection ID if we are not really connected. I am surprised that
42 this signal handler is called when we are not connected.
44 2007-05-31 Murray Cumming <murrayc@murrayc.com>
47 * src/modest-ui-actions.c:
48 (modest_ui_actions_get_msgs_full_error_handler):
49 Renamed an enum, added comments, added an enum
50 for retrieve-limit errors.
52 * src/modest-mail-operation.c: (foreach_add_item),
53 (internal_folder_observer_update), (update_account_thread),
54 (modest_mail_operation_get_msgs_full):
55 (modest_mail_operation_update_account),
56 Added comments about how this works, and some code that should
57 (but does not) check the retrieve-limit. See the TODO comment.
59 2007-05-31 Murray Cumming <murrayc@murrayc.com>
61 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
62 Initialize help_id to fix the build. Warnings are good.
64 2007-05-31 Murray Cumming <murrayc@murrayc.com>
66 * src/widgets/modest-hbox-cell-renderer.c:
67 (modest_hbox_cell_renderer_append):
68 * src/widgets/modest-vbox-cell-renderer.c:
69 (modest_vbox_cell_renderer_append):
70 Fix the last commit by doing an extra ref.
72 2007-05-31 Murray Cumming <murrayc@murrayc.com>
74 * src/widgets/modest-hbox-cell-renderer.c:
75 (modest_hbox_cell_renderer_append):
76 * src/widgets/modest-vbox-cell-renderer.c:
77 (modest_vbox_cell_renderer_append):
78 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
79 to fix the build with Maemo Bora.
80 However, there seems to be a remaining crash, probably due to reference
83 2007-05-30 Murray Cumming <murrayc@murrayc.com>
85 * src/modest-tny-account.c:
86 (modest_tny_account_new_for_local_folders):
87 Use hildon_file_system_info_async_new() to get a better name for
88 the memory card account, setting it as the account name.
89 The timing seems to work, but this is probably
90 not the best place to do this. See the TODO comment.
91 * src/maemo/modest-main-window.c: (create_details_widget):
92 * src/widgets/modest-folder-view.c: (text_cell_data):
93 Use the tny account name instead of hardcoding a name.
95 2007-05-30 Christian Kellner <ckellner@openismus.com>
97 * src/modest-search.c: (modest_search):
98 Correctly set part_search_func even if we have already parsed
99 the query and thus a valid OgsTextSearcher object.
101 2007-05-30 Christian Kellner <ckellner@openismus.com>
104 Search and check for libogs.
107 Incooparte the ogs build env.
109 * src/modest-mime-part-search-stream.c:
110 * src/modest-mime-part-search-stream.h:
111 Removed since we do the real searching now in modest-search.c.
113 * src/modest-search.c:
114 * src/modest-search.h:
115 Implement support for ogs. We use that if available and requested
116 and fall back to modest_text_utils_utf8_strcmp (). The search logic
117 should now handle the corner case when the search term is spread
118 across multiple reads.
119 Also the logic in modest_search () was corrected to search all
120 requested fields until one is found.
122 2007-05-30 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
127 * src/modest-init.c: Made modest_init_local_folders() take a
128 path and be public so we can iniitialize maildir folders on
131 * src/modest-local-folder-info.h:
132 * src/modest-local-folder-info.c:
133 (modest_local_folder_info_get_maildir_path): Add a path parameter.
135 * src/modest-tny-account.c:
136 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
137 still means the standard local-folders path on the local volume.
139 * src/modest-tny-account-store.c:
140 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
141 signal so we can detect mount/unmount of the MMC1 card, and do an update of
142 all accounts when that happens.
143 (get_server_accounts): If the MMC1 card is mounted, create a store account for
144 this too, so it shows up in the treeview.
146 2007-05-28 Murray Cumming <murrayc@murrayc.com>
148 * src/maemo/modest-maemo-global-settings-dialog.c:
149 (current_connection):
150 * src/widgets/modest-global-settings-dialog.c:
151 (current_connection_default):
152 Use the enum values instead of 0, 1 and -1,
153 to make the code clearer.
155 * src/modest-account-mgr-helpers.c:
156 (modest_account_mgr_get_connection_specific_smtp): Make this code
159 * src/modest-runtime.h:
160 * src/modest-runtime.c:
161 Added modest_runtime_remove_all_send_queues().
162 * src/maemo/modest-main-window.c:
163 (on_account_store_connecting_finished): Recreate the send queues,
164 using the appropriate transport accounts for this new connection.
165 Some futher adapting might be needed if the old send queues are not
166 automatically stopped at this point.
168 * src/modest-tny-account-store.c: (get_server_accounts):
169 Create the connection-specific transport accounts, so that they can
170 be found later by their ID.
172 * src/modest-tny-account.h:
173 * src/modest-tny-account.c:
174 Added modest_tny_account_new_from_server_account_name().
175 modest_tny_account_new_from_server_account(): Do not create the
176 send queues here, because they will be
177 recreated anyway when the connection changes for the first time.
179 2007-05-28 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-local-folder-info.h:
182 * src/modest-local-folder-info.c:
183 (modest_per_account_local_outbox_folder_info_get_maildir_path),
184 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
185 tbox_folder): Take a modest account name instead of a server TnyAccount,
186 so we can have per-modest-account rather than per-transport-account
188 We must make sure that we change or recreate the exisitng send queues
189 when the connection changes for connection-specific transport accounts.
191 * src/modest-tny-account-store.c:
192 (create_per_account_local_outbox_folders): Create outboxed per modest
193 account, not per transport account.
195 * src/modest-tny-account.h:
196 * src/modest-tny-account.c:
197 (modest_tny_account_get_special_folder): For outboxes, get the
198 parent modest account name. The account is ignored for other folders.
199 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
200 modest account name rather than a server TnyAccount.
202 2007-05-25 Murray Cumming <murrayc@murrayc.com>
204 * src/modest-tny-account.c:
205 (modest_tny_account_new_from_server_account):
206 Call modest_runtime_get_send_queue() immediately after creating transport
207 accounts, so that they start trying to send email from the outbox as soon
208 as possible at startup. This is probably what we want.
210 * src/modest-mail-operation.c: (update_account_thread):
211 * src/modest-runtime.c: (modest_runtime_get_send_queue):
212 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
213 * src/modest-tny-send-queue.h:
214 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
215 (modest_ui_actions_on_send):
216 Added comments about how sending works, though it needs some more work.
218 2007-05-25 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-tny-account.c:
221 (modest_tny_account_get_special_folder): Add TODO because this fails when
223 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
224 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
225 Do not try to show this window when there is no active account. The UI
226 specs does not tell us what to do in this case.
228 2007-05-24 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/Makefile.am:
233 * src/widgets/Makefile.am: Some dist fixes.
235 2007-05-24 Murray Cumming <murrayc@murrayc.com>
237 * src/maemo/modest-connection-specific-smtp-window.c:
238 (on_button_edit): Make the code clearer, to prevent a double free.
240 2007-05-24 Murray Cumming <murrayc@murrayc.com>
242 * src/maemo/modest-account-settings-dialog.c:
243 (modest_account_settings_dialog_set_account_name),
244 Check the connection-specific smtp servers checkbox if there are any.
246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
247 (modest_connection_specific_smtp_edit_window_init):
248 Start with a suitable port number.
250 * src/modest-account-mgr-helpers.h:
251 * src/modest-account-mgr-helpers.c: Added
252 modest_account_mgr_get_has_connection_specific_smtp().
254 (modest_account_mgr_set_connection_specific_smtp),
255 (modest_account_mgr_remove_connection_specific_smtp),
256 (modest_account_mgr_get_has_connection_specific_smtp),
257 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
258 connection-specific smtp server accounts in the account, rather than
259 the server account conf dir.
261 This fixes bug projects.maemo.org bug NB#58263 .
263 * src/modest-tny-account-store.c:
264 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
265 if there are no server accounts yet, to prevent an infinite loop when there
266 are no accounts. Document that one must be called before the other.
268 2007-05-24 Murray Cumming <murrayc@murrayc.com>
270 * src/modest-account-mgr-helpers.c:
271 (modest_account_mgr_get_default_account): Make sure that at least
272 one account is always the default, if there are any enabled accounts.
273 This is just a sanity check that shouldn't be necessary.
275 * src/modest-account-mgr-priv.c:
276 (_modest_account_mgr_account_from_key): Unescape the conf key to
277 get the real account name. For instance, this is an issue if a space
278 was in the account name, which can happen because the account name
279 is generated from the display name.
280 (_modest_account_mgr_get_account_keyname): Always escape the
282 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
283 Unescape the conf keys to get the real account names.
285 For instance, previously the is-default radio button in the accounts
286 list was not checked for any accounts at first. This fixes that,
287 and might fix several similar bugs.
289 2007-05-23 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
292 Removed some debug printfs.
294 2007-05-23 Murray Cumming <murrayc@murrayc.com>
296 Modest on-disk outbox directories are now here, for instance:
297 $HOME/.modest/outboxes/<account-id-1>/outbox
298 $HOME/.modest/outboxes/<account-id-2>/outbox
300 $HOME/.modest/local-folders/outbox
301 so we can have a separate outbox for each account.
302 But they are shown as one outbox in the GtkTreeView, by using a
303 TnyMergeFolder in a ModestTnySimpleFolderStore.
306 * src/modest-tny-simple-folder-store.c:
307 * src/modest-tny-simple-folder-store.h:
308 Added ModestTnySimpleFolderStore, used to contain folders from
309 other folder stores, such as other accounts.
311 * src/modest-tny-outbox-account.h:
312 * src/modest-tny-outbox-account.c:
313 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
314 used for the per-account local outbox folders.
316 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
317 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
318 only use this (internally) now for the non-outbox local folders.
321 * src/modest-init.c: Added modest_init_one_local_folder(), for
322 setting up the directory structure for each local folder.
324 * src/modest-local-folder-info.c:
325 (modest_per_account_local_outbox_folder_info_get_maildir_path),
326 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
328 * src/modest-local-folder-info.h:
329 * src/modest-tny-account-store.c: (on_account_removed),
330 (on_account_changed), (create_per_account_local_outbox_folders),
331 (get_server_accounts), (modest_tny_account_store_get_accounts),
332 (modest_tny_account_store_get_tny_account_by_account),
333 (modest_tny_folder_store_is_virtual_local_folders):
335 * src/modest-tny-account.h:
336 * src/modest-tny-account.c:
337 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
338 to create an on-disk per-account local outbox folder for each
340 (create_per_account_local_outbox_folders): Create a local outbox folder
341 for each transport account.
342 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
343 for all local folders.
345 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
346 instead of using g_object_get/set() directly. It is clearer.
348 (modest_tny_folder_store_get_message_count),
349 (modest_tny_folder_store_get_local_size
350 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
351 because we now use these with non-acount folder stores.
353 (modest_tny_account_get_special_folder),
354 (modest_tny_account_new_from_server_account),
355 (modest_tny_account_new_from_account):
356 (recurse_folders): Adjust to the new outbox system.
358 * src/modest-tny-folder.h:
359 * src/modest-tny-folder.c:
360 (modest_tny_folder_is_local_folder),
361 (modest_tny_folder_get_local_folder_type),
362 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
364 * src/widgets/modest-main-window.h:
365 * src/maemo/modest-main-window.c: (create_details_widget),
366 (modest_main_window_set_contents_style): Show details for any folder store,
369 (modest_tny_folder_get_rules):
370 Remove the const. C does not support constness enough for this.
372 * src/modest-ui-actions.c:
373 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
374 make all outboxes appear as one, in the usual local-folders tree node.
376 (set_active_account_from_tny_account),
377 (modest_ui_actions_on_folder_selection_changed):
378 * src/widgets/modest-folder-view.c: (text_cell_data),
379 (icon_cell_data), (filter_row),
380 (add_account_folders_to_merged_folder),
381 (add_account_folders_to_simple_folder_store), (),
382 (get_cmp_rows_type_pos), (cmp_rows),
383 (modest_folder_view_set_account_id_of_visible_server_account):
384 Adjust to the new outbox system, using generic folder stores and folders
387 2007-05-23 Christian Kellner <ckellner@openismus.com>
389 * src/modest-mail-operation.c:
390 (modest_mail_operation_update_account):
391 Use info->max_size instead of unintialized local var [small
392 build fix]. (Added TODO to review that change since I don't
395 2007-05-23 Marcus Bauer <marcusb@openismus.com>
397 * libmodest-dbus-client/libmodest-dbus-client.c:
398 (libmodest_dbus_client_compose_mail): function added
399 * src/dbus_api/modest-dbus-api.h:
400 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
401 (on_compose_mail): Implementation of the SendAsMail functionality
403 2007-05-22 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-account-mgr.c:
406 (modest_account_mgr_add_server_account): Set the secure-connection
407 conf key for transport accounts as well as store accounts. I don't know
408 why the if was there. For instance, this makes sure that we use SSL
409 for the gmail preset from the easysetup wizard.
411 2007-05-22 Murray Cumming <murrayc@murrayc.com>
413 * src/gnome/modest-main-window.c:
414 (on_account_store_connecting_finished), (connect_signals):
415 * src/maemo/modest-main-window.c:
416 (on_account_store_connecting_finished), (connect_signals),
417 (modest_main_window_new):
418 Handle TnyAccountStore::connecting-finished instead of
419 TnyDevice::connection-changed, because we cannot actually perform
420 operations on accounts until TnyAccountStore has itself responded to
421 the TnyDevice::connection-changed signal. This prevents a GError from
423 Do not try to update at startup, because we (at least on scratchbox)
424 already do an update at startup when the device goes online.
425 This prevents a GError from tinymail.
426 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
427 Added TODO about stopping simultaneous operations.
429 2007-05-21 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
432 * src/modest-mail-operation-queue.c:
433 (modest_mail_operation_queue_remove):
434 * src/modest-tny-account-store.c: When GErrors happen, give more clues
435 about where they happened.
437 2007-05-21 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-ui-actions.c:
440 (modest_ui_actions_on_password_requested): Make sure that the remember
441 output parameter is always TRUE.
443 2007-05-21 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
446 Show a OK/Cancel dialog if the error is a question, though we still do not
447 know anything more about what we are asking the user.
448 * src/widgets/modest-folder-view.c: (on_drag_data_received):
449 Fix an uninitialized variable (helper). This is a logic error, however.
451 2007-05-21 Christian Kellner <ckellner@openismus.com>
453 * src/modest-search.h:
454 Correct bit shifting in the ModestSearchFlags enum.
456 2007-05-21 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-account.c:
459 (modest_tny_account_new_from_server_account): Do not use the lsub and
460 check-all hard-coded IMAP options when using POP.
462 2007-05-21 Murray Cumming <murrayc@murrayc.com>
464 * src/modest-tny-account.c:
465 (modest_tny_account_new_from_server_account):
466 Use NULL for the secure-auth method for POP when Password auth has been
467 specified by the user, as we already do for IMAP. "auth=Login" causes
468 an error from camel or the server.
470 2007-05-17 Murray Cumming <murrayc@murrayc.com>
472 * src/maemo/modest-account-settings-dialog.c:
473 (create_page_account_details),
474 (modest_account_settings_dialog_set_account_name):
475 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
476 for the leave-on-server checkbox, rathr than just the checkbox, when
477 the protocol is not POP.
479 2007-05-17 Murray Cumming <murrayc@murrayc.com>
481 * src/widgets/modest-account-view.c:
482 * src/widgets/modest-account-view.h:
483 Added modest_account_view_select_account() which will be useful later
484 to asynchronously re-select the edited account.
486 2007-05-17 Murray Cumming <murrayc@murrayc.com>
488 * src/maemo/modest-account-settings-dialog.c:
489 (modest_account_settings_dialog_set_account_name):
490 Automatically choose the port numbers based on the secure authentication
491 methods, if they have not been chosen before.
492 This fixes projects.maemo.org bug NB#56273 .
494 2007-05-17 Murray Cumming <murrayc@murrayc.com>
496 * src/maemo/modest-main-window-ui.h:
497 * src/modest-ui-actions.c:
498 * src/modest-ui-actions.h:
499 Connect the Tools/SMTP Servers menu item to
500 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
501 SMTP servers dialog, as in the UI specification and saves changes when it
502 is closed. This fixed projects.maemo.org bug NB#56305 .
504 2007-05-17 Murray Cumming <murrayc@murrayc.com>
506 * src/maemo/modest-connection-specific-smtp-window.c:
507 (modest_connection_specific_smtp_window_init):
508 Use gtk_window_set_default_size() to make this window big enough, so
509 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
511 2007-05-17 Murray Cumming <murrayc@murrayc.com>
513 * src/maemo/modest-connection-specific-smtp-edit-window.h:
514 * src/maemo/modest-connection-specific-smtp-edit-window.c:
515 (modest_connection_specific_smtp_edit_window_init),
516 Do not try to connect to a combobox signal before the combobox exists.
517 This fixes the cras in projects.maemo.org bug NB#56288 .
518 (modest_connection_specific_smtp_edit_window_get_settings):
519 Remove the server_account_name parameter which was being checked for NULL
520 though it was not used.
522 * src/maemo/modest-connection-specific-smtp-window.c:
523 (modest_connection_specific_smtp_window_fill_with_connections),
524 (on_button_edit), (modest_connection_specific_smtp_window_init):
525 Correct the number of treemodel columns to prevent a warning.
526 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
527 libconic does not work.
529 2007-05-16 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-tny-account.c:
532 (modest_tny_account_new_from_server_account):
533 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
534 SMTP when "None" was chosen by the user. However, with my SMTP server that
535 does not support ANONYMOUS, the emails do not leave the Outbox and I see
538 2007-05-16 Murray Cumming <murrayc@murrayc.com>
540 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
541 to explain the memory management issue with the ID in the ModestPair.
543 * src/gnome/modest-account-assistant.c: (add_receiving_page),
544 (add_sending_page), (modest_account_assistant_finalize):
545 * src/gnome/modest-gnome-global-settings-dialog.c:
546 (create_updating_page), (create_composing_page):
547 * src/gnome/modest-msg-edit-window.c: (get_transports),
548 (init_window), (modest_msg_edit_window_finalize),
549 (modest_msg_edit_window_get_msg_data):
550 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
551 * src/gnome/modest-transport-widget.c:
552 (modest_transport_widget_finalize), (smtp_configuration):
553 * src/maemo/modest-maemo-global-settings-dialog.c:
554 (create_updating_page), (create_composing_page):
555 * src/maemo/modest-msg-edit-window.c: (get_transports),
556 (init_window), (modest_msg_edit_window_finalize),
557 (modest_msg_edit_window_get_msg_data),
558 (modest_msg_edit_window_free_msg_data):
559 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
560 (modest_store_widget_finalize):
561 * src/maemo/modest-transport-widget.c:
562 (modest_transport_widget_finalize), (smtp_configuration):
563 * src/modest-main.c: (send_mail):
564 * src/widgets/modest-combo-box.h:
565 * src/widgets/modest-global-settings-dialog-priv.h:
566 * src/widgets/modest-global-settings-dialog.c:
567 (modest_global_settings_dialog_finalize):
568 * src/widgets/modest-msg-edit-window.h:
569 Whenever using modest_combo_box_new(), keep the ModestPairList alive
570 as long as the combo box, to prevent use of freed memory for the ID.
572 2007-05-15 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
575 get_accounts(), to make this clearer. Do not check for the enabled gconf
576 key, because we do not use this for server accounts (at least, not yet).
577 This allows us to send email again.
579 2007-05-15 Murray Cumming <murrayc@murrayc.com>
581 * src/maemo/modest-platform.c:
582 (on_modest_conf_update_interval_changed), (modest_platform_init):
583 Only respond to this particular key change. All these strcmp()s cannot be
586 2007-05-15 Murray Cumming <murrayc@murrayc.com>
588 * src/maemo/modest-maemo-global-settings-dialog.c:
589 (current_connection): Prevent a crash in scratchbox when
590 ny_maemo_conic_device_get_current_iap_id() returns NULL.
591 * src/maemo/modest-platform.c:
592 (on_modest_conf_update_interval_changed), (modest_platform_init):
593 Get the update interval from gconf and reset it when the gconf key changes.
595 2007-05-15 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-protocol-info.c:
598 * src/modest-protocol-info.h: Adde enum-specific get functions,
599 instead of using a ModestProtocolType enum parameter.
601 * src/gnome/modest-account-assistant.c:
602 * src/gnome/modest-store-widget.c:
603 * src/gnome/modest-store-widget.h:
604 * src/gnome/modest-transport-widget.c:
605 * src/gnome/modest-transport-widget.h:
606 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
607 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
608 * src/maemo/easysetup/modest-easysetup-wizard.c:
609 * src/maemo/modest-account-settings-dialog.c:
610 * src/maemo/modest-account-settings-dialog.h:
611 * src/maemo/modest-store-widget.c:
612 * src/maemo/modest-store-widget.h:
613 * src/maemo/modest-transport-widget.c:
614 * src/maemo/modest-transport-widget.h:
615 * src/modest-account-mgr-helpers.c:
616 * src/modest-account-mgr-helpers.h:
617 * src/modest-account-mgr.c:
618 * src/modest-account-mgr.h:
619 * src/modest-tny-account.c:
620 * src/modest-tny-folder.c:
621 * src/widgets/modest-account-view.c:
622 * src/widgets/modest-retrieve-combo-box.c:
623 * src/widgets/modest-retrieve-combo-box.h:
624 * src/widgets/modest-secureauth-combo-box.c:
625 * src/widgets/modest-serversecurity-combo-box.c:
626 * src/widgets/modest-serversecurity-combo-box.h:
627 * tests/check_account-mgr.c:
628 Use the specific functions, and use the re-renamed enum values for GNOME too.
630 2007-05-15 Murray Cumming <murrayc@murrayc.com>
633 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
634 so we can get the second based on the first.
636 * src/maemo/modest-account-settings-dialog.h:
637 * src/maemo/modest-account-settings-dialog.c:
638 Added get_supported_secure_authentication_methods(), though it is mostly
639 commented-out for now until the necessary API is committed to tinymail.
640 (modest_account_settings_dialog_set_account_name),
641 (save_configuration): Request the supported authentication methods from the
642 server, so we can choose a working method.
644 * src/modest-tny-account-store.h:
645 * src/modest-tny-account-store.c:
646 (modest_tny_account_store_get_session): Rename from
647 tny_account_store_get_session().
649 2007-05-14 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-protocol-info.h: Split the ModestProtocol enum
652 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
653 There was no need to have these unrelated values in one enum.
655 * src/: many files: Adapted to changed enum. This makes the code a bit
656 clearer, and the compiler could catch some errors.
658 2007-05-14 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
661 Show the detailed internal camel error message when an error happens
662 during the configuration, so that our testers can give us more clues.
663 For instance, in projects.maemo.org bug NB#56910 .
665 2007-05-14 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-tny-account.c:
668 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
669 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
671 2007-05-14 Murray Cumming <murrayc@murrayc.com>
673 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
674 * src/maemo/modest-account-settings-dialog.c:
675 (modest_account_settings_dialog_set_account_name),
676 (save_configuration): For the incoming secure authentication checkbox,
677 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
678 the UI specification. PLAIN does not seem to be supported for most IMAP
679 servers anyway, and I am not sure what it would mean.
680 However, we probably need to discover which of the secure-authentication
681 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
682 * src/modest-account-mgr-helpers.c:
683 (modest_account_mgr_get_server_account_data):
685 * src/modest-tny-account.c:
686 (modest_tny_account_new_from_server_account):
687 Use tny_account_set_mech() to set secure-authentication methods,
688 with some special-casing for IMAP, based on my observations of how
691 * src/modest-account-mgr-helpers.h:
692 * src/modest-account-mgr.c:
693 * src/modest-defs.h: Comment that the URI is only used for local folders.
695 2007-05-11 Murray Cumming <murrayc@murrayc.com>
697 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
698 parameter const, just to be neat.
699 * src/modest-text-utils.c: (modest_text_utils_inline):
700 End g_strconcat() with NULL, as its documentation says. This is almost
701 certainly the cause of my crash at startup on the device. Interestingly,
702 valgrind doesn't tell us about these errors.
704 2007-05-11 Murray Cumming <murrayc@murrayc.com>
706 * scripts/build-packages: Added more precise comments about how to use
707 this script, though I still get this error:
708 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
709 error building tinymail
711 2007-05-11 Murray Cumming <murrayc@murrayc.com>
713 * src/maemo/modest-main-window.c: (on_account_update):
714 Very slight cleanup, hoping to make it simpler to discover what causes
715 a crash here sometimes.
717 * src/modest-tny-account.c:
718 (modest_tny_account_new_from_server_account): Set the port. Added
719 comments about the options and a TODO comment because I need to find out
720 how to specify the secure authentication method.
722 2007-05-11 Marcus Bauer <marcusb@openismus.com>
724 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
725 changed CFlags paths form modest to libmodest
727 2007-05-10 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-account-mgr-helpers.c:
730 (modest_account_mgr_get_server_account_data),
731 (modest_account_mgr_free_server_account_data):
732 * src/modest-account-mgr-helpers.h:
733 * src/modest-account-mgr.c:
734 (modest_account_mgr_add_server_account):
736 * src/modest-tny-account.c:
737 (modest_tny_account_new_from_server_account):
738 Determine the options for tny_camel_account_add_option() here,
739 based on the settings, rather than storing them directly in gconf.
741 2007-05-10 Murray Cumming <murrayc@murrayc.com>
743 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
744 Show a more friendly error dialog now that we expect (from the tinymail
745 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
747 2007-05-10 Murray Cumming <murrayc@murrayc.com>
749 * src/maemo/modest-main-window.c: (on_account_update): Check that
750 account_name is not NULL, to prevent a crash at startup that I am
751 seeing on the N800. I do wonder why it is NULL.
753 * src/maemo/easysetup/modest-easysetup-wizard.c:
754 (create_page_user_details):
755 * src/maemo/modest-account-settings-dialog.c:
756 (create_page_user_details), (create_page_outgoing):
757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
758 (modest_connection_specific_smtp_edit_window_init):
759 * src/modest-ui-actions.c:
760 (modest_ui_actions_on_password_requested):
761 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
762 might do something useful with the on-screen keyboard.
764 2007-05-10 Murray Cumming <murrayc@murrayc.com>
766 * src/maemo/modest-main-window.c: (on_account_update):
767 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
768 NULL, to avoid lots of warnings. However, it probably should not be NULL.
770 2007-05-09 Murray Cumming <murrayc@murrayc.com>
772 * src/modest-tny-account-store.c: (on_account_changed):
773 Correct the signature of this signal handler.
775 2007-05-09 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
778 Show a HildonNote instead of a GtkDialog for Maemo.
780 2007-05-09 Murray Cumming <murrayc@murrayc.com>
782 * src/widgets/modest-account-view.h:
783 * src/widgets/modest-account-view.c: (on_account_changed),
784 (on_account_removed). Added a boolean flag, set/unset by
785 modest_account_view_block_conf_updates(),
786 modest_account_view_unblock_conf_updates() to prevent unnecessary
787 updates, but this is not very useful because the gconf notifications are
788 so delays (maybe only on Maemo Bora).
789 So auto-updating is turned off, and these functions do an explicit
790 update when necessary.
791 However, something else is still doing too much work when adding/removing
792 accounts, probably in another part of the application.
794 * src/maemo/modest-account-view-window.c:
795 (on_delete_button_clicked), (on_edit_button_clicked),
796 (on_new_button_clicked): Use the new functions.
798 2007-05-09 Murray Cumming <murrayc@murrayc.com>
800 * src/modest-account-mgr-helpers.c:
801 (modest_account_mgr_set_first_account_as_default):
802 Sort the list of names alphabetically-by-title, so we choose the first one
804 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
805 alphabetically by the title.
807 This fixes projects.maemo.org bug NB#56418 .
809 * src/modest-account-mgr-priv.c:
810 (_modest_account_mgr_account_from_key):
811 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
812 avoid a valgrind error, and possible random behaviour.
814 2007-05-09 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
817 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
818 tinymail documentation to say that this can be expected.
819 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
820 pretty, and should not happen, but I would prefer to know when it does.
822 2007-05-09 Murray Cumming <murrayc@murrayc.com>
824 * configure.ac: When using the older hildon version, probably on Bora,
825 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
827 * src/widgets/modest-attachment-view.c:
828 (modest_attachment_view_set_part_default): Initialize variables, to fix the
831 2007-05-09 Marcus Bauer <marcusb@openismus.com>
833 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
834 Implemented the prototype. Can be tested with
835 tests/dbus_api/test_open_message:
837 2007-05-08 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-tny-account-store.c:
840 (modest_tny_account_store_instance_init), (get_password):
841 * src/modest-ui-actions.c:
842 (modest_ui_actions_on_password_requested):
843 Do not store the password in gconf, because this function is called
844 for non-remembered passwords. Actually use the cached (in the hash map)
845 password instead of releasing it.
846 The password will now not be remembered if it is asked via the protected
847 password dialog, as per the UI spec.
849 2007-05-08 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-account-mgr-helpers.h:
853 * src/modest-account-mgr-helpers.c:
854 Added modest_server_account_get_username_has_succeeded(),
855 modest_server_account_set_username_has_succeeded().
856 (modest_server_account_set_username),
857 Reset the has-succeeded flag if the username changes.
859 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
860 * src/maemo/modest-connection-specific-smtp-window.c:
861 (modest_connection_specific_smtp_window_save_server_accounts):
862 Use modest_server_account_set_username() instead of using
863 modest_conf_set_string() directly, so that the has-succeeded flag is always
866 * src/modest-ui-actions.c:
867 (modest_ui_actions_on_password_requested): Dim the username entry if
868 the username has ever worked, as per the UI spec.
870 2007-05-08 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-tny-account-store.c: (get_password):
873 * src/modest-ui-actions.c:
874 (modest_ui_actions_on_password_requested):
875 Allow the username to be changed too, though there is more work to
876 be done on exactly how this behaves.
878 2007-05-08 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-account-mgr-helpers.h:
881 * src/modest-account-mgr-helpers.c:
882 Added modest_account_mgr_get_display_name(),
883 modest_server_account_get_username(),
884 modest_server_account_set_username(),
885 modest_server_account_set_password(),
886 modest_server_account_get_hostname() functions so we do not need to
887 use the conf API directly.
889 * src/maemo/modest-main-window.c: (connect_signals):
890 Actually connect ot the ModestAccountStore::request-password signal,
891 so that we show the dialog when the password is requested by Tinymail,
892 for isntance if it is empty.
894 * src/modest-marshal.list:
895 * src/modest-tny-account-store.c:
896 (modest_tny_account_store_class_init), (get_password),
897 (modest_tny_account_store_alert):
898 * src/modest-tny-account-store.h:
899 * src/modest-ui-actions.h:
900 * src/modest-ui-actions.c:
901 (modest_ui_actions_on_password_requested):
902 Change the signal parameters, so it is obvious that we are providing
903 the non human-readable server name, and receiving both the username
904 and password, though changing of the username is not yet implemented.
905 Change the dialog UI to match the Maemo UI specifications, with #idfefing
906 for the GNOME version.
908 This should fix the projects.maemo.org bug NB#56209, though it does not
909 work on Bora, because the gconf_client_get() for the password fails
910 immediately after we save it with gconf_client_set().
912 2007-05-08 Murray Cumming <murrayc@murrayc.com>
915 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
916 caused an undefined symbol error:
917 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
919 2007-05-08 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-tny-account-store.c:
922 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
923 using a GError instead of a string message, so we can translate it in
926 2007-05-08 Murray Cumming <murrayc@murrayc.com>
928 * src/maemo/modest-address-book.c:
929 (modest_address_book_check_names):
930 * src/maemo/modest-msg-view-window.c:
931 (modest_msg_view_window_clipboard_owner_change):
932 * src/modest-init.c: (modest_init_init_ui):
933 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
934 (update_folders_cb), (modest_mail_operation_update_account):
935 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
936 (modest_ui_actions_on_msg_attachment_clicked),
937 (modest_ui_actions_on_msg_recpt_activated):
938 * src/widgets/modest-header-view.c: (drag_data_get_cb):
939 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
940 (modest_msg_view_search_next):
941 * src/widgets/modest-recpt-editor.c:
942 (modest_recpt_editor_on_button_release_event),
943 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
944 g_message(). At this point we should only be seeing interesting errors on
945 stdout. Debugging messages could be #ifdefed-out if they are still useful.
947 2007-05-07 Murray Cumming <murrayc@murrayc.com>
949 (modest_wizard_dialog_force_title_update):
950 * src/maemo/easysetup/modest-wizard-dialog.h:
951 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
952 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
953 can update the title when appropriate. Otherwise the title is wrong if the
954 pages are added after adding the notebook to the dialog.
955 This must be a problem in HildonWizardDialog too.
956 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
958 * src/maemo/easysetup/modest-easysetup-wizard.c:
959 (create_subsequent_customsetup_pages),
960 (create_subsequent_easysetup_pages):
961 Call modest_wizard_dialog_force_title_update() so that the title is
962 correct even with GTK+ < 2.10.
963 This fixes projects.maemo.org bug NB#56145 .
965 2007-05-07 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/modest-platform.c:
968 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
969 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
972 2007-05-07 Murray Cumming <murrayc@murrayc.com>
974 * src/widgets/modest-window.h:
975 * src/widgets/modest-window.c: Added a save_state_func vfunc,
976 and modest_window_save_state(), which invokes it.
978 * src/widgets/modest-window-mgr.h:
979 * src/widgets/modest-window-mgr.c:
980 Added modest_window_mgr_save_state_for_all_windows(), which calls
981 the save_state vfunc on all registered windows, if implemented.
983 * src/gnome/modest-msg-edit-window.c:
984 * src/gnome/modest-msg-view-window.c:
985 * src/maemo/modest-msg-edit-window.c:
986 * src/maemo/modest-msg-view-window.c:
987 * src/maemo/modest-main-window.c:
988 Specify the existing save_settings functions as implementations of
989 ModestWindow::save_state_func().
991 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
992 Call modest_window_mgr_save_state_for_all_windows(). This happens before
993 enabling hibernation, for instance.
995 We may need to do the same thing for restoring settings.
998 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1000 * src/widgets/modest-window-mgr.c:
1001 * src/widgets/modest-window-mgr.h:
1002 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1003 modest_window_mgr_get_hibernation_is_prevented().
1005 * src/maemo/modest-main-window.c:
1006 (on_hildon_program_is_topmost_notify): Prevent hibernation
1007 (possible when the application goes to the background in the WM),
1008 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1010 * src/maemo/easysetup/modest-easysetup-wizard.c:
1011 (modest_easysetup_wizard_dialog_init):
1012 * src/maemo/modest-account-settings-dialog.c:
1013 (modest_account_settings_dialog_init):
1014 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1015 (modest_connection_specific_smtp_edit_window_init):
1016 * src/maemo/modest-connection-specific-smtp-window.c:
1017 (modest_connection_specific_smtp_window_init):
1018 * src/maemo/modest-signature-editor-dialog.c:
1019 (modest_signature_editor_dialog_init):
1020 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1021 prevent hibernation while any of these account settings dialogs are open.
1023 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1025 * src/maemo/Makefile.am:
1026 * src/maemo/modest-osso-state-saving.c:
1027 * src/maemo/modest-osso-state-saving.h: Added
1028 modest_osso_load_state() and modest_osso_save_state() though they do
1029 nothing now. They should iterate through all the open windows and load/save
1031 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1032 save state when closing.
1034 * src/maemo/modest-main-window.c:
1035 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1036 Add a notification handler for the HildonProgram::is-topmost property,
1037 so we can allow hibernation when the application goes into the background.
1038 But we still need to detect when the accounts setup windows are open so
1039 we can stop hibernation when they are open.
1040 To do this, I also added the main window the HildonProgram. This might have
1041 other side-effects/benefits, and should maybe be done for other windows.
1043 * src/maemo/modest-osso-autosave-callbacks.h:
1044 * src/maemo/modest-osso-autosave-callbacks.c:
1045 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1046 though it does not do anything yet, and we might never need this to do
1047 anything. For instance, we already save drafts.
1049 * src/maemo/modest-platform.c: (modest_platform_init):
1050 Specify the libosso auto-save callback.
1052 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1054 * src/maemo/modest-platform.c:
1055 (modest_platform_set_update_interval):
1056 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1057 aparently stays valid between application instances, so we can use this
1058 to remove and reset it later. According to a maemo-developers email from
1061 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1063 * configure.ac: Depend on libalarm for Maemo.
1065 * src/dbus_api/modest-dbus-api.h:
1066 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1067 (on_send_receive), (modest_dbus_req_handler):
1068 Handle a SEND_RECEIVE D-Bus method.
1070 * libmodest-dbus-client/libmodest-dbus-client.c:
1071 (libmodest_dbus_client_send_and_receive):
1072 * libmodest-dbus-client/libmodest-dbus-client.h:
1073 Add C convenience functions for calling the new D-Bus method.
1075 * src/modest-platform.h:
1076 * src/gnome/modest-platform.c:
1077 * src/maemo/modest-platform.c:
1078 Added modest_platform_set_update_interval(), which uses the
1079 alarmd API on Maemo.
1080 (modest_platform_init),
1081 Call modest_platform_set_update_interval(), using a hard-coded
1082 interval for now (until the global settings dialog is implemented),
1083 though I am not sure that this makes sense yet.
1085 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1087 * src/dbus_api/modest-dbus-callbacks.c:
1088 (modest_osso_cb_hw_state_handler):
1089 * src/dbus_api/modest-dbus-callbacks.h:
1090 * src/maemo/modest-platform.c: (modest_platform_init):
1091 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1092 in case this has some effect on the ability for Maemo to ping the
1095 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1098 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1099 warning. It is probably a logic error, but I need to fix the build.
1101 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1103 * src/modest-account-mgr.h:
1104 * src/modest-account-mgr.c:
1105 (modest_account_mgr_account_names): Add a gboolean enabled_only
1106 parameter, so we can get lists of onlt the enabled accounts.
1108 (modest_account_mgr_add_account),,
1109 (modest_account_mgr_account_with_display_name_exists):
1110 * src/maemo/modest-msg-edit-window.c: (get_transports):
1111 * src/modest-account-mgr-helpers.c:
1112 (modest_account_mgr_set_first_account_as_default):
1113 * src/modest-init.c: (init_default_account_maybe):
1114 * src/modest-tny-account-store.c: (get_accounts):
1115 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1116 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1117 * tests/check_account-mgr.c: (START_TEST):
1118 Provide the extra parameter, as appropriate.
1120 * src/widgets/modest-account-view.c: (update_account_view):
1121 Do not show disabled accounts (meaning that there is no way to
1122 enable/disable accounts in the UI (the feature is not in our UI
1123 specification), so we can use this internally only to mark unfinished
1124 or temporary account data.
1126 * src/maemo/easysetup/modest-easysetup-wizard.c:
1127 (create_account): Add boolean enable parameter, so we can specify FALSE
1128 to create the temporary account.
1129 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1130 (on_before_next): When finishing, when there is a temporary account, just
1132 Also, use a timeout to delay the showing of the dialog until gconf is likely
1133 to return correct information, due to a maemo gconf bug that is fixed in
1134 osso 1.1, but not yet in Bora.
1135 However, the dialog stays on screen after it is destroyed.
1137 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1138 for invalid data when cancelling. Use a hildon note instead of a dialog
1139 to complain about invalid data. Do not show the account-saved note if the
1140 account is disabled (a temporary account that will not really be saved for use
1143 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1145 * src/modest-account-mgr-helpers.h:
1146 * src/modest-account-mgr-helpers.c:
1147 Added modest_account_mgr_unset_default_account(),
1148 Added modest_account_mgr_set_first_account_as_default().
1150 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1151 If it was the default account, unset the default account name.
1153 * src/maemo/modest-account-view-window.c:
1154 (on_delete_button_clicked): If it was the default account,
1155 set the first remaining account as the default instead.
1157 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1158 a NULL account or a NULL default account, to prevent a crash. This should
1159 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1162 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1164 * src/widgets/modest-recpt-editor.c:
1165 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1166 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1167 TODO comment for this. This fixes the build.
1169 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1170 be the best place for it. This will in future update all auto-update accounts,
1171 rather than just the current/default account, when that gconf key exists.
1172 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1173 if there are no accounts, before calling do_send_receive().
1174 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1176 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1177 * src/maemo/modest-main-window-ui.h:
1178 * src/maemo/modest-main-window.c: (on_connection_changed),
1179 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1180 directly, becaue the signal handler does more.
1182 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1184 * src/modest-account-mgr-helpers.c:
1185 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1186 for the case that the account does not exist.
1188 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1189 (equivalent to the modest account name) rather than the tinymail account name
1190 (equivalent to the modest account title - human readable) to get the account data.
1191 Check for null account data to prevent the crash, and add a TODO comment saying that
1192 this needs fixing because it is using the server account name instead of the account name.
1194 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1196 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1197 * src/maemo/modest-account-settings-dialog.c: (show_error),
1199 Use hildon_note_new_information() for informative and error messages,
1200 which seems to be expected for Maemo applications (no documentation that I know of
1201 says this). I am surprised that there is no distinction between info and error
1204 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1206 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1207 it is easy to find where this is used.
1209 * src/maemo/easysetup/modest-easysetup-wizard.c:
1210 (create_page_welcome), (create_page_account_details),
1211 (create_page_user_details), (create_page_complete_easysetup),
1212 (create_page_custom_incoming), (create_page_custom_outgoing),
1213 (create_page_complete_custom):
1214 * src/maemo/modest-account-settings-dialog.c:
1215 (create_page_account_details), (create_page_user_details),
1216 (create_page_incoming), (create_page_outgoing):
1217 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1218 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1219 (modest_connection_specific_smtp_edit_window_init):
1220 * src/maemo/modest-connection-specific-smtp-window.c:
1221 (modest_connection_specific_smtp_window_init):
1222 * src/maemo/modest-signature-editor-dialog.c:
1223 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1224 and scrolling policy as per the Email Application Layout Guide, if I have
1227 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1230 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1231 which were empty, because these vfuncs have been removed from TnyAccountStore.
1232 This fixes the build.
1234 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1236 * src/maemo/modest-main-window.c:
1237 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1238 showing/hiding it. Added TODO because it probably should not be NULL.
1239 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1240 because unnecessary g_warnings() make degugging difficult.
1242 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1244 * src/maemo/modest-msg-edit-window.c:
1245 (modest_msg_edit_window_select_color),
1246 (modest_msg_edit_window_select_background_color): 2 const corrections and
1247 moving 2 #endifs before closing brackets, to fix the build.
1249 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/easysetup/modest-easysetup-wizard.h:
1252 * src/maemo/easysetup/modest-easysetup-wizard.c:
1253 (modest_easysetup_wizard_dialog_finalize),
1254 (on_button_edit_advanced_settings), (create_page_complete_custom),
1255 (on_response), (create_account):
1256 Implement the Advanced Settings edit button, by saving the account information,
1257 for the Advanded Settings dialog to use directly from gconf, and removing it
1258 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1259 Bug #5533 in the projects.maemo.org bugzilla.
1261 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/modest-msg-view-window.c:
1264 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1265 when opening a message window.
1267 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1269 * src/maemo/easysetup/modest-easysetup-wizard.c:
1270 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1273 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1274 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1275 gconf settings. I probably added more checks than necessary, but that is safer.
1277 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1278 variable to fix the build, but this seems to be used when it is still NULL.
1280 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1282 * src/modest-platform.h:
1283 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1284 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1285 * src/modest-main.c: Implement this function so we can avoid using
1286 maemo-specific API from cross-platform code.
1288 * src/modest-tny-account-store.c:
1289 (get_smtp_specific_transport_account_for_open_connection):
1290 * src/modest-ui-actions.c: (check_for_connection),
1291 (modest_ui_actions_on_item_not_found):
1292 Use modest_platform_connect_and_wait() and put #idefs around other
1293 maemo-specific code, because only maemo currently has a way to
1294 identify connection names.
1296 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1298 * src/modest-tny-account-store.h:
1299 * src/modest-tny-account-store.c:
1300 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1301 the connection-specific SMTP server settings in the configuration.
1303 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1305 * src/maemo/modest-main-window.c: (on_connection_changed),
1307 * src/modest-main.c: (main), (start_ui), (send_mail):
1308 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1309 that is what is intended.
1311 * src/modest-ui-actions.c: (action_send), (action_receive),
1312 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1313 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1314 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1315 SMTP server is used when it is specified.
1317 (modest_ui_actions_on_send_receive):
1318 Check that a connection is open before proceeding.
1319 Receive and then send, instead of vice-versa, as per the specification.
1321 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1323 * src/modest-mail-operation.c:
1324 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1325 though I guess it should be something other than NULL.
1327 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1329 * src/maemo/easysetup/modest-easysetup-wizard.c:
1330 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1331 combo twice, to avoid an g_warning and to make it visible again.
1332 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1333 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1334 (already intended) dereference when detaching, because we then recreate the menu.
1335 But I am not sure why the warning was happening, and it is possible that this is a memory
1338 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1340 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1341 and uri_parse_mailto() utility functions.
1342 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1344 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1346 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1348 * src/dbus_api/modest-dbus-api.h:
1349 * src/dbus_api/modest-dbus-callbacks.c:
1350 Use an idle callback to execute the modest code in the application's own thread.
1351 Remove the helloworld example method.
1352 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1353 parsed, and the open-message method is not implemented because this is not yet implemented in
1355 * libmodest-dbus-client/libmodest-dbus-client.c:
1356 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1357 (libmodest_dbus_client_open_message):
1358 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1360 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1361 body without crashing.
1363 * tests/dbus_api/Makefile.am:
1364 * tests/dbus_api/test_mail_to.c:
1365 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1367 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1369 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1370 Added file to fix the build. Sorry.
1372 * src/dbus_api/Makefile.am:
1373 * src/dbus_api/modest-dbus-api.h:
1374 * src/dbus_api/modest-dbus-callbacks.h:
1375 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1376 (modest_dbus_req_handler):
1377 Put constants in a separate header so it can be reused by the
1378 client library, without duplication
1380 * libmodest-dbus-client/Makefile.am:
1381 * libmodest-dbus-client/libmodest-dbus-client.c:
1382 (libmodest_dbus_client_call_helloworld),
1383 (libmodfest_dbus_client_send_mail),
1384 (libmodfest_dbus_client_mailto),
1385 (libmodfest_dbus_client_open_message):
1386 * libmodest-dbus-client/libmodest-dbus-client.h:
1387 (Partly) Implement a send_mail D-Bus method.
1389 * tests/dbus_api/Makefile.am:
1390 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1391 the send_email D-Bus method.
1393 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1397 * libmodest-dbus-client/Makefile.am:
1398 * libmodest-dbus-client/libmodest-dbus-client.c:
1399 * libmodest-dbus-client/libmodest-dbus-client.h:
1400 * tests/dbus_api/Makefile.am:
1401 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1402 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1404 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1406 * src/maemo/easysetup/modest-easysetup-wizard.c:
1407 (create_page_account_details):
1408 * src/maemo/modest-account-settings-dialog.c:
1409 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1410 widgets, because this might not be the default in future versions of the Maemo GTK+.
1411 However, I can not not get capitalization to work even in a simple test case.
1413 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/easysetup/modest-easysetup-wizard.c:
1416 (create_page_custom_incoming), (create_page_custom_outgoing):
1417 * src/maemo/modest-account-settings-dialog.c:
1418 (create_page_account_details), (create_page_incoming),
1419 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1420 instead of using gtk_check_button_with_label(), so they are aligned like the other
1421 widgets, as per the UI spec.
1423 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-easysetup-wizard.c:
1426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1427 * src/widgets/modest-validating-entry.c:
1428 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1429 Modest prefix instead of an EasySetup prefix.
1431 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1433 * src/widgets/modest-validating-entry.h:
1434 * src/widgets/modest-validating-entry.c: (on_insert_text),
1435 Added easysetup_validating_entry_set_max_func(), used to set a callback
1436 to call when the max number of characters is reached. GtkEntry has a max-length
1437 already but is silent about it.
1439 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1440 (create_page_account_details), (create_page_user_details),
1442 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1443 (create_page_account_details), (create_page_user_details),
1444 (create_page_outgoing):
1445 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1446 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1447 the UI spec, when the user tries to enter more than the max number of characters.
1449 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/easysetup/modest-easysetup-wizard.c:
1452 (create_page_user_details), (create_page_custom_incoming),
1453 (create_page_custom_outgoing):
1454 * src/maemo/modest-account-settings-dialog.c:
1455 (create_page_user_details), (create_page_incoming),
1456 (create_page_outgoing):
1457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1458 (modest_connection_specific_smtp_edit_window_init):
1459 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1460 not appropriate. Bad Maemo-specific defaults!.
1462 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1464 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1465 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1466 (modest_signature_editor_dialog_set_settings):
1467 Disable the label and textview when the checkbox is disabled, and use the
1468 specified (UI spec) default signature text.
1470 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1473 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1475 * src/modest-defs.h:
1476 * src/modest-account-mgr-helpers.h:
1477 * src/modest-account-mgr-helpers.c:
1478 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1480 * src/maemo/Makefile.am:
1481 * src/maemo/modest-signature-editor-dialog.c:
1482 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1485 * src/maemo/modest-account-settings-dialog.h:
1486 * src/maemo/modest-account-settings-dialog.c:
1487 (modest_account_settings_dialog_finalize), (on_button_signature),
1488 (save_configuration): Use the new dialog when the Edit button is pressed, and
1489 save the changes if necessary, as per the UI spec.
1491 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1493 * src/maemo/Makefile.am:
1494 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1495 based on maemo-develoers email from Dirk.
1497 * src/maemo/easysetup/modest-easysetup-wizard.c:
1498 (create_page_welcome), (create_page_account_details),
1499 (create_page_user_details), (create_page_complete_easysetup),
1500 (create_page_custom_incoming), (create_page_custom_outgoing),
1501 (create_page_complete_custom),
1502 (modest_easysetup_wizard_dialog_init):
1503 * src/maemo/modest-account-settings-dialog.c:
1504 (create_page_account_details), (create_page_user_details),
1505 (create_page_incoming), (create_page_outgoing),
1506 (modest_account_settings_dialog_init):
1507 * src/maemo/modest-connection-specific-smtp-window.c:
1508 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1510 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/easysetup/modest-easysetup-wizard.c:
1513 (create_page_account_details), (create_page_custom_outgoing),
1514 (create_page_complete_custom):
1515 * src/maemo/modest-account-settings-dialog.c:
1516 (create_page_user_details), (create_page_incoming),
1517 (create_page_outgoing):
1518 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1519 (modest_connection_specific_smtp_edit_window_init):
1520 Use the correct (UI spec) port min/max, and use horizontal separators,
1523 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1525 * src/maemo/easysetup/modest-easysetup-wizard.c:
1526 (set_default_custom_servernames):
1527 * src/maemo/modest-account-settings-dialog.c:
1528 (create_page_incoming), (on_combo_outgoing_security_changed),
1529 (on_combo_incoming_security_changed), (create_page_outgoing),
1530 (modest_account_settings_dialog_set_account_name),
1531 (save_configuration):
1532 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1533 (on_combo_security_changed),
1534 (modest_connection_specific_smtp_edit_window_init),
1535 (modest_connection_specific_smtp_edit_window_set_connection),
1536 (modest_connection_specific_smtp_edit_window_get_settings):
1537 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1540 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1543 * src/maemo/easysetup/modest-easysetup-wizard.c:
1544 (create_page_custom_outgoing), (create_page_complete_custom):
1545 * src/maemo/modest-account-settings-dialog.c:
1546 (create_page_user_details), (create_page_outgoing):
1547 * src/maemo/modest-account-view-window.c: (button_box_new):
1548 Use changed logical IDs as per the most recent UI spec:
1549 mcen_bd_emailsetup_edit -> mcen_bd_edit
1550 mcen_bd_emailsetup_delete -> mcen_bd_delete
1551 mcen_bd_emailsetup_close -> mcen_bd_close
1553 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1557 * src/dbus_api/Makefile.am:
1558 * src/dbus_api/modest-dbus-callbacks.c:
1559 * src/dbus_api/modest-dbus-callbacks.h:
1560 * src/maemo/modest-platform.c: (modest_platform_init):
1561 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1563 * tests/Makefile.am:
1564 * tests/dbus_api/Makefile.am:
1565 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1567 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/modest-account-settings-dialog.c:
1570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1571 Removed unnecessary includes.
1573 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1575 * src/maemo/easysetup/modest-easysetup-wizard.c:
1576 * src/maemo/modest-account-settings-dialog.c:
1577 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1578 * src/widgets/Makefile.am:
1579 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1580 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1581 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1582 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1583 * src/widgets/modest-secureauth-combo-box.c:
1584 * src/widgets/modest-secureauth-combo-box.h:
1585 * src/widgets/modest-serversecurity-combo-box.c:
1586 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1587 made the GObject names more consistent with the rest of the Modest code.
1589 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1591 * src/maemo/easysetup/Makefile.am:
1592 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1593 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1594 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1595 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1596 * src/maemo/easysetup/modest-easysetup-wizard.c:
1597 * src/maemo/easysetup/modest-validating-entry.c:
1598 * src/maemo/easysetup/modest-validating-entry.h:
1599 * src/maemo/modest-account-settings-dialog.c:
1600 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1601 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1602 widgets/ because they are used outside of easysetup too. After checking in,
1603 svn will allow me to rename them too.
1605 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1607 * src/gnome/modest-msg-edit-window.c:
1608 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1609 linker error, to fix the build on the GNOME platform.
1610 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1611 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1612 ifdefed out to avoid a warning.
1614 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1616 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1617 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1618 some alternative for GTK+ 2.6.
1620 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1622 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1624 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1625 specified for EmailAccountsDialog in UI spec.
1627 * src/maemo/easysetup/modest-easysetup-wizard.c:
1628 * src/maemo/easysetup/modest-easysetup-wizard.h:
1629 * src/maemo/modest-account-settings-dialog.c:
1630 * src/maemo/modest-account-settings-dialog.h:
1631 Reuse a member window widget for the connection-specific SMTP server accounts,
1632 so we can tell it to create/save the accounts only if we actually save changes.
1634 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1635 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1636 (modest_connection_specific_smtp_edit_window_get_settings):
1637 Return a struct instance for temporarily remembering the entered data.
1639 * src/maemo/modest-connection-specific-smtp-window.h:
1640 * src/maemo/modest-connection-specific-smtp-window.c:
1641 (modest_connection_specific_smtp_window_finalize),
1642 (modest_connection_specific_smtp_window_fill_with_connections),
1644 (modest_connection_specific_smtp_window_save_server_accounts),
1645 (update_model_server_names): Do not actually save data until asked,
1646 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1648 (on_selection_changed),
1649 (modest_connection_specific_smtp_window_init): Disable the edit
1650 button when nothing is selected.
1652 * src/modest-account-mgr-helpers.c:
1653 * src/modest-account-mgr-helpers.h:
1654 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1657 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1659 * src/modest-account-mgr-helpers.h:
1660 * src/modest-account-mgr-helpers.c:
1661 (modest_account_mgr_get_unused_account_name),
1662 (modest_account_mgr_get_unused_account_display_name): Added these
1663 utility functions, to avoid code duplication.
1665 * src/maemo/easysetup/modest-easysetup-wizard.c:
1666 (create_page_account_details), (create_account):
1667 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1668 (on_combo_security_changed),
1669 (modest_connection_specific_smtp_edit_window_init),
1670 (modest_connection_specific_smtp_edit_window_save_settings):
1671 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1672 * src/maemo/modest-connection-specific-smtp-window.c:
1673 (modest_connection_specific_smtp_window_finalize),
1674 (modest_connection_specific_smtp_window_fill_with_connections),
1675 (on_button_edit), (modest_connection_specific_smtp_window_init):
1676 * src/maemo/modest-connection-specific-smtp-window.h:
1677 Implementing saving of connection-specific server accounts.
1679 But I need to refactor this so we can save the data for each
1680 possible connection-specific account and only actually create the server accounts
1681 when the easysetup finished, or the OK button is pressed on the account settings
1684 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1686 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1687 (on_combo_security_changed):
1688 (modest_connection_specific_smtp_edit_window_init):
1689 Auto-fill the port number as in the account settings.
1691 (modest_connection_specific_smtp_edit_window_set_connection):
1692 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1693 * src/maemo/modest-connection-specific-smtp-window.c:
1694 (fill_with_connections), (on_button_edit),
1695 (modest_connection_specific_smtp_window_init):
1696 Turn the edit window into a dialog to simplify the code, and
1697 set a WM hint as in a GtkDialog, because only a popup can be on top of
1698 another window in Maemo, and popups usually have no WM decoration.
1700 * src/modest-defs.h:
1701 * src/modest-account-mgr-helpers.c:
1702 (modest_account_mgr_set_connection_specific_smtp),
1703 (modest_account_mgr_remove_connection_specific_smtp),
1704 (modest_account_mgr_get_connection_specific_smtp):
1705 * src/modest-account-mgr-helpers.h: Some functions to write the
1706 connection-specific SMTP server information. Not yet used.
1709 * src/widgets/modest-folder-view.c: (text_cell_data):
1710 Fix a warning about an uninitialized variable.
1711 (on_configuration_key_changed): Put an #ifdef around the use
1712 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1714 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1716 * src/maemo/modest-account-settings-dialog.h:
1717 * src/maemo/modest-account-settings-dialog.c:
1718 Added connect_for_modified() utility function to mark the new modified boolean.
1720 (create_page_account_details), (create_page_user_details),
1721 (create_page_incoming), (create_page_outgoing), (on_response),
1722 (modest_account_settings_dialog_init),
1723 (modest_account_settings_dialog_set_account_name):
1724 Only warn about unsaved changes when there are actually unsaved changes.
1726 * src/modest-account-mgr-helpers.c:
1727 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1728 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1729 to get the data from there in future.
1731 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1733 * src/modest-defs.h:
1735 * src/modest-account-mgr-helpers.h:
1736 * src/modest-account-mgr-helpers.c:
1737 Store the security account setting in a single conf key instead of using
1738 the options list, so that the list is left for just the to-be-removed camel hack,
1739 and because gconf_client_set_list() is failing for some reason.
1741 * src/modest-account-mgr.c:
1742 (modest_account_mgr_add_server_account):
1743 * src/maemo/modest-account-settings-dialog.c:
1744 (modest_account_settings_dialog_set_account_name),
1745 (save_configuration): Use the renamed functions.
1748 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1750 * src/widgets/Makefile.am:
1751 * src/widgets/modest-limit-retrieve-combo-box.c:
1752 * src/widgets/modest-limit-retrieve-combo-box.h:
1753 * src/widgets/modest-retrieve-combo-box.c:
1754 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1755 the account settings dialog.
1757 * src/modest-defs.h:
1758 * src/modest-account-mgr-helpers.h:
1759 * src/modest-account-mgr-helpers.c:
1760 (modest_server_account_get_option_secure_auth),
1761 (modest_server_account_set_option_secure_auth):
1762 * src/modest-account-mgr.c:
1763 (modest_account_mgr_add_server_account):
1764 Use the existing AUTH_MECH conf key for the secure-auth setting,
1765 instead of putting it in the list options, because this was actually used already.
1767 * src/maemo/modest-account-settings-dialog.c:
1768 (create_page_account_details),
1769 (modest_account_settings_dialog_set_account_name),
1770 (save_configuration):
1771 * src/maemo/modest-account-settings-dialog.h:
1772 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1773 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1775 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1778 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1779 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1781 * src/modest-defs.h:
1782 * src/maemo/modest-account-settings-dialog.c:
1783 (create_page_incoming), (on_combo_outgoing_security_changed),
1784 (on_combo_incoming_security_changed), (create_page_outgoing),
1785 (modest_account_settings_dialog_set_account_name),
1786 (save_configuration): Load/Save the port number, and change it when the
1787 security combo changes, to suitable defaults.
1789 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-account-mgr.c:
1792 (modest_account_mgr_add_server_account): Set the security and secure-auth
1793 options, and add a comment saying that the other camel-specific options should be
1796 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1798 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1800 * src/modest-tny-account-store.c: (account_list_free),
1801 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1802 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1805 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1807 * src/modest-protocol-info.c:
1808 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1809 is required by our UI spec. Maybe something in our implementation will use this eventually.
1810 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1811 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1812 instead of the previous 0 placeholder.
1814 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1815 secure-auth settings.
1816 * src/modest-account-mgr-helpers.h:
1817 * src/modest-account-mgr-helpers.c:
1818 (modest_server_account_data_get_option_secure_auth),
1819 (modest_server_account_set_option_secure_auth),
1820 (modest_server_account_data_get_option_security),
1821 (modest_server_account_set_option_security): Added this API for getting and setting the security
1822 and secure-auth settings.
1824 * src/maemo/modest-account-settings-dialog.h:
1825 * src/maemo/modest-account-settings-dialog.c:
1826 (modest_account_settings_dialog_finalize), (check_data),
1827 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1828 about changing titles.
1829 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1830 (save_configuration): Save the security and secure-auth settings.
1832 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1833 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1835 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1837 * src/modest-defs.h:
1838 * src/modest-account-mgr.c:
1839 (modest_account_mgr_add_server_account):
1840 Added and used defines for the options key and value pair strings,
1841 that are used so far, though they do not seem to correspond to anything in our
1842 UI specs or ModestProtocol enum.
1844 * src/modest-account-mgr-helpers.h:
1845 * src/modest-account-mgr-helpers.c:
1846 (compare_option_strings_for_name),
1847 (modest_server_account_data_get_option_value),
1848 (modest_server_account_data_get_option_bool),
1849 (modest_account_mgr_get_server_account_option):
1850 Added helper functions for parsing the options GSList.
1852 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1854 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1855 display name is based on the supplied account name.
1856 * src/modest-account-mgr.c:
1857 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1858 with an inefficient, but good-enough, implementation.
1860 * src/maemo/easysetup/modest-easysetup-wizard.c:
1861 (create_page_account_details), (on_before_next), (create_account):
1862 Check for existing display names rather than (non-user-visible) account names, and just
1863 create and set a unique account name at the end.
1865 * src/maemo/modest-account-settings-dialog.c:
1866 (modest_account_settings_dialog_init),
1867 (modest_account_settings_dialog_set_account_name),
1868 (create_page_incoming): Show the display name, instead of the account name.
1869 (on_response): Do some (not all) extra checks, as in the UI spec.
1870 (save_configuration): Save the display name if it was changed.
1872 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1874 * po/en_GB.po: Added needed logical ID and translation.
1875 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1876 (init_view): Made the is-default column clicking work.
1878 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1881 * src/maemo/easysetup/Makefile.am:
1882 * src/maemo/easysetup/modest-easysetup-wizard.c:
1883 (modest_easysetup_wizard_dialog_init):
1884 * src/maemo/easysetup/provider-data-test.keyfile:
1885 * src/maemo/easysetup/provider-data.keyfile:
1886 Moved the provider data file to the new modest-providers-data package and used it from there.
1888 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-local-folder-info.c:
1891 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1892 N_() was already used on the static strings, but this just marks it for translation without
1893 using the translation.
1895 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1897 * src/maemo/modest-account-settings-dialog.c:
1898 (create_page_incoming),
1899 (modest_account_settings_dialog_set_account_name):
1900 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1901 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1902 I will do this if nobody else gets there first.
1904 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1906 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1907 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1908 save the security stuff.
1910 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1912 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1913 Set the email address and user fullname, which I now see must be
1916 * src/maemo/modest-account-settings-dialog.h:
1917 * src/maemo/modest-account-settings-dialog.c:
1919 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1920 leave-on-server and authentication.
1921 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1924 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1927 * src/maemo/modest-account-settings-dialog.c:
1928 * src/maemo/modest-account-settings-dialog.h:
1929 Most (but not all) of the widgets are now present as specified by the UI spec.
1930 No changes are yet saved, and some details are not properly shown yet.
1932 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1934 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1936 * src/maemo/Makefile.am:
1937 * src/maemo/modest-account-settings-dialog.c:
1938 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1939 an existing account. Doesn't do much yet.
1941 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1942 Open the accounts settings dialog when Edit is clicked.
1944 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1946 * src/maemo/easysetup/Makefile.am:
1947 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1949 * src/maemo/easysetup/modest-easysetup-wizard.c:
1950 (modest_easysetup_wizard_dialog_init):
1951 Try to get the source directory from the build system,
1952 instead of hard-coding "./" into the source code, when opening our local
1953 copies of the configuration files.
1954 But this still fails when opening the wizard from the Accounts window,
1955 maybe because the working directory seems to change at runtime.
1956 So the wizard will fail the second time unless you copy the files into their
1957 proper locations - see the stdout warnings for the paths.
1959 (create_page_account_details),(on_before_next):
1960 Check for existing non-server accounts instead of server accounts,
1961 so the default account name is useful again, and to prevent trying to
1964 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1965 Show the wizard when New is clicked.
1967 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1968 (init_view): Show the column headers, and show the columns that are
1969 specified in the UI specs. However, something in Maemo's GTK+ prevents
1970 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1971 change the default account. This is despite unsetting the special properties.
1973 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1975 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1976 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1977 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1978 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1979 to make that clearer.
1980 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1982 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/modest-account-view-window.c:
1985 (modest_account_view_window_init),
1986 (modest_account_view_window_new):
1987 Use the same buttons as specified in the
1988 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1989 the existing widgets, which never had a chance of working.
1990 Put the ModestAccountView treeview in a scrolled window.
1991 Do not repeat the initialization in both _init() and _new().
1993 * src/widgets/modest-account-view.c: (update_account_view):
1994 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1995 this widget and window shows no accounts.
1997 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1999 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2001 * src/maemo/easysetup/modest-easysetup-wizard.c:
2002 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2003 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2004 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2007 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2008 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2009 accounts exist yet, as in the UI spec.
2011 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2013 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2015 * src/maemo/Makefile.am:
2016 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2017 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2018 New window for editing connection-specific smtp details.
2019 Not fully implemented.
2021 * src/maemo/modest-connection-specific-smtp-window.c:
2022 (modest_connection_specific_smtp_window_finalize) :
2023 unref the tree model.
2024 (on_button_edit): Show the edit window.
2026 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2028 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2031 * src/maemo/Makefile.am:
2032 * src/maemo/modest-connection-specific-smtp-window.c:
2033 * src/maemo/modest-connection-specific-smtp-window.h:
2034 New window for showing the list of connections, for connection-specific
2035 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2036 * src/maemo/easysetup/modest-easysetup-wizard.c:
2037 (create_page_custom_outgoing): Show the new window when the button is clicked.
2039 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2042 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2043 * src/maemo/modest-msg-edit-window.c:
2044 (modest_msg_edit_window_insert_image):
2045 * src/modest-conf.c: (modest_conf_key_escape):
2046 * src/modest-mail-operation.c:
2047 (modest_mail_operation_send_new_mail):
2048 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2049 (modest_ui_actions_on_new_account):
2050 * src/widgets/modest-attachment-view.c: (update_filename_request):
2051 * src/widgets/modest-mail-header-view.c:
2052 Corrected warnings that were breaking the build, by commenting out unused variables,
2053 and a function, and by including a header.
2055 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2057 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2058 so we can #ifdef around platform-specific code when necessary.
2059 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2060 to allow this to build for the GNOME platform too.
2062 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/easysetup/modest-easysetup-wizard.c:
2065 Added util_increment_name() and used it in create_page_account_details()
2066 to make sure that the default account name is always a new name.
2068 (modest_easysetup_wizard_dialog_init),
2069 (set_default_custom_servernames): Some minor memory management fixes.
2071 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2075 * src/modest-runtime.c: (init_i18n): Restored the translation
2076 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2077 are defined in config.h, and the translations are installed.
2079 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2080 is defined for translation.
2082 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2086 * src/maemo/easysetup/modest-easysetup-wizard.c:
2087 (modest_easysetup_wizard_dialog_init):
2088 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2089 Use realistic paths (though they should use $prefix generically) to the
2090 mcc_mapping and provider-data.keyfile files which might work when they
2091 are installed by the future version of the operator-wizard package,
2092 and then fallback to paths in our source code, with an explanatory
2095 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/Makefile.am:
2100 * src/maemo/easysetup/: Added files from the previously-exernal
2101 osso-modest-easysetup.
2102 * src/maemo/modest-main-window-ui.h:
2103 * src/modest-ui-actions.c:
2104 * src/modest-ui-actions.h:
2105 Added modest_ui_actions_on_new_account() as a signal handler for the
2106 New Account menu item. It shows the easysetup wizard.
2107 * po/en_GB.po: Added additional needed logical IDs and translations.
2109 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2110 Apparently ChangeLog is not used for some vague Nokia legal reasons.