2007-07-25 Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
Never save the entered username and password in gconf,
because the UI spec says we should not. This helps
slightly with projects.maemo.org bug NB#63671.

pmo-trunk-r2790

diff --git a/ChangeLog2 b/ChangeLog2
index 8a9168d..b29410f 100644 (file)
--- a/ChangeLog2
+++ b/ChangeLog2
@@ -1,5 +1,12 @@
 2007-07-25  Murray Cumming  <murrayc@murrayc.com>
 
+       * src/modest-tny-account-store.c: (get_password):
+       Never save the entered username and password in gconf, 
+       because the UI spec says we should not. This helps 
+       slightly with projects.maemo.org bug NB#63671.
+
+2007-07-25  Murray Cumming  <murrayc@murrayc.com>
+
        * src/widgets/modest-msg-edit-window.h:
        * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
        Moved some code here to make it simpler.

diff --git a/src/modest-tny-account-store.c b/src/modest-tny-account-store.c
index 8211b78..2291b62 100644 (file)
--- a/src/modest-tny-account-store.c
+++ b/src/modest-tny-account-store.c
@@ -688,6 +688,9 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                         * but we need to tell tinymail about the username too: */
                        tny_account_set_user (account, username);
                        
+                       /* Do not save the password in gconf, 
+                        * because the UI spec says "The password will never be saved in the account": */
+                       /*
                        if (remember) {
                                printf ("%s: Storing username=%s, password=%s\n", 
                                        __FUNCTION__, username, pwd);
@@ -696,6 +699,8 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                                modest_server_account_set_password (priv->account_mgr, server_account_name,
                                                               pwd);
                        }
+                       */
+
                        /* We need to dup the string even knowing that
                           it's already a dup of the contents of an
                           entry, because it if it's wrong, then camel