* Reviewed reference counting of tree row reference. There
were some cases we were leaking this (fixes NB#78857).
pmo-trunk-r4140
g_object_unref(priv->header_model);
priv->header_model = NULL;
if (priv->row_reference)
g_object_unref(priv->header_model);
priv->header_model = NULL;
if (priv->row_reference)
- g_object_unref(priv->row_reference);
+ gtk_tree_row_reference_free (priv->row_reference);
priv->row_reference = NULL;
if (priv->next_row_reference)
priv->row_reference = NULL;
if (priv->next_row_reference)
- g_object_unref(priv->next_row_reference);
+ gtk_tree_row_reference_free (priv->next_row_reference);
priv->next_row_reference = NULL;
modest_ui_actions_check_toolbar_dimming_rules(MODEST_WINDOW(window));
priv->next_row_reference = NULL;
modest_ui_actions_check_toolbar_dimming_rules(MODEST_WINDOW(window));
/* Read the message & show it */
if (!message_reader (window, priv, header, row_reference)) {
retval = FALSE;
/* Read the message & show it */
if (!message_reader (window, priv, header, row_reference)) {
retval = FALSE;
- gtk_tree_row_reference_free (row_reference);
+ gtk_tree_row_reference_free (row_reference);
/* Free */
g_object_unref (header);
/* Free */
g_object_unref (header);
row_reference = gtk_tree_row_reference_new (priv->header_model, path);
/* Read the message & show it */
retval = message_reader (window, priv, header, row_reference);
row_reference = gtk_tree_row_reference_new (priv->header_model, path);
/* Read the message & show it */
retval = message_reader (window, priv, header, row_reference);
- if (!retval)
- gtk_tree_row_reference_free (row_reference);
+ gtk_tree_row_reference_free (row_reference);
} else {
finished = FALSE;
}
} else {
finished = FALSE;
}
ModestMsgViewWindowPrivate *priv = NULL;
GtkTreeRowReference *row_reference = NULL;
ModestMsgViewWindowPrivate *priv = NULL;
GtkTreeRowReference *row_reference = NULL;
+ row_reference = (GtkTreeRowReference *) user_data;
+ gtk_tree_row_reference_free (row_reference);
return;
}
/* If there was any error */
return;
}
/* If there was any error */
- row_reference = (GtkTreeRowReference *) user_data;
if (!modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) {
gtk_tree_row_reference_free (row_reference);
return;
if (!modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) {
gtk_tree_row_reference_free (row_reference);
return;