Sergio Villar Senin [Thu, 4 Oct 2007 13:39:59 +0000 (13:39 +0000)]
* Added a callback for the save_to_drafts operation
* Removed a call to edit window directly from mail operations
* Fixed a bug caused by the old implementation, now if the message was saved when the editor was closed it unregisters the header in the window mgr, so we are able to open it again
pmo-trunk-r3470
Sergio Villar Senin [Thu, 4 Oct 2007 13:32:02 +0000 (13:32 +0000)]
* Added a missing g_object_unref that was causing leaks
pmo-trunk-r3469
Sergio Villar Senin [Thu, 4 Oct 2007 08:12:40 +0000 (08:12 +0000)]
* Added a new signal "updating-msg-list" to the header view
* Now the Main window shows an "updating banner" whenever the refresh of a folder takes more than 2 seconds
pmo-trunk-r3465
Jose Dapena Paz [Wed, 3 Oct 2007 16:55:20 +0000 (16:55 +0000)]
* src/modest-platform.h, src/maemo/modest-platform.c:
* Added method (modest_platform_set_dialog_help) and
implementation for maemo using hildon/osso help. This method
sets a topic for contextual help of a dialog.
* src/maemo/modest-account-view-window.c:
* Attach help topic for accounts settings dialog. This fixes
NB#64313 at modest side. We still need the topic help in
help contents.
pmo-trunk-r3463
Sergio Villar Senin [Wed, 3 Oct 2007 15:31:19 +0000 (15:31 +0000)]
* Fixes NB#65999 note that the translation is still not available
* Fixes the problem present when creating a new account, the account view was showing the account id of the account instead of the display account
* Now, every account that is added is automatically refreshed
pmo-trunk-r3462
Jose Dapena Paz [Wed, 3 Oct 2007 09:37:15 +0000 (09:37 +0000)]
These changes add support for searching in outbox folder (fixes
NB#57740).
* src/dbus_api/modest-dbus-callbacks.c:
* (find_message_by_url): if the url prefix is merge we assume
we're trying to retrieve a message in outbox.
* (on_dbus_method_search): we remove the MAND: and USER: strings
in the received folder name.
* (add_single_folder_to_list): if folder is merge folder, and
name is Outbox, we add it to the list of folders as
MAND:outbox.
* (add_single_folder_to_list): now we add MAND: prefix if the
folder is a mandatory folder (inbox, sent, drafts, archive).
If not, we add the USER: prefix.
* src/modest-search.c:
* (modest_search_folder): if we search in a specific folder,
make "outbox" folder name match any folder of type outbox.
* src/modest-tny-account-store.[ch]:
* Added new method
(modest_tny_account_store_find_msg_in_outboxes)
that finds a message uri (with the merge:// format) in outbox
folders, to open it properly. This way, we can open a message
in an outbox folder from global search emails list.
pmo-trunk-r3457
Sergio Villar Senin [Tue, 2 Oct 2007 17:43:37 +0000 (17:43 +0000)]
* Moved the op_type to the mail operations, it should be definitely there and not set by external callers. The new operation-started/finished allow us to do this
pmo-trunk-r3456
Sergio Villar Senin [Tue, 2 Oct 2007 17:06:57 +0000 (17:06 +0000)]
* Added operation-started and operation-finished to the mail operations
* Fixes NB#62764, the progressbar is not shown for local folders
pmo-trunk-r3455
Vivek Sekar [Tue, 2 Oct 2007 11:45:16 +0000 (11:45 +0000)]
Modified the changelog with the updated bug fixes and the component change.
pmo-trunk-r3450
Jose Dapena Paz [Tue, 2 Oct 2007 09:15:49 +0000 (09:15 +0000)]
* src/modest-search.c:
* (add_hit): now we get the minimum of the dates in a header,
instead of the date received. This way the date is better
obtained (fixes NB#61007).
* (search_mime_part_strcmp): minor improvemnt in the broken
no-ogs backend for search.
pmo-trunk-r3449
Sergio Villar Senin [Fri, 28 Sep 2007 17:22:09 +0000 (17:22 +0000)]
* Fixed NB#62792, the editor is closed if the account is removed
* Added modest_signal_mgr_disconnect, for disconnecting a single handler
* Added the signal parametter to modest_signal_mgr_connect, this way we can add multiple connections for the same object
* Renamed modest_window_mgr_(set/get)_modal_dialog to modest_window_mgt_(set/get)_modal because we can set a normal window as modal as well
* Implemented a queue of modal dialogs in the window mgr, this way if the top one is removed the second one becomes the topmost
pmo-trunk-r3441
Jose Dapena Paz [Fri, 28 Sep 2007 14:54:55 +0000 (14:54 +0000)]
This commit implements a new handling of image attachments. We follow
the standard of mime, adding the image attachment in a multipart/related
with the body. These together form the complete body of the message.
This fixes NB#64463.
* src/widgets/modest-msg-edit-window.h:
* Add attribute images to the MsgData.
* src/widgets/modest-attachments-view.c:
* We only add attachments from message if it's not a
multipart/related (as they would be attached images and they
shouldn't be represented in attachments view).
* src/modest-tny-msg.[ch]:
* (modest_formatter_create_message): now it accepts a new
parameter "has_images", to create the proper structure of
image attachments (including the multipart/related).
* /modest_tny_msg_new_html_plain): now it receives also a
list of image mime parts. It adds them properly to the
message using the new add_images() method.
* (add_attachment). Now it allows adding attachments as children
of an arbitrary part. This is required to add image
attachments to multipart/related. It also accepts a new
parameter "add_inline" to set the disposition as attachment or
inline depending on the parameter used.
* (add_images): this new method searches the multipart/related
mime part, and adds a list of image mime parts to it.
* src/modest-ui-actions.c:
* Add images parameter to save to drafts and send new mail
actions.
* src/maemo/modest-msg-edit-window.c:
* Now we maintain an internal list of images in body buffer,
separated from the list of attachments.
* (replace_with_attachments): renamed to replace_with_images
as it's intended to replace image replacers with attached
images in priv->images list.
* New method (get_related_images): searches the
multipart/related mime part, and obtains all the image
children it has. Then it adds the images to the priv->images
list.
* Now last_cid is updated using the images and attachments list.
* (modest_msg_edit_window_get_msg_data): now we also obtain the
list of images attached (unless a image is in priv->image and
not refernced in the buffer).
* src/modest-formatter.[ch]:
* Added internal method find_body_parent (), to refactor the
work to find the part where body should be attached to.
* (modest_formatter_create_message): now it takes into account
the new attribute has_images to create the proper mime part
multipart/related.
* src/modest-mail-operation.[ch]:
* (modest_mail_operation_create_message): now we pass the images
list to the lower layers.
pmo-trunk-r3438
Sergio Villar Senin [Fri, 28 Sep 2007 09:45:33 +0000 (09:45 +0000)]
* The main paned position follows now the 30/70 rule if it was not set previously
pmo-trunk-r3436
Jose Dapena Paz [Thu, 27 Sep 2007 21:28:46 +0000 (21:28 +0000)]
* src/widgets/modest-account-view.c:
* (on_default_account_changed): Now we check if there's an
account name, as it was crashing when we removed the last
available account.
* src/modest-widget-memory.c:
* (restore_settings_paned, save_settings_paned): now we store
in ModestConf the percent of the total the separator is
set, instead of the pixel position. This way, we correctly
recover the position (fixes NB#63405).
pmo-trunk-r3434
Sergio Villar Senin [Thu, 27 Sep 2007 18:00:57 +0000 (18:00 +0000)]
* The "account-changed" signal is now properly managed in the ModestTnyAccountStore and in ModestTnyAccount, there were some errors in the handler that were actually preventing the account update to happen
* Changed the signature of the method modest_tny_account_update_from_account
* Added display_name_changed signal to notify changes in the display name of the accounts
* ModestConf does not listen for key changes, all signal emissions related to changes in the configuration must be triggered by the account manager
* Removed the ModestConf delayed notification system, we do not need it since we're not listening for chey changes there anymore
* All the modest_account_mgr_(get/set)_(int/book/string/list) are now private methods and could not be used by third parties
* Added a lot of getters and setters to the modest-account-mgr-helpers. We did that to ensure that nobody changes the configuration keys directly (because maybe we want to notify key changes)
* Renamed old modest_server_account_get_xxx by modest_account_mgr_get_server_account_xxx
* Renamed old modest_server_account_set_xxx by modest_account_mgr_set_server_account_xxx
* FolderView now changes the display name of an account if it changes
* AccountView now changes the display name of an account if it changes
* Removed unused code here and there
* Several aesthetic changes here and there
* TODO: I realized that the account-settings dialog thinks that something has changed when you change it and then revert the change
* TODO: detect in the account-settings dialog which changes should issue an "account-changed" signals and which ones not, for example a change in the display name should not force an account reload
pmo-trunk-r3433
Jose Dapena Paz [Thu, 27 Sep 2007 17:07:11 +0000 (17:07 +0000)]
Work to fix NB#66729: after moving selected messages to another folder,
selection should go to the next available message.
* src/modest-ui-actions.c:
* Now we pass a MoveToHelper as argument for move_to_cb. This
helper contains a row reference for the next row to be
selected if move to is successful, and the information banner.
* Added new method get_next_after_selected_headers, that
obtains a row reference of the next row of the header view
after the selected headers.
* (move_to_cb). Now, if we get a row reference in move to
helper, we select it after moving the messages.
pmo-trunk-r3432
Jose Dapena Paz [Wed, 26 Sep 2007 12:14:20 +0000 (12:14 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_on_password_requested): now we set the
focus to the password entry in case username has already a
value (fixes NB#66489).
pmo-trunk-r3422
Sergio Villar Senin [Wed, 26 Sep 2007 12:12:09 +0000 (12:12 +0000)]
* Some aesthetic changes
* Removed an invalid g_warning
* Fixed a problem when changing the name of the device, the details widget was showing the %s after a device name change because it was using another different function than the one used for creating the widget
* Changed some ModestConf functions
* Modest now listens for changes in the keys without needing a folder view
pmo-trunk-r3421
Jose Dapena Paz [Wed, 26 Sep 2007 11:48:28 +0000 (11:48 +0000)]
* src/widgets/modest-msg-edit-window.h:
* Add new method to interface to reset the modified status.
* src/modest-ui-actions.c:
* On saving to drafts, we now reset the modified status of
the editor (fixes NB#67694).
* src/maemo/modest-msg-edit-window.c:
* Make reset_modified method public, to be able to access it
from the ui actions.
pmo-trunk-r3420
Sergio Villar Senin [Wed, 26 Sep 2007 10:59:26 +0000 (10:59 +0000)]
* Fixed an error in the g_signal_emit of my last commit
* Fixed some leaks
pmo-trunk-r3416
Sergio Villar Senin [Wed, 26 Sep 2007 10:34:22 +0000 (10:34 +0000)]
* Some aesthetic changes
* Replaced a folder_sync by a folder_async
* If a new account is created select show it as the default in the account view
pmo-trunk-r3415
Jose Dapena Paz [Tue, 25 Sep 2007 20:25:21 +0000 (20:25 +0000)]
Work to fix NB#61649:
* src/modest-ui-actions.c:
* If we activate headers and there's more than one
selected header, then we show the select 1 message only
banner.
* src/maemo/modest-main-window.c:
* If we press enter and focus is in headers view, check if
there are more than one header selected, and then, show
the proper information banner.
pmo-trunk-r3413
Sergio Villar Senin [Tue, 25 Sep 2007 17:16:23 +0000 (17:16 +0000)]
* Some aesthetic changes
* Removed unused #includes
* Removed invalid code related to send queues
* Fixed the problem of GConf notifications when the default window is changed in the account view window
--This line, and those below, will be ignored- -
M src/modest-main.c
M src/widgets/modest-folder-view.c
M src/widgets/modest-account-view.c
M src/modest-tny-folder.c
M src/maemo/modest-account-view-window.c
M src/modest-conf.c
M src/modest-conf.h
M src/modest-widget-memory.c
pmo-trunk-r3412
Jose Dapena Paz [Tue, 25 Sep 2007 12:34:27 +0000 (12:34 +0000)]
* src/widgets/modest-folder-view.c:
* Now copied models also attach the row inserted signal. This
way the code that sets the focus on specific folders also
work for the folder dialogs (fixes NB#67005).
pmo-trunk-r3410
Philip Van Hoof [Tue, 25 Sep 2007 10:57:01 +0000 (10:57 +0000)]
Reconnect and forget password when changing account settings
pmo-trunk-r3406
Jose Dapena Paz [Mon, 24 Sep 2007 15:55:32 +0000 (15:55 +0000)]
* src/widgets/modest-header-view.c:
* If selection in headers view is multiple, and we move the
toplevel focus out of this, we remove the selection and keep
only one item selected (fixes NB#57631).
pmo-trunk-r3403
Philip Van Hoof [Mon, 24 Sep 2007 13:56:17 +0000 (13:56 +0000)]
Bugfix, priv used too early
pmo-trunk-r3402
Dirk-Jan C. Binnema [Mon, 24 Sep 2007 09:51:46 +0000 (09:51 +0000)]
* add missing commit...
pmo-trunk-r3399
Sergio Villar Senin [Fri, 21 Sep 2007 17:51:39 +0000 (17:51 +0000)]
* Added two missing unref's
* Do not use gconf directly, replaced by calls to modest_conf
* Fixes NB#65856, do not show the "Saving" info banner while asking for confirmation
pmo-trunk-r3396
Sergio Villar Senin [Fri, 21 Sep 2007 17:11:26 +0000 (17:11 +0000)]
* Fixes NB#66338, show the proper info banner when creating a folder fails
pmo-trunk-r3395
Sergio Villar Senin [Fri, 21 Sep 2007 16:49:16 +0000 (16:49 +0000)]
* Fixed a SIGSEV when starting modest with no accounts
pmo-trunk-r3394
Dirk-Jan C. Binnema [Fri, 21 Sep 2007 16:24:33 +0000 (16:24 +0000)]
* cache the modest-conf keynames, so we don't have to re-calculate
them all the time. this showed up high in oprofile, and indeed
the cache seems to make things faster.
pmo-trunk-r3393
Dirk-Jan C. Binnema [Fri, 21 Sep 2007 13:12:44 +0000 (13:12 +0000)]
* further optimization of parse_mcc_mapping_line, which still
showed up high in the profiles
pmo-trunk-r3391
Dirk-Jan C. Binnema [Fri, 21 Sep 2007 12:16:59 +0000 (12:16 +0000)]
* bugfix: register the new dialog as the new modal dialog; this
handles the case where there are >2 candidate modal dialogs
pmo-trunk-r3390
Dirk-Jan C. Binnema [Fri, 21 Sep 2007 12:04:25 +0000 (12:04 +0000)]
* fix mistake in the action menu name for full screen mode;
this cause a Glib-Critical, and most probably some other bug
as well.
pmo-trunk-r3389
Dirk-Jan C. Binnema [Fri, 21 Sep 2007 11:42:11 +0000 (11:42 +0000)]
* make sure there only one modal window at any time, and
also that it is the toplevel one; this prevents a number of
hangs and seemingly-hangs
pmo-trunk-r3388
Dirk-Jan C. Binnema [Fri, 21 Sep 2007 08:58:49 +0000 (08:58 +0000)]
* move modest-tny-account-store to use modest-signal-mgr
(the little helper class to remember gsignal handler ids)
* make modest-signal-mgr a bit more fault-tolerant
* this fixes the ugly G-Criticals when closing modest
pmo-trunk-r3387
Jose Dapena Paz [Thu, 20 Sep 2007 20:00:06 +0000 (20:00 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now, when we set the file format to html using the
modest_msg_edit_window_set_file_format, we remove all
the tags, so that the text is shown again with the default
font (fixes NB#63647).
pmo-trunk-r3380
Jose Dapena Paz [Thu, 20 Sep 2007 19:32:53 +0000 (19:32 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now, if we add characters to the subject field, and it's
already in the max size (1000 characters), show proper
information banner (fixes NB#66473).
* src/modest-conf.c:
* Fix a compilation warning.
pmo-trunk-r3379
Jose Dapena Paz [Thu, 20 Sep 2007 18:29:19 +0000 (18:29 +0000)]
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* (on_response). Now, if the range is invalid, we never process
cancel or ok responses. This way we only show one
notification (fixes NB#66862).
pmo-trunk-r3378
Sergio Villar Senin [Thu, 20 Sep 2007 18:07:29 +0000 (18:07 +0000)]
* Added a new signal to the account mgr that notifies changes in the default account, need some review because we're not getting all the changes from gconf
* Fixed a hang when creating the first account, now the accounts are not updated if the status is connecting
pmo-trunk-r3376
Jose Dapena Paz [Thu, 20 Sep 2007 17:28:07 +0000 (17:28 +0000)]
* src/maemo/modest-address-book.c:
* (modest_address_book_check_names): now, if the string is not
empty and we didn't resolve any address, we return an error
information banner (fixes NB#66116).
pmo-trunk-r3375
Jose Dapena Paz [Thu, 20 Sep 2007 16:43:47 +0000 (16:43 +0000)]
* src/modest-ui-dimming-rules.c:
* Fixed a typo in paste dimming rule.
pmo-trunk-r3374
Dirk-Jan C. Binnema [Thu, 20 Sep 2007 16:06:18 +0000 (16:06 +0000)]
* fix two memory leaks
pmo-trunk-r3373
Dirk-Jan C. Binnema [Thu, 20 Sep 2007 13:25:01 +0000 (13:25 +0000)]
* handle the case when init fails more gracefully (not Criticals)
* remove some needless debug stuff
pmo-trunk-r3371
Dirk-Jan C. Binnema [Thu, 20 Sep 2007 13:23:11 +0000 (13:23 +0000)]
* check for the required provider data at startup time; cleanup code a bit
pmo-trunk-r3370
Vivek Sekar [Thu, 20 Sep 2007 13:11:28 +0000 (13:11 +0000)]
added bug fixes to changelog.
pmo-trunk-r3369
Sergio Villar Senin [Thu, 20 Sep 2007 11:14:52 +0000 (11:14 +0000)]
* Fixes some issues
pmo-trunk-r3368
Philip Van Hoof [Thu, 20 Sep 2007 10:57:05 +0000 (10:57 +0000)]
Meaningless comparison
pmo-trunk-r3367
Philip Van Hoof [Thu, 20 Sep 2007 10:52:56 +0000 (10:52 +0000)]
Compilation warning
pmo-trunk-r3366
Sergio Villar Senin [Thu, 20 Sep 2007 10:10:59 +0000 (10:10 +0000)]
* Added an improvement for d&d, now it's not required to use the SHIFT key to do multiple d&d
pmo-trunk-r3363
Jose Dapena Paz [Wed, 19 Sep 2007 21:35:49 +0000 (21:35 +0000)]
* src/widgets/modest-attachments-view.c:
* Wops, we should use "focus" event instead of focus-in.
pmo-trunk-r3359
Jose Dapena Paz [Wed, 19 Sep 2007 21:28:00 +0000 (21:28 +0000)]
* src/widgets/modest-attachments-view.c:
* Added focus in event. If focus in, we select the first
attachment available (fixes NB#66101).
pmo-trunk-r3358
Jose Dapena Paz [Wed, 19 Sep 2007 21:09:30 +0000 (21:09 +0000)]
* src/modest-tny-msg.c:
* (add_attachments): we don't add purged attachments to
constructed messages (fixes NB#66088).
pmo-trunk-r3357
Jose Dapena Paz [Wed, 19 Sep 2007 15:45:07 +0000 (15:45 +0000)]
* src/maemo/modest-msg-edit-window.c
* Now, after setting font attributes with the font dialog, we
update the toolbar properly (fixes NB#65518).
pmo-trunk-r3355
Sergio Villar Senin [Wed, 19 Sep 2007 15:39:37 +0000 (15:39 +0000)]
* Renamed one method in modest UI actions
* Added modest-dnd.c with some helper functions for drag&drop
* Fixes NB#62404, drag&drop of multiple headers at a time is now possible
pmo-trunk-r3354
Jose Dapena Paz [Wed, 19 Sep 2007 15:32:34 +0000 (15:32 +0000)]
Add dimming for save to drafts menu action (fixes NB#66476).
* src/widgets/modest-msg-edit-window-ui.h:
* Add email menu ui action for checking dimming rules.
* src/maemo/modest-msg-edit-window-ui-dimming.h:
* Add dimming rule for save to drafts to editor.
* src/modest-ui-dimming-rules.[ch]:
* Added dimming rule implementation for save to drafts in
editor. If message is not marked as modified, we don't dim.
pmo-trunk-r3353
Jose Dapena Paz [Wed, 19 Sep 2007 14:15:40 +0000 (14:15 +0000)]
* src/modest-tny-msg.c:
* Prevent a crash when we didn't get a message in the body.
* src/modest-ui-dimming-rules.c:
* In main window, if focus is on folder view, and no folder is
selected, details should be dimmed (fixes NB#64991).
pmo-trunk-r3352
Dirk-Jan C. Binnema [Wed, 19 Sep 2007 11:49:20 +0000 (11:49 +0000)]
* optimize the parsing of the provider data, particularly the
parsing of the countries list; that one showed up high in
oprofile
basically, we take the (reasonable) assumptions that the
lines have a fixed max len and are valid ascii. this allows
us to get rid of all mem allocs. also, we just the
clustered-by-mcc values (the provider data has been adapted
for this), and with that we can get rid of a lot of strcmps
this all should help with NB#64324
pmo-trunk-r3343
Jose Dapena Paz [Wed, 19 Sep 2007 09:12:06 +0000 (09:12 +0000)]
* src/modest-ui-actions.c:
* (open_msg_for_purge_cb): fixed usage of iterators. We were
resetting the iterator to the first position and this was not
working properly. Also removed a code that wasn't working for
freeing the referenced attachments.
* src/modest-ui-dimming-rules.c:
* (modest_ui_dimming_rules_on_remove_attachments): fixed a typo
that was making the dimming rule fail (fixes NB#65901).
pmo-trunk-r3337
Dirk-Jan C. Binnema [Wed, 19 Sep 2007 08:11:22 +0000 (08:11 +0000)]
* use hildon_uri_get_actions_by_uri instead of just _get_actions, to
make it a bit more intelligent if an URI is e.g. only for mediaplayer
pmo-trunk-r3334
Jose Dapena Paz [Tue, 18 Sep 2007 22:23:08 +0000 (22:23 +0000)]
* src/widgets/modest-attachments-view.c:
* Now, if we delete a selected attachment, and selection is
after this empty, then we select the next attachment
(fixes NB#65447).
pmo-trunk-r3332
Jose Dapena Paz [Tue, 18 Sep 2007 17:38:10 +0000 (17:38 +0000)]
* src/widgets/modest-recpt-editor.c:
* (modest_recpt_editor_on_button_release_event): don't force
the cursor movement to the end in case selection is not
changed.
* (modest_recpt_editor_on_key_press_event): for Return, choose
insert or selection mark (the one with higher offset).
(fixes NB#65960).
pmo-trunk-r3331
Jose Dapena Paz [Tue, 18 Sep 2007 16:57:13 +0000 (16:57 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Prevent a crash with the new clipboard text storing
method.
pmo-trunk-r3330
Jose Dapena Paz [Tue, 18 Sep 2007 16:13:36 +0000 (16:13 +0000)]
* src/widgets/modest-msg-edit-window.h:
* Added method *_get_clipboard_text to get the last clipboard
text in selection clipboard.
* src/maemo/modest-msg-edit-window.c:
* Added implementation of *_get_clipboard_text. We set this on
clipboard change handler.
* src/maemo/modest-msg-edit-window-ui-dimming.h:
* Now we set check the paste dimming rule in standard menu
group, as now this rule does not use clipboard wait functions.
This way we can check if paste should be dimmed.
* src/modest-ui-dimming-rules.[ch]:
* Now paste dimming rule for editor also sets it dimmed when
focus is on a toggle button (just as when you're focusing
the from combobox (fixes NB#65204).
pmo-trunk-r3329
Sergio Villar Senin [Tue, 18 Sep 2007 15:27:08 +0000 (15:27 +0000)]
* Fixed an invalid g_object_ref without g_object_unref
* Some code clean ups
* Removed some unused debug code
* Fixed an issue with drag&drop, the unselect of the source folder is now done properly
* Exported a private function to the modest-tny-folder API
* Changed the name and the signature of the callback of xfer mail operations
* Refactored the xfer_folder method
* Fixes NB#66340, d&d an user created folder to a subfolder is no longer possible
* Fixes NB#67817, focus is not lost anymore when transfer operations fails
* The "Pasting" info note is removed when the transfer operation fails
pmo-trunk-r3328
Vivek Sekar [Tue, 18 Sep 2007 11:55:20 +0000 (11:55 +0000)]
Added bugs fixed till 18th sept, to changelog.
pmo-trunk-r3326
Jose Dapena Paz [Mon, 17 Sep 2007 21:03:35 +0000 (21:03 +0000)]
* src/modest-tny-msg.c:
* Now we use modest_formatter_quote instead of
modest_formatter_inline, as quote quotes attachments in the
resulting output (fixes NB#68169).
pmo-trunk-r3324
Jose Dapena Paz [Mon, 17 Sep 2007 16:34:13 +0000 (16:34 +0000)]
* src/widgets/modest-msg-edit-window-ui.h:
* Prevent a warning with a toolbar button without name on
creating a editor.
pmo-trunk-r3323
Jose Dapena Paz [Mon, 17 Sep 2007 16:06:33 +0000 (16:06 +0000)]
* src/modest-ui-dimming-rules.c:
* As now we support purging attachments also in local folders
we don't dim now. This, with the proper cahnge in tinymail,
enable attachment purging in local folders (fixes NB#63986).
pmo-trunk-r3322
Philip Van Hoof [Mon, 17 Sep 2007 15:48:38 +0000 (15:48 +0000)]
Adapted to latest Tinymail API
pmo-trunk-r3321
Sergio Villar Senin [Mon, 17 Sep 2007 15:06:36 +0000 (15:06 +0000)]
* Fixes NB#66217, do not move the selection to the inbox if the user presses cancel on the the delete dialog
pmo-trunk-r3319
Sergio Villar Senin [Mon, 17 Sep 2007 14:49:02 +0000 (14:49 +0000)]
* Fixes NB#66167, now the "unable to delete N messages" shows the number of messages that can not be deleted instead of the total number of selected messages
* Some code cleanups
pmo-trunk-r3318
Philip Van Hoof [Mon, 17 Sep 2007 14:42:00 +0000 (14:42 +0000)]
Adapted Modest to latest Tinymail API
pmo-trunk-r3317
Jose Dapena Paz [Mon, 17 Sep 2007 14:12:53 +0000 (14:12 +0000)]
* src/widgets/modest-header-view-render.c:
* Now we escape the subjects to be added to the header subject
cell, to prevent some warnings.
* src/modest-ui-actions.c:
* (modest_ui_actions_on_delete_message): now we check if
selection is empty to unselect it. We got the selection in
main window case, but in message window selection is
always NULL. We prevent a warning this way.
* (new_messages_arrived): if new_headers is NULL, we don't show
a warning.
* src/maemo/modest-msg-view-window.c:
* (modest_msg_view_window_get_header): if the row reference is
not valid, we return NULL without warnings.
* (message_reader): now it uses a row reference instead of a
path. This way the reference is valid even after deleting
messages. This way deletion does not break the row references.
And this way after deleting a message in viewer, the next
message shown and the one you would delete are the same
(fixes NB#63937). We use now row reference for all things
related to retrieval of messages.
* src/modest-mail-operation.c:
* Minor change.
* src/modest-ui-dimming-rules.c:
* (_define_msg_view_window_dimming_state): if the header of the
message view is NULL, we don't show a warning (happens on
loading a new message to view).
pmo-trunk-r3316
Sergio Villar Senin [Mon, 17 Sep 2007 11:22:26 +0000 (11:22 +0000)]
* Added a check in a g_object_ref, now it could happen that the object is NULL in error cases
* Added a check in the new messages received, it could happen that the list is NULL when something wrong happens
pmo-trunk-r3315
Sergio Villar Senin [Mon, 17 Sep 2007 10:49:09 +0000 (10:49 +0000)]
* Fixes NB#63512, do not show the "Internal message error ...." just ignore it
pmo-trunk-r3314
Sergio Villar Senin [Fri, 14 Sep 2007 17:01:55 +0000 (17:01 +0000)]
* The connection specific SMTP accounts are added only once, because they're shared by all the account
s. Some clenanups
* I'm also commenting the function that adds them to the list of transport accounts. I do it beause this stuff is not correctly implemented and could cause SIGSEVs. See the comment in the code for more details
pmo-trunk-r3312
Jose Dapena Paz [Fri, 14 Sep 2007 13:57:24 +0000 (13:57 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now successful search changes focus to view in order to remove
the vkb (fixes NB#59519).
pmo-trunk-r3309
Philip Van Hoof [Fri, 14 Sep 2007 13:39:04 +0000 (13:39 +0000)]
Reconnecting after setting account settings
pmo-trunk-r3308
Jose Dapena Paz [Fri, 14 Sep 2007 11:42:42 +0000 (11:42 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Reenabled image replacement.
pmo-trunk-r3306
Jose Dapena Paz [Fri, 14 Sep 2007 11:35:19 +0000 (11:35 +0000)]
* src/modest-tny-send-queue.c:
* (modest_tny_send_queue_get_msg_id): Now the message id is
generated using the subject and the date received field.
This way, the id is the same in outbox and sentbox folder.
Then we can remove the message from send queue.
* (_on_msg_has_been_sent): now we set the message as seen, so
that the message is added to sent box as already readed. We
also avoid showing the information banner when the message is
not in this send queue (fixes NB#66511).
pmo-trunk-r3304
Sergio Villar Senin [Fri, 14 Sep 2007 11:06:00 +0000 (11:06 +0000)]
* Do not play a sound when new message arrives if the user does not want to
pmo-trunk-r3302
Sergio Villar Senin [Fri, 14 Sep 2007 10:01:46 +0000 (10:01 +0000)]
* Removed a duplicated method
* Fixed an error in my last commit 3298, we can not use maemo specific calls in the ui actions
* Fixes NB#67017, a dbus callback was storing a new message in the drafts even before editing it
pmo-trunk-r3299
Sergio Villar Senin [Thu, 13 Sep 2007 18:42:18 +0000 (18:42 +0000)]
* Fixes NB#63001, now we get errors if the SMTP connection fails
* Fixed a GLIB_CRITICAL in send_receive method
* Moved the send queue handlers to modest_ui_actions, makes sense because these are common for both GNOME and Maemo
* Removed some unused commented code
* Added a couple of missing calls to redraw widgets in the case that we're using a gtk version < 2.8
* Removed some wrong code, that was creating the send queues in the main window added in commit 3208
pmo-trunk-r3298
Dirk-Jan C. Binnema [Thu, 13 Sep 2007 16:21:24 +0000 (16:21 +0000)]
* use explicit tny_folder calls to get the number of (unread) messages;
apparently, the tree model is not always up-to-date.
this fixes (at least) the issue where the outbox count behaved funny
pmo-trunk-r3297
Philip Van Hoof [Thu, 13 Sep 2007 13:45:19 +0000 (13:45 +0000)]
Updated Modest to the latest Tinymail API
pmo-trunk-r3296
Dirk-Jan C. Binnema [Thu, 13 Sep 2007 12:13:15 +0000 (12:13 +0000)]
* get rid of guess_mime_type_from_name, use gnome_vfs_get_mime_from_name instead
pmo-trunk-r3295
Vivek Sekar [Thu, 13 Sep 2007 11:27:27 +0000 (11:27 +0000)]
Added fixes to changelog. week38 pre release.
pmo-trunk-r3294
Dirk-Jan C. Binnema [Thu, 13 Sep 2007 09:07:42 +0000 (09:07 +0000)]
* updated modest_platform_on_new_header_received a bit:
- use the icon 'qgn_list_messagin' for the notifications
- small cosmetic cleanup
* Fixes: NB#66798
pmo-trunk-r3292
Jose Dapena Paz [Wed, 12 Sep 2007 16:45:28 +0000 (16:45 +0000)]
* src/widgets/modest-recpt-editor.c:
* Now, if you click a resolved recipient that's already
selected, selection is dropped and cursor moves to the end
(fixes NB#64776).
* src/maemo/modest-address-book.c:
* Now check names sets the valid addresses also as resolved
addresses.
pmo-trunk-r3290
Sergio Villar Senin [Wed, 12 Sep 2007 15:07:14 +0000 (15:07 +0000)]
* Fixes NB#64132, message count in Drafts folder is now correct
* Removed some unused debug code
* Properly initialization of the variable that determines if a folder is empty or not, this was causing a "no messages to show" bug
pmo-trunk-r3289
Jose Dapena Paz [Wed, 12 Sep 2007 10:45:24 +0000 (10:45 +0000)]
* src/widgets/modest-folder-view.c:
* Added reexpand private attribute. This is enabled when there
are new folders in folder view. Then, all the available
folders are expanded at least in the first depth level. This
is instead of always expanding on map (fixes NB#65051).
* (expand_root_items): modified the method to expand the items.
Now we iterate on all the root folders until there's no next
folder, instead of only expanding on folders with children.
This way the local folders are expanded always, even when
remote root folder does not have children.
* Now we scroll to the selected cell to highlight it.
* Now we mark as selectable any new inbox folder added to the
view. This is ok as we'll be only showing one remote inbox
folder at a time.
pmo-trunk-r3284
Dirk-Jan C. Binnema [Wed, 12 Sep 2007 09:16:58 +0000 (09:16 +0000)]
* build with -fPIC for the launcher
pmo-trunk-r3283
Sergio Villar Senin [Wed, 12 Sep 2007 08:54:03 +0000 (08:54 +0000)]
* Added some checks that prevent glib criticals in some cases
pmo-trunk-r3282
Sergio Villar Senin [Tue, 11 Sep 2007 16:40:20 +0000 (16:40 +0000)]
* Removed a connect_and_wait from the mail_operations because UI code is not allowed in that part of the code. Moved it to the UI actions
* Fixed an infinite loop in on_cert_dialog_response caused by a recursive gtk_dialog_response in the handler
* Fixed a logical id
* Removed some unused debug code
* Fixes NB#62237, new notification for invalid certificates (using some previous code from djcb)
* Fixes NB#60517, the Send&Receive option in the main menu no longer freezes the progress bar
pmo-trunk-r3278
Philip Van Hoof [Tue, 11 Sep 2007 15:20:29 +0000 (15:20 +0000)]
Reverted tny_folder_sync to tny_folder_sync_async to solve 66145
pmo-trunk-r3276
Murray Cumming [Tue, 11 Sep 2007 14:20:10 +0000 (14:20 +0000)]
2007-09-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name): Set the incoming
secure-auth checkbox only when a secure auth method is really specified
in gconf. For some reason, it was set also if a secure connection was
chosen, but that does not make sense to me, and was not commented.
For instance, this stops the user from seeing an error about unsupported
secure authentication when editing a gmail account.
pmo-trunk-r3274
Jose Dapena Paz [Tue, 11 Sep 2007 12:05:25 +0000 (12:05 +0000)]
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
* Now countries ellipsize if required to prevent cutting
caption labels.
* src/maemo/easysetup/modest-easysetup-wizard.c:
* CHange all labels to expand and wrap correctly (fixes
NB#63507).
* Add scrolled window to incoming page.
* Add all pages to notebook with expand and fill properties
enabled.
pmo-trunk-r3269
Jose Dapena Paz [Tue, 11 Sep 2007 09:17:43 +0000 (09:17 +0000)]
* src/modest-dimming-rules-group.[ch]:
* Added new method modest_dimming_rules_group_add_widget_rule.
This method connects a dimming rule to a widget in the group,
so that we can connect rules to widgets outside an ui manager.
* Refactored some code to add rules to the dimming rules group
from the methods add_rules and add_widget_rule.
* src/modest-dimming-rule.[ch]:
* Now dimming rules can be connected to widgets, not only to
ui manager action paths.
* Added new methods for getting the action path and connected
widget from outside.
* src/gnome/modest-main-window.c:
* Adapted to change in in modest_main_window_get_child_widget
type.
* src/widgets/modest-msg-edit-window.h:
* Added method modest_msg_edit_window_get_child_widget to access
editor widgets from external methods (in particular from
ui dimming rules).
* Added methods to get can-undo and can-redo status.
* src/widgets/modest-msg-edit-window-ui.h:
* Added ui action handlers for menu parents, so that we can run
dimming rules.
* src/widgets/modest-main-window.h:
* Changed modest_main_window_get_child_widget types to have a
proper namespace (instead of MODEST_WIDGET_TYPE_* now we have
MODEST_MAIN_WINDOW_WIDGET_TYPE_*).
* src/modest-ui-actions.[ch]:
* Adapted calls to modest_main_window_get_child_widget new api.
* Added new method modest_ui_actions_on_format_menu_activated,
to run the dimming rules on showing the format menu.
* src/dbus_api/modest-dbus-callback.c:
* Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-msg-edit-window.c:
* Removed insensitive handlers, as now they're managed in
dimming manager. In particular, we remove methods
send_insensitive_press, style_insensitive_press,
setup_insensitive_handlers.
* Added "move-cursor" signal handler subject_field_move_cursor.
This is required because moving cursor in a way that drops
selection in a GtkEntry does not change primary clipboard
selection.
* Removed methods to update dimming status, as this is now
managed in dimming manager. In particular we drop
update_dimmed, update_paste_dimming,
update_remove_attachment_dimming, update_copy_cut_dimming,
update_select_all_dimming, update_zoom_dimming,
update_send_dimming.
* Also removed methods to handle menu activation, as this is now
handled in the ui manager.
* Added methods to get the can_undo and can_redo status. This is
updated through signal handlers of wptextbuffer, as this does
not provide a method to check this on real time.
* Added signal handler for owner change in default clipboard
(required to manage properly paste dimming).
* Now we use dimming rules for toolbar, menus and clipboard
based actions. We also use specific dimming rule binding for
the widgets that we don't get from ui manager (font size and
face selection, color selection).
* Implementation of new method
modest_msg_edit_window_get_child_widget, to access children
from outside (in particular from dimming rules).
* src/maemo/modest-platform.c:
* Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-msg-view-window.c:
* Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-main-window.c:
* Adapted calls to modest_main_window_get_child_widget new api.
* src/modest-ui-dimming-rules.[ch]:
* Adapted calls to modest_main_window_get_child_widget new api.
* (..._on_select_all): added implementation for editor widget.
* (..._on_undo): added implementation for editor widget.
* New dimming rule ..._on_redo.
* New dimming rule ..._on_set_style, for style operations of
message editor.
* New dimming rule ..._on_zoom for editor (we can only zoom
when focus is on body).
* New dimming rule ..._on_editor_paste. This operation depends
on clipboard, so it cannot be hooked in menu activation
methods.
* New dimming rule ..._on_editor_remove_attachment for editor.
* New dimming rule ..._on_send for editor.
* Added support in _invalid_clipboard_selected for editor.
pmo-trunk-r3264