Dirk-Jan C. Binnema [Sat, 21 Apr 2007 18:26:48 +0000 (18:26 +0000)]
* make the header icon hack somewhat work for maemo too
pmo-trunk-r1627
Dirk-Jan C. Binnema [Sat, 21 Apr 2007 18:26:04 +0000 (18:26 +0000)]
* cleaned up the header render code a bit
pmo-trunk-r1626
Dirk-Jan C. Binnema [Sat, 21 Apr 2007 10:30:51 +0000 (10:30 +0000)]
* fixed some logical-ids
pmo-trunk-r1625
Dirk-Jan C. Binnema [Sat, 21 Apr 2007 09:56:21 +0000 (09:56 +0000)]
* try /etc/hostname for the local device name as initial guess
if there's a bluetooth name (used as the n800 device name), that one
will replace the initial guess later during startup, but e.g.
in scratchbox, the initial guess remains
pmo-trunk-r1624
Dirk-Jan C. Binnema [Sat, 21 Apr 2007 08:59:01 +0000 (08:59 +0000)]
* cleanup: moved init stuff to modest-init.[ch]
* cleanup: removed the tny test account stuff; it's not needed anymore
as the account setup works
* add some sanity checks to make sure runtime/init/singletons are really only
started once
* fixed the appname problem: g_set_application_name should be called *after* gtk_init
* made appname platform specific; for product we will call it "Email", otherwise it will be knows as "modest"
pmo-trunk-r1623
Javier Fernandez Garcia-Boente [Fri, 20 Apr 2007 20:32:25 +0000 (20:32 +0000)]
* Add 64 pixel icons for priority/attachment flag column.
* Remove old code about pango conversion, because an optimized
method is defined in modest-text-utils.c.
pmo-trunk-r1622
Dirk-Jan C. Binnema [Fri, 20 Apr 2007 18:56:39 +0000 (18:56 +0000)]
* replace the _pango functions with modest_text_utils_convert_to_pango,
which require fewer string copies.
pmo-trunk-r1621
Sergio Villar Senin [Fri, 20 Apr 2007 17:49:47 +0000 (17:49 +0000)]
* First implementation of Root folders view
pmo-trunk-r1620
Murray Cumming [Fri, 20 Apr 2007 17:36:14 +0000 (17:36 +0000)]
remove duplicate .po entry
pmo-trunk-r1619
Murray Cumming [Fri, 20 Apr 2007 17:27:36 +0000 (17:27 +0000)]
2007-04-20 Murray Cumming <murrayc@murrayc.com>
* po/en_GB.po:
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_custom_outgoing), (create_page_complete_custom):
* src/maemo/modest-account-settings-dialog.c:
(create_page_user_details), (create_page_outgoing):
* src/maemo/modest-account-view-window.c: (button_box_new):
Use changed logical IDs as per the most recent UI spec:
mcen_bd_emailsetup_edit -> mcen_bd_edit
mcen_bd_emailsetup_delete -> mcen_bd_delete
mcen_bd_emailsetup_close -> mcen_bd_close
pmo-trunk-r1618
Javier Fernandez Garcia-Boente [Fri, 20 Apr 2007 17:17:36 +0000 (17:17 +0000)]
* Change priority managment logic, using HIGH flags
as priority mask, and then compare it with = operator.
pmo-trunk-r1617
Murray Cumming [Fri, 20 Apr 2007 17:16:07 +0000 (17:16 +0000)]
2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
* configure.ac:
* src/Makefile.am:
* src/dbus_api/Makefile.am:
* src/dbus_api/modest-dbus-callbacks.c:
* src/dbus_api/modest-dbus-callbacks.h:
* src/maemo/modest-platform.c: (modest_platform_init):
Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
method.
* tests/Makefile.am:
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
pmo-trunk-r1616
Jose Dapena Paz [Fri, 20 Apr 2007 17:14:38 +0000 (17:14 +0000)]
* src/gnome/modest-msg-edit-window.c:
* Added stub implementation of ...set_file_format.
pmo-trunk-r1615
Jose Dapena Paz [Fri, 20 Apr 2007 16:52:34 +0000 (16:52 +0000)]
* src/modest-ui-actions.[ch]:
* Action to select contacts in editor to add to a recipient
list.
* src/maemo/modest-msg-edit-window.c:
* Dim font attribute actions depending on rich text disabled.
* Dim Undo when required.
* Make add attachment button non focusable.
* Add open addressbook handler for buttons in Cc: and Bcc:
recipients lists.
* Fix a warning because the action name of the send toolbar
button was not correct in the method that expands it.
* Update the file format (formatted/plain) on undo, as it can
be changed.
* (Added modest_msg_edit_window_select_contacts): method that
shows select contacts dialog for focused recipient list (or
To: recipient list if no recipient list focused).
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added SelectContacts menu action.
* src/gnome/modest-msg-edit-window.c:
* Removed non used code about zooming.
* Removed duplicated set_priority_flags stub code.
* Added stub implementation for ...select_contacts method.
* src/widgets/modest-mail-header-view.c:
* Now field name labels align to right.
* src/widgets/modest-msg-edit-window.h:
* Added ..._select_contacs method.
* src/widgets/modest-recpt-editor.c:
* Now the widget is focusable.
* src/widgets/modest-msg-edit-window-ui.h:
* Added email menu, and select contacts action.
pmo-trunk-r1614
Jose Dapena Paz [Fri, 20 Apr 2007 13:54:54 +0000 (13:54 +0000)]
* src/modest-ui-actions.[ch]:
* (..._on_undo): Add UI action for undo, with implementation for
editor.
* (..._msg_edit_on_change_file_format): Added UI action to
handle changes in editor file format
* (..._on_select_font): Added UI action to rise font dialog
and update editor font with it.
* src/maemo/modest-msg-edit-window.c:
* Replaced static strings of icons with icons in
modest-icon-names.h.
* Use logical id's
* Set translation domain of menu to make translation work.
* Add radio action group for choosing file format.
* Send mail in plain text or rich format depending on the
file format selection.
* (..._set_file_format): new method to change the file format
between plain and formatted text. If the change is from
formatted text to plain text, it shows a warning about losing
format.
* (..._select_font): new method to change the font attributes
through the Maemo generic dialog. It shows the dialog and then
updates the currently applied attributes.
* (..._undo): new method to undo last change in body.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added Undo menu option.
* Added show toolbar toggles.
* Corrected order of menus.
* Removed format menu options not present in UI specs
(background color).
* Now there's a new send toolbar action, to make menu action not
show the icon.
* src/modest-defs.h:
* Added definitions for file format options.
* src/gnome/modest-msg-edit-window.c:
* Added more stub implementations for actions present in
Maemo client.
* src/widgets/modest-msg-edit-window.h:
* New actions for Maemo client (undo, set_file_format,
select_font).
* src/widgets/modest-msg-edit-window-ui.h:
* Use logical-id's
* Added ToolbarSend, separate from ActionSend.
* New actions for selecting font, file format and undo.
* src/modes-tny-msg.c:
* Changed the order of alternate to put html part after pplain
text part for mails with rich text. This makes evolution
choose the correct format.
pmo-trunk-r1613
Javier Fernandez Garcia-Boente [Fri, 20 Apr 2007 12:42:56 +0000 (12:42 +0000)]
* Add two new columns to show compact Sent/Received date. This change
was required to keep compatibility with 1-row style view.
* Change configuration header setting to load new compact columns.
* Use strftime to build date/time strings.
* Parse special character in subjects and mail addresses for allowing
pango markup tags to format two style rows view.
pmo-trunk-r1612
Murray Cumming [Fri, 20 Apr 2007 10:44:35 +0000 (10:44 +0000)]
2007-04-20 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/modest-connection-specific-smtp-edit-window.c:
Removed unnecessary includes.
pmo-trunk-r1611
Murray Cumming [Fri, 20 Apr 2007 10:42:16 +0000 (10:42 +0000)]
2007-04-20 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* src/widgets/Makefile.am:
* src/widgets/modest-easysetup-secureauth-combo-box.c:
* src/widgets/modest-easysetup-secureauth-combo-box.h:
* src/widgets/modest-easysetup-serversecurity-combo-box.c:
* src/widgets/modest-easysetup-serversecurity-combo-box.h:
* src/widgets/modest-secureauth-combo-box.c:
* src/widgets/modest-secureauth-combo-box.h:
* src/widgets/modest-serversecurity-combo-box.c:
* src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
made the GObject names more consistent with the rest of the Modest code.
pmo-trunk-r1610
Murray Cumming [Fri, 20 Apr 2007 10:30:11 +0000 (10:30 +0000)]
2007-04-20 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/Makefile.am:
* src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
* src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
* src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
* src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/easysetup/modest-validating-entry.c:
* src/maemo/easysetup/modest-validating-entry.h:
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
widgets/ because they are used outside of easysetup too. After checking in,
svn will allow me to rename them too.
pmo-trunk-r1609
Murray Cumming [Fri, 20 Apr 2007 10:04:43 +0000 (10:04 +0000)]
2007-04-20 Murray Cumming <murrayc@murrayc.com>
* src/gnome/modest-msg-edit-window.c:
(modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
linker error, to fix the build on the GNOME platform.
modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
ifdefed out to avoid a warning.
pmo-trunk-r1608
Murray Cumming [Fri, 20 Apr 2007 09:07:09 +0000 (09:07 +0000)]
2007-04-20 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
some alternative for GTK+ 2.6.
pmo-trunk-r1607
Sergio Villar Senin [Fri, 20 Apr 2007 07:55:32 +0000 (07:55 +0000)]
* Do not scroll the header view if the row is already shown
pmo-trunk-r1604
Dirk-Jan C. Binnema [Fri, 20 Apr 2007 06:05:00 +0000 (06:05 +0000)]
* check the result of modest_account_mgr_get_from_string
(so we won't crash when are no accounts defined yet)
pmo-trunk-r1603
Dirk-Jan C. Binnema [Fri, 20 Apr 2007 06:03:39 +0000 (06:03 +0000)]
* fix some logical ids
* leave 'X-OSSO-Service' empty in the desktop file (temp fix),
to stop from being killed (this can be reenabled once dbus-support is added)
pmo-trunk-r1602
Dirk-Jan C. Binnema [Fri, 20 Apr 2007 06:01:05 +0000 (06:01 +0000)]
* replace 'Wating...' with logical id
pmo-trunk-r1601
Dirk-Jan C. Binnema [Thu, 19 Apr 2007 18:29:50 +0000 (18:29 +0000)]
* fix for broken en_GB.po
pmo-trunk-r1600
Javier Fernandez Garcia-Boente [Thu, 19 Apr 2007 17:41:38 +0000 (17:41 +0000)]
* Use strftime function instead of GDate to build string
dates and time values.
pmo-trunk-r1599
Sergio Villar Senin [Thu, 19 Apr 2007 17:27:18 +0000 (17:27 +0000)]
* Added MMC icon
pmo-trunk-r1598
Sergio Villar Senin [Thu, 19 Apr 2007 17:20:45 +0000 (17:20 +0000)]
* Added a missing include
pmo-trunk-r1597
Murray Cumming [Thu, 19 Apr 2007 14:34:36 +0000 (14:34 +0000)]
2007-04-19 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-address-book.c: Added include to avoid a warning.
* po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
specified for EmailAccountsDialog in UI spec.
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/easysetup/modest-easysetup-wizard.h:
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/modest-account-settings-dialog.h:
Reuse a member window widget for the connection-specific SMTP server accounts,
so we can tell it to create/save the accounts only if we actually save changes.
* src/maemo/modest-connection-specific-smtp-edit-window.h:
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_get_settings):
Return a struct instance for temporarily remembering the entered data.
* src/maemo/modest-connection-specific-smtp-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_finalize),
(modest_connection_specific_smtp_window_fill_with_connections),
(on_button_edit),
(modest_connection_specific_smtp_window_save_server_accounts),
(update_model_server_names): Do not actually save data until asked,
when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
(on_selection_changed),
(modest_connection_specific_smtp_window_init): Disable the edit
button when nothing is selected.
* src/modest-account-mgr-helpers.c:
* src/modest-account-mgr-helpers.h:
Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
elsewhere.
pmo-trunk-r1596
Sergio Villar Senin [Thu, 19 Apr 2007 12:28:15 +0000 (12:28 +0000)]
* Rewritten main window title handling
* Removed some unused fields
* Changed the signature of modest_folder_view_get_selected
pmo-trunk-r1595
Jose Dapena Paz [Thu, 19 Apr 2007 11:01:55 +0000 (11:01 +0000)]
* src/modest-address-book.h:
* Now modest_address_book_select_addresses adds the selected
addresses to the ModestRecptEditor instead of returning them.
* src/maemo/modest-address-book.c:
* Implementation of the new ..._select_addresses method. This
uses the osso abook api to retrieve addresses from device
addressbook.
* src/gnome/modest-address-book.c:
* Updated the stub functions to conform the new API.
* src/widgets/modest-msg-edit-window.h:
* New method for setting priorities from ui actions.
* src/widgets/modest-msg-edit-window-ui.h:
* Added actions for handling priorities.
* src/widgets/modest-combo-box.c:
* Set the widget to ellipsize.
* Make selected options expand in the available space.
* src/widgets/modest-recpt.editor.[ch]:
* Added "open-addressbook" signal, for attaching handlers to the
addressbook button click.
* Added new add_recipients method, that adds a non resolved
recipient to the recipient list.
* Added new add_resolved_recipient method, that gets a list of
resolved recipients with an ID. It adds them underlined, and
with a specific tag id.
* Now recipient adders add the recipients one per line, adding
\n. It also returns the recipients with the \n characters
filtered.
* Now it uses the ModestScrollText to support scroll line by
line limited to 5 lines.
* src/widgets/modest-scroll-text.c:
* Fixed a bug, that moved the cursor to the start every time
the embedded text view changed its contents.
* Correct the size request to take into account the shadow of
the scroll.
* src/widgets/modest-attachments-view.[ch]:
* Refactored to create a new add_attachment method. It's used
to add new attachments to the list one by one, and in the
existing modest_attachments_view_set_message.
* src/maemo/modest-msg-edit-window.c:
* Added handler for "open-addressbook" signal in To: recipients
editor. It calls the addressbook corresponding method.
* Added handling of priority flags (added menu to change the
mail priority, priority icon to the left of the subject,
and sending mails with the priority field).
* Added "add attachment" button to the right of subject. No
functionality yet.
* Added frame to the body editor.
* Use HildonScrollArea to implement full view scroll.
* Added attachments view, using ModestAttachmentsView. Also
added code to update the view when new images are added.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added priority handling menu options.
* src/modest-ui-actions.[ch]:
* (added modest_ui_action_msg_edit_on_change_priority): action
to handle priority radio buttons change in editor.
* (modest_ui_actions_on_send): added handling for priority
field.
* src/modest-account-mgr-helpers.c:
* Added minor fixes to avoid warnings (GSList method called
without assigning their result).
* src/modest-mail-operation.[ch]:
* Now ..._send_new_mail method receives also the required
priority for the mail.
* src/modest-main.c:
* Small change to use the new priority parameter in
_send_new_mail method with default value in CLI invokation.
pmo-trunk-r1594
Murray Cumming [Thu, 19 Apr 2007 09:25:27 +0000 (09:25 +0000)]
2007-04-19 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_unused_account_name),
(modest_account_mgr_get_unused_account_display_name): Added these
utility functions, to avoid code duplication.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_account_details), (create_account):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(on_combo_security_changed),
(modest_connection_specific_smtp_edit_window_init),
(modest_connection_specific_smtp_edit_window_save_settings):
* src/maemo/modest-connection-specific-smtp-edit-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_finalize),
(modest_connection_specific_smtp_window_fill_with_connections),
(on_button_edit), (modest_connection_specific_smtp_window_init):
* src/maemo/modest-connection-specific-smtp-window.h:
Implementing saving of connection-specific server accounts.
But I need to refactor this so we can save the data for each
possible connection-specific account and only actually create the server accounts
when the easysetup finished, or the OK button is pressed on the account settings
dialog.
pmo-trunk-r1593
Murray Cumming [Wed, 18 Apr 2007 18:51:24 +0000 (18:51 +0000)]
2007-04-18 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(on_combo_security_changed):
(modest_connection_specific_smtp_edit_window_init):
Auto-fill the port number as in the account settings.
(modest_connection_specific_smtp_edit_window_set_connection):
* src/maemo/modest-connection-specific-smtp-edit-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(fill_with_connections), (on_button_edit),
(modest_connection_specific_smtp_window_init):
Turn the edit window into a dialog to simplify the code, and
set a WM hint as in a GtkDialog, because only a popup can be on top of
another window in Maemo, and popups usually have no WM decoration.
* src/modest-defs.h:
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_set_connection_specific_smtp),
(modest_account_mgr_remove_connection_specific_smtp),
(modest_account_mgr_get_connection_specific_smtp):
* src/modest-account-mgr-helpers.h: Some functions to write the
connection-specific SMTP server information. Not yet used.
pmo-trunk-r1592
Sergio Villar Senin [Wed, 18 Apr 2007 17:58:27 +0000 (17:58 +0000)]
* Added MMC icon name
* Added proper window title visualization of current folder
* Added MMC and device icons to the folder view
* Added MMC and device names to the folder view
pmo-trunk-r1591
Sergio Villar Senin [Wed, 18 Apr 2007 17:03:54 +0000 (17:03 +0000)]
* Removed the ^M end of line characters
pmo-trunk-r1590
Javier Fernandez Garcia-Boente [Wed, 18 Apr 2007 16:34:24 +0000 (16:34 +0000)]
* Change display format of dates and time.
pmo-trunk-r1589
Javier Fernandez Garcia-Boente [Wed, 18 Apr 2007 16:11:19 +0000 (16:11 +0000)]
* Changes in headers list rows layout:
- set fixed width to Sent/Received date column
- change font settings
pmo-trunk-r1588
Dirk-Jan C. Binnema [Wed, 18 Apr 2007 14:18:48 +0000 (14:18 +0000)]
updated english translation file
pmo-trunk-r1587
Murray Cumming [Wed, 18 Apr 2007 12:41:31 +0000 (12:41 +0000)]
2007-04-18 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
Added connect_for_modified() utility function to mark the new modified boolean.
(create_page_account_details), (create_page_user_details),
(create_page_incoming), (create_page_outgoing), (on_response),
(modest_account_settings_dialog_init),
(modest_account_settings_dialog_set_account_name):
Only warn about unsaved changes when there are actually unsaved changes.
* src/modest-account-mgr-helpers.c:
* src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
into the ModestServerAccountData struct. I do not use it yet, but someone might expect
to get the data from there in future.
pmo-trunk-r1585
Sergio Villar Senin [Wed, 18 Apr 2007 12:32:06 +0000 (12:32 +0000)]
* First review of ModestFolderView visual names for folders
* Added the device name management to folder view
pmo-trunk-r1584
Murray Cumming [Wed, 18 Apr 2007 12:06:49 +0000 (12:06 +0000)]
2007-04-18 Murray Cumming <murrayc@murrayc.com>
* src/modest-defs.h:
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Store the security account setting in a single conf key instead of using
the options list, so that the list is left for just the to-be-removed camel hack,
and because gconf_client_set_list() is failing for some reason.
* src/modest-account-mgr.c:
(modest_account_mgr_add_server_account):
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name),
(save_configuration): Use the renamed functions.
pmo-trunk-r1583
Sergio Villar Senin [Wed, 18 Apr 2007 10:46:51 +0000 (10:46 +0000)]
* Fixed a bug when the model is empty
pmo-trunk-r1582
Murray Cumming [Wed, 18 Apr 2007 10:10:37 +0000 (10:10 +0000)]
2007-04-18 Murray Cumming <murrayc@murrayc.com>
* src/widgets/Makefile.am:
* src/widgets/modest-limit-retrieve-combo-box.c:
* src/widgets/modest-limit-retrieve-combo-box.h:
* src/widgets/modest-retrieve-combo-box.c:
* src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
the account settings dialog.
* src/modest-defs.h:
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
(modest_server_account_get_option_secure_auth),
(modest_server_account_set_option_secure_auth):
* src/modest-account-mgr.c:
(modest_account_mgr_add_server_account):
Use the existing AUTH_MECH conf key for the secure-auth setting,
instead of putting it in the list options, because this was actually used already.
* src/maemo/modest-account-settings-dialog.c:
(create_page_account_details),
(modest_account_settings_dialog_set_account_name),
(save_configuration):
* src/maemo/modest-account-settings-dialog.h:
Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
pmo-trunk-r1581
Sergio Villar Senin [Wed, 18 Apr 2007 09:49:30 +0000 (09:49 +0000)]
* Added hardware key navigation
pmo-trunk-r1580
Murray Cumming [Wed, 18 Apr 2007 08:30:27 +0000 (08:30 +0000)]
2007-04-18 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
* src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
* src/modest-defs.h:
* src/maemo/modest-account-settings-dialog.c:
(create_page_incoming), (on_combo_outgoing_security_changed),
(on_combo_incoming_security_changed), (create_page_outgoing),
(modest_account_settings_dialog_set_account_name),
(save_configuration): Load/Save the port number, and change it when the
security combo changes, to suitable defaults.
pmo-trunk-r1579
Sergio Villar Senin [Wed, 18 Apr 2007 07:22:01 +0000 (07:22 +0000)]
* Added preliminar code to support send and receive from the toolbar menu
pmo-trunk-r1578
Javier Fernandez Garcia-Boente [Tue, 17 Apr 2007 20:52:56 +0000 (20:52 +0000)]
* Change headers list tree view rows layout (flags, header, date).
* Use pango markup to set width and size font settings.
* Add a new compact flag column to show priority/attachment data.
* Enable multiple selection on headers list tree view.
* Change header settings in runtime configuration.
* Add 5 new icons to show all combinations of priority/attachment values.
pmo-trunk-r1577
Dirk-Jan C. Binnema [Tue, 17 Apr 2007 19:04:00 +0000 (19:04 +0000)]
add conic to PKG_CHECK_MODULES
pmo-trunk-r1576
Murray Cumming [Tue, 17 Apr 2007 16:49:15 +0000 (16:49 +0000)]
2007-04-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c:
(modest_account_mgr_add_server_account): Set the security and secure-auth
options, and add a comment saying that the other camel-specific options should be
removed in future.
pmo-trunk-r1575
Dirk-Jan C. Binnema [Tue, 17 Apr 2007 13:57:59 +0000 (13:57 +0000)]
* use the new TnyMaemoConicDevice
pmo-trunk-r1574
Murray Cumming [Tue, 17 Apr 2007 13:53:46 +0000 (13:53 +0000)]
2007-04-17 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
found by valgrind.
* src/modest-tny-account-store.c: (account_list_free),
(on_account_changed): Add a TODO comment about a valgrind error, caused by using
cursor->data after unreffing it. But there is some strange stuff there so it might not be
easy to fix.
pmo-trunk-r1573
Murray Cumming [Tue, 17 Apr 2007 13:34:43 +0000 (13:34 +0000)]
2007-04-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-protocol-info.c:
* src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
is required by our UI spec. Maybe something in our implementation will use this eventually.
* src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
(easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
instead of the previous 0 placeholder.
* src/modest-defs.h: Added gconf list pair key names and value strings for the security and
secure-auth settings.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
(modest_server_account_data_get_option_secure_auth),
(modest_server_account_set_option_secure_auth),
(modest_server_account_data_get_option_security),
(modest_server_account_set_option_security): Added this API for getting and setting the security
and secure-auth settings.
* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_finalize), (check_data),
(on_response): Store the original title as well as the name, to avoid unnececessary warnings
about changing titles.
(modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
(save_configuration): Save the security and secure-auth settings.
* src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
pmo-trunk-r1572
Dirk-Jan C. Binnema [Tue, 17 Apr 2007 13:01:24 +0000 (13:01 +0000)]
fix link failures in tests/
pmo-trunk-r1571
Murray Cumming [Tue, 17 Apr 2007 09:22:05 +0000 (09:22 +0000)]
2007-04-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-defs.h:
* src/modest-account-mgr.c:
(modest_account_mgr_add_server_account):
Added and used defines for the options key and value pair strings,
that are used so far, though they do not seem to correspond to anything in our
UI specs or ModestProtocol enum.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
(compare_option_strings_for_name),
(modest_server_account_data_get_option_value),
(modest_server_account_data_get_option_bool),
(modest_account_mgr_get_server_account_option):
Added helper functions for parsing the options GSList.
pmo-trunk-r1570
Sergio Villar Senin [Tue, 17 Apr 2007 07:44:25 +0000 (07:44 +0000)]
* Replaced a duplicated action name in the msg window
pmo-trunk-r1569
Murray Cumming [Mon, 16 Apr 2007 18:23:01 +0000 (18:23 +0000)]
Attempt to commit. See ChangeLog2
pmo-trunk-r1568
Murray Cumming [Mon, 16 Apr 2007 13:26:17 +0000 (13:26 +0000)]
2007-04-16 Murray Cumming <murrayc@murrayc.com>
* po/en_GB.po: Added needed logical ID and translation.
* src/widgets/modest-account-view.c: (on_account_default_toggled),
(init_view): Made the is-default column clicking work.
pmo-trunk-r1567
Murray Cumming [Mon, 16 Apr 2007 12:19:50 +0000 (12:19 +0000)]
2007-04-16 Murray Cumming <murrayc@murrayc.com>
* configure.ac:
* src/maemo/easysetup/Makefile.am:
* src/maemo/easysetup/modest-easysetup-wizard.c:
(modest_easysetup_wizard_dialog_init):
* src/maemo/easysetup/provider-data-test.keyfile:
* src/maemo/easysetup/provider-data.keyfile:
Moved the provider data file to the new modest-providers-data package and used it from there.
pmo-trunk-r1565
Murray Cumming [Mon, 16 Apr 2007 10:49:53 +0000 (10:49 +0000)]
modest-providers-data directory added.
pmo-trunk-r1563
Sergio Villar Senin [Mon, 16 Apr 2007 07:00:46 +0000 (07:00 +0000)]
2007-04-16 Sergio Villar Senin <svillar@igalia.com>
* Fixed compilation error
pmo-trunk-r1562
Sergio Villar Senin [Sun, 15 Apr 2007 11:32:49 +0000 (11:32 +0000)]
2007-04-15 Sergio Villar Senin <svillar@igalia.com>
* Fixed the issue with the reply button popup
* Removed create_toolbar virtual method
* Fixed the GTK_STOCK_FULLSCREEN double definition in GNOME
* Replaced the hildon_window_toolbar_add/remove by gtk_widget_show/remove functions
pmo-trunk-r1561
Dirk-Jan C. Binnema [Sat, 14 Apr 2007 10:50:00 +0000 (10:50 +0000)]
small compile fixes
pmo-trunk-r1560
Sergio Villar Senin [Fri, 13 Apr 2007 17:15:12 +0000 (17:15 +0000)]
* Added simple/split view mode persistence for ModestMainWindow
pmo-trunk-r1559
Sergio Villar Senin [Fri, 13 Apr 2007 16:38:40 +0000 (16:38 +0000)]
* Added application wide toolbars to the pending windows
pmo-trunk-r1558
Sergio Villar Senin [Fri, 13 Apr 2007 13:12:06 +0000 (13:12 +0000)]
* Added show toolbar application wide code
* Added show toolbar code to main window (msgview and msgeditor pending)
pmo-trunk-r1557
Jose Dapena Paz [Fri, 13 Apr 2007 09:16:27 +0000 (09:16 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Replaced the toolbar font size combobox with a completely new
button fitting better the specs.
* Also replaced the font face selector. Now it previews the font
in the combo and in the button.
* Changed the recipient buttons, to use the new
ModestRecptEditor widget.
* Unref the labels size group when it's initialized to avoid a
leak.
* Added size group for all the entry fields.
* Policy for horizontal scrollbar in scrolled window set to
never.
* Changed placeholder positions to put font color at the end and
font size and face at the beginning.
* Added expand and homogeneous properties to all buttons in
toolbar.
* Removed bullet list toolbar button.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added independent place holders for font color and font
attributes (size and face).
* src/widgets/modest-msg-edit-window-ui.h:
* Updated the zoom +/- actions to call modest ui actions instead
of private methods in edit window.
* Added src/widgets/modest-recpt-editor.[ch]:
* New widget to edit a list of recipients. It will be used to
implement the specific UI interactions and addressbook
integration expected in clients.
* It shows an addressbook button that will be used for
opening the addressbook and adding addresses to the recipient
list.
* It's work-in-progress
* src/widgets/Makefile.am:
* Added ModestRecptEditor to compilation.
pmo-trunk-r1556
Sergio Villar Senin [Fri, 13 Apr 2007 09:02:57 +0000 (09:02 +0000)]
* Added the proper icon to each window
* Replaced the Modest icon in the desktop file
pmo-trunk-r1555
Sergio Villar Senin [Thu, 12 Apr 2007 17:55:36 +0000 (17:55 +0000)]
* Added toggle actions for show toolbars
* Replaced some action names
pmo-trunk-r1554
Sergio Villar Senin [Thu, 12 Apr 2007 15:55:58 +0000 (15:55 +0000)]
* Fixed some compilation problems in GNOME
pmo-trunk-r1553
Dirk-Jan C. Binnema [Thu, 12 Apr 2007 14:35:21 +0000 (14:35 +0000)]
* it's SPLIT not SPLITTED :-)
pmo-trunk-r1552
Dirk-Jan C. Binnema [Thu, 12 Apr 2007 14:29:57 +0000 (14:29 +0000)]
* when removing an account, also remove the corresponding server_accounts
pmo-trunk-r1551
Sergio Villar Senin [Thu, 12 Apr 2007 12:59:24 +0000 (12:59 +0000)]
* Added simple view mode for main window
* Fixed an issue with an include file
pmo-trunk-r1550
Jose Dapena Paz [Thu, 12 Apr 2007 11:32:24 +0000 (11:32 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Implemented support for ModestWindow zoom_minus and zoom_plus
virtual methods, replacing the previous minus/plus methods.
* Take into account window manager API in window-state-event
handler.
* src/widgets/modest-msg-edit-window-ui.h:
* Updated the zoom +/- actions to call modest ui actions instead
of private methods in edit window.
pmo-trunk-r1549
Jose Dapena Paz [Thu, 12 Apr 2007 11:13:11 +0000 (11:13 +0000)]
* src/modest-ui-actions.[ch]:
* Refactored and reworked fullscreen methods to use the
new modest_window_mgr methods.
* New Zoom plus and Zoom minus action handlers using the new
ModestWindow zooming interfaces.
* Added handlers for toggle actions "Show Cc:" and "Show Bcc:".
* src/maemo/modest-main-window-ui.h:
* Put zoom actions in main window action list.
* Use the new fullscreen actions interface.
* src/maemo/modest-msg-edit-window.ch:
* Implement the ModestWindow set_zoom and get_zoom interfaces.
Added menu actions for switching among different zoom levels.
* Implement full view scroll of the editor. Now it includes
the headers in the scrollable area. It uses the mark_set
event handler of the body GtkTextView, to update the scroll
current value.
* Replaced buttons and labels form header fields with
HildonCaption, to fit UI specs (and make the UI more usable).
* Added autocap setters.
* Max length of the subject field is now 1000 characters.
* Support for fullscreen modes (not ended yet).
* If To: field is empty on setting a new message to edit, it's
the field to take focus. If not, focus goes to body editor.
* Added zoom plus and minus key shortcuts.
* Implemented showing/hiding Cc: and Bcc: fields depending on
the selected menu option.
* src/maemo/modest-main-window.[ch]:
* Replaced radio menu options for fullscreen modes with a
toggle.
* Added support for the new window manager fullscreen management
API and behavior.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added zoom levels to menu.
* Added fullscreen toggle to menu.
* Added key accelerators for zoom and fullscreen.
* src/maemo/ui/modest-main-window-ui.xml:
* Added key accelerator for fullscreen.
* Now it uses the fullscreen toggle instead of radio menu items.
* src/maemo/modest-msg-view-window.c:
* Use the new zooming api available in ModestMsgWindow. Add
fullscreen state code to modify the status of the fullscreen
toggle action.
* src/gnome/modest-msg-edit-window.c:
* Added some stubs for newly implemented functionality in maemo
client. Anyway, there may be missing ones to compile in gnome.
* src/widgets/modest-msg-edit-window.h:
* Added new methods for toggling Cc: and Bcc: fields.
* Added interface for toggling fullscreen status.
* src/widgets/modest-window-mgr.[ch]:
* Added method for getting the current fullscreen status.
* src/widgets/modest-window.[ch]:
* Added interface methods for working with zoom (set/get, and
minus/plus). Added also default empty implementations.
* src/widgets/modest-msg-view-window.h:
* Added toggle fullscreen method.
* src/widgets/modest-msg-edit-window-ui.h:
* Added zoom support menu options.
* Added fullscreen toggle menu option
* Updated the Cc: and Bcc: field toggles, and removed the To:
toggle.
* Added key accelerator actions for zoom and fullscreen.
pmo-trunk-r1548
Sergio Villar Senin [Wed, 11 Apr 2007 17:30:15 +0000 (17:30 +0000)]
* Added code to handle fullscreen mode for the whole application
* Added ModestWindowMgr code
* Added automatic mail operation canceling when closing
* Added closing dialog MSG-NOT308
pmo-trunk-r1547
Dirk-Jan C. Binnema [Wed, 11 Apr 2007 12:00:44 +0000 (12:00 +0000)]
build fixes for maemo
pmo-trunk-r1546
Dirk-Jan C. Binnema [Wed, 11 Apr 2007 11:38:47 +0000 (11:38 +0000)]
build fixes for gnome
pmo-trunk-r1545
Jose Dapena Paz [Wed, 11 Apr 2007 11:11:46 +0000 (11:11 +0000)]
* src/maemo/modest-msg-view-window.c:
* Remove gtk_window_add_accel_group as it wasn't really needed
to attach actions. Should remove a runtime warning.
pmo-trunk-r1544
Jose Dapena Paz [Wed, 11 Apr 2007 10:57:51 +0000 (10:57 +0000)]
* src/maemo/modest-main-window-ui.h:
* Readded add to contacts action, that's different from
"contacts..." action.
* Removed accel actions for up and down, as this is now handled
internally through key events.
pmo-trunk-r1543
Sergio Villar Senin [Wed, 11 Apr 2007 10:06:32 +0000 (10:06 +0000)]
* Removed some files
pmo-trunk-r1542
Dirk-Jan C. Binnema [Wed, 11 Apr 2007 09:53:43 +0000 (09:53 +0000)]
* build fixes for Bora
pmo-trunk-r1541
Jose Dapena Paz [Wed, 11 Apr 2007 08:01:59 +0000 (08:01 +0000)]
* Removed --enable-debug (added with error in previous commit)
pmo-trunk-r1540
Jose Dapena Paz [Wed, 11 Apr 2007 07:59:55 +0000 (07:59 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Commented call to gtk_text_buffer_set_can_paste_rich_text
as it does not exist in gtk 2.10.
* src/maemo/modest-main-window-ui.h:
* Added zoom menu.
* Added callback for message details action.
* Added next/prev message menu actions.
* Added callback for "close window" menu action.
* Added next message, prev message, find in message and move to
actions to toolbar.
* Added toggle action for toggling fullscreen view.
* src/maemo/modest-platform.c:
* Added support for n800 and osso 1.1 implementation switching
of URI handling (n800 uses osso-uri and osso 1.1 uses
hildon-uri).
* Added implementation of modest_platform_activate_uri and
modest_platform_show_uri_popup (both for n800 and osso 1.1).
* Added warning banners for trying to show a popup of an
URI we don't support.
* src/maemo/modest-icon-names.h:
* Added "move to..." icon.
* src/maemo/modest-msg-view-window.c,
src/widgets/modest-msg-view-window.h:
* Added support for adding key accelerators from ui manager.
* Added support for zooming (actions for zoom levels, key
accelerators for hw keys, integration in menu). It uses the
magnification support in gtkhtml.
* Added support for fullscreen (actions for toggling fullscreen,
key accelerator for hw key, integration in menu). It uses the
standard ui action for toggling fullscreen in GtkWindow.
* Added ..._new_with_header_model. This function is used to
add a reference to a header list model. It's used for
implementing next/prev message actions.
* Added support for browsing next/prev messages of the header
model inside (the one the view was opened from). Added also
dimming support of next/prev message actions.
* Refactored toolbar setup to the new get_toolbar function.
* Now toolbar buttons get the whole space with homogeneous
spacing and expandable properties.
* Contextual menu for toolbar button "reply". It shows a menu
with different kinds of reply actions (forward, reply and
reply to all).
* Added "find in message" implementation. It uses
HildonFindToolbar and gtkhtml engine search. It's working
partially, as automatic scroll to the words found is not
working yet.
* Now it sets the priority of the message shown in the message
view, getting the information from the headers list.
* Added support for translation of ui manager actions.
* Added handler for contextual links in message view.
* Dimming support of reply button depending on the folder the
message is opened from.
* src/maemo/ui/modest-msg-view-window-ui.xml:
* Renamed some action names to be the same of main window.
* Added zoom level menu.
* Added fullscreen toggle menu option
* Added next/prev message menu options.
* Added "close all windows" menu option.
* Completed the toolbar layout:
- Added new, move to, find in message, prev message and
next message actions.
- Removed forward and reply to all toolbar buttons, and added
contextual menu for reply (including these actions).
* Added keyboard accelerators for zoom, fullscreen, and scroll.
* src/maemo/ui/modest-main-window-ui.xml:
* Renamed action names
* src/modest-ui-actions.[ch]:
* ..._on_delete closes the window after deletion when used
from ModestMsgView.
* ..._on_quit now calls gtk_main_quit () to really close the
application.
* ..._on_close_window added to implement specific window close.
It's partially implemented now (does not close properly the
main window).
* ..._on_next and ..._on_prev: added support for prev and next
operations in ModestMsgViewWindow (not implemented yet in
Maemo client). It passes a reference to the modesl of the
header list, that the ModestMsgViewWindow should hold to
implement next/prev on the specific model.
* ..._on_header_activate: now it passes the reference of the
header list model to the constructor of ModestMsgViewWindow
(used in implementation of on_next and on_prev).
* ..._on_msg_link_clicked: calls to the new platform function
modest_platform_activate_uri (currently only implemented in
maemo platform).
* Added ..._on_msg_link_contextual action, that's run on
requesting the contextual menu of a link. It calls to the new
modest_platform_show_uri_popup ().
* Added ..._on_change_zoom. This calls to the newly implemented
zoom support in ModestWindow (implemented at least for
ModestMsgViewWindow in maemo).
* Added ..._on_toggle_fullscreen. This toggles fullscreen status
of the window it's called from.
* Added ..._on_message_details. This opens the new message
details dialog.
* src/modest-platform.h:
* Added new function ..._activate_uri for implementing default
uri action handler.
* Added new function ..._show_uri_popup for implementing
contextual menu of an uri.
* src/gnome/modest-platform.c:
* Added skel implementations for ..._activate_uri and
..._show_uri_popup.
* src/gnome/modest-msg-view-window.c:
* Added skel implementations of ..._new_with_header_model,
..._select_next_message and ..._select_previous_message.
* src/widgets/modest-mail-header-view.c:
* Added support for showing the priority of the message. It does
not use the priority in the TnyHeader, but there are methods
for setting it externally.
* Removed bolding of field names.
* Now it get's and expanded parameter in constructor to specify
if it should be expanded on startup.
* src/widgets/modest-msg-view.[ch]:
* Added support for searching in gtkhtml view.
* Added support for showing contextual menus using tap and hold
(only in MAEMO).
* Added support for zooming (using gtkhtml magnification).
* Now it constructs the mail header view expanded.
* Added separator
* Added support for showing priority of messages (it simply sets
the priority of the mail header view).
* src/widgets/modest-window.[ch]:
* Added abstract methods for setting/getting zoom level.
* Added src/widgets/modest-msg-view-details-dialog.[ch]:
* Dialog to show some message properties. Now it's used only
from ModestMsgViewWindow details action.
pmo-trunk-r1539
Dirk-Jan C. Binnema [Wed, 11 Apr 2007 07:21:39 +0000 (07:21 +0000)]
* cleanup icon handling a bit
pmo-trunk-r1538
Dirk-Jan C. Binnema [Wed, 11 Apr 2007 06:59:24 +0000 (06:59 +0000)]
* get rid of our icon caches, use gtk's; now icons are displayed
again in the header view
pmo-trunk-r1537
Dirk-Jan C. Binnema [Wed, 11 Apr 2007 06:34:29 +0000 (06:34 +0000)]
* make package compilable on arm again
* activate the i18n stuff
pmo-trunk-r1536
Dirk-Jan C. Binnema [Tue, 10 Apr 2007 21:32:58 +0000 (21:32 +0000)]
* uncommented valid strings
pmo-trunk-r1535
Dirk-Jan C. Binnema [Tue, 10 Apr 2007 21:32:31 +0000 (21:32 +0000)]
* minor fixes; revert is-default logic for default account
pmo-trunk-r1534
Sergio Villar Senin [Tue, 10 Apr 2007 17:45:18 +0000 (17:45 +0000)]
* Added window manager calls
* Commented some code in the mail operations that should be reviewed
* Added support to automatically unregister windows when destroyed
pmo-trunk-r1533
Dirk-Jan C. Binnema [Tue, 10 Apr 2007 11:37:54 +0000 (11:37 +0000)]
* typo fix: rename recpt-activated into recpt_activated
pmo-trunk-r1532
Dirk-Jan C. Binnema [Tue, 10 Apr 2007 11:36:32 +0000 (11:36 +0000)]
* enable the accounts stuff access through the menu
pmo-trunk-r1531
Dirk-Jan C. Binnema [Tue, 10 Apr 2007 11:35:48 +0000 (11:35 +0000)]
* make the easy setup stuff somewhat working, using real data
pmo-trunk-r1530
Sergio Villar Senin [Tue, 10 Apr 2007 11:02:55 +0000 (11:02 +0000)]
* Added ModestWindowMgr object
* Added ModestWindowMgr singleton stuff
* Added homogeneous toolbar items to the main window
pmo-trunk-r1529
Sergio Villar Senin [Tue, 10 Apr 2007 09:55:04 +0000 (09:55 +0000)]
* Added logical ids to main window menus
pmo-trunk-r1528
Dirk-Jan C. Binnema [Tue, 10 Apr 2007 08:06:25 +0000 (08:06 +0000)]
* build fixes
pmo-trunk-r1527
Dirk-Jan C. Binnema [Tue, 10 Apr 2007 07:13:24 +0000 (07:13 +0000)]
* folder-view, header-view:
- compile fixes
pmo-trunk-r1526
Dirk-Jan C. Binnema [Fri, 6 Apr 2007 13:43:18 +0000 (13:43 +0000)]
* restore gnome building (check for easysetup)
* use the MODEST_PLATFORM_(GNOME|MAEMO) instead of ugly MODEST_PLATFORM_ID
pmo-trunk-r1525
Murray Cumming [Fri, 6 Apr 2007 12:57:03 +0000 (12:57 +0000)]
2007-04-06 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(create_page_incoming),
(modest_account_settings_dialog_set_account_name):
Added comments about the need for new API in ModestAccountMgr to handle the authentication
and secure-connection stuff that is stored in the options GSList* with hard-coded names.
I will do this if nobody else gets there first.
pmo-trunk-r1524
Murray Cumming [Fri, 6 Apr 2007 12:47:15 +0000 (12:47 +0000)]
2007-04-06 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c: (save_configuration):
Saved much of the incoming and outgoing data too, though I cannot yet see how to
save the security stuff.
pmo-trunk-r1523