const char *p, *e;
p = arg;
- e = arg + strlen(arg);
+ e = arg + strlen(arg)-1;
- if (*(e - 1) == ' ')
- e--;
- while (*e && *e == ' ')
+ while (p != e && *e && *e == ' ')
e--;
while (p != e && *p == ' ')
p++;
if (*p == '-') //allow negative values
p++;
- while (p != e) {
+ while (p <= e) {
if (!isdigit(*p))
break;
p++;
}
- if (p == e)
+ if (p == e+1)
return ARG_LONG;
if (*p == '.') {
p++;
- while (p != e) {
+ while (p <= e) {
if (!isdigit(*p))
- return ARG_STRING;
+ return ARG_BAD;
p++;
}
return ARG_DOUBLE;
}
- return ARG_STRING;
+ return ARG_BAD;
}
char *arg_to_string(const char *arg)
type1 = get_arg_type(expr_dup);
type2 = get_arg_type(expr_dup + idx + 1);
+ if (type1 == ARG_BAD || type2 == ARG_BAD) {
+ NORM_ERR("Bad arguments: '%s' and '%s'", expr_dup, (expr_dup + idx + 1));
+ return -2;
+ }
if (type1 == ARG_LONG && type2 == ARG_DOUBLE)
type1 = ARG_DOUBLE;
if (type1 == ARG_DOUBLE && type2 == ARG_LONG)
case ARG_DOUBLE:
return dcompare(arg_to_double(expr_dup), mtype,
arg_to_double(expr_dup + idx + 1));
+ case ARG_BAD: /* make_gcc_happy() */;
}
/* not reached */
return -2;
};
enum arg_type {
+ ARG_BAD = 0, /* something strange */
ARG_STRING = 1, /* "asdf" */
ARG_LONG = 2, /* 123456 */
ARG_DOUBLE = 3, /* 12.456 */