1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/ControlStructures/ProhibitUntilBlocks.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks;
15 use Perl::Critic::Utils qw{ :severities };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $DESC => q{"until" block used};
23 Readonly::Scalar my $EXPL => [ 97 ];
25 #-----------------------------------------------------------------------------
27 sub supported_parameters { return () }
28 sub default_severity { return $SEVERITY_LOW }
29 sub default_themes { return qw(core pbp cosmetic) }
30 sub applies_to { return 'PPI::Statement' }
32 #-----------------------------------------------------------------------------
35 my ( $self, $elem, undef ) = @_;
36 if ( $elem->first_element() eq 'until' ) {
37 return $self->violation( $DESC, $EXPL, $elem );
46 #-----------------------------------------------------------------------------
52 Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks - Write C<while(! $condition)> instead of C<until($condition)>.
56 This Policy is part of the core L<Perl::Critic> distribution.
61 Conway discourages using C<until> because it leads to double-negatives
62 that are hard to understand. Instead, reverse the logic and use C<while>.
64 until($condition) { do_something() } #not ok
65 until(! $no_flag) { do_something() } #really bad
66 while( ! $condition) { do_something() } #ok
68 This Policy only covers the block-form of C<until>. For the postfix
69 variety, see C<ProhibitPostfixControls>.
74 This Policy is not configurable except for the standard options.
79 L<Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls>
83 Jeffrey Ryan Thalhammer <thaljef@cpan.org>
87 Copyright (c) 2005-2008 Jeffrey Ryan Thalhammer. All rights reserved.
89 This program is free software; you can redistribute it and/or modify
90 it under the same terms as Perl itself. The full text of this license
91 can be found in the LICENSE file included with this module.
97 # cperl-indent-level: 4
99 # indent-tabs-mode: nil
100 # c-indentation-style: bsd
102 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :