1 2007-08-22 Armin Burgmeier <armin@openismus.com>
3 * src/widgets/modest-account-view.c: Fix for bora by using
4 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
5 latter seems not be used anymore.
7 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
10 * src/maemo/modest-main-window.c: Update menu items when the default
11 account changes so that the current default account is always bolded.
12 This fixes maemo.projects.org bug NB#66173.
14 2007-08-17 Murray Cumming <murrayc@murrayc.com>
16 * src/dbus_api/modest-dbus-callbacks.c:
17 (on_dbus_method_get_folders): Avoid trying to get the account name
18 when there are no accounts, to avoid critical g_warnings, fixing
19 projects.maemo.org bug NB#65574.
21 2007-08-17 Murray Cumming <murrayc@murrayc.com>
23 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
24 Use modest_account_mgr_get_signature() instead of accessing gconf
25 directly, to slightly simplify the code.
26 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
27 Append the signature also when opening via other applications,
28 fixing projects.maemo.org bug NB#65828.
30 2007-08-17 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
33 Check for NULLs to prevent a crash when opening an email that is
34 an attachment in another email, fixing projects.maemo.org bug
37 2007-08-17 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-ui-dimming-rules.c:
40 (modest_ui_dimming_rules_on_view_window_move_to):
41 Enable the Move To toolbar button for search results, fixing the
42 last part of projects.maemo.org bug NB#63807.
44 2007-08-17 Murray Cumming <murrayc@murrayc.com>
46 * src/dbus_api/modest-dbus-callbacks.c:
47 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
48 because this is called from idle handlers, to fix hangs afte the
50 (find_message_by_url): Added a TODO comment about a crash that
51 happens when tinymail was built with DBC checks.
53 2007-08-16 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-search.c: (modest_search_folder):
56 * src/modest-search.h: Rename ModestSearch::before to start_date
57 and after to end_date, using the same names as the libogs struct
59 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
60 The start_date and end_date were swapped in the check. This
61 fixes date range searches, fixing projects.maemo.org bug NB#63407.
63 2007-08-16 Murray Cumming <murrayc@murrayc.com>
65 * src/maemo/modest-account-view-window.c:
66 Added (check_for_active_acount).
67 (on_delete_button_clicked), (on_edit_button_clicked):
68 When an account is doing something (such as refreshing),
69 show the same warning for account deletion as for account
70 editing, to fix projects.maemo.org bug NB#64588.
72 2007-08-16 Murray Cumming <murrayc@murrayc.com>
74 * src/widgets/modest-msg-view-window.h:
75 * src/gnome/modest-msg-view-window.c:
76 * src/maemo/modest-msg-view-window.c:
77 Added modest_msg_view_window_construct().
78 (modest_msg_view_window_new_with_header_model),
79 Added modest_msg_view_window_new_for_search_result),
80 Renamed modest_msg_view_window_new() to
81 modest_msg_view_window_new_for_attachment(),
82 and modest_msg_view_window_is_search_result(),
83 so we can explicitly know that the window is for an
84 attachment or a search result or a message from the list.
86 (modest_msg_view_window_view_attachment):
87 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
88 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
89 Use modest_msg_view_window_new_for_search_result().
91 * src/modest-ui-dimming-rules.c:
92 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
93 for search results, fixing projects.maemo.org bug NB#63811.
95 2007-08-16 Armin Burgmeier <armin@openismus.com>
97 * src/modest-ui-actions.c: Show a banner instead of a dialog when
98 renaming a folder fails, to stay consistent with what happens when
99 creating a folder fails.
101 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
102 slightly country loading from the mmc_mappings file, fixed a memory
105 2007-08-16 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-tny-account-store.c: (volume_path_is_mounted):
108 Check the GnomeVFSVolume activation path instead of the device path,
109 so that the memory card is really really shown in the UI.
111 2007-08-16 Murray Cumming <murrayc@murrayc.com>
113 * src/maemo/easysetup/modest-easysetup-wizard.c:
114 (get_entered_account_title), (on_before_next), (entry_is_empty),
116 * src/maemo/modest-account-settings-dialog.c:
117 (get_entered_account_title), (on_button_signature), (check_data),
118 (save_configuration), (entry_is_empty):
119 Strip the account title of whitespace at the start and end before
120 using it or checking it. This means that an all-whitespace title
121 is not allowed, fixing projects.maemo.org bug NB#64977.
123 2007-08-15 Murray Cumming <murrayc@murrayc.com>
125 * src/modest-ui-actions.h:
126 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
127 to modest_run_account_setup_wizard() and made it public.
128 * src/dbus_api/modest-dbus-callbacks.c:
129 (check_and_offer_account_creation), (on_idle_mail_to),
130 (on_idle_compose_mail), (on_idle_open_default_inbox):
131 Offer account creation if necessary, fixing projects.maemo.org
134 2007-08-15 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-ui-actions.c: (run_account_setup_wizard):
137 Return a gboolean to indicate success.
138 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
139 (modest_ui_actions_on_send): When offering account creation, only
140 give up (return) if account creation failed. Otherwise continue
141 with the original request. This fixed projects.maemo.org bug
144 2007-08-15 Murray Cumming <murrayc@murrayc.com>
146 * src/widgets/modest-recpt-editor.c:
147 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
148 to fix projects.maemo.org bug NB#63789.
150 2007-08-15 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
153 (modest_tny_account_store_new): Properly detect the memory card at
154 startup, and add an account for it.
156 2007-08-14 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
159 Commented out the MMC code again because it mistakenly detects
160 the card even when it isn't inserted.
162 2007-08-14 Murray Cumming <murrayc@murrayc.com>
164 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
165 Renabled the call to add_mmc_account() because I do not believe
166 it could be the cause of the mentioned hang (in scratchbox, where
167 there is no memory card), and because I have tested that it works
170 2007-08-14 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
173 Comment out part of the last commit because it apparently causes
176 2007-08-14 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-tny-account-store.c: Added the add_mmc_account()
179 function to save some copy/pasting.
180 (modest_tny_account_store_new): If the memory card is mounted,
181 create an account for it at the start, instead of waiting for the
182 user to unmount it and mount it.
184 2007-08-13 Murray Cumming <murrayc@murrayc.com>
186 * src/widgets/modest-account-view.c: (on_account_changed):
187 Do not try to use the human-readable TnyAccount name instead of the
188 ID of the modest account to get the transport account. And unref
189 the transport account. This prevents a g_warning(), and a possible
192 2007-08-13 Murray Cumming <murrayc@murrayc.com>
194 * src/maemo/modest-platform.c:
195 (modest_platform_set_update_interval): Handle the new
196 alarmd error to warn when alarmd is not running, as is the case in
197 scratchbox for me now because
198 "Module /usr/lib/alarmd/libretu.so initialization failed"
200 2007-08-13 Murray Cumming <murrayc@murrayc.com>
202 * src/widgets/modest-header-view-render.c:
203 (_modest_header_view_compact_header_cell_data):
204 NULL some strings after freeing them, trying to deal with
205 the double deletion found in projects.maemo.org bug 64183,
206 probably having no effect.
208 2007-08-13 Murray Cumming <murrayc@murrayc.com>
210 * src/maemo/modest-account-settings-dialog.c:
211 (create_page_incoming), (create_page_outgoing): Use a define
212 for the min and max port numbers.
214 (check_hildon_number_editor_and_warn_value_not_in_range),
215 (check_data): Do an extra check for an invalid port number, as needed
216 in projects.maemo.org bug #64275, when the number is cleared, but this
217 does not work due to bugs.maemo.org bug #1806.
219 2007-08-13 Murray Cumming <murrayc@murrayc.com>
221 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
222 Comment out the debug warning about the unexpected D-Bus methods.
223 They are just annoying now.
224 * src/maemo/modest-platform.c:
225 (modest_platform_set_update_interval): Correct the D-Bus path, instead
226 of using a file path, though it did not seem to break things before.
227 It might be needed now:
228 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
229 modest is not already running. This is the behaviour of the old client, and
230 Mox says it is what we should do for modest.
231 This closes projects.maemo.org bug NB#64327.
233 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
235 * src/modest-text-utils.c:
236 Fixed invalid jump due to incorrect string/pointer
238 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
241 2007-08-01 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-account-mgr-helpers.h:
244 * src/modest-account-mgr-helpers.c:
245 Added modest_account_mgr_get_first_account_name(),
246 using code from modest_account_mgr_set_first_account_as_default().
248 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
249 (account_number_changed): Call set_at_least_one_account_visible() so that
250 the first account is visible when first added, without the user having to
252 I do wonder how this worked before.
254 2007-08-01 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-tny-account-store.c: (show_password_warning_only),
257 (show_wrong_password), (request_password_and_wait), (get_password),
258 (modest_tny_account_store_alert): Remove the (incomplete anyway)
259 attempts to show UI only in the main context, which used g_idle_add()
260 and mainloops, because tinymail now guarantees that it only calls these
261 callbacks in the mainloop with the gdk lock. This makes everything much
264 2007-08-01 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
267 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
268 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
269 error dialog, instead of ignoring it.
271 2007-08-01 Murray Cumming <murrayc@murrayc.com>
273 * src/maemo/modest-msg-view-window.c:
274 (modest_msg_view_window_get_header),
275 (modest_msg_view_window_last_message_selected):
276 Added comments to explain the use of priv->header_model.
277 * src/modest-ui-dimming-rules.c:
278 (modest_ui_dimming_rules_on_open_msg),
279 (modest_ui_dimming_rules_on_mark_as_read_msg),
280 (modest_ui_dimming_rules_on_mark_as_unread_msg),
281 (modest_ui_dimming_rules_on_remove_attachments),
282 (_invalid_attach_selected), (_selected_msg_marked_as):
283 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
284 and changed the parameter to a ModestMainWindow to make it clearer that
285 it never uses any other kind of window.
286 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
287 instead of the selected message.
288 I notice that much of the dimming code and the ModestMsgViewWindow code
289 hard-codes the assumption that the viewed message is always selected in
290 the header view. This does not seem wise or simple.
292 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
293 examine the actual message instead of whatever might be selected
294 in the header view. This stops the delete toolbar button and menu item
295 from being dimmed when opening a message view the search UI,
296 partially fixing projects.maemo.org bug NB#63811.
298 However, when actually deleting, I now get this warning:
299 "tny_header_set_flags: This is a header instance for a new message.
300 Only priority and attachment flags are supported"
302 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
304 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
306 Show account wizard if no accounts are defined while sending
307 (automatic sending after the account wizard finished does not
308 work because it takes some time until the account manager
309 synchronizes everything. (projects.maemo.org NB#62792)
311 2007-07-30 Murray Cumming <murrayc@murrayc.com>
313 * src/modest-tny-account-store.c: (on_account_removed),
314 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
315 account is removed from the View menu. We have TnyAccountStore
316 and ModestTnyAccountStore signals that seem very similar, but this
317 seems to work for now.
319 * src/maemo/modest-main-window.c:
320 (on_show_account_action_activated): Prevent dereference
321 of a NULL if the accoutn does not really exist, though that
322 should not happen anymore.
324 This fixes projects.maemo.org bug NB#64606.
326 2007-07-30 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-ui-actions.c: (run_account_setup_wizard),
329 (modest_ui_actions_on_accounts): Revert a change that set these
330 to modal dialogs, freezing the UI when they show secondary dialogs.
331 This fixed projects.maemo.org bug NB#64519.
333 2007-07-27 Murray Cumming <murrayc@murrayc.com>
335 * src/widgets/modest-header-view-render.c:
336 (_modest_header_view_compact_header_cell_data):
337 Some checks and initialization to try to deal with a crash,
338 probably ineffective.
340 2007-07-27 Murray Cumming <murrayc@murrayc.com>
342 * src/maemo/modest-maemo-utils.c:
343 (modest_maemo_utils_get_supported_secure_authentication_methods):
344 Make sure that we have a connection, asking the user for one
346 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
347 Check for a connection before showing the wizard, because
348 the wizard needs a connection to check for server capabilities.
350 2007-07-27 Murray Cumming <murrayc@murrayc.com>
352 * src/maemo/modest-account-view-window.c:
353 (on_new_button_clicked): Remember the wizard dialog instance,
354 so we can just present it again if necessary. This prevents
355 multiple windows from appearing if you click again quickly on the
356 New button before the dialog appears, fixing projects.maemo.org
359 2007-07-27 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
362 Offer a connection dialog if there is no connection when
363 starting modest. This should fix projects.maemo.org bug NB#61134.
365 2007-07-27 Murray Cumming <murrayc@murrayc.com>
367 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
368 Reverted my last commit. I was able to fix the build by doing
369 apt-get install wpeditor0 (replacing other wpeditor packages) and
370 an explicit apt-get install wpeditor-dev to upgrade the -dev
373 2007-07-27 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
376 Commented out the use of wp_text_buffer_replace_image()
377 because it does not exist, to break the build. Added a TODO for it.
379 2007-07-26 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-tny-account-store.c: (recreate_all_accounts):
382 Recreate them even if they were NULL before. I guess something
383 else was already creating them before, or this would never
385 (modest_tny_account_store_get_server_account): Make sure that
386 the tny accounts have been created before trying to find one.
387 This allows libmodest_dbus_client_compose_mail() to work
388 when the UI is not yet visible.
389 This is probably useful in other cases too.
391 (get_password): When the password is wrong after it is entered
392 in the protected password dialog, show an info banner (in an
393 idle handler) before showing the protected password dialog
396 2007-07-26 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-ui-actions.h:
399 * src/modest-ui-actions.c: Added
400 modest_do_refresh_current_folder() containing some code from
401 modest_ui_actions_on_send_receive().
402 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
403 Call modest_do_refresh_current_folder() before refreshing the
404 requested account, as in modest_ui_actions_on_send_receive().
405 This is strange, but seems to be necessary to show new mails.
406 Now new emails are finally visible in the UI when downloaded
407 via the automatic update interval, fixing bug NB#57458.
408 This also works because bug NB#57458 has been fixed somehow.
410 2007-07-26 Murray Cumming <murrayc@murrayc.com>
412 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
413 printf more details when we get unhandled D-Bus methods, because
416 * src/modest-mail-operation.c: (update_account_thread):
417 Comment out the tny_camel_pop_store_account_reconnect(), because this
418 is apparently no longer needed, and it did not work before anyway.
419 See the comment in the code.
421 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
422 by checking the header flags. This fixes projects.maemo.org bug
425 2007-07-25 Murray Cumming <murrayc@murrayc.com>
427 * src/maemo/modest-maemo-utils.h:
428 * src/maemo/modest-maemo-utils.c: Added
429 modest_maemo_show_information_note_in_main_context_and_forget().
430 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
431 Use the new function to show simple error dialogs in the main
432 context, though question dialogs are still in the current context,
433 which is unfortunately usually not the main context. This should
436 2007-07-25 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-tny-account-store.c: (get_password):
439 Never save the entered username and password in gconf,
440 because the UI spec says we should not. This helps
441 slightly with projects.maemo.org bug NB#63671.
443 2007-07-25 Murray Cumming <murrayc@murrayc.com>
445 * src/widgets/modest-msg-edit-window.h:
446 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
447 Moved some code here to make it simpler.
448 (modest_msg_edit_window_attach_file_one): Renamed from
449 modest_msg_edit_window_attach_file_interactive().
450 (modest_msg_edit_window_offer_attach_file): Renamed from
451 modest_msg_edit_window_attach_file() and used
452 modest_msg_edit_window_attach_file_one() instead of
453 copy/pasting the code. The old code for one was not using
454 GnomeVFS. This allows use of smb:// URLs when using send-as
455 from external applications, fixing bug NB#63741.
457 (modest_msg_edit_window_insert_image),
458 (modest_msg_edit_window_add_attachment_clicked):
459 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
460 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
461 Adapted to the new function names.
463 2007-07-25 Murray Cumming <murrayc@murrayc.com>
465 (modest_platform_set_update_interval): Set the alarm recurrence
466 fields so that auto-update does not just happen the first time.
467 This should have fixed projects.maemo.org bug NB#63938.
469 When this happens you can see a printf when the D-Bus method is
471 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
473 However, I do not actually seem to get new POP messages even when
474 clicking the refresh button manually. A restart gets them.
475 This might be a problem in today's tinymail only.
477 2007-07-24 Murray Cumming <murrayc@murrayc.com>
479 * src/maemo/modest-maemo-global-settings-dialog.c:
480 (current_connection):
481 Avoid a crash (probably only in scratchbox) when strcmp()ing a
482 NULL when closing the dialog.
484 2007-07-24 Murray Cumming <murrayc@murrayc.com>
486 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
487 Remove the hacky send/receive that didn't work, and instead
488 refilter the treemodel to make the deleted email really vanish from
489 the UI (though the delete-from-menu code does has commented out
490 the code that does that). This fixes projects.maemo.org bug
493 2007-07-24 Murray Cumming <murrayc@murrayc.com>
495 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
496 Try a couple of tricks to force the treeview to update (
497 poke the folder, and do a send/receive refresh), but the deleted
498 email still appears with a strike-through instead of really being
501 2007-07-23 Murray Cumming <murrayc@murrayc.com>
503 * src/dbus_api/modest-dbus-callbacks.c:
504 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
505 because their ID is not human-readable (see the comment about
506 improvements needed to the osso-email-interface API) and
507 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
509 2007-07-23 Murray Cumming <murrayc@murrayc.com>
511 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
512 (add_folders_to_list), (on_dbus_method_get_folders),
513 (modest_dbus_req_filter):
514 * src/maemo/modest-maemo-utils.c:
515 (on_camel_account_get_supported_secure_authentication):
516 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
517 (on_header_view_focus_in):
518 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
519 * src/modest-formatter.c: (modest_formatter_create_body_part):
520 * src/modest-mail-operation.c: (recurse_folders),
521 (update_account_thread), (get_msgs_full_thread),
522 (modest_mail_operation_get_msgs_full),
523 (modest_mail_operation_xfer_msgs):
524 * src/modest-search.c: (search_mime_part_and_child_parts),
525 (modest_search_account), (modest_search_all_accounts):
526 * src/modest-tny-account.c:
527 (modest_tny_account_get_special_folder), (recurse_folders):
528 * src/modest-tny-local-folders-account.c:
529 (modest_tny_local_folders_account_query_passes):
530 * src/modest-tny-msg.c: (copy_mime_part),
531 (modest_tny_msg_find_body_part_from_mime_part):
532 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
533 (modest_tny_send_queue_try_to_send):
534 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
535 (_modest_ui_actions_open), (download_uncached_messages),
536 (reply_forward), (modest_ui_actions_on_copy),
537 (modest_ui_actions_on_details), (has_retrieved_msgs),
538 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
540 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
541 (_selected_msg_marked_as), (_msg_download_completed),
542 (_selected_msg_sent_in_progress):
543 * src/widgets/modest-attachments-view.c:
544 (modest_attachments_view_set_message):
545 * src/widgets/modest-msg-view.c: (find_cid_image):
546 * tests/check_folder-transfer.c: (find_folders):
547 * tests/check_update-account.c: (func):
548 * tests/dbus_api/test_get_folders.c: (main):
549 Checked all uses of tny_iterator_get_current(), making sure
550 that the object is unreferenced (3 or 4 places did not),
551 and adding checks for NULL.
553 2007-07-23 Murray Cumming <murrayc@murrayc.com>
555 * src/dbus_api/modest-dbus-callbacks.c:
556 (on_idle_open_default_inbox): Make sure that the application UI is
558 * src/maemo/easysetup/modest-easysetup-wizard.c:
559 (on_entry_invalid_character): Show the word whitespace instead
560 of (null) in the banner when whitespace was entered.
561 (show_error): Add a comment that this does not work in
562 Maemo Bora, though we do not know why.
564 2007-07-23 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-tny-account.c:
567 (modest_tny_account_get_special_folder): Use an if instead of
568 an assert for when the parent account name is NULL, because this
569 might be causing a crash in projects.maemo.org bug 63192.
570 * src/modest-mail-operation.c:
571 (modest_mail_operation_send_new_mail_cb),
572 (modest_mail_operation_remove_folder): unref the folder that is
573 returned from modest_tny_account_get_special_folder().
575 2007-07-23 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-ui-actions.c:
578 (modest_ui_actions_on_password_requested):
579 Show mail_ib_login_cancelled info banner when the user cancels
580 the protected password dialog, to fix projects.maemo.org
583 2007-07-23 Murray Cumming <murrayc@murrayc.com>
585 * src/maemo/modest-account-settings-dialog.c:
586 (create_page_outgoing): Put this page in a GtkScrolledWindow,
587 matching the UI mock-up in the UI spec, and allowing access
588 to all widgets even when the on-screen keyboard is active.
590 2007-07-23 Murray Cumming <murrayc@murrayc.com>
592 Reverted this previous commit from Johannes,
593 because the scrollbars are always visible and because
594 I think we only need it on onepage of the account
595 settings, not the account wizard.
596 (I wrote the wrong instructions in the bug.)
598 * src/maemo/easysetup/modest-easysetup-wizard.c:
599 Added scrollbars to account wizard dialog.
600 Fixed projects.maemo.org NB #62744
602 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
604 * src/maemo/easysetup/modest-easysetup-wizard.c:
605 (create_page_user_details):
606 Use auto-cap for name (projects.maemo.org NB#63716)
607 * src/widgets/modest-account-view.c: (on_account_busy_changed):
609 2007-07-22 Armin Burgmeier <armin@openismus.com>
611 * src/maemo/modest-ui-actions.c: Use current account instead of
612 default account for creating viewer windows, so that the viewer
613 window knows to which account the viewed message belongs.
615 * src/maemo/modest-msg-view-window.c: Destroy the window when the
616 corresponding account is deleted. This fixes projects.maemo.org bug
619 2007-07-18 Armin Burgmeier <armin@openismus.com>
621 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
622 the dialog close after entering an invalid port number and clicking
623 OK. This fixes projects.maemo.org bug NB#63602.
625 2007-07-18 Armin Burgmeier <armin@openismus.com>
627 * src/modest-tny-account-store.c:
628 (get_server_accounts): Set parent modest account name for each
629 connection-specific transport account so that special folders of such
630 an account can be looked up. This fixes a crash when changing account
631 settings. This might also be related to projects.maemo.org bug
634 2007-07-16 Armin Burgmeier <armin@openismus.com>
636 * src/modest-ui-actions.c: Added a button to create a folder to the
637 move-to dialog. This fixes projects.maemo.org bug NB#59863.
639 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
641 * src/maemo/easysetup/modest-easysetup-wizard.c:
642 Added scrollbars to account wizard dialog.
643 Fixed projects.maemo.org NB #62744
645 2007-07-16 Murray Cumming <murrayc@murrayc.com>
647 * src/widgets/modest-msg-view.h:
648 * src/widgets/modest-msg-view.c:
649 Added modest_msg_view_get_message_is_empty() but this needs
651 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
652 Check if there is any text in the message yet.
653 But this needs to be implemented properly.
654 (modest_msg_edit_window_toggle_find_toolbar):
655 * src/maemo/modest-msg-view-window.c:
656 (modest_msg_view_window_toggle_find_toolbar):
657 Show a banner warning if there is no text to search, when
658 trying to start a search. This partially fixes
659 projects.maemo.org bug NB#62350.
661 2007-07-13 Murray Cumming <murrayc@murrayc.com>
663 * src/modest-mail-operation.c: (update_account_thread):
664 Initialized num_new_headers to fix the build.
666 2007-07-13 Murray Cumming <murrayc@murrayc.com>
668 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
669 Ignore modest accounts whose server accounts don't exist in gconf.
670 This prevents us trying to create TnyAccount instances for those
671 server accounts when the server account has been removed from gconf,
672 but the parent modest account has not yet been removed from modest.
673 I don't know why this is only noticeable now. It was probably just
674 a harmeless g_warning() anyway.
676 2007-07-13 Murray Cumming <murrayc@murrayc.com>
678 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
679 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
681 2007-07-12 Armin Burgmeier <armin@openismus.com>
683 * src/maemo/modest-main-window.c: Make default account appear bold
684 in view, tools/send & receive and toolbar/send & receive SCM menus.
685 This fixes projects.maemo.org bug NB#59010.
687 2007-07-12 Murray Cumming <murrayc@murrayc.com>
689 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
690 Add a short-cut, by checking if the folder store is an account.
691 This ensures that the Sort menu item and toolbar is dimmed for
692 the local-folders account root item, fixing
693 projects.maemo.org bug NB#62545.
695 2007-07-12 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-tny-account-store.c: (get_password):
698 Show the password dialog (via the signal) only in the mainloop, via
699 an idle handler that we wait for. This could theoretically prevent
700 hangs, though I worry that it could introduce some too.
702 2007-07-12 Murray Cumming <murrayc@murrayc.com>
704 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
705 * src/maemo/modest-platform.c:
706 (modest_platform_connect_and_wait):
707 Take a TnyAccount* parameter and try to set it to online
708 (a TnyCamel-only API), because tinymail sets accounts to offline
709 when the user cancels a password dialog, and doesn't ask again until
710 it has been set to online.
711 However, this is commented out because it causes a hang now.
713 (modest_platform_connect_and_wait_if_network_account):
714 * src/modest-mail-operation.c:
715 (modest_mail_operation_update_account):
716 * src/modest-platform.h:
717 * src/modest-ui-actions.c: (_modest_ui_actions_open),
718 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
720 2007-07-12 Armin Burgmeier <armin@openismus.com>
722 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
724 * src/modest-mail-operation.c:
725 * src/modest-ui-actions.c: Check for already existing folder before
726 querying the server, show error message from camel if the request
727 still fails. This fixes projects.maemo.org bug NB#58701.
729 2007-07-12 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-tny-account-store.h:
732 * src/modest-tny-account-store.c:
733 Added modest_tny_account_store_forget_password_in_memory(),
734 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
735 when creating a new account, so that new passwords will be used, instead of
736 us thinking that it's a second request as a result of a failed password again.
738 2007-07-12 Murray Cumming <murrayc@murrayc.com>
740 * src/dbus_api/modest-dbus-callbacks.c:
741 (on_idle_open_message): If the message is in drafts then open it
742 in an edit window instead of a view window. This fixes
743 projects.maemo.org bug NB#63005.
745 2007-07-12 Murray Cumming <murrayc@murrayc.com>
747 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
748 Avoided a harmless g_warning().
750 2007-07-12 Murray Cumming <murrayc@murrayc.com>
752 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
753 Pass the modest account name, not the TnyAccount display name to
754 modest_msg_view_window_new() so that the reply feature works,
755 fixing projects.maemo.org bug NB#62892.
757 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
758 (modest_msg_view_window_new_with_header_model):
759 * src/maemo/modest-msg-view-window.c:
760 (modest_msg_view_window_new_with_header_model),
761 (modest_msg_view_window_new):
762 * src/modest-ui-actions.c: (reply_forward):
763 * src/widgets/modest-msg-view-window.h:
764 * src/widgets/modest-window.c: (modest_window_set_active_account):
765 Rename an account parameter to modest_account_name to make this clearer.
767 2007-07-11 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-ui-actions.h:
770 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
771 modest_do_message_delete().
772 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
773 Call modest_do_message_delete(), hoping that this would cause messages
774 to be really deleted from search instead of just marked with strike through.
775 Does not seem to help.
777 2007-07-11 Armin Burgmeier <armin@openismus.com>
779 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
780 priv->reselect to FALSE prior to calling
781 modest_folder_view_select_first_inbox_or_local() to prevent endless
782 recursion and thus a crash on startup.
784 2007-07-11 Armin Burgmeier <armin@openismus.com>
786 * src/maemo/modest-account-settings-dialog.h: Include
787 <gtk/gtknotebook.h> to fix the build (at least for me).
789 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
790 Use "New FolderN" as default suggested name if "New folder" already
791 exists, with N being the first free number, though never exceed "New
792 folder99" in which case we just fall back to "New Folder" even though
793 it already exists. This fixes projects.maemo.org bug NB#58663.
795 2007-07-11 Murray Cumming <murrayc@murrayc.com>
797 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
798 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
799 projects.maemo.org bug NB#62778.
801 2007-07-11 Murray Cumming <murrayc@murrayc.com>
803 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
804 Ignore the wrong (for now) secure-smtp setting in the presets -
805 just default to requiring secure authentication for SMTP, because
808 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
810 * src/widgets/modest-folder-view.c: (filter_row)
811 Do not show drafts folder (see UI specs)
813 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
815 * src/modest-ui-actions.c:
816 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
817 place and also not necessary.
819 * src/widgets/modest-folder-view.c: (filter_row)
820 Guess folder type and hide Sent & Outbox if necessary.
821 Fixed project.maemo.org NB#57328
823 2007-07-11 Murray Cumming <murrayc@murrayc.com>
825 * src/modest-ui-actions.h:
826 * src/modest-ui-actions.c:
827 (modest_ui_actions_on_delete_message):
828 Move some code into a new
829 modest_ui_actions_refresh_message_window_after_delete()
830 function so we can use it from elsewhere.
832 * src/dbus_api/modest-dbus-callbacks.c:
833 (on_idle_delete_message), (on_delete_message): Used an idle
834 handler, as we do for the other D-Bus method handlers.
835 Call modest_ui_actions_refresh_message_window_after_delete()
836 if the deleted message was open in a window. This fixed
837 projects.maemo.org bug NB#62862.
839 2007-07-11 Murray Cumming <murrayc@murrayc.com>
841 * src/modest-main.c: (main): Only show the UI at the start if
842 the showui command line option was given. For instance,
843 run-standalone src/modest showui
844 Otherwise, we wait for the top_application D-Bus method to
845 be sent by hildon-desktop when the application is selected
847 This allows us to run without a UI when osso-global-search
848 uses our D-Bus methods.
850 2007-07-11 Murray Cumming <murrayc@murrayc.com>
852 * src/dbus_api/modest-dbus-api.h: Added a define for a
853 top-application D-Bus method.
854 * src/dbus_api/modest-dbus-callbacks.c:
855 (on_top_application),
856 (modest_dbus_req_handler): Handle the top-application D-Bus
857 method, which might be an undocumented D-Bus signal sent by
858 hildon-desktop when it starts the application from the menu.
859 But I am not sure and I need to test it on the device, because
860 my scratchbox does not have the application in the menu now.
861 This method shows the main window, so that it can be invisible
862 when started, for instance, just for email searching from
865 * src/maemo/modest-main-window.c: (restore_settings),
866 (modest_main_window_new): Do not show the window immediately
867 upon creation. We show it later.
868 * src/modest-widget-memory.c: (save_settings_paned):
869 Try (unsuccessfully) to avoid saving the paned position when
870 it is not even visible.
871 (restore_settings_paned): Do not allow a silly paned position.
872 This seems necessary when not showing the window at first.
874 * tests/dbus_api/Makefile.am:
875 * tests/dbus_api/test_top_application.c: (main): Test for the
878 2007-07-10 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-ui-dimming-rules.c:
881 (modest_ui_dimming_rules_on_new_msg),
882 (modest_ui_dimming_rules_on_reply_msg),
883 (modest_ui_dimming_rules_on_delete_msg),
884 (modest_ui_dimming_rules_on_details),
885 (modest_ui_dimming_rules_on_view_window_move_to),
886 (modest_ui_dimming_rules_on_view_previous),
887 (modest_ui_dimming_rules_on_view_next),
888 (_invalid_folder_for_purge): Added checks before
889 casting the window. This looks like an actual
890 logic error in _invalid_folder_for_purge(), because it
891 tries to use a ModestMainWindow as a message window.
893 2007-07-10 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/modest-account-settings-dialog.c:
896 (show_error): Use the same implementation as in
897 modest-easysetup-wizard.c:
898 (on_entry_invalid_character): The logical ID contains a %s.
899 Guessed what it should be.
900 (on_entry_max), (check_data), (on_response): Adapt to
901 changed show_error().
902 (create_page_account_details): Really call
903 modest_validating_entry_set_func() on the correct widgets.
904 * src/maemo/easysetup/modest-easysetup-wizard.c:
905 (on_entry_invalid_character): Fix the logical ID here too.
906 (create_page_account_details),
907 (create_page_user_details):
909 modest_validating_entry_set_func() on the correct widgets.
911 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
912 Do not try to use the account if it is NULL.
914 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
916 * src/modest-ui-actions.c: (create_move_to_dialog),
917 (modest_ui_actions_on_main_window_move_to),
918 (modest_ui_actions_on_msg_view_window_move_to):
919 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
920 (filter_row), (modest_folder_view_show_non_move_folders):
921 * src/widgets/modest-folder-view.h:
923 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
924 the Sent folder yet as it does not report the correct folder type.
926 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
928 * src/maemo/modest-msg-edit-window.c: (init_window):
931 2007-07-10 Murray Cumming <murrayc@murrayc.com>
933 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
934 Take a parent widget instead of a parent window, and
935 implement this with hildon_banner_show_information() instead.
936 Non-Maemo builds can just ifdef that there.
937 This fixed projects.maemo.org bug NB#62766.
939 (on_entry_invalid_character): Use show_error() again instead
940 of using hildon directly, and use the _CS() macro to use the correct
942 (create_account), (check_for_supported_auth_methods), (on_entry_max):
943 Pass a widget instead od a window to show_error().
945 2007-07-10 Murray Cumming <murrayc@murrayc.com>
947 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
948 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
949 This allows us to show the server name in the error message, fixing
950 projects.maemo.org bug NB#62904.
951 Also, use the appropriate logical ID message for the account protocol.
953 2007-07-10 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-tny-account-store.c: (on_idle_wrong_password):
956 A compilation fix, though the build wasn't broken for me.
958 2007-07-09 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
961 Do not try to unref a NULL folder store, to avoid a runtime warning.
962 This seems to happen sometimes when changing accounts settings.
964 2007-07-09 Murray Cumming <murrayc@murrayc.com>
966 * src/modest-tny-account-store.c:
967 (modest_tny_account_store_instance_init),
968 (modest_tny_account_store_finalize),
969 (on_account_settings_hide), (on_idle_wrong_password):
970 Use a GHashTable to ensure that we only show one account settings
971 dialog per modest account. This avoids us having a dialog open for
972 both the store and transport accounts, or due to repeated get_password()
973 calls that shouldn't happen anyway.
975 2007-07-09 Murray Cumming <murrayc@murrayc.com>
977 * src/maemo/modest-maemo-utils.c: (on_hide),
978 (modest_maemo_show_dialog_and_forget): Handle the response, because
979 the window is not even hidden by default.
981 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
982 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
983 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
984 which seems to prevent some modality problems.
986 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
987 Ignore user cancellation errors.
989 * src/modest-account-mgr-helpers.h:
990 * src/modest-account-mgr-helpers.c:
991 Added modest_server_account_get_password() and
992 modest_server_account_get_has_password() to avoid direct use of
995 * src/maemo/modest-account-settings-dialog.h:
996 * src/maemo/modest-account-settings-dialog.c:
997 (modest_account_settings_dialog_init): Store the notebook so we can
999 Added modest_account_settings_dialog_switch_to_user_info().
1001 * src/modest-tny-account-store.c:
1002 (get_password): When the password in the account settings is wrong (we think),
1003 show the relevant page of the account settings dialog, in the mainloop.
1004 However, we currently get many of these at once because cancel does not
1006 (forget_password): Do not forget the password
1007 from the account settings, because this causes side-effects when
1008 tinymail seems to call it at strange time, maybe because of how we
1009 are cancelling get_password().
1010 (modest_tny_account_store_alert): Ignore user cancellations.
1012 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1014 * src/maemo/modest-maemo-utils.h:
1015 * src/maemo/modest-maemo-utils.c:
1016 Added modest_maemo_show_information_note_and_forget() for use instead of
1017 gtk_dialog_run() when the response is not needed, to avoid an extra
1018 mainloop which could cause a hang.
1020 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1021 Use the logical IDs for the error message, though they are not
1022 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1023 because gtk_dialog_run() caused a hang here (the window did not close).
1024 This fixes projects.maemo.org bug NB#62646.
1026 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-account-mgr-helpers.h:
1029 * src/modest-account-mgr-helpers.c:
1030 Added modest_account_mgr_get_store_protocol().
1032 * src/maemo/modest-account-view-window.c:
1033 (on_delete_button_clicked): Show different warning text depending on
1034 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1035 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1038 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1040 * src/maemo/modest-msg-edit-window.c:
1041 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1042 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1044 2007-07-07 Armin Burgmeier <armin@openismus.com>
1046 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1047 ckdg_ib_maximum_characters_reached from correct package.
1049 * src/modest-ui-actions.c: Show an error message when a folder could
1050 not be created. Tinymail does not give us specific error codes about
1051 what has gone wrong, so we assume that a folder with that name
1052 already exists, though there might be other reasons.
1054 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1056 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1057 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1058 give a more exact error message that can be partly translated.
1060 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/modest-address-book.c:
1063 (select_email_addrs_for_contact): Specify a default window size for the
1064 select-email-address dialog, so that it is probably big enough for the
1065 title. This should fix projects.maemo.org bug NB#62277.
1067 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/easysetup/modest-easysetup-wizard.c:
1070 (create_page_complete_easysetup): Use
1071 gtk_widget_set_size() request to ensure that the text wraps
1074 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1076 * src/maemo/easysetup/modest-easysetup-wizard.c:
1077 (on_entry_invalid_character), (create_page_account_details),
1078 (create_page_user_details):
1079 Use new API of ModestValidatingEntry. But for some reason the banner is
1080 not shown. I will have to investigate that further.
1082 * src/widgets/modest-validating-entry.c: (on_insert_text),
1083 (modest_validating_entry_set_func):
1084 * src/widgets/modest-validating-entry.h:
1085 Added a new callback function to be able to react to prevented
1086 characters whitespaces to e.g show a banner.
1088 2007-07-05 Armin Burgmeier <armin@openismus.com>
1090 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1091 notification of HildonNumberEditor instead of remembering the port
1092 number. Thanks to Johannes for pointing this out.
1094 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1096 * src/maemo/easysetup/modest-easysetup-wizard.c:
1097 Check if there are any user changes before showing a confirmation
1098 dialog (projects.maemo.org NB#60946)
1100 2007-07-05 Armin Burgmeier <armin@openismus.com>
1102 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1103 number at the beginning of the dialog and set the modified flag at the
1104 end if the port number has changed. This is necessary because
1105 HildonNumberEditor does not support notification when the value has
1108 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-ui-actions.c:
1111 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1112 a connection before asking anything else. Correct the check for the destination
1113 folder so that it succeeds when online.
1114 This fixed projects.maemo.org bug NB#61645.
1116 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1119 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1120 to fix projects.maemo.org bug NB#62439.
1122 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-tny-account.c: (on_connection_status_changed):
1125 Really do not use tny_device_force_offline() here. See the previous comment.
1127 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1129 * src/modest-tny-account.c: (on_connection_status_changed):
1130 Do not use tny_device_force_offline() when tinymail says that something
1131 went wrong with the connection. It seems to report this unnecessarily.
1133 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1135 * src/maemo/modest-connection-specific-smtp-window.c:
1136 (modest_connection_specific_smtp_window_init):
1137 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1138 does not seem to have any effect in osso 1.1 (though it works in
1139 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1141 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1143 * src/maemo/modest-connection-specific-smtp-window.c:
1144 Fix UI specification problems with projects.meamo.org NB#60479
1146 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1149 clue when this has failed, because the error dialog is not always shown
1150 (at least in earlier version).
1152 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1153 GError message, because the generic error dialog is not helpful.
1155 'This message is not currently available (can't let a new connection go online)'
1156 when trying to open an IMAP message.
1158 (_modest_ui_actions_open): Offer a connection when some messages would
1159 have to be downloaded and we are offline.
1161 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1163 * src/widgets/modest-folder-view.c:
1164 Don't check for MERGE type anymore as we use the correct type
1166 NOTE: For the last two changes you need to update your tinymail copy
1167 because of API changes!
1169 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1171 * src/modest-tny-local-folders-account.c:
1172 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1173 (see projects.maemo.org NB#61580)
1175 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1177 * src/modest-tny-account.c: (on_connection_status_changed):
1178 Commented out the call to modest_platform_connect_and_wait() because this
1179 seems to always hang, and I would like to know if this is the only thing
1180 that causes a hang when showing the connection dialog.
1181 It is not very useful anyway.
1183 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1185 * src/maemo/modest-msg-view-window.c:
1186 (modest_msg_view_window_select_next_message):
1188 * src/modest-platform.h:
1189 * src/maemo/modest-platform.c:
1190 Added modest_platform_connect_and_wait(), which calls
1191 tny_maemo_conic_device_connect() always in the main thread, by calling it
1192 in an idle handler and waiting for the idle handler to run. It should be
1193 in the main thread because it uses GTK+ UI code. It just returns TRUE
1194 if the device is already online.
1196 There is some nasty code to ensure that subsequent calls to
1197 modest_platform_connect_and_wait() just wait for the first one to finish,
1198 by checking repeatedly in another idle handler. This is necessary,
1199 because other threads (or even the main thread, via another idle handler)
1200 can call modest_platform_connect_and_wait() while
1201 modest_platform_connect_and_wait() is running.
1203 (modest_platform_connect_and_wait_if_network_account),
1204 (modest_platform_connect_and_wait_if_network_folderstore):
1205 Convenience functions that calls modest_platform_connect_and_wait() if
1206 the account or folder might want network access.
1208 * src/modest-mail-operation.c:
1209 (modest_mail_operation_update_account):
1210 * src/modest-ui-actions.c: (download_uncached_messages),
1211 (modest_ui_actions_on_rename_folder), (delete_folder),
1212 (modest_ui_actions_on_main_window_move_to),
1213 (modest_ui_actions_on_msg_view_window_move_to):
1214 * src/widgets/modest-folder-view.c:
1215 (drag_and_drop_from_folder_view):
1216 Offer a connection if we are offline.
1218 * src/modest-tny-account.c: (on_connection_status_changed):
1219 Document this as only handling errors during network operations in progress,
1220 and replace the idle code with a simple call to
1221 modest_platform_connect_and_wait(), which does this instead.
1223 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-tny-account.c:
1226 (modest_tny_account_get_special_folder): (util_on_idle),
1227 Handle the GError so we can see when tny_folder_store_get_folders()
1228 fails, as it currently does while something else is connecting.
1230 Added util_run_in_main_thread_and_wait()
1231 which uses an idlen handler and mainloop to ensure that the function
1232 is called in the main thread.
1233 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1234 to make sure that we call attempt the connection in the mainloop only,
1235 which might solve some hangs.
1237 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1239 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1240 be found by their display name. This is never useful.
1241 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1242 by its ID, instead of trying to use its ID as its display name.
1244 * src/modest-tny-account-store.h:
1245 * src/modest-tny-account.c:
1246 (modest_tny_account_get_special_folder): Add a g_warning() when
1247 tny_folder_store_get_folders() returns an empty list for the maildir.
1249 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1250 Add a g_warning() when this returns NULL, because that it not allowed
1253 2007-07-02 Armin Burgmeier <armin@openismus.com>
1255 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1256 note when trying to cancel the wizard. This fixes projects.maemo.org
1259 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-tny-account.h:
1262 * src/modest-tny-account.c:
1263 (modest_tny_account_new_from_server_account),
1264 (modest_tny_account_new_from_server_account_name),
1265 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1266 because this must now be set before setting the proto. This is usd in
1267 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1268 warning in camel_session_get_service() caused by
1269 tny_camel_transport_account_prepare().
1271 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1274 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1276 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1278 (modest_connection_specific_smtp_edit_window_init):
1280 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1281 of "changed" for now
1283 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-tny-account.c:
1286 (modest_tny_account_new_from_server_account):
1287 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1288 now uses to request a connection when it needs one, and which it uses
1289 to tell us that something is wrong with the connection, so we can force
1290 the accounts offline to prevent further problems.
1292 * src/modest-defs.h:
1293 * src/modest-init.c: (init_default_settings):
1294 * src/modest-mail-operation.c:
1295 (modest_mail_operation_update_account):
1296 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1297 This should not be necessary anymore. Do not set the conf key that
1298 determined this (it was always TRUE and not set anywhere else).
1300 * src/modest-ui-actions.h: Remove unused and unimplemented
1301 modest_ui_actions_on_online_toggle_toggled().
1303 2007-06-29 Murray Cumming <murrayc@murrayc.com
1305 * src/maemo/modest-main-window.c: (connect_signals):
1306 Don't connect to delete_event twice. Maybe this was harmless.
1308 2007-06-29 Murray Cumming <murrayc@murrayc.com
1310 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1311 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1312 Debug output to give some more clue when a folder move is not allowed.
1314 2007-06-28 Murray Cumming <murrayc@murrayc.com
1316 * src/modest-tny-account.c: (on_modest_file_system_info),
1317 (modest_tny_account_get_mmc_account_name):
1318 Always call the callback, without checking whether the name has changed.
1319 * src/widgets/modest-folder-view.c: (strings_are_equal),
1320 (on_model_foreach_set_name), (on_get_mmc_account_name),
1321 (text_cell_data): Compare the name here, and use the name from
1322 the account rather than from the
1323 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1324 if the name was changed after the account was added to the model.
1325 That's a tinymail bug but not one that I want to fix now.
1327 This finally fixes projects.maemo.org bug NB#59301.
1329 2007-06-27 Armin Burgmeier <armin@openismus.com>
1331 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1334 2007-06-27 Murray Cumming <murrayc@murrayc.com
1336 * src/modest-tny-account.h:
1337 * src/modest-tny-account.c:
1338 Added modest_tny_account_get_mmc_account_name(), to set the memory
1339 card name asynchronously for the given account and then notify.
1340 (modest_tny_account_new_for_local_folders): Use this new function instead
1341 of using hildon_file_system_info_async_new() directly.
1343 * src/widgets/modest-folder-view.c: (text_cell_data):
1344 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1345 gtk_tree_model_row_changed() when it is available.
1347 This should fix projects.maemo.org bug NB#59301.
1349 2007-06-27 Murray Cumming <murrayc@murrayc.com
1351 * src/modest-mail-operation.c: (update_account_thread),
1352 (get_msgs_full_thread): Fix typo failures in the revert
1355 2007-06-27 Murray Cumming <murrayc@murrayc.com
1357 * src/maemo/modest-maemo-global-settings-dialog.c:
1358 (idle_select_default_focus):
1359 * src/modest-mail-operation.c: (idle_notify_progress),
1360 (idle_notify_progress_once), (set_last_updated_idle),
1361 (update_account_thread), (get_msgs_full_thread):
1362 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1363 * src/widgets/modest-header-view.c:
1364 (idle_notify_headers_count_changed_destroy),
1365 (idle_notify_headers_count_changed):
1366 Reverted the additions of gdk_threads_enter/leave(), in case this
1367 helps with a startup hang on the device.
1369 2007-06-26 Armin Burgmeier <armin@openismus.com>
1371 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1372 for supported secure authentication methods from server by
1373 gtk_dialog_run(), saving CPU time and a potential race condition.
1375 2007-06-26 Armin Burgmeier <armin@openismus.com>
1377 * src/maemo/modest-maemo-utils.h:
1378 * src/maemo/modest-maemo-utils.c: Added a
1379 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1380 only error code to tell the calling code when the user canceled the
1383 * src/maemo/modest-account-settings-dialog.h:
1384 * src/maemo/modest-account-settings-dialog.c:
1385 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1386 message if the retrieval of secure authentication methods was canceled
1387 by the user. Perform the check before saving anything to configuration
1388 to not end up with half-committed configuration changes, do not show
1389 a "Saving to configuration failed" note when authentication methods
1390 could not be retrieved.
1392 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1395 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1397 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1398 Only return the first level of folders under accounts, because the
1399 osso-global-search UI spec doesn't want the rest.
1400 This fixed projects.maemo.org bug NB#61811.
1402 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1404 * src/modest-tny-account-store.c:
1405 * src/modest-tny-account-store.h:
1406 Added modest_tny_account_is_memory_card_account().
1407 * src/maemo/modest-main-window.c: (create_details_widget):
1408 Show the same information items for the memory card as we show for the
1409 local-folders, to fix projects.maemo.org bug NB#59307.
1411 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1413 * src/modest-tny-account-store.c: (get_password):
1414 Added some checks for NULL to maybe prevent crashes, though I think
1415 it was Philip's last commit that actually prevented the crash here
1416 when creating a first new account.
1417 But the new account is still not usable (no messages are shown)
1418 until a restart of the application.
1420 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1422 * src/maemo/modest-maemo-global-settings-dialog.c:
1423 (idle_select_default_focus):
1424 * src/modest-mail-operation.c: (idle_notify_progress),
1425 (idle_notify_progress_once), (idle_notify_update_account_queue),
1426 (set_last_updated_idle), (update_account_thread),
1427 (notify_get_msgs_full), (get_msgs_full_destroyer),
1428 (get_msgs_full_thread):
1429 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1430 * src/widgets/modest-header-view.c:
1431 (idle_notify_headers_count_changed_destroy),
1432 (idle_notify_headers_count_changed):
1433 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1434 all idle handlers, because some other thread could be blocking
1435 the GDK lock, so that it can do GUI stuff.
1437 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1439 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1440 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1441 (on_idle_send_receive), (on_idle_open_default_inbox):
1442 * src/maemo/modest-msg-edit-window.c:
1443 (modest_msg_edit_window_attach_file_noninteractive):
1444 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1445 to prevent a hang. I don't quite understand why these are necessary,
1446 beause we should already be in the main loop. I guess something outside
1447 of the main loop is taking the lock.
1449 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1450 we are really using URIs, and use files that are more likely to exist.
1452 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1454 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1455 necessary because configure.ac now defines different variables.
1457 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1459 * libmodest-dbus-client/libmodest-dbus-client.c:
1460 * libmodest-dbus-client/libmodest-dbus-client.h:
1461 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1462 libmodest_dbus_client_compose_mail() is what things actually use.
1464 * src/dbus_api/modest-dbus-api.h:
1465 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1466 * tests/dbus_api/Makefile.am:
1467 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1470 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1472 * src/modest-init.c: (modest_init_local_folders):
1473 For memory-card (or other non local-folders) maildir accounts,
1474 always create an Archive folder, so that there is somewhere to put
1475 messages. This should be less confusing, because the user does not need
1476 to guess that the need to create a folder.
1478 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1480 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1481 Fixed icon size by using (50, 50) which is the same as defined by
1484 2007-06-25 Armin Burgmeier <armin@openismus.com>
1486 * src/widgets/modest-window-mgr.c:
1487 * src/modest-init.c:
1488 * configure.ac: Correctly recognize hildon-notify presence and fixed
1489 the build without it being installed.
1491 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1493 * libmodest-dbus-client/libmodest-dbus-client.c:
1494 (libmodest_dbus_client_search): Fix the build. Sorry.
1495 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1496 (reply_forward_cb): Initialize variables to fix the build.
1498 * src/modest-tny-account-store.c:
1499 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1500 comparison (a silly typo) so that email search results can be opened
1501 when there are more than one account.
1503 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1505 * libmodest-dbus-client/libmodest-dbus-client.c:
1506 (libmodest_dbus_client_search),
1507 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1508 instead of 1 second, because the search gets folders and messages from
1509 the server, which can take a long time. When it times out,
1510 osso-global-search will report no results.
1512 We need to specify whether we should search only cached information
1513 (maybe with a user preference), and the osso-email-search-plugin
1514 API should really be improved to allow that option, and to allow results
1515 to be delivered asynchronously in batches.
1517 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1520 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1521 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1523 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1525 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1526 that is an empty string. D-Bus seems to give us these instead of NULL.
1528 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1530 * src/dbus_api/modest-dbus-callbacks.c:
1531 * src/maemo/easysetup/modest-easysetup-wizard.h:
1532 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1533 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1534 (modest_connection_specific_smtp_edit_window_init):
1535 * src/maemo/modest-maemo-global-settings-dialog.c:
1537 * src/maemo/modest-maemo-utils.c:
1538 (modest_maemo_utils_setup_images_filechooser):
1539 * src/maemo/modest-main-window.c: (create_details_widget):
1540 * src/maemo/modest-msg-edit-window.c:
1541 (modest_msg_edit_window_attach_file_noninteractive),
1542 (modest_msg_edit_window_color_button_change),
1543 (modest_msg_edit_window_set_zoom):
1544 * src/modest-mail-operation.c: (update_account_thread):
1545 * src/modest-tny-account-store.c:
1546 * src/modest-tny-account.c:
1547 * src/widgets/modest-global-settings-dialog.c:
1548 * src/widgets/modest-window.h:
1550 Fixed build on bora!
1552 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1554 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1555 * src/modest-search.c: (modest_search_folder),
1556 (modest_search_all_accounts): Actually search only in the specified folder,
1557 doing a simple match on the folder ID.
1558 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1559 and added some documentation.
1561 2007-06-22 Armin Burgmeier <armin@openismus.com>
1563 * src/maemo/modest-maemo-utils.h:
1564 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1565 modest_maemo_utils_get_supported_secure_authentication_methods.
1567 * src/maemo/easysetup/modest-easysetup-wizard.c:
1568 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1569 one occured, not just "Server does not support secure authentication".
1571 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1573 * src/modest-tny-account-store.c: (get_password):
1574 Restored the call to tny_account_set_user() because Philip seems to have
1575 stopped this from crashing (by not using the freed string). It still does
1576 not work, but now we can test it.
1578 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1580 * src/maemo/modest-msg-edit-window.c: (init_window):
1581 Comment out use of an uninitialzed GtkScrolledWindow variable,
1582 to fix the build and stop a crash. Yet again.
1584 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account-store.c: (get_password):
1587 Remove the call to tny_account_set_user() because this actually crashes.
1588 As mentioned in the last commit, it is known to not work anyway.
1590 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-tny-account-store.c: (get_password):
1593 Use tny_account_set_username() to tell tinymail that the username might
1594 have changed too. But tinymail ignores this: see projects.maemo.org
1596 * src/modest-ui-actions.c:
1597 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1598 reset the connection when changing the username, and improve the comments.
1599 Save the changed username to gconf at least, so it is used when Modest is
1602 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1604 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1605 Do not use a query, so that we get all folders, including for POP and
1606 local-folders. They work as search criteria too.
1607 This fixes projects.maemo.org bug NB#57740.
1609 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1611 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1612 Comment out the use of hildon_notification_set_sound() because it is
1613 not declared, to fix the build. Warnings are serious, people.
1615 2007-06-21 Armin Burgmeier <armin@openismus.com>
1617 * src/maemo/modest-maemo-utils.h:
1618 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1619 modest_maemo_utils_get_supported_secure_authentication_methods()
1620 to query authentication methods for a specific user. This should fix
1621 projects.maemo.org bug NB#61369.
1623 * src/maemo/easysetup/modest-easysetup-wizard.c:
1624 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1627 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1629 * libmodest-dbus-client/libmodest-dbus-client.h:
1630 * libmodest-dbus-client/libmodest-dbus-client.c:
1631 (modest_dbus_message_iter_get_search_hit),
1632 (libmodest_dbus_client_search):
1633 Reorganised and commented this.
1634 Removed modest_search_hit_free() from the public API because it
1637 Added libmodest_dbus_client_get_folders() and
1638 modest_folder_result_list_free().
1640 * src/dbus_api/modest-dbus-api.h:
1641 * src/dbus_api/modest-dbus-callbacks.c:
1642 (modest_dbus_req_filter): Commented. Moved most code to
1643 on_dbus_method_search() and added on_dbus_method_get_folders().
1645 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1646 of the extra D-Bus handler.
1648 * tests/dbus_api/Makefile.am:
1649 * tests/dbus_api/test_get_folders.c: New test for
1650 libmodest_dbus_client_get_folders(). This seems to return an empty list
1651 at the moment. That could be the same error that causes the message list
1652 to be empty sometimes.
1653 This should help with projects.maemo.org bug NB#57740.
1655 2007-06-21 Armin Burgmeier <armin@openismus.com>
1657 * src/modest-mail-operation.c: Do not call
1658 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1659 notify the operation's end after having set the status to CANCELED for
1660 the operation queue to listen on. This fixes a deadlock when there
1661 were mail operations in the queue during its finalization.
1663 * src/modest-singletons.c: Reordered uninitialization of the account
1664 manager to happen after the mail operation queue was uninitialized
1665 because the mail operation's in the queue might still try to access
1666 the account manager (see modest_mail_operation_notify_end()). This
1667 fixes a potential crash when terminating the application.
1669 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1671 * src/modest-search.c:
1672 (search_mime_part_and_child_parts): Moved some code here so we
1673 can search recursively in child folders.
1674 (modest_search_folder): Search in the message as a mime part, instead
1675 of just its child mime parts.
1676 (read_chunk), (search_mime_part_ogs):
1677 Check how many bytes were read, to prevent an endless loop.
1678 Searching in message bodies now works. This finishes the fix for
1679 projects.maemo.org bug NB#61007.
1681 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1683 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1684 Add a g_warning when the item is not a folder.
1686 * src/modest-ui-dimming-rules.c:
1687 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1688 when selected item is not a folder (for instance, an account), because
1689 the UI spec only talks about folders.
1690 I am not sure what the UI spec wants, so this might not totally fix
1691 projects.maemo.org bug NB#60794.
1693 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1695 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1696 (load_from_file): Sort the list. The unsorted list would be more noticeable
1697 in non-English locales.
1699 * src/maemo/modest-msg-edit-window.c:
1700 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1701 warning and fix the build.
1703 * src/maemo/modest-progress-bar-widget.c:
1704 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1705 avoid a g_warning, and probably to avoid a crash.
1707 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-search.c: (modest_search_folder): Check for a GError
1710 when calling tny_folder_get_headers(), to show that this is not the cause
1713 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1715 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1716 Actually set the body query instead of the subject query.
1718 * src/modest-search.c: (search_mime_part_ogs),
1719 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1720 which would probably cause it to fail if we got this far.
1722 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1723 to simplify the code.
1724 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1725 be causing search-in-body to fail.
1727 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1729 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1731 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1732 Better debug message when the folder cannot be found.
1733 This should help with fixing projects.maemo.org bug #61287.
1734 * src/modest-search.c: (add_hit): Do not leak the furl string.
1736 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-ui-actions.c:
1739 (modest_ui_actions_on_folder_selection_changed):
1740 Do not special-case TNY_MERGE_FOLDER here, because
1741 modest_tny_folder_get_account() already does that. This fixes
1742 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1743 shown when the Outbox was selected).
1745 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1747 * libmodest-dbus-client/libmodest-dbus-client.c:
1748 (_dbus_iter_get_string_or_null): Initialize the string variable in
1749 case this helps with Dirk's crash.
1751 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1753 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1754 though it is not implemented yet (this function is maybe not even used),
1755 to avoid breaking ABI in future.
1756 * libmodest-dbus-client/libmodest-dbus-client.c:
1757 (get_attachments_string): Moved some code into this generic function.
1758 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1759 sends email. It is maybe not used.
1760 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1761 (on_send_mail): Use attachments.
1763 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1764 * src/maemo/modest-msg-edit-window.c:
1765 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1766 a filename before using it, to fix projects.maemo.org bug NB#58233.
1768 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1771 Initialize the continue_download variable to fix the build, and probably
1772 to fix randome behaviour.
1774 2007-06-18 Armin Burgmeier <armin@openismus.com>
1776 * src/modest-tny-send-queue.h:
1777 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1778 the queue so we can later show it in the UI. Replaced
1779 modest_tny_send_queue_msg_is_being_sent() by
1780 modest_tny_send_queue_get_msg_status().
1782 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1784 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1785 gpointer. This probably was not harmful, but just to be sure.
1787 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1789 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1790 Fix the build, but leave the function broken on Bora, because
1791 hildon_uri_action_get_service() does not exist.
1792 osso_uri_action_get_service() does not exist either, it seems.
1794 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-tny-account.c:
1797 (modest_tny_account_new_from_server_account):
1798 Uncommented the url debug output again, because it is useful for
1799 debugging, as I said in the comment.
1801 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1803 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1805 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1806 for Mameo Bora, to fix the build.
1808 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1811 Fixed build with hildon < 0.99
1813 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1814 Check if the selected account is busy instead of checking all accounts
1816 * src/modest-account-mgr-priv.h:
1817 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1818 (modest_account_mgr_init), (compare_account_name),
1819 (modest_account_mgr_set_account_busy),
1820 (modest_account_mgr_account_is_busy):
1821 * src/modest-account-mgr.h:
1822 Added busy information to the account manager. It possible to
1823 set an account to busy or not busy now.
1825 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1826 (modest_mail_operation_update_account),
1827 (modest_mail_operation_notify_end):
1828 Set the account to busy/not busy depending on the operation state.
1830 * src/widgets/modest-account-view.c:
1831 (modest_account_view_finalize), (get_last_updated_string),
1832 (update_account_view), (on_account_busy_changed), (init_view):
1833 Show string "Refreshing..." if the account is currently busy.
1835 All this fixes projects.maemo.org bug NB#59711
1837 2007-06-14 Armin Burgmeier <armin@openismus.com>
1839 * src/widgets/modest-attachments-view.h:
1840 * src/widgets/modest-attachments-view.c: Added
1841 modest_attachments_view_has_attachments() and fixed coordinate
1842 transformation in get_att_view_at_coords(). This fixes attachment
1845 * src/widgets/modest-msg-view.c: Make use of
1846 modest_attachments_view_has_attachments() to decide whether to show
1847 attachments in the header.
1849 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1851 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1852 (on_change), (on_combo_security_changed),
1853 (modest_connection_specific_smtp_edit_window_init),
1854 (modest_connection_specific_smtp_edit_window_set_connection),
1855 (modest_connection_specific_smtp_edit_window_is_dirty):
1856 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1857 * src/maemo/modest-connection-specific-smtp-window.c:
1860 Show an comfirmation dialog for the smpt-edit-window if there are
1861 unsaved changes and the user hits cancel.
1862 (projects.maemo.org bug NB#60479)
1864 2007-06-14 Armin Burgmeier <armin@openismus.com>
1866 * src/maemo/easysetup/modest-easysetup-wizard.c:
1867 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1868 address" info in banner instead of node, and select all the text as
1869 per UI spec. This fixes projects.maemo.org bug NB#60550.
1871 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1873 reviewed by: <delete if not using a buddy>
1875 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1876 * src/modest-ui-actions.c: (folder_refreshed_cb):
1878 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1880 * src/widgets/modest-folder-view.c: (filter_row):
1881 Explictly filter out the per-account outbox accounts. I don't know why
1882 these only sometimes show up, but now they should never show up in the UI.
1883 This should fix projects.maemo.org bug NB#60160.
1885 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1887 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1888 when the toolbar does not exist yet.
1889 * src/modest-widget-memory.c: (save_settings_header_view):
1890 Added g_warnings() to help us to discover when we are trying to set
1891 an empty columns list in gconf.
1893 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1895 * src/modest-init.h:
1896 * src/modest-init.c:
1897 Added modest_init_get_default_header_view_column_ids().
1899 * src/modest-widget-memory.c: (restore_settings_header_view):
1900 Use the new function to get defaults, if the gconf key is empty,
1901 instead of not creating any columns. This seems to fix the
1902 empty right-hand pane problems.
1904 * src/widgets/modest-header-view.h: Improved documentation.
1906 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1908 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1909 Revert the use of the display name as the account name, because this
1910 is generally wrong and would break the code that follows.
1912 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1914 * src/maemo/easysetup/modest-easysetup-wizard.c:
1915 (check_for_supported_auth_methods), (on_before_next),
1918 More correct fix for projects.maemo.org bug NB# 58991
1919 Do not longer accept AUTH_PASSWORD as secure method and choose
1920 correct method when creating the account.
1922 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1924 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1925 Fixed projects.maemo.org bug NB# 58991
1927 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-init.c: (modest_init_init_core),
1930 (modest_init_local_folders): Fixed compilation errors.
1932 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1934 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1935 Remove unnecessary lib/include, though it is good in principle when needed.
1937 * src/modest-init.c: (modest_init_one_local_folder),
1938 (modest_init_local_folders):
1939 * src/modest-init.h: Initialize the .modest library for memory cards,
1940 instead of just doing nothing for them. This should allow us to create
1941 folders there, fixing projects.maemo.org bug NB#59297.
1943 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1945 * libmodest-dbus-client/libmodest-dbus-client.c:
1946 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1947 (libmodest_dbus_client_compose_mail),
1948 (libmodest_dbus_client_open_message),
1949 (libmodest_dbus_client_send_and_receive),
1950 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1952 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1953 (on_idle_open_message), (modest_dbus_req_handler),
1954 (search_result_to_message), (modest_dbus_req_filter):
1955 * src/modest-search.c: (add_hit), (modest_search_folder),
1956 (modest_search_all_accounts): Improved debug messages.
1958 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1960 * src/modest-tny-account-store.c:
1961 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1964 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1967 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1969 * src/modest-tny-account-store.c: (get_server_accounts):
1970 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1971 even when there are no accounts, so that the Outbox folder is always
1972 visible. This fixes projects.maemo.org bug NB#60158.
1974 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1976 * src/maemo/modest-main-window.c: (create_details_widget):
1977 Use the mcen_va_never logical ID.
1979 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1981 * src/dbus_api/modest-dbus-api.h:
1982 * src/dbus_api/modest-dbus-callbacks.c:
1983 (on_idle_open_default_inbox), (on_open_default_inbox),
1984 (modest_dbus_req_handler):
1985 Added a new OpenDefaultInbox method.
1987 * libmodest-dbus-client/libmodest-dbus-client.h:
1988 * libmodest-dbus-client/libmodest-dbus-client.c:
1989 Added libmodest_dbus_client_open_default_inbox() to call the new
1990 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1991 though it should maybe be used by a new osso-email-interface function.
1993 * tests/dbus_api/Makefile.am:
1994 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1997 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1999 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2000 NULL, so that the signals get all the keys. This should not actually
2001 change any behaviour because we currently update everything when anything
2004 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2006 * src/widgets/modest-folder-view.c: (text_cell_data),
2007 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2008 (find_inbox_iter): If tinymail tells us that the folder is
2009 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2010 This causes the inbox to be selected at startup, fixing part of
2011 projects.maemo.org bug NB#56305.
2013 * src/modest-ui-dimming-rules.c:
2014 (modest_ui_dimming_rules_on_tools_smtp_servers):
2015 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2016 the SMTP servers menu item.
2017 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2018 that the SMTP Servers menu item is dimmed when there are no accounts,
2019 as a future version of the UI spec will require. This fixes
2020 projects.maemo.org bug NB#56305.
2022 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2024 * src/maemo/modest-maemo-utils.c:
2025 (modest_maemo_utils_get_supported_secure_authentication_methods):
2026 Added label to dialog instead of unreadable title
2028 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2029 (modest_main_window_new):
2030 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2033 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2034 * src/modest-account-mgr.h:
2035 Added method to avoid code duplication
2037 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2038 (modest_ui_actions_on_send_receive):
2039 Use modest_account_mgr_has_accounts
2041 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2043 * src/maemo/easysetup/modest-presets.c:
2044 (modest_presets_get_info_server_security): Do not report secure auth
2046 * src/modest-protocol-info.c: Use the defines for the gconf key names
2047 for secure authentication. This was not working because we were writing
2048 Password and reading password, and the check was case sensitive.
2049 With this, gmail now works for receiving and sending when created via
2052 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2054 * src/maemo/easysetup/modest-presets.c:
2055 (modest_presets_get_info_server_security): Correct the key name for
2056 SecureSmtp, because it seems to be case-sensitive.
2057 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2058 Do not try to get the 0th notebook page if there are 0 pages, to
2059 avoid a g_warning().
2061 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2064 Prevent use of the new notification feature for now, because it currently
2065 shows one dialog for each new email, which is annoying.
2067 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2070 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2071 when no country was selected, so that we show the global ones.
2072 * src/maemo/easysetup/modest-presets.c:
2073 (modest_presets_get_providers): Return only the global providers, not
2074 all providers when mmc=0 was requested.
2076 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2079 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2080 provider ID in the combo.
2082 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2083 Do not show the page numbers, because it would be confusing when we add
2084 the 2 extra pages for the custom setup, when the user chooses the "Other"
2085 provider. This fixes projects.maemo.org bug NB#59028
2087 * src/modest-init.c: (modest_init_init_core),
2088 (modest_init_local_folders):
2089 * src/modest-init.h:
2090 * src/modest-tny-account.c:
2091 (modest_tny_account_new_for_local_folders): Do not create default folders
2092 for the memory card. This should fix projects.maemo.org bug NB#59328.
2094 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2096 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2097 Free the changed_conf_keys string items. They are already freed in the
2098 idle handler if that runs first.
2100 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2102 * src/modest-ui-actions.c:
2103 (modest_ui_actions_on_password_requested): Check that the server name
2104 is not NULL, because I just saw a password dialog with (null) as the
2107 * src/modest-tny-folder.[h|c]: Added
2108 modest_tny_folder_is_memory_card_folder().
2109 * src/modest-ui-dimming-rules.c:
2110 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2111 menu item for memory cards, as per the UI spec (section 7.4). This should
2112 fix projects.maemo.org bug NB#59297.
2114 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2116 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2117 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2118 is another problem with the code, see Murray's comment at line 772)
2120 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2123 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2124 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2125 (load_from_file), (easysetup_country_combo_box_init),
2126 (easysetup_country_combo_box_get_active_country_ids),
2127 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2128 instead of just one ID, to avoid duplicate country names in the UI.
2130 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2131 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2132 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2133 a single ID, avoiding duplicate providers.
2134 * src/maemo/easysetup/modest-easysetup-wizard.c:
2135 (on_combo_account_country): Adapt to use a list.
2137 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2140 keys changed in the last X seconds.
2142 * src/modest-account-mgr.h:
2143 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2144 (on_key_change), (modest_account_mgr_class_init),
2145 (modest_account_mgr_init), (modest_account_mgr_finalize):
2146 As the keys are changed, save them in a GSList* and signal that GSList*
2147 further every X seconds, to batch changes, to allow us to do just one
2148 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2149 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2151 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2152 changed signal signature.
2154 * src/modest-conf.c: (modest_conf_set_list),
2155 (modest_conf_on_change): Reenable notification.
2157 (modest_conf_maemo_fake_on_change): Comment out the hack that
2158 notified immediately instead of asynchronously.
2160 * src/widgets/modest-account-view.h:
2161 * src/widgets/modest-account-view.c:
2162 (update_account_view): Select the previously-selected account ID,
2163 if possible. This fixes projects.maemo.org bug NB#56933.
2165 (on_account_changed), (on_account_removed),
2166 (modest_account_view_select_account):
2168 Remove the block/unblock functions
2169 because they were not useful.
2171 * src/maemo/modest-account-view-window.c:
2172 (on_delete_button_clicked), (on_edit_button_clicked),
2173 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2175 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2178 Improve the error dialog to show Incorrect Account Settings, which seems
2179 clearer, and say that the internal error message (to be removed from the
2180 dialog later) is often misleading.
2181 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2183 * src/modest-tny-account.c:
2184 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2185 URL because this is so useful for debugging on the device.
2187 * src/widgets/modest-serversecurity-combo-box.c:
2188 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2190 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2192 * src/modest-mail-operation.c:
2193 (modest_mail_operation_send_new_mail):
2194 Added a comment about a nasty but apparently harmless message. Details
2195 added to the wiki g_warnings() page.
2197 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2199 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2200 (modest_tny_send_queue_class_init):
2201 Do not use the priv struct because it is empty, to avoid g_warnings
2202 about a non-existant priv struct.
2204 * src/modest-tny-account-store.c:
2205 (modest_tny_account_store_get_server_account),
2206 (modest_tny_account_store_get_transport_account_for_open_connection
2207 ): Do not try to get transport server accounts for local folders,
2208 because they don't have any. This avoids a g_warning().
2210 * src/maemo/modest-main-window.c:
2211 (modest_main_window_notify_send_receive_initied),
2212 (on_configuration_key_changed):
2213 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2214 * src/modest-defs.h:
2215 * src/modest-mail-operation.c:
2216 (modest_mail_operation_update_account):
2217 * src/modest-tny-account-store.h:
2218 * src/modest-tny-account.c:
2219 (modest_tny_account_get_special_folder),
2220 (modest_tny_account_new_for_local_folders),
2221 (modest_tny_account_new_for_per_account_local_outbox_folder):
2222 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2223 * src/modest-tny-local-folders-account.c:
2224 (add_account_folders_to_merged_folder):
2225 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2226 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2227 (modest_ui_actions_on_send):
2228 * src/widgets/modest-folder-view.c: (update_model):
2229 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2230 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2231 modest_tny_account_store_get_tny_account_by_account() to
2232 modest_tny_account_store_get_server_account() to make the code clearer.
2234 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2236 * src/dbus_api/modest-dbus-api.h:
2237 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2238 * src/maemo/modest-msg-edit-window.c:
2239 (modest_msg_edit_window_attach_file_noninteractive):
2240 added g_warning in case the file to be attached does not exist
2241 * tests/dbus_api/test_compose_mail.c: (main):
2242 removed obsolete comment, added generic files as test case
2244 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2246 * src/modest-tny-account-store.c: (get_server_accounts):
2247 Create the local folders account only once, not once for each outbox, and
2248 not only when there are some outboxes.
2250 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2252 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2253 code that is causing a crash at startup. Sergio says that he is fixing this.
2255 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2257 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2258 * src/maemo/modest-account-settings-dialog.c:
2259 (create_page_outgoing),
2260 (modest_account_settings_dialog_set_account_name),
2261 (save_configuration):
2262 - Fixed handling of the "Use secure authentication" toggle to comply with
2263 the ui specification. See also projects.maemo.org bug NB#58400
2265 - Restore the Secure connection setting combo correctly when loading
2268 * src/maemo/modest-maemo-utils.c:
2269 (on_camel_account_get_supported_secure_authentication),
2270 (modest_maemo_utils_get_supported_secure_authentication_methods):
2271 Fixed a crasher if operation is canceled
2273 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2274 (modest_protocol_info_auth_is_secure):
2275 * src/modest-protocol-info.h:
2277 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2278 the sense of the "Use secure authentication" toggle.
2280 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2282 * src/modest-tny-account-store.h:
2283 * src/modest-tny-account-store.c:
2284 Added modest_tny_account_store_get_local_folders_account().
2286 * src/modest-tny-folder.h:
2287 * src/modest-tny-folder.c:
2288 (modest_tny_folder_get_account):
2289 Added this replacement for tny_folder_get_account() which returns
2290 the local-folders account for TnyMergeFolders, to avoid the
2291 warning about the unimplemented get_account_func() vfunc().
2293 (modest_tny_folder_get_rules),
2294 * src/modest-ui-actions.c:
2295 (modest_ui_actions_on_folder_selection_changed):
2296 * src/modest-mail-operation.c:
2297 (modest_mail_operation_remove_folder),
2298 (modest_mail_operation_xfer_folder),
2299 (modest_mail_operation_rename_folder),
2300 (modest_mail_operation_get_msg),
2301 (modest_mail_operation_get_msgs_full),
2302 (modest_mail_operation_remove_msg),
2303 (modest_mail_operation_xfer_msgs),
2304 (modest_mail_operation_refresh_folder):
2305 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2307 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2310 (modest_server_account_set_security):
2311 * src/modest-defs.h: Add comments explaining that our
2312 UI spec means TLS when it says Normal, so these do not look like errors.
2314 * src/modest-tny-account.c:
2315 (modest_tny_account_new_from_server_account): Use the new tinymail
2316 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2317 for TLS. This should fix projects.maemo.org bug NB#58460.
2319 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/easysetup/modest-easysetup-wizard.c:
2322 (create_account): Correct the position of the gconf sanity check warning.
2323 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2324 of using the g_idle_add() hack, because this does not seem to be necessary
2325 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2326 caused by something other than maemo's gconf.
2327 This fixes projects.maemo.org bug #59022.
2329 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-account-mgr-helpers.c:
2332 (modest_account_mgr_get_default_account): Do not check that the account
2333 exists if there is no default account (NULL), to fix a runtime warning.
2335 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2337 * src/widgets/modest-folder-view.c: (update_model):
2338 Do not unref the treemodel before we have finished with it.
2339 This prevents a valgrind warning and an occasional crash at startup.
2341 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2343 * libmodest-dbus-client/libmodest-dbus-client.h:
2344 added libmodest_dbus_client_compose_mail()
2345 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2347 added functions needed for SendAsMail() functionality
2348 * src/maemo/modest-msg-edit-window.c:
2349 (modest_msg_edit_window_attach_file_noninteractive):
2350 non interactively attaching files to message edit window
2351 * src/widgets/modest-msg-edit-window.h:
2352 * tests/dbus_api/Makefile.am:
2353 added test_compose_mail.c
2354 * tests/dbus_api/test_compose_mail.c: (main):
2356 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2358 * src/modest-account-view.c:
2359 Fixed bug projects.maemo.org bug NB#59307
2361 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2363 * src/maemo/easysetup/modest-easysetup-wizard.c:
2364 (get_serverport_incoming), (on_before_next), (create_account):
2365 * src/maemo/modest-account-settings-dialog.c:
2366 (modest_account_settings_dialog_set_account_name):
2367 * src/maemo/modest-maemo-utils.c:
2368 (on_camel_account_get_supported_secure_authentication_status),
2369 (on_camel_account_get_supported_secure_authentication),
2370 (on_secure_auth_cancel),
2371 (modest_maemo_utils_get_supported_secure_authentication_methods):
2373 Implemented security authentication for settings and easysetup.
2375 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2377 * src/maemo/modest-main-window.c: (create_details_widget):
2378 Show the total size for memory card accounts too, instead of showing
2379 the name again. Fixes bug projects.maemo.org bug NB#59307.
2381 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2384 * src/modest-tny-simple-folder-store.c:
2385 * src/modest-tny-simple-folder-store.h: Removed.
2387 * src/modest-tny-local-folders-account.h
2388 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2389 for the local-folders maildir, with an extra TnyMergedFolder containing
2390 the folders of the per-account outbox store accounts.
2391 * src/modest-tny-account-store.c: (get_server_accounts):
2392 Add the outboxes to the special local folders account after creating it.
2394 * src/modest-tny-account.c:
2395 (modest_tny_account_new_for_local_folders): Create the derived
2396 account when creating the main local-folders account.
2398 * src/maemo/modest-main-window.c: (create_details_widget),
2399 (modest_main_window_set_contents_style):
2400 Adapted to the use of the derived account instead of the folder store.
2402 * src/modest-ui-actions.c:
2403 (modest_ui_actions_on_folder_selection_changed):
2404 * src/modest-ui-dimming-rules.c:
2405 (modest_ui_dimming_rules_on_new_folder):
2406 * src/widgets/modest-folder-view.c: (text_cell_data),
2407 (icon_cell_data), (filter_row), (update_model),
2408 (get_cmp_rows_type_pos):
2411 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2412 Do not get the priv struct, because no priv struct has been set,
2413 to avoid a runtime warning.
2415 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2416 #ifelse with #else, to fix a warning, to fix the build.
2419 2007-06-05 Christian Kellner <ckellner@openismus.com>
2421 * libmodest-dbus-client/libmodest-dbus-client.c:
2422 Fix small typo in doc (why do you always see them
2423 AFTER committing stuff?)
2426 2007-06-05 Christian Kellner <ckellner@openismus.com>
2428 * libmodest-dbus-client/libmodest-dbus-client.c:
2429 (libmodest_dbus_client_search):
2430 Initialize hit list with NULL. Also set folder list
2431 to "" if NULL was supplied.
2434 2007-06-03 Christian Kellner <ckellner@openismus.com>
2436 * libmodest-dbus-client/libmodest-dbus-client.c:
2437 (modest_search_hit_list_free):
2438 Make it save to call it with NULL.
2440 * src/dbus_api/modest-dbus-callbacks.c:
2441 * src/modest-search.c:
2442 Return full ModestSearchHits as the search result list not TnyHeader
2443 since can't be around withouth the correspoding TnyFolder.
2445 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2447 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2448 Added currently commented code to check for secure auth
2450 * src/maemo/modest-account-settings-dialog.c: (on_response),
2451 (save_configuration), (show_ok):
2452 Fixed projects.maemo.org bugs NB #59248 and #59251
2454 * src/maemo/modest-maemo-utils.c:
2455 (on_camel_account_get_supported_secure_authentication_status),
2456 (on_camel_account_get_supported_secure_authentication),
2457 (modest_maemo_utils_get_supported_secure_authentication_methods):
2458 * src/maemo/modest-maemo-utils.h:
2459 Moved get_supported_secure_authentication() method here to be able
2460 to use it from easysetup wizard.
2462 * src/modest-pair.c: (on_pair_compare_as_string):
2463 Should compare string with first part of pair and not
2464 strcmp pairs which will crash.
2466 * src/modest-protocol-info.c:
2467 (modest_protocol_info_protocol_is_store):
2468 * src/modest-protocol-info.h:
2469 Added modest_protocol_info_get_auth_protocol_name()
2471 2007-06-03 Armin Burgmeier <armin@openismus.com>
2473 * src/modest-mail-operation.c:
2474 (modest_mail_operation_get_msgs_full): Set priv->account also when
2475 only retrieving a single message. This avoids a crash when canceling
2478 (modest_mail_operation_notify_end): Do not explicitely remove the
2479 operation from the queue but only emit the progress_changed signal.
2480 The queue itself listens to that signal to remove the operation when
2481 it is finished. This reduces coupling and removes a potential deadlock
2482 when modest_mail_operation_notify_end() is called from the queue
2483 itself. If that is a problem performance-wise, I would suggest to
2484 implement a status-changed signal or something.
2486 * src/modest-mail-operation-queue.c: Make sure to never call a
2487 function from another file while the queue is locked. This (hopefully)
2488 fixes another deadlock when exiting the application while retrieving
2491 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2493 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2494 Fixed build if libogs is not available
2496 2007-06-03 Christian Kellner <ckellner@openismus.com>
2498 * libmodest-dbus-client/libmodest-dbus-client.h:
2499 * libmodest-dbus-client/libmodest-dbus-client.c:
2500 (libmodest_dbus_client_delete_message):
2501 Implement deletion of messages (Client side).
2503 (modest_search_hit_free),
2504 (modest_search_hit_list_free):
2505 Utility functions to free the result hits.
2507 * src/dbus_api/modest-dbus-api.h:
2508 * src/dbus_api/modest-dbus-callbacks.c:
2509 (on_delete_message),
2510 (modest_dbus_req_handler):
2511 Implement deletion of messages (Server side).
2513 * tests/dbus_api/test_search.c: (main):
2516 * tests/dbus_api/Makefile.am:
2517 * tests/dbus_api/test_delete_message:
2518 Add little test for the message deletion logic
2520 2007-06-03 Armin Burgmeier <armin@openismus.com>
2522 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2523 when the operation queue was not empty. projects.maemo.org bug
2526 2007-06-03 Armin Burgmeier <armin@openismus.com>
2528 * src/widgets/modest-account-view.c
2529 (on_account_default_toggled): Toggle default account column
2530 explicitely instead of waiting for gconf notification (which is
2531 currently ignored). This should fix projects.maemo.org bug NB#56910
2532 for now. It should probably be removed when gconf notifications are
2535 2007-06-03 Christian Kellner <ckellner@openismus.com>
2537 * libmodest-dbus-client/libmodest-dbus-client.c:
2538 Removed debugging spew.
2540 * src/dbus_api/modest-dbus-callbacks.c:
2541 Added debugging info.
2543 * src/modest-search.c:
2544 (modest_search_all_accounts):
2545 Use tny_account_store_get_accounts () on the account store
2546 to get all accounts which is the way to get all accounts.
2548 * tests/dbus_api/test_search.c: (main):
2549 Make it possible to supply the search term on the command line.
2551 2007-06-03 Christian Kellner <ckellner@openismus.com>
2553 * libmodest-dbus-client/libmodest-dbus-client.c:
2554 * libmodest-dbus-client/libmodest-dbus-client.h:
2555 Implement searching for mesages over raw dbus. (Client side)
2557 * src/dbus_api/Makefile.am:
2558 * src/dbus_api/modest-dbus-api.h:
2559 * src/dbus_api/modest-dbus-callbacks.c:
2560 * src/dbus_api/modest-dbus-callbacks.h:
2561 Search framework (Server side). Also implement on_idle_open_message().
2563 * src/maemo/modest-platform.c: (modest_platform_init):
2564 Prepare for raw dbus/osso rpc interaction.
2566 * src/modest-search.h:
2567 Changed minsize from unspecific guint to guint32.
2569 * src/modest-search.c:
2571 Added strange hack which magically made tnymail work.
2573 (modest_search_folder),
2574 (modest_search_account),
2575 (modest_search_all_accounts):
2576 Implement helper functions to search all accounts, specific account
2579 * tests/dbus_api/Makefile.am:
2580 * tests/dbus_api/test_open_message.c:
2581 Read url to open from commandline.
2583 * tests/dbus_api/test_search.c:
2584 Implement small test for dbus search stuff
2586 2007-06-02 Armin Burgmeier <armin@openismus.com>
2588 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2589 include account type and account title. This fixes projects.maemo.org
2592 * src/maemo/modest-account-view-window.c: Set a title for the window.
2594 2007-06-02 Armin Burgmeier <armin@openismus.com>
2596 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2597 incoming and outgoing server name based on email address and server
2598 types as long as the names have not been edited manually. This fixes
2599 projects.maemo.org bug NB#58671.
2601 2007-06-02 Armin Burgmeier <armin@openismus.com>
2603 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2604 server type cannot be changed in future to the incoming details page
2605 when creating an account. This fixes projects.maemo.org bug NB#59029.
2607 2007-06-02 Armin Burgmeier <armin@openismus.com>
2609 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2610 and assigned max width chars so that they wrap instead of being
2611 truncated. Fixes projects.maemo.org bug NB#56126.
2613 2007-06-02 Armin Burgmeier <armin@openismus.com>
2615 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2616 introductory note to the connection specific smtp servers dialog, as
2617 section 8.12 of the email UI specification requires. This fixes
2618 projects.maemo.org bug NB#59212.
2620 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2622 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2623 Check for running mail operations, and offer to cancel them, as per the UI
2624 spec. This fixes projects.maemo.org bug NB#59041 .
2625 However, I suspect that tinymail may still use the network connection
2626 in ways that we cannot detect or cancel. But it should at least adapt to
2627 changes fairly well.
2629 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2631 * src/modest-tny-account-store.c: (recreate_all_accounts),
2632 (get_cached_accounts), (get_server_accounts): Do more sensible
2633 ref-counting of the temporarily-cached outbox accounts list. This seems
2634 to fix a crash when entering the password when the password was wrong.
2636 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2638 * src/gnome/modest-main-window.c: (connect_signals):
2639 * src/modest-tny-account-store.c: (get_password),
2640 (modest_tny_account_store_alert): Added comments and clues and
2641 commented-out code about how we currently fail to deal with connection
2642 errors and wrong passwords, and how we should.
2644 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2646 * src/widgets/modest-retrieve-combo-box.c:
2647 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2648 This fixes projects.maemo.org bug NB#58472 .
2650 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2652 * src/maemo/easysetup/modest-easysetup-wizard.c:
2653 (create_page_complete_easysetup):
2654 (create_page_complete_custom): Correct the last commit,
2655 putting the correct sentences in the correct pages.
2657 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_complete_custom): Show the second sentence of text
2661 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2664 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2666 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2667 Set the leave-on-server conf key by default. This fixes
2668 projects.maemo.org bug NB#59258 .
2670 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2672 * src/maemo/modest-account-view-window.c:
2673 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2674 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2677 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/easysetup/modest-easysetup-wizard.c:
2680 (create_caption_new_with_asterisk):
2681 * src/maemo/modest-account-settings-dialog.c:
2682 (create_caption_new_with_asterisk):
2683 Uncomment the code to add the asterisk, because they are no longer in the
2684 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2685 (update_incoming_server_title): Add an asterisk here too.
2687 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2689 * src/maemo/modest-maemo-global-settings-dialog.c:
2690 (current_connection): Check that we are even connected before trying to
2691 get the current connection name, to prevent a warning.
2693 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2694 Change the comments because tny_maemo_conic_device_connect() is now meant to
2696 * src/modest-mail-operation.c:
2697 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2698 make sure we have a connection and fail if we can't connect.
2700 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2702 * src/maemo/modest-main-window.c:
2703 (on_account_store_connecting_finished): Do not try to get the
2704 connection ID if we are not really connected. I am surprised that
2705 this signal handler is called when we are not connected.
2707 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2709 * src/modest-error.h:
2710 * src/modest-ui-actions.c:
2711 (modest_ui_actions_get_msgs_full_error_handler):
2712 Renamed an enum, added comments, added an enum
2713 for retrieve-limit errors.
2715 * src/modest-mail-operation.c: (foreach_add_item),
2716 (internal_folder_observer_update), (update_account_thread),
2717 (modest_mail_operation_get_msgs_full):
2718 (modest_mail_operation_update_account),
2719 Added comments about how this works, and some code that should
2720 (but does not) check the retrieve-limit. See the TODO comment.
2722 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2724 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2725 Initialize help_id to fix the build. Warnings are good.
2727 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2729 * src/widgets/modest-hbox-cell-renderer.c:
2730 (modest_hbox_cell_renderer_append):
2731 * src/widgets/modest-vbox-cell-renderer.c:
2732 (modest_vbox_cell_renderer_append):
2733 Fix the last commit by doing an extra ref.
2735 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2737 * src/widgets/modest-hbox-cell-renderer.c:
2738 (modest_hbox_cell_renderer_append):
2739 * src/widgets/modest-vbox-cell-renderer.c:
2740 (modest_vbox_cell_renderer_append):
2741 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2742 to fix the build with Maemo Bora.
2743 However, there seems to be a remaining crash, probably due to reference
2746 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2748 * src/modest-tny-account.c:
2749 (modest_tny_account_new_for_local_folders):
2750 Use hildon_file_system_info_async_new() to get a better name for
2751 the memory card account, setting it as the account name.
2752 The timing seems to work, but this is probably
2753 not the best place to do this. See the TODO comment.
2754 * src/maemo/modest-main-window.c: (create_details_widget):
2755 * src/widgets/modest-folder-view.c: (text_cell_data):
2756 Use the tny account name instead of hardcoding a name.
2758 2007-05-30 Christian Kellner <ckellner@openismus.com>
2760 * src/modest-search.c: (modest_search):
2761 Correctly set part_search_func even if we have already parsed
2762 the query and thus a valid OgsTextSearcher object.
2764 2007-05-30 Christian Kellner <ckellner@openismus.com>
2767 Search and check for libogs.
2770 Incooparte the ogs build env.
2772 * src/modest-mime-part-search-stream.c:
2773 * src/modest-mime-part-search-stream.h:
2774 Removed since we do the real searching now in modest-search.c.
2776 * src/modest-search.c:
2777 * src/modest-search.h:
2778 Implement support for ogs. We use that if available and requested
2779 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2780 should now handle the corner case when the search term is spread
2781 across multiple reads.
2782 Also the logic in modest_search () was corrected to search all
2783 requested fields until one is found.
2785 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2787 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2789 * src/modest-init.h:
2790 * src/modest-init.c: Made modest_init_local_folders() take a
2791 path and be public so we can iniitialize maildir folders on
2794 * src/modest-local-folder-info.h:
2795 * src/modest-local-folder-info.c:
2796 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2798 * src/modest-tny-account.c:
2799 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2800 still means the standard local-folders path on the local volume.
2802 * src/modest-tny-account-store.c:
2803 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2804 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2805 all accounts when that happens.
2806 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2807 this too, so it shows up in the treeview.
2809 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/modest-maemo-global-settings-dialog.c:
2812 (current_connection):
2813 * src/widgets/modest-global-settings-dialog.c:
2814 (current_connection_default):
2815 Use the enum values instead of 0, 1 and -1,
2816 to make the code clearer.
2818 * src/modest-account-mgr-helpers.c:
2819 (modest_account_mgr_get_connection_specific_smtp): Make this code
2822 * src/modest-runtime.h:
2823 * src/modest-runtime.c:
2824 Added modest_runtime_remove_all_send_queues().
2825 * src/maemo/modest-main-window.c:
2826 (on_account_store_connecting_finished): Recreate the send queues,
2827 using the appropriate transport accounts for this new connection.
2828 Some futher adapting might be needed if the old send queues are not
2829 automatically stopped at this point.
2831 * src/modest-tny-account-store.c: (get_server_accounts):
2832 Create the connection-specific transport accounts, so that they can
2833 be found later by their ID.
2835 * src/modest-tny-account.h:
2836 * src/modest-tny-account.c:
2837 Added modest_tny_account_new_from_server_account_name().
2838 modest_tny_account_new_from_server_account(): Do not create the
2839 send queues here, because they will be
2840 recreated anyway when the connection changes for the first time.
2842 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2844 * src/modest-local-folder-info.h:
2845 * src/modest-local-folder-info.c:
2846 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2847 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2848 tbox_folder): Take a modest account name instead of a server TnyAccount,
2849 so we can have per-modest-account rather than per-transport-account
2851 We must make sure that we change or recreate the exisitng send queues
2852 when the connection changes for connection-specific transport accounts.
2854 * src/modest-tny-account-store.c:
2855 (create_per_account_local_outbox_folders): Create outboxed per modest
2856 account, not per transport account.
2858 * src/modest-tny-account.h:
2859 * src/modest-tny-account.c:
2860 (modest_tny_account_get_special_folder): For outboxes, get the
2861 parent modest account name. The account is ignored for other folders.
2862 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2863 modest account name rather than a server TnyAccount.
2865 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2867 * src/modest-tny-account.c:
2868 (modest_tny_account_new_from_server_account):
2869 Call modest_runtime_get_send_queue() immediately after creating transport
2870 accounts, so that they start trying to send email from the outbox as soon
2871 as possible at startup. This is probably what we want.
2873 * src/modest-mail-operation.c: (update_account_thread):
2874 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2875 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2876 * src/modest-tny-send-queue.h:
2877 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2878 (modest_ui_actions_on_send):
2879 Added comments about how sending works, though it needs some more work.
2881 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2883 * src/modest-tny-account.c:
2884 (modest_tny_account_get_special_folder): Add TODO because this fails when
2885 the network is busy.
2886 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2887 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2888 Do not try to show this window when there is no active account. The UI
2889 specs does not tell us what to do in this case.
2891 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/Makefile.am:
2896 * src/widgets/Makefile.am: Some dist fixes.
2898 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2900 * src/maemo/modest-connection-specific-smtp-window.c:
2901 (on_button_edit): Make the code clearer, to prevent a double free.
2903 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2905 * src/maemo/modest-account-settings-dialog.c:
2906 (modest_account_settings_dialog_set_account_name),
2907 Check the connection-specific smtp servers checkbox if there are any.
2909 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2910 (modest_connection_specific_smtp_edit_window_init):
2911 Start with a suitable port number.
2913 * src/modest-account-mgr-helpers.h:
2914 * src/modest-account-mgr-helpers.c: Added
2915 modest_account_mgr_get_has_connection_specific_smtp().
2917 (modest_account_mgr_set_connection_specific_smtp),
2918 (modest_account_mgr_remove_connection_specific_smtp),
2919 (modest_account_mgr_get_has_connection_specific_smtp),
2920 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2921 connection-specific smtp server accounts in the account, rather than
2922 the server account conf dir.
2924 This fixes bug projects.maemo.org bug NB#58263 .
2926 * src/modest-tny-account-store.c:
2927 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2928 if there are no server accounts yet, to prevent an infinite loop when there
2929 are no accounts. Document that one must be called before the other.
2931 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-account-mgr-helpers.c:
2934 (modest_account_mgr_get_default_account): Make sure that at least
2935 one account is always the default, if there are any enabled accounts.
2936 This is just a sanity check that shouldn't be necessary.
2938 * src/modest-account-mgr-priv.c:
2939 (_modest_account_mgr_account_from_key): Unescape the conf key to
2940 get the real account name. For instance, this is an issue if a space
2941 was in the account name, which can happen because the account name
2942 is generated from the display name.
2943 (_modest_account_mgr_get_account_keyname): Always escape the
2945 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2946 Unescape the conf keys to get the real account names.
2948 For instance, previously the is-default radio button in the accounts
2949 list was not checked for any accounts at first. This fixes that,
2950 and might fix several similar bugs.
2952 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2954 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2955 Removed some debug printfs.
2957 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2959 Modest on-disk outbox directories are now here, for instance:
2960 $HOME/.modest/outboxes/<account-id-1>/outbox
2961 $HOME/.modest/outboxes/<account-id-2>/outbox
2963 $HOME/.modest/local-folders/outbox
2964 so we can have a separate outbox for each account.
2965 But they are shown as one outbox in the GtkTreeView, by using a
2966 TnyMergeFolder in a ModestTnySimpleFolderStore.
2969 * src/modest-tny-simple-folder-store.c:
2970 * src/modest-tny-simple-folder-store.h:
2971 Added ModestTnySimpleFolderStore, used to contain folders from
2972 other folder stores, such as other accounts.
2974 * src/modest-tny-outbox-account.h:
2975 * src/modest-tny-outbox-account.c:
2976 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2977 used for the per-account local outbox folders.
2979 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2980 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2981 only use this (internally) now for the non-outbox local folders.
2983 * src/modest-init.h:
2984 * src/modest-init.c: Added modest_init_one_local_folder(), for
2985 setting up the directory structure for each local folder.
2987 * src/modest-local-folder-info.c:
2988 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2989 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2991 * src/modest-local-folder-info.h:
2992 * src/modest-tny-account-store.c: (on_account_removed),
2993 (on_account_changed), (create_per_account_local_outbox_folders),
2994 (get_server_accounts), (modest_tny_account_store_get_accounts),
2995 (modest_tny_account_store_get_tny_account_by_account),
2996 (modest_tny_folder_store_is_virtual_local_folders):
2998 * src/modest-tny-account.h:
2999 * src/modest-tny-account.c:
3000 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3001 to create an on-disk per-account local outbox folder for each
3003 (create_per_account_local_outbox_folders): Create a local outbox folder
3004 for each transport account.
3005 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3006 for all local folders.
3008 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3009 instead of using g_object_get/set() directly. It is clearer.
3011 (modest_tny_folder_store_get_message_count),
3012 (modest_tny_folder_store_get_local_size
3013 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3014 because we now use these with non-acount folder stores.
3016 (modest_tny_account_get_special_folder),
3017 (modest_tny_account_new_from_server_account),
3018 (modest_tny_account_new_from_account):
3019 (recurse_folders): Adjust to the new outbox system.
3021 * src/modest-tny-folder.h:
3022 * src/modest-tny-folder.c:
3023 (modest_tny_folder_is_local_folder),
3024 (modest_tny_folder_get_local_folder_type),
3025 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3027 * src/widgets/modest-main-window.h:
3028 * src/maemo/modest-main-window.c: (create_details_widget),
3029 (modest_main_window_set_contents_style): Show details for any folder store,
3032 (modest_tny_folder_get_rules):
3033 Remove the const. C does not support constness enough for this.
3035 * src/modest-ui-actions.c:
3036 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3037 make all outboxes appear as one, in the usual local-folders tree node.
3039 (set_active_account_from_tny_account),
3040 (modest_ui_actions_on_folder_selection_changed):
3041 * src/widgets/modest-folder-view.c: (text_cell_data),
3042 (icon_cell_data), (filter_row),
3043 (add_account_folders_to_merged_folder),
3044 (add_account_folders_to_simple_folder_store), (),
3045 (get_cmp_rows_type_pos), (cmp_rows),
3046 (modest_folder_view_set_account_id_of_visible_server_account):
3047 Adjust to the new outbox system, using generic folder stores and folders
3048 in the GtkTreeModel.
3050 2007-05-23 Christian Kellner <ckellner@openismus.com>
3052 * src/modest-mail-operation.c:
3053 (modest_mail_operation_update_account):
3054 Use info->max_size instead of unintialized local var [small
3055 build fix]. (Added TODO to review that change since I don't
3058 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3060 * libmodest-dbus-client/libmodest-dbus-client.c:
3061 (libmodest_dbus_client_compose_mail): function added
3062 * src/dbus_api/modest-dbus-api.h:
3063 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3064 (on_compose_mail): Implementation of the SendAsMail functionality
3066 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3068 * src/modest-account-mgr.c:
3069 (modest_account_mgr_add_server_account): Set the secure-connection
3070 conf key for transport accounts as well as store accounts. I don't know
3071 why the if was there. For instance, this makes sure that we use SSL
3072 for the gmail preset from the easysetup wizard.
3074 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3076 * src/gnome/modest-main-window.c:
3077 (on_account_store_connecting_finished), (connect_signals):
3078 * src/maemo/modest-main-window.c:
3079 (on_account_store_connecting_finished), (connect_signals),
3080 (modest_main_window_new):
3081 Handle TnyAccountStore::connecting-finished instead of
3082 TnyDevice::connection-changed, because we cannot actually perform
3083 operations on accounts until TnyAccountStore has itself responded to
3084 the TnyDevice::connection-changed signal. This prevents a GError from
3086 Do not try to update at startup, because we (at least on scratchbox)
3087 already do an update at startup when the device goes online.
3088 This prevents a GError from tinymail.
3089 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3090 Added TODO about stopping simultaneous operations.
3092 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3094 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3095 * src/modest-mail-operation-queue.c:
3096 (modest_mail_operation_queue_remove):
3097 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3098 about where they happened.
3100 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3102 * src/modest-ui-actions.c:
3103 (modest_ui_actions_on_password_requested): Make sure that the remember
3104 output parameter is always TRUE.
3106 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3108 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3109 Show a OK/Cancel dialog if the error is a question, though we still do not
3110 know anything more about what we are asking the user.
3111 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3112 Fix an uninitialized variable (helper). This is a logic error, however.
3114 2007-05-21 Christian Kellner <ckellner@openismus.com>
3116 * src/modest-search.h:
3117 Correct bit shifting in the ModestSearchFlags enum.
3119 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3121 * src/modest-tny-account.c:
3122 (modest_tny_account_new_from_server_account): Do not use the lsub and
3123 check-all hard-coded IMAP options when using POP.
3125 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3127 * src/modest-tny-account.c:
3128 (modest_tny_account_new_from_server_account):
3129 Use NULL for the secure-auth method for POP when Password auth has been
3130 specified by the user, as we already do for IMAP. "auth=Login" causes
3131 an error from camel or the server.
3133 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3135 * src/maemo/modest-account-settings-dialog.c:
3136 (create_page_account_details),
3137 (modest_account_settings_dialog_set_account_name):
3138 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3139 for the leave-on-server checkbox, rathr than just the checkbox, when
3140 the protocol is not POP.
3142 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3144 * src/widgets/modest-account-view.c:
3145 * src/widgets/modest-account-view.h:
3146 Added modest_account_view_select_account() which will be useful later
3147 to asynchronously re-select the edited account.
3149 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3151 * src/maemo/modest-account-settings-dialog.c:
3152 (modest_account_settings_dialog_set_account_name):
3153 Automatically choose the port numbers based on the secure authentication
3154 methods, if they have not been chosen before.
3155 This fixes projects.maemo.org bug NB#56273 .
3157 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3159 * src/maemo/modest-main-window-ui.h:
3160 * src/modest-ui-actions.c:
3161 * src/modest-ui-actions.h:
3162 Connect the Tools/SMTP Servers menu item to
3163 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3164 SMTP servers dialog, as in the UI specification and saves changes when it
3165 is closed. This fixed projects.maemo.org bug NB#56305 .
3167 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3169 * src/maemo/modest-connection-specific-smtp-window.c:
3170 (modest_connection_specific_smtp_window_init):
3171 Use gtk_window_set_default_size() to make this window big enough, so
3172 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3174 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3176 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3178 (modest_connection_specific_smtp_edit_window_init),
3179 Do not try to connect to a combobox signal before the combobox exists.
3180 This fixes the cras in projects.maemo.org bug NB#56288 .
3181 (modest_connection_specific_smtp_edit_window_get_settings):
3182 Remove the server_account_name parameter which was being checked for NULL
3183 though it was not used.
3185 * src/maemo/modest-connection-specific-smtp-window.c:
3186 (modest_connection_specific_smtp_window_fill_with_connections),
3187 (on_button_edit), (modest_connection_specific_smtp_window_init):
3188 Correct the number of treemodel columns to prevent a warning.
3189 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3190 libconic does not work.
3192 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3194 * src/modest-tny-account.c:
3195 (modest_tny_account_new_from_server_account):
3196 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3197 SMTP when "None" was chosen by the user. However, with my SMTP server that
3198 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3201 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3203 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3204 to explain the memory management issue with the ID in the ModestPair.
3206 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3207 (add_sending_page), (modest_account_assistant_finalize):
3208 * src/gnome/modest-gnome-global-settings-dialog.c:
3209 (create_updating_page), (create_composing_page):
3210 * src/gnome/modest-msg-edit-window.c: (get_transports),
3211 (init_window), (modest_msg_edit_window_finalize),
3212 (modest_msg_edit_window_get_msg_data):
3213 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3214 * src/gnome/modest-transport-widget.c:
3215 (modest_transport_widget_finalize), (smtp_configuration):
3216 * src/maemo/modest-maemo-global-settings-dialog.c:
3217 (create_updating_page), (create_composing_page):
3218 * src/maemo/modest-msg-edit-window.c: (get_transports),
3219 (init_window), (modest_msg_edit_window_finalize),
3220 (modest_msg_edit_window_get_msg_data),
3221 (modest_msg_edit_window_free_msg_data):
3222 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3223 (modest_store_widget_finalize):
3224 * src/maemo/modest-transport-widget.c:
3225 (modest_transport_widget_finalize), (smtp_configuration):
3226 * src/modest-main.c: (send_mail):
3227 * src/widgets/modest-combo-box.h:
3228 * src/widgets/modest-global-settings-dialog-priv.h:
3229 * src/widgets/modest-global-settings-dialog.c:
3230 (modest_global_settings_dialog_finalize):
3231 * src/widgets/modest-msg-edit-window.h:
3232 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3233 as long as the combo box, to prevent use of freed memory for the ID.
3235 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3237 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3238 get_accounts(), to make this clearer. Do not check for the enabled gconf
3239 key, because we do not use this for server accounts (at least, not yet).
3240 This allows us to send email again.
3242 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3244 * src/maemo/modest-platform.c:
3245 (on_modest_conf_update_interval_changed), (modest_platform_init):
3246 Only respond to this particular key change. All these strcmp()s cannot be
3249 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3251 * src/maemo/modest-maemo-global-settings-dialog.c:
3252 (current_connection): Prevent a crash in scratchbox when
3253 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3254 * src/maemo/modest-platform.c:
3255 (on_modest_conf_update_interval_changed), (modest_platform_init):
3256 Get the update interval from gconf and reset it when the gconf key changes.
3258 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3260 * src/modest-protocol-info.c:
3261 * src/modest-protocol-info.h: Adde enum-specific get functions,
3262 instead of using a ModestProtocolType enum parameter.
3264 * src/gnome/modest-account-assistant.c:
3265 * src/gnome/modest-store-widget.c:
3266 * src/gnome/modest-store-widget.h:
3267 * src/gnome/modest-transport-widget.c:
3268 * src/gnome/modest-transport-widget.h:
3269 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3270 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3271 * src/maemo/easysetup/modest-easysetup-wizard.c:
3272 * src/maemo/modest-account-settings-dialog.c:
3273 * src/maemo/modest-account-settings-dialog.h:
3274 * src/maemo/modest-store-widget.c:
3275 * src/maemo/modest-store-widget.h:
3276 * src/maemo/modest-transport-widget.c:
3277 * src/maemo/modest-transport-widget.h:
3278 * src/modest-account-mgr-helpers.c:
3279 * src/modest-account-mgr-helpers.h:
3280 * src/modest-account-mgr.c:
3281 * src/modest-account-mgr.h:
3282 * src/modest-tny-account.c:
3283 * src/modest-tny-folder.c:
3284 * src/widgets/modest-account-view.c:
3285 * src/widgets/modest-retrieve-combo-box.c:
3286 * src/widgets/modest-retrieve-combo-box.h:
3287 * src/widgets/modest-secureauth-combo-box.c:
3288 * src/widgets/modest-serversecurity-combo-box.c:
3289 * src/widgets/modest-serversecurity-combo-box.h:
3290 * tests/check_account-mgr.c:
3291 Use the specific functions, and use the re-renamed enum values for GNOME too.
3293 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3295 * src/modest-pair.h:
3296 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3297 so we can get the second based on the first.
3299 * src/maemo/modest-account-settings-dialog.h:
3300 * src/maemo/modest-account-settings-dialog.c:
3301 Added get_supported_secure_authentication_methods(), though it is mostly
3302 commented-out for now until the necessary API is committed to tinymail.
3303 (modest_account_settings_dialog_set_account_name),
3304 (save_configuration): Request the supported authentication methods from the
3305 server, so we can choose a working method.
3307 * src/modest-tny-account-store.h:
3308 * src/modest-tny-account-store.c:
3309 (modest_tny_account_store_get_session): Rename from
3310 tny_account_store_get_session().
3312 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3314 * src/modest-protocol-info.h: Split the ModestProtocol enum
3315 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3316 There was no need to have these unrelated values in one enum.
3318 * src/: many files: Adapted to changed enum. This makes the code a bit
3319 clearer, and the compiler could catch some errors.
3321 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3323 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3324 Show the detailed internal camel error message when an error happens
3325 during the configuration, so that our testers can give us more clues.
3326 For instance, in projects.maemo.org bug NB#56910 .
3328 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3330 * src/modest-tny-account.c:
3331 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3332 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3334 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3336 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3337 * src/maemo/modest-account-settings-dialog.c:
3338 (modest_account_settings_dialog_set_account_name),
3339 (save_configuration): For the incoming secure authentication checkbox,
3340 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3341 the UI specification. PLAIN does not seem to be supported for most IMAP
3342 servers anyway, and I am not sure what it would mean.
3343 However, we probably need to discover which of the secure-authentication
3344 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3345 * src/modest-account-mgr-helpers.c:
3346 (modest_account_mgr_get_server_account_data):
3348 * src/modest-tny-account.c:
3349 (modest_tny_account_new_from_server_account):
3350 Use tny_account_set_mech() to set secure-authentication methods,
3351 with some special-casing for IMAP, based on my observations of how
3354 * src/modest-account-mgr-helpers.h:
3355 * src/modest-account-mgr.c:
3356 * src/modest-defs.h: Comment that the URI is only used for local folders.
3358 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3361 parameter const, just to be neat.
3362 * src/modest-text-utils.c: (modest_text_utils_inline):
3363 End g_strconcat() with NULL, as its documentation says. This is almost
3364 certainly the cause of my crash at startup on the device. Interestingly,
3365 valgrind doesn't tell us about these errors.
3367 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3369 * scripts/build-packages: Added more precise comments about how to use
3370 this script, though I still get this error:
3371 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3372 error building tinymail
3374 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3376 * src/maemo/modest-main-window.c: (on_account_update):
3377 Very slight cleanup, hoping to make it simpler to discover what causes
3378 a crash here sometimes.
3380 * src/modest-tny-account.c:
3381 (modest_tny_account_new_from_server_account): Set the port. Added
3382 comments about the options and a TODO comment because I need to find out
3383 how to specify the secure authentication method.
3385 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3387 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3388 changed CFlags paths form modest to libmodest
3390 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-account-mgr-helpers.c:
3393 (modest_account_mgr_get_server_account_data),
3394 (modest_account_mgr_free_server_account_data):
3395 * src/modest-account-mgr-helpers.h:
3396 * src/modest-account-mgr.c:
3397 (modest_account_mgr_add_server_account):
3398 * src/modest-defs.h:
3399 * src/modest-tny-account.c:
3400 (modest_tny_account_new_from_server_account):
3401 Determine the options for tny_camel_account_add_option() here,
3402 based on the settings, rather than storing them directly in gconf.
3404 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3406 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3407 Show a more friendly error dialog now that we expect (from the tinymail
3408 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3410 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3412 * src/maemo/modest-main-window.c: (on_account_update): Check that
3413 account_name is not NULL, to prevent a crash at startup that I am
3414 seeing on the N800. I do wonder why it is NULL.
3416 * src/maemo/easysetup/modest-easysetup-wizard.c:
3417 (create_page_user_details):
3418 * src/maemo/modest-account-settings-dialog.c:
3419 (create_page_user_details), (create_page_outgoing):
3420 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3421 (modest_connection_specific_smtp_edit_window_init):
3422 * src/modest-ui-actions.c:
3423 (modest_ui_actions_on_password_requested):
3424 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3425 might do something useful with the on-screen keyboard.
3427 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/modest-main-window.c: (on_account_update):
3430 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3431 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3433 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3435 * src/modest-tny-account-store.c: (on_account_changed):
3436 Correct the signature of this signal handler.
3438 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3440 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3441 Show a HildonNote instead of a GtkDialog for Maemo.
3443 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3445 * src/widgets/modest-account-view.h:
3446 * src/widgets/modest-account-view.c: (on_account_changed),
3447 (on_account_removed). Added a boolean flag, set/unset by
3448 modest_account_view_block_conf_updates(),
3449 modest_account_view_unblock_conf_updates() to prevent unnecessary
3450 updates, but this is not very useful because the gconf notifications are
3451 so delays (maybe only on Maemo Bora).
3452 So auto-updating is turned off, and these functions do an explicit
3453 update when necessary.
3454 However, something else is still doing too much work when adding/removing
3455 accounts, probably in another part of the application.
3457 * src/maemo/modest-account-view-window.c:
3458 (on_delete_button_clicked), (on_edit_button_clicked),
3459 (on_new_button_clicked): Use the new functions.
3461 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3463 * src/modest-account-mgr-helpers.c:
3464 (modest_account_mgr_set_first_account_as_default):
3465 Sort the list of names alphabetically-by-title, so we choose the first one
3467 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3468 alphabetically by the title.
3470 This fixes projects.maemo.org bug NB#56418 .
3472 * src/modest-account-mgr-priv.c:
3473 (_modest_account_mgr_account_from_key):
3474 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3475 avoid a valgrind error, and possible random behaviour.
3477 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3479 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3480 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3481 tinymail documentation to say that this can be expected.
3482 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3483 pretty, and should not happen, but I would prefer to know when it does.
3485 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3487 * configure.ac: When using the older hildon version, probably on Bora,
3488 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3490 * src/widgets/modest-attachment-view.c:
3491 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3494 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3496 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3497 Implemented the prototype. Can be tested with
3498 tests/dbus_api/test_open_message:
3500 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3502 * src/modest-tny-account-store.c:
3503 (modest_tny_account_store_instance_init), (get_password):
3504 * src/modest-ui-actions.c:
3505 (modest_ui_actions_on_password_requested):
3506 Do not store the password in gconf, because this function is called
3507 for non-remembered passwords. Actually use the cached (in the hash map)
3508 password instead of releasing it.
3509 The password will now not be remembered if it is asked via the protected
3510 password dialog, as per the UI spec.
3512 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3514 * src/modest-defs.h:
3515 * src/modest-account-mgr-helpers.h:
3516 * src/modest-account-mgr-helpers.c:
3517 Added modest_server_account_get_username_has_succeeded(),
3518 modest_server_account_set_username_has_succeeded().
3519 (modest_server_account_set_username),
3520 Reset the has-succeeded flag if the username changes.
3522 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3523 * src/maemo/modest-connection-specific-smtp-window.c:
3524 (modest_connection_specific_smtp_window_save_server_accounts):
3525 Use modest_server_account_set_username() instead of using
3526 modest_conf_set_string() directly, so that the has-succeeded flag is always
3529 * src/modest-ui-actions.c:
3530 (modest_ui_actions_on_password_requested): Dim the username entry if
3531 the username has ever worked, as per the UI spec.
3533 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3535 * src/modest-tny-account-store.c: (get_password):
3536 * src/modest-ui-actions.c:
3537 (modest_ui_actions_on_password_requested):
3538 Allow the username to be changed too, though there is more work to
3539 be done on exactly how this behaves.
3541 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3543 * src/modest-account-mgr-helpers.h:
3544 * src/modest-account-mgr-helpers.c:
3545 Added modest_account_mgr_get_display_name(),
3546 modest_server_account_get_username(),
3547 modest_server_account_set_username(),
3548 modest_server_account_set_password(),
3549 modest_server_account_get_hostname() functions so we do not need to
3550 use the conf API directly.
3552 * src/maemo/modest-main-window.c: (connect_signals):
3553 Actually connect ot the ModestAccountStore::request-password signal,
3554 so that we show the dialog when the password is requested by Tinymail,
3555 for isntance if it is empty.
3557 * src/modest-marshal.list:
3558 * src/modest-tny-account-store.c:
3559 (modest_tny_account_store_class_init), (get_password),
3560 (modest_tny_account_store_alert):
3561 * src/modest-tny-account-store.h:
3562 * src/modest-ui-actions.h:
3563 * src/modest-ui-actions.c:
3564 (modest_ui_actions_on_password_requested):
3565 Change the signal parameters, so it is obvious that we are providing
3566 the non human-readable server name, and receiving both the username
3567 and password, though changing of the username is not yet implemented.
3568 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3569 for the GNOME version.
3571 This should fix the projects.maemo.org bug NB#56209, though it does not
3572 work on Bora, because the gconf_client_get() for the password fails
3573 immediately after we save it with gconf_client_set().
3575 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3578 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3579 caused an undefined symbol error:
3580 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3582 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3584 * src/modest-tny-account-store.c:
3585 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3586 using a GError instead of a string message, so we can translate it in
3589 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3591 * src/maemo/modest-address-book.c:
3592 (modest_address_book_check_names):
3593 * src/maemo/modest-msg-view-window.c:
3594 (modest_msg_view_window_clipboard_owner_change):
3595 * src/modest-init.c: (modest_init_init_ui):
3596 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3597 (update_folders_cb), (modest_mail_operation_update_account):
3598 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3599 (modest_ui_actions_on_msg_attachment_clicked),
3600 (modest_ui_actions_on_msg_recpt_activated):
3601 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3602 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3603 (modest_msg_view_search_next):
3604 * src/widgets/modest-recpt-editor.c:
3605 (modest_recpt_editor_on_button_release_event),
3606 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3607 g_message(). At this point we should only be seeing interesting errors on
3608 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3610 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3612 (modest_wizard_dialog_force_title_update):
3613 * src/maemo/easysetup/modest-wizard-dialog.h:
3614 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3615 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3616 can update the title when appropriate. Otherwise the title is wrong if the
3617 pages are added after adding the notebook to the dialog.
3618 This must be a problem in HildonWizardDialog too.
3619 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3621 * src/maemo/easysetup/modest-easysetup-wizard.c:
3622 (create_subsequent_customsetup_pages),
3623 (create_subsequent_easysetup_pages):
3624 Call modest_wizard_dialog_force_title_update() so that the title is
3625 correct even with GTK+ < 2.10.
3626 This fixes projects.maemo.org bug NB#56145 .
3628 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3630 * src/maemo/modest-platform.c:
3631 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3632 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3635 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3637 * src/widgets/modest-window.h:
3638 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3639 and modest_window_save_state(), which invokes it.
3641 * src/widgets/modest-window-mgr.h:
3642 * src/widgets/modest-window-mgr.c:
3643 Added modest_window_mgr_save_state_for_all_windows(), which calls
3644 the save_state vfunc on all registered windows, if implemented.
3646 * src/gnome/modest-msg-edit-window.c:
3647 * src/gnome/modest-msg-view-window.c:
3648 * src/maemo/modest-msg-edit-window.c:
3649 * src/maemo/modest-msg-view-window.c:
3650 * src/maemo/modest-main-window.c:
3651 Specify the existing save_settings functions as implementations of
3652 ModestWindow::save_state_func().
3654 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3655 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3656 enabling hibernation, for instance.
3658 We may need to do the same thing for restoring settings.
3661 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3663 * src/widgets/modest-window-mgr.c:
3664 * src/widgets/modest-window-mgr.h:
3665 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3666 modest_window_mgr_get_hibernation_is_prevented().
3668 * src/maemo/modest-main-window.c:
3669 (on_hildon_program_is_topmost_notify): Prevent hibernation
3670 (possible when the application goes to the background in the WM),
3671 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3673 * src/maemo/easysetup/modest-easysetup-wizard.c:
3674 (modest_easysetup_wizard_dialog_init):
3675 * src/maemo/modest-account-settings-dialog.c:
3676 (modest_account_settings_dialog_init):
3677 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3678 (modest_connection_specific_smtp_edit_window_init):
3679 * src/maemo/modest-connection-specific-smtp-window.c:
3680 (modest_connection_specific_smtp_window_init):
3681 * src/maemo/modest-signature-editor-dialog.c:
3682 (modest_signature_editor_dialog_init):
3683 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3684 prevent hibernation while any of these account settings dialogs are open.
3686 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3688 * src/maemo/Makefile.am:
3689 * src/maemo/modest-osso-state-saving.c:
3690 * src/maemo/modest-osso-state-saving.h: Added
3691 modest_osso_load_state() and modest_osso_save_state() though they do
3692 nothing now. They should iterate through all the open windows and load/save
3694 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3695 save state when closing.
3697 * src/maemo/modest-main-window.c:
3698 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3699 Add a notification handler for the HildonProgram::is-topmost property,
3700 so we can allow hibernation when the application goes into the background.
3701 But we still need to detect when the accounts setup windows are open so
3702 we can stop hibernation when they are open.
3703 To do this, I also added the main window the HildonProgram. This might have
3704 other side-effects/benefits, and should maybe be done for other windows.
3706 * src/maemo/modest-osso-autosave-callbacks.h:
3707 * src/maemo/modest-osso-autosave-callbacks.c:
3708 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3709 though it does not do anything yet, and we might never need this to do
3710 anything. For instance, we already save drafts.
3712 * src/maemo/modest-platform.c: (modest_platform_init):
3713 Specify the libosso auto-save callback.
3715 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3717 * src/maemo/modest-platform.c:
3718 (modest_platform_set_update_interval):
3719 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3720 aparently stays valid between application instances, so we can use this
3721 to remove and reset it later. According to a maemo-developers email from
3724 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3726 * configure.ac: Depend on libalarm for Maemo.
3728 * src/dbus_api/modest-dbus-api.h:
3729 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3730 (on_send_receive), (modest_dbus_req_handler):
3731 Handle a SEND_RECEIVE D-Bus method.
3733 * libmodest-dbus-client/libmodest-dbus-client.c:
3734 (libmodest_dbus_client_send_and_receive):
3735 * libmodest-dbus-client/libmodest-dbus-client.h:
3736 Add C convenience functions for calling the new D-Bus method.
3738 * src/modest-platform.h:
3739 * src/gnome/modest-platform.c:
3740 * src/maemo/modest-platform.c:
3741 Added modest_platform_set_update_interval(), which uses the
3742 alarmd API on Maemo.
3743 (modest_platform_init),
3744 Call modest_platform_set_update_interval(), using a hard-coded
3745 interval for now (until the global settings dialog is implemented),
3746 though I am not sure that this makes sense yet.
3748 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3750 * src/dbus_api/modest-dbus-callbacks.c:
3751 (modest_osso_cb_hw_state_handler):
3752 * src/dbus_api/modest-dbus-callbacks.h:
3753 * src/maemo/modest-platform.c: (modest_platform_init):
3754 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3755 in case this has some effect on the ability for Maemo to ping the
3758 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3760 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3761 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3762 warning. It is probably a logic error, but I need to fix the build.
3764 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3766 * src/modest-account-mgr.h:
3767 * src/modest-account-mgr.c:
3768 (modest_account_mgr_account_names): Add a gboolean enabled_only
3769 parameter, so we can get lists of onlt the enabled accounts.
3771 (modest_account_mgr_add_account),,
3772 (modest_account_mgr_account_with_display_name_exists):
3773 * src/maemo/modest-msg-edit-window.c: (get_transports):
3774 * src/modest-account-mgr-helpers.c:
3775 (modest_account_mgr_set_first_account_as_default):
3776 * src/modest-init.c: (init_default_account_maybe):
3777 * src/modest-tny-account-store.c: (get_accounts):
3778 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3779 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3780 * tests/check_account-mgr.c: (START_TEST):
3781 Provide the extra parameter, as appropriate.
3783 * src/widgets/modest-account-view.c: (update_account_view):
3784 Do not show disabled accounts (meaning that there is no way to
3785 enable/disable accounts in the UI (the feature is not in our UI
3786 specification), so we can use this internally only to mark unfinished
3787 or temporary account data.
3789 * src/maemo/easysetup/modest-easysetup-wizard.c:
3790 (create_account): Add boolean enable parameter, so we can specify FALSE
3791 to create the temporary account.
3792 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3793 (on_before_next): When finishing, when there is a temporary account, just
3795 Also, use a timeout to delay the showing of the dialog until gconf is likely
3796 to return correct information, due to a maemo gconf bug that is fixed in
3797 osso 1.1, but not yet in Bora.
3798 However, the dialog stays on screen after it is destroyed.
3800 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3801 for invalid data when cancelling. Use a hildon note instead of a dialog
3802 to complain about invalid data. Do not show the account-saved note if the
3803 account is disabled (a temporary account that will not really be saved for use
3806 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3808 * src/modest-account-mgr-helpers.h:
3809 * src/modest-account-mgr-helpers.c:
3810 Added modest_account_mgr_unset_default_account(),
3811 Added modest_account_mgr_set_first_account_as_default().
3813 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3814 If it was the default account, unset the default account name.
3816 * src/maemo/modest-account-view-window.c:
3817 (on_delete_button_clicked): If it was the default account,
3818 set the first remaining account as the default instead.
3820 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3821 a NULL account or a NULL default account, to prevent a crash. This should
3822 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3825 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3827 * src/widgets/modest-recpt-editor.c:
3828 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3829 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3830 TODO comment for this. This fixes the build.
3832 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3833 be the best place for it. This will in future update all auto-update accounts,
3834 rather than just the current/default account, when that gconf key exists.
3835 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3836 if there are no accounts, before calling do_send_receive().
3837 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3839 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3840 * src/maemo/modest-main-window-ui.h:
3841 * src/maemo/modest-main-window.c: (on_connection_changed),
3842 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3843 directly, becaue the signal handler does more.
3845 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3847 * src/modest-account-mgr-helpers.c:
3848 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3849 for the case that the account does not exist.
3851 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3852 (equivalent to the modest account name) rather than the tinymail account name
3853 (equivalent to the modest account title - human readable) to get the account data.
3854 Check for null account data to prevent the crash, and add a TODO comment saying that
3855 this needs fixing because it is using the server account name instead of the account name.
3857 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3859 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3860 * src/maemo/modest-account-settings-dialog.c: (show_error),
3862 Use hildon_note_new_information() for informative and error messages,
3863 which seems to be expected for Maemo applications (no documentation that I know of
3864 says this). I am surprised that there is no distinction between info and error
3867 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3869 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3870 it is easy to find where this is used.
3872 * src/maemo/easysetup/modest-easysetup-wizard.c:
3873 (create_page_welcome), (create_page_account_details),
3874 (create_page_user_details), (create_page_complete_easysetup),
3875 (create_page_custom_incoming), (create_page_custom_outgoing),
3876 (create_page_complete_custom):
3877 * src/maemo/modest-account-settings-dialog.c:
3878 (create_page_account_details), (create_page_user_details),
3879 (create_page_incoming), (create_page_outgoing):
3880 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3881 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3882 (modest_connection_specific_smtp_edit_window_init):
3883 * src/maemo/modest-connection-specific-smtp-window.c:
3884 (modest_connection_specific_smtp_window_init):
3885 * src/maemo/modest-signature-editor-dialog.c:
3886 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3887 and scrolling policy as per the Email Application Layout Guide, if I have
3890 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3892 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3893 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3894 which were empty, because these vfuncs have been removed from TnyAccountStore.
3895 This fixes the build.
3897 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3899 * src/maemo/modest-main-window.c:
3900 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3901 showing/hiding it. Added TODO because it probably should not be NULL.
3902 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3903 because unnecessary g_warnings() make degugging difficult.
3905 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3907 * src/maemo/modest-msg-edit-window.c:
3908 (modest_msg_edit_window_select_color),
3909 (modest_msg_edit_window_select_background_color): 2 const corrections and
3910 moving 2 #endifs before closing brackets, to fix the build.
3912 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3914 * src/maemo/easysetup/modest-easysetup-wizard.h:
3915 * src/maemo/easysetup/modest-easysetup-wizard.c:
3916 (modest_easysetup_wizard_dialog_finalize),
3917 (on_button_edit_advanced_settings), (create_page_complete_custom),
3918 (on_response), (create_account):
3919 Implement the Advanced Settings edit button, by saving the account information,
3920 for the Advanded Settings dialog to use directly from gconf, and removing it
3921 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3922 Bug #5533 in the projects.maemo.org bugzilla.
3924 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3926 * src/maemo/modest-msg-view-window.c:
3927 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3928 when opening a message window.
3930 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3932 * src/maemo/easysetup/modest-easysetup-wizard.c:
3933 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3936 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3937 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3938 gconf settings. I probably added more checks than necessary, but that is safer.
3940 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3941 variable to fix the build, but this seems to be used when it is still NULL.
3943 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3945 * src/modest-platform.h:
3946 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3947 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3948 * src/modest-main.c: Implement this function so we can avoid using
3949 maemo-specific API from cross-platform code.
3951 * src/modest-tny-account-store.c:
3952 (get_smtp_specific_transport_account_for_open_connection):
3953 * src/modest-ui-actions.c: (check_for_connection),
3954 (modest_ui_actions_on_item_not_found):
3955 Use modest_platform_connect_and_wait() and put #idefs around other
3956 maemo-specific code, because only maemo currently has a way to
3957 identify connection names.
3959 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3961 * src/modest-tny-account-store.h:
3962 * src/modest-tny-account-store.c:
3963 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3964 the connection-specific SMTP server settings in the configuration.
3966 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3968 * src/maemo/modest-main-window.c: (on_connection_changed),
3970 * src/modest-main.c: (main), (start_ui), (send_mail):
3971 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3972 that is what is intended.
3974 * src/modest-ui-actions.c: (action_send), (action_receive),
3975 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3976 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3977 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3978 SMTP server is used when it is specified.
3980 (modest_ui_actions_on_send_receive):
3981 Check that a connection is open before proceeding.
3982 Receive and then send, instead of vice-versa, as per the specification.
3984 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3986 * src/modest-mail-operation.c:
3987 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3988 though I guess it should be something other than NULL.
3990 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3992 * src/maemo/easysetup/modest-easysetup-wizard.c:
3993 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3994 combo twice, to avoid an g_warning and to make it visible again.
3995 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3996 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3997 (already intended) dereference when detaching, because we then recreate the menu.
3998 But I am not sure why the warning was happening, and it is possible that this is a memory
4001 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4003 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4004 and uri_parse_mailto() utility functions.
4005 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4007 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4009 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4011 * src/dbus_api/modest-dbus-api.h:
4012 * src/dbus_api/modest-dbus-callbacks.c:
4013 Use an idle callback to execute the modest code in the application's own thread.
4014 Remove the helloworld example method.
4015 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4016 parsed, and the open-message method is not implemented because this is not yet implemented in
4018 * libmodest-dbus-client/libmodest-dbus-client.c:
4019 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4020 (libmodest_dbus_client_open_message):
4021 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4023 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4024 body without crashing.
4026 * tests/dbus_api/Makefile.am:
4027 * tests/dbus_api/test_mail_to.c:
4028 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4030 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4032 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4033 Added file to fix the build. Sorry.
4035 * src/dbus_api/Makefile.am:
4036 * src/dbus_api/modest-dbus-api.h:
4037 * src/dbus_api/modest-dbus-callbacks.h:
4038 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4039 (modest_dbus_req_handler):
4040 Put constants in a separate header so it can be reused by the
4041 client library, without duplication
4043 * libmodest-dbus-client/Makefile.am:
4044 * libmodest-dbus-client/libmodest-dbus-client.c:
4045 (libmodest_dbus_client_call_helloworld),
4046 (libmodfest_dbus_client_send_mail),
4047 (libmodfest_dbus_client_mailto),
4048 (libmodfest_dbus_client_open_message):
4049 * libmodest-dbus-client/libmodest-dbus-client.h:
4050 (Partly) Implement a send_mail D-Bus method.
4052 * tests/dbus_api/Makefile.am:
4053 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4054 the send_email D-Bus method.
4056 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4060 * libmodest-dbus-client/Makefile.am:
4061 * libmodest-dbus-client/libmodest-dbus-client.c:
4062 * libmodest-dbus-client/libmodest-dbus-client.h:
4063 * tests/dbus_api/Makefile.am:
4064 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4065 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4067 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4069 * src/maemo/easysetup/modest-easysetup-wizard.c:
4070 (create_page_account_details):
4071 * src/maemo/modest-account-settings-dialog.c:
4072 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4073 widgets, because this might not be the default in future versions of the Maemo GTK+.
4074 However, I can not not get capitalization to work even in a simple test case.
4076 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4078 * src/maemo/easysetup/modest-easysetup-wizard.c:
4079 (create_page_custom_incoming), (create_page_custom_outgoing):
4080 * src/maemo/modest-account-settings-dialog.c:
4081 (create_page_account_details), (create_page_incoming),
4082 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4083 instead of using gtk_check_button_with_label(), so they are aligned like the other
4084 widgets, as per the UI spec.
4086 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4088 * src/maemo/easysetup/modest-easysetup-wizard.c:
4089 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4090 * src/widgets/modest-validating-entry.c:
4091 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4092 Modest prefix instead of an EasySetup prefix.
4094 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4096 * src/widgets/modest-validating-entry.h:
4097 * src/widgets/modest-validating-entry.c: (on_insert_text),
4098 Added easysetup_validating_entry_set_max_func(), used to set a callback
4099 to call when the max number of characters is reached. GtkEntry has a max-length
4100 already but is silent about it.
4102 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4103 (create_page_account_details), (create_page_user_details),
4105 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4106 (create_page_account_details), (create_page_user_details),
4107 (create_page_outgoing):
4108 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4109 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4110 the UI spec, when the user tries to enter more than the max number of characters.
4112 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4114 * src/maemo/easysetup/modest-easysetup-wizard.c:
4115 (create_page_user_details), (create_page_custom_incoming),
4116 (create_page_custom_outgoing):
4117 * src/maemo/modest-account-settings-dialog.c:
4118 (create_page_user_details), (create_page_incoming),
4119 (create_page_outgoing):
4120 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4121 (modest_connection_specific_smtp_edit_window_init):
4122 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4123 not appropriate. Bad Maemo-specific defaults!.
4125 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4127 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4128 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4129 (modest_signature_editor_dialog_set_settings):
4130 Disable the label and textview when the checkbox is disabled, and use the
4131 specified (UI spec) default signature text.
4133 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4135 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4136 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4138 * src/modest-defs.h:
4139 * src/modest-account-mgr-helpers.h:
4140 * src/modest-account-mgr-helpers.c:
4141 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4143 * src/maemo/Makefile.am:
4144 * src/maemo/modest-signature-editor-dialog.c:
4145 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4148 * src/maemo/modest-account-settings-dialog.h:
4149 * src/maemo/modest-account-settings-dialog.c:
4150 (modest_account_settings_dialog_finalize), (on_button_signature),
4151 (save_configuration): Use the new dialog when the Edit button is pressed, and
4152 save the changes if necessary, as per the UI spec.
4154 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4156 * src/maemo/Makefile.am:
4157 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4158 based on maemo-develoers email from Dirk.
4160 * src/maemo/easysetup/modest-easysetup-wizard.c:
4161 (create_page_welcome), (create_page_account_details),
4162 (create_page_user_details), (create_page_complete_easysetup),
4163 (create_page_custom_incoming), (create_page_custom_outgoing),
4164 (create_page_complete_custom),
4165 (modest_easysetup_wizard_dialog_init):
4166 * src/maemo/modest-account-settings-dialog.c:
4167 (create_page_account_details), (create_page_user_details),
4168 (create_page_incoming), (create_page_outgoing),
4169 (modest_account_settings_dialog_init):
4170 * src/maemo/modest-connection-specific-smtp-window.c:
4171 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4173 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4175 * src/maemo/easysetup/modest-easysetup-wizard.c:
4176 (create_page_account_details), (create_page_custom_outgoing),
4177 (create_page_complete_custom):
4178 * src/maemo/modest-account-settings-dialog.c:
4179 (create_page_user_details), (create_page_incoming),
4180 (create_page_outgoing):
4181 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4182 (modest_connection_specific_smtp_edit_window_init):
4183 Use the correct (UI spec) port min/max, and use horizontal separators,
4186 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/easysetup/modest-easysetup-wizard.c:
4189 (set_default_custom_servernames):
4190 * src/maemo/modest-account-settings-dialog.c:
4191 (create_page_incoming), (on_combo_outgoing_security_changed),
4192 (on_combo_incoming_security_changed), (create_page_outgoing),
4193 (modest_account_settings_dialog_set_account_name),
4194 (save_configuration):
4195 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4196 (on_combo_security_changed),
4197 (modest_connection_specific_smtp_edit_window_init),
4198 (modest_connection_specific_smtp_edit_window_set_connection),
4199 (modest_connection_specific_smtp_edit_window_get_settings):
4200 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4203 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4206 * src/maemo/easysetup/modest-easysetup-wizard.c:
4207 (create_page_custom_outgoing), (create_page_complete_custom):
4208 * src/maemo/modest-account-settings-dialog.c:
4209 (create_page_user_details), (create_page_outgoing):
4210 * src/maemo/modest-account-view-window.c: (button_box_new):
4211 Use changed logical IDs as per the most recent UI spec:
4212 mcen_bd_emailsetup_edit -> mcen_bd_edit
4213 mcen_bd_emailsetup_delete -> mcen_bd_delete
4214 mcen_bd_emailsetup_close -> mcen_bd_close
4216 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4220 * src/dbus_api/Makefile.am:
4221 * src/dbus_api/modest-dbus-callbacks.c:
4222 * src/dbus_api/modest-dbus-callbacks.h:
4223 * src/maemo/modest-platform.c: (modest_platform_init):
4224 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4226 * tests/Makefile.am:
4227 * tests/dbus_api/Makefile.am:
4228 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4230 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4232 * src/maemo/modest-account-settings-dialog.c:
4233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4234 Removed unnecessary includes.
4236 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4238 * src/maemo/easysetup/modest-easysetup-wizard.c:
4239 * src/maemo/modest-account-settings-dialog.c:
4240 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4241 * src/widgets/Makefile.am:
4242 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4243 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4244 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4245 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4246 * src/widgets/modest-secureauth-combo-box.c:
4247 * src/widgets/modest-secureauth-combo-box.h:
4248 * src/widgets/modest-serversecurity-combo-box.c:
4249 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4250 made the GObject names more consistent with the rest of the Modest code.
4252 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/easysetup/Makefile.am:
4255 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4256 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4257 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4258 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4259 * src/maemo/easysetup/modest-easysetup-wizard.c:
4260 * src/maemo/easysetup/modest-validating-entry.c:
4261 * src/maemo/easysetup/modest-validating-entry.h:
4262 * src/maemo/modest-account-settings-dialog.c:
4263 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4264 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4265 widgets/ because they are used outside of easysetup too. After checking in,
4266 svn will allow me to rename them too.
4268 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4270 * src/gnome/modest-msg-edit-window.c:
4271 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4272 linker error, to fix the build on the GNOME platform.
4273 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4274 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4275 ifdefed out to avoid a warning.
4277 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4279 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4280 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4281 some alternative for GTK+ 2.6.
4283 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4285 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4287 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4288 specified for EmailAccountsDialog in UI spec.
4290 * src/maemo/easysetup/modest-easysetup-wizard.c:
4291 * src/maemo/easysetup/modest-easysetup-wizard.h:
4292 * src/maemo/modest-account-settings-dialog.c:
4293 * src/maemo/modest-account-settings-dialog.h:
4294 Reuse a member window widget for the connection-specific SMTP server accounts,
4295 so we can tell it to create/save the accounts only if we actually save changes.
4297 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4299 (modest_connection_specific_smtp_edit_window_get_settings):
4300 Return a struct instance for temporarily remembering the entered data.
4302 * src/maemo/modest-connection-specific-smtp-window.h:
4303 * src/maemo/modest-connection-specific-smtp-window.c:
4304 (modest_connection_specific_smtp_window_finalize),
4305 (modest_connection_specific_smtp_window_fill_with_connections),
4307 (modest_connection_specific_smtp_window_save_server_accounts),
4308 (update_model_server_names): Do not actually save data until asked,
4309 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4311 (on_selection_changed),
4312 (modest_connection_specific_smtp_window_init): Disable the edit
4313 button when nothing is selected.
4315 * src/modest-account-mgr-helpers.c:
4316 * src/modest-account-mgr-helpers.h:
4317 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4320 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4322 * src/modest-account-mgr-helpers.h:
4323 * src/modest-account-mgr-helpers.c:
4324 (modest_account_mgr_get_unused_account_name),
4325 (modest_account_mgr_get_unused_account_display_name): Added these
4326 utility functions, to avoid code duplication.
4328 * src/maemo/easysetup/modest-easysetup-wizard.c:
4329 (create_page_account_details), (create_account):
4330 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4331 (on_combo_security_changed),
4332 (modest_connection_specific_smtp_edit_window_init),
4333 (modest_connection_specific_smtp_edit_window_save_settings):
4334 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4335 * src/maemo/modest-connection-specific-smtp-window.c:
4336 (modest_connection_specific_smtp_window_finalize),
4337 (modest_connection_specific_smtp_window_fill_with_connections),
4338 (on_button_edit), (modest_connection_specific_smtp_window_init):
4339 * src/maemo/modest-connection-specific-smtp-window.h:
4340 Implementing saving of connection-specific server accounts.
4342 But I need to refactor this so we can save the data for each
4343 possible connection-specific account and only actually create the server accounts
4344 when the easysetup finished, or the OK button is pressed on the account settings
4347 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4349 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4350 (on_combo_security_changed):
4351 (modest_connection_specific_smtp_edit_window_init):
4352 Auto-fill the port number as in the account settings.
4354 (modest_connection_specific_smtp_edit_window_set_connection):
4355 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4356 * src/maemo/modest-connection-specific-smtp-window.c:
4357 (fill_with_connections), (on_button_edit),
4358 (modest_connection_specific_smtp_window_init):
4359 Turn the edit window into a dialog to simplify the code, and
4360 set a WM hint as in a GtkDialog, because only a popup can be on top of
4361 another window in Maemo, and popups usually have no WM decoration.
4363 * src/modest-defs.h:
4364 * src/modest-account-mgr-helpers.c:
4365 (modest_account_mgr_set_connection_specific_smtp),
4366 (modest_account_mgr_remove_connection_specific_smtp),
4367 (modest_account_mgr_get_connection_specific_smtp):
4368 * src/modest-account-mgr-helpers.h: Some functions to write the
4369 connection-specific SMTP server information. Not yet used.
4372 * src/widgets/modest-folder-view.c: (text_cell_data):
4373 Fix a warning about an uninitialized variable.
4374 (on_configuration_key_changed): Put an #ifdef around the use
4375 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4377 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4379 * src/maemo/modest-account-settings-dialog.h:
4380 * src/maemo/modest-account-settings-dialog.c:
4381 Added connect_for_modified() utility function to mark the new modified boolean.
4383 (create_page_account_details), (create_page_user_details),
4384 (create_page_incoming), (create_page_outgoing), (on_response),
4385 (modest_account_settings_dialog_init),
4386 (modest_account_settings_dialog_set_account_name):
4387 Only warn about unsaved changes when there are actually unsaved changes.
4389 * src/modest-account-mgr-helpers.c:
4390 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4391 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4392 to get the data from there in future.
4394 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4396 * src/modest-defs.h:
4398 * src/modest-account-mgr-helpers.h:
4399 * src/modest-account-mgr-helpers.c:
4400 Store the security account setting in a single conf key instead of using
4401 the options list, so that the list is left for just the to-be-removed camel hack,
4402 and because gconf_client_set_list() is failing for some reason.
4404 * src/modest-account-mgr.c:
4405 (modest_account_mgr_add_server_account):
4406 * src/maemo/modest-account-settings-dialog.c:
4407 (modest_account_settings_dialog_set_account_name),
4408 (save_configuration): Use the renamed functions.
4411 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4413 * src/widgets/Makefile.am:
4414 * src/widgets/modest-limit-retrieve-combo-box.c:
4415 * src/widgets/modest-limit-retrieve-combo-box.h:
4416 * src/widgets/modest-retrieve-combo-box.c:
4417 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4418 the account settings dialog.
4420 * src/modest-defs.h:
4421 * src/modest-account-mgr-helpers.h:
4422 * src/modest-account-mgr-helpers.c:
4423 (modest_server_account_get_option_secure_auth),
4424 (modest_server_account_set_option_secure_auth):
4425 * src/modest-account-mgr.c:
4426 (modest_account_mgr_add_server_account):
4427 Use the existing AUTH_MECH conf key for the secure-auth setting,
4428 instead of putting it in the list options, because this was actually used already.
4430 * src/maemo/modest-account-settings-dialog.c:
4431 (create_page_account_details),
4432 (modest_account_settings_dialog_set_account_name),
4433 (save_configuration):
4434 * src/maemo/modest-account-settings-dialog.h:
4435 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4436 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4438 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4440 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4441 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4442 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4444 * src/modest-defs.h:
4445 * src/maemo/modest-account-settings-dialog.c:
4446 (create_page_incoming), (on_combo_outgoing_security_changed),
4447 (on_combo_incoming_security_changed), (create_page_outgoing),
4448 (modest_account_settings_dialog_set_account_name),
4449 (save_configuration): Load/Save the port number, and change it when the
4450 security combo changes, to suitable defaults.
4452 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4454 * src/modest-account-mgr.c:
4455 (modest_account_mgr_add_server_account): Set the security and secure-auth
4456 options, and add a comment saying that the other camel-specific options should be
4459 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4461 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4463 * src/modest-tny-account-store.c: (account_list_free),
4464 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4465 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4468 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4470 * src/modest-protocol-info.c:
4471 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4472 is required by our UI spec. Maybe something in our implementation will use this eventually.
4473 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4474 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4475 instead of the previous 0 placeholder.
4477 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4478 secure-auth settings.
4479 * src/modest-account-mgr-helpers.h:
4480 * src/modest-account-mgr-helpers.c:
4481 (modest_server_account_data_get_option_secure_auth),
4482 (modest_server_account_set_option_secure_auth),
4483 (modest_server_account_data_get_option_security),
4484 (modest_server_account_set_option_security): Added this API for getting and setting the security
4485 and secure-auth settings.
4487 * src/maemo/modest-account-settings-dialog.h:
4488 * src/maemo/modest-account-settings-dialog.c:
4489 (modest_account_settings_dialog_finalize), (check_data),
4490 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4491 about changing titles.
4492 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4493 (save_configuration): Save the security and secure-auth settings.
4495 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4496 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4498 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4500 * src/modest-defs.h:
4501 * src/modest-account-mgr.c:
4502 (modest_account_mgr_add_server_account):
4503 Added and used defines for the options key and value pair strings,
4504 that are used so far, though they do not seem to correspond to anything in our
4505 UI specs or ModestProtocol enum.
4507 * src/modest-account-mgr-helpers.h:
4508 * src/modest-account-mgr-helpers.c:
4509 (compare_option_strings_for_name),
4510 (modest_server_account_data_get_option_value),
4511 (modest_server_account_data_get_option_bool),
4512 (modest_account_mgr_get_server_account_option):
4513 Added helper functions for parsing the options GSList.
4515 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4517 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4518 display name is based on the supplied account name.
4519 * src/modest-account-mgr.c:
4520 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4521 with an inefficient, but good-enough, implementation.
4523 * src/maemo/easysetup/modest-easysetup-wizard.c:
4524 (create_page_account_details), (on_before_next), (create_account):
4525 Check for existing display names rather than (non-user-visible) account names, and just
4526 create and set a unique account name at the end.
4528 * src/maemo/modest-account-settings-dialog.c:
4529 (modest_account_settings_dialog_init),
4530 (modest_account_settings_dialog_set_account_name),
4531 (create_page_incoming): Show the display name, instead of the account name.
4532 (on_response): Do some (not all) extra checks, as in the UI spec.
4533 (save_configuration): Save the display name if it was changed.
4535 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4537 * po/en_GB.po: Added needed logical ID and translation.
4538 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4539 (init_view): Made the is-default column clicking work.
4541 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4544 * src/maemo/easysetup/Makefile.am:
4545 * src/maemo/easysetup/modest-easysetup-wizard.c:
4546 (modest_easysetup_wizard_dialog_init):
4547 * src/maemo/easysetup/provider-data-test.keyfile:
4548 * src/maemo/easysetup/provider-data.keyfile:
4549 Moved the provider data file to the new modest-providers-data package and used it from there.
4551 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4553 * src/modest-local-folder-info.c:
4554 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4555 N_() was already used on the static strings, but this just marks it for translation without
4556 using the translation.
4558 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4560 * src/maemo/modest-account-settings-dialog.c:
4561 (create_page_incoming),
4562 (modest_account_settings_dialog_set_account_name):
4563 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4564 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4565 I will do this if nobody else gets there first.
4567 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4569 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4570 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4571 save the security stuff.
4573 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4575 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4576 Set the email address and user fullname, which I now see must be
4579 * src/maemo/modest-account-settings-dialog.h:
4580 * src/maemo/modest-account-settings-dialog.c:
4582 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4583 leave-on-server and authentication.
4584 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4587 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4590 * src/maemo/modest-account-settings-dialog.c:
4591 * src/maemo/modest-account-settings-dialog.h:
4592 Most (but not all) of the widgets are now present as specified by the UI spec.
4593 No changes are yet saved, and some details are not properly shown yet.
4595 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4597 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4599 * src/maemo/Makefile.am:
4600 * src/maemo/modest-account-settings-dialog.c:
4601 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4602 an existing account. Doesn't do much yet.
4604 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4605 Open the accounts settings dialog when Edit is clicked.
4607 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4609 * src/maemo/easysetup/Makefile.am:
4610 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4612 * src/maemo/easysetup/modest-easysetup-wizard.c:
4613 (modest_easysetup_wizard_dialog_init):
4614 Try to get the source directory from the build system,
4615 instead of hard-coding "./" into the source code, when opening our local
4616 copies of the configuration files.
4617 But this still fails when opening the wizard from the Accounts window,
4618 maybe because the working directory seems to change at runtime.
4619 So the wizard will fail the second time unless you copy the files into their
4620 proper locations - see the stdout warnings for the paths.
4622 (create_page_account_details),(on_before_next):
4623 Check for existing non-server accounts instead of server accounts,
4624 so the default account name is useful again, and to prevent trying to
4627 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4628 Show the wizard when New is clicked.
4630 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4631 (init_view): Show the column headers, and show the columns that are
4632 specified in the UI specs. However, something in Maemo's GTK+ prevents
4633 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4634 change the default account. This is despite unsetting the special properties.
4636 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4638 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4639 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4640 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4641 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4642 to make that clearer.
4643 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4645 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4647 * src/maemo/modest-account-view-window.c:
4648 (modest_account_view_window_init),
4649 (modest_account_view_window_new):
4650 Use the same buttons as specified in the
4651 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4652 the existing widgets, which never had a chance of working.
4653 Put the ModestAccountView treeview in a scrolled window.
4654 Do not repeat the initialization in both _init() and _new().
4656 * src/widgets/modest-account-view.c: (update_account_view):
4657 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4658 this widget and window shows no accounts.
4660 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4662 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4664 * src/maemo/easysetup/modest-easysetup-wizard.c:
4665 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4666 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4667 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4670 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4671 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4672 accounts exist yet, as in the UI spec.
4674 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4676 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4678 * src/maemo/Makefile.am:
4679 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4680 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4681 New window for editing connection-specific smtp details.
4682 Not fully implemented.
4684 * src/maemo/modest-connection-specific-smtp-window.c:
4685 (modest_connection_specific_smtp_window_finalize) :
4686 unref the tree model.
4687 (on_button_edit): Show the edit window.
4689 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4691 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4694 * src/maemo/Makefile.am:
4695 * src/maemo/modest-connection-specific-smtp-window.c:
4696 * src/maemo/modest-connection-specific-smtp-window.h:
4697 New window for showing the list of connections, for connection-specific
4698 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4699 * src/maemo/easysetup/modest-easysetup-wizard.c:
4700 (create_page_custom_outgoing): Show the new window when the button is clicked.
4702 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4704 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4705 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4706 * src/maemo/modest-msg-edit-window.c:
4707 (modest_msg_edit_window_insert_image):
4708 * src/modest-conf.c: (modest_conf_key_escape):
4709 * src/modest-mail-operation.c:
4710 (modest_mail_operation_send_new_mail):
4711 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4712 (modest_ui_actions_on_new_account):
4713 * src/widgets/modest-attachment-view.c: (update_filename_request):
4714 * src/widgets/modest-mail-header-view.c:
4715 Corrected warnings that were breaking the build, by commenting out unused variables,
4716 and a function, and by including a header.
4718 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4720 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4721 so we can #ifdef around platform-specific code when necessary.
4722 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4723 to allow this to build for the GNOME platform too.
4725 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4727 * src/maemo/easysetup/modest-easysetup-wizard.c:
4728 Added util_increment_name() and used it in create_page_account_details()
4729 to make sure that the default account name is always a new name.
4731 (modest_easysetup_wizard_dialog_init),
4732 (set_default_custom_servernames): Some minor memory management fixes.
4734 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4738 * src/modest-runtime.c: (init_i18n): Restored the translation
4739 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4740 are defined in config.h, and the translations are installed.
4742 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4743 is defined for translation.
4745 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4747 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4749 * src/maemo/easysetup/modest-easysetup-wizard.c:
4750 (modest_easysetup_wizard_dialog_init):
4751 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4752 Use realistic paths (though they should use $prefix generically) to the
4753 mcc_mapping and provider-data.keyfile files which might work when they
4754 are installed by the future version of the operator-wizard package,
4755 and then fallback to paths in our source code, with an explanatory
4758 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4762 * src/maemo/Makefile.am:
4763 * src/maemo/easysetup/: Added files from the previously-exernal
4764 osso-modest-easysetup.
4765 * src/maemo/modest-main-window-ui.h:
4766 * src/modest-ui-actions.c:
4767 * src/modest-ui-actions.h:
4768 Added modest_ui_actions_on_new_account() as a signal handler for the
4769 New Account menu item. It shows the easysetup wizard.
4770 * po/en_GB.po: Added additional needed logical IDs and translations.