modest
16 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Wed, 12 Sep 2007 10:45:24 +0000 (10:45 +0000)]
* src/widgets/modest-folder-view.c:
        * Added reexpand private attribute. This is enabled when there
          are new folders in folder view. Then, all the available
          folders are expanded at least in the first depth level. This
          is instead of always expanding on map (fixes NB#65051).
        * (expand_root_items): modified the method to expand the items.
          Now we iterate on all the root folders until there's no next
          folder, instead of only expanding on folders with children.
          This way the local folders are expanded always, even when
          remote root folder does not have children.
        * Now we scroll to the selected cell to highlight it.
        * Now we mark as selectable any new inbox folder added to the
          view. This is ok as we'll be only showing one remote inbox
          folder at a time.

pmo-trunk-r3284

16 years ago* build with -fPIC for the launcher
Dirk-Jan C. Binnema [Wed, 12 Sep 2007 09:16:58 +0000 (09:16 +0000)]
* build with -fPIC for the launcher

pmo-trunk-r3283

16 years ago * Added some checks that prevent glib criticals in some cases
Sergio Villar Senin [Wed, 12 Sep 2007 08:54:03 +0000 (08:54 +0000)]
* Added some checks that prevent glib criticals in some cases

pmo-trunk-r3282

16 years ago * Removed a connect_and_wait from the mail_operations because UI code is not allowed...
Sergio Villar Senin [Tue, 11 Sep 2007 16:40:20 +0000 (16:40 +0000)]
* Removed a connect_and_wait from the mail_operations because UI code is not allowed in that part of the code. Moved it to the UI actions
* Fixed an infinite loop in on_cert_dialog_response caused by a recursive gtk_dialog_response in the handler
* Fixed a logical id
* Removed some unused debug code
* Fixes NB#62237, new notification for invalid certificates (using some previous code from djcb)
* Fixes NB#60517, the Send&Receive option in the main menu no longer freezes the progress bar

pmo-trunk-r3278

16 years agoReverted tny_folder_sync to tny_folder_sync_async to solve 66145
Philip Van Hoof [Tue, 11 Sep 2007 15:20:29 +0000 (15:20 +0000)]
Reverted tny_folder_sync to tny_folder_sync_async to solve 66145

pmo-trunk-r3276

16 years ago2007-09-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 11 Sep 2007 14:20:10 +0000 (14:20 +0000)]
2007-09-11  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name): Set the incoming
secure-auth checkbox only when a secure auth method is really specified
in gconf. For some reason, it was set also if a secure connection was
chosen, but that does not make sense to me, and was not commented.
For instance, this stops the user from seeing an error about unsupported
secure authentication when editing a gmail account.

pmo-trunk-r3274

16 years ago* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
Jose Dapena Paz [Tue, 11 Sep 2007 12:05:25 +0000 (12:05 +0000)]
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
        * Now countries ellipsize if required to prevent cutting
          caption labels.
* src/maemo/easysetup/modest-easysetup-wizard.c:
        * CHange all labels to expand and wrap correctly (fixes
          NB#63507).
        * Add scrolled window to incoming page.
        * Add all pages to notebook with expand and fill properties
          enabled.

pmo-trunk-r3269

16 years ago* src/modest-dimming-rules-group.[ch]:
Jose Dapena Paz [Tue, 11 Sep 2007 09:17:43 +0000 (09:17 +0000)]
* src/modest-dimming-rules-group.[ch]:
        * Added new method modest_dimming_rules_group_add_widget_rule.
          This method connects a dimming rule to a widget in the group,
          so that we can connect rules to widgets outside an ui manager.
        * Refactored some code to add rules to the dimming rules group
          from the methods add_rules and add_widget_rule.
* src/modest-dimming-rule.[ch]:
        * Now dimming rules can be connected to widgets, not only to
          ui manager action paths.
        * Added new methods for getting the action path and connected
          widget from outside.
* src/gnome/modest-main-window.c:
        * Adapted to change in in modest_main_window_get_child_widget
          type.
* src/widgets/modest-msg-edit-window.h:
        * Added method modest_msg_edit_window_get_child_widget to access
          editor widgets from external methods (in particular from
          ui dimming rules).
        * Added methods to get can-undo and can-redo status.
* src/widgets/modest-msg-edit-window-ui.h:
        * Added ui action handlers for menu parents, so that we can run
          dimming rules.
* src/widgets/modest-main-window.h:
        * Changed modest_main_window_get_child_widget types to have a
          proper namespace (instead of MODEST_WIDGET_TYPE_* now we have
          MODEST_MAIN_WINDOW_WIDGET_TYPE_*).
* src/modest-ui-actions.[ch]:
        * Adapted calls to modest_main_window_get_child_widget new api.
        * Added new method modest_ui_actions_on_format_menu_activated,
          to run the dimming rules on showing the format menu.
* src/dbus_api/modest-dbus-callback.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-msg-edit-window.c:
        * Removed insensitive handlers, as now they're managed in
          dimming manager. In particular, we remove methods
          send_insensitive_press, style_insensitive_press,
          setup_insensitive_handlers.
        * Added "move-cursor" signal handler subject_field_move_cursor.
          This is required because moving cursor in a way that drops
          selection in a GtkEntry does not change primary clipboard
          selection.
        * Removed methods to update dimming status, as this is now
          managed in dimming manager. In particular we drop
          update_dimmed, update_paste_dimming,
          update_remove_attachment_dimming, update_copy_cut_dimming,
          update_select_all_dimming, update_zoom_dimming,
          update_send_dimming.
        * Also removed methods to handle menu activation, as this is now
          handled in the ui manager.
        * Added methods to get the can_undo and can_redo status. This is
          updated through signal handlers of wptextbuffer, as this does
          not provide a method to check this on real time.
        * Added signal handler for owner change in default clipboard
          (required to manage properly paste dimming).
        * Now we use dimming rules for toolbar, menus and clipboard
          based actions. We also use specific dimming rule binding for
          the widgets that we don't get from ui manager (font size and
          face selection, color selection).
        * Implementation of new method
          modest_msg_edit_window_get_child_widget, to access children
          from outside (in particular from dimming rules).
* src/maemo/modest-platform.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-msg-view-window.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-main-window.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/modest-ui-dimming-rules.[ch]:
        * Adapted calls to modest_main_window_get_child_widget new api.
        * (..._on_select_all): added implementation for editor widget.
        * (..._on_undo): added implementation for editor widget.
        * New dimming rule ..._on_redo.
        * New dimming rule ..._on_set_style, for style operations of
          message editor.
        * New dimming rule ..._on_zoom for editor (we can only zoom
          when focus is on body).
        * New dimming rule ..._on_editor_paste. This operation depends
          on clipboard, so it cannot be hooked in menu activation
          methods.
        * New dimming rule ..._on_editor_remove_attachment for editor.
        * New dimming rule ..._on_send for editor.
        * Added support in _invalid_clipboard_selected for editor.

pmo-trunk-r3264

16 years ago * Fixes NB#64889, the connection specific SMTP window is closed now in response...
Sergio Villar Senin [Mon, 10 Sep 2007 17:53:56 +0000 (17:53 +0000)]
* Fixes NB#64889, the connection specific SMTP window is closed now in response to a Escape key press

pmo-trunk-r3261

16 years ago * Now it really fixes NB#64908, the accounts window is now modal and allow another...
Sergio Villar Senin [Mon, 10 Sep 2007 17:28:01 +0000 (17:28 +0000)]
* Now it really fixes NB#64908, the accounts window is now modal and allow another dialogs to be shown

pmo-trunk-r3259

16 years ago * Reopening NB#64908 because setting this dialog modal does not enable the user...
Sergio Villar Senin [Mon, 10 Sep 2007 17:12:32 +0000 (17:12 +0000)]
* Reopening NB#64908 because setting this dialog modal does not enable the user to access to the other dialogs that could be launched with the edit or new buttons

pmo-trunk-r3258

16 years ago * Fixes NB#64908, the account list window is now modal
Sergio Villar Senin [Mon, 10 Sep 2007 16:48:07 +0000 (16:48 +0000)]
* Fixes NB#64908, the account list window is now modal
* removed some code from maemo utils

pmo-trunk-r3257

16 years ago * Fixes NB#66420, warn the user before editing online accounts, the previous check...
Sergio Villar Senin [Mon, 10 Sep 2007 10:35:58 +0000 (10:35 +0000)]
* Fixes NB#66420, warn the user before editing online accounts, the previous check was not right, it was checking only that the account was doing a send receive
* Fixes a leak reference

pmo-trunk-r3252

16 years agoClipboard dimming rules shouldn't be run in show menu callbacks
Jose Dapena Paz [Mon, 10 Sep 2007 09:42:36 +0000 (09:42 +0000)]
Clipboard dimming rules shouldn't be run in show menu callbacks
(fixes NB#65033).
* src/maemo/modest-msg-view-window.c:
        * Use new clipboard dimming rules in owner change handler,
          and in widget startup.
* src/maemo/modest-msg-view-window-ui-dimming.h:
        * Create new clipboard dimming rules group, and move clipboard
          status depending rules from menu to the new group.

pmo-trunk-r3250

16 years ago * Fixed a typo
Sergio Villar Senin [Mon, 10 Sep 2007 08:41:15 +0000 (08:41 +0000)]
* Fixed a typo
* Uncommented some code

pmo-trunk-r3247

16 years ago * Changed the update_account_thread it now refreshes the INBOX and pokes the other...
Sergio Villar Senin [Fri, 7 Sep 2007 16:11:32 +0000 (16:11 +0000)]
* Changed the update_account_thread it now refreshes the INBOX and pokes the other folders
* Changed the signature of the signal that notifies about new messages
* Added the proper dbus call when new messages arrive to the notification
* replaced the old new_msg method of modest-platform by new_header_arrived
* Fixes NB#59971 adds message notifications, NB#63779 adds LED pattern to the notifications

pmo-trunk-r3246

16 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Fri, 7 Sep 2007 16:05:02 +0000 (16:05 +0000)]
* src/maemo/modest-main-window.c:
* Convert the View addittions menu items for selecting the
  currently viewed account to radio items (fixes NB#65054).

pmo-trunk-r3245

16 years ago * Fixed a leak reference
Sergio Villar Senin [Fri, 7 Sep 2007 14:47:21 +0000 (14:47 +0000)]
* Fixed a leak reference
* Added a g_object_ref because otherwise we're unreferencing too much the transport accounts and this caused a SIGSEV when finalizing the account store

pmo-trunk-r3244

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 7 Sep 2007 13:20:44 +0000 (13:20 +0000)]
* src/maemo/modest-msg-edit-window.c:
* We were resetting the format to the configuration one in
  editor instead of preserving the one of the original message.
  Removed that code (fixes NB#64077).

pmo-trunk-r3243

16 years ago* fix compiler warning
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 11:59:44 +0000 (11:59 +0000)]
* fix compiler warning

pmo-trunk-r3242

16 years agoAdded bugs for the week 37-1 pre-release. 7th Sept
Vivek Sekar [Fri, 7 Sep 2007 10:59:14 +0000 (10:59 +0000)]
Added bugs for the week 37-1 pre-release. 7th Sept

pmo-trunk-r3239

16 years agoWhen moving messages to a local folder don't try to connect if the
Alberto Garcia [Fri, 7 Sep 2007 10:33:36 +0000 (10:33 +0000)]
When moving messages to a local folder don't try to connect if the
remote folder is POP3 and all messages are already cached. It's not
necessary as in POP3 all messages are removed from the server when
they're opened.

Fixes NB#65235

pmo-trunk-r3238

16 years ago* moved the tny alert dialog stuff to modest-platform
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 10:11:00 +0000 (10:11 +0000)]
* moved the tny alert dialog stuff to modest-platform
* cleaned up the tnyalert handling a bit modest-tny-account-store
* implemented the SSL certificate handling dialogs; not hooked up yet

pmo-trunk-r3237

16 years ago* move the instantiation of modest-tny-account-store to modest runtime;
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 09:50:23 +0000 (09:50 +0000)]
* move the instantiation of modest-tny-account-store to modest runtime;
  (from singletons). before, we were seeing various chicken & egg problems,
  and Glib-Criticals at startup.

pmo-trunk-r3236

16 years agoDon't ask for confirmation on modest_ui_actions_xfer_messages_from_move_to(), it...
Alberto Garcia [Fri, 7 Sep 2007 09:01:53 +0000 (09:01 +0000)]
Don't ask for confirmation on modest_ui_actions_xfer_messages_from_move_to(), it's redundant

pmo-trunk-r3235

16 years ago * Removed a duplicated save_state call
Sergio Villar Senin [Fri, 7 Sep 2007 07:32:10 +0000 (07:32 +0000)]
* Removed a duplicated save_state call

pmo-trunk-r3233

16 years agoUpdated to Tinymail's recent API change
Philip Van Hoof [Thu, 6 Sep 2007 20:05:49 +0000 (20:05 +0000)]
Updated to Tinymail's recent API change

pmo-trunk-r3232

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 6 Sep 2007 17:35:21 +0000 (17:35 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added a method that catches move-focus signal. In case the
  focus is on attachments view, it stops signal handler,
  preventing this way the focus (fixes NB#66802).

pmo-trunk-r3231

16 years ago* src/maemo/modest-maemo-global-settings-dialog.c:
Jose Dapena Paz [Thu, 6 Sep 2007 17:17:59 +0000 (17:17 +0000)]
* src/maemo/modest-maemo-global-settings-dialog.c:
* Added "notify" signal handler for the size limit
  editor. This way we track the value. If the value is 0
  we dim it (fixes NB#62647).

pmo-trunk-r3230

16 years ago* Select previous row if last rheader is deleted.
Javier Fernandez Garcia-Boente [Thu, 6 Sep 2007 13:58:20 +0000 (13:58 +0000)]
* Select previous row if last rheader is deleted.
* Fixes: NB#65265

pmo-trunk-r3228

16 years agoDon't pass the GtkWindow to header_list_count_uncached_msgs(), it's
Alberto Garcia [Thu, 6 Sep 2007 13:46:31 +0000 (13:46 +0000)]
Don't pass the GtkWindow to header_list_count_uncached_msgs(), it's
not necessary.

pmo-trunk-r3227

16 years ago* fix for NB#63690
Dirk-Jan C. Binnema [Thu, 6 Sep 2007 12:47:48 +0000 (12:47 +0000)]
* fix for NB#63690

pmo-trunk-r3226

16 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 6 Sep 2007 11:01:27 +0000 (11:01 +0000)]
* src/modest-mail-operation.c:
* (idle_create_msg_cb): do gdk_threads_leave to protect also
  the unref's, as they can cause locks (fixes NB#65540).

pmo-trunk-r3225

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 21:25:58 +0000 (21:25 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now set zoom updates the radio menu option properly
  (fixes NB#65274).

pmo-trunk-r3222

16 years ago* src/modest-tny-folder.c:
Jose Dapena Paz [Wed, 5 Sep 2007 19:46:31 +0000 (19:46 +0000)]
* src/modest-tny-folder.c:
* (modest_tny_folder_guess_folder_type_from_name): fixed
  this function. We were downcasing the name, but not the
  strings we were comparing with (fixes NB#65059).

pmo-trunk-r3221

16 years ago* Check for opened edit-windows before close all windows.
Javier Fernandez Garcia-Boente [Wed, 5 Sep 2007 17:55:28 +0000 (17:55 +0000)]
* Check for opened edit-windows before close all windows.
* Fixes: NB#64364

pmo-trunk-r3220

16 years ago* src/maemo/modest-account-settings-dialog.c:
Jose Dapena Paz [Wed, 5 Sep 2007 16:07:39 +0000 (16:07 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* Now the account details tab is also including a scroll to
  prevent some weird problems that hide the buttons sometimes
  (fixes NB#64537).

pmo-trunk-r3219

16 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 13:49:44 +0000 (13:49 +0000)]
* src/maemo/modest-main-window.c:
* Pending change for disabling toggling cut/copy/paste CSM actions in main menu.

pmo-trunk-r3218

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 12:50:35 +0000 (12:50 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Rework the cut/copy dimming in editor in order to be accurate
  (fixes NB#63877).

pmo-trunk-r3217

16 years ago* Add information banner (Opening) when user open
Javier Fernandez Garcia-Boente [Wed, 5 Sep 2007 12:01:59 +0000 (12:01 +0000)]
* Add information banner (Opening) when user open
messages from Draft or Outbox folders.
* Fixes: NB#64296

pmo-trunk-r3215

16 years agounified all the bugs into a single entry in the changelog, for week 36 - release...
Vivek Sekar [Wed, 5 Sep 2007 11:36:23 +0000 (11:36 +0000)]
unified all the bugs into a single entry in the changelog, for week 36 - release, 05th sept.

pmo-trunk-r3213

16 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Wed, 5 Sep 2007 09:35:04 +0000 (09:35 +0000)]
* src/modest-mail-operation.c:
* Now we only show the move folder error as copy is not
  present in translation.

pmo-trunk-r3212

16 years ago2007-09-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 5 Sep 2007 08:35:02 +0000 (08:35 +0000)]
2007-09-05  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication),
(modest_maemo_utils_get_supported_secure_authentication_methods):
Adapted to the changed tinymail signature of the callback, and
printf a warning when there is an exception, as a clue.

pmo-trunk-r3211

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 4 Sep 2007 16:11:41 +0000 (16:11 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now we use the primary selection clipboard for checking
  cut/copy dimming (fixes NB#62432).

pmo-trunk-r3209

16 years ago* Fixed some strange behaviour on send-queues and
Javier Fernandez Garcia-Boente [Tue, 4 Sep 2007 16:05:40 +0000 (16:05 +0000)]
* Fixed some strange behaviour on send-queues and
sending status management.

pmo-trunk-r3208

16 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:47:13 +0000 (15:47 +0000)]
* src/widgets/modest-msg-view.c:
* Reenabled message view scroll on find in page (fixes
  NB#62258).

pmo-trunk-r3207

16 years ago* src/maemo/modest-retrieve-combo-box.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:43:00 +0000 (15:43 +0000)]
* src/maemo/modest-retrieve-combo-box.c:
* Finally disabled "messages" retrieval options. Now we only
  support "headers only" and "messages with attachments"
  options (fixes NB#58475).

pmo-trunk-r3206

16 years ago * Fixes NB#64093 the message count in folders is now recursive
Sergio Villar Senin [Tue, 4 Sep 2007 15:34:24 +0000 (15:34 +0000)]
* Fixes NB#64093 the message count in folders is now recursive

pmo-trunk-r3205

16 years ago* src/widgets/modest-recpt-view.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:33:54 +0000 (15:33 +0000)]
* src/widgets/modest-recpt-view.c:
* Grab focus on click, so that clipboard operations do what we
  expect them to do (fixes NB#64898).

pmo-trunk-r3204

16 years ago * Fixes NB#64415, now the show_toolbar options are per window type specific
Sergio Villar Senin [Tue, 4 Sep 2007 13:54:21 +0000 (13:54 +0000)]
* Fixes NB#64415, now the show_toolbar options are per window type specific
* Deleted some unused methods

pmo-trunk-r3202

16 years ago * Replaced the casting by a proper variable definition
Sergio Villar Senin [Tue, 4 Sep 2007 13:28:37 +0000 (13:28 +0000)]
* Replaced the casting by a proper variable definition

pmo-trunk-r3201

16 years agoCompilation warning
Philip Van Hoof [Tue, 4 Sep 2007 11:59:22 +0000 (11:59 +0000)]
Compilation warning

pmo-trunk-r3200

16 years ago* src/maemo/modest-main-window-ui-dimming.h:
Jose Dapena Paz [Tue, 4 Sep 2007 09:27:18 +0000 (09:27 +0000)]
* src/maemo/modest-main-window-ui-dimming.h:
* Removed the dimming rules for cut/copy/paste actions in main
  window.

pmo-trunk-r3199

16 years agoAdded fixed bugs. - week 36, 4th sept.
Vivek Sekar [Tue, 4 Sep 2007 09:24:52 +0000 (09:24 +0000)]
Added fixed bugs. -  week 36, 4th sept.

pmo-trunk-r3198

16 years ago* src/maemo/ui/modest-main-window-ui.xml:
Jose Dapena Paz [Tue, 4 Sep 2007 09:04:47 +0000 (09:04 +0000)]
* src/maemo/ui/modest-main-window-ui.xml:
* Removed cut/copy/paste actions from main window menus
  (fixes NB#67792).

pmo-trunk-r3197

16 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Tue, 4 Sep 2007 09:03:02 +0000 (09:03 +0000)]
* src/widgets/modest-recpt-editor.c:
* Limited text insertion to 1024 characters. This should prevent
  getting too big input (fixes NB#64721).

pmo-trunk-r3196

16 years ago2007-09-03 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 3 Sep 2007 17:32:12 +0000 (17:32 +0000)]
2007-09-03  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.c: Don't set the temporary account
online that checks for supported authentication methods. This fixes
projects.maemo.org bug NB#61369.

pmo-trunk-r3195

16 years agoChanged an idle to a non-idle because it's not needed anymore
Philip Van Hoof [Mon, 3 Sep 2007 16:58:43 +0000 (16:58 +0000)]
Changed an idle to a non-idle because it's not needed anymore

pmo-trunk-r3194

16 years agoAPI change
Philip Van Hoof [Mon, 3 Sep 2007 15:35:05 +0000 (15:35 +0000)]
API change

pmo-trunk-r3193

16 years ago2007-09-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 3 Sep 2007 14:20:07 +0000 (14:20 +0000)]
2007-09-03  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-folder-view.c: (strings_are_equal),
(on_model_foreach_set_name), (on_get_mmc_account_name),
(text_cell_data): Restored this code that was removed in
svn revision 3165 by jfernandez, because this late name-discovery
really is necessary sometimes. This is the correct fix to the endless
calling of this function:
* src/modest-tny-account.c: (on_modest_file_system_info):
Don't call tny_account_set_name() when the name is already correct,
to avoid unnecessary (endless) updates to the tree model.

pmo-trunk-r3192

16 years ago* fix for NB#67837, NB#63633
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 13:33:42 +0000 (13:33 +0000)]
* fix for NB#67837, NB#63633
  - don't try to convert ' --> &apos; [ while technically correct,
    apparently, wpeditor does not like it
  - clean up writing of reply/forward msgs a bit. it could use more cleanup

pmo-trunk-r3191

16 years agoremoved 2 bugs to start integration. - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 13:28:31 +0000 (13:28 +0000)]
removed 2 bugs to start integration. -  week 36, 3rd sept.

pmo-trunk-r3190

16 years agoAdded new fixes to changelog - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 12:34:32 +0000 (12:34 +0000)]
Added new fixes to changelog -  week 36, 3rd sept.

pmo-trunk-r3188

16 years agoshow the correct icons for debian packages
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 11:38:55 +0000 (11:38 +0000)]
show the correct icons for debian packages

pmo-trunk-r3187

16 years ago* Review dimming rules to detect when modest is sedning mails.
Javier Fernandez Garcia-Boente [Mon, 3 Sep 2007 11:30:20 +0000 (11:30 +0000)]
* Review dimming rules to detect when modest is sedning mails.
* Use the new tinymail API function to add mails to send queue
asynchronously.
* Fixes: NB#61607, NB#61952, NB#64146, NB#64924

pmo-trunk-r3186

16 years ago* fix NB#67791
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 10:59:04 +0000 (10:59 +0000)]
* fix NB#67791

pmo-trunk-r3185

16 years ago * Fixed a leak with folders when refreshing
Sergio Villar Senin [Mon, 3 Sep 2007 09:56:30 +0000 (09:56 +0000)]
* Fixed a leak with folders when refreshing

pmo-trunk-r3184

16 years ago* show the correct icon, even for osso-notes attachments.
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 08:14:07 +0000 (08:14 +0000)]
* show the correct icon, even for osso-notes attachments.

pmo-trunk-r3183

16 years ago * Fixes NB#65015 the Outbox folder is no longer missing in the folder view when...
Sergio Villar Senin [Mon, 3 Sep 2007 07:48:30 +0000 (07:48 +0000)]
* Fixes NB#65015 the Outbox folder is no longer missing in the folder view when an account is added. It's also properly removed, when no account is defined

pmo-trunk-r3182

16 years ago* Add Shortcuts to Send, Replay and Forward actions.
Javier Fernandez Garcia-Boente [Sat, 1 Sep 2007 14:58:30 +0000 (14:58 +0000)]
* Add Shortcuts to Send, Replay and Forward actions.
* Fixes: NB#65668

pmo-trunk-r3181

16 years ago* fix the glaring security issue with the previous commit, ie,
Dirk-Jan C. Binnema [Sat, 1 Sep 2007 11:59:03 +0000 (11:59 +0000)]
* fix the glaring security issue with the previous commit, ie,
  when someone would specify a file name
  "../../etc/passwd". fixed now.

pmo-trunk-r3180

16 years ago* fix for NB#63391, where a notes-attachment would be opened in the browser instead
Dirk-Jan C. Binnema [Sat, 1 Sep 2007 11:43:50 +0000 (11:43 +0000)]
* fix for NB#63391, where a notes-attachment would be opened in the browser instead
  - code would make a temp file <random>.ext and ask the mime system to open that,
  however, it only took the *last* extension, so foo.notes.html would become
  <random>.html, and thus opened in browser
  - second, it would open with these funny random chars in the name
  - solution: we now make a temporary-directory (with random name), and save the
  attachment file there with it's real name
  - one issue remaining are attachments without a name.

* make #define hildon_foo --> osso_foo for the functions in modest-platform, so we can
  get rid of the ugly #ifdef blocks.

pmo-trunk-r3179

16 years ago* sort the folder names in the way the spec wants; this work is not complete:
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 16:08:56 +0000 (16:08 +0000)]
* sort the folder names in the way the spec wants; this work is not complete:
  - we're still missing the outbox
  - we need to take care of localization (urgh)
  - what about 'All mail folders'?

pmo-trunk-r3178

16 years ago2007-08-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 31 Aug 2007 16:02:51 +0000 (16:02 +0000)]
2007-08-31  Murray Cumming  <murrayc@murrayc.com>

* src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
boolean, because this is the specified behaviour in the UI spec.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_set_connection_specific_smtp),
(modest_account_mgr_remove_connection_specific_smtp),
(modest_account_mgr_get_connection_specific_smtp): Remove the account_name
parameter.
* src/maemo/modest-connection-specific-smtp-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_finalize),
(modest_connection_specific_smtp_window_fill_with_connections),
(modest_connection_specific_smtp_window_save_server_accounts):
Remove the account_name parameters and member variable.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_button_outgoing_smtp_servers), (create_account):
* src/maemo/modest-account-settings-dialog.c:
(on_button_outgoing_smtp_servers), (check_data),
(modest_account_settings_dialog_set_account_name),
(save_configuration):
* src/maemo/modest-maemo-utils.c: (on_account_online),
(modest_maemo_utils_get_supported_secure_authentication_methods):
* src/modest-tny-account-store.c:
(get_smtp_specific_transport_account_for_open_connection),
(insert_account), (add_connection_specific_transport_accounts):
* src/modest-ui-actions.c: (on_smtp_servers_window_hide),
(modest_ui_actions_on_smtp_servers):
 Adapt to the changed API.

pmo-trunk-r3176

16 years ago* tiny optimization for the header view: avoid one needless
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 15:08:56 +0000 (15:08 +0000)]
* tiny optimization for the header view: avoid one needless
  copy of the subject

pmo-trunk-r3174

16 years ago* only use modest_window_set_active_account with real, non-pseudo accounts.
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 14:10:13 +0000 (14:10 +0000)]
* only use modest_window_set_active_account with real, non-pseudo accounts.
  this makes send/receive/open aware of the active account in many cases,
  fixes NB#67071, and maybe some others.

Note: I think the 'active_account' could probable be tracked more easy with
  a function on modest_folder_view.

pmo-trunk-r3173

16 years ago* only allow real, non-pseudo accounts
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 14:06:54 +0000 (14:06 +0000)]
* only allow real, non-pseudo accounts

pmo-trunk-r3172

16 years agoRemoved bugs not accepted by the system.
Vivek Sekar [Fri, 31 Aug 2007 13:00:40 +0000 (13:00 +0000)]
Removed bugs not accepted by the system.

pmo-trunk-r3171

16 years agoRemoved bugs not accepted by the system.
Vivek Sekar [Fri, 31 Aug 2007 12:44:23 +0000 (12:44 +0000)]
Removed bugs not accepted by the system.

pmo-trunk-r3170

16 years agoAdded unreleased bugs from week 35 into the new week 36 pre release.
Vivek Sekar [Fri, 31 Aug 2007 12:21:19 +0000 (12:21 +0000)]
Added unreleased bugs from week 35 into the new week 36 pre release.

pmo-trunk-r3169

16 years ago * Reverts some changes of commit 3159 with is causing some annoying side effects...
Sergio Villar Senin [Fri, 31 Aug 2007 12:19:08 +0000 (12:19 +0000)]
* Reverts some changes of commit 3159 with is causing some annoying side effects, we need to find a better way to place the passive focus. The commit 3159 was placing the active focus by error

pmo-trunk-r3167

16 years ago* Show a "Pasting" banner when moving messages
Alberto Garcia [Fri, 31 Aug 2007 11:54:52 +0000 (11:54 +0000)]
* Show a "Pasting" banner when moving messages
Fixes NB#63479

pmo-trunk-r3166

16 years ago* Avoid to get MMC root folder name in text_cell_data.
Javier Fernandez Garcia-Boente [Fri, 31 Aug 2007 10:30:52 +0000 (10:30 +0000)]
* Avoid to get MMC root folder name in text_cell_data.
* Fixes: NB#65331

pmo-trunk-r3165

16 years ago* remove some annoying debug warnings
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 06:35:21 +0000 (06:35 +0000)]
* remove some annoying debug warnings
* remember the parent-uid for messages (needed to check if a reply to a message
  is already ongoing)

pmo-trunk-r3163

16 years ago* remove some needless warnings (ie. edit windows don't have to
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 06:29:55 +0000 (06:29 +0000)]
* remove some needless warnings (ie. edit windows don't have to
  warn about not having a UID)

pmo-trunk-r3162

16 years ago* New Message toolbar button and menu item will be dimmed
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 19:18:15 +0000 (19:18 +0000)]
* New Message toolbar button and menu item will be dimmed
when no accounts have been defined.
* Fixes: NB#64278

pmo-trunk-r3161

16 years ago * Fixes NB#64311 show the proper help depending on the folder that is selected in...
Sergio Villar Senin [Thu, 30 Aug 2007 18:11:56 +0000 (18:11 +0000)]
* Fixes NB#64311 show the proper help depending on the folder that is selected in the folder view

pmo-trunk-r3160

16 years agofixes NB#58917
Peter Csaszar [Thu, 30 Aug 2007 16:21:37 +0000 (16:21 +0000)]
fixes NB#58917

pmo-trunk-r3159

16 years ago* Fixed crash on dimmin rules when M;MC root account is selected.
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 13:57:12 +0000 (13:57 +0000)]
* Fixed crash on dimmin rules when M;MC root account is selected.

pmo-trunk-r3156

16 years ago* Commented out modest_folder_view_set_folder_selected because
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 12:23:06 +0000 (12:23 +0000)]
* Commented out modest_folder_view_set_folder_selected because
it caused some hangs after folder transfer was completed.

pmo-trunk-r3154

16 years ago * Moving back to the old version of has_subfolder_with_name because the new version...
Sergio Villar Senin [Thu, 30 Aug 2007 11:17:47 +0000 (11:17 +0000)]
* Moving back to the old version of has_subfolder_with_name because the new version needs some tinymail changes
* Fixed a problem when creating folders related to folder names, now it uses the has_subfolder_with_name function
* Fixes NB#62026, folder moves is fixed right now

pmo-trunk-r3153

16 years ago * Select the folder that has been moved
Sergio Villar Senin [Thu, 30 Aug 2007 10:03:21 +0000 (10:03 +0000)]
* Select the folder that has been moved

pmo-trunk-r3152

16 years ago* fix some mem leaks (50Kb after clicking around a bit, according to valgrind)
Dirk-Jan C. Binnema [Thu, 30 Aug 2007 09:57:48 +0000 (09:57 +0000)]
* fix some mem leaks (50Kb after clicking around a bit, according to valgrind)

pmo-trunk-r3151

16 years ago * added led-pattern hint to notification based on the code of the old client
Sergio Villar Senin [Thu, 30 Aug 2007 09:31:20 +0000 (09:31 +0000)]
* added led-pattern hint to notification based on the code of the old client

pmo-trunk-r3150

16 years agoModified changelog to reflect week 35, as queue is still not frozen.
Vivek Sekar [Thu, 30 Aug 2007 08:21:32 +0000 (08:21 +0000)]
Modified changelog to reflect week 35, as queue is still not frozen.

pmo-trunk-r3148

16 years agoAdded new fixes and moved the week 35-2 fixes to week 36-1 build on 30th aug.
Vivek Sekar [Thu, 30 Aug 2007 08:00:06 +0000 (08:00 +0000)]
Added new fixes and moved the week 35-2 fixes to week 36-1 build on 30th aug.

pmo-trunk-r3146

16 years ago* activate the maemo-launcher once more
Dirk-Jan C. Binnema [Thu, 30 Aug 2007 06:14:27 +0000 (06:14 +0000)]
* activate the maemo-launcher once more

pmo-trunk-r3145

16 years ago2007-08-29 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 29 Aug 2007 21:35:54 +0000 (21:35 +0000)]
2007-08-29  Armin Burgmeier  <armin@openismus.com>

* src/modest-protocol-info.h:
* src/modest-protocol-info.c: Added
modest_protocol_info_get_auth_protocol() to translate an
authentication protocol name to the corresponding enum value.

* src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
generation using the newly added function.

* src/maemo/modest-account-settings-dialog.c: Use the current element
when traversing through the list of supported authentication methods,
not always the first.

pmo-trunk-r3144

16 years ago * Improved my last commit, only invalidate cur_folder_store and folder_to_select...
Sergio Villar Senin [Wed, 29 Aug 2007 17:39:18 +0000 (17:39 +0000)]
* Improved my last commit, only invalidate cur_folder_store and folder_to_select when the account that it's being removed is the same account than the accounts of any of these folders

pmo-trunk-r3143

16 years ago * Fixed a SIGSEV when renaming folders caused by the delayed selection
Sergio Villar Senin [Wed, 29 Aug 2007 17:24:04 +0000 (17:24 +0000)]
* Fixed a SIGSEV when renaming folders caused by the delayed selection
* Implemented a TODO related to the delayed selection
* Fixed the delayed selection when renaming folders

pmo-trunk-r3142