Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:48:17 +0000 (10:48 +0000)]
* fix the fallout of the configuration changes - builds again now
pmo-trunk-r2385
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:17:13 +0000 (10:17 +0000)]
* remove some unintended changes in the last checkin
pmo-trunk-r2384
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:09:45 +0000 (10:09 +0000)]
* cleanup the configuration system a bit:
- don't have an overall 'hildon0' or 'hildon1' check, because this causes problems with sardine
- check for ogs, hildon-help, hildon-notify etc. separately
- turn on -Werr for *all* maemo builds
pmo-trunk-r2383
Dirk-Jan C. Binnema [Sat, 23 Jun 2007 09:02:13 +0000 (09:02 +0000)]
* fix bora build (there's no hildonnotification there)
pmo-trunk-r2382
Armin Burgmeier [Fri, 22 Jun 2007 20:03:30 +0000 (20:03 +0000)]
2007-06-22 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a GError parameter to
modest_maemo_utils_get_supported_secure_authentication_methods.
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Show correct error if
one occured, not just "Server does not support secure authentication".
pmo-trunk-r2381
Murray Cumming [Fri, 22 Jun 2007 16:13:17 +0000 (16:13 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Restored the call to tny_account_set_user() because Philip seems to have
stopped this from crashing (by not using the freed string). It still does
not work, but now we can test it.
pmo-trunk-r2380
Jose Dapena Paz [Fri, 22 Jun 2007 15:11:11 +0000 (15:11 +0000)]
* src/widgets/modest-msg-view.[ch]:
* Remove an attachment mime part from view.
* src/widgets/modest-msg-view-window.[ch]:
* Implemented dialog for removing attachments, but dropped
any remove attachment implementation until we know how to
remove attachments only from cache.
pmo-trunk-r2379
Murray Cumming [Fri, 22 Jun 2007 14:09:23 +0000 (14:09 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-edit-window.c: (init_window):
Comment out use of an uninitialzed GtkScrolledWindow variable,
to fix the build and stop a crash. Yet again.
pmo-trunk-r2378
Jose Dapena Paz [Fri, 22 Jun 2007 12:15:57 +0000 (12:15 +0000)]
* src/modest-ui-actions.c:
* Now saving to drafts shows a proper information
banner (fixes NB#59333).
pmo-trunk-r2377
Jose Dapena Paz [Fri, 22 Jun 2007 12:07:28 +0000 (12:07 +0000)]
* src/widgets/modest-folder-view.c:
* Now local folder is bolded too (fixes NB#59314).
pmo-trunk-r2376
Jose Dapena Paz [Fri, 22 Jun 2007 11:53:46 +0000 (11:53 +0000)]
* src/modest-text-utils.[ch]:
* Added new method modest_text_utils_get_color_string, that
obtains a color string proper for inserting in pango markup
or html from a GdkColor.
* src/maemo/modest-main-window.c:
* Now the folder details view puts secondary text color on field
names (fixes NB#59310).
pmo-trunk-r2375
Murray Cumming [Fri, 22 Jun 2007 11:20:51 +0000 (11:20 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Remove the call to tny_account_set_user() because this actually crashes.
As mentioned in the last commit, it is known to not work anyway.
pmo-trunk-r2374
Jose Dapena Paz [Fri, 22 Jun 2007 10:26:15 +0000 (10:26 +0000)]
* src/maemo/modest-address-book.c:
* Removed call to osso_abook_select_dialog_set_new_contact
as this has been removed from new osso abook API.
* src/maemo/modest-msg-edit-window.c:
* Now inserted images size are limited to a width of 640
on insertion to buffer, to avoid requiring horizontal
scroll.
* Now images are also obtained using Gnome VFS. This way we can
obtain remote images.
* Now we accept selecting multiple image files to insert
(fixes NB#59820).
* Now we open the insert image filechooser dialog in the
images special folder.
* src/maemo/modest-maemo-utils.[ch]:
* New modest_maemo_utils_setup_images_filechooser method,
that sets up a filechooser for saving or browsing images.
Sets the filter to images mimetype category, and the
default folder to the images one.
pmo-trunk-r2373
Murray Cumming [Fri, 22 Jun 2007 09:57:08 +0000 (09:57 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Use tny_account_set_username() to tell tinymail that the username might
have changed too. But tinymail ignores this: see projects.maemo.org
bug #61463.
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested): Remove the useless attempt to
reset the connection when changing the username, and improve the comments.
Save the changed username to gconf at least, so it is used when Modest is
restarted.
pmo-trunk-r2372
Murray Cumming [Thu, 21 Jun 2007 17:44:44 +0000 (17:44 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
Do not use a query, so that we get all folders, including for POP and
local-folders. They work as search criteria too.
This fixes projects.maemo.org bug NB#57740.
pmo-trunk-r2371
Jose Dapena Paz [Thu, 21 Jun 2007 17:23:33 +0000 (17:23 +0000)]
* src/widgets/modest-msg-edit-window.h:
* Added zoom actions for 80% and 120%.
* src/maemo/modest-msg-edit-window.c:
* Now zoom menu is updated properly on inherited zooms
(fixes NB#61337).
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added 80% and 120% menu levels actions.
pmo-trunk-r2370
Murray Cumming [Thu, 21 Jun 2007 17:20:51 +0000 (17:20 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_on_new_msg):
Comment out the use of hildon_notification_set_sound() because it is
not declared, to fix the build. Warnings are serious, people.
pmo-trunk-r2368
Jose Dapena Paz [Thu, 21 Jun 2007 16:55:08 +0000 (16:55 +0000)]
Refactoring work to make new folder and rename folder share
the same implementation (fixes NB#58817).
* src/modest-platform.h:
* New rename_folder_dialog method.
* src/modest-ui-actions.c:
* Now rename uses a dialog in modest platform, sharing the
implementation with new folder dialog. Also removed old
dialog implementation.
* src/maemo/modest-platform.c:
* New method rename_folder_dialog, and refactored
new_folder_dialog, creating name_folder_dialog
that implements the same logic and controls for
both UI actions.
pmo-trunk-r2367
Jose Dapena Paz [Thu, 21 Jun 2007 16:11:41 +0000 (16:11 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now, if you're not focusing the body editor, zoom is not
allowed from menu nor hardware keys (fixes NB#58800).
* Fixed translation strings for zoom information banners.
Now they use the hildon-common-strings domain strings.
* src/maemo/modest-msg-view-window.c:
* Fix translation strings for zoom information banners.
* src/maemo/modest-main-window.c:
* Add unable to zoom information banner in main window.
* src/maemo/modest-main-window-ui.xml:
* Added zoom hardware key actions.
pmo-trunk-r2366
Armin Burgmeier [Thu, 21 Jun 2007 15:48:43 +0000 (15:48 +0000)]
2007-06-21 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a username parameter to the
modest_maemo_utils_get_supported_secure_authentication_methods()
to query authentication methods for a specific user. This should fix
projects.maemo.org bug NB#61369.
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
function.
pmo-trunk-r2365
Sergio Villar Senin [Thu, 21 Jun 2007 15:09:15 +0000 (15:09 +0000)]
* Added a callback to the update_account operation that notifies about the new messages received
* Fixed the Empty view problem
* Removed the new message notification from the header view
pmo-trunk-r2364
Jose Dapena Paz [Thu, 21 Jun 2007 14:17:53 +0000 (14:17 +0000)]
* src/maemo/modest-folder-view.c:
* Now it sorts local folders in a different way. It puts
first the special folders outbox, drafts and sent, and then
all the user created folders (fixes NB#60361).
pmo-trunk-r2363
Javier Fernandez Garcia-Boente [Thu, 21 Jun 2007 13:46:27 +0000 (13:46 +0000)]
* Fix bug about how set_flags function was being used.
* Fixes: NB#59193
pmo-trunk-r2362
Murray Cumming [Thu, 21 Jun 2007 13:28:14 +0000 (13:28 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* ossoemailinterface.c: (osso_email_get_folder_list):
Implement this with the new libmodest_dbus_client_get_folders()
function. This should help with projects.maemo.org bug NB#57740.
pmo-trunk-r2361
Murray Cumming [Thu, 21 Jun 2007 12:46:58 +0000 (12:46 +0000)]
Removed junk.
pmo-trunk-r2360
Murray Cumming [Thu, 21 Jun 2007 12:42:31 +0000 (12:42 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.h:
* libmodest-dbus-client/libmodest-dbus-client.c:
(modest_dbus_message_iter_get_search_hit),
(libmodest_dbus_client_search):
Reorganised and commented this.
Removed modest_search_hit_free() from the public API because it
is not needed.
Added libmodest_dbus_client_get_folders() and
modest_folder_result_list_free().
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
(modest_dbus_req_filter): Commented. Moved most code to
on_dbus_method_search() and added on_dbus_method_get_folders().
* src/maemo/modest-platform.c: (modest_platform_init): Commented the use
of the extra D-Bus handler.
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_get_folders.c: New test for
libmodest_dbus_client_get_folders(). This seems to return an empty list
at the moment. That could be the same error that causes the message list
to be empty sometimes.
This should help with projects.maemo.org bug NB#57740.
pmo-trunk-r2358
Dirk-Jan C. Binnema [Thu, 21 Jun 2007 12:17:17 +0000 (12:17 +0000)]
* update
pmo-trunk-r2357
Armin Burgmeier [Thu, 21 Jun 2007 11:47:07 +0000 (11:47 +0000)]
2007-06-21 Armin Burgmeier <armin@openismus.com>
* src/modest-mail-operation.c: Do not call
modest_mail_operation_queue_cancel_all() in _cancel() but do instead
notify the operation's end after having set the status to CANCELED for
the operation queue to listen on. This fixes a deadlock when there
were mail operations in the queue during its finalization.
* src/modest-singletons.c: Reordered uninitialization of the account
manager to happen after the mail operation queue was uninitialized
because the mail operation's in the queue might still try to access
the account manager (see modest_mail_operation_notify_end()). This
fixes a potential crash when terminating the application.
pmo-trunk-r2354
Jose Dapena Paz [Thu, 21 Jun 2007 10:53:43 +0000 (10:53 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now "Select all" is dimmed when focus is on an area without anything
to select (for example, an empty body) (fixes NB#59393).
* Minor API fix on usage of priority flags.
pmo-trunk-r2353
Murray Cumming [Thu, 21 Jun 2007 10:14:44 +0000 (10:14 +0000)]
removed junk
pmo-trunk-r2352
Murray Cumming [Thu, 21 Jun 2007 10:13:42 +0000 (10:13 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c:
(search_mime_part_and_child_parts): Moved some code here so we
can search recursively in child folders.
(modest_search_folder): Search in the message as a mime part, instead
of just its child mime parts.
(read_chunk), (search_mime_part_ogs):
Check how many bytes were read, to prevent an endless loop.
Searching in message bodies now works. This finishes the fix for
projects.maemo.org bug NB#61007.
pmo-trunk-r2351
Jose Dapena Paz [Thu, 21 Jun 2007 09:35:23 +0000 (09:35 +0000)]
* src/modest-platform.h:
* Added a new platform function for showing information banner. Should
remove a new dependency in common non specific maemo code.
* src/modest-dimming-rules-group.c:
* Now it does not use hildon information banner, but the new platform
equivalent.
* src/modest-ui-actions.c:
* Now it shows an information banner on copying the messages to outbox
(fixes NB#59332).
* src/maemo/modest-platform.c:
* Added implementation of the new information banner platform function,
that uses the hildon information banner.
pmo-trunk-r2350
Javier Fernandez Garcia-Boente [Thu, 21 Jun 2007 08:45:19 +0000 (08:45 +0000)]
* Add some utility funcitons to email clipboard to check
if changes made on any folder must force to clear clipboard
data.
* Add new dimming rules for paste messages operation.
* Fixes: NB#59395
pmo-trunk-r2349
Jose Dapena Paz [Thu, 21 Jun 2007 08:37:11 +0000 (08:37 +0000)]
* src/modest-init.c:
* Now sort values are initialized to useful default values
(fixes NB#59321).
pmo-trunk-r2348
Jose Dapena Paz [Wed, 20 Jun 2007 17:39:01 +0000 (17:39 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
* Removed delete message action, as it's not in new UI specs
(fixes NB#59245).
pmo-trunk-r2347
Jose Dapena Paz [Wed, 20 Jun 2007 17:34:00 +0000 (17:34 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
* Removed delete message action, as it's not in new UI specs
(fixes NB#59245).
pmo-trunk-r2346
Jose Dapena Paz [Wed, 20 Jun 2007 17:26:29 +0000 (17:26 +0000)]
* src/maemo/modest-main-window.c:
* Now "send & receive/all" is hidden when there's only one
account available (fixes NB#59238).
pmo-trunk-r2345
Jose Dapena Paz [Wed, 20 Jun 2007 16:49:04 +0000 (16:49 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now it dims remove attachments action when there's no
attachment selected, and when there are more than one.
Also added insensitive press messages for both
(fixes NB#59176).
pmo-trunk-r2344
Jose Dapena Paz [Wed, 20 Jun 2007 16:25:05 +0000 (16:25 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now it dims properly the Paste menu option (fixes NB#58809).
pmo-trunk-r2343
Murray Cumming [Wed, 20 Jun 2007 15:47:22 +0000 (15:47 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_details):
Add a g_warning when the item is not a folder.
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
when selected item is not a folder (for instance, an account), because
the UI spec only talks about folders.
I am not sure what the UI spec wants, so this might not totally fix
projects.maemo.org bug NB#60794.
pmo-trunk-r2342
Jose Dapena Paz [Wed, 20 Jun 2007 15:42:31 +0000 (15:42 +0000)]
* src/widgets/modest-header-view.c:
* Fix sort by priority, as it wasn't comparing the
fields values properly.
* src/maemo/modest-platform.c:
* Fix recovering the sort status from header view to
create the sort dialog.
* Save the new widget status on finishing the sort
(fixes NB#58628).
* src/modest-widget-memory.c:
* Fix the recovering of sort status from header view.
pmo-trunk-r2341
Murray Cumming [Wed, 20 Jun 2007 15:03:06 +0000 (15:03 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
(load_from_file): Sort the list. The unsorted list would be more noticeable
in non-English locales.
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file): Initialize a variable to avoid a
warning and fix the build.
* src/maemo/modest-progress-bar-widget.c:
(modest_progress_bar_widget_set_progress): Avoid a division by zero, to
avoid a g_warning, and probably to avoid a crash.
pmo-trunk-r2340
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 14:40:02 +0000 (14:40 +0000)]
Add some notifications to dimmed rules.
pmo-trunk-r2339
Murray Cumming [Wed, 20 Jun 2007 14:25:17 +0000 (14:25 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/modest-search.c: (modest_search_folder): Check for a GError
when calling tny_folder_get_headers(), to show that this is not the cause
of later failure.
pmo-trunk-r2338
Murray Cumming [Wed, 20 Jun 2007 14:11:31 +0000 (14:11 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
Actually set the body query instead of the subject query.
* src/modest-search.c: (search_mime_part_ogs),
(search_mime_part_strcmp): Remove extra space from the text/* regex,
which would probably cause it to fail if we got this far.
(modest_search_folder): Use simple #ifdefs instead of the function pointer,
to simplify the code.
Warn when tny_mime_part_get_parts() returns an empty list, which seems to
be causing search-in-body to fail.
pmo-trunk-r2337
Jose Dapena Paz [Wed, 20 Jun 2007 14:02:17 +0000 (14:02 +0000)]
* src/maemo/modest-address-book.c:
* Minor change to avoid problems with addressbook init.
* src/maemo/modest-msg-edit-window.c:
* Support attaching more than one file at a time
(fixes NB#58614).
* src/maemo/modest-msg-view-window.c:
* Add an information banner for trying to search an empty
string.
pmo-trunk-r2336
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 13:51:37 +0000 (13:51 +0000)]
* Increase performance of dimming rules manager, avoiding call
get_selected_headers to check if no headers were selected to
perform operation.
pmo-trunk-r2335
Sergio Villar Senin [Wed, 20 Jun 2007 13:36:05 +0000 (13:36 +0000)]
* Added ending notification to the send_mail operation
* Fixed a problem with armin's modest_tny_send_queue code, it was causing a crash due to a g_assert
pmo-trunk-r2334
Jose Dapena Paz [Wed, 20 Jun 2007 13:28:26 +0000 (13:28 +0000)]
* src/widget/modest-attachments-view.c:
* Crashed when there was an attached message with
a NULL subject. Fixed (fixes NB#61283).
pmo-trunk-r2333
Philip Van Hoof [Wed, 20 Jun 2007 13:19:54 +0000 (13:19 +0000)]
Added listening on an extra signal
pmo-trunk-r2332
Sergio Villar Senin [Wed, 20 Jun 2007 11:57:49 +0000 (11:57 +0000)]
* Added progress information to open single message operation
* Added byte information to the ModestMailOperationStatus struct
pmo-trunk-r2331
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 11:48:47 +0000 (11:48 +0000)]
* Fixed problem with focus and move_to operation.
pmo-trunk-r2330
Murray Cumming [Wed, 20 Jun 2007 10:10:19 +0000 (10:10 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
struct item.
* src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
Better debug message when the folder cannot be found.
This should help with fixing projects.maemo.org bug #61287.
* src/modest-search.c: (add_hit): Do not leak the furl string.
pmo-trunk-r2329
Sergio Villar Senin [Wed, 20 Jun 2007 09:45:50 +0000 (09:45 +0000)]
* Fixed a lot of reference leaks
* Fixed a problem when closing the main window
pmo-trunk-r2328
Dirk-Jan C. Binnema [Wed, 20 Jun 2007 09:12:19 +0000 (09:12 +0000)]
* don't make in the po/ directory
* add libogs1.2-dev as a dep for debian packaging (maemo1)
pmo-trunk-r2327
Murray Cumming [Wed, 20 Jun 2007 08:53:06 +0000 (08:53 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/modest-ui-actions.c:
(modest_ui_actions_on_folder_selection_changed):
Do not special-case TNY_MERGE_FOLDER here, because
modest_tny_folder_get_account() already does that. This fixes
projects.maemo.org bug NB#60955 (The smtp connections dialog was not
shown when the Outbox was selected).
pmo-trunk-r2326
Dirk-Jan C. Binnema [Wed, 20 Jun 2007 08:50:22 +0000 (08:50 +0000)]
* set the folder name in instead of the folder-url for the search results
pmo-trunk-r2325
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 07:52:49 +0000 (07:52 +0000)]
Fixes: NB#61019
pmo-trunk-r2323
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 07:12:04 +0000 (07:12 +0000)]
* Fixes: NB#59203
pmo-trunk-r2322
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 06:47:03 +0000 (06:47 +0000)]
* Changes in the localization structure. GETTEXT package is
configure in configure.ac, checking version of application
in order to use trnaslation packages or .po files.
* Avoid using GTK_WIDGET_HAS_FOCUS to check if some widget has
the focus, because we need to check window local focus, rather
than global focus.
pmo-trunk-r2321
Murray Cumming [Tue, 19 Jun 2007 17:16:26 +0000 (17:16 +0000)]
2007-06-19 Murray Cumming,,, <murrayc@murrayc-desktop>
* libmodest-dbus-client/libmodest-dbus-client.c:
(_dbus_iter_get_string_or_null): Initialize the string variable in
case this helps with Dirk's crash.
2007-06-19 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
though it is not implemented yet (this function is maybe not even used),
to avoid breaking ABI in future.
* libmodest-dbus-client/libmodest-dbus-client.c:
(get_attachments_string): Moved some code into this generic function.
(libmodest_dbus_client_send_mail): Corrected the documentation. This really
sends email. It is maybe not used.
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
(on_send_mail): Use attachments.
* src/widgets/modest-msg-edit-window.h: Improve the documentation.
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
a filename before using it, to fix projects.maemo.org bug NB#58233.
pmo-trunk-r2319
Jose Dapena Paz [Tue, 19 Jun 2007 16:36:53 +0000 (16:36 +0000)]
Fix for some issues in translation of plural strings (fixes NB#61146).
* src/modest-ui-actions.c:
* src/modest-msg-edit-window.c:
* Changed translations of plurals to use ngettext.
pmo-trunk-r2318
Jose Dapena Paz [Tue, 19 Jun 2007 15:20:50 +0000 (15:20 +0000)]
* src/maemo/modest-platform.c:
* (modest_platform_show_uri_popup): now it uses the translation
domain of the actions (fixes NB#61049).
pmo-trunk-r2316
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 15:20:13 +0000 (15:20 +0000)]
Updated the changelog with the fixes made on 2007.06.19.
pmo-trunk-r2314
Jose Dapena Paz [Tue, 19 Jun 2007 14:58:06 +0000 (14:58 +0000)]
Work to fix priority recovering from messages (fixes NB#58045).
* src/maemo/modest-msg-edit-window.c:
* Now it gets the priority flags from the message it's
constructed from.
* Updates the priority in menus with the initial values.
Other changes
* src/maemo/modest-msg-edit-window.c:
* Minor translation fix.
pmo-trunk-r2313
Sergio Villar Senin [Tue, 19 Jun 2007 14:13:09 +0000 (14:13 +0000)]
* Allow incremental filling of the headers view while refreshing the folder
pmo-trunk-r2312
Murray Cumming [Tue, 19 Jun 2007 13:53:16 +0000 (13:53 +0000)]
slightly improved debug messages
pmo-trunk-r2311
Murray Cumming [Tue, 19 Jun 2007 13:10:55 +0000 (13:10 +0000)]
Improved debug message
pmo-trunk-r2310
Sergio Villar Senin [Tue, 19 Jun 2007 11:50:54 +0000 (11:50 +0000)]
* Fixed a memory corruption problem while initializing threads
* Added a poke_status call whenever we update an account with the send&receive button
pmo-trunk-r2309
Philip Van Hoof [Tue, 19 Jun 2007 11:31:46 +0000 (11:31 +0000)]
First-time quickfix
pmo-trunk-r2308
Murray Cumming [Tue, 19 Jun 2007 11:06:41 +0000 (11:06 +0000)]
2007-06-19 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_copy):
Initialize the continue_download variable to fix the build, and probably
to fix randome behaviour.
pmo-trunk-r2307
Sergio Villar Senin [Tue, 19 Jun 2007 09:52:35 +0000 (09:52 +0000)]
* Fixes NB#60735, ask for confirmation when copying mails from a POP account
pmo-trunk-r2306
Sergio Villar Senin [Tue, 19 Jun 2007 08:56:46 +0000 (08:56 +0000)]
* Fixes NB#57632, the delete option is dimmed for folders
pmo-trunk-r2305
Jose Dapena Paz [Tue, 19 Jun 2007 08:25:35 +0000 (08:25 +0000)]
Fix dimming rules for add to contacts action (fixes NB#59174).
* src/modest-ui-dimming-rules.[ch]:
* Added dimming rule for add to contacts.
* src/maemo/modest-msg-view-window.c:
* Added new dimming rule for add to contacts action.
pmo-trunk-r2304
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 08:16:56 +0000 (08:16 +0000)]
* leak fixes; free both list and its elements when we call modest_account_mgr_account_names
* use the new function modest_account_mgr_free_account_names
* some other smaller leak fixes
pmo-trunk-r2303
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 07:47:50 +0000 (07:47 +0000)]
* temporary crash fix for modest-tny-send-queue
pmo-trunk-r2302
Philip Van Hoof [Tue, 19 Jun 2007 07:44:42 +0000 (07:44 +0000)]
Small bugfix
pmo-trunk-r2301
Philip Van Hoof [Tue, 19 Jun 2007 07:43:02 +0000 (07:43 +0000)]
Question and small bugfix
pmo-trunk-r2300
Jose Dapena Paz [Tue, 19 Jun 2007 07:37:44 +0000 (07:37 +0000)]
* src/maemo/modest-msg-view-window.c:
* Modified to use the save objects dialog (fixes NB#59057).
pmo-trunk-r2299
Philip Van Hoof [Tue, 19 Jun 2007 07:34:18 +0000 (07:34 +0000)]
Error handling for the send queues
pmo-trunk-r2298
Sergio Villar Senin [Tue, 19 Jun 2007 06:47:22 +0000 (06:47 +0000)]
* Fixed several reference count leaks in the dimming rules
* Fixed several reference count leaks in the folder view
* Added a dispose method to the header view to prevent cycles when unrefs
* Commented some debug code
* Removed an initialization that could cause the blank right paned issue
pmo-trunk-r2297
Armin Burgmeier [Mon, 18 Jun 2007 20:52:22 +0000 (20:52 +0000)]
2007-06-18 Armin Burgmeier <armin@openismus.com>
* src/modest-tny-send-queue.h:
* src/modest-tny-send-queue.c: Keep track of the status of messages in
the queue so we can later show it in the UI. Replaced
modest_tny_send_queue_msg_is_being_sent() by
modest_tny_send_queue_get_msg_status().
* src/modest-ui-dimming-rules.c: Adjust for the replaced function.
* src/modest-tny-account.c: Changed a cast to gpointer* to one to
gpointer. This probably was not harmful, but just to be sure.
pmo-trunk-r2296
Jose Dapena Paz [Mon, 18 Jun 2007 16:13:14 +0000 (16:13 +0000)]
Work to fix recovering sort status in headers view (fixes NB#58250).
* src/maemo/modest-platform.c:
* Now it retrieves the current header view sort column,
sort type, and in case of sorting flags, the flag we sort.
This way, the dialog is prefilled with the current header
view status.
* src/modest-widget-memory-priv.h:
* Added the new kind of key "column-sort", that specified the
model column used to sort in header view.
* src/modest-widget-memory.c:
* Now save_settings_header_view and restore_settings_header_view
store a global sort value. This is required for recovering the
sort status in the compact view.
Other fixes:
* src/modest-ui-dimming-rules.c:
* Condition for one or more attachments was wrong.
pmo-trunk-r2292
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 15:25:42 +0000 (15:25 +0000)]
* Fixed several logical id transations.
* Fixes: NB#60765, NB#60768, NB#60770, NB#60771, NB#60774, NB#60774
* Fixes: NB#60775, NB#60776, NB#60777, NB#60954, NB#60952, NB#60953
* Fixes: NB#60964, NB#60968
pmo-trunk-r2289
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 15:24:48 +0000 (15:24 +0000)]
* hopefully, this restores the bora-build
pmo-trunk-r2288
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 14:53:59 +0000 (14:53 +0000)]
updated the changelog, removed all the old bugs from the list
pmo-trunk-r2287
Murray Cumming [Mon, 18 Jun 2007 14:41:16 +0000 (14:41 +0000)]
2007-06-18 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_activate_uri):
Fix the build, but leave the function broken on Bora, because
hildon_uri_action_get_service() does not exist.
osso_uri_action_get_service() does not exist either, it seems.
pmo-trunk-r2286
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:53:28 +0000 (13:53 +0000)]
updated the changelog, removed some released bugs from the list
pmo-trunk-r2285
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:52:50 +0000 (13:52 +0000)]
updated the changelog, removed some released bugs from the list
pmo-trunk-r2284
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 13:36:53 +0000 (13:36 +0000)]
Fixed som compilation errors.
pmo-trunk-r2283
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:21:47 +0000 (13:21 +0000)]
* fix logical id, NB#60950
pmo-trunk-r2282
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 13:13:55 +0000 (13:13 +0000)]
* Add a new singleton to be used as headers clipboard
on copy, cut and paste operaitons.
* Implement copy, cut and paste operations for both, headers
and folders view.
* Fixes: NB##58174
pmo-trunk-r2280
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 12:32:32 +0000 (12:32 +0000)]
* fix the uri activation, bug NB#58220
pmo-trunk-r2278
Jose Dapena Paz [Mon, 18 Jun 2007 11:56:21 +0000 (11:56 +0000)]
* src/modest-msg-edit-window.c:
* Added autocap for subject field (fixes NB#57932).
pmo-trunk-r2277
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 11:50:42 +0000 (11:50 +0000)]
* some more crash-avoiding
pmo-trunk-r2276
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 11:41:40 +0000 (11:41 +0000)]
* check some parameters (give BUG: warnings instead of crashing)
pmo-trunk-r2275
Jose Dapena Paz [Mon, 18 Jun 2007 11:15:00 +0000 (11:15 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added menu action for find in page (fixes NB#57201).
pmo-trunk-r2274
Jose Dapena Paz [Mon, 18 Jun 2007 10:44:32 +0000 (10:44 +0000)]
* src/widgets/modest-window-mgr.c:
* Now it does not crash if we cannot get an uid from one of the
windows (should happen at least with main window, but also
with editors) (fixes NB#60430).
pmo-trunk-r2273
Jose Dapena Paz [Mon, 18 Jun 2007 10:12:11 +0000 (10:12 +0000)]
Work to fix bugs getting the From: field in the editor for new messages
and messages opened in drafts folder (fixes NB#58214, NB#58219):
* src/modest-ui-actions.c:
* Now "New message" and "open message from drafts" fill the from
field in the editor with the default account instead of the
current folder active account.
* src/maemo/modest-msg-edit-window.c:
* Fills the From: field with the account name passed in the
constructor.
pmo-trunk-r2272
Murray Cumming [Mon, 18 Jun 2007 10:10:59 +0000 (10:10 +0000)]
2007-06-18 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Uncommented the url debug output again, because it is useful for
debugging, as I said in the comment.
pmo-trunk-r2271