Peter Csaszar [Wed, 29 Aug 2007 15:09:11 +0000 (15:09 +0000)]
fixes NB#66495
pmo-trunk-r3133
Alberto Garcia [Wed, 29 Aug 2007 15:05:05 +0000 (15:05 +0000)]
* src/modest-ui-actions.c
(modest_ui_actions_on_rename_folder):
Don't try to connect before showing the rename dialog
pmo-trunk-r3132
Sergio Villar Senin [Wed, 29 Aug 2007 14:27:32 +0000 (14:27 +0000)]
* Renamed on_paste_msg by on_paste
pmo-trunk-r3131
Alberto Garcia [Wed, 29 Aug 2007 14:12:33 +0000 (14:12 +0000)]
* src/modest-platform.h
* src/modest-platform.c
(modest_platform_is_network_folderstore):
Checks whether a folder store is remote
* src/modest-ui-actions.c
(modest_ui_actions_on_move_to):
Don't try to connect to the internet, leave that for the following
functions.
(modest_ui_actions_on_main_window_move_to):
(modest_ui_actions_on_msg_view_window_move_to):
Ask for confirmation if the device is offline and the source folder
is remote
pmo-trunk-r3130
Peter Csaszar [Wed, 29 Aug 2007 14:12:01 +0000 (14:12 +0000)]
tries to solve NB#66463, I am not sure if this is enough
pmo-trunk-r3129
Dirk-Jan C. Binnema [Wed, 29 Aug 2007 13:49:27 +0000 (13:49 +0000)]
* fix a mem leak
pmo-trunk-r3128
Dirk-Jan C. Binnema [Wed, 29 Aug 2007 13:34:01 +0000 (13:34 +0000)]
* remove annoying g_debug
pmo-trunk-r3127
Peter Csaszar [Wed, 29 Aug 2007 11:08:14 +0000 (11:08 +0000)]
fixes NB#66461
pmo-trunk-r3124
Sergio Villar Senin [Wed, 29 Aug 2007 10:24:18 +0000 (10:24 +0000)]
* Fixes NB#66968, there is no limit on the number of sub-folders that the user can have
pmo-trunk-r3123
Murray Cumming [Wed, 29 Aug 2007 10:08:04 +0000 (10:08 +0000)]
2007-08-29 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: (modest_search_all_accounts):
* src/modest-platform.h:
* src/maemo/modest-platform.c: Moved and renamed
check_and_wait_for_account_is_online() to
modest_platform_check_and_wait_for_account_is_online() so it
can be used in more places.
pmo-trunk-r3122
Sergio Villar Senin [Wed, 29 Aug 2007 09:59:55 +0000 (09:59 +0000)]
* Fixes NB#67061, do not ask the user to download the msg if we're online
pmo-trunk-r3121
Sergio Villar Senin [Wed, 29 Aug 2007 09:35:15 +0000 (09:35 +0000)]
* Partially fixes NB#67060, now this bug is reassigned to the language component
pmo-trunk-r3120
Murray Cumming [Wed, 29 Aug 2007 09:29:49 +0000 (09:29 +0000)]
2007-08-29 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
Removed the sleep(1) experiment because it does not seem to help,
and I should not have checked the experiment in anyway.
The problem is maybe in the TnyAccount connected state - I will
investigate that instead.
pmo-trunk-r3119
Peter Csaszar [Wed, 29 Aug 2007 09:18:07 +0000 (09:18 +0000)]
fixes NB#64231
pmo-trunk-r3118
Peter Csaszar [Wed, 29 Aug 2007 06:22:56 +0000 (06:22 +0000)]
some modification that helps solving NB#66762
pmo-trunk-r3117
Sergio Villar Senin [Tue, 28 Aug 2007 18:43:18 +0000 (18:43 +0000)]
* Fixed the signature of the "folder-selection-changed" signal
* Fixes NB#66937
* Fixes NB#62966
pmo-trunk-r3116
Peter Csaszar [Tue, 28 Aug 2007 17:08:30 +0000 (17:08 +0000)]
should fix NB#65097 and NB#63178
pmo-trunk-r3115
Javier Fernandez Garcia-Boente [Tue, 28 Aug 2007 16:46:16 +0000 (16:46 +0000)]
* Define a new mail-operation to remove several messages.
* Sync folder after send mail from Draft folder, to actually remove it.
* Sync folder after remove message from outbox, after they were sent.
* Changes on header-view-render to get send-queus of all defined accounts
if they were not in send-queue cache.
* Define a new status for header-view to determine if all messages in
the current selected folder are marked as deleted.
* Allow to enable and disable dimming rules. This feature could
improve performance in operations which require that a lot of headers
were selected.
* Fixes: NB#64359, NB#64321, NB#61954, NB#63011
pmo-trunk-r3114
Murray Cumming [Tue, 28 Aug 2007 14:55:13 +0000 (14:55 +0000)]
2007-08-28 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
Added a sleep(1) in case it helps with bug #66769.
pmo-trunk-r3113
Vivek Sekar [Tue, 28 Aug 2007 13:48:48 +0000 (13:48 +0000)]
Added new fixes. week 35-28 aug.
pmo-trunk-r3111
Alberto Garcia [Tue, 28 Aug 2007 13:12:07 +0000 (13:12 +0000)]
* src/widgets/modest-msg-edit-window-ui.h
Added shortcut for "Save as draft" (Ctrl+S)
pmo-trunk-r3110
Murray Cumming [Tue, 28 Aug 2007 12:50:44 +0000 (12:50 +0000)]
2007-08-28 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: (on_timeout_check_account_is_online),
(check_and_wait_for_account_is_online):
It is OK for local-folder and mmc accounts to be used when they
are in the _INIT folder, instead of waiting for them to change
(they never do).
For POP and IMAP, wait from them to stop being _INIT, rather than
waiting from them to be _CONNECTED, because that seems to be
the status that causes the problems.
pmo-trunk-r3109
Murray Cumming [Tue, 28 Aug 2007 11:37:08 +0000 (11:37 +0000)]
2007-08-28 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: (check_and_wait_for_account_is_online):
Actually pass the account to the timeout callback.
pmo-trunk-r3107
Peter Csaszar [Tue, 28 Aug 2007 11:28:30 +0000 (11:28 +0000)]
optimized dimming rule for select all
pmo-trunk-r3106
Alberto Garcia [Tue, 28 Aug 2007 10:01:32 +0000 (10:01 +0000)]
* src/widgets/modest-msg-edit-window-ui.h
Defined new keyboard shortcuts:
Ctrl+Return: send message
Ctrl+Z: undo
Ctrl+X: cut
Ctrl+C: copy
Ctrl+V: paste
Ctrl+W: close window
Ctrl+Q: close application
Ctrl+E: search e-mails
Ctrl+F: find in page
Fixes NB#63393
pmo-trunk-r3104
Murray Cumming [Tue, 28 Aug 2007 09:42:00 +0000 (09:42 +0000)]
2007-08-28 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: (on_timeout_check_account_is_online):
Added some debug output to help me debug a problem on the N800.
(check_and_wait_for_account_is_online): Fail immediately if the
device is offline.
modest_search_all_accounts(): Try the search even if the account does
not seem to be online, because this can work sometimes, and should work
with the cache if there is no active libconic connection.
pmo-trunk-r3103
Sergio Villar Senin [Tue, 28 Aug 2007 08:37:56 +0000 (08:37 +0000)]
* Partially fixes NB#63588, it works but we still need to find a proper solution for detecting duplicates in local folders
* Fixes NB#66839, delete folders in cascade no longer crashes the application
pmo-trunk-r3102
Dirk-Jan C. Binnema [Tue, 28 Aug 2007 06:51:52 +0000 (06:51 +0000)]
* fix some leaks, turn an assert into a runtime warning
pmo-trunk-r3101
Dirk-Jan C. Binnema [Tue, 28 Aug 2007 06:25:27 +0000 (06:25 +0000)]
* check whether folder_view actually exists before calling it;
this fixes some GLib-Criticals.
pmo-trunk-r3100
Armin Burgmeier [Mon, 27 Aug 2007 14:32:18 +0000 (14:32 +0000)]
Reverted my previous changes, this will be fixed in another way.
pmo-trunk-r3097
Alberto Garcia [Mon, 27 Aug 2007 13:48:47 +0000 (13:48 +0000)]
* src/maemo/modest-msg-view-window.c
(save_mime_parts_to_file_with_checks):
Check whether there are one or many files about to be overwritten
and show a different confirmation message in each case
(idle_save_mime_part_show_result):
If there are still unsaved files then save them directly without
asking. The user should only be asked once.
Fixes NB#66450
pmo-trunk-r3094
Armin Burgmeier [Mon, 27 Aug 2007 13:40:24 +0000 (13:40 +0000)]
2007-08-27 Armin Burgmeier <armin@openismus.com>
* src/modest-tny-send-queue.c: Implement TnyFolderObserver and
observe outbox for added messages to assign them a status. Previously,
this was done in modest_tny_send_queue_add(), but the message id might
not yet be known at that point. This reduces warnings when sending
mail, though I am not sure how this even worked before.
pmo-trunk-r3093
Murray Cumming [Mon, 27 Aug 2007 12:38:29 +0000 (12:38 +0000)]
2007-08-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_init):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init):
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_get_supported_secure_authentication_methods):
* src/maemo/modest-platform.c:
(modest_platform_run_folder_name_dialog):
* src/maemo/modest-signature-editor-dialog.c:
(modest_signature_editor_dialog_init):
* src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
(modest_ui_actions_on_password_requested), (create_move_to_dialog):
* src/widgets/modest-global-settings-dialog.c:
(modest_global_settings_dialog_init):
Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
mcen_bd_dialog_ok,
GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
GTK_STOCK_EDIT with mcen_bd_edit, and
GTK_STOCK_CLOSE with mcen_bd_close,
to fix projects.maemo.org bug NB#64995.
I strongly believe that Maemo's GTK+ should have the wanted translations
instead of duplicating this in each application and complicating the code.
pmo-trunk-r3092
Peter Csaszar [Mon, 27 Aug 2007 12:18:54 +0000 (12:18 +0000)]
fixes NB#64181
pmo-trunk-r3091
Alberto Garcia [Mon, 27 Aug 2007 11:55:32 +0000 (11:55 +0000)]
* src/modest-search.c
Fix build problem caused by latest commit by murrayc
pmo-trunk-r3088
Armin Burgmeier [Mon, 27 Aug 2007 11:47:07 +0000 (11:47 +0000)]
2007-08-27 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
recursion when entering text in the subject field.
pmo-trunk-r3087
Murray Cumming [Mon, 27 Aug 2007 11:35:03 +0000 (11:35 +0000)]
2007-08-27 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: Added check_and_wait_for_account_is_online(),
which checks every second, 10 times, to wait until the account is online
so that we can use it, if the account is in the process of going online.
(modest_search_all_accounts): Use check_and_wait_for_account_is_online()
so that searching works even when the application was not yet started before.
This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
pmo-trunk-r3085
Alberto Garcia [Mon, 27 Aug 2007 11:06:28 +0000 (11:06 +0000)]
* src/modest-text-utils.c
Replaced unlocalised strings in message forwarding by
localised ones.
Fixes NB#63783
pmo-trunk-r3083
Vivek Sekar [Mon, 27 Aug 2007 10:53:16 +0000 (10:53 +0000)]
Week 35 Pre Release, added bug fixed in the week.
pmo-trunk-r3082
Peter Csaszar [Mon, 27 Aug 2007 10:36:31 +0000 (10:36 +0000)]
two small modification
pmo-trunk-r3080
Peter Csaszar [Mon, 27 Aug 2007 09:54:44 +0000 (09:54 +0000)]
fixes NB#64201
pmo-trunk-r3079
Dirk-Jan C. Binnema [Mon, 27 Aug 2007 09:21:49 +0000 (09:21 +0000)]
* small fix, this commit mainly for testing commit message delivery
pmo-trunk-r3078
Peter Csaszar [Mon, 27 Aug 2007 08:04:19 +0000 (08:04 +0000)]
fixes NB#66161 (dimming on Edit>SelectAll)
pmo-trunk-r3076
Dirk-Jan C. Binnema [Mon, 27 Aug 2007 07:00:14 +0000 (07:00 +0000)]
* cleaner version of the patch to make sure no double account-setup-wizards are
shown
* fixes a critical G-Warning in modest-window-mgr
* apparently also fixes: NB#66304
pmo-trunk-r3075
Sergio Villar Senin [Sun, 26 Aug 2007 09:28:28 +0000 (09:28 +0000)]
* Fixed a double-leak in the last commit
pmo-trunk-r3074
Peter Csaszar [Fri, 24 Aug 2007 19:12:13 +0000 (19:12 +0000)]
fixes NB#63872
pmo-trunk-r3073
Sergio Villar Senin [Fri, 24 Aug 2007 17:42:32 +0000 (17:42 +0000)]
* Fixed a hang when moving folders using the "Move to" dialog
* The "Move to" dialog show now the proper account
pmo-trunk-r3072
Sergio Villar Senin [Fri, 24 Aug 2007 16:58:16 +0000 (16:58 +0000)]
* Fixed a bug added with armin's commit 3066, the key need to be initialized
pmo-trunk-r3071
Javier Fernandez Garcia-Boente [Fri, 24 Aug 2007 14:09:39 +0000 (14:09 +0000)]
* Always check how many rows are selected before open it
using hardware select key.
* Fixes: NB#61649
pmo-trunk-r3068
Sergio Villar Senin [Fri, 24 Aug 2007 14:01:18 +0000 (14:01 +0000)]
* Renamed a function
* Added a new define for hildon-libs domain translation
* Fixes NB#65969
pmo-trunk-r3067
Armin Burgmeier [Fri, 24 Aug 2007 13:49:45 +0000 (13:49 +0000)]
2007-08-24 Armin Burgmeier <armin@openismus.com>
* src/modest-widget-memory.c: Always show the default account when the
application is started, as stated in the UI spec. This fixes
projects.maemo.org bug NB#66630.
pmo-trunk-r3066
Armin Burgmeier [Fri, 24 Aug 2007 12:44:29 +0000 (12:44 +0000)]
2007-08-24 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-platform.c:
(modest_platform_run_rename_folder_dialog): Use logical IDs instead of
english text for strings in the rename folder dialog, fixing
projects.maemo.org bug NB#66338.
pmo-trunk-r3065
Alberto Garcia [Fri, 24 Aug 2007 11:54:11 +0000 (11:54 +0000)]
* src/widgets/modest-main-window.h
* src/widgets/modest-main-window.c
(modest_main_window_transfer_mode_enabled):
Checks whether the main window is in transfer mode.
(set_toolbar_mode):
Checks dimming rules when changing toolbar mode
* src/modest-ui-dimming-rules.c
(modest_ui_dimming_rules_on_delete_folder):
Dim "delete folder" if the main window is in transfer mode
(_transfer_mode_enabled):
Added support for the main window
Fixes NB#64604
pmo-trunk-r3064
Sergio Villar Senin [Fri, 24 Aug 2007 11:50:01 +0000 (11:50 +0000)]
* Fixes NB@63545
pmo-trunk-r3063
Javier Fernandez Garcia-Boente [Fri, 24 Aug 2007 10:56:29 +0000 (10:56 +0000)]
* Review filter_row function in header-view to define a enumeration
for status private field. This new approach allows to define an
initial value avoiding to show false 'empty views' at first
time some folder is selected.
pmo-trunk-r3062
Dirk-Jan C. Binnema [Fri, 24 Aug 2007 07:29:46 +0000 (07:29 +0000)]
* automatically register the main window
* make sure only one ModestEasySetupWizardDialog instance can be alive at any time,
letting modest-easysetup-wizard.c keep track of that
* if the we're asked for a new instance, present the old one instead
Fixes: NB#66408, and all other cases where this could happen.
pmo-trunk-r3061
Sergio Villar Senin [Thu, 23 Aug 2007 18:47:24 +0000 (18:47 +0000)]
* Fixes NB#63313
pmo-trunk-r3060
Javier Fernandez Garcia-Boente [Thu, 23 Aug 2007 16:23:40 +0000 (16:23 +0000)]
* Check subfolders name on move-to operations.
* Fixes: NB#66403
pmo-trunk-r3059
Sergio Villar Senin [Thu, 23 Aug 2007 15:22:59 +0000 (15:22 +0000)]
* Reverting the last change because the specs allow to move a folder from a remote server to a local folder
pmo-trunk-r3058
Peter Csaszar [Thu, 23 Aug 2007 14:08:08 +0000 (14:08 +0000)]
fixes NB#63563
pmo-trunk-r3057
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 13:34:31 +0000 (13:34 +0000)]
* this fix should fix the crash mentioned int NB#65283, but the problem
probably remains.
pmo-trunk-r3056
Sergio Villar Senin [Thu, 23 Aug 2007 13:28:17 +0000 (13:28 +0000)]
* Fixes NB#66132
pmo-trunk-r3055
Peter Csaszar [Thu, 23 Aug 2007 13:14:29 +0000 (13:14 +0000)]
fixes NB#62700, NB#62963
pmo-trunk-r3054
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 12:52:38 +0000 (12:52 +0000)]
* add license headers where they were missings, fixes critical bug #64095
pmo-trunk-r3053
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 12:09:46 +0000 (12:09 +0000)]
* update to the latest UI spec; fixes critical bug NB#65536
pmo-trunk-r3052
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 11:51:24 +0000 (11:51 +0000)]
* update logical id, fixes critical NB#66450
pmo-trunk-r3051
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 11:42:51 +0000 (11:42 +0000)]
* get rid of a critical warning when moving a message;
this might help with NB#66471
pmo-trunk-r3050
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 11:41:49 +0000 (11:41 +0000)]
* get rid of warnings for a missing icon
pmo-trunk-r3049
Vivek Sekar [Thu, 23 Aug 2007 08:35:05 +0000 (08:35 +0000)]
Week 34 Release, added bug fixed in the week.
pmo-trunk-r3048
Peter Csaszar [Thu, 23 Aug 2007 06:27:53 +0000 (06:27 +0000)]
hildon_banner_... changed to modest_platform_...
pmo-trunk-r3047
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 17:10:10 +0000 (17:10 +0000)]
* Keep main-view window title as selected folder, avoiding
change it when each header is selected.
* Fixes: NB#61930
pmo-trunk-r3046
Peter Csaszar [Wed, 22 Aug 2007 14:26:34 +0000 (14:26 +0000)]
fixes NB#61800
pmo-trunk-r3045
Armin Burgmeier [Wed, 22 Aug 2007 14:07:16 +0000 (14:07 +0000)]
2007-08-22 Armin Burgmeier <armin@openismus.com>
* src/widgets/modest-account-view.c: Fix for bora by using
MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
latter seems not be used anymore.
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
minor optimizations.
* src/maemo/modest-main-window.c: Update menu items when the default
account changes so that the current default account is always bolded.
This fixes projects.maemo.org bug NB#66173.
pmo-trunk-r3044
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 12:10:41 +0000 (12:10 +0000)]
* Commneted Bullet format menu option and its
associated code in msg-edit window.
* Fixes: NB#62316
pmo-trunk-r3042
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 11:29:37 +0000 (11:29 +0000)]
* Remove Undo option from main-vew window Edit menu.
* Fixes: NB#62994
pmo-trunk-r3041
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 11:08:21 +0000 (11:08 +0000)]
* Add dimming rules to copy and paste operations.
Sepecial folders and root folders/accounts can not
be cut.
* Fixes: NB#66139
pmo-trunk-r3040
Vivek Sekar [Wed, 22 Aug 2007 09:29:27 +0000 (09:29 +0000)]
Week 34 pre release, added bug fixed in the week.
pmo-trunk-r3039
Peter Csaszar [Wed, 22 Aug 2007 07:36:31 +0000 (07:36 +0000)]
avoid some critical warning on d&d
pmo-trunk-r3038
Alberto Garcia [Tue, 21 Aug 2007 13:37:48 +0000 (13:37 +0000)]
* src/modest-ui-actions.c
(modest_ui_actions_on_send):
Don't ask confirmation if the body is empty as it can't be empty
anymore
* src/maemo/modest-msg-edit-window.c
(update_send_dimming):
(send_insensitive_press):
Check if the message body is empty too.
(body_changed):
New function called everytime the body is updated.
(init_window):
Register callback for "changed" event in the message body.
Fixes: NB#66115
pmo-trunk-r3037
Peter Csaszar [Tue, 21 Aug 2007 13:12:36 +0000 (13:12 +0000)]
fixes NB#66301
pmo-trunk-r3035
Alberto Garcia [Tue, 21 Aug 2007 12:00:58 +0000 (12:00 +0000)]
* src/modest-ui-actions.c
(modest_ui_actions_on_send):
Don't ask confirmation if the subject is empty as it can't be empty
anymore
* src/maemo/modest-msg-edit-window.c
(update_send_dimming):
New function to update the dimming of the send button and menu
entry, based on the old recpt_field_changed()
(recpt_field_changed):
(subject_field_changed):
Call update_send_dimming()
(send_insensitive_press):
Check whether the subject is empty or not in order to show the proper
notification
Fixes: NB#66112
pmo-trunk-r3031
Alberto Garcia [Tue, 21 Aug 2007 10:44:54 +0000 (10:44 +0000)]
* src/modest-ui-actions.c
(download_uncached_messages):
Removed reply_fwd parameter (not needed anymore).
When retrieving an e-mail, only ask for confirmation when the
device is offline.
(reply_forward):
(modest_ui_actions_on_copy):
Removed obsolete argument in call to download_uncached_messages()
Fixes NB#66066
pmo-trunk-r3030
Alberto Garcia [Tue, 21 Aug 2007 09:06:13 +0000 (09:06 +0000)]
* src/widgets/modest-global-settings-dialog-priv.h
* src/maemo/modest-maemo-global-settings-dialog.c
Removed include_reply variable and checkbox
* src/widgets/modest-global-settings-dialog.c
(_modest_global_settings_dialog_load_conf):
(get_current_settings):
(_modest_global_settings_dialog_save_conf):
(settings_changed):
Removed include_reply from the settings dialog.
Fixes NB#66193
pmo-trunk-r3029
Vivek Sekar [Tue, 21 Aug 2007 07:59:07 +0000 (07:59 +0000)]
Added bug fixes to changelog, week 34 aug 21st.
pmo-trunk-r3028
Alberto Garcia [Tue, 21 Aug 2007 07:47:35 +0000 (07:47 +0000)]
Removed backup file
pmo-trunk-r3027
Alberto Garcia [Mon, 20 Aug 2007 14:40:34 +0000 (14:40 +0000)]
* src/maemo/modest-progress-bar-widget.c
(modest_progress_bar_cancel_current_operation):
(modest_progress_bar_cancel_all_operations):
Don't show the "Session cancelled" info banner as it's deprecated.
Fixes NB#66135
pmo-trunk-r3018
Alberto Garcia [Fri, 17 Aug 2007 17:09:05 +0000 (17:09 +0000)]
* src/modest-tny-account-store.c
(get_smtp_specific_transport_account_for_open_connection):
Don't try to use a connection-specific SMTP server if the option
is disabled for that account
pmo-trunk-r3014
Murray Cumming [Fri, 17 Aug 2007 16:15:39 +0000 (16:15 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
(on_dbus_method_get_folders): Avoid trying to get the account name
when there are no accounts, to avoid critical g_warnings, fixing
projects.maemo.org bug NB#65574.
pmo-trunk-r3013
Murray Cumming [Fri, 17 Aug 2007 15:20:59 +0000 (15:20 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
Check for NULLs to prevent a crash when opening an email that is
an attachment in another email, fixing projects.maemo.org bug
NB#66012.
pmo-trunk-r3012
Murray Cumming [Fri, 17 Aug 2007 14:26:36 +0000 (14:26 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_view_window_move_to):
Enable the Move To toolbar button for search results, fixing the
last part of projects.maemo.org bug NB#63807.
pmo-trunk-r3011
Peter Csaszar [Fri, 17 Aug 2007 14:14:19 +0000 (14:14 +0000)]
There was a bug 60714 which was partially fixed by me in revision
2959. However the real problem was that once there was an update (by
folder selection or msg retrieval) in header-view for a folder whose
msg was shown in msg-view, the model referenced by msg-view was not
the same with the model in header-view. Because of this the dimming
for prev/next buttons could had not be synchronous with header-view.
There is an observer now. The observed is the meader-view and the
observer is the msg-view-window. The target is to detect if the
model of header-view is replaced. Another essential part is the
callback for row-insertions on the model. This can be found in
modest-msg-view-window.c file.
pmo-trunk-r3010
Alberto Garcia [Fri, 17 Aug 2007 12:51:13 +0000 (12:51 +0000)]
* src/modest-defs.h:
New gconf key: "use_specific_smtp"
* src/modest-account-mgr-helpers.h
* src/modest-account-mgr-helpers.c
(modest_account_mgr_get_has_connection_specific_smtp): removed
(modest_account_mgr_get_use_connection_specific_smtp):
(modest_account_mgr_set_use_connection_specific_smtp): New
functions to set and get the state of the use_specific_smtp
gconf key
* src/maemo/easysetup/modest-easysetup-wizard.c
(create_account):
Save the actual state of the "Use connection-specific SMTP
servers" checkbox in gconf
* src/maemo/modest-account-settings-dialog.c
(modest_account_settings_dialog_set_account_name):
(save_configuration):
Save and restore the actual state of the "Use
connection-specific SMTP server" checkbox in gconf
Fixes NB#65993
pmo-trunk-r3009
Dirk-Jan C. Binnema [Fri, 17 Aug 2007 12:09:00 +0000 (12:09 +0000)]
Added fixes for week 33 post release, 17th august.
pmo-trunk-r3008
Murray Cumming [Fri, 17 Aug 2007 10:24:08 +0000 (10:24 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
(check_and_offer_account_creation): Use gdk_thread_enter/leave(),
because this is called from idle handlers, to fix hangs afte the
wizard closes.
(find_message_by_url): Added a TODO comment about a crash that
happens when tinymail was built with DBC checks.
pmo-trunk-r3007
Murray Cumming [Thu, 16 Aug 2007 16:23:10 +0000 (16:23 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: (modest_search_folder):
* src/modest-search.h: Rename ModestSearch::before to start_date
and after to end_date, using the same names as the libogs struct
fields.
* src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
The start_date and end_date were swapped in the check. This
fixes date range searches, fixing projects.maemo.org bug NB#63407.
pmo-trunk-r3006
Murray Cumming [Thu, 16 Aug 2007 14:55:08 +0000 (14:55 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-msg-view-window.h:
* src/gnome/modest-msg-view-window.c:
* src/maemo/modest-msg-view-window.c:
Added modest_msg_view_window_construct().
(modest_msg_view_window_new_with_header_model),
Added modest_msg_view_window_new_for_search_result),
Renamed modest_msg_view_window_new() to
modest_msg_view_window_new_for_attachment(),
and modest_msg_view_window_is_search_result(),
so we can explicitly know that the window is for an
attachment or a search result or a message from the list.
(modest_msg_view_window_view_attachment):
* src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
Use modest_msg_view_window_new_for_search_result().
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_delete_msg): Dim the delete button
for search results, fixing projects.maemo.org bug NB#63811.
pmo-trunk-r3005
Armin Burgmeier [Thu, 16 Aug 2007 14:26:12 +0000 (14:26 +0000)]
2007-08-16 Armin Burgmeier <armin@openismus.com>
* src/modest-ui-actions.c: Show a banner instead of a dialog when
renaming a folder fails, to stay consistent with what happens when
creating a folder fails.
* src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
slightly country loading from the mmc_mappings file, fixed a memory
leak.
pmo-trunk-r3004
Murray Cumming [Thu, 16 Aug 2007 11:45:58 +0000 (11:45 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (volume_path_is_mounted):
Check the GnomeVFSVolume activation path instead of the device path,
so that the memory card is really really shown in the UI.
pmo-trunk-r3001
Murray Cumming [Thu, 16 Aug 2007 10:20:56 +0000 (10:20 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(get_entered_account_title), (on_before_next), (entry_is_empty),
(create_account):
* src/maemo/modest-account-settings-dialog.c:
(get_entered_account_title), (on_button_signature), (check_data),
(save_configuration), (entry_is_empty):
Strip the account title of whitespace at the start and end before
using it or checking it. This means that an all-whitespace title
is not allowed, fixing projects.maemo.org bug NB#64977.
pmo-trunk-r3000
Dirk-Jan C. Binnema [Thu, 16 Aug 2007 08:16:31 +0000 (08:16 +0000)]
Added known issues and fixed bugs, week 33 pre release - 16th Aug.
pmo-trunk-r2999